Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112989/#review45064 --- This review has been submitted with commit f3ac957d713585fd5dce0017d764468e80a1950e by Cristian Oneț to branch master. - Commit Hook On Sept. 29, 2013, 11:37 a.m., Cristian Oneț wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112989/ > --- > > (Updated Sept. 29, 2013, 11:37 a.m.) > > > Review request for KMymoney. > > > Bugs: 312816 > http://bugs.kde.org/show_bug.cgi?id=312816 > > > Repository: kmymoney > > > Description > --- > > Improve the resizing of the register and the transaction form. > > The transaction form was not correctly resizing the Value2 column > when the data of the KMyMoneyEdit exceeded the size of the widget. > The size of the push button (when present) was not considered when > the width was computed based on the cell text. > > The same issues were fixed when for the inline transaction editor. > > The register resizing was improved in the following ways: > - the number fields is no longer limited > - the details column can no longer be shrinked to a size smaller then > it's needed to render the data it contains > > BUG: 312816 > > > Diffs > - > > kmymoney/widgets/kmymoneydateinput.cpp > 856efaa9ddffcec7440cf3530349568d2c789333 > kmymoney/widgets/register.h 50ce7598783b49197de6acf4859a0fbd7c5c8962 > kmymoney/widgets/register.cpp d5dd63951d35b7098c0797fe64f10baf07a77fe1 > kmymoney/widgets/transactionform.cpp > 642e98f97eb98a14676186c296c1b27972f195cd > > Diff: http://git.reviewboard.kde.org/r/112989/diff/ > > > Testing > --- > > Ledger resize with/without the transaction form with multiple account types. > > > Thanks, > > Cristian Oneț > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 112989: Improve the resizing of the register and the transaction form.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112989/ --- (Updated Dec. 3, 2013, 9:33 p.m.) Status -- This change has been marked as submitted. Review request for KMymoney. Bugs: 312816 http://bugs.kde.org/show_bug.cgi?id=312816 Repository: kmymoney Description --- Improve the resizing of the register and the transaction form. The transaction form was not correctly resizing the Value2 column when the data of the KMyMoneyEdit exceeded the size of the widget. The size of the push button (when present) was not considered when the width was computed based on the cell text. The same issues were fixed when for the inline transaction editor. The register resizing was improved in the following ways: - the number fields is no longer limited - the details column can no longer be shrinked to a size smaller then it's needed to render the data it contains BUG: 312816 Diffs - kmymoney/widgets/kmymoneydateinput.cpp 856efaa9ddffcec7440cf3530349568d2c789333 kmymoney/widgets/register.h 50ce7598783b49197de6acf4859a0fbd7c5c8962 kmymoney/widgets/register.cpp d5dd63951d35b7098c0797fe64f10baf07a77fe1 kmymoney/widgets/transactionform.cpp 642e98f97eb98a14676186c296c1b27972f195cd Diff: http://git.reviewboard.kde.org/r/112989/diff/ Testing --- Ledger resize with/without the transaction form with multiple account types. Thanks, Cristian Oneț ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 312816] Resize ledger No. column
https://bugs.kde.org/show_bug.cgi?id=312816 Cristian Oneț changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/f3ac957d713585fd5dce00 ||17d764468e80a1950e --- Comment #16 from Cristian Oneț --- Git commit f3ac957d713585fd5dce0017d764468e80a1950e by Cristian Oneț. Committed on 29/09/2013 at 11:18. Pushed by conet into branch 'master'. Improve the resizing of the register and the transaction form. The transaction form was not correctly resizing the Value2 column when the data of the KMyMoneyEdit exceeded the size of the widget. The size of the push button (when present) was not considered when the width was computed based on the cell text. The same issues were fixed for the inline transaction editor. The register resizing was improved in the following ways: - the number fields is no longer limited - the details column can no longer be shrinked to a size smaller then it's needed to render the data it contains REVIEW: 112989 M +0-2kmymoney/widgets/kmymoneydateinput.cpp M +27 -26 kmymoney/widgets/register.cpp M +5-0kmymoney/widgets/register.h M +9-2kmymoney/widgets/transactionform.cpp http://commits.kde.org/kmymoney/f3ac957d713585fd5dce0017d764468e80a1950e -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
