[Kmymoney-devel] [kmymoney4] [Bug 272393] Crash while entering data if XIM input method is used

2014-01-03 Thread Fam.Hoogerwerf 
https://bugs.kde.org/show_bug.cgi?id=272393

--- Comment #25 from fam.hoogerw...@sunrise.ch ---
Thanks Thomas,

I built the version 4.6.4 stating from the TAR archive. I found it would 
have been helpful to have the command :
sudo apt-get build-dep kmymoney given in the README.cmake file. Now I 
only ran into it on the page:
http://www.linuxquestions.org/questions/debian-26/minimun-packages-required-to-build-kde-apps-kmymoney-856535/
 
after some struggle to get cmake to run. I have done a quick test and it 
appears the program works fine.

Thanks for your efforts.

Arno Hoogerwerf



On 01/03/2014 12:38 PM, Thomas Baumgart wrote:
> https://bugs.kde.org/show_bug.cgi?id=272393
>
> --- Comment #24 from Thomas Baumgart  ---
> (In reply to comment #23)
>> Created attachment 84422 [details]
>> New crash information added by DrKonqi
>>
>> kmymoney (4.6.1) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1
> This bug has been fixed in KMyMoney 4.6.4 and is therefor closed. Please
> upgrade and reopen only if the problem still persists.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-03 Thread Allan Anderson 


> On Jan. 4, 2014, 12:23 a.m., Allan Anderson wrote:
> >

An edit disappeared so...
Git commit 3422b775db80fd1956775eb94370c9e950f2b52e by Allan Anderson.
Committed on 24/10/2013 at 22:34.
Pushed by allananderson into branch 'master'.
Reinstate previous fix, allow memo field to be empty, and allow date to be
edited.

M  +1-1kmymoney/dialogs/investactivities.cpp
M  +2-0kmymoney/dialogs/investactivities.h
M  +19   -5kmymoney/dialogs/investtransactioneditor.cpp
M  +3-2kmymoney/dialogs/investtransactioneditor.h
M  +28   -5kmymoney/dialogs/transactioneditor.cpp
M  +4-0kmymoney/dialogs/transactioneditor.h

http://commits.kde.org/kmymoney/3422b775db80fd1956775eb94370c9e950f2b52e


- Allan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113427/#review46743
---


On Oct. 24, 2013, 11:06 p.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113427/
> ---
> 
> (Updated Oct. 24, 2013, 11:06 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 289351
> http://bugs.kde.org/show_bug.cgi?id=289351
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> There was a previous fix for this problem - Git commit 
> 9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, 
> this was inadvertently disabled when BUG:311481 REVIEW:107714 was committed.  
> This is now fixed.
> This review adds the same capability for investment transactions.
> In addition, there have been requests that when clearing the memo field, it 
> should when required be empty rather that containing a blank character.  It 
> is necessary to enter a character in the memo field in order to signal that 
> an edit has occurred, but now that character may then be deleted to leave the 
> field empty, if that is what is required.
> With investment transactions, it is always necessary to enter the security 
> name as well. This requirement could probably be removed, but it is probably 
> sensible to be editing just a single security.
> As with all editing of multiple items, all fields appear as blank initially. 
> This has been retained here with multiple memo editing, but if desired, this 
> could be changed and the field could be left showing previous content, which 
> could be more intuitive for a user wanting to have an empty field.
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/investactivities.h aa4800f 
>   kmymoney/dialogs/investactivities.cpp e4760e5 
>   kmymoney/dialogs/investtransactioneditor.h 20e3819 
>   kmymoney/dialogs/investtransactioneditor.cpp 805bd8d 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 71d94ec 
> 
> Diff: https://git.reviewboard.kde.org/r/113427/diff/
> 
> 
> Testing
> ---
> 
> Numerous groups of investment and checking transactions entered and edited 
> correctly.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-03 Thread Allan Anderson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113427/
---

(Updated Jan. 4, 2014, 12:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Bugs: 289351
http://bugs.kde.org/show_bug.cgi?id=289351


Repository: kmymoney


Description
---

There was a previous fix for this problem - Git commit 
9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, this 
was inadvertently disabled when BUG:311481 REVIEW:107714 was committed.  This 
is now fixed.
This review adds the same capability for investment transactions.
In addition, there have been requests that when clearing the memo field, it 
should when required be empty rather that containing a blank character.  It is 
necessary to enter a character in the memo field in order to signal that an 
edit has occurred, but now that character may then be deleted to leave the 
field empty, if that is what is required.
With investment transactions, it is always necessary to enter the security name 
as well. This requirement could probably be removed, but it is probably 
sensible to be editing just a single security.
As with all editing of multiple items, all fields appear as blank initially. 
This has been retained here with multiple memo editing, but if desired, this 
could be changed and the field could be left showing previous content, which 
could be more intuitive for a user wanting to have an empty field.


Diffs
-

  kmymoney/dialogs/investactivities.h aa4800f 
  kmymoney/dialogs/investactivities.cpp e4760e5 
  kmymoney/dialogs/investtransactioneditor.h 20e3819 
  kmymoney/dialogs/investtransactioneditor.cpp 805bd8d 
  kmymoney/dialogs/transactioneditor.h f07dafb 
  kmymoney/dialogs/transactioneditor.cpp 71d94ec 

Diff: https://git.reviewboard.kde.org/r/113427/diff/


Testing
---

Numerous groups of investment and checking transactions entered and edited 
correctly.


Thanks,

Allan Anderson

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-03 Thread Allan Anderson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113427/#review46743
---


- Allan Anderson


On Oct. 24, 2013, 11:06 p.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113427/
> ---
> 
> (Updated Oct. 24, 2013, 11:06 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 289351
> http://bugs.kde.org/show_bug.cgi?id=289351
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> There was a previous fix for this problem - Git commit 
> 9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, 
> this was inadvertently disabled when BUG:311481 REVIEW:107714 was committed.  
> This is now fixed.
> This review adds the same capability for investment transactions.
> In addition, there have been requests that when clearing the memo field, it 
> should when required be empty rather that containing a blank character.  It 
> is necessary to enter a character in the memo field in order to signal that 
> an edit has occurred, but now that character may then be deleted to leave the 
> field empty, if that is what is required.
> With investment transactions, it is always necessary to enter the security 
> name as well. This requirement could probably be removed, but it is probably 
> sensible to be editing just a single security.
> As with all editing of multiple items, all fields appear as blank initially. 
> This has been retained here with multiple memo editing, but if desired, this 
> could be changed and the field could be left showing previous content, which 
> could be more intuitive for a user wanting to have an empty field.
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/investactivities.h aa4800f 
>   kmymoney/dialogs/investactivities.cpp e4760e5 
>   kmymoney/dialogs/investtransactioneditor.h 20e3819 
>   kmymoney/dialogs/investtransactioneditor.cpp 805bd8d 
>   kmymoney/dialogs/transactioneditor.h f07dafb 
>   kmymoney/dialogs/transactioneditor.cpp 71d94ec 
> 
> Diff: https://git.reviewboard.kde.org/r/113427/diff/
> 
> 
> Testing
> ---
> 
> Numerous groups of investment and checking transactions entered and edited 
> correctly.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 289351] Editing mulitple transactions - cannot change Memo field

2014-01-03 Thread allan 
https://bugs.kde.org/show_bug.cgi?id=289351

allan  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kmym
   ||oney/3422b775db80fd1956775e
   ||b94370c9e950f2b52e

--- Comment #12 from allan  ---
Git commit 3422b775db80fd1956775eb94370c9e950f2b52e by Allan Anderson.
Committed on 24/10/2013 at 22:34.
Pushed by allananderson into branch 'master'.
Reinstate previous fix, allow memo field to be empty, and allow date to be
edited.

M  +1-1kmymoney/dialogs/investactivities.cpp
M  +2-0kmymoney/dialogs/investactivities.h
M  +19   -5kmymoney/dialogs/investtransactioneditor.cpp
M  +3-2kmymoney/dialogs/investtransactioneditor.h
M  +28   -5kmymoney/dialogs/transactioneditor.cpp
M  +4-0kmymoney/dialogs/transactioneditor.h

http://commits.kde.org/kmymoney/3422b775db80fd1956775eb94370c9e950f2b52e

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 114767: Add ability to modify loan institution attribute.

2014-01-03 Thread Jeremy Whiting 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114767/
---

(Updated Jan. 3, 2014, 4:27 p.m.)


Review request for KMymoney.


Changes
---

Updated as per review. All seems fine now except when editing closed accounts 
an exception is thrown that isn't caught. That may be the case when editing 
other selections also however.

Editing a loan's institution works right here now including showing "(No 
institution)" when no institution is assigned, etc.


Bugs: 257619
http://bugs.kde.org/show_bug.cgi?id=257619


Repository: kmymoney


Description (updated)
---

Add ability to modify loan institution attribute.

Add a new choice to editselectionwizardpage to modify only loan attributes.
Add a new loanattributes page to modify just institution for now, will add 
other attributes next.

BUG:257619
REVIEW:114767


Diffs (updated)
-

  kmymoney/wizards/newloanwizard/CMakeLists.txt 
939d569c2bba56ccfd3c9d6b28f8b90d414b9332 
  kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp 
e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5 
  kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui 
2e482c47f9a3642a880f0dcb047ca577c6e0446c 
  kmymoney/wizards/newloanwizard/keditloanwizard.cpp 
5590a359ffc16c92fc3dc24b6484aac1180b1507 
  kmymoney/wizards/newloanwizard/knewloanwizard.h 
6b3f049912605f4f9cb0e78ee83b14e2767586b8 
  kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui 
831d85ce388b51a904c76cd998f54ca6a099b347 
  kmymoney/wizards/newloanwizard/loanattributeswizardpage.h PRE-CREATION 
  kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp PRE-CREATION 
  kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114767/diff/


Testing
---

It works here to set and to show the current institution.


Thanks,

Jeremy Whiting

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 114767: Add ability to modify loan institution attribute.

2014-01-03 Thread Thomas Baumgart 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114767/#review46738
---


Looks very promising to me. Keep going.


kmymoney/wizards/newloanwizard/keditloanwizard.cpp


Trailing blanks



kmymoney/wizards/newloanwizard/keditloanwizard.cpp


In case it is equal to this special string, wouldn't the user expect the 
link to the institution go away?



kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp


I suggest to use "const MyMoneyInstitution&" as type in cases like this.


- Thomas Baumgart


On Jan. 3, 2014, 6:06 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114767/
> ---
> 
> (Updated Jan. 3, 2014, 6:06 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 257619
> http://bugs.kde.org/show_bug.cgi?id=257619
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Add ability to modify loan institution attribute.
> 
> Add a new choice to editselectionwizardpage to modify only loan attributes.
> Add a new loanattributes page to modify just institution for now, will add 
> other attributes next.
> 
> BUG:257619
> 
> 
> Diffs
> -
> 
>   kmymoney/wizards/newloanwizard/CMakeLists.txt 
> 939d569c2bba56ccfd3c9d6b28f8b90d414b9332 
>   kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp 
> e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5 
>   kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui 
> 2e482c47f9a3642a880f0dcb047ca577c6e0446c 
>   kmymoney/wizards/newloanwizard/keditloanwizard.cpp 
> 5590a359ffc16c92fc3dc24b6484aac1180b1507 
>   kmymoney/wizards/newloanwizard/knewloanwizard.h 
> 6b3f049912605f4f9cb0e78ee83b14e2767586b8 
>   kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui 
> 831d85ce388b51a904c76cd998f54ca6a099b347 
>   kmymoney/wizards/newloanwizard/loanattributeswizardpage.h PRE-CREATION 
>   kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp PRE-CREATION 
>   kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114767/diff/
> 
> 
> Testing
> ---
> 
> It works here to set and to show the current institution.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 114767: Add ability to modify loan institution attribute.

2014-01-03 Thread Jeremy Whiting 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114767/
---

(Updated Jan. 3, 2014, 10:06 a.m.)


Review request for KMymoney.


Changes
---

Updated as per review. One more thing is missing however, if I edit a loan that 
has been closed, the finish button is throwing an exception because the loan's 
schedule is invalid or something. I guess I need to change what happens in the 
finish a bit also.


Bugs: 257619
http://bugs.kde.org/show_bug.cgi?id=257619


Repository: kmymoney


Description (updated)
---

Add ability to modify loan institution attribute.

Add a new choice to editselectionwizardpage to modify only loan attributes.
Add a new loanattributes page to modify just institution for now, will add 
other attributes next.

BUG:257619


Diffs (updated)
-

  kmymoney/wizards/newloanwizard/CMakeLists.txt 
939d569c2bba56ccfd3c9d6b28f8b90d414b9332 
  kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp 
e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5 
  kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui 
2e482c47f9a3642a880f0dcb047ca577c6e0446c 
  kmymoney/wizards/newloanwizard/keditloanwizard.cpp 
5590a359ffc16c92fc3dc24b6484aac1180b1507 
  kmymoney/wizards/newloanwizard/knewloanwizard.h 
6b3f049912605f4f9cb0e78ee83b14e2767586b8 
  kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui 
831d85ce388b51a904c76cd998f54ca6a099b347 
  kmymoney/wizards/newloanwizard/loanattributeswizardpage.h PRE-CREATION 
  kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp PRE-CREATION 
  kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114767/diff/


Testing
---

It works here to set and to show the current institution.


Thanks,

Jeremy Whiting

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 272393] Crash while entering data if XIM input method is used

2014-01-03 Thread Thomas Baumgart 
https://bugs.kde.org/show_bug.cgi?id=272393

--- Comment #24 from Thomas Baumgart  ---
(In reply to comment #23)
> Created attachment 84422 [details]
> New crash information added by DrKonqi
> 
> kmymoney (4.6.1) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1

This bug has been fixed in KMyMoney 4.6.4 and is therefor closed. Please
upgrade and reopen only if the problem still persists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 272393] Crash while entering data if XIM input method is used

2014-01-03 Thread Fam.Hoogerwerf 
https://bugs.kde.org/show_bug.cgi?id=272393

--- Comment #23 from fam.hoogerw...@sunrise.ch ---
Created attachment 84422
  --> https://bugs.kde.org/attachment.cgi?id=84422&action=edit
New crash information added by DrKonqi

kmymoney (4.6.1) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1

- What I was doing when the application crashed: Entering a new ledger entry. 
- Just upgraded to Linux Kernel 3.8.0. 
- Re-installing KMyMoney with the UIbuntu Software Center doesn't help.

-- Backtrace (Reduced):
#6  0x7f9b596e163f in QWidget::testAttribute_helper (this=0x35da3c0,
attribute=Qt::WA_WState_Created) at kernel/qwidget.cpp:11034
#7  0x7f9b596e264a in testAttribute (attribute=Qt::WA_WState_Created,
this=0x35da3c0) at ../../include/QtGui/../../src/gui/kernel/qwidget.h:1042
#8  QWidget::effectiveWinId (this=0x35da3c0) at kernel/qwidget.cpp:2610
#9  0x7f9b59c728ed in QXIMInputContext::reset (this=0x1f35240) at
inputmethod/qximinputcontext_x11.cpp:579
#10 0x7f9b59c74073 in QXIMInputContext::setFocusWidget (this=0x1f35240,
w=0x0) at inputmethod/qximinputcontext_x11.cpp:649

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel