Re: [Kmymoney-devel] Overly wide Details column in ledger
Hi all, On Monday 06 January 2014 10:26:04 Cristian Oneț wrote: 2013/12/26 Thomas Baumgart t...@net-bembel.de: Hi all, On Thursday 05 December 2013 08:27:36 Cristian Oneț wrote: It's definitely caused by this commit [1]. I'll check if it can be caused by whitespace as Allan suggests, then that case can be solved. But if you have a really long details string in some transaction then I guess the scrollbar is appropriate. Not sure. I do see a scrollbar here, but using it jumps by the column and not smooth (maybe just another setting for the widget that is missing). The problem Marko sees is caused by the following change at the very end of void Register::resize(int col, bool force) from: setColumnWidth(col, w); to:setColumnWidth(col, qMax(w, minimumColumnWidth(col))); While I agree with all the other changes contained in this commit, this one annoys me, as it is mostly due to wide memo fields. I do give an example that I have here (and displaying that all in one line is just nonsense): SEPA-BASISLASTSCHRIFT EREF+ B##V# 41 MREF+ - CRED+ DE36ZZZ### S VWZ+ sonstige Zahlung KNR:2 ##/faellig 13.11.20 13 Netto ##,##faellig 13.11.2013 Netto ##,## That's 205 chars. Even if using the full 1920 width I cannot display all of the above on the screen. My feeling here is that we need a more modern widget to display all of the transaction data. It should certainly be based on the MVD model which gives us more control over things than we have today. I would really like to revert that one line shown above to what it was before but want to hear some comments from others before (esp. Crisitan who made the change). Hi Thomas, Sorry for the late reply, I was away for a few weeks. The current behavior annoys me as well so please improve it (or revert it). I intended to but haven't had time to do so. By improvement I would suggest improving the value returned by minimumColumnWidth(col) for the details column or you can just revert it if you think this approach would not work in all cases. Reverted that one change back to the original. That should solve the annoyance while keeping the other improvements. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - I can break things just fine by myself, I don't need (KDE) 4.2 to help me. -- Bill Suit - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 114352: Bug 312816 - Fine tune the resizing of the register and the transaction form.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114352/ --- (Updated Jan. 7, 2014, 11:28 a.m.) Status -- This change has been discarded. Review request for KMymoney and Cristian Oneț. Bugs: 312816 http://bugs.kde.org/show_bug.cgi?id=312816 Repository: kmymoney Description --- This patch extends the code of REVIEW: 112989, and as I cannot add a patch to Cristian's review request, I have raised a new request. a) When an account is loaded, the columns for the kMyMoneyEdit fields have extra white-space, to allow for the calculator and date buttons, but these buttons won't appear until editing starts. This happens because m_usedWithEditor was being enabled in KGlobalLedgerView ctor. I've changed this so m_usedWithEditor is enabled instead in KGlobalLedgerView::startEdit() and reset in KGlobalLedgerView::slotLeaveEditMode(). b) When a transaction is opened for editing, the above columns are widened for the buttons. However, this window widening is not helped by potentially surplus white-space appearing in the Description column. This can frequently happen if the memo text is wide and possibly originally multi-line. When not editing, the multi-lines are combined into a wider field, but the multi-lines are restored when editing but the Details column does not notice this, so retains its full width. I've remedied this by reducing the width to that of the widest sub-string. Diffs - kmymoney/views/kgloballedgerview.cpp 000393c kmymoney/widgets/register.cpp 56bf46d Diff: https://git.reviewboard.kde.org/r/114352/diff/ Testing --- Much resizing of many checking and investment accounts, both while in edit mode and not. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Typos - erronous is erroneous
There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
On 07/01/14 12:26, Cristian Oneț wrote: 2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian I'll do all those in strings first, then do the rest carefully, testing as I go. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
On 07/01/14 12:26, Cristian Oneț wrote: 2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian I've corrected all the strings, but I'm not sure I understand your comment. Sorry to pester, but I don't want to screw up. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
Hi, On Tuesday 07 January 2014 12:41:17 Allan wrote: On 07/01/14 12:26, Cristian Oneț wrote: 2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian I'll do all those in strings first, then do the rest carefully, testing as I go. I did a quick analysis on this. Here are my findings which be of help. git grep -i erronous showed 122 occurrences, among which only the ones in kmymoney/dialogs/settings/ksettingscolorsdecl.ui and kmymoney/kmymoney.kcfg referring listErronousTransactionColor are a bit tricky. They are also found in register.cpp and kmymoney/widgets/transaction.cpp as KMyMoneyGlobalSettings::listErronousTransactionColor(). Changing those has only one side-effect: in case the user has modified the standard color in his settings they will be lost. I don't think that this is critical, as the user can change it again. Most of the others are in the following comment An exception will be thrown upon erronous situations. a probably the result of copy/paste. All others remaining seem to reference only internal variables. So I don't see a problem to change them either. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - The only 'intuitive' interface is the nipple. After that, it's all learned. -- Bruce Ediger, bedi...@teal.csn.org, on X interfaces - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
Hi, On Tuesday 07 January 2014 13:12:14 Allan wrote: On 07/01/14 12:26, Cristian Oneț wrote: 2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian I've corrected all the strings, but I'm not sure I understand your comment. Sorry to pester, but I don't want to screw up. I think Cristian is referring to the spelling of occurence in the (XML) data file. That cannot easily be changed. Erroneous is not part of the data file (only the configuration as I described in my earlier post). So there should be no problem with what you do. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - Having trouble with Windows? Reboot! Having trouble with Linux? Be root! - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Typos - erronous is erroneous
On 07/01/14 14:18, Thomas Baumgart wrote: Hi, On Tuesday 07 January 2014 13:12:14 Allan wrote: On 07/01/14 12:26, Cristian Oneț wrote: 2014/1/7 Allan agande...@gmail.com: There is a large number of these typos which keep catching my eye, and also affect searches. They mainly occur in strings, but quite a few in code. Is there any reason why I should not fix this? I would probably do it in batches, like per file, to limit the potential for damage. Typos can be fixed but be aware that there are some typos in the file format which should not be fixed unless a format upgrade action is added. Regards, Cristian I've corrected all the strings, but I'm not sure I understand your comment. Sorry to pester, but I don't want to screw up. I think Cristian is referring to the spelling of occurence in the (XML) data file. That cannot easily be changed. Erroneous is not part of the data file (only the configuration as I described in my earlier post). So there should be no problem with what you do. OK, thanks, Thomas. I'll just have a look into that one later, so I know the issue. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] endModalSession problem
Hi Marko, On Tuesday 07 January 2014 20:23:49 mk-li...@email.de wrote: Hi devs, I found some lines like this in my logs: --- kmymoney[550]: modalSession has been exited prematurely - check for a reentrant call to endModalSession: — Is this something to worry about? Don't know. It's not something that comes directly from KMyMoney. Which backend do you use? -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - When PRIVACY Is Outlawed... Only OUTLAWS Will Have Privacy! - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 296883] OFX and QIF import of investment Buy / Sell transactions not assigned to brokerage account
https://bugs.kde.org/show_bug.cgi?id=296883 --- Comment #4 from Jack ostrof...@users.sourceforge.net --- I confirm this in 4.6.3 with OFX, even if the brokerage account name is set to the default of the investment account name followed by ' (brokerage)'. However, editing the imported transaction and specifying the brokerage account does fix the transaction - leaving a correctly incremented number of shares and the correct purchase price deducted from the brokerage account. Interestingly, when I hover over the transaction in the ledger, the error is missing category, which might technically be correct, but that terminology seems to apply to a normal transaction not to an investment transaction. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 329701] New: Let user specify the name of the brokerage account for an investment account
https://bugs.kde.org/show_bug.cgi?id=329701 Bug ID: 329701 Summary: Let user specify the name of the brokerage account for an investment account Classification: Unclassified Product: kmymoney4 Version: 4.6.4 Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: ostrof...@users.sourceforge.net When creating an investment account, KMM currently offers to create the associated investment account, which is given the same name as the investment account, followed by ' (brokerage)'. If the user accepts that name, then it will be used as the default brokerage account in the appropriate investment transactions. However, if you change the name, or want to specify another already existing account (such as checking) as the brokerage account, KMM does not remember it, and you have to explicitly specify it every time it is needed. I would prefer that KMM actually remember the name of the brokerage account as part of the investment account configuration. For example, I would prefer to use Merrill Lynch - invest and Merrill Lynch - brokerage instead of Merrill Lynch and Merrill Lynch (brokerage) as names for the pair of accounts. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 329706] New: bugreport
https://bugs.kde.org/show_bug.cgi?id=329706 Bug ID: 329706 Summary: bugreport Classification: Unclassified Product: kmymoney4 Version: unspecified Platform: unspecified OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: mickey...@gmail.com attempting to report a bug, thr bugreporter crashed! -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 329706] bugreport
https://bugs.kde.org/show_bug.cgi?id=329706 --- Comment #1 from Jack ostrof...@users.sourceforge.net --- If you want help, you need to provide a bit more information. Perhaps your browser crashed and not bugs.kde.org? (You can either click the link to go the bugs.kde.org, or just reply to this email, and your response will get posted to the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
