Re: [Kmymoney-devel] Review Request 115338: Fix loosing track of check number if check number sequence is interrupted.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115338/#review50037 --- This review has been submitted with commit 0a3ef042a8bd7494c5bae192e76a1818beb5c96f by Allan Anderson to branch master. - Commit Hook On Jan. 27, 2014, 5:33 p.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115338/ > --- > > (Updated Jan. 27, 2014, 5:33 p.m.) > > > Review request for KMymoney. > > > Bugs: 319801 > http://bugs.kde.org/show_bug.cgi?id=319801 > > > Repository: kmymoney > > > Description > --- > > Follow-up patch on https://git.reviewboard.kde.org/r/115302/, > to fix handling of number field. > There was no check that a new 'next number' did not already exist. For > instance, if there is the sequence 22,23,24, and the user entered a new > transaction numbered 21, the 'next number' would have been 22, which already > exists. > Deletion of a numered transaction would produce an incorrect next number. > An edit of an existing number was not saved. > These issues, which exist also in the stable release, have been fixed. > (new Reviewboard item raised for this part, on suggestion of Thomas Baumgart). > > > Diffs > - > > kmymoney/kmymoneyutils.cpp e89528e > kmymoney/kmymoneyutils.h a899121 > kmymoney/kmymoney.cpp 7a2fd4f > kmymoney/dialogs/transactioneditor.cpp 3c148d8 > kmymoney/dialogs/transactioneditor.h db86832 > > Diff: https://git.reviewboard.kde.org/r/115338/diff/ > > > Testing > --- > > Numerous manual test cases run. Unit tests run. > > > Thanks, > > Allan Anderson > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 115338: Fix loosing track of check number if check number sequence is interrupted.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115338/ --- (Updated Feb. 17, 2014, 1:08 p.m.) Status -- This change has been marked as submitted. Review request for KMymoney. Bugs: 319801 http://bugs.kde.org/show_bug.cgi?id=319801 Repository: kmymoney Description --- Follow-up patch on https://git.reviewboard.kde.org/r/115302/, to fix handling of number field. There was no check that a new 'next number' did not already exist. For instance, if there is the sequence 22,23,24, and the user entered a new transaction numbered 21, the 'next number' would have been 22, which already exists. Deletion of a numered transaction would produce an incorrect next number. An edit of an existing number was not saved. These issues, which exist also in the stable release, have been fixed. (new Reviewboard item raised for this part, on suggestion of Thomas Baumgart). Diffs - kmymoney/kmymoneyutils.cpp e89528e kmymoney/kmymoneyutils.h a899121 kmymoney/kmymoney.cpp 7a2fd4f kmymoney/dialogs/transactioneditor.cpp 3c148d8 kmymoney/dialogs/transactioneditor.h db86832 Diff: https://git.reviewboard.kde.org/r/115338/diff/ Testing --- Numerous manual test cases run. Unit tests run. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 319801] program looses track of check number if check number sequence is interrupted. (EDIT) Also, if a check number is later edited, the new value is lost.
https://bugs.kde.org/show_bug.cgi?id=319801 allan changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/1dede8b9dfb550b3a26e4f |oney/0a3ef042a8bd7494c5bae1 |c0ade208788c877b2c |92e76a1818beb5c96f --- Comment #8 from allan --- Git commit 0a3ef042a8bd7494c5bae192e76a1818beb5c96f by Allan Anderson. Committed on 27/01/2014 at 11:09. Pushed by allananderson into branch 'master'. Related: bug 2 REVIEW:115338 M +43 -12 kmymoney/dialogs/transactioneditor.cpp M +10 -0kmymoney/kmymoney.cpp M +58 -0kmymoney/kmymoneyutils.cpp M +14 -0kmymoney/kmymoneyutils.h http://commits.kde.org/kmymoney/0a3ef042a8bd7494c5bae192e76a1818beb5c96f -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 288308] Forecast -> Detail Tab Results display could be optimized...
https://bugs.kde.org/show_bug.cgi?id=288308 --- Comment #11 from allan --- Oops. Apologies, my hopes got the better of me. One day, I might try a screen-shot of the headings and drag into place. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 288308] Forecast -> Detail Tab Results display could be optimized...
https://bugs.kde.org/show_bug.cgi?id=288308 --- Comment #10 from Alvaro Soliverez --- This if for the forecast view, not reports. Reports require a rewrite to support such features. Nowadays they are plain HTML. On Mon, Feb 17, 2014 at 8:11 AM, allan wrote: > https://bugs.kde.org/show_bug.cgi?id=288308 > > allan changed: > >What|Removed |Added > > CC||agande...@gmail.com > > --- Comment #9 from allan --- > A bit off-topic from this bug, but might there be a similar feature possible > for 'frozen row headings'? I did query this quite some while ago, as a way > to > avoid the row headings scrolling out of sight on say the investment reports > with several investments. > > If so I'll do a wishlist. > > -- > You are receiving this mail because: > You are the assignee for the bug. > ___ > KMyMoney-devel mailing list > KMyMoney-devel@kde.org > https://mail.kde.org/mailman/listinfo/kmymoney-devel -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] [kmymoney4] [Bug 288308] Forecast -> Detail Tab Results display could be optimized...
This if for the forecast view, not reports. Reports require a rewrite to support such features. Nowadays they are plain HTML. On Mon, Feb 17, 2014 at 8:11 AM, allan wrote: > https://bugs.kde.org/show_bug.cgi?id=288308 > > allan changed: > >What|Removed |Added > > CC||agande...@gmail.com > > --- Comment #9 from allan --- > A bit off-topic from this bug, but might there be a similar feature possible > for 'frozen row headings'? I did query this quite some while ago, as a way > to > avoid the row headings scrolling out of sight on say the investment reports > with several investments. > > If so I'll do a wishlist. > > -- > You are receiving this mail because: > You are the assignee for the bug. > ___ > KMyMoney-devel mailing list > KMyMoney-devel@kde.org > https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 288308] Forecast -> Detail Tab Results display could be optimized...
https://bugs.kde.org/show_bug.cgi?id=288308 allan changed: What|Removed |Added CC||agande...@gmail.com --- Comment #9 from allan --- A bit off-topic from this bug, but might there be a similar feature possible for 'frozen row headings'? I did query this quite some while ago, as a way to avoid the row headings scrolling out of sight on say the investment reports with several investments. If so I'll do a wishlist. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
