Re: [Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.
> On Sept. 18, 2014, 6:57 p.m., Cristian Oneț wrote: > > It fixes the reported problem. Don't forget to add the 'BUG: NR' and > > 'REVIEW: NR' markers in the commit message (each on it's own line). > > Allan Anderson wrote: > Good. Did you notice specifically the behaviour of the radio buttons? The radio buttons work. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/#review66860 --- On Sept. 18, 2014, 11:49 a.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120260/ > --- > > (Updated Sept. 18, 2014, 11:49 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > I've been working for a while on improving the appearance and operation of > the CSV importer plugin, which has gone far more slowly than I expected. > In the meantime, a new version of KMyMoney has been released for Windows, and > two users have reported the known problem of buttons at the foot of the > plugin page not appearing fully. Plus, a difficulty with the start page > radio buttons. So, there is more urgency now, and I've extracted the > reworked UI files, and made a patch which includes them, with a needed small > change to the code handling the UI. Also, there is a small fix for > occasional crashes related to decimal symbol handling. This is based on the > current HEAD. Otherwise, the UI looks much like the HEAD version, apart from > the correct visibility of the buttons. > I am still working on improving other parts of the plugin > > > Diffs > - > > kmymoney/plugins/csvimport/separatorwizardpage.ui 30b2dc7 > kmymoney/plugins/csvimport/csvdialog.cpp 7e0229b > kmymoney/plugins/csvimport/csvdialog.ui 36e7fd5 > kmymoney/plugins/csvimport/csvutil.h 546bfa5 > kmymoney/plugins/csvimport/csvutil.cpp 4c0dd25 > kmymoney/plugins/csvimport/introwizardpage.ui 9bd29f5 > kmymoney/plugins/csvimport/investmentwizardpage.ui 3744963 > kmymoney/plugins/csvimport/investprocessing.h 55dd4ca > kmymoney/plugins/csvimport/investprocessing.cpp c21c679 > kmymoney/plugins/csvimport/lines-datewizardpage.ui fb10a0e > kmymoney/plugins/csvimport/bankingwizardpage.ui d2179bf > kmymoney/plugins/csvimport/completionwizardpage.ui 99db075 > kmymoney/plugins/csvimport/csvdialog.h b9d4527 > > Diff: https://git.reviewboard.kde.org/r/120260/diff/ > > > Testing > --- > > I've tested the patch on Linux Mint and Ubuntu, with a large number of > different files. > I am not able to test on Windows, having only XP. > I don't know if these changes help with the radio button issue on Windows, as > I am not able to reproduce the problem here, the radio, and all other, > buttons work as expected. > > > Thanks, > > Allan Anderson > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 337208] Security names after a security with a missing trading symbol are replaced by that symbol.
https://bugs.kde.org/show_bug.cgi?id=337208 --- Comment #4 from geo...@wildturkeyranch.net --- (In reply to allan from comment #1) > In case there are any other features in your file that influence the > reported behaviour, it would be very helpful if you could provide a simple > file, obviously with sensitive data disguised, as long as it still exhibits > the problem. > Either attach it to the bug report (see 'Add an attachment') just above > Additional comments, or send direct to me. > It is a requirement in KMyMoney that all securities have a symbol, as that > is/should be its unique reference within the program. This is not really a > bug, but you could change this to a wishlist item (under Severity) I have edited ../kmymoney/converter/mymoneystatementreader.cpp to fix this problem. I do believe it is important to allow the match to be just on the security name as not all securities will have symbols. When KMM advances to handle derivitives this will be needed. I can send a patch or try to submit via git. What do you suggest? -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 339192] New: OFX download leaves "Missing assignment" Edit requries change to Enter.
https://bugs.kde.org/show_bug.cgi?id=339192 Bug ID: 339192 Summary: OFX download leaves "Missing assignment" Edit requries change to Enter. Product: kmymoney4 Version: git master Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: geo...@wildturkeyranch.net After an OFX download to an investment account Dividend (and possibly other) transactions are flagged with the ! diamond and the message "Transation has a missing assigment of ...". If I attempt to fix this by editing the transaction, the editor fills in the required "Account" information by default, however the "Enter" button is grayed out until some change is made (even adding a blank and backspace after the default entry). I think two things are at fault here: 1. The "Brokerage" account should have been filled in in the origional download, and 2. If the "edit" code is going to supply a default (and I think it should), it should allow immeadiat entry. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Question on new investment account
But the only balance in an investment account is number of shares, not dollars. I can see allowing a starting number of shares when creating a security or adding a security to an investment account. Cristian Oneț wrote: >I guess that by allowing an opening balance a user can start tracking >an already existing account without caring about historic >transactions. > >Regards, >Cristian > >2014-09-18 19:04 GMT+03:00 Jack : >> For some of the testing I've done recently, I created a new Investment >> account, and noticed that it is possible to specify an opening balance. >> This is the Investment account, not the Brokerage account. Since the only >> content of an Investment account should be Securities, this seems wrong to >> me. Is there a reason for this that I don't understand, or is it just an >> unintended consequence of the reusing code for multiple types of accounts? >> It's clearly not very important, but it got me curious. >> >> Jack >> ___ >> KMyMoney-devel mailing list >> KMyMoney-devel@kde.org >> https://mail.kde.org/mailman/listinfo/kmymoney-devel >___ >KMyMoney-devel mailing list >KMyMoney-devel@kde.org >https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.
> On Sept. 18, 2014, 6:57 p.m., Cristian Oneț wrote: > > It fixes the reported problem. Don't forget to add the 'BUG: NR' and > > 'REVIEW: NR' markers in the commit message (each on it's own line). Good. Did you notice specifically the behaviour of the radio buttons? - Allan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/#review66860 --- On Sept. 18, 2014, 11:49 a.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120260/ > --- > > (Updated Sept. 18, 2014, 11:49 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > I've been working for a while on improving the appearance and operation of > the CSV importer plugin, which has gone far more slowly than I expected. > In the meantime, a new version of KMyMoney has been released for Windows, and > two users have reported the known problem of buttons at the foot of the > plugin page not appearing fully. Plus, a difficulty with the start page > radio buttons. So, there is more urgency now, and I've extracted the > reworked UI files, and made a patch which includes them, with a needed small > change to the code handling the UI. Also, there is a small fix for > occasional crashes related to decimal symbol handling. This is based on the > current HEAD. Otherwise, the UI looks much like the HEAD version, apart from > the correct visibility of the buttons. > I am still working on improving other parts of the plugin > > > Diffs > - > > kmymoney/plugins/csvimport/separatorwizardpage.ui 30b2dc7 > kmymoney/plugins/csvimport/csvdialog.cpp 7e0229b > kmymoney/plugins/csvimport/csvdialog.ui 36e7fd5 > kmymoney/plugins/csvimport/csvutil.h 546bfa5 > kmymoney/plugins/csvimport/csvutil.cpp 4c0dd25 > kmymoney/plugins/csvimport/introwizardpage.ui 9bd29f5 > kmymoney/plugins/csvimport/investmentwizardpage.ui 3744963 > kmymoney/plugins/csvimport/investprocessing.h 55dd4ca > kmymoney/plugins/csvimport/investprocessing.cpp c21c679 > kmymoney/plugins/csvimport/lines-datewizardpage.ui fb10a0e > kmymoney/plugins/csvimport/bankingwizardpage.ui d2179bf > kmymoney/plugins/csvimport/completionwizardpage.ui 99db075 > kmymoney/plugins/csvimport/csvdialog.h b9d4527 > > Diff: https://git.reviewboard.kde.org/r/120260/diff/ > > > Testing > --- > > I've tested the patch on Linux Mint and Ubuntu, with a large number of > different files. > I am not able to test on Windows, having only XP. > I don't know if these changes help with the radio button issue on Windows, as > I am not able to reproduce the problem here, the radio, and all other, > buttons work as expected. > > > Thanks, > > Allan Anderson > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/#review66860 --- Ship it! It fixes the reported problem. Don't forget to add the 'BUG: NR' and 'REVIEW: NR' markers in the commit message (each on it's own line). - Cristian Oneț On Sept. 18, 2014, 11:49 a.m., Allan Anderson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120260/ > --- > > (Updated Sept. 18, 2014, 11:49 a.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > I've been working for a while on improving the appearance and operation of > the CSV importer plugin, which has gone far more slowly than I expected. > In the meantime, a new version of KMyMoney has been released for Windows, and > two users have reported the known problem of buttons at the foot of the > plugin page not appearing fully. Plus, a difficulty with the start page > radio buttons. So, there is more urgency now, and I've extracted the > reworked UI files, and made a patch which includes them, with a needed small > change to the code handling the UI. Also, there is a small fix for > occasional crashes related to decimal symbol handling. This is based on the > current HEAD. Otherwise, the UI looks much like the HEAD version, apart from > the correct visibility of the buttons. > I am still working on improving other parts of the plugin > > > Diffs > - > > kmymoney/plugins/csvimport/separatorwizardpage.ui 30b2dc7 > kmymoney/plugins/csvimport/csvdialog.cpp 7e0229b > kmymoney/plugins/csvimport/csvdialog.ui 36e7fd5 > kmymoney/plugins/csvimport/csvutil.h 546bfa5 > kmymoney/plugins/csvimport/csvutil.cpp 4c0dd25 > kmymoney/plugins/csvimport/introwizardpage.ui 9bd29f5 > kmymoney/plugins/csvimport/investmentwizardpage.ui 3744963 > kmymoney/plugins/csvimport/investprocessing.h 55dd4ca > kmymoney/plugins/csvimport/investprocessing.cpp c21c679 > kmymoney/plugins/csvimport/lines-datewizardpage.ui fb10a0e > kmymoney/plugins/csvimport/bankingwizardpage.ui d2179bf > kmymoney/plugins/csvimport/completionwizardpage.ui 99db075 > kmymoney/plugins/csvimport/csvdialog.h b9d4527 > > Diff: https://git.reviewboard.kde.org/r/120260/diff/ > > > Testing > --- > > I've tested the patch on Linux Mint and Ubuntu, with a large number of > different files. > I am not able to test on Windows, having only XP. > I don't know if these changes help with the radio button issue on Windows, as > I am not able to reproduce the problem here, the radio, and all other, > buttons work as expected. > > > Thanks, > > Allan Anderson > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Question on new investment account
I guess that by allowing an opening balance a user can start tracking an already existing account without caring about historic transactions. Regards, Cristian 2014-09-18 19:04 GMT+03:00 Jack : > For some of the testing I've done recently, I created a new Investment > account, and noticed that it is possible to specify an opening balance. > This is the Investment account, not the Brokerage account. Since the only > content of an Investment account should be Securities, this seems wrong to > me. Is there a reason for this that I don't understand, or is it just an > unintended consequence of the reusing code for multiple types of accounts? > It's clearly not very important, but it got me curious. > > Jack > ___ > KMyMoney-devel mailing list > KMyMoney-devel@kde.org > https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Question on new investment account
For some of the testing I've done recently, I created a new Investment account, and noticed that it is possible to specify an opening balance. This is the Investment account, not the Brokerage account. Since the only content of an Investment account should be Securities, this seems wrong to me. Is there a reason for this that I don't understand, or is it just an unintended consequence of the reusing code for multiple types of accounts? It's clearly not very important, but it got me curious. Jack ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.
> On Sept. 12, 2014, 12:10 p.m., Allan Anderson wrote: > > I've confirmed that when the OFX file (produced from the logfile) is > > imported into a checking account, the sign now is correct. > > I've also imported a number of my own non-OFX files and they too are OK. > > I'm not an OFX user, and I'm assuming that the second half of the file is > > informational and not for import. > > Cristian Oneț wrote: > Thanks, then somebody using OFX to import investment transactions should > check this patch, anybody up fo the task? Sorry it took so long, but I can confirm that with the patch, the .01 imports as a deposit. The second half of the file does look informational, and I suppose in an ideal world, it might be imported either just for informational display or perhaps to confirm balances, but ignoring it for now seems correct. - Jack --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120153/#review66338 --- On Sept. 12, 2014, 6:25 a.m., Cristian Oneț wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120153/ > --- > > (Updated Sept. 12, 2014, 6:25 a.m.) > > > Review request for KMymoney and Allan Anderson. > > > Bugs: 333522 > http://bugs.kde.org/show_bug.cgi?id=333522 > > > Repository: kmymoney > > > Description > --- > > As the author of the hack states he's not sure why this was necessary. > This hack also caused a lot of workarounds in MyMoneyStatementReader > so it definitely should be removed. I've tried to keep the current > behaviour in MyMoneyStatementReader but since I'm not familiar with > investment transaction these should be double checked. > > BUG: 333522 > > > Diffs > - > > kmymoney/converter/mymoneystatementreader.cpp > 766d2151e17f07891f43e6d4d50861d40cbffe17 > kmymoney/plugins/ofximport/ofximporterplugin.cpp > 556cb4195ef1c5680ac50ce394f8bd9893fdcbdb > > Diff: https://git.reviewboard.kde.org/r/120153/diff/ > > > Testing > --- > > Imported the OFX file attached to BUG 333522 in a checking account and in an > investemnt account. Allan please take a look if the investment transactions > part in MyMoneyStatementReader is OK. > > > Thanks, > > Cristian Oneț > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.
On 2014.09.12 08:16, Cristian Oneț wrote: > On Sept. 12, 2014, 12:10 p.m., Allan Anderson wrote: I've confirmed that when the OFX file (produced from the logfile) is imported into a checking account, the sign now is correct. I've also imported a number of my own non-OFX files and they too are OK. I'm not an OFX user, and I'm assuming that the second half of the file is informational and not for import. Thanks, then somebody using OFX to import investment transactions should check this patch, anybody up fo the task? I can finally confirm that this imports as a payment, using git HEAD. Hopefully I can now apply the patch and check if that changes. Jack ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 339175] New: Multiple selection of transactions for "matching" not allowed, and transactions don't match automatically on OFX direct download
https://bugs.kde.org/show_bug.cgi?id=339175 Bug ID: 339175 Summary: Multiple selection of transactions for "matching" not allowed, and transactions don't match automatically on OFX direct download Product: kmymoney4 Version: unspecified Platform: MS Windows OS: MS Windows Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: wolfe...@gmail.com After using the OFX plugin's direct connect feature (Windows 7 installer, version 4.6.90-cdd451fe35), there are imported transactions in the ledger that are yellow which match with older transactions. First problem: These transactions are not already matched when imported, while they were in the 4.6.4 version for Windows. Second problem: Trying to highlight two transactions and match them manually doesn't work, by which I mean that holding the CTRL key and clicking on two transactions does not select both of them. This may well be an issue with the Windows version of library files or something like that. Reproducible: Always Steps to Reproduce: 1. Use OFX Direct Connect to download transactions (optional) 2. Try to select multiple items with CTRL-click 3. Actual Results: Multiple items not selected, transactions not matched. Expected Results: Automatically matched transactions, or failing that manual matching. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Review Request 120260: CSV import wizard does not appear to be working.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120260/ --- Review request for KMymoney. Repository: kmymoney Description --- I've been working for a while on improving the appearance and operation of the CSV importer plugin, which has gone far more slowly than I expected. In the meantime, a new version of KMyMoney has been released for Windows, and two users have reported the known problem of buttons at the foot of the plugin page not appearing fully. Plus, a difficulty with the start page radio buttons. So, there is more urgency now, and I've extracted the reworked UI files, and made a patch which includes them, with a needed small change to the code handling the UI. Also, there is a small fix for occasional crashes related to decimal symbol handling. This is based on the current HEAD. Otherwise, the UI looks much like the HEAD version, apart from the correct visibility of the buttons. I am still working on improving other parts of the plugin Diffs - kmymoney/plugins/csvimport/separatorwizardpage.ui 30b2dc7 kmymoney/plugins/csvimport/csvdialog.cpp 7e0229b kmymoney/plugins/csvimport/csvdialog.ui 36e7fd5 kmymoney/plugins/csvimport/csvutil.h 546bfa5 kmymoney/plugins/csvimport/csvutil.cpp 4c0dd25 kmymoney/plugins/csvimport/introwizardpage.ui 9bd29f5 kmymoney/plugins/csvimport/investmentwizardpage.ui 3744963 kmymoney/plugins/csvimport/investprocessing.h 55dd4ca kmymoney/plugins/csvimport/investprocessing.cpp c21c679 kmymoney/plugins/csvimport/lines-datewizardpage.ui fb10a0e kmymoney/plugins/csvimport/bankingwizardpage.ui d2179bf kmymoney/plugins/csvimport/completionwizardpage.ui 99db075 kmymoney/plugins/csvimport/csvdialog.h b9d4527 Diff: https://git.reviewboard.kde.org/r/120260/diff/ Testing --- I've tested the patch on Linux Mint and Ubuntu, with a large number of different files. I am not able to test on Windows, having only XP. I don't know if these changes help with the radio button issue on Windows, as I am not able to reproduce the problem here, the radio, and all other, buttons work as expected. Thanks, Allan Anderson ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Fwd: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working.
On 18/09/14 12:08, Cristian Oneț wrote: OK, but where is the patch? Please post a review request. Regards, Cristian I'd been hoping to have it tested first, before submitting it, as I can't test on XP, but it looks like that's a non-starter. This is a pain. I'll do a review request later. Any thoughts on the behaviour of the radio buttons that Jack sees? I just don't any such problem on Linux. Allan 2014-09-18 13:22 GMT+03:00 Allan : I'd intended to cc this to the list, in case anyone can offer comment/explanation. The patch I refer to is to address the incorrect display of the CSV import plugin, when on Windows and Ubuntu. I'm only able to test on Ubuntu, where all now looks fine. It consists mainly of modified UI files, with only a minimal code change, needed for the new UI's plus a small fix for a problem with decimal symbol handling which could/and did sometimes result in a crash. I've produced it now as two Windows users have experienced this problem, so I'll also need a Windows tester able to compile and apply the patch, purely to verify that the UI now looks correct, rather than to test the CSV capability. Thanks Allan Forwarded Message Subject: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working. Date: Thu, 18 Sep 2014 00:43:54 +0100 From: Allan To: Jack Ostroff On 17/09/14 22:57, Jack Ostroff wrote: Allan, I finally got a chance to work with the Windows version for a while. The radio button issue is very strange. With the mouse, I can click on either radio button, but the only effect is a slight highlight of the circle, not an actual selection. However, I can use the keyboard to select, and it seems to work fine. On the other buttons, I'm pretty sure they are actually there, just below the bottom of the window - actually a pixel or two (or maybe three?) is visible, because if I tab out of the radio buttons, I can see something change, indicating activating one of the buttons or perhaps the file name field. I even managed to get the file selector to pop up, using some combination of tab and space. So - it looks like the main issue is just display and layout. Let me know if do still want me to check those patches on Linux. Jack That is strange. I've looked at the code, and those two radio buttons are handled the same way as on the Banking/Investment pages, and all the other ordinary buttons They respond to a 'clicked signal', and the only way I could see a problem with that is the pointer has to be within the button, when pressed and when released, so if the user moved off too quickly it might not get picked up. I'll copy this to the dev list as well in case anyone else can throw any light. But, I've pressed those buttons hundreds of times with no problem at all. However, if two Windows users, including you, have hit it. I could use the pressed signal as well, if that may help. So far as the patch is concerned, it might be worthwhile to try on another distro, but then you've used the git HEAD version. I'll forward it off-line, as it's fairly large, with the UI's being changed. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Fwd: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working.
OK, but where is the patch? Please post a review request. Regards, Cristian 2014-09-18 13:22 GMT+03:00 Allan : > I'd intended to cc this to the list, in case anyone can offer > comment/explanation. > > The patch I refer to is to address the incorrect display of the CSV import > plugin, when on Windows and Ubuntu. I'm only able to test on Ubuntu, where > all now looks fine. > > It consists mainly of modified UI files, with only a minimal code change, > needed for the new UI's plus a small fix for a problem with decimal symbol > handling which could/and did sometimes result in a crash. > > I've produced it now as two Windows users have experienced this problem, so > I'll also need a Windows tester able to compile and apply the patch, purely > to verify that the UI now looks correct, rather than to test the CSV > capability. > > Thanks > > Allan > > > Forwarded Message > Subject: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to > be working. > Date: Thu, 18 Sep 2014 00:43:54 +0100 > From: Allan > To: Jack Ostroff > > On 17/09/14 22:57, Jack Ostroff wrote: >> >> Allan, >> >> I finally got a chance to work with the Windows version for a while. >> >> The radio button issue is very strange. With the mouse, I can click on >> either radio button, but the only effect is a slight highlight of the >> circle, not an actual selection. However, I can use the keyboard to >> select, and it seems to work fine. On the other buttons, I'm pretty >> sure they are actually there, just below the bottom of the window - >> actually a pixel or two (or maybe three?) is visible, because if I tab >> out of the radio buttons, I can see something change, indicating >> activating one of the buttons or perhaps the file name field. I even >> managed to get the file selector to pop up, using some combination of >> tab and space. So - it looks like the main issue is just display and >> layout. >> >> Let me know if do still want me to check those patches on Linux. >> >> Jack > > > That is strange. I've looked at the code, and those two radio buttons > are handled the same way as on the Banking/Investment pages, and all the > other ordinary buttons They respond to a 'clicked signal', and the only > way I could see a problem with that is the pointer has to be within the > button, when pressed and when released, so if the user moved off too > quickly it might not get picked up. > > I'll copy this to the dev list as well in case anyone else can throw any > light. But, I've pressed those buttons hundreds of times with no > problem at all. However, if two Windows users, including you, have hit > it. I could use the pressed signal as well, if that may help. > > So far as the patch is concerned, it might be worthwhile to try on > another distro, but then you've used the git HEAD version. I'll forward > it off-line, as it's fairly large, with the UI's being changed. > > Allan > > > > ___ > KMyMoney-devel mailing list > KMyMoney-devel@kde.org > https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Fwd: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working.
I'd intended to cc this to the list, in case anyone can offer comment/explanation. The patch I refer to is to address the incorrect display of the CSV import plugin, when on Windows and Ubuntu. I'm only able to test on Ubuntu, where all now looks fine. It consists mainly of modified UI files, with only a minimal code change, needed for the new UI's plus a small fix for a problem with decimal symbol handling which could/and did sometimes result in a crash. I've produced it now as two Windows users have experienced this problem, so I'll also need a Windows tester able to compile and apply the patch, purely to verify that the UI now looks correct, rather than to test the CSV capability. Thanks Allan Forwarded Message Subject: Re: [kmymoney4] [Bug 339044] CSV import wizard does not appear to be working. Date: Thu, 18 Sep 2014 00:43:54 +0100 From: Allan To: Jack Ostroff On 17/09/14 22:57, Jack Ostroff wrote: Allan, I finally got a chance to work with the Windows version for a while. The radio button issue is very strange. With the mouse, I can click on either radio button, but the only effect is a slight highlight of the circle, not an actual selection. However, I can use the keyboard to select, and it seems to work fine. On the other buttons, I'm pretty sure they are actually there, just below the bottom of the window - actually a pixel or two (or maybe three?) is visible, because if I tab out of the radio buttons, I can see something change, indicating activating one of the buttons or perhaps the file name field. I even managed to get the file selector to pop up, using some combination of tab and space. So - it looks like the main issue is just display and layout. Let me know if do still want me to check those patches on Linux. Jack That is strange. I've looked at the code, and those two radio buttons are handled the same way as on the Banking/Investment pages, and all the other ordinary buttons They respond to a 'clicked signal', and the only way I could see a problem with that is the pointer has to be within the button, when pressed and when released, so if the user moved off too quickly it might not get picked up. I'll copy this to the dev list as well in case anyone else can throw any light. But, I've pressed those buttons hundreds of times with no problem at all. However, if two Windows users, including you, have hit it. I could use the pressed signal as well, if that may help. So far as the patch is concerned, it might be worthwhile to try on another distro, but then you've used the git HEAD version. I'll forward it off-line, as it's fairly large, with the UI's being changed. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
