[Kmymoney-devel] Jenkins build is back to normal : kmymoney_master #346

2014-10-16 Thread KDE CI System 
See 

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Build failed in Jenkins: kmymoney_master #345

2014-10-16 Thread KDE CI System 
See 

Changes:

[agander93] Restore kmymoney/plugins/csvimport/CMakeLists.txt which was 
replaced by mistake, as part of 
http://commits.kde.org/kmymoney/50f7b6c47ad4f326b7cd6b2e0f8746b8391b3810.

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kmymoney_master] $ /bin/sh -xe /tmp/hudson1055408059248823380.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/kmymoney
   50f7b6c..dda890c  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 50f7b6c CSV Plugin - Improve functionality across distros. 
Improve UI to display the whole of the file being imported, and smarten to 
avoid displaying split rows. Also, rework some areas of the code to avoid 
duplication and improve re-usability. In addition, the UI heading labels have 
been pruned, to simplify translation. They are still centered, but no longer 
HTML based.
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@69277b88
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kmymoney.git # timeout=10
Fetching upstream changes from git://anongit.kde.org/kmymoney.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kmymoney.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision dda890c80e3ccd43ca4d01cb1a3db854f25b89c0 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f dda890c80e3ccd43ca4d01cb1a3db854f25b89c0
 > git rev-list 50f7b6c47ad4f326b7cd6b2e0f8746b8391b3810 # timeout=10
 > git tag -a -f -m Jenkins Build #345 jenkins-kmymoney_master-345 # timeout=10
[kmymoney_master] $ /bin/sh -xe /tmp/hudson3356396801838769294.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kmymoney - Branch master
== Build Dependencies:
 soprano - Branch master
 phonon - Branch master
 nepomuk-core - Branch master
 qjson - Branch master
 libdbusmenu-qt - Branch master
 shared-desktop-ontologies - Branch master
 qca - Branch master
 kdelibs - Branch KDE/4.14
 strigidaemon - Branch master
 cmake - Branch master
 attica - Branch qt4
 libstreamanalyzer - Branch master
 strigiclient - Branch master
 alkimia - Branch master
 libstreams - Branch master
 polkit-qt-1 - Branch master
 strigiutils - Branch master
 automoc - Branch master
 akonadi - Branch 1.13
 grantlee - Branch master
 qt - Branch 4.8
 poppler - Branch master
 dogtail - Branch master
 prison - Branch master
 kactivities - Branch KDE/4.13
 kdepimlibs - Branch KDE/4.14
 kdesupport-svn - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt-Version 4.8.6 (using 
/srv/jenkins/install/linux/x86_64/g++/latest-qt4/qt/inst/bin/qmake)
-- Looking for XOpenDisplay in 
/usr/lib64/libX11.so;/usr/lib64/libXext.so;/usr/lib64/libXft.so;/usr/lib64/libXau.so;/usr/lib64/libXdmcp.so;/usr/lib64/libXpm.so
-- Looking for XOpenDisplay in 
/usr/lib64/libX11.so;/usr/lib64/libXext.so;/usr/lib64/libXft.so;/usr/lib64/libXau.so;/usr/lib64/libXdmcp.so;/usr/lib64/libXpm.so
 - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib64/libX11.so
-- Looking for include file pthread.h
-- Looking for include f

Re: [Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows.

2014-10-16 Thread Allan Anderson 


> On Oct. 7, 2014, 12:47 p.m., Cristian Oneț wrote:
> > I wouldn't wait for a ship it since, as always the patch is huge, I don't 
> > want to speak for others but it's really hard for anybody to make a 
> > relevant review this way. I know we had our ups and downs so take this 
> > advice as a sign that I care enough to not leave this review request 
> > unanswered. If you find the patch good just ship it.
> > 
> > Also I support the effort of trying to improve and to avoid duplication but 
> > all I see is that 'CSVDialog' keeps getting new members and judging by 
> > their names it has become the most complex state machine I've ever seen.
> > 
> > Here are some nitpicks I came up with by looking at the request.
> 
> Allan Anderson wrote:
> Thanks Cristian.  As you say, the patch is huge, although that mainly 
> comes from several (nearly all) UI files having changes.  Alvaro mentioned 
> recently that he doesn't use QTDesigner because of its tendency to bloat the 
> files, I suspect rather like Windows Office.  If I were more confident, I too 
> would use a text editor.  In addition, some code I wanted to change was also 
> going to need to be reused, so I extracted it into two separate routines, and 
> the original large routine I was able to dispense with.  I don't foresee any 
> further major changes in the plugin!
> This patch and the recent associated "BUG:339044 REVIEW:120260 - Fix CSV 
> import wizard not working correctly on Windows", between them removed 431 
> lines, so I think I've moved in the right direction.

Committed.
remote: This commit is available for viewing at:
remote: http://commits.kde.org/kmymoney/50f7b6c47ad4f326b7cd6b2e0f8746b8391b3810


> On Oct. 7, 2014, 12:47 p.m., Cristian Oneț wrote:
> > kmymoney/plugins/csvimport/investmentwizardpage.ui, line 302
> > 
> >
> > Do we really need to center all strings? As a translator I found it 
> > verry hard to translate the csvimporter because of the many rich text 
> > directives. Please take KMyMoney UI as an example.
> 
> Allan Anderson wrote:
> You did mention this before, but now I understand to what you are 
> referring.  May be this is another example of Designer bloat.  I might be 
> able to get a simpler result from producing these UI labels via code.  I'll 
> keep my eye on that.

The UI heading labels have been trimmed.  They are still cemtered, but no 
longer HTML-based


- Allan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120507/#review68050
---


On Oct. 16, 2014, 12:15 p.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120507/
> ---
> 
> (Updated Oct. 16, 2014, 12:15 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Improve functionality across distros.
> It was also the intention to save the windows settings, but it was realised 
> that there was a liklihood that the next file to be imported could have quite 
> different column width and number of rows. So, it was decided to  display the 
> whole of the file being imported instead.  
> Also,the UI has been improved to avoid displaying split rows, with all 
> possible rows being displayed, the window height aligning with the rows, and 
> the width displaying complete columns, as far as the screen allowed.  
> Further, I reworked some areas of the code to avoid duplication and improve 
> re-usability.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/lines-datewizardpage.ui 884f3ba 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui b6dba9f 
>   kmymoney/plugins/csvimport/bankingwizardpage.ui 0d6a4a8 
>   kmymoney/plugins/csvimport/csvdialog.h 24abd9a 
>   kmymoney/plugins/csvimport/csvdialog.cpp ab20ed4 
>   kmymoney/plugins/csvimport/csvdialog.ui 61ab9ce 
>   kmymoney/plugins/csvimport/csvimporterplugin.h d2d2f6c 
>   kmymoney/plugins/csvimport/csvimporterplugin.cpp 602b4d9 
>   kmymoney/plugins/csvimport/introwizardpage.ui a597d56 
>   kmymoney/plugins/csvimport/investmentdlg.cpp 5e7b266 
>   kmymoney/plugins/csvimport/investmentwizardpage.ui 846836e 
>   kmymoney/plugins/csvimport/investprocessing.h fa8ffa0 
>   kmymoney/plugins/csvimport/investprocessing.cpp 1629e14 
> 
> Diff: https://git.reviewboard.kde.org/r/120507/diff/
> 
> 
> Testing
> ---
> 
> Tested with numerous banking and investment files from different sources, on 
> Linux Mint KDE and Ubuntu Unity.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-d

Re: [Kmymoney-devel] Review Request 120507: CSV Plugin - Improve functionality across distros. Improve UI to display the whole of the file being imported, and smarten to avoid displaying split rows.

2014-10-16 Thread Allan Anderson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120507/
---

(Updated Oct. 16, 2014, 12:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
---

Improve functionality across distros.
It was also the intention to save the windows settings, but it was realised 
that there was a liklihood that the next file to be imported could have quite 
different column width and number of rows. So, it was decided to  display the 
whole of the file being imported instead.  
Also,the UI has been improved to avoid displaying split rows, with all possible 
rows being displayed, the window height aligning with the rows, and the width 
displaying complete columns, as far as the screen allowed.  Further, I reworked 
some areas of the code to avoid duplication and improve re-usability.


Diffs
-

  kmymoney/plugins/csvimport/lines-datewizardpage.ui 884f3ba 
  kmymoney/plugins/csvimport/separatorwizardpage.ui b6dba9f 
  kmymoney/plugins/csvimport/bankingwizardpage.ui 0d6a4a8 
  kmymoney/plugins/csvimport/csvdialog.h 24abd9a 
  kmymoney/plugins/csvimport/csvdialog.cpp ab20ed4 
  kmymoney/plugins/csvimport/csvdialog.ui 61ab9ce 
  kmymoney/plugins/csvimport/csvimporterplugin.h d2d2f6c 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp 602b4d9 
  kmymoney/plugins/csvimport/introwizardpage.ui a597d56 
  kmymoney/plugins/csvimport/investmentdlg.cpp 5e7b266 
  kmymoney/plugins/csvimport/investmentwizardpage.ui 846836e 
  kmymoney/plugins/csvimport/investprocessing.h fa8ffa0 
  kmymoney/plugins/csvimport/investprocessing.cpp 1629e14 

Diff: https://git.reviewboard.kde.org/r/120507/diff/


Testing
---

Tested with numerous banking and investment files from different sources, on 
Linux Mint KDE and Ubuntu Unity.


Thanks,

Allan Anderson

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] Jenkins build became unstable: kmymoney_master #344

2014-10-16 Thread KDE CI System 
See 

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel