Re: [Kmymoney-devel] kf5 based version
Hi Jeremy, On 01 Dec 2014, at 22:16 , Jeremy Whiting wrote: > Today I tried to build the frameworks branch of kmymoney, but it fails at > cmake time looking for KF5PimIdentitiesConfig.cmake. I have a whole > frameworks build with kdesrc-build here, but don't see PimIdentities > anywhere. It's mentioned in kdepimlibs (and in the kdepimlibs description on > projects.kde.org) but kdepimlibs master branch doesn't create that cmake file > somehow. Is there a certain branch of kdepimlibs that the kf5 port of kmm > depends on ? well, on OSX/CI I have removed kdepimlibs altogether from KMM’s dependencies, thus avoiding the whole issue! That’s the only way how I can build its ‘frameworks' branch successfully for KF5 at the moment on OSX. Cristian will surely give you more information for Linux... Greets, Marko___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] kf5 based version
Hello all, Today I tried to build the frameworks branch of kmymoney, but it fails at cmake time looking for KF5PimIdentitiesConfig.cmake. I have a whole frameworks build with kdesrc-build here, but don't see PimIdentities anywhere. It's mentioned in kdepimlibs (and in the kdepimlibs description on projects.kde.org) but kdepimlibs master branch doesn't create that cmake file somehow. Is there a certain branch of kdepimlibs that the kf5 port of kmm depends on ? thanks, Jeremy ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #8 from allan --- Going back to the top, your first problem (July 2013), importing that file now, or my similar version - !Account NInv TInvst ^ !Type:Invst D03/06/2014 YsecurityB NDivX MDividend Payment T1150 O150 ^ This now imports correctly, sort of. and after import it appears to be correct. Viewed in the Transaction form, fee = 150.00, Interest = 1000.00, total = 1150.00. So, that looks promising. However, if I now open to edit the transaction, the Total now = 850.00. So, I think I know where to go next. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #7 from allan --- After processing in mymoneyqifreader.cpp, the data is passed to moneystatementreader.cpp. On 12 Sept 2014, a change was applied here - "Remove the OFX investment transactions amount sign inversion hack. As the author of the hack states he's not sure why this was necessary. This hack also caused a lot of workarounds in MyMoneyStatementReader so it definitely should be removed. I've tried to keep the current behaviour in MyMoneyStatementReader but since I'm not familiar with investment transaction these should be double checked. BUG: 333522 REVIEW: 120153" This might be implicated. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Review Request 120153: Remove the OFX investment transactions amount sign inversion hack.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120153/#review71206 --- I've been drawn back to this because of another bug I'm looking at - "[Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import". As mymoneystatementreader.cpp is involve also in QIF and CSV importing, I suspect there may be a side effect of this change. In mymoneyqifreader.cpp, I see the following - "// For historic reasons (coming from the OFX importer) the statement reader // expects the dividend with a reverse sign. So we just do that. tr.m_amount = -(amount - tr.m_fees);" Will not a corresponding change be required here? I suspect this may be in part contributing to Bug 322381. I've removed the -ve sign and it does partially correct this problem, but I need to look deeper because I suspect there is an earlier bug too. - Allan Anderson On Sept. 21, 2014, 9:33 a.m., Cristian Oneț wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120153/ > --- > > (Updated Sept. 21, 2014, 9:33 a.m.) > > > Review request for KMymoney and Allan Anderson. > > > Bugs: 333522 > http://bugs.kde.org/show_bug.cgi?id=333522 > > > Repository: kmymoney > > > Description > --- > > As the author of the hack states he's not sure why this was necessary. > This hack also caused a lot of workarounds in MyMoneyStatementReader > so it definitely should be removed. I've tried to keep the current > behaviour in MyMoneyStatementReader but since I'm not familiar with > investment transaction these should be double checked. > > BUG: 333522 > > > Diffs > - > > kmymoney/converter/mymoneystatementreader.cpp > 766d2151e17f07891f43e6d4d50861d40cbffe17 > kmymoney/plugins/ofximport/ofximporterplugin.cpp > 556cb4195ef1c5680ac50ce394f8bd9893fdcbdb > > Diff: https://git.reviewboard.kde.org/r/120153/diff/ > > > Testing > --- > > Imported the OFX file attached to BUG 333522 in a checking account and in an > investemnt account. Allan please take a look if the investment transactions > part in MyMoneyStatementReader is OK. > > > Thanks, > > Cristian Oneț > > ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #6 from egroegba...@yahoo.com --- Yes I thought we were getting different results, but I see they are the same. BTW I am using the latest daily-build from Clay Weber downloaded yesterday on Mint 17 On Monday, December 1, 2014 4:55 PM, allan wrote: https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #5 from allan --- That doesn't make any difference, Tim, but I'm not sure we're getting different results. When you say "Maybe you will get the minus amount", where are you seeing that? Looking at either the brokerage account or the cheque account, the result is the same - 850.00. Looking at the investment account, if the imported transaction is *not* selected, the Value shows as 850.00. If it is selected, then -1000.00 shows under Quantity, but if you are using the Transaction form to view, then that -1000.00 is the interest amount, the fee is 150.00 and the total is 850.00. It is definitely wrong. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #5 from allan --- That doesn't make any difference, Tim, but I'm not sure we're getting different results. When you say "Maybe you will get the minus amount", where are you seeing that? Looking at either the brokerage account or the cheque account, the result is the same - 850.00. Looking at the investment account, if the imported transaction is *not* selected, the Value shows as 850.00. If it is selected, then -1000.00 shows under Quantity, but if you are using the Transaction form to view, then that -1000.00 is the interest amount, the fee is 150.00 and the total is 850.00. It is definitely wrong. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #4 from egroegba...@yahoo.com --- Hi Allan The DIVX transaction is defaulting to the brokerage account. Try adding the line L[Bank Accounts:Cheque] for transfer to the cheque account. Maybe you will get the minus amount that I got. Regards Timothy On Monday, December 1, 2014 2:25 PM, allan wrote: https://bugs.kde.org/show_bug.cgi?id=322381 allan changed: What |Removed |Added Ever confirmed|0 |1 CC| |agande...@gmail.com Status|UNCONFIRMED |CONFIRMED --- Comment #3 from allan --- There is definitely a problem. Here is a simple QIF file. !Account NInv TInvst ^ !Type:Invst D03/06/2014 YsecurityB NDivX MDividend Payment T1150.00 O150.00 ^ If I create an Investment account called Inv, which has an associated (Brokerage) account, and a security called securityB, and then import that file into Inv, the Brokerage account shows a payment of 850.00, instead of a net deposit of 1000.00, and a missing assignment of 300.00 is flagged. The splits show a payment of 1000.00 and a fee payment of 150.00 If for comparison, I manually create a Dividend transaction, with amount 1150.00 and fee of 150.00, then that is correctly entered, with the Brokerage account showing a deposit of 1000.00, and a fee of 150.00 -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 allan changed: What|Removed |Added Ever confirmed|0 |1 CC||agande...@gmail.com Status|UNCONFIRMED |CONFIRMED --- Comment #3 from allan --- There is definitely a problem. Here is a simple QIF file. !Account NInv TInvst ^ !Type:Invst D03/06/2014 YsecurityB NDivX MDividend Payment T1150.00 O150.00 ^ If I create an Investment account called Inv, which has an associated (Brokerage) account, and a security called securityB, and then import that file into Inv, the Brokerage account shows a payment of 850.00, instead of a net deposit of 1000.00, and a missing assignment of 300.00 is flagged. The splits show a payment of 1000.00 and a fee payment of 150.00 If for comparison, I manually create a Dividend transaction, with amount 1150.00 and fee of 150.00, then that is correctly entered, with the Brokerage account showing a deposit of 1000.00, and a fee of 150.00 -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 --- Comment #2 from egroegba...@yahoo.com --- BTW I amusin the latest KMM from Clay Weber daily updates Version 4.7.90 Using KDE Development Platform 4.13.3. The update was dowmloaded yesterday. -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] [kmymoney4] [Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import
https://bugs.kde.org/show_bug.cgi?id=322381 egroegba...@yahoo.com changed: What|Removed |Added CC||egroegba...@yahoo.com --- Comment #1 from egroegba...@yahoo.com --- > > On Sun, 2014-11-30 at 13:13 +, Allan wrote: > >> Hi Timothy > >> > >> On 30/11/14 12:18, timothy wrote: > >>> Hi > >>> > >>> Could you please give me the sign convention for QIF investment format > >>> expected by Kymoney. ie Should the QIF file show positive or negative > >>> numbers. > >> > >> In general, the sign is taken care of in the activity type. That > >> is,both a Buy and a Sell expect no sign. Similarly, a Div and a Fee > >> will be expected to be with no sign. > >> > >>> Specifically in the DIVX file for the Amount (T) and the Fees (O). > >>> > >>> Things seem to have changed since I last imported a Dividend? > >> > >> Well, that might depend on when you last imported a Dividend! The > >> general case has not changed. However, there may well have been some > >> minor changes, to cater for certain activity types previously not > >> expecting say, a fee, but which some users wished otherwise. > >> > >> If that doesn't help, the best thing might be to give us an example > >> which is not doing what you expect/expected. > >> > >> Allan > > > > Thanks Alan. Could you also please specify whether the amount (T) is > > expected net of fees (O) or inclusive of the fees. > > > > In KMM it appears that when amount and fees are positive or no sign, the > > the fees are being subtracted from the QIF file amount to give the KMM > > "Interest Amount" and then subtracted again to give the "Total Amount". > > The sign of the amount or interest is then changed to negative. > > > > Example > > The QIF file gives > > !Type:Invst > > D15/09/2014 > > NDIVX > > T1853.00 \\ This is net of fees being the amount received by me > > O327.00 \\ These are the fees as taken off by broker. The total > > dividend declared should be T+O > > > > After manual import KMM gives > > Fee AmountZAR 327.00 > > Interest ZAR -1526.00 > > Total ZAR 1199.00 > > > > Regards > > Timothy > > > > Further to above I have found that the Total 1199.00 which is transferred > > to my > > cheque account is actually negative and appears in the cheque a/c as a > > payment not a deposit. > > So it looks like the QIF amount T has the sign changed and then the fees > > are added to give the > > Interest Amount and then added again to give the Total. Wow! > > > > Timothy > > > > Just a quick test for the moment, but that doesn't look right to me. > > I'll need to investigate, but would you please raise a bug at > https://bugs.kde.org > > Allan Will do so. Timothy Hi Allan This is a duplicate of Bug 322381 filed July 2013 with the variation the sign is also changed. I did not follow up on this bug as I had implemented a work-around in my own QIF preprocessor and things had worked quite nicely from then. However the negative sign has now thrown out my work-around logic. I had forgotten the original bug filed, as dividend import was working for me. You can import my original bug numbers and see that the result has now changed. If you want me to add anything to the original bug filed let me know. Timothy -- You are receiving this mail because: You are the assignee for the bug. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
