date:20150301

Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and unknown payee import dialog

2015-03-01 Thread Cristian Oneț



> On Sept. 21, 2013, 2:24 p.m., Alvaro Soliverez wrote:
> > I fail to see why you would want equity accounts displayed for imports. Can 
> > you explain the use case?
> > 
> > Keep in mind that equity accounts are not stock or share accounts of some 
> > kind.
> 
> Ralf Habacker wrote:
> To be able to import opening balances for example when using german 
> template "all accounts", which have an account "Equity"->"Opening balances". 
> Otherwise I would have to manual enter the opening balances for all related 
> accounts by hand.
> 
> Alvaro Soliverez wrote:
> These opening balances are exactly that, opening balances, and should not 
> have a payee assigned.
> 
> That account is to balance the entry when you start using KMyMoney and 
> you enter the opening balances for your asset and liability accounts. As per 
> double-entry accounting, all transactions have to be balanced, and money 
> can't just pop out of the blue. 
> 
> eg. you start using KMM on Jan 1, but you already had a bank account by 
> that date. You create the account and enter the balance on that date. To 
> balance that transaction, a split is assigned to "Equity/Opening balances". 
> No payees are involved.
> 
> Sorry for the delay, this went under my radar.
>

I understand what Alvaro is saying but is there a way to import opening 
balances of accounts if one has many accounts? If there is not then I would 
suggest shipping this patch since the visibility of the equity accounts is 
controlled by the expert mode flag anyway. I really don't like limiting the 
functionality in valid use cases just for the sake of simplicity.


- Cristian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112847/#review40403
---


On Sept. 21, 2013, 12:41 p.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112847/
> ---
> 
> (Updated Sept. 21, 2013, 12:41 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> When enabled display of equity accounts with 'settings->general->filter->show 
> equity accounts' equity accounts are not displayed in the "Default Account" 
> tab of payee page and in the unknown payee import dialog. 
> 
> The related bug could be triggered with: 
> 1. create a new file
> 2. select the german skr03 standard chart of accounts. 
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/mymoneystatementreader.cpp 5619cc2 
>   kmymoney/views/kgloballedgerview.cpp 2057b47 
>   kmymoney/views/kpayeesview.cpp 69697e6 
> 
> Diff: https://git.reviewboard.kde.org/r/112847/diff/
> 
> 
> Testing
> ---
> 
> git master
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 338306] Ledger search box doesn't support account hierarchy character ":"

2015-03-01 Thread Cristian Oneț

https://bugs.kde.org/show_bug.cgi?id=338306

Cristian Oneț  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 297007] Printing splits lines over pages

2015-03-01 Thread Cristian Oneț

https://bugs.kde.org/show_bug.cgi?id=297007

Cristian Oneț  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 313793] Consistency checker is reporting spurious errors

2015-03-01 Thread Cristian Oneț

https://bugs.kde.org/show_bug.cgi?id=313793

Cristian Oneț  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [kmymoney4] [Bug 344708] New: Add average column to reports

2015-03-01 Thread Julian Kalinowski

https://bugs.kde.org/show_bug.cgi?id=344708

Bug ID: 344708
   Summary: Add average column to reports
   Product: kmymoney4
   Version: 4.7.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: julak...@gmail.com

For reports, it would be nice to have an "average" column in addition to the
(optional) "Sum" column.
This would provide a better overview of e.g. average monthly costs per category
over the last year.

Maybe one could specifiy the divider to be used to calculate the average from
the sum, or the application could automatically decide (e.g. divide by 12 for a
one-year-period in monthly view).

To achieve this atm, one needs to export data to another tool (LO Calc).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Help, I don't get it

2015-03-01 Thread Thomas Baumgart

Hi,

On Friday 27 February 2015 21:05:55 Christian Dávid wrote:

> Jack is right. The file is created by cmake (Cristian added that some days
> ago). I guess there is an issue in the order of these commands leading to a
> race condition in your build (seems like add _ subdirectory is involved).

Nope, that's not the case. Even if I run "make -j1" the file is simply not 
generated. The other one (widgets_export.h) is created during the run of 
cmake. The delegates_export.h can't be created here for some reason.


> Am 27. Februar 2015 20:40:51 MEZ, schrieb Jack :
> >so it looks like (at least for me) it is created either by cmake or by
> >
> >make.  (I did the find after the make had started, so I can't be sure
> >which created it.)  The make is now only at 8%, so I don't know if I'll
> >
> >get any error related to this before it's complete.


> >
> >Jack
> >___
> >KMyMoney-devel mailing list
> >KMyMoney-devel@kde.org
> >https://mail.kde.org/mailman/listinfo/kmymoney-devel
> 
> ___
> KMyMoney-devel mailing list
> KMyMoney-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-
An optimist laughs to forget.
A pessimist forgets to laugh.
-


signature.asc
Description: This is a digitally signed message part.
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

2015-03-01 Thread Allan Anderson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122364/#review76808
---


Might someone be free to OK this, or otherwise, please.  In spite of its size, 
there is not a huge amount of change involved.

- Allan Anderson


On Feb. 3, 2015, 12:27 a.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122364/
> ---
> 
> (Updated Feb. 3, 2015, 12:27 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 340656
> http://bugs.kde.org/show_bug.cgi?id=340656
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Fix display on high-definition monitors. Fix interaction between the import 
> preview table widget and the parameter entry wizard, caused by them both 
> resizing dynamically within the same window. This was achieved by creating a 
> new class and UI for the wizard and transferring most of the existing 
> relevant code out of the large csvdialog.cpp file into the new class and 
> file.  Unfortunately, because 11 UIs are affected and the transfer of 
> existing logic into a new class, the patch is quite large, although there is 
> little new code involved.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvwizard.h PRE-CREATION 
>   kmymoney/plugins/csvimport/csvwizard.cpp PRE-CREATION 
>   kmymoney/plugins/csvimport/csvwizard.ui PRE-CREATION 
>   kmymoney/plugins/csvimport/introwizardpage.ui 2bf93f0 
>   kmymoney/plugins/csvimport/investmentdlg.cpp 5e7ce06 
>   kmymoney/plugins/csvimport/investmentwizardpage.ui d3f2857 
>   kmymoney/plugins/csvimport/investprocessing.h 3c08dee 
>   kmymoney/plugins/csvimport/investprocessing.cpp 2b6b2d1 
>   kmymoney/plugins/csvimport/lines-datewizardpage.ui 01d7253 
>   kmymoney/plugins/csvimport/redefinedlgdecl.ui 26d8b62 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui 21136f2 
>   kmymoney/plugins/csvimport/CMakeLists.txt 36e5afc 
>   kmymoney/plugins/csvimport/bankingwizardpage.ui 9e1b5cb 
>   kmymoney/plugins/csvimport/completionwizardpage.ui ce61e89 
>   kmymoney/plugins/csvimport/csvdialog.h 780329d 
>   kmymoney/plugins/csvimport/csvdialog.cpp b986317 
>   kmymoney/plugins/csvimport/csvdialog.ui 166b04a 
> 
> Diff: https://git.reviewboard.kde.org/r/122364/diff/
> 
> 
> Testing
> ---
> 
> Tested on 96 DPI and 160 DPI.  Also, the OP of the bug has tested the patch 
> and confirms its performance.
> There is one remaining UI not yet included.  I've completed its testing, but 
> as it's a little-used window, I've held it back to avoid making this patch 
> even larger.
> I'm unable to test on Windows.
> 
> 
> File Attachments
> 
> 
> Updated patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/6e4dad98-936c-4ca0-8804-c4abb9b51438__0002-BUG-340656.patch
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

2015-03-01 Thread Allan Anderson



> On Feb. 12, 2015, 9:24 p.m., Christian David wrote:
> > File Attachment: Updated patch - 0002-BUG-340656.patch
> > 
> >
> > ```Qt::WindowFlags eFlags = windowFlags();``` (space removed)
> 
> Allan Anderson wrote:
> I know it looks odd, but I copied this from a google search.  If I 
> remember, the point was to avoid the window in question staying on top.
> Perhaps I misunderstood?  I didn't actually try without it.

see below


> On Feb. 12, 2015, 9:24 p.m., Christian David wrote:
> > File Attachment: Updated patch - 0002-BUG-340656.patch
> > 
> >
> > This part can be removed, the flag is set and removed again. Also you 
> > call show() twice.
> 
> Allan Anderson wrote:
> As above.
> 
> Christian David wrote:
> Without seeing the code: I think, you should just drop the part where the 
> flag is removed again and the second ```show()```.
> 
> Allan Anderson wrote:
> This is used in three places, and in two of them problems ensue.  In the 
> first one, the wizard window stays on top and clicking on the table window 
> does not bring it to the front.  It is necessary to start to manipulate the 
> wizard before the table wakes up.  In the second one, it is possible for the 
> table to completely cover the wizard, and to circumvent this, I allow a ight 
> click on the table to raise the wizard.  With those three lines removed, the 
> wizard stays hidden.  In the third case, it might be possible to remove all 
> that code, with no problem apparent.  I'll keep my eye on all this.

No other issues.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122364/#review75942
---


On Feb. 3, 2015, 12:27 a.m., Allan Anderson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122364/
> ---
> 
> (Updated Feb. 3, 2015, 12:27 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 340656
> http://bugs.kde.org/show_bug.cgi?id=340656
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Fix display on high-definition monitors. Fix interaction between the import 
> preview table widget and the parameter entry wizard, caused by them both 
> resizing dynamically within the same window. This was achieved by creating a 
> new class and UI for the wizard and transferring most of the existing 
> relevant code out of the large csvdialog.cpp file into the new class and 
> file.  Unfortunately, because 11 UIs are affected and the transfer of 
> existing logic into a new class, the patch is quite large, although there is 
> little new code involved.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvwizard.h PRE-CREATION 
>   kmymoney/plugins/csvimport/csvwizard.cpp PRE-CREATION 
>   kmymoney/plugins/csvimport/csvwizard.ui PRE-CREATION 
>   kmymoney/plugins/csvimport/introwizardpage.ui 2bf93f0 
>   kmymoney/plugins/csvimport/investmentdlg.cpp 5e7ce06 
>   kmymoney/plugins/csvimport/investmentwizardpage.ui d3f2857 
>   kmymoney/plugins/csvimport/investprocessing.h 3c08dee 
>   kmymoney/plugins/csvimport/investprocessing.cpp 2b6b2d1 
>   kmymoney/plugins/csvimport/lines-datewizardpage.ui 01d7253 
>   kmymoney/plugins/csvimport/redefinedlgdecl.ui 26d8b62 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui 21136f2 
>   kmymoney/plugins/csvimport/CMakeLists.txt 36e5afc 
>   kmymoney/plugins/csvimport/bankingwizardpage.ui 9e1b5cb 
>   kmymoney/plugins/csvimport/completionwizardpage.ui ce61e89 
>   kmymoney/plugins/csvimport/csvdialog.h 780329d 
>   kmymoney/plugins/csvimport/csvdialog.cpp b986317 
>   kmymoney/plugins/csvimport/csvdialog.ui 166b04a 
> 
> Diff: https://git.reviewboard.kde.org/r/122364/diff/
> 
> 
> Testing
> ---
> 
> Tested on 96 DPI and 160 DPI.  Also, the OP of the bug has tested the patch 
> and confirms its performance.
> There is one remaining UI not yet included.  I've completed its testing, but 
> as it's a little-used window, I've held it back to avoid making this patch 
> even larger.
> I'm unable to test on Windows.
> 
> 
> File Attachments
> 
> 
> Updated patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/6e4dad98-936c-4ca0-8804-c4abb9b51438__0002-BUG-340656.patch
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Help, I don't get it

2015-03-01 Thread Thomas Baumgart

Hi Jack,

I don't do insource builds. Having the build directory as a subdir of the 
source dir is still an out-of-source-build. So I do have

/home/thb/devel/kmymoney as the source dir and
/home/thb/devel/kmymoney/build as the build dir. That worked for ages. So it 
does not seem to be the issue.

I did notice some differences between cmake 2.8.11 and 2.8.12 in the past 
though.

The only thing that puzzles me is, that the only spot the file is referenced 
in the build system is a the binary (build) dir as a dependency:

thb@thb-nb:~/devel/kmymoney (master)$ find . -name CMakeLists.txt | xargs grep 
payeeidentifier_iban_bic_widgets_export.h
./kmymoney/payeeidentifier/ibanandbic/widgets/CMakeLists.txt:  
${CMAKE_CURRENT_BINARY_DIR}/payeeidentifier_iban_bic_widgets_export.h


For some reason the generate_export_header() macros in 
kmymoney/payeeidentifier/ibanandbic/widgets/CMakeLists.txt don't do what they 
are supposed to do.

Cheers

Thomas


On Saturday 28 February 2015 12:31:02 Jack wrote:

> My cmake is 2.8.12 (Gentoo).  In my case, the build directory is NOT
> under the source root - I have been "trained" over the years that
> in-source build directories can sometimes cause hard to track down
> problems, although I'm not sure if that is the issue here or not.
> 
> Jack
> 
> On 2015.02.28 11:48, Thomas Baumgart wrote:
> > Hi,
> > 
> > well, since my build directory is a subdir to the source directory,
> > find
> > should have found it, but it is not there.
> > 
> > Where is the code that generates it? It must be somewhere in the
> > CMakeLists.txt files, right? Which one? BTW, I am on cmake 2.8.11.2,
> > the one
> > provided with my distro, just in case you use a feature only provided
> > by a
> > newer version.
> > 
> > Cheers
> > 
> > Thomas
> > 
> > On Friday 27 February 2015 21:57:54 Cristian Oneț wrote:
> > > It should be in the build directory since it's generated by the
> > 
> > build
> > 
> > > system.
> > > 
> > > Regards,
> > > Cristian
> > > 
> > > 2015-02-27 21:21 GMT+02:00 Thomas Baumgart :
> > > > Hi all,
> > > > 
> > > > I just synced with git master and compiled as usual, when I hit
> > 
> > the
> > 
> > > > problem, that a header file was missing. It is referenced in two
> > > > locations, but I can't seem to find it in my sandbox.
> > > > 
> > > > thb@thb-nb:~/devel/kmymoney (master)$ git grep
> > > > payeeidentifier_iban_bic_delegates_export.h
> > 
> > kmymoney/payeeidentifier/ibanandbic/widgets/ibanbicitemdelegate.h:#include
> > 
> > > > "payeeidentifier_iban_bic_delegates_export.h"
> > 
> > kmymoney/payeeidentifier/ibanandbic/widgets/ibanbicitemedit.h:#include
> > 
> > > > "payeeidentifier_iban_bic_delegates_export.h"
> > > > 
> > > > 
> > > > but
> > > > 
> > > > 
> > > > thb@thb-nb:~/devel/kmymoney (master)$ find . -name
> > > > payeeidentifier_iban_bic_delegates_export.h
> > > > 
> > > > does not return a single file. Hence I get:
> > > > 
> > > > [100%] Building CXX object
> > 
> > kmymoney/payeeidentifier/ibanandbic/widgets/CMakeFiles/payeeidentifier_iba
> > 
> > > > n_bic_delegates.dir/ibanbicitemdelegate.cpp.o In file included
> > 
> > from
> > 
> > /home/thb/devel/kmymoney/kmymoney/payeeidentifier/ibanandbic/widgets/ibanb
> > 
> > > > icitemdelegate.cpp:19:0:
> > /home/thb/devel/kmymoney/kmymoney/payeeidentifier/ibanandbic/widgets/iban
> > 
> > > > bicitemdelegate.h:26:55: fatal error:
> > > > payeeidentifier_iban_bic_delegates_export.h: No such file or
> > 
> > directory
> > 
> > > >  #include "payeeidentifier_iban_bic_delegates_export.h"
> > > >  
> > > >^
> > > > 
> > > > compilation terminated.
> > > > make[2]: ***
> > 
> > [kmymoney/payeeidentifier/ibanandbic/widgets/CMakeFiles/payeeidentifier_ib
> > 
> > > > an_bic_delegates.dir/ibanbicitemdelegate.cpp.o] Error 1
> > > > make[1]: ***
> > 
> > [kmymoney/payeeidentifier/ibanandbic/widgets/CMakeFiles/payeeidentifier_ib
> > 
> > > > an_bic_delegates.dir/all] Error 2
> > > > make: *** [all] Error 2
> > > > 
> > > > 
> > > > 
> > > > What am I missing? The CI build is OK (maybe it is not compiling
> > 
> > this part
> > 
> > > > of the project). Christian?
> > > > 
> > > > 
> > > > 
> > > > 
> > > > --
> > > > 
> > > > Regards
> > > > 
> > > > Thomas Baumgart
> > > > 
> > > > GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
> > > > -
> > > > As soon as there is an optimist who discovers a light that does
> > 
> > not exist
> > 
> > > > there is a pessimist who blows it out. (Giovanni Guareschi)
> > > > -
> > > > 
> > > > ___
> > > > KMyMoney-devel mailing list
> > > > KMyMoney-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/kmymoney-devel
> > > 
> > > ___
> > > KMyMoney-devel mailing list
> > > KMyMoney-devel@kde.org
> > > https://mail.kde.o

Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and unknown payee import dialog

[Kmymoney-devel] [kmymoney4] [Bug 338306] Ledger search box doesn't support account hierarchy character ":"

[Kmymoney-devel] [kmymoney4] [Bug 297007] Printing splits lines over pages

[Kmymoney-devel] [kmymoney4] [Bug 313793] Consistency checker is reporting spurious errors

[Kmymoney-devel] [kmymoney4] [Bug 344708] New: Add average column to reports

Re: [Kmymoney-devel] Help, I don't get it

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

Re: [Kmymoney-devel] Review Request 122364: CSV Importer - Fix display on high-definition displays. Fix interaction between QTable and QWizard in same window.

Re: [Kmymoney-devel] Help, I don't get it

9 matches

Site Navigation

Mail list logo

Footer information