Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 76 - Still Unstable!

2016-09-11 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/76/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 11 Sep 2016 18:02:26 +
Build duration: 10 min

CHANGE SET
Revision 7425d0b58a7dbf710e0a1604af789f09a776fb6f by Thomas Baumgart: (Keep the 
last 10 versions of the data file)
  change: edit kmymoney/kmymoney.kcfg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/23 (87%)FILES 178/231 (77%)CLASSES 178/231 (77%)LINE 21617/34574 
(63%)CONDITIONAL 34569/95859 (36%)

By packages
  
kmymoney
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 70/331 (21%)CONDITIONAL 
96/726 (13%)
kmymoney.converter
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 158/531 (30%)CONDITIONAL 
252/1674 (15%)
kmymoney.converter.tests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 372/374 (99%)CONDITIONAL 
344/694 (50%)
kmymoney.mymoney
FILES 50/60 (83%)CLASSES 50/60 (83%)LINE 4884/7586 
(64%)CONDITIONAL 4607/13489 (34%)
kmymoney.mymoney.payeeidentifier
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 66/168 (39%)CONDITIONAL 
22/218 (10%)
kmymoney.mymoney.payeeidentifier.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 24/30 (80%)CONDITIONAL 
19/44 (43%)
kmymoney.mymoney.storage
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 4171/6423 
(65%)CONDITIONAL 6056/18366 (33%)
kmymoney.mymoney.storage.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 2255/2576 
(88%)CONDITIONAL 3625/8224 (44%)
kmymoney.mymoney.tests
FILES 42/43 (98%)CLASSES 42/43 (98%)LINE 5915/6199 
(95%)CONDITIONAL 11929/24698 (48%)
kmymoney.payeeidentifier.ibanandbic
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 72/363 (20%)CONDITIONAL 
56/897 (6%)
kmymoney.payeeidentifier.ibanandbic.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 208/212 (98%)CONDITIONAL 
131/280 (47%)
kmymoney.payeeidentifier.nationalaccount
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/93 (5%)CONDITIONAL 
3/182 (2%)
kmymoney.payeeidentifier.unavailableplugin
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/34 (0%)CONDITIONAL 0/28 
(0%)
kmymoney.plugins.csvimport
FILES 3/9 (33%)CLASSES 3/9 (33%)LINE 153/3207 (5%)CONDITIONAL 
164/5950 (3%)
kmymoney.plugins.csvimport.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 158/160 (99%)CONDITIONAL 
184/366 (50%)
kmymoney.plugins.onlinetasks.dummy.tasks
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 15/36 (42%)CONDITIONAL 
5/12 (42%)
kmymoney.plugins.onlinetasks.interfaces.tasks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/6 (83%)CONDITIONAL 0/6 
(0%)
kmymoney.plugins.onlinetasks.interfaces.ui
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/1 (0%)CONDITIONAL 0/2 (0%)
kmymoney.plugins.onlinetasks.unavailabletask.tasks
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/30 (0%)CONDITIONAL 0/12 
(0%)
kmymoney.reports
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 1606/2753 
(58%)CONDITIONAL 2423/7575 (32%)
kmymoney.reports.tests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1451/1507 
(96%)CONDITIONAL 4602/9326 (49%)
kmymoney.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/25 (100%)CONDITIONAL 
47/94 (50%)
kmymoney.widgets
FILES 2/25 (8%)CLASSES 2/25 (8%)LINE 4/1929 (0%)CONDITIONAL 
4/2996 (0%)

[kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As " Please use an older version...."

2016-09-11 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

--- Comment #5 from Thomas Baumgart  ---
Ooops, something must have ruined your file. This does not look like a KMyMoney
data file at all. Don't you have a backup of it at some other location? The
auto backup feature seems to be turned off, too bad.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As " Please use an older version...."

2016-09-11 Thread Somoorthi P via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

--- Comment #4 from Somoorthi P  ---
(In reply to Thomas Baumgart from comment #3)
This is what i got
paarkavin@Paarkavin:~$ ls -l "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo -
Sep-16.kmy"*
-rwx-- 1 paarkavin paarkavin 590596 Sep  4 06:50
/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy
paarkavin@Paarkavin:~$ od -c "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo -
Sep-16.kmy" | head
000 377 377   {   m 354   /   v   e   r   s   i   o   n   =   "   1
020 356   7 342   '   e   n   c   o   d   i   n   g   =   "   U   T
040   F 355   ?   "   ?   > 372 375   w   r   o   j   e   c 364   /
060   v   e   r   s   i   o   n   =   "   4   "   > 372 377   '   <
100   c   o 355 177   o   n   e   n 364   /   n   a   m   e   =   "
120   C   h   a   n   g   e   L   i   s   t   M   a   n   a   g   e
140   r   "   > 372 343 347 347   '   <   l   i   s 364   /   d   e
160   f   a   u   l   t   =   "   t   r   u   e 342   '   i   d   =
200   "   b   4   d   5   b   7   3   1   -   9   5 361   7   -   4
220   9   a   3   -   b   f   7   b   -   1   2   e   2 342   ?   9
paarkavin@Paarkavin:~$

-- 
You are receiving this mail because:
You are the assignee for the bug.


[kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As " Please use an older version...."

2016-09-11 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

Thomas Baumgart  changed:

   What|Removed |Added

Summary|KmyMoney File Not opening   |KmyMoney File Not opening
   |and gives error As " Please |and gives error As " Please
   |use an older vesion"|use an older version"

--- Comment #3 from Thomas Baumgart  ---
At the end of the first command was an asterisk on purpose. Can you repeat
that?

So what we know is that the file is 500K large but 'data' is not what I
expected. What we don't know (yet) if you have backup files (see command
above). Also, what is the output of the following command:

od -c "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy" | head

-- 
You are receiving this mail because:
You are the assignee for the bug.


[kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As " Please use an older vesion...."

2016-09-11 Thread Somoorthi P via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

--- Comment #2 from Somoorthi P  ---
Thanks for your immediate reply... the following are the results of the
commands
paarkavin@Paarkavin:~$ ls -l "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo -
Sep-16.kmy"
-rwx-- 1 paarkavin paarkavin 590596 Sep  4 06:50
/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy
paarkavin@Paarkavin:~$ file "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo -
Sep-16.kmy"
/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy: data
paarkavin@Paarkavin:~$ 

For your reference.
Thanks & Rgds
P.Somoorthi



  From: Thomas Baumgart via KDE Bugzilla 
 To: somoor...@yahoo.co.in 
 Sent: Sunday, 11 September 2016 7:28 PM
 Subject: [kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As
" Please use an older vesion"

https://bugs.kde.org/show_bug.cgi?id=368593

--- Comment #1 from Thomas Baumgart  ---
What is the output of the following commands

ls -l "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy"*
file "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 368593] KmyMoney File Not opening and gives error As " Please use an older vesion...."

2016-09-11 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

--- Comment #1 from Thomas Baumgart  ---
What is the output of the following commands

ls -l "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy"*
file "/media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy"

-- 
You are receiving this mail because:
You are the assignee for the bug.


[kmymoney4] [Bug 368593] New: KmyMoney File Not opening and gives error As " Please use an older vesion...."

2016-09-11 Thread Somoorthi P via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368593

Bug ID: 368593
   Summary: KmyMoney File Not opening and gives error As " Please
use an older vesion"
   Product: kmymoney4
   Version: 4.8.0
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: file
  Assignee: kmymoney-devel@kde.org
  Reporter: somoor...@yahoo.co.in

I am using KmyMoney (in Ubuntu) for my personal finance managment since last 4
years, after migrating from a legacy made finance software. With almost 10 to
12 years of data, it was working fine. But suddenly it is not opening and
throwing the following error.
"File /media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy contains the old
binary format used by KMyMoney. Please use an older version of KMyMoney (0.8.x)
that still supports this format to convert it to the new XML based format."
Recently i made upgrade from 15.1 to 16.04 so along with ubuntu i also made a
upgrade on KmyMoney from 4.7.2 to 4.8.0. 
After the upgrade, still it was working well for 10 days and suddenly it is
started giving the error. I tried with previous versions also (4.6.4) but the
error is repeating. Tried wthe same with windows version also. Still the same
error. In windows no upgrade has been made.
Please help to recover the data. how to solve this error and open my kMymoney
file.
2 years earlier backup kmy file i opened find it is opening.
Thanks in advance

Reproducible: Always

Steps to Reproduce:
1.Every time i open the file it is repeating
2.
3.

Actual Results:  
File /media/paarkavin/Paarkavin/Ex1/YaArO/yAaRo - Sep-16.kmy contains the old
binary format used by KMyMoney. Please use an older version of KMyMoney (0.8.x)
that still supports this format to convert it to the new XML based format.

Expected Results:  
Instead of opening the file it is throwing the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 75 - Still Unstable!

2016-09-11 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/75/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 11 Sep 2016 13:01:34 +
Build duration: 17 min

CHANGE SET
Revision 2a0ddce46bedbc7063664a4216c75cc909f5971e by yurchor: (Fix minor typo)
  change: edit kmymoney/plugins/csvimport/csvwizard.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/23 (87%)FILES 178/231 (77%)CLASSES 178/231 (77%)LINE 21617/34574 
(63%)CONDITIONAL 34565/95859 (36%)

By packages
  
kmymoney
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 70/331 (21%)CONDITIONAL 
96/726 (13%)
kmymoney.converter
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 158/531 (30%)CONDITIONAL 
252/1674 (15%)
kmymoney.converter.tests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 372/374 (99%)CONDITIONAL 
344/694 (50%)
kmymoney.mymoney
FILES 50/60 (83%)CLASSES 50/60 (83%)LINE 4884/7586 
(64%)CONDITIONAL 4607/13489 (34%)
kmymoney.mymoney.payeeidentifier
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 66/168 (39%)CONDITIONAL 
22/218 (10%)
kmymoney.mymoney.payeeidentifier.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 24/30 (80%)CONDITIONAL 
19/44 (43%)
kmymoney.mymoney.storage
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 4171/6423 
(65%)CONDITIONAL 6056/18366 (33%)
kmymoney.mymoney.storage.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 2255/2576 
(88%)CONDITIONAL 3625/8224 (44%)
kmymoney.mymoney.tests
FILES 42/43 (98%)CLASSES 42/43 (98%)LINE 5915/6199 
(95%)CONDITIONAL 11925/24698 (48%)
kmymoney.payeeidentifier.ibanandbic
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 72/363 (20%)CONDITIONAL 
56/897 (6%)
kmymoney.payeeidentifier.ibanandbic.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 208/212 (98%)CONDITIONAL 
131/280 (47%)
kmymoney.payeeidentifier.nationalaccount
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/93 (5%)CONDITIONAL 
3/182 (2%)
kmymoney.payeeidentifier.unavailableplugin
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/34 (0%)CONDITIONAL 0/28 
(0%)
kmymoney.plugins.csvimport
FILES 3/9 (33%)CLASSES 3/9 (33%)LINE 153/3207 (5%)CONDITIONAL 
164/5950 (3%)
kmymoney.plugins.csvimport.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 158/160 (99%)CONDITIONAL 
184/366 (50%)
kmymoney.plugins.onlinetasks.dummy.tasks
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 15/36 (42%)CONDITIONAL 
5/12 (42%)
kmymoney.plugins.onlinetasks.interfaces.tasks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/6 (83%)CONDITIONAL 0/6 
(0%)
kmymoney.plugins.onlinetasks.interfaces.ui
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/1 (0%)CONDITIONAL 0/2 (0%)
kmymoney.plugins.onlinetasks.unavailabletask.tasks
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/30 (0%)CONDITIONAL 0/12 
(0%)
kmymoney.reports
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 1606/2753 
(58%)CONDITIONAL 2423/7575 (32%)
kmymoney.reports.tests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1451/1507 
(96%)CONDITIONAL 4602/9326 (49%)
kmymoney.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/25 (100%)CONDITIONAL 
47/94 (50%)
kmymoney.widgets
FILES 2/25 (8%)CLASSES 2/25 (8%)LINE 4/1929 (0%)CONDITIONAL 
4/2996 (0%)

Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

2016-09-11 Thread Allan Anderson


> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote:
> > It was actually on my todo list to remove the QIF facility as it no longer 
> > had any purpose.  It was a relict from early days before CSV import became 
> > fully established.
> > I had indicated this on the lists several times without receiving any 
> > protests.  It's possible, I suppose, that on implementation, a non-lister 
> > might discover that a much needed feature had been removed.  I would still 
> > have gone ahead, but the change would have had to be reverted in that 
> > circumstance.
> > Perhaps you see a need?
> 
> Łukasz Wojniłowicz wrote:
> I didn't know that you wanted to remove QIF facility. I don't use it 
> personally. Initially I wanted to move it as separate CSV->QIF converter but 
> it would involve the same steps you do during CSV import, so I left it where 
> it is.
> I think defeaturing CSV importer of QIF converter would be loss of work.
> 
> Allan Anderson wrote:
> It's certainly not causing any harm, that I'm aware of.  It was purely to 
> remove clutter.  No hard views, either way, though.
> 
> Łukasz Wojniłowicz wrote:
> We can hide it deep with an option through recent configuration dialog to 
> remove clutter, if all you devs think it would be a good idea :)
> 
> Allan, do you use CSV Importer from master branch? Lots of code have been 
> changed recently and I'm little bit concerned about usablity in all cases.

I'm afraid I have not had a lot of time lately, what with my hospital 
appointments, dental troubles and now my wife was admitted to hospital 10 days 
ago.  Also, I've been waiting on my distro, and as it happens only two days ago 
it released a new version.
As soon as I can find time, I'll try to upgrade, etc.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
---


On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> ---
> 
> (Updated Sept. 10, 2016, 4:35 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/, because it is so in files, that I 
> saw.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>



Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

2016-09-11 Thread Łukasz Wojniłowicz


> On Wrz 11, 2016, 12:09 po południu, Allan Anderson wrote:
> > It was actually on my todo list to remove the QIF facility as it no longer 
> > had any purpose.  It was a relict from early days before CSV import became 
> > fully established.
> > I had indicated this on the lists several times without receiving any 
> > protests.  It's possible, I suppose, that on implementation, a non-lister 
> > might discover that a much needed feature had been removed.  I would still 
> > have gone ahead, but the change would have had to be reverted in that 
> > circumstance.
> > Perhaps you see a need?
> 
> Łukasz Wojniłowicz wrote:
> I didn't know that you wanted to remove QIF facility. I don't use it 
> personally. Initially I wanted to move it as separate CSV->QIF converter but 
> it would involve the same steps you do during CSV import, so I left it where 
> it is.
> I think defeaturing CSV importer of QIF converter would be loss of work.
> 
> Allan Anderson wrote:
> It's certainly not causing any harm, that I'm aware of.  It was purely to 
> remove clutter.  No hard views, either way, though.

We can hide it deep with an option through recent configuration dialog to 
remove clutter, if all you devs think it would be a good idea :)

Allan, do you use CSV Importer from master branch? Lots of code have been 
changed recently and I'm little bit concerned about usablity in all cases.


- Łukasz


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
---


On Wrz 10, 2016, 6:35 po południu, Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> ---
> 
> (Updated Wrz 10, 2016, 6:35 po południu)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/, because it is so in files, that I 
> saw.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>



Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

2016-09-11 Thread Allan Anderson


> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote:
> > It was actually on my todo list to remove the QIF facility as it no longer 
> > had any purpose.  It was a relict from early days before CSV import became 
> > fully established.
> > I had indicated this on the lists several times without receiving any 
> > protests.  It's possible, I suppose, that on implementation, a non-lister 
> > might discover that a much needed feature had been removed.  I would still 
> > have gone ahead, but the change would have had to be reverted in that 
> > circumstance.
> > Perhaps you see a need?
> 
> Łukasz Wojniłowicz wrote:
> I didn't know that you wanted to remove QIF facility. I don't use it 
> personally. Initially I wanted to move it as separate CSV->QIF converter but 
> it would involve the same steps you do during CSV import, so I left it where 
> it is.
> I think defeaturing CSV importer of QIF converter would be loss of work.

It's certainly not causing any harm, that I'm aware of.  It was purely to 
remove clutter.  No hard views, either way, though.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
---


On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> ---
> 
> (Updated Sept. 10, 2016, 4:35 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/, because it is so in files, that I 
> saw.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>



Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

2016-09-11 Thread Łukasz Wojniłowicz


> On Wrz 11, 2016, 12:09 po południu, Allan Anderson wrote:
> > It was actually on my todo list to remove the QIF facility as it no longer 
> > had any purpose.  It was a relict from early days before CSV import became 
> > fully established.
> > I had indicated this on the lists several times without receiving any 
> > protests.  It's possible, I suppose, that on implementation, a non-lister 
> > might discover that a much needed feature had been removed.  I would still 
> > have gone ahead, but the change would have had to be reverted in that 
> > circumstance.
> > Perhaps you see a need?

I didn't know that you wanted to remove QIF facility. I don't use it 
personally. Initially I wanted to move it as separate CSV->QIF converter but it 
would involve the same steps you do during CSV import, so I left it where it is.
I think defeaturing CSV importer of QIF converter would be loss of work.


- Łukasz


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
---


On Wrz 10, 2016, 6:35 po południu, Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> ---
> 
> (Updated Wrz 10, 2016, 6:35 po południu)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/, because it is so in files, that I 
> saw.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>



Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

2016-09-11 Thread Allan Anderson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
---



It was actually on my todo list to remove the QIF facility as it no longer had 
any purpose.  It was a relict from early days before CSV import became fully 
established.
I had indicated this on the lists several times without receiving any protests. 
 It's possible, I suppose, that on implementation, a non-lister might discover 
that a much needed feature had been removed.  I would still have gone ahead, 
but the change would have had to be reverted in that circumstance.
Perhaps you see a need?

- Allan Anderson


On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> ---
> 
> (Updated Sept. 10, 2016, 4:35 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/, because it is so in files, that I 
> saw.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>



Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 74 - Still Unstable!

2016-09-11 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 11 Sep 2016 09:35:17 +
Build duration: 21 min

CHANGE SET
Revision 9bc55e58741c21dca99a6e9a15763d2f9a1036b5 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kmymoney/plugins/csvimport/kmm_csvimport.desktop
  change: edit kmymoney/plugins/csvexport/kmm_csvexport.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 
36 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/23 (87%)FILES 178/231 (77%)CLASSES 178/231 (77%)LINE 21617/34574 
(63%)CONDITIONAL 34567/95859 (36%)

By packages
  
kmymoney
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 70/331 (21%)CONDITIONAL 
96/726 (13%)
kmymoney.converter
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 158/531 (30%)CONDITIONAL 
252/1674 (15%)
kmymoney.converter.tests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 372/374 (99%)CONDITIONAL 
344/694 (50%)
kmymoney.mymoney
FILES 50/60 (83%)CLASSES 50/60 (83%)LINE 4884/7586 
(64%)CONDITIONAL 4609/13489 (34%)
kmymoney.mymoney.payeeidentifier
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 66/168 (39%)CONDITIONAL 
22/218 (10%)
kmymoney.mymoney.payeeidentifier.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 24/30 (80%)CONDITIONAL 
19/44 (43%)
kmymoney.mymoney.storage
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 4171/6423 
(65%)CONDITIONAL 6056/18366 (33%)
kmymoney.mymoney.storage.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 2255/2576 
(88%)CONDITIONAL 3625/8224 (44%)
kmymoney.mymoney.tests
FILES 42/43 (98%)CLASSES 42/43 (98%)LINE 5915/6199 
(95%)CONDITIONAL 11925/24698 (48%)
kmymoney.payeeidentifier.ibanandbic
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 72/363 (20%)CONDITIONAL 
56/897 (6%)
kmymoney.payeeidentifier.ibanandbic.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 208/212 (98%)CONDITIONAL 
131/280 (47%)
kmymoney.payeeidentifier.nationalaccount
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/93 (5%)CONDITIONAL 
3/182 (2%)
kmymoney.payeeidentifier.unavailableplugin
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/34 (0%)CONDITIONAL 0/28 
(0%)
kmymoney.plugins.csvimport
FILES 3/9 (33%)CLASSES 3/9 (33%)LINE 153/3207 (5%)CONDITIONAL 
164/5950 (3%)
kmymoney.plugins.csvimport.tests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 158/160 (99%)CONDITIONAL 
184/366 (50%)
kmymoney.plugins.onlinetasks.dummy.tasks
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 15/36 (42%)CONDITIONAL 
5/12 (42%)
kmymoney.plugins.onlinetasks.interfaces.tasks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 5/6 (83%)CONDITIONAL 0/6 
(0%)
kmymoney.plugins.onlinetasks.interfaces.ui
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/1 (0%)CONDITIONAL 0/2 (0%)
kmymoney.plugins.onlinetasks.unavailabletask.tasks
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/30 (0%)CONDITIONAL 0/12 
(0%)
kmymoney.reports
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 1606/2753 
(58%)CONDITIONAL 2423/7575 (32%)
kmymoney.reports.tests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1451/1507 
(96%)CONDITIONAL 4602/9326 (49%)
kmymoney.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/25 (100%)CONDITIONAL 
47/94 (50%)
kmymoney.widgets
FILES 2/25 (8%)CLASSES 2/25 (8%)LINE 4/1929 (0%)CONDITIONAL 
4/2996 (0%)