> On Dez. 25, 2016, 1:37 nachm., Łukasz Wojniłowicz wrote:
> > After this change, CSV Importer plugin isn't displayed in File->Import
> > menu, even after steps suggested in following post
> > http://kmymoney-devel.kde.narkive.com/hSaamIlT/plugins-path-in-master-branch
> > So please add making this working again to your TODO list.
Hi ?ukasz,
are the other plugins shown? Unfortunatly it will take a week (or two) before I
can have a look on this issue. However, I am quite sure I checked the
import/export plugins before I send this patch. Let me revaluate that…
Greetings
Christian
- Christian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129393/#review101572
---
On Nov. 26, 2016, 4:12 nachm., Christian David wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129393/
> ---
>
> (Updated Nov. 26, 2016, 4:12 nachm.)
>
>
> Review request for KMymoney.
>
>
> Repository: kmymoney
>
>
> Description
> ---
>
> Hi,
>
> this is my long overdue change on the plugin system. It actually started in
> Randa.
>
> Sorry for such a long review request! I think it is ready for publishing, I
> made this review request only to give everybody a chance to ask questions :)
>
>
> Commit 1
>
>
> This is a major change. Instead of a KPluginFactory based plugin
> loading, Qt's plugin system is used. The docu was adopeted to reflect
> this.
>
> Commit 2
>
>
> The plugins for onlineTasks are now loaded with QPluginLoader on demand.
> The necessary information is encoded in Qt's json plugin header.
>
> Commit 3
>
>
> Moved plugin loader out of kmm_plugin and put it into the executable
>
> The plugin shared library is for plugins now and does not include the
> loading of plugins (which was kind of wired). All loading operations of
> standard plugins is done in KMyMoneyApp now.
>
> Therefor the interface system for plugins needed do be reworked to
> great degree. Some overly complex operations were replaced by simpler
> ones. All plugins were adopted to that. Also it is more type safe now.
>
> Now the user configuration which plugins should be loaded or not is
> respected (standard plugins only).
>
> An old bug was fixed: If the configuration in the plugin settings
> changed the plugins are loaded/unloaded after the user accepts the
> dialog (perviously this was done when the checkbox was clicked).
>
> Todos
> =
>
> The new system is still not finished. However, it is a great step in
> the right direction. An uncomplete list of FIXMEs (or bugs?):
>
> 1. pluginloader.{h,cpp} are gui only now and should be merged into the
> settings dialog.
> 2. The UI for plugins still has some issues, e.g. the online banking
> plugins which are loaded on demand (and are not deactivatable) have a
> checkbox for loading and unloading which has no function.
> 3. Unloading plugins may not work correctly (I think it never did).
> 4. The payeeIdentifiers are not listet in the plugin settings page.
>
>
> Diffs
> -
>
> CMakeLists.txt 09970dd5626e308c443ea20ee20ecf8503b21209
> kmymoney/CMakeLists.txt acbe6a3c91a62a15871a0061486a7d0771b3a5e6
> kmymoney/dialogs/konlinetransferform.h
> e4761904d68a92471c0b05cc9e5b2bcd1461511d
> kmymoney/dialogs/konlinetransferform.cpp
> 07e73ab17f93cd8fd804b9d11ede2b049f76eefe
> kmymoney/dialogs/settings/ksettingsplugins.cpp
> 007a59d4be08fe779245dd5d52f664ebfcee447d
> kmymoney/kmymoney.h 8d10023b5e35be8f4449973ea16e0ec0cc0acca2
> kmymoney/kmymoney.cpp 043342dd87cbc03557c5e2b29eb3b9dfcd1083dd
> kmymoney/mymoney/onlinejobadministration.h
> e72d1a6e46c7c8bcc7cf05193e04bdc8bd9103f5
> kmymoney/mymoney/onlinejobadministration.cpp
> 52658747a44bc5477ccd75a531aef471b4553b19
> kmymoney/pluginloader.h PRE-CREATION
> kmymoney/pluginloader.cpp PRE-CREATION
> kmymoney/plugins/CMakeLists.txt fd7cad75256c0a43d7d1fd3a23b37cef7fab8bf9
> kmymoney/plugins/csvexport/CMakeLists.txt
> 9f2e29fd43e32cd3c6acc7f597c45d522eac4eaf
> kmymoney/plugins/csvexport/csvexport.json.in PRE-CREATION
> kmymoney/plugins/csvexport/csvexporterplugin.h
> f163ade2d59ae1b6eb32958a317384e77a658523
> kmymoney/plugins/csvexport/csvexporterplugin.cpp
> 31027c65111edbad8ca78b00f5b7df572056bb37
> kmymoney/plugins/csvexport/kmm_csvexport.desktop
> 957a9edc4101504e0db08378392e29358327b1c6
> kmymoney/plugins/csvimport/CMakeLists.txt
> c3e13285944f3624d69f7cc7cde0d4d9014a2a2c
> kmymoney/plugins/csvimport/csvimport.json.in PRE-CREATION
> kmymoney/plugins/csvimport/csvimporterplugin.h
> e66f9cf8e7bfdf9a431d7c57db2e905f5e89ec66
> kmymoney/plugins/csvimport/csvimporterplugin.cpp
> 9a28dca3efd54b82882ef71595439
