[kmymoney4] [Bug 380852] Reports - add a negative sign to expenses

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380852

Henry Miller  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380852] New: Reports - add a negative sign to expenses

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380852

Bug ID: 380852
   Summary: Reports - add a negative sign to expenses
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: FreeBSD
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: h...@millerfarm.com
  Target Milestone: ---

I'm using KMyMoney for a local organisation, and I need to present monthly
reports to the rest of the committee.

When I print out the "Income and Expenses this Month" report several of the old
people complain that they do not understand the report. They are not used to
looking at Income/Expense and inferring that expensive are negative.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380851] Add a Monthly report

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380851

--- Comment #1 from Henry Miller  ---
That is starting and final account balance. I need to report the net change,
but have more details available for those who are interested.

Right now this requires two different reports (or manually preparing it in a
spreadsheet)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380851] New: Add a Monthly report

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380851

Bug ID: 380851
   Summary: Add a Monthly report
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: FreeBSD
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: h...@millerfarm.com
  Target Milestone: ---

I'm using KMyMoney for a local organisation, and I need to present monthly
reports to the rest of the committee. There is no report that fits the
information that I need to present.  What I want is mostly the "Income and
Expenses this month" report, but with the starting and final balance.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380850] New: Add Reports for last month/last year

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380850

Bug ID: 380850
   Summary: Add Reports for last month/last year
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: FreeBSD
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: h...@millerfarm.com
  Target Milestone: ---

KMyMoney has many helpful reports for this month (ie Income and Expenses this
month), but most often I just did my reconciliation for the previous month and
now I want to see the report. It seems like this is a common report timeframe
and so I shouldn't have to manually configure/ enter the date to get this
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380849] New: Multiple reports on one page

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380849

Bug ID: 380849
   Summary: Multiple reports on one page
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: FreeBSD
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: h...@millerfarm.com
  Target Milestone: ---

I'm using KMyMoney for a local organisation, and I need to present monthly
reports to the rest of the committee. I often print several reports, each takes
only half a page of paper wasting the other half. It would be nice if I could
put two reports on one page saving paper.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380848] Remove "All currencies converted to US Dollars" from reports when not needed.

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380848

Henry Miller  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 380848] New: Remove "All currencies converted to US Dollars" from reports when not needed.

2017-06-04 Thread Henry Miller 
https://bugs.kde.org/show_bug.cgi?id=380848

Bug ID: 380848
   Summary: Remove "All currencies converted to US Dollars" from
reports when not needed.
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: FreeBSD
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: h...@millerfarm.com
  Target Milestone: ---

I'm using KMyMoney for a local organisation, and I need to present monthly
reports to the rest of the committee.  We only deal in US dollars and as a
local focused origination there is no reason to expect to ever get other
currency (there may even be legal implications to foreign transactions).  As
such the line on reports indicating "all currencies converted to US dollars" is
at best not required and may even be misleading.

I realise that this notice is important when someone has transactions/accounts
in multiple currencies, but I suspect that isn't the most common use case. In
any case I don't think it should br brought out when not required.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130143: Add support for dedicated opening balance account.

2017-06-04 Thread Thomas Baumgart 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103278
---




kmymoney/converter/mymoneytemplate.cpp (line 416)


I agree with Christian here. The flag is either present in the template or 
not. That should be sufficient. Plus, I don't see a usage of the attribute 
'value' in this patch at all. So, from MPOV, the 'value' attribute can be 
removed.



kmymoney/dialogs/knewaccountdlg.cpp (line 222)


You could write 

m_qcheckboxOpeningBalance->setEnabled(false);
m_qcheckboxOpeningBalance->setToolTip(i18n("Reason"));

here infront of the if() statement and only enable it inside in case no 
other opening balance account was found. In case the reason differs 
(transactions found), update the tooltip reason. Also update the tooltip 
contents in case one can mark the account as opening balance account with text 
which explains what this is good for (which I expected to find in the ui file 
but did not).

This code layout saves you the multiple else paths at the end.



kmymoney/dialogs/knewaccountdlg.cpp (line 239)


Agreed, it might be not so wise to hide the widget in case the account 
cannot be made an opening balance account.

I just verified that the tooltip is also shown when a widget is disabled. 
So showing a descriptive text in the tooltip whenever the widget is disabled is 
a good idea.



kmymoney/dialogs/knewaccountdlg.cpp (line 240)


You could simplify this whole basic block into a single instruction with


m_qcheckboxOpeningBalance->setEnabled(MyMoneyFile::instance()->transactionCount(account.id())
 == 0);


- Thomas Baumgart


On Mai 30, 2017, 9:45 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> ---
> 
> (Updated Mai 30, 2017, 9:45 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
> http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This patch introduce a feature to specify a dedicated account
> to be used as opening balance account instead of using an account
> with a predefined name which may be language specific.
> 
> The "opening balance account" flag could be set in the account
> editor if no other account contains this flag. Also changing
> the state of the flag is only possible if no transactions are
> assigned to the account having this flag.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a related template account flag if specified
> in the following form
> 
> 
>
> 
> 
> If specified the template admin needs to make sure that only one
> template account has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> BUG:370290
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/mymoneytemplate.cpp 
> 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui 
> bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 
> 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 
> 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 
> 40b103ca965e0a1973b6fd0a351ddb976aa10471 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> ---
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given 
> account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an 
> additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if 
> transactions are assigned to the opening balance account -> check box is 
> disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the 
> template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 127678: Register metatypes that are used in Qt Designer files to eliminate warnings.

2017-06-04 Thread Christian David 


> On April 22, 2016, 8:19 vorm., Christian David wrote:
> > Hi Mitch,
> > 
> > according to the [Qt 
> > Docu](http://doc.qt.io/qt-5/qmetatype.html#qRegisterMetaType-1) 
> > ```qRegisterMetaType``` is (only) needed under some circumstances:
> > 
> > To use the type T in QVariant, using Q_DECLARE_METATYPE() is 
> > sufficient. To use the type T in queued signal and slot connections, 
> > qRegisterMetaType() must be called before the first connection is 
> > established.
> > 
> > To prevent complicated issues if we use queued connections ourself in the 
> > future the ```qRegisterMetaType``` should go somewhere else. I think it 
> > should be ```mymoneymoney.cpp``` for ```MyMoneyMoney``` but I am unsure 
> > here.
> 
> Mitch Frazier wrote:
> In terms of logically where it ought to go I don't know, I'm not that 
> familiar with the organization of the code base.  However, in terms of 
> satisfying the requirement that it "must be called before the first 
> connection is established," making it a static variable initializer should be 
> sufficient regardless of where it is placed.  Static initializers are run 
> when the .so is loaded so they'll be executed before any "real" code gets run.
> 
> Christian David wrote:
> In your case they are loaded in another (kind of unrelated) library than 
> the library of the original objects. This violates the concept of enclosed 
> units. To be specific; the ```qRegisterMetaType()``` call should be in the 
> ```kmm_mymoney``` library. To suppress the warnings only they could go in the 
> ```kmymoneywidgets``` library (but not ```kmm_widgets```). Your static 
> initializer trick is cool.
> 
> Thomas Baumgart wrote:
> Ping: Christian / Mitch what is the status on this one? Did you come to a 
> conclusion what to do with the patch?

I recommend to use my recommended relocation of the ´´´qRegisterMetaType()´´´.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127678/#review94753
---


On April 22, 2016, 5:01 nachm., Mitch Frazier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127678/
> ---
> 
> (Updated April 22, 2016, 5:01 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Register metatypes to eliminate Qt Desinger warnings.
> 
> Registering metatypes for a type used in a widget eliminates
> the following types of warnings from Qt Designer on start up
> (displayed when designer is started from a console window):
> 
> QMetaProperty::read: Unable to handle unregistered datatype
>   '' for property '::'
> 
> 
> Diffs
> -
> 
>   kmymoney/widgets/kmymoneycurrencyselector.cpp 41be539 
>   kmymoney/widgets/kmymoneyedit.cpp ac79db7 
> 
> Diff: https://git.reviewboard.kde.org/r/127678/diff/
> 
> 
> Testing
> ---
> 
> Tested dialogs that use the data types.
> 
> 
> Thanks,
> 
> Mitch Frazier
> 
>

Re: Review Request 130009: Use qCDebug instead of qDebug

2017-06-04 Thread Christian David 


> On Juni 4, 2017, 11:36 vorm., Christian David wrote:
> > I suggest to discard this review request. Mainly because I do not think 
> > that we will write the long text ```qCDebug(LOG_KMYMONEY)``` in future. 
> > Maybe we can use this for some submodules of KMyMoney in future.

Btw: For what do you need or want this?


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130009/#review103275
---


On März 13, 2017, Mittag, José Arthur Benetasso Villanova wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130009/
> ---
> 
> (Updated März 13, 2017, Mittag)
> 
> 
> Review request for KMymoney and José Arthur Benetasso Villanova.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Use qCDebug instead of qDebug
> 
> 
> Diffs
> -
> 
>   kmymoney/CMakeLists.txt 585c7d4 
>   kmymoney/converter/existingtransactionmatchfinder.cpp 7bedd28 
>   kmymoney/converter/mymoneygncreader.cpp 4c6d28c 
>   kmymoney/converter/mymoneyqifreader.cpp 3ad6723 
>   kmymoney/converter/mymoneyqifwriter.cpp da796a3 
>   kmymoney/converter/mymoneystatementreader.cpp 825b490 
>   kmymoney/converter/scheduledtransactionmatchfinder.cpp 4713a2b 
>   kmymoney/converter/tests/converter-test.cpp 3b596ee 
>   kmymoney/converter/transactionmatchfinder.cpp 56e97dd 
>   kmymoney/converter/webpricequote.cpp 15b1467 
>   kmymoney/dialogs/kgeneratesqldlg.cpp 5d20c1d 
>   kmymoney/dialogs/kselectdatabasedlg.cpp c281fc8 
>   kmymoney/kmymoney.h dd37972 
>   kmymoney/kmymoney.cpp 674f251 
>   kmymoney/kmymoneyutils.cpp 0492578 
>   kmymoney/logging.h PRE-CREATION 
>   kmymoney/logging.cpp PRE-CREATION 
>   kmymoney/main.cpp 77d68a7 
>   kmymoney/models/accountsmodel.cpp 12aac8d 
>   kmymoney/models/costcentermodel.cpp ac2d671 
>   kmymoney/models/ledgermodel.cpp 47e7b06 
>   kmymoney/models/modeltest.cpp 225e5de 
>   kmymoney/models/payeesmodel.cpp 35ff045 
>   kmymoney/mymoney/CMakeLists.txt 33b6177 
>   kmymoney/mymoney/mymoneyfile.h 2494af3 
>   kmymoney/mymoney/mymoneyfile.cpp d39a1d6 
>   kmymoney/mymoney/mymoneyforecast.cpp b286a85 
>   kmymoney/mymoney/onlinejobadministration.cpp d5f44f6 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 4a68175 
>   kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp dbaf6d0 
>   kmymoney/mymoney/tests/mymoneymoney-test.cpp ef1dd26 
>   kmymoney/mymoney/tests/mymoneyschedule-test.cpp 5c911fe 
>   kmymoney/mymoney/tests/mymoneytransaction-test.cpp f6d52c6 
>   kmymoney/plugins/CMakeLists.txt 6b235fb 
>   kmymoney/plugins/csvexport/CMakeLists.txt 454d7d2 
>   kmymoney/plugins/csvexport/csvwriter.cpp 83365bb 
>   kmymoney/plugins/csvimport/csvwizard.cpp e9ca8a6 
>   kmymoney/plugins/icalendarexport/CMakeLists.txt e30245f 
>   kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp ed14916 
>   kmymoney/plugins/kbanking/mymoneybanking.cpp 3e2f25b 
>   kmymoney/plugins/ofximport/dialogs/CMakeLists.txt b913db8 
>   kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp 2ddbb39 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp cff2ed9 
>   kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 83be16e 
>   kmymoney/plugins/reconciliationreport/CMakeLists.txt b28dc02 
>   kmymoney/plugins/reconciliationreport/reconciliationreport.cpp ee2d42f 
>   kmymoney/reports/kreportchartview.cpp d1f0c51 
>   kmymoney/reports/pivottable.cpp 833dc45 
>   kmymoney/reports/querytable.cpp 4d5a843 
>   kmymoney/reports/reporttable.cpp 1acec56 
>   kmymoney/reports/tests/reportstestcommon.cpp f64d3b6 
>   kmymoney/tests/kmymoneyutils-test.h 3faac41 
>   kmymoney/views/kforecastview.cpp 13c8b1a 
>   kmymoney/views/kmymoneyview.cpp 91750fa 
>   kmymoney/views/konlinejoboutbox.cpp 0708346 
>   kmymoney/views/kpayeesview.cpp fbe6fd0 
>   kmymoney/views/kreportsview.cpp a98d5b8 
>   kmymoney/views/ktagsview.cpp f361a4b 
>   kmymoney/views/ledgerdelegate.cpp 7274966 
>   kmymoney/views/ledgerview.cpp 8807d40 
>   kmymoney/views/newspliteditor.cpp 707117a 
>   kmymoney/views/newtransactioneditor.cpp b7f070d 
>   kmymoney/views/simpleledgerview.cpp 6793fdf 
>   kmymoney/views/splitdelegate.cpp 510d55f 
>   kmymoney/views/splitdialog.cpp becdfcf 
>   kmymoney/widgets/CMakeLists.txt 7560682 
>   kmymoney/widgets/kmymoneymvccombo.cpp 29e378f 
>   kmymoney/widgets/transaction.cpp 4061ae2 
> 
> Diff: https://git.reviewboard.kde.org/r/130009/diff/
> 
> 
> Testing
> ---
> 
> For now just compiled
> 
> 
> Thanks,
> 
> José Arthur Benetasso Villanova
> 
>

Re: Review Request 130009: Use qCDebug instead of qDebug

2017-06-04 Thread Christian David 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130009/#review103275
---



I suggest to discard this review request. Mainly because I do not think that we 
will write the long text ```qCDebug(LOG_KMYMONEY)``` in future. Maybe we can 
use this for some submodules of KMyMoney in future.

- Christian David


On März 13, 2017, Mittag, José Arthur Benetasso Villanova wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130009/
> ---
> 
> (Updated März 13, 2017, Mittag)
> 
> 
> Review request for KMymoney and José Arthur Benetasso Villanova.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Use qCDebug instead of qDebug
> 
> 
> Diffs
> -
> 
>   kmymoney/CMakeLists.txt 585c7d4 
>   kmymoney/converter/existingtransactionmatchfinder.cpp 7bedd28 
>   kmymoney/converter/mymoneygncreader.cpp 4c6d28c 
>   kmymoney/converter/mymoneyqifreader.cpp 3ad6723 
>   kmymoney/converter/mymoneyqifwriter.cpp da796a3 
>   kmymoney/converter/mymoneystatementreader.cpp 825b490 
>   kmymoney/converter/scheduledtransactionmatchfinder.cpp 4713a2b 
>   kmymoney/converter/tests/converter-test.cpp 3b596ee 
>   kmymoney/converter/transactionmatchfinder.cpp 56e97dd 
>   kmymoney/converter/webpricequote.cpp 15b1467 
>   kmymoney/dialogs/kgeneratesqldlg.cpp 5d20c1d 
>   kmymoney/dialogs/kselectdatabasedlg.cpp c281fc8 
>   kmymoney/kmymoney.h dd37972 
>   kmymoney/kmymoney.cpp 674f251 
>   kmymoney/kmymoneyutils.cpp 0492578 
>   kmymoney/logging.h PRE-CREATION 
>   kmymoney/logging.cpp PRE-CREATION 
>   kmymoney/main.cpp 77d68a7 
>   kmymoney/models/accountsmodel.cpp 12aac8d 
>   kmymoney/models/costcentermodel.cpp ac2d671 
>   kmymoney/models/ledgermodel.cpp 47e7b06 
>   kmymoney/models/modeltest.cpp 225e5de 
>   kmymoney/models/payeesmodel.cpp 35ff045 
>   kmymoney/mymoney/CMakeLists.txt 33b6177 
>   kmymoney/mymoney/mymoneyfile.h 2494af3 
>   kmymoney/mymoney/mymoneyfile.cpp d39a1d6 
>   kmymoney/mymoney/mymoneyforecast.cpp b286a85 
>   kmymoney/mymoney/onlinejobadministration.cpp d5f44f6 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 4a68175 
>   kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp dbaf6d0 
>   kmymoney/mymoney/tests/mymoneymoney-test.cpp ef1dd26 
>   kmymoney/mymoney/tests/mymoneyschedule-test.cpp 5c911fe 
>   kmymoney/mymoney/tests/mymoneytransaction-test.cpp f6d52c6 
>   kmymoney/plugins/CMakeLists.txt 6b235fb 
>   kmymoney/plugins/csvexport/CMakeLists.txt 454d7d2 
>   kmymoney/plugins/csvexport/csvwriter.cpp 83365bb 
>   kmymoney/plugins/csvimport/csvwizard.cpp e9ca8a6 
>   kmymoney/plugins/icalendarexport/CMakeLists.txt e30245f 
>   kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp ed14916 
>   kmymoney/plugins/kbanking/mymoneybanking.cpp 3e2f25b 
>   kmymoney/plugins/ofximport/dialogs/CMakeLists.txt b913db8 
>   kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp 2ddbb39 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp cff2ed9 
>   kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 83be16e 
>   kmymoney/plugins/reconciliationreport/CMakeLists.txt b28dc02 
>   kmymoney/plugins/reconciliationreport/reconciliationreport.cpp ee2d42f 
>   kmymoney/reports/kreportchartview.cpp d1f0c51 
>   kmymoney/reports/pivottable.cpp 833dc45 
>   kmymoney/reports/querytable.cpp 4d5a843 
>   kmymoney/reports/reporttable.cpp 1acec56 
>   kmymoney/reports/tests/reportstestcommon.cpp f64d3b6 
>   kmymoney/tests/kmymoneyutils-test.h 3faac41 
>   kmymoney/views/kforecastview.cpp 13c8b1a 
>   kmymoney/views/kmymoneyview.cpp 91750fa 
>   kmymoney/views/konlinejoboutbox.cpp 0708346 
>   kmymoney/views/kpayeesview.cpp fbe6fd0 
>   kmymoney/views/kreportsview.cpp a98d5b8 
>   kmymoney/views/ktagsview.cpp f361a4b 
>   kmymoney/views/ledgerdelegate.cpp 7274966 
>   kmymoney/views/ledgerview.cpp 8807d40 
>   kmymoney/views/newspliteditor.cpp 707117a 
>   kmymoney/views/newtransactioneditor.cpp b7f070d 
>   kmymoney/views/simpleledgerview.cpp 6793fdf 
>   kmymoney/views/splitdelegate.cpp 510d55f 
>   kmymoney/views/splitdialog.cpp becdfcf 
>   kmymoney/widgets/CMakeLists.txt 7560682 
>   kmymoney/widgets/kmymoneymvccombo.cpp 29e378f 
>   kmymoney/widgets/transaction.cpp 4061ae2 
> 
> Diff: https://git.reviewboard.kde.org/r/130009/diff/
> 
> 
> Testing
> ---
> 
> For now just compiled
> 
> 
> Thanks,
> 
> José Arthur Benetasso Villanova
> 
>

Re: Review Request 130143: Add support for dedicated opening balance account.

2017-06-04 Thread Christian David 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103274
---



Here are some things that came to my mind while reading through this review 
request. Unfortunatly I cannot try the patch because I cannot compile the 4.8 
branch.

What happens if the user creates a new account (no opening balances account) 
and enters a opening balance and there is no opening balances account, yet? Is 
a opening balance account created (silently)? The user can rename it later then 
(less user interaction, so this is my preferred behavior).

What if the user creates a opening balances account with a opening balance?


kmymoney/converter/mymoneytemplate.cpp (line 416)


I think setting a value is not needed. Also someone who only reads the XML 
file could think setting ```value="0"``` could deactivate the flag. Then it 
would be ``.



kmymoney/dialogs/knewaccountdlg.cpp (line 239)


This could confuse the user. Because he selected his new account to become 
an opening balances account but this option is silently ignored.

To solve this the checkbox to make an account an opening balances account 
could be disabled and a notice or label inform the user why.



kmymoney/dialogs/knewaccountdlg.cpp (line 243)


```transactionList.isEmpty()``` is faster



kmymoney/mymoney/mymoneyfile.cpp (line 1104)


The RegExp could be replaced by ```QString::startsWith()```

http://doc.qt.io/qt-5/qstring.html#startsWith



kmymoney/mymoney/mymoneyfile.cpp (line 1107)


I know you did not write but I see it now: The ```if```s could be combinde 
with ```&&```? Also ```(*it).foobar()``` is ```it->foobar()```.


- Christian David


On Mai 30, 2017, 9:45 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> ---
> 
> (Updated Mai 30, 2017, 9:45 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
> http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This patch introduce a feature to specify a dedicated account
> to be used as opening balance account instead of using an account
> with a predefined name which may be language specific.
> 
> The "opening balance account" flag could be set in the account
> editor if no other account contains this flag. Also changing
> the state of the flag is only possible if no transactions are
> assigned to the account having this flag.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a related template account flag if specified
> in the following form
> 
> 
>
> 
> 
> If specified the template admin needs to make sure that only one
> template account has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> BUG:370290
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/mymoneytemplate.cpp 
> 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui 
> bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 
> 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 
> 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 
> 40b103ca965e0a1973b6fd0a351ddb976aa10471 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> ---
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given 
> account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an 
> additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if 
> transactions are assigned to the opening balance account -> check box is 
> disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the 
> template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>