[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 --- Comment #10 from Ralf Habacker --- Git commit 3761846aa319733dbe763b4e5a0cce92c7048d7f by Ralf Habacker. Committed on 18/07/2017 at 04:46. Pushed by habacker into branch '4.8'. Fixup for commit e2902141 Make net worth graph and report configuration account filter to be independent from expert mode. Expert mode seems to be used already to much to be able to switch off. Instead enable equity accounts in account filter if report is of type eAccount. M +4-4kmymoney/dialogs/kfindtransactiondlg.cpp M +4-2kmymoney/dialogs/kfindtransactiondlg.h M +1-1kmymoney/dialogs/kreportconfigurationfilterdlg.cpp M +0-4kmymoney/mymoney/mymoneyreport.cpp https://commits.kde.org/kmymoney/3761846aa319733dbe763b4e5a0cce92c7048d7f -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 --- Comment #11 from Ralf Habacker --- Git commit 2365b64e44350592fff8b307c2a98486834fa59b by Ralf Habacker. Committed on 17/07/2017 at 20:23. Pushed by habacker into branch '4.8'. Add code to dump report configuration M +52 -0kmymoney/mymoney/mymoneyreport.cpp M +16 -0kmymoney/mymoney/mymoneyreport.h https://commits.kde.org/kmymoney/2365b64e44350592fff8b307c2a98486834fa59b --- Comment #10 from Ralf Habacker --- Git commit 3761846aa319733dbe763b4e5a0cce92c7048d7f by Ralf Habacker. Committed on 18/07/2017 at 04:46. Pushed by habacker into branch '4.8'. Fixup for commit e2902141 Make net worth graph and report configuration account filter to be independent from expert mode. Expert mode seems to be used already to much to be able to switch off. Instead enable equity accounts in account filter if report is of type eAccount. M +4-4kmymoney/dialogs/kfindtransactiondlg.cpp M +4-2kmymoney/dialogs/kfindtransactiondlg.h M +1-1kmymoney/dialogs/kreportconfigurationfilterdlg.cpp M +0-4kmymoney/mymoney/mymoneyreport.cpp https://commits.kde.org/kmymoney/3761846aa319733dbe763b4e5a0cce92c7048d7f -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 382327] Release kf5 version
https://bugs.kde.org/show_bug.cgi?id=382327 --- Comment #5 from Matthias --- Plasma also do not provide all features from its KDE SC 4 incarnation and its officially released.. ;) -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports
https://bugs.kde.org/show_bug.cgi?id=382427 --- Comment #2 from Ralf Habacker --- The problem is located inside class void KDChart::AbstractDiagram::Private methods void paintDataValueText( const AbstractDiagram* diag, QPainter* painter, const QModelIndex& index, const QPointF& pos, double value, bool justCalculateRect=false, QRectF* cumulatedBoundingRect=0 ) and QString roundValues( double value, const int decimalPos, const int decimalDigits) const; They simply use QString::number(value) with default conversation settings which are QString::number(value, 'g', 6). A number of 1800 is returned as "1.80e+7". Also in KReportChartView::drawPivotChart() there is used dataValueAttr.setDecimalDigits(MyMoneyMoney::denomToPrec(MyMoneyFile::instance()->baseCurrency().smallestAccountFraction())); which limits the number of digits to 2 which results into 1.80 for the mentioned value 1800. Another example is 180.000 which is displayed also as 1.80. The fix is to refactor the mentioned methods. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 --- Comment #9 from Ralf Habacker --- (In reply to David Houlden from comment #8) > Anonymous file now uploaded to this bug. Thanks > Ralf, you really need to compile a KMyMoney from git prior to the offending > commit in order to see what I > reported. I'm aware of that equity accounts are not included in the net worth report before this commit. Unfortunally there is a reason why this commit has been added - to include all accounts into the "Transactions by account" and other reports which is required to support small companies. Now we need to find a way to support both. I guess that the problem is that different report types uses the same set of initialization which inferences here. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 --- Comment #8 from David Houlden --- Anonymous file now uploaded to this bug. Ralf, you really need to compile a KMyMoney from git prior to the offending commit in order to see what I reported. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 --- Comment #7 from David Houlden --- Created attachment 106680 --> https://bugs.kde.org/attachment.cgi?id=106680&action=edit Anonymous KMyMoney file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 David Houlden changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|FIXED |--- --- Comment #6 from David Houlden --- Ralf, your latest fix does not correct the graph for me. I have always had "show equity accounts" selected in KMyMoney settings since it became available (probably years ago) but the Net Worth graph changed after commit 67d5ee7055dd3b0277423cd07ae92ea205f4b6af. I cannot see why the amount in an opening balance account should be subtracted from the total Net Worth on the graph as I described. The Net worth shown elsewhere is correct. The anonymous file I created the images above from is my own KMYMoney file with many years of history in it. I will post the anon file to this bug so you can investigate with that file. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports
https://bugs.kde.org/show_bug.cgi?id=382427 Ralf Habacker changed: What|Removed |Added Summary|Incorrect formatting of |Incorrect formatting of |number display of point |number display of point |label |label in graph reports --- Comment #1 from Ralf Habacker --- The mentioned screenshot shows that point labels are formatted wrongly. For example the number is 18.000.000 and the label shows 1.80. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382427] New: Incorrect formatting of number display of point label
https://bugs.kde.org/show_bug.cgi?id=382427 Bug ID: 382427 Summary: Incorrect formatting of number display of point label Product: kmymoney4 Version: 4.8.0 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: ralf.habac...@freenet.de Target Milestone: --- https://bugsfiles.kde.org/attachment.cgi?id=106647 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 381786] Make release 4.8.1
https://bugs.kde.org/show_bug.cgi?id=381786 Bug 381786 depends on bug 382293, which changed state. Bug 382293 Summary: Irritating backup file modification time on Windows https://bugs.kde.org/show_bug.cgi?id=382293 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 Ralf Habacker changed: What|Removed |Added Version Fixed In||4.8.1 Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kmy ||money/e29021419e09583f8995a ||b9b27c9a802ab584826 Status|UNCONFIRMED |RESOLVED --- Comment #5 from Ralf Habacker --- Git commit e29021419e09583f8995ab9b27c9a802ab584826 by Ralf Habacker. Committed on 17/07/2017 at 11:42. Pushed by habacker into branch '4.8'. Only add equity accounts to reports if expert mode is enabled This restores Net Worth Graph behaviour in non export mode. Thanks to David Houlden for pointing out. FIXED-IN:4.8.1 M +2-1kmymoney/dialogs/kfindtransactiondlg.cpp M +7-4kmymoney/mymoney/mymoneyreport.cpp https://commits.kde.org/kmymoney/e29021419e09583f8995ab9b27c9a802ab584826 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382293] Irritating backup file modification time on Windows
https://bugs.kde.org/show_bug.cgi?id=382293 Ralf Habacker changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Version Fixed In||4.8.1 Latest Commit||https://commits.kde.org/kmy ||money/5cf2e46c185098bbd141c ||f4f80693df19edb48af --- Comment #5 from Ralf Habacker --- Git commit 5cf2e46c185098bbd141cf4f80693df19edb48af by Ralf Habacker. Committed on 13/07/2017 at 09:38. Pushed by habacker into branch '4.8'. Fix 'Irritating backup file modification time on Windows' MS way to touch modification date of a copied file is to append '+nul' to the source filename. FIXED-IN:4.8.1 M +2-2kmymoney/kmymoney.cpp https://commits.kde.org/kmymoney/5cf2e46c185098bbd141cf4f80693df19edb48af -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit
https://bugs.kde.org/show_bug.cgi?id=382378 Ralf Habacker changed: What|Removed |Added CC||ralf.habac...@freenet.de --- Comment #4 from Ralf Habacker --- Created attachment 106679 --> https://bugs.kde.org/attachment.cgi?id=106679&action=edit KMymoney test file I've tried to reproduce this issue with the appended test file. With this test case I can confirm that with recent code from 4.8 branch the net worth graph is similar to attachment 106647 when unselecting the opening balance account in the account tab of the report configuration and like attachment 106648 when selecting opening balance account I cannot confirm that changing show/hide equity accounts in kmymoney settings creates a graph like shown in attachment 106649. Because the test file may not fit exactly into your use case, feel free to update it according to your related transactions to be able to get -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 382327] Release kf5 version
https://bugs.kde.org/show_bug.cgi?id=382327 --- Comment #4 from Matthias --- I mean its far enough to release a version. Its in productive usage here for years. Currently, it seems like KmyMoney is not in development anymore. Users just look often at the page of KDE and so on. Not on Github. Plus, much package maintainers refuse to use the new version, even when they ship Plasma5 with all the kf5 packages, which create conflicts again. What speaks against a pre release or something? -- You are receiving this mail because: You are the assignee for the bug.
