Re: Review Request 130234: Fix 'Missing buttons for adding/removing entries in currency edit dialog'

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130234/
---

(Updated Aug. 25, 2017, 6:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KMymoney and Jack Ostroff.


Changes
---

Submitted with commit b5c4ff902e2d541f09010f510408dd00b5ff6f6b by Ralf Habacker 
to branch 4.8.


Bugs: 383831
http://bugs.kde.org/show_bug.cgi?id=383831


Repository: kmymoney


Description
---

Patch adds requested buttons


Diffs
-

  kmymoney/dialogs/kcurrencyeditdlg.h 712420304caf55a1ae762a6d715568a908de4fc0 
  kmymoney/dialogs/kcurrencyeditdlg.cpp 
58b7c20c083a73730dedd4faa3607b89c5dd00ca 
  kmymoney/kmymoney.cpp 9c372746c658d9562dfde1eec25a472e95a81ebe 

Diff: https://git.reviewboard.kde.org/r/130234/diff/


Testing
---

- branch compiled
- tested adding entry
- tested removing entry


Thanks,

Ralf Habacker

[kmymoney4] [Bug 383831] Missing buttons for adding/removing entries in currency edit dialog

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383831

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In||4.8.1
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kmy
   ||money/b5c4ff902e2d541f09010
   ||f510408dd00b5ff6f6b

--- Comment #3 from Ralf Habacker  ---
Git commit b5c4ff902e2d541f09010f510408dd00b5ff6f6b by Ralf Habacker.
Committed on 25/08/2017 at 06:52.
Pushed by habacker into branch '4.8'.

Fix 'Missing buttons for adding/removing entries in currency edit dialog'

FIXED-IN:4.8.1
REVIEW:130234

M  +12   -1kmymoney/dialogs/kcurrencyeditdlg.cpp
M  +3-0kmymoney/dialogs/kcurrencyeditdlg.h
M  +2-0kmymoney/kmymoney.cpp

https://commits.kde.org/kmymoney/b5c4ff902e2d541f09010f510408dd00b5ff6f6b

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383831] Missing buttons for adding/removing entries in currency edit dialog

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383831

--- Comment #2 from Ralf Habacker  ---
(In reply to NSLW from comment #1)
> Please look at
> https://phabricator.kde.org/D5271
> and determine if it's worth having this bug open for 4.8.
I think this patch is too big to be applied to 4.8 and contains unrelated stuff
which will break present functionality and requires too much work to test. 

For a dedicated patch for this issue see
https://git.reviewboard.kde.org/r/130234/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130234: Fix 'Missing buttons for adding/removing entries in currency edit dialog'

[Thomas Baumgart]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130234/#review103650
---


Ship it!




This should be the last feature addition to 4.8.  We should concentrate on the 
KF5 based version. What we have added in the past is way more than a bugfix 
release.

- Thomas Baumgart


On Aug. 24, 2017, 4:18 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130234/
> ---
> 
> (Updated Aug. 24, 2017, 4:18 nachm.)
> 
> 
> Review request for KMymoney and Jack Ostroff.
> 
> 
> Bugs: 383831
> http://bugs.kde.org/show_bug.cgi?id=383831
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Patch adds requested buttons
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/kcurrencyeditdlg.h 
> 712420304caf55a1ae762a6d715568a908de4fc0 
>   kmymoney/dialogs/kcurrencyeditdlg.cpp 
> 58b7c20c083a73730dedd4faa3607b89c5dd00ca 
>   kmymoney/kmymoney.cpp 9c372746c658d9562dfde1eec25a472e95a81ebe 
> 
> Diff: https://git.reviewboard.kde.org/r/130234/diff/
> 
> 
> Testing
> ---
> 
> - branch compiled
> - tested adding entry
> - tested removing entry
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

[kmymoney4] [Bug 383990] KDChart update has made graph X-Axis unreadable

[David Houlden]

https://bugs.kde.org/show_bug.cgi?id=383990

--- Comment #1 from David Houlden  ---
Created attachment 107509
  --> https://bugs.kde.org/attachment.cgi?id=107509&action=edit
Graph before KDChart update

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383990] New: KDChart update has made graph X-Axis unreadable

[David Houlden]

https://bugs.kde.org/show_bug.cgi?id=383990

Bug ID: 383990
   Summary: KDChart update has made graph X-Axis unreadable
   Product: kmymoney4
   Version: 4.8.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

Created attachment 107508
  --> https://bugs.kde.org/attachment.cgi?id=107508&action=edit
Graph after KDChart update

With the recent update to KDChart 2.6 in 4.8 the X-Axis labels on my price
charts are now unreadable. My charts show one year of history and all the dates
are piled on top of each other along the X-Axis. See attached screenshots.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383977] New: In Accounts view, do not change expand/collapse state after editing an account

[Jack]

https://bugs.kde.org/show_bug.cgi?id=383977

Bug ID: 383977
   Summary: In Accounts view, do not change expand/collapse state
after editing an account
   Product: kmymoney4
   Version: git (master)
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: ostrof...@users.sourceforge.net
  Target Milestone: ---

The Accounts View defaults to displaying fully expanded.  If I collapse all
accounts (to not show equities, for example) and then edit an account (to
change it's name) when I OK the edit, the list is fully expanded again.  This
is very annoying, since I only want to see the account names, not all the
equities (yes this is for investment accounts.)  I do not want to disable
showing the equities, since I do generally want to see them, but if I am (for
example) making systemic changes to account names (such as to include partial
account number in the name) I have several edits to do, and it is very
inconvenient to have to reset the expand/collapse after every edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Retirement of Reviewboard - Transition to Phabricator

[Jack]

On 2017.08.24 10:02, Yuri Chornoivan wrote:

четвер, 24 серпня 2017 р. 16:54:49 EEST Jack Ostroff написано:
I hope rbt (review board tools) will be able to work with  
Phabricator, or there is a replacement.


It is recommended to use Arcanist with Phabricator:

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

Hope this helps.

Best regards,
Yuri


Thanks.  I'm all set up now.

Jack

Re: Review Request 130234: Fix 'Missing buttons for adding/removing entries in currency edit dialog'

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130234/
---

(Updated Aug. 24, 2017, 4:18 nachm.)


Review request for KMymoney and Jack Ostroff.


Changes
---

simplified


Bugs: 383831
http://bugs.kde.org/show_bug.cgi?id=383831


Repository: kmymoney


Description
---

Patch adds requested buttons


Diffs (updated)
-

  kmymoney/dialogs/kcurrencyeditdlg.h 712420304caf55a1ae762a6d715568a908de4fc0 
  kmymoney/dialogs/kcurrencyeditdlg.cpp 
58b7c20c083a73730dedd4faa3607b89c5dd00ca 
  kmymoney/kmymoney.cpp 9c372746c658d9562dfde1eec25a472e95a81ebe 

Diff: https://git.reviewboard.kde.org/r/130234/diff/


Testing
---

- branch compiled
- tested adding entry
- tested removing entry


Thanks,

Ralf Habacker

Re: Fwd: Retirement of Reviewboard - Transition to Phabricator

[Yuri Chornoivan]

четвер, 24 серпня 2017 р. 16:54:49 EEST Jack Ostroff написано:
> I hope rbt (review board tools) will be able to work with Phabricator, or
> there is a replacement.
> 
> Jack

Hi,

It is recommended to use Arcanist with Phabricator:

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

Hope this helps.

Best regards,
Yuri

> 
> On Aug 24, 2017, 5:26 AM, at 5:26 AM, Thomas Baumgart  
wrote:
> >Hi all,
> >
> >since there are some reviews still lingering around for KMyMoney on
> >KDE's
> >reviewboard, I want to inform about an upcoming change for this infra.
> >
> >The list can be found at
> >
> >https://git.reviewboard.kde.org/groups/kmymoney/
> >
> >(make sure to select 'hide closed' to find the ones that are still
> >open).
> >
> >Regards
> >
> >Thomas
> >
> >--  Forwarded Message  --
> >
> >Subject: Retirement of Reviewboard - Transition to Phabricator
> >Date: Donnerstag, 24. August 2017, 21:07:49 CEST
> >From: Ben Cooksley 
> >To: informing about and discussing non-technical community topics  >commun...@kde.org>, kde-devel , kde-core-devel
> > >de...@kde.org>, kde-frameworks-de...@kde.org
> >,
> >Plasma , KDevelop ,
> >Calligra
> >Suite developers and users mailing list ,
> >digiKam
> >developers room - digiKam - Manage your photographs as a professional
> >with the
> >power of open source 
> >CC: sysad...@kde.org 
> >
> >Hi all,
> >
> >The following is Sysadmin's suggested plan for the retirement of
> >Reviewboard now that Phabricator is fully up and running for hosting
> >of code reviews.
> >
> >Phase 1: Commences September 2: All repositories are closed for
> >accepting new reviews on Reviewboard. A notice is added to the top of
> >the main page indicating that reviews should now be done on
> >Phabricator.
> >
> >Phase 2: Commences September 16: Login to Reviewboard is disabled, and
> >final backups are taken. A static copy of Reviewboard is generated and
> >published online, and the software itself is taken down.
> >
> >The vast majority of projects should now be migrated to Phabricator,
> >with only historical reviews needing to be cleaned up.
> >
> >Note that due to how Reviewboard stores diffs and reproduces them for
> >use, some reviews may have decayed and may no longer be readable. This
> >is due to short-hashes which are used by Git/Reviewboard in diffs now
> >having collisions with other commits which previously did not exist.
> >Unfortunately there is nothing we can do about this.
> >
> >Any comments on the above?
> >
> >Regards,
> >Ben
> >
> >-

Re: Fwd: Retirement of Reviewboard - Transition to Phabricator

[Jack Ostroff]

I hope rbt (review board tools) will be able to work with Phabricator, or there 
is a replacement.

Jack

On Aug 24, 2017, 5:26 AM, at 5:26 AM, Thomas Baumgart  
wrote:
>Hi all,
>
>since there are some reviews still lingering around for KMyMoney on
>KDE's
>reviewboard, I want to inform about an upcoming change for this infra.
>
>The list can be found at
>
>https://git.reviewboard.kde.org/groups/kmymoney/
>
>(make sure to select 'hide closed' to find the ones that are still
>open).
>
>Regards
>
>Thomas
>
>--  Forwarded Message  --
>
>Subject: Retirement of Reviewboard - Transition to Phabricator
>Date: Donnerstag, 24. August 2017, 21:07:49 CEST
>From: Ben Cooksley 
>To: informing about and discussing non-technical community topics commun...@kde.org>, kde-devel , kde-core-devel
>de...@kde.org>, kde-frameworks-de...@kde.org
>,
>Plasma , KDevelop ,
>Calligra
>Suite developers and users mailing list ,
>digiKam
>developers room - digiKam - Manage your photographs as a professional
>with the
>power of open source 
>CC: sysad...@kde.org 
>
>Hi all,
>
>The following is Sysadmin's suggested plan for the retirement of
>Reviewboard now that Phabricator is fully up and running for hosting
>of code reviews.
>
>Phase 1: Commences September 2: All repositories are closed for
>accepting new reviews on Reviewboard. A notice is added to the top of
>the main page indicating that reviews should now be done on
>Phabricator.
>
>Phase 2: Commences September 16: Login to Reviewboard is disabled, and
>final backups are taken. A static copy of Reviewboard is generated and
>published online, and the software itself is taken down.
>
>The vast majority of projects should now be migrated to Phabricator,
>with only historical reviews needing to be cleaned up.
>
>Note that due to how Reviewboard stores diffs and reproduces them for
>use, some reviews may have decayed and may no longer be readable. This
>is due to short-hashes which are used by Git/Reviewboard in diffs now
>having collisions with other commits which previously did not exist.
>Unfortunately there is nothing we can do about this.
>
>Any comments on the above?
>
>Regards,
>Ben
>
>-
>--
>
>Regards
>
>Thomas Baumgart
>
>https://www.telegram.org/   Telegram, the better WhatsApp
>-
>To be or not to be that is the question. - Any programmer
>knows the answer: $2B | !$2B is $FF.
>-

[kmymoney4] [Bug 383952] New: Cannot set holiday region

[David Houlden]

https://bugs.kde.org/show_bug.cgi?id=383952

Bug ID: 383952
   Summary: Cannot set holiday region
   Product: kmymoney4
   Version: 4.8.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

I am installing KMyMoney on a new install of KDE 4.14.32. After compiling 4.8
from git I am unable to select a holiday region in settings -> scheduled
transactions. The list of regions is empty. Using git bisect I have traced this
problem to commit ce51d7b2f915b075839c0017c91567d4ab2bd66 (Make kdepimlibs
optional). Compiling from before this commit I get a selectable list of holiday
regions. When I run cmake I get this output which seems to indicate all should
be ok.

KDE PIM holidays:yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

Fwd: Retirement of Reviewboard - Transition to Phabricator

[Thomas Baumgart]

Hi all,

since there are some reviews still lingering around for KMyMoney on KDE's 
reviewboard, I want to inform about an upcoming change for this infra.

The list can be found at 

https://git.reviewboard.kde.org/groups/kmymoney/

(make sure to select 'hide closed' to find the ones that are still open).

Regards

Thomas

--  Forwarded Message  --

Subject: Retirement of Reviewboard - Transition to Phabricator
Date: Donnerstag, 24. August 2017, 21:07:49 CEST
From: Ben Cooksley 
To: informing about and discussing non-technical community topics , kde-devel , kde-core-devel , kde-frameworks-de...@kde.org , 
Plasma , KDevelop , Calligra 
Suite developers and users mailing list , digiKam 
developers room - digiKam - Manage your photographs as a professional with the 
power of open source 
CC: sysad...@kde.org 

Hi all,

The following is Sysadmin's suggested plan for the retirement of
Reviewboard now that Phabricator is fully up and running for hosting
of code reviews.

Phase 1: Commences September 2: All repositories are closed for
accepting new reviews on Reviewboard. A notice is added to the top of
the main page indicating that reviews should now be done on
Phabricator.

Phase 2: Commences September 16: Login to Reviewboard is disabled, and
final backups are taken. A static copy of Reviewboard is generated and
published online, and the software itself is taken down.

The vast majority of projects should now be migrated to Phabricator,
with only historical reviews needing to be cleaned up.

Note that due to how Reviewboard stores diffs and reproduces them for
use, some reviews may have decayed and may no longer be readable. This
is due to short-hashes which are used by Git/Reviewboard in diffs now
having collisions with other commits which previously did not exist.
Unfortunately there is nothing we can do about this.

Any comments on the above?

Regards,
Ben

-
-- 

Regards

Thomas Baumgart

https://www.telegram.org/   Telegram, the better WhatsApp
-
To be or not to be that is the question. - Any programmer
knows the answer: $2B | !$2B is $FF.
-


signature.asc
Description: This is a digitally signed message part.

Re: Review Request 130234: Fix 'Missing buttons for adding/removing entries in currency edit dialog'

[Thomas Baumgart]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130234/#review103648
---




kmymoney/dialogs/kcurrencyeditdlg.cpp (line 289)


Why don't you connect the resp. signal directly to newCurrency, e.g.

  connect(this, SIGNAL(user3Clicked()), this, SIGNAL(newCurrency()));
  
This way, you don't need the slotNewCurrency() at all.


- Thomas Baumgart


On Aug. 22, 2017, 10:49 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130234/
> ---
> 
> (Updated Aug. 22, 2017, 10:49 vorm.)
> 
> 
> Review request for KMymoney and Jack Ostroff.
> 
> 
> Bugs: 383831
> http://bugs.kde.org/show_bug.cgi?id=383831
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Patch adds requested buttons
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/kcurrencyeditdlg.h 
> 712420304caf55a1ae762a6d715568a908de4fc0 
>   kmymoney/dialogs/kcurrencyeditdlg.cpp 
> 58b7c20c083a73730dedd4faa3607b89c5dd00ca 
>   kmymoney/kmymoney.cpp 9c372746c658d9562dfde1eec25a472e95a81ebe 
> 
> Diff: https://git.reviewboard.kde.org/r/130234/diff/
> 
> 
> Testing
> ---
> 
> - branch compiled
> - tested adding entry
> - tested removing entry
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>