[kmymoney] [Bug 390207] Cannot create new online account with aqhbci: Could not create dialog

2018-02-12 Thread Martin Steigerwald
https://bugs.kde.org/show_bug.cgi?id=390207

Martin Steigerwald  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #2 from Martin Steigerwald  ---
According to thread "[Aqbanking-user] AqBanking 5.7.7 herausgegeben" and
"[Aqbanking-user] Konto anlegen-Dialog von AqHBCI kommt nicht: dlg_setup.c:
920: Could not create dialog" in aqbanking-user mailing list¹ this issue is
fixed in AqBanking 5.7.7. Setting bug report accordingly.

[1] Archive only visible for mailing list members:
http://lists.aqbanking.de/cgi-bin/mailman/listinfo/aqbanking-user

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390042] can't change ledger sort options in configure dialog

2018-02-12 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390042

--- Comment #5 from David Nelson  ---
I applied the patches and it now works as expected.

BTW, I'm running ubuntu bionic which has webKit 5.43, kmm uses 5.42, but a
symlink to 5.43 seems to run ok, at least so far.

Thank you Thomas for the speedy resolution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Question about commit

2018-02-12 Thread Łukasz Wojniłowicz
Dnia poniedziałek, 12 lutego 2018 08:09:37 CET Pino Toscano pisze:
> Hi,
> 
> In data sabato 10 febbraio 2018 21:18:19 CET, Thomas Baumgart ha scritto:
> > this commit on the 5.0 branch
> > 
> > commit 9b27c432ef80c9d4a35bc9dff37619cde9673343
> > Author: Pino Toscano 
> > Date:   Thu Feb 8 22:16:47 2018 +0100
> > 
> > cmake: install local icons in the local datadir
> > 
> > Install all the local actions icons to the kmymoney data directory, to
> > avoid polluting the global icon themes.
> > 
> > Fixes commit d9cf5550c478d95d4faf312c1149f30829829516.
> > 
> > apparently causes that the icons are not shown anymore in the application.
> > Any idea of what to look for?
> 
> I see, the icon loading code uses QIcon, which does not know about
> local paths for icons. Can you please try the attached patch, which
> switches to KIconLoader?
> 
> Since kmymoney has a lot of own icons, I'd really avoid to install them
> in the global icon themes, with the risk of clashes with the themes
> themselves. Also, the above commit makes the situation as it was in
> kmymoney 4.x.
> 
> Thanks,

Hi Pino,

either something is not working on my setup or you didn't test this patch. 
It breaks whole icon system. In $HOME/.local/share/icons/ I've got custom icon 
theme which I don't use with KMyMoney, but after your patch it's loaded for it 
although I choose different icon theme for it.

I believe it's because you switched QIcon::fromTheme to KDE::icon which is not 
equal to each other.

Small hint No. 1: do not change code without knowing what it does.

In general I confirm Thomas' observation about icon deficiencies.

Small hint No. 2: please don't commit changes "5 minutes before app's release" 
without consulting it with anyone actively involved in the development

> Since kmymoney has a lot of own icons, I'd really avoid to install them
> in the global icon themes, with the risk of clashes with the themes
> themselves.

Although I understand concept of clash, I don't understand why it should 
happen here or why it should ever bring bad outcome.

1) icons we ship don't exist in themes, hence we ship them, so what it should 
clash with?

2) if other app (e.g. Skrooge) ships icons with the same name as ours and a 
clash occurs then it's nothing bad either, because we don't need the exact 
icon, that we ship, and nothing bad will happen if we use the icon, which e.g. 
Skrooge has overwritten.

3) installing icons in local directory is making them available only to single 
user on the computer, which in my opinion is bad for multi-user setups.

I would like to revert your patch and install missing icons globally unless 
you come up with better solution.

Cheers
Łukasz


[kmymoney] [Bug 377760] Cannot turn off Outbox tab in 4.8.0.

2018-02-12 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=377760

Thomas Baumgart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kmy
   ||money/a1c8097e290685c8de719
   ||e9ce802414337f63474
   Version Fixed In||5.0.1
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Thomas Baumgart  ---
Git commit a1c8097e290685c8de719e9ce802414337f63474 by Thomas Baumgart.
Committed on 12/02/2018 at 13:55.
Pushed by tbaumgart into branch '5.0'.

Remove online job view if not needed

Summary:
In case no online job plugin is available, the online job view is not
needed. This change removes the view from the application in case no
online plugin is active at startup of the application.
FIXED-IN: 5.0.1

Test Plan: Disable KBanking and OFX plugin and check that page is not shown.
Enable at least one of them to have the page back after the next application
start.

Reviewers: wojnilowicz

Reviewed By: wojnilowicz

Differential Revision: https://phabricator.kde.org/D10457

M  +19   -6kmymoney/views/kmymoneyview.cpp

https://commits.kde.org/kmymoney/a1c8097e290685c8de719e9ce802414337f63474

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 377760] Cannot turn off Outbox tab in 4.8.0.

2018-02-12 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=377760

Thomas Baumgart  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Thomas Baumgart  ---
I just added a proposed fix at https://phabricator.kde.org/D10457

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390249] Ctrl+Shift+Space shortcut no longer available

2018-02-12 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=390249

Thomas Baumgart  changed:

   What|Removed |Added

   Version Fixed In||5.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.