[kmymoney] [Bug 451338] New: The Yes/No modal dialog shown if "Clear All" is pressed in Split Editor is redundant

2022-03-09 Thread Dawid Wróbel via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=451338

Bug ID: 451338
   Summary: The Yes/No modal dialog shown if "Clear All" is
pressed in Split Editor is redundant
   Product: kmymoney
   Version: 5.1.2
  Platform: Other
OS: Other
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: ux-ui
  Assignee: kmymoney-devel@kde.org
  Reporter: m...@dawidwrobel.com
  Target Milestone: ---

SUMMARY
The Yes/No modal dialog shown if "Clear All" is pressed in Split Editor is
redundant, since no irreversible action is being performed, as the user still
has an option to click "Cancel" when editing splits and restore the previous
state of the transaction.

STEPS TO REPRODUCE
1. Open a transaction with splits
2. Click "Clear All"

OBSERVED RESULT
Notice the "Do you really want to continue" dialog. 

EXPECTED RESULT
No dialog should be shown, splits should be cleared right away. User can
restore them by clicking "Cancel"

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Hard dependency on plasma-framework in Alkimia

2022-03-09 Thread Thomas Baumgart via KMyMoney-devel
Hi Ben,

On Mittwoch, 9. März 2022 11:09:53 CET Ben Cooksley wrote:

> Hi Thomas,
> 
> Recently some changes were introduced to Frameworks which means that they
> now enforce more rigorously the platforms on which they build.
> 
> This means that Plasma Framework is no longer available on Windows -
> unfortunately though it looks like Alkimia has a mandatory dependency on
> Plasma Framework.
> 
> Are you able to make this optional or should we disable Windows CI builds
> for Alkimia (and the projects that depend on it)?

I just accepted https://invent.kde.org/office/alkimia/-/merge_requests/17 so you
can re-enable Alkimia builds once this is merged.

p.s. quite a short time frame from notice until cut-off for my taste.

-- 

Regards

Thomas Baumgart

https://www.signal.org/   Signal, the better WhatsApp
-
Linux, because rebooting is for adding new hardware ...
-


signature.asc
Description: This is a digitally signed message part.


[sysadmin/ci-tooling] local-metadata: Alkimia has a hard dependency on Plasma Framework by default on Windows, and Plasma Framework is no longer available on Windows.

2022-03-09 Thread Ben Cooksley via KMyMoney-devel
Git commit 9b120b06156140e0c2657de5f9306620812f7d40 by Ben Cooksley.
Committed on 09/03/2022 at 17:39.
Pushed by bcooksley into branch 'master'.

Alkimia has a hard dependency on Plasma Framework by default on Windows, and 
Plasma Framework is no longer available on Windows.
Therefore we have to disable Alkimia builds on Windows.

CCMAIL: kde-frameworks-de...@kde.org
CCMAIL: kmymoney-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/9b120b06156140e0c2657de5f9306620812f7d40

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index 5d7ecfd..e42d203 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -22,6 +22,7 @@
 - 'kde/workspace/libksysguard'
 - 'kde/kdenetwork/kaccounts-integration'
 - 'extragear/libs/pulseaudio-qt'
+- 'extragear/office/alkimia'
 - "kde/pim/libkleo"
 
 'FreeBSDQt5.15':