[kmymoney] [Bug 451921] Capital gains report should allow including closed accounts

2022-03-26 Thread bugzilla_noreply--- via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=451921

--- Comment #2 from zoltan1...@gmail.com ---
One more thing I forgot to mention: To reduce clutter in reports, I think
closed account could still be hidden if they were closed throughout the whole
period covered by the report (i.e., the got closed before the start of the
reporting period). In this case it truely does not make too much sense to show
them as they could not play any role in the results, thus can be safely
omitted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 451921] Capital gains report should allow including closed accounts

2022-03-26 Thread bugzilla_noreply--- via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=451921

--- Comment #1 from zoltan1...@gmail.com ---
I just noticed that "Realized Capital Gains" is just the name that I gave to
the report, kmymoney just calls it a Capital Gains report with the "Sum
investements" setting set to "Only sold". Apart from the different naming
convention, it is a realized capital gains report in essence.

I also noticed that there already is a bug report about this behavior with the
number 429710. However, in that bug the OP is asked to open a wishlist item
instead, and this ticket is exactly that, so it's not an exact duplicate.
Additionally, I think this report provides more details on the motivation for
the desired behavior. Still, after reading the concerns against 429710, I would
like to elaborate a bit more on why closed accounts should be included in my
opinion.

1. If we approach the problem from the point of view of the "closed account"
functionality, I would argue that users are expected to close an account once
they close the corresponding "real" account at a financial institution and thus
can no longer do transactions in it. As for the purpose of this function, I
would say that it serves to reduce the clutter in the various account lists.
However, hiding such accounts only makes sense when the associated information
is irrelevant. This applies to ledger selection because it is not possible to
do transactions and also applies to "snapshot" reports, because the account
value is 0. However, it does not apply to historical reports, where closed
accounts have a significant role.

2. If approaching the problem from the "Show all accounts" functionality, it
shows closed accounts in the account selectors and allows opening their
ledgers. I would argue that it should also apply to reports as I see no reason
for why it shouldn't but I see several for why I should (see points 1 and 3).

3. Finally, if we approach from the use case - generating a realized capital
gains report for tax purposes - it definitely makes sense to include these
transactions, and this holds true irrespective of the first two bullet points.
In fact, it is even misleading and dangerous to hide them, because if one were
to solely rely on such a report for calculating taxes without noticing the
omission of closed accounts, they would file their taxes wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 451921] New: Capital gains report should allow including closed accounts

2022-03-26 Thread bugzilla_noreply--- via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=451921

Bug ID: 451921
   Summary: Capital gains report should allow including closed
accounts
   Product: kmymoney
   Version: 5.1.2
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: zoltan1...@gmail.com
  Target Milestone: ---

SUMMARY

For tax calculation purposes, it is useful to generate a report about capital
gains realized in the previous year. However, by that time, the affected
accounts could be closed. The capital gains from those closed accounts are
still relevant though and should be included in the report. Currently they are
omitted, even when the "show all accounts" setting is enabled in the view menu.
I would suggest adapting one of the following behaviors:
- Respect the "show all accounts" setting of the view menu. (Personally I don't
like this option too much, because it still makes it easy to accidentally omit
closed accounts, but it at least makes it possible to include them.)
- Have a separate setting in the report configuration that allows including
closed accounts and make it default to yes.
- Include closed accounts in the capital gains report unconditionally. (For
unrealized capital gains there won't be anything to include from closed
accounts and for realized gains it makes sense to include closed accounts.)

STEPS TO REPRODUCE
1. Create a pair of investment transactions that produces capital gain.
2. Close the account.
3. Generate a report of realized capital gains.

OBSERVED RESULT

Capital gains are not shown for the closed account.

EXPECTED RESULT

Capital gains should be shown for the closed account.

ADDITIONAL INFORMATION

Thanks for the great software! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 424377] Change default matching behavior for new payees to "match on exact payee name"

2022-03-26 Thread Thomas Baumgart via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=424377

Thomas Baumgart  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/offi
   ||ce/kmymoney/commit/caa11249
   ||c6df800ee4aa69b6a733e067241
   ||b65a3
   Version Fixed In||5.1.3
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Thomas Baumgart  ---
Git commit caa11249c6df800ee4aa69b6a733e067241b65a3 by Thomas Baumgart.
Committed on 26/03/2022 at 08:24.
Pushed by tbaumgart into branch '5.1'.

Set default for new payees to match on name
FIXED-IN: 5.1.3

(cherry picked from commit d13ed775e1a5b440812d0837c652c4c03d4575f4)

M  +1-0kmymoney/kmymoneyutils.cpp

https://invent.kde.org/office/kmymoney/commit/caa11249c6df800ee4aa69b6a733e067241b65a3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 424377] Change default matching behavior for new payees to "match on exact payee name"

2022-03-26 Thread Thomas Baumgart via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=424377

--- Comment #10 from Thomas Baumgart  ---
Git commit d13ed775e1a5b440812d0837c652c4c03d4575f4 by Thomas Baumgart.
Committed on 26/03/2022 at 08:01.
Pushed by tbaumgart into branch 'master'.

Set default for new payees to match on name

M  +1-0kmymoney/kmymoneyutils.cpp

https://invent.kde.org/office/kmymoney/commit/d13ed775e1a5b440812d0837c652c4c03d4575f4

-- 
You are receiving this mail because:
You are the assignee for the bug.