[kmymoney] [Bug 485980] New: No Desktop Icon for kmymoney during install

2024-04-22 Thread David Vail via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=485980

Bug ID: 485980
   Summary: No Desktop Icon for kmymoney during install
Classification: Applications
   Product: kmymoney
   Version: 5.1.3
  Platform: Microsoft Windows
OS: Other
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: davidv...@gmail.com
  Target Milestone: ---

SUMMARY
I just heard about Kmymoney, went to your website and downloaded it. I have a
desktop gaming PC with Windows 11. After installation, I discovered there was
no desktop icon on my desktop. When I went into the Windows app launcher, I
found Kmymoney, but there is no icon to install on the desktop - there is one
for the Windows taskbar.


EXPECTED RESULT: I expected to have an application icon of Kmymoney on my
desktop with my other frequently used applications.


SOFTWARE/OS VERSIONS
Windows: 11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 475247] New: Cheque number field kmmSplits.checkNumber is too small

2023-10-05 Thread David via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=475247

Bug ID: 475247
   Summary: Cheque number field kmmSplits.checkNumber is too small
Classification: Applications
   Product: kmymoney
   Version: 5.1.3
  Platform: Ubuntu
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: database
  Assignee: kmymoney-devel@kde.org
  Reporter: davidan...@gmail.com
  Target Milestone: ---

SUMMARY
***
Table kmmSplits, column checkNumber is declared as VARCHAR(32), however my
banking system is creating entries with cheque numbers like
"BALANCE_CASHBACK-2xxd-5xx6-4xxc-8xxd-9xx2"
***


STEPS TO REPRODUCE
1. Create transaction with long cheque number (such as the example)
2. Save As to SQL

OBSERVED RESULT
Save As will fail, reporting that the data is too large for the checkNumber
field.

EXPECTED RESULT
Transaction is saved into the database as entered without truncation or errors.
(except in the case of an obscenely long entry)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 23.04
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Using the KMyMoney Tools menu, select the "Generate SQL" tool and copy the
generated code to a text editor. Searching for checkNumber verifies that the
field is VARCHAR(32). I recommend that it be changed in future versions to
VARCHAR(64).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 474474] New: KMyMoney crashes when filling in scheduled transaction

2023-09-13 Thread David Naylor via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=474474

Bug ID: 474474
   Summary: KMyMoney crashes when filling in scheduled transaction
Classification: Applications
   Product: kmymoney
   Version: git (master)
  Platform: macOS (DMG)
OS: macOS
Status: REPORTED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: naylor.b.da...@gmail.com
  Target Milestone: ---

Created attachment 161596
  --> https://bugs.kde.org/attachment.cgi?id=161596=edit
macOS crash report

STEPS TO REPRODUCE
1. Find a transaction in the "Ledger"
2. Right click and select "Create scheduled transaction..."
3. Select a transaction from the "Select autofill transaction" dialog and click
"OK"

OBSERVED RESULT
KMyMoney crashes

EXPECTED RESULT
The dialog for creating a scheduled transaction appears

SOFTWARE/OS VERSIONS
macOS: 13.5

ADDITIONAL INFORMATION
KMyMoney nightly (5.1.80-5d4ad1deb) was used (the stable version didn't show
any content under home, due to an issue with QWebEngine).  

The new schedule dialog does appear clicking the "New Schedule..." button on
the "Scheduled transactions" page, or when selecting "Cancel" on the "Select
autofill transaction" dialog.  Thus, it is likely the autofilling that is
causing the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: A bug in the current stable release

2021-12-06 Thread David Walker via KMyMoney-devel


Excellent. Many Thanks.Davidenvoyé : 6 décembre 2021 à 08:02de : Thomas Baumgart à : kmymoney-devel@kde.orgCc: David Walker objet : Re: A bug in the current stable releaseHi,On Sonntag, 5. Dezember 2021 15:28:25 CET David Walker via KMyMoney-devel wrote:The Operating System is Ubuntu 18.04.06KMymoney is V5.0.0.That is a rather old version of KMyMoney. Gnome:3.28.2This problem started manifesting itself about 2 months ago. I did have a problem with a Multi-USB card. This card problem has been resolved, but the KMymoney still persists. I tried to backup to an external USB HDD on a different USB card, but experienced the same issue.Do you have the "Mount this directory before backing up" checkbox marked or not? In case your USB drive is auto-mounted, mounting does not work. If the aforementioned option is on, turn it off and check what happens.Thomasenvoyé : 4 décembre 2021 à 14:23de : Thomas Baumgart à : kmymoney-devel@kde.orgCc: David Walker objet : Re: A bug in the current stable releaseHi,On Samstag, 4. Dezember 2021 09:48:25 CET David Walker via KMyMoney-devel wrote:When trying to backup my KmyMoney file after an update, it says "Error Mounting "Destination drive. I click OK and t says "Error Unmounting "Destination Drive.A few more pieces of information are required so that we can provide advice.Which operating system are you using? Which version?Which version of KMyMoney do you encounter these problems with?--RegardsThomas Baumgarthttps://www.signal.org/ Signal, the better WhatsApp-Knowledge is of two kinds. We know a subject ourselves, or we know wherewe can find information upon it. — Samuel Johnson (Boswell's Life of Johnson)--- RegardsThomas Baumgarthttps://www.signal.org/ Signal, the better WhatsApp-The impossible I do today: miracles take a little longer.-


Re: A bug in the current stable release

2021-12-05 Thread David Walker via KMyMoney-devel


The Operating System is Ubuntu 18.04.06KMymoney is V5.0.0.Gnome:3.28.2This problem started manifesting itself about 2 months ago. I did have a problem with a Multi-USB card. This card problem has been resolved, but the KMymoney still persists. I tried to backup to an external USB HDD on a different USB card, but experienced the same issue.RegardsDavid Walkerenvoyé : 4 décembre 2021 à 14:23de : Thomas Baumgart à : kmymoney-devel@kde.orgCc: David Walker objet : Re: A bug in the current stable releaseHi,On Samstag, 4. Dezember 2021 09:48:25 CET David Walker via KMyMoney-devel wrote:When trying to backup my KmyMoney file after an update, it says "Error Mounting "Destination drive. I click OK and t says "Error Unmounting "Destination Drive.A few more pieces of information are required so that we can provide advice.Which operating system are you using? Which version?Which version of KMyMoney do you encounter these problems with?-- RegardsThomas Baumgarthttps://www.signal.org/ Signal, the better WhatsApp-Knowledge is of two kinds. We know a subject ourselves, or we know wherewe can find information upon it. — Samuel Johnson (Boswell's Life of Johnson)-


A bug in the current stable release

2021-12-04 Thread David Walker via KMyMoney-devel


When trying to backup my KmyMoney file after an update, it says "Error Mounting  "Destination drive. I click OK and t says "Error Unmounting "Destination Drive.How to correct?regardsDavid Walker


[kmymoney] [Bug 444100] Kmymoney will not open

2021-10-20 Thread David Eggleton via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=444100

--- Comment #1 from David Eggleton  ---
“kmymoney.app” can’t be opened because Apple cannot check it for malicious
software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444100] New: Kmymoney will not open

2021-10-20 Thread David Eggleton via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=444100

Bug ID: 444100
   Summary: Kmymoney will not open
   Product: kmymoney
   Version: unspecified
  Platform: macOS (DMG)
OS: macOS
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: david.f.eggle...@gmail.com
  Target Milestone: ---

“kmymoney.app” can’t be opened because Apple cannot check it for malicious
software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 436534] Report behaves incorrectly after configuration change

2021-10-02 Thread David Houlden via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=436534

David Houlden  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from David Houlden  ---
Unable to reproduce in 5.1.2 so marking as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 440060] Icons are missing on Linux if Breeze icon theme shipped by the bistro is older than 5.81

2021-07-20 Thread David Redondo via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=440060

David Redondo  changed:

   What|Removed |Added

 CC||k...@david-redondo.de

--- Comment #3 from David Redondo  ---
Alternative would be to use the icons that you used before as fallback instead
of bundling everything in https://doc.qt.io/qt-5/qicon.html#fromTheme-1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 436534] New: Report behaves incorrectly after configuration change

2021-05-03 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=436534

Bug ID: 436534
   Summary: Report behaves incorrectly after configuration change
   Product: kmymoney
   Version: 5.1.1
  Platform: Slackware Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

STEPS TO REPRODUCE
1. Open an investment price graph which has both vertical and horizontal grid
lines configured.
2. Go into configuration for the report and untick vertical grid lines.
3. Click apply.

OBSERVED RESULT
A blank graph with just the heading is displayed. Closing and reopening the
report makes no difference. A restart of kmymoney is needed. Go into the report
after the restart and the vertical lines have been removed. However, the report
now shows lines for lots of other investments which were not on the original
graph.

EXPECTED RESULT
After removing the vertical lines the report should be redisplayed. If a
restart is needed, the report should only have the original investment(s) on
it.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: KMyMoney 4.8.5 build fails with alkimia problem

2020-06-22 Thread David Houlden
On Sunday 21 June 2020 12:22:54 Jack wrote:
> On 6/21/20 12:15 PM, David Houlden wrote:
> > On Sunday 21 June 2020 11:16:58 Jack wrote:
> >> On 6/21/20 10:56 AM, David Houlden wrote:
> >>> Hi
> >>>
> >>> I am trying to build kmymoney 4.8.5 git HEAD. It fails in make with error 
> >>> "alkimia/alkonlinequote.h no such file or directory"
> >>>
> >>> This looks like an alkimia version problem. I have 5.0.0 and have not yet 
> >>> managed to build a later version on my slackware 14.2 system. 5.0.0 used 
> >>> to be sufficient until commit 6da0bad "Use alkimia provided online quotes 
> >>> support".
> >>>
> >>> Cmake did not show any version problem. It output "Found LibAlkimia: 
> >>> /usr/lib64/cmake/LibAlkimia/LibAlkimiaConfig.cmake (found version 
> >>> "5.0.0")"
> >>>
> >>> Is it possible to use alkimia 5.0.0 now? Would it be possible to have an 
> >>> option whether to use alkimia's quotes support or use the old way?
> >>>
> >>> Thanks
> >>> David
> >> Hello David,
> >>
> >> Is there any reason you're not using KMM 5.1?  (5.0 branch has been
> >> frozen, with current development in 5.1 branch, and 5.1 released.)
> >> 5.0.0 is also rather old for libalkimia.  My Gentoo system has 7.0.2 and
> >> my Artix Linux has 8.0.2.  I don't see an actual minimum libalkimia
> >> required by 4.8.5, but it does require <6.0.0.
> >>
> >> Jack
> >>
> > Hello Jack
> >
> > Simply because slackware is still on KDE4.
> >
> > You say 4.8.5 requires libalkimia <6.0.0 and I have 5.0.0 which should be 
> > ok shouldn't it? Anyway, in the meantime I have managed to build libalkimia 
> > 8.0.1. This has enabled me to build KMyMoney HEAD from git. I am now trying 
> > it out but first impressions are not good. More about that later maybe.
> >
> > Thanks
> > David
> Try building from git head of the 5.1 branch instead of the master 
> branch.  When we released 5.1, a lot of  new code was pushed into master 
> branch, and I don't think it is recommended yet for anything except 
> testing that new code.
> 
> While I would expect libalkimia 5.0.0 to work for KMM 4.8.5, I have not 
> tried it myself, so I don't know for sure.

I cannot use the 5.1 branch as I am still on KDE4. At least that is my 
understanding.
I now have libalkimia 8.0.1 installed and have built kmymoney from HEAD of the 
4.8 branch. I will not be using it though. There are too many bugs.
Briefly-
On Home screen Assets and Liabilities Summary the decimal places of values are 
not aligned vertically. This happens on some reports too.

On Tags screen, if I select a tag no transactions are shown. A balance for the 
tag is however shown.

Same on Payees screen. Selecting a payee shows no transactions.

How do I update stock prices? All the ways I used to have which parsed web 
sites have disappeared.

Regards, David.







Re: KMyMoney 4.8.5 build fails with alkimia problem

2020-06-21 Thread David Houlden
On Sunday 21 June 2020 11:16:58 Jack wrote:
> On 6/21/20 10:56 AM, David Houlden wrote:
> > Hi
> >
> > I am trying to build kmymoney 4.8.5 git HEAD. It fails in make with error 
> > "alkimia/alkonlinequote.h no such file or directory"
> >
> > This looks like an alkimia version problem. I have 5.0.0 and have not yet 
> > managed to build a later version on my slackware 14.2 system. 5.0.0 used to 
> > be sufficient until commit 6da0bad "Use alkimia provided online quotes 
> > support".
> >
> > Cmake did not show any version problem. It output "Found LibAlkimia: 
> > /usr/lib64/cmake/LibAlkimia/LibAlkimiaConfig.cmake (found version "5.0.0")"
> >
> > Is it possible to use alkimia 5.0.0 now? Would it be possible to have an 
> > option whether to use alkimia's quotes support or use the old way?
> >
> > Thanks
> > David
> 
> Hello David,
> 
> Is there any reason you're not using KMM 5.1?  (5.0 branch has been 
> frozen, with current development in 5.1 branch, and 5.1 released.)  
> 5.0.0 is also rather old for libalkimia.  My Gentoo system has 7.0.2 and 
> my Artix Linux has 8.0.2.  I don't see an actual minimum libalkimia 
> required by 4.8.5, but it does require <6.0.0.
> 
> Jack
> 

Hello Jack

Simply because slackware is still on KDE4. 

You say 4.8.5 requires libalkimia <6.0.0 and I have 5.0.0 which should be ok 
shouldn't it? Anyway, in the meantime I have managed to build libalkimia 8.0.1. 
This has enabled me to build KMyMoney HEAD from git. I am now trying it out but 
first impressions are not good. More about that later maybe.

Thanks
David


KMyMoney 4.8.5 build fails with alkimia problem

2020-06-21 Thread David Houlden
Hi

I am trying to build kmymoney 4.8.5 git HEAD. It fails in make with error 
"alkimia/alkonlinequote.h no such file or directory" 

This looks like an alkimia version problem. I have 5.0.0 and have not yet 
managed to build a later version on my slackware 14.2 system. 5.0.0 used to be 
sufficient until commit 6da0bad "Use alkimia provided online quotes support". 

Cmake did not show any version problem. It output "Found LibAlkimia: 
/usr/lib64/cmake/LibAlkimia/LibAlkimiaConfig.cmake (found version "5.0.0")"

Is it possible to use alkimia 5.0.0 now? Would it be possible to have an option 
whether to use alkimia's quotes support or use the old way?

Thanks
David


[kmymoney] [Bug 422200] KMyMoney crashes when navigating backwards through CSV import wizard

2020-06-12 Thread David
https://bugs.kde.org/show_bug.cgi?id=422200

--- Comment #7 from David  ---
This weekend, I am planning on upgrading my OS to Debian 11 (testing), so I
will no longer be able to contribute further to this bug with Debian 10
(stable). However, I will be able to test and see if the bug still exists with
Debian 11.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 422200] KMyMoney crashes when navigating backwards through CSV import wizard

2020-06-12 Thread David
https://bugs.kde.org/show_bug.cgi?id=422200

--- Comment #6 from David  ---
(In reply to Dawid Wróbel from comment #3)
> I actually saw that myself and am convinced this bug hasn't been fixed yet.
> That having said, I wasn't able to reproduce each time this happened.
> 
> David, can you please provide a sample file with your column mappings and
> the exact steps you take so that I can reproduce it on my end?

I have attached the csvimportrc containing the column mappings and a CSV file
that can be used to cause the crash. Sensitive information was redacted from
the CSV file, but I tested it before and after redactions with the same result.


To reproduce:
1) open CSV import wizard
2) select "Banking"
3) select "Credit Union CSV" profile
4) select the "redacted.csv" file to import
5) move forward through the wizard (no changes necessary) 
5) move backward to the first page of the wizard as though to select a
different file.
6) No need to actually select a different file. Just continue navigating
forward again. Crash will occur before reaching the final page of the wizard.

As long as I do not move back to the first page, the crash will not occur and
the import will be successful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 422200] KMyMoney crashes when navigating backwards through CSV import wizard

2020-06-12 Thread David
https://bugs.kde.org/show_bug.cgi?id=422200

--- Comment #5 from David  ---
Created attachment 129271
  --> https://bugs.kde.org/attachment.cgi?id=129271=edit
CSV file used to cause a crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 422200] KMyMoney crashes when navigating backwards through CSV import wizard

2020-06-12 Thread David
https://bugs.kde.org/show_bug.cgi?id=422200

David  changed:

   What|Removed |Added

 CC||lassi_suri...@yahoo.ca

--- Comment #4 from David  ---
Created attachment 129270
  --> https://bugs.kde.org/attachment.cgi?id=129270=edit
csvimportrc with column mappings used

Change: "Directory=" was changed to ~ remove the name of my financial
institution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 398852] KMyMoney Crashes on New Account creation when there is a starting balance

2020-01-11 Thread David Sherer
https://bugs.kde.org/show_bug.cgi?id=398852

--- Comment #2 from David Sherer  ---
I just tried on a new file and created 4 accounts and it did not crash. Not
sure what happened before.



Sent from my T-Mobile 4G LTE Device



 Original message 
From: Thomas Baumgart 
Date: 1/11/20 1:14 PM (GMT-06:00)
To: daveshe...@hotmail.com
Subject: [kmymoney] [Bug 398852] KMyMoney Crashes on New Account creation when
there is a starting balance

https://bugs.kde.org/show_bug.cgi?id=398852

Thomas Baumgart  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Thomas Baumgart  ---
I tried to duplicate this with the current HEAD of the 5.8 branch and I cannot
reproduce the problem anymore. Can you check if it still fails for you using
the stable AppImage? See https://kmymoney.org/appimage.php howto do that.
Thanks in advance.

If it still happens, can you explain exactly which type and options you set
during creation of the account.

--
You are receiving this mail because:
You reported the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: question regarding modification from category ledgers

2019-09-09 Thread David Houlden
Hi

Not sure why we can't change within a category but this may help.

Go into the account ledger and type the category you want to split into the 
filter field at top of screen. This will restrict the transactions to the ones 
you want.
Select the ones you want to change by selecting multiple lines with the mouse 
and holding shift or ctrl key down. Click the edit button and change the 
category. Click enter and all selected transactions should be updated.

Hope that helps you.

David

On Sunday 08 September 2019 08:23:09 jvap...@gmail.com wrote:
> Hi all, 
> 
> Why is it prohibited to make changes from within a Category? 
> 
> For example, if I have a category of Home Repairs and I want to go into
> that category to break it down to Home Repairs: home1, Home Repairs:
> home2 etc.. I cannot do that easily. I have to track down each
> transaction, go to its source ledger and adjust it there. This is a
> pain. I know other software does allow for adjusting within a Category
> so I am not sure if KMM is prohibiting it due to a technical limitation
> within the code or if this has been discussed and there is a reason why
> we don't allow it. 
> 
> My scenario basically comes down to me originally assigning all the
> transactions to a generic Expense account. After reviewing some of the
> reports, I find that I want to see the data broken down further. Thus I
> want to break the Category into other subcategories and reassign
> certain transactions there. This would be easy if I could go into the
> Generic Category and reassign from there. KMM doesn't allow me. :( 
> 
> I will find another way around it or use something else to get the
> breakdown but I figured I would share in case you get other similar
> requests; us users want it. :) 
> 
> 
> thanks, 
> 
> JV
> 


[kmymoney] [Bug 405383] Add python3 support for weboob plugin

2019-08-03 Thread David Geiger
https://bugs.kde.org/show_bug.cgi?id=405383

--- Comment #3 from David Geiger  ---
Any news about this bug? after about 5 month

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 408451] New: Financial Times online price update fails for LSE equities

2019-06-08 Thread David Mason
https://bugs.kde.org/show_bug.cgi?id=408451

Bug ID: 408451
   Summary: Financial Times online price update fails for LSE
equities
   Product: kmymoney
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: d...@tarp.org.uk
  Target Milestone: ---

Created attachment 120690
  --> https://bugs.kde.org/attachment.cgi?id=120690=edit
Patch to make Financial Times date regexp more flexible

SUMMARY

I've noticed that online price update fails for LSE (London Stock Exchange)
equities when using the "Financial Times" source.

The date regexp for this data source searches for the text: "Data delayed at
least 15 minutes". However, LSE equities have a delay of 20 minutes, so the
match fails: https://markets.ft.com/data/equities/tearsheet/summary?s=IHG:LSE

Making the date regexp more flexible allows price update to work as expected.

I've attached a patch that updates the default date regexp.

STEPS TO REPRODUCE
1. Add an LSE equity, such as IHG:LSE
2. Set the online source to Financial Times
3. Update the price

OBSERVED RESULT

Price found: '123.40' (123.4)
Unable to update price for xxx (no price or no date)

EXPECTED RESULT

Price found: '123.40' (123.4)
Date found: 'Fri Jun 7 2019'
Price for xxx updated (ID E01)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 406273] OFX name

2019-04-07 Thread David
https://bugs.kde.org/show_bug.cgi?id=406273

David  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #4 from David  ---
Yes, you right, it works now ... Maybe I tried to import file before it could
be available in then download directory.. Very strange. Sorry

Regards

Cyb.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 406273] OFX name

2019-04-06 Thread David
https://bugs.kde.org/show_bug.cgi?id=406273

--- Comment #2 from David  ---
(In reply to Ralf Habacker from comment #1)
> How many characters does the ofx filename have ?

My bank makes a 29 characters OFX file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 406273] New: OFX name

2019-04-06 Thread David
https://bugs.kde.org/show_bug.cgi?id=406273

Bug ID: 406273
   Summary: OFX name
   Product: kmymoney
   Version: 4.8.3
  Platform: Other
OS: MS Windows
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: importer
  Assignee: kmymoney-devel@kde.org
  Reporter: cybor...@laposte.net
  Target Milestone: ---

I saw OFX long name is not supported.
When I import OFX file from my bank, I need to rename it shorter else is not
recognized by KmyMoney like a valid file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 405808] Unknown property X-KMyMoney-Sepa-Country

2019-04-04 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=405808

--- Comment #5 from Christian David  ---
This code part was significantly changed by another developer. So I cannot tell
you if it is required anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 405383] New: python3 weboob support now available but not in kmymoney

2019-03-12 Thread David Geiger
https://bugs.kde.org/show_bug.cgi?id=405383

Bug ID: 405383
   Summary: python3 weboob support now available but not in
kmymoney
   Product: kmymoney
   Version: 5.0.3
  Platform: Mageia RPMs
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: buildsystem
  Assignee: kmymoney-devel@kde.org
  Reporter: geiger.david68...@gmail.com
  Target Milestone: ---

Hi,

As now python3 support added in weboob 1.4 would it be possible to port
kmymoney buildsytem also to python3, please?


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Mageia Cauldron
(available in About System)
KDE Plasma Version: 5.12.2
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-19 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

David Nelson  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |NOT A BUG
 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #12 from David Nelson  ---
OK, noted for the next time, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #10 from David Nelson  ---
Sorry, I missed the qt5 in the path !

Now kmm runs normally.

Thanks a lot for the answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #8 from David Nelson  ---
I added -DCMAKE_INSTALL_PREFIX=/usr, reinstalled and now have identical plugins
in both libs

/usr/lib/x86_64-linux-gnu/plugins/kmymoney
/usr/local/lib/x86_64-linux-gnu/plugins/kmymoney

Both ways result in the same missing plugin error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #6 from David Nelson  ---
yes, /usr/local/lib/x86_64-linux-gnu/plugins/kmymoney contains:

checkprinting.so
csvexporter.so
csvimporter.so
gncimporter.so
icalendarexporter.so
kcm_checkprinting.so
kcm_csvimporter.so
kcm_icalendarexporter.so
kcm_qif.so
konlinetasks_sepa.so
payeeidentifier_iban_bic_delegates.so
payeeidentifier_ibanbic_storageplugin.so
payeeidentifier_nationalaccount_storageplugin.so
payeeidentifier_nationalAccount_ui.so
qifexporter.so
qifimporter.so
reconciliationreport.so

i've attached log of install, i can't see any errors.

running from command line produces 3 lines:
 WebConnect: Try to connect to WebConnect server
 WebConnect: Connect to server failed
 WebConnect: Running in server mode

trying to open file from menu produces dialog box:

 Couldn't find any plugin for opening storage.

Thanks for your help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #5 from David Nelson  ---
Created attachment 116111
  --> https://bugs.kde.org/attachment.cgi?id=116111=edit
install log

no install errors

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

--- Comment #3 from David Nelson  ---
1) output of grep xmlstorage.so install_manifest.txt:

/usr/local/lib/x86_64-linux-gnu/plugins/kmymoney/xmlstorage.so
/usr/local/lib/x86_64-linux-gnu/plugins/kmymoney/kcm_xmlstorage.so

2) output of find /usr -name k\*part.so:

/usr/lib/kde4/khtmlimagepart.so
/usr/lib/kde4/khtmladaptorpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kfontviewpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/komparenavtreepart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/korganizerpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/komparepart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/konsolepart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/parts/khtmlpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/parts/kmultipart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/parts/khtmlimagepart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/parts/katepart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/parts/khtmladaptorpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kmailpart.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kaddressbookpart.so

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 400684] New: Can't open open existing kmy file, error message "Could not read your data source..."

2018-11-04 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=400684

Bug ID: 400684
   Summary: Can't open open existing kmy file, error message
"Could not read your data source..."
   Product: kmymoney
   Version: 5.0.2
  Platform: Compiled Sources
OS: Linux
Status: REPORTED
  Severity: critical
  Priority: NOR
 Component: file
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

Created attachment 116092
  --> https://bugs.kde.org/attachment.cgi?id=116092=edit
config log

SUMMARY


STEPS TO REPRODUCE
1. compile kmm-5.0.2 from tarball on kubuntu-18.10
2. try to open existing kmy file created by kmm-5.0.1

OBSERVED RESULT
error msg: "Could not read your data source. Please check the KMyMoney settings
that the necessary plugin is enabled."


EXPECTED RESULT


SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 5.14.2
KDE Frameworks Version: 5.51.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION
My kmm has no plugins, same as 5.0.1 which works fine.
I've reverted to 5.0.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 398852] New: KMyMoney Crashes on New Account creation when there is a starting balance

2018-09-19 Thread David Sherer
https://bugs.kde.org/show_bug.cgi?id=398852

Bug ID: 398852
   Summary: KMyMoney Crashes on New Account creation when there is
a starting balance
   Product: kmymoney
   Version: 5.0.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: daveshe...@hotmail.com
  Target Milestone: ---

When deleting my 401(k) account after removing the transactions  KMyMoney just
closes but it deletes the account.

When Creating a new 401(k) and trying to create it with a starting balance, it
just closes but never creates the account. If I create it without a balance it
does not close and creates the account.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Future of Alkimia

2018-05-16 Thread Christian David
Hello Lukasz, Thomas, Jack and Thomas,

I am afraid that this discussion could just end without any decision. So let 
me sum up what we have until now:

1) Alkimia is only used by KMyMoney. So using it as a separate library is not 
useful.

2) For eight years no feature was added that makes alkimia of interested for 
other software developers.

3) Instead of dropping Alkimia we could make it useful (for the first time).

Is that a good representation?

So I recommend: we wait until 23rd of October 2018 (this is in 6 months). If 
there is no new feature¹ then we drop it. Knowingly that the git repository, 
the wiki etc. will still be kept and can be reactivated if needed.

I want to highlight that this does not mean that the ideas behind alkimia are 
bad nor that the work which went into it were senseless! I spent a lot of time 
with alkimia, too!

Btw: the first svn commit to Alkimia was on Sun May 23 13:15:55 2010 (8 years 
- 1 week ago).

Best
Chris

¹ A feature that makes alkimia of real interest to other programs

Am Mittwoch, 4. April 2018, 18:34:28 CEST schrieb Christian David:
> For this reason I recommend to drop alkimia and move AlkValue into KMyMoney
> directly.




[kmymoney] [Bug 390411] Sqlite opening broken

2018-05-05 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=390411

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #4 from Christian David <christian-da...@web.de> ---
Could this be connected with or caused by bug 341304?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Future of Alkimia

2018-05-05 Thread Christian David
Hello Ralf,

Am Donnerstag, 12. April 2018, 17:09:16 CEST schrieb Ralf Habacker:
> Another option would be make it more interesting for other projects by
> adding more stuff into.

Do not get me wrong, I still think the original ideas are very good [1]. 
However, there were no development on features for eight years, why should it 
happen now or in future? Also I think we should think like: there is a 
problem, this should be solved with a library. Not the other way round: we 
want a library, how can we get people to use it?

Best
Chris

[1] https://community.kde.org/Alkimia/Usecases





Re: Future of Alkimia

2018-04-28 Thread Christian David
Hello Ralf,

Am Donnerstag, 12. April 2018, 17:09:16 CEST schrieb Ralf Habacker:
> Another option would be make it more interesting for other projects by
> adding more stuff into.

Do not get me wrong, I still think the original ideas are very good [1]. 
However, there were no development on features for eight years, why should it 
happen now or in future? Also I think we should think like: there is a 
problem, this should be solved with a library. Not the other way round: we 
want a library, how can we get people to use it?

Best
Chris

[1] https://community.kde.org/Alkimia/Usecases





Future of Alkimia

2018-04-04 Thread Christian David
Hello,

Alkimia was started about eight years ago by the developers of Skrooge, Kraft 
and KMyMoney. Unfortunately it never supported more than AlkValue. As far as I 
know, KMyMoney is the only project left to use alkimia. Skrooge and Kraft are  
not using it anymore and I do not know any other software to use alkimia.

For this reason I recommend to drop alkimia and move AlkValue into KMyMoney 
directly. This reduces the maintenance for developers, packages and users who 
just want to compile KMyMoney on their own. Additionally it reduces possible 
sources of trouble (just remember how much work it was for Ralf to get it 
working with Qt 4 & 5) and we remove a dependency.

What are you thinking about this?

Best
Chris





[kmymoney] [Bug 391453] Displaying the ledger without an account having been selected displays a closed account

2018-03-06 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=391453

--- Comment #4 from David Nelson <merli...@fastmail.com> ---
I just cherry-picked your commit 6a5731e0 and it now looks good!

Sorry for all the fuss about a minor issue.

This was the last of my bugs, but I'll keep looking.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 391453] Displaying the ledger without an account having been selected displays a closed account

2018-03-06 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=391453

David Nelson <merli...@fastmail.com> changed:

   What|Removed |Added

 CC||merli...@fastmail.com

--- Comment #2 from David Nelson <merli...@fastmail.com> ---
I just checked kmm 4.8.1, in my case the acct displayed does seem to be the one
 with the lowest internal ID.

Could kmm5 just do the same?  I think this is how Investments view implicitly
selects the oldest account as the default.

I have no preferred accounts.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390406] switching from Investments page to Ledgers always shows same stale closed account ledger

2018-03-05 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390406

--- Comment #11 from David Nelson <merli...@fastmail.com> ---
i'm not comfortable yet with git branching, but i pulled branch 5.0 and
confirmed that kgloballedgerview_p.h has your changes.

if you start kmm, click on Ledgers (without selecting an account in Home view) 
the account selection combobox is still showing 'Asset'.

the problem seems to be that Ledgers view does not default to an account
(before the user selects one) in the way Investments view does.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 391305] uncaught error when adding new investment transaction

2018-03-02 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=391305

David Nelson <merli...@fastmail.com> changed:

   What|Removed |Added

Summary|uncaught error when adding  |uncaught error when adding
   |new transaction |new investment transaction

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 391305] New: uncaught error when adding new transaction

2018-03-02 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=391305

Bug ID: 391305
   Summary: uncaught error when adding new transaction
   Product: kmymoney
   Version: git (master)
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

Version 5.0.80-6676cec5

in investment acct ledger trying to add a transaction

case 1:
click on New, crash before uncaught error popup display completed

case 2:
duplicate old txn, crashes when clicking on Edit, uncaught error pops up,
details are blank

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390406] switching from Investments page to Ledgers always shows same stale closed account ledger

2018-02-27 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390406

--- Comment #5 from David Nelson <merli...@fastmail.com> ---
more info:

case 1:
start kmm, select Ledgers view, account selection combobox is blank, stale
account is shown (in my case a closed chequing account). 

case 2:
start kmm, select Investments view, this is OK, first investment account is
shown, select Ledgers view, same closed chequing account shown, account
selection combobox is blank.

case3:
switch among accounts in Investments view, then select Ledgers view, and the
previously shown account is still displayed.
in other words, Ledgers view is not synced when account is changed in
Investments view.

once an account has been explicitly selected in Ledgers view, the stale account
does not appear again, 
but the account shown is not the one selected in Investments view before
switching to Ledgers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 391068] New: account totals in home view have lost their decimal places

2018-02-25 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=391068

Bug ID: 391068
   Summary: account totals in home view have lost their decimal
places
   Product: kmymoney
   Version: git (master)
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

this is a regression between commits 09ffa40a and cff06889

Total Assets, Total Liabilities, Net Worth still show decimal places,
but individual account totals are now rounded

could this have happened when the currency symbol was repositioned ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390979] securities have changed into currency

2018-02-24 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390979

--- Comment #3 from David Nelson <merli...@fastmail.com> ---
this looks good now.
thanks for the speedy fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390979] New: securities have changed into currency

2018-02-23 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390979

Bug ID: 390979
   Summary: securities have changed into currency
   Product: kmymoney
   Version: git (master)
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

Created attachment 110952
  --> https://bugs.kde.org/attachment.cgi?id=110952=edit
investment ledger showing various securities replaced by currency

this is a regression between commits 09ffa40a and 7150b4a5
affects investment accounts

ledger view shows all securities replaced by canadian dollar (all my accounts
are cad). see attached screenshot.

investment view shows all symbols as $ and all prices as 1. which seems to
be the exchange rate.

quantities are fine, just the prices and values are wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390967] New: quantity in Investments view should be right-justified

2018-02-23 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390967

Bug ID: 390967
   Summary: quantity in Investments view should be right-justified
   Product: kmymoney
   Version: git (master)
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

Version 5.0.80-9d616136

Investments view:

Values in the Quantity column are left-justified.  Value and Price columns are
correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390873] New: dollar symbol appears after amount

2018-02-21 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390873

Bug ID: 390873
   Summary: dollar symbol appears after amount
   Product: kmymoney
   Version: 5.0.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

The currency symbol, in my case $, now appears after the amount on the home
page, investments page, and scheduled transactions. 

In KMM4 it was positioned correctly before the amount.

Regional Settings format is en_CA.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390406] switching from Investments page to Ledgers always shows same stale closed account ledger

2018-02-21 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390406

--- Comment #3 from David Nelson <merli...@fastmail.com> ---
more info on this problem:
1) on the Investments page the Select Account combo box shows the account being
displayed
2) then click on Ledgers and the account name at the top has changed to a
different account.

It looks like the account selection in Ledgers page is no longer synchronised
when you switch accounts in the Investments page.

If after starting KMM, you first click on Investments, it seems that the
selection of the Ledgers account is not initialised.  That's when I see the
closed chequing account.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390044] can't add new investment in Investments window

2018-02-21 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390044

--- Comment #4 from David Nelson <merli...@fastmail.com> ---
This problem has gone away in 5.0.80-7150b4a5.
Thank you very much !

However, in this iteration there is a bigger problem: investments have changed
type (mutual fund is now a stock) and the values make no sense.  My accounts
are all in Canadian dollar, and all current prices show as $1.000.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390044] can't add new investment in Investments window

2018-02-20 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390044

--- Comment #2 from David Nelson <merli...@fastmail.com> ---
(In reply to NSLW from comment #1)
> I cannot reproduce your bug. Do you have investment account selected in
> "Select account: " combo box? 
> It would be helpful if you could provide screenshots?

Thanks for your help.  In the Investments window the accounts listed under
Select Account are only investment accounts.  The problem is that
right-clicking on the background under the existing equities brings up the
Investment Options popup with the New Investment option disabled.  I have just
once seen this option enabled but haven't since been able to reproduce it.  
I'm trying to take a screenshot without the popup disappearing and with my data
blacked out.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390406] switching from Investments page to Ledgers always shows same stale closed account ledger

2018-02-15 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390406

--- Comment #2 from David Nelson <merli...@fastmail.com> ---
(In reply to Thomas Baumgart from comment #1)
> Version 5.0.80-09ffa40a is clearly of master and not the 5.0 branch.
> 
> Could it be, that the Preferred account flag is set for the closed account?
> What happens, if you turn that off?

I have trouble seeing the closed accounts. Show All Accounts has no effect on
the account list.  Somehow I managed to see that it is NOT a preferred account,
but I'm not sure what I right-clicked on, I can't get into Edit Account again
for a closed account.  
None of my open accounts is a preferred account, so it's likely the closed ones
are not either.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390406] New: switching from Investments page to Ledgers always shows same stale closed account ledger

2018-02-13 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390406

Bug ID: 390406
   Summary: switching from Investments page to Ledgers always
shows same stale closed account ledger
   Product: kmymoney
   Version: 5.0.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: merli...@fastmail.com
  Target Milestone: ---

Version 5.0.80-09ffa40a

Clicking on Ledgers after Investments displays stale ledger from a closed
account.  This happens with all my investment accounts, and it's always the
same stale ledger.

Reselecting the account in Ledger view gets around this, so no big deal.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390042] can't change ledger sort options in configure dialog

2018-02-12 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390042

--- Comment #5 from David Nelson <merli...@fastmail.com> ---
I applied the patches and it now works as expected.

BTW, I'm running ubuntu bionic which has webKit 5.43, kmm uses 5.42, but a
symlink to 5.43 seems to run ok, at least so far.

Thank you Thomas for the speedy resolution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390044] New: can't add new investment in Investments window

2018-02-07 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390044

Bug ID: 390044
   Summary: can't add new investment in Investments window
   Product: kmymoney
   Version: 5.0.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: davidnel...@telus.net
  Target Milestone: ---

Version 5.0.80-09ffa40a

Investments | Equities shows current holdings, but 'New Investment...' option
in Investment Options popup is greyed out.

I got around it by duplicating and moving transaction from another account.

Generally KMM is working very well. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Error Linking konlinetasks_sepa

2017-11-20 Thread Christian David
Hi Gary,

could you solve the problem already?

If not: I doubt the issue is caused by the version of CMake you are using (it 
is not way newer than the version I used to create the files and CMake is 
pretty good in backwards compatibility).

Currently I asume this is an issue with automoc or an incorrect 
#include "moc_...". Did you try a full clean and rebuild?

Best
Christian

Am Samstag, 29. Juli 2017, 04:22:13 CET schrieb Gary Duzan:
>I've been trying to get KMyMoney4 working on NetBSD through pkgsrc/wip,
> and have made a fair amount of progress. I have rough packages for
> libalkimia, gwenhywfar, and aqbanking compiling, and now I'm working on
> kmymoney4 itself. It is currently failing to link konlinetasks_sepa.so,
> with multiple definitions from sepaStoragePlugin, one from
> plugins/onlinetasks/sepa/moc_sepastorageplugin.cpp and one from
> plugins/onlinetasks/sepa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_s
> epastorageplugin.cpp . I've included the full error below. Does this look
> familiar, or do I need to just dive into the cmake stuff? This is with
> 4.8.0 sources.
> 
>Thanks.
> 
>   Gary Duzan
> 
> 
> 
> [ 77%] Linking CXX shared module ../../../../lib/konlinetasks_sepa.so
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/m
> oc_compilation.cpp.o: In function
> `sepaStoragePlugin::qt_static_metacall(QObject*, QMetaObject::Ca ll, int,
> void**)':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/s
> epa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_sepastorageplugin.cpp:4
> 0: multiple definition of `sepaStoragePlugin::qt_static_metacall(QObject*,
> QMetaObject::Call, int, void**)'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:40: first defined here
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/
> moc_compilation.cpp.o: In function `onlineJob::isLocked() const':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/
> sepa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_sepastorageplugin.cpp:
> 62: multiple definition of `sepaStoragePlugin::metaObject() const'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:62: first defined here
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/
> moc_compilation.cpp.o: In function `sepaCreditTransferEdit::metaObject()
> const':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/
> sepa/konlinetasks_sepa_OBJECTS_autogen/UYX5XTB5RZ/moc_sepacredittransferedit
> .cpp:124: multiple definition of `sepaStoragePlugin::staticMetaObject'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:40: first defined here
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/
> moc_compilation.cpp.o: In function `sepaStoragePlugin::qt_metacast(char
> const*)':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/
> sepa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_sepastorageplugin.cpp:
> 66: multiple definition of `sepaStoragePlugin::qt_metacast(char const*)'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:66: first defined here
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/
> moc_compilation.cpp.o: In function
> `sepaStoragePlugin::qt_metacall(QMetaObject::Call, int, void**)':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/
> sepa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_sepastorageplugin.cpp:
> 79: multiple definition of
> `sepaStoragePlugin::qt_metacall(QMetaObject::Call, int, void**)'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:79: first defined here
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_autogen/
> moc_compilation.cpp.o: In function `onlineJob::sendDate() const':
> /usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinetasks/
> sepa/konlinetasks_sepa_OBJECTS_autogen/EWIEGA46WW/moc_sepastorageplugin.cpp:
> 62: multiple definition of `sepaStoragePlugin::staticMetaObjectExtraData'
> CMakeFiles/konlinetasks_sepa_OBJECTS.dir/konlinetasks_sepa_OBJECTS_automoc.
> cpp.o:/usr/pkgsrc/wip/kmymoney4/work/kmymoney-4.8.0/kmymoney/plugins/onlinet
> asks/sepa/moc_sepastorageplugin.cpp:40: first 

[kmymoney] [Bug 387040] Git commit c829ec79 broke investment price chart

2017-11-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=387040

--- Comment #3 from David Houlden <djhoul...@gmail.com> ---
Created attachment 108921
  --> https://bugs.kde.org/attachment.cgi?id=108921=edit
GBP chart after commit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 387040] Git commit c829ec79 broke investment price chart

2017-11-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=387040

--- Comment #2 from David Houlden <djhoul...@gmail.com> ---
Created attachment 108920
  --> https://bugs.kde.org/attachment.cgi?id=108920=edit
GBP chart before commit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 387040] New: Git commit c829ec79 broke investment price chart

2017-11-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=387040

Bug ID: 387040
   Summary: Git commit c829ec79 broke investment price chart
   Product: kmymoney
   Version: 4.8.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

Created attachment 108918
  --> https://bugs.kde.org/attachment.cgi?id=108918=edit
Examply KMyMoney file

The latest commit to the 4.8 branch has broken one of my investment reports.

I have shares which are priced in USD and my base currency in KMyMoney is GBP.
I produce two investment price charts for the shares showing the last year's
price history. One shows the price history in USD, the other in GBP. This is
achieved by ticking or unticking "Convert values to base currency" in the
report configuration. 

After commit c829ec79 the GBP price history is not converting the price. The
chart shows price history in USD. Attached is a KMyMoney file which can be used
to show the problem, a screen print of the USD chart and prints of the GBP
chart before and after the commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 384344] New: Apply commit from master to speed up 4.8 reports

2017-09-04 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=384344

Bug ID: 384344
   Summary: Apply commit from master to speed up 4.8 reports
   Product: kmymoney4
   Version: 4.8.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

I cherry picked commit 3b265c4 from git master and applied it to my copy of the
 4.8 branch. It significantly improved the time taken to display one of my
investment price history reports. In my opinion this would be a worthwhile
change to 4.8 before any 4.8.1 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 384021] Crash on investment charts with multiple investments

2017-08-26 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=384021

--- Comment #2 from David Houlden <djhoul...@gmail.com> ---
Created attachment 107532
  --> https://bugs.kde.org/attachment.cgi?id=107532=edit
Anon file to demonstrate problem

Open the anon file attached. In investment reports, R13, 14, 16 will crash
KMyMoney. R18 will work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 384021] New: Crash on investment charts with multiple investments

2017-08-25 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=384021

Bug ID: 384021
   Summary: Crash on investment charts with multiple investments
   Product: kmymoney4
   Version: 4.8.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

Created attachment 107521
  --> https://bugs.kde.org/attachment.cgi?id=107521=edit
Backtrace

Latest 4.8 git head crashes whenever I try to display an investment price graph
which shows price history for more than one investment. Charts showing only one
investment work ok. Backtrace attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383990] KDChart update has made graph X-Axis unreadable

2017-08-25 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=383990

--- Comment #1 from David Houlden <djhoul...@gmail.com> ---
Created attachment 107509
  --> https://bugs.kde.org/attachment.cgi?id=107509=edit
Graph before KDChart update

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383952] New: Cannot set holiday region

2017-08-24 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=383952

Bug ID: 383952
   Summary: Cannot set holiday region
   Product: kmymoney4
   Version: 4.8.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

I am installing KMyMoney on a new install of KDE 4.14.32. After compiling 4.8
from git I am unable to select a holiday region in settings -> scheduled
transactions. The list of regions is empty. Using git bisect I have traced this
problem to commit ce51d7b2f915b075839c0017c91567d4ab2bd66 (Make kdepimlibs
optional). Compiling from before this commit I get a selectable list of holiday
regions. When I run cmake I get this output which seems to indicate all should
be ok.

KDE PIM holidays:yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit

2017-07-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=382378

--- Comment #8 from David Houlden <djhoul...@gmail.com> ---
Anonymous file now uploaded to this bug. Ralf, you really need to compile a
KMyMoney from git prior to the offending commit in order to see what I
reported.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit

2017-07-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=382378

--- Comment #7 from David Houlden <djhoul...@gmail.com> ---
Created attachment 106680
  --> https://bugs.kde.org/attachment.cgi?id=106680=edit
Anonymous KMyMoney file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382378] Net Worth Graph broken by 4.8.1 commit

2017-07-17 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=382378

David Houlden <djhoul...@gmail.com> changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|FIXED   |---

--- Comment #6 from David Houlden <djhoul...@gmail.com> ---
Ralf, your latest fix does not correct the graph for me. I have always had
"show equity accounts" selected in KMyMoney settings since it became available
(probably years ago) but the Net Worth graph changed after commit
67d5ee7055dd3b0277423cd07ae92ea205f4b6af.

I cannot see why the amount in an opening balance account should be subtracted
from the total Net Worth on the graph as I described. The Net worth shown
elsewhere is correct.

The anonymous file I created the images above from is my own KMYMoney file with
many years of history in it. I will post the anon file to this bug so you can
investigate with that file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382378] New: Net Worth Graph broken by 4.8.1 commit

2017-07-15 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=382378

Bug ID: 382378
   Summary: Net Worth Graph broken by 4.8.1 commit
   Product: kmymoney4
   Version: 4.8.0
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: djhoul...@gmail.com
  Target Milestone: ---

Commit 67d5ee7055dd3b0277423cd07ae92ea205f4b6af to the 4.8 branch on 18th May
2017 has broken the Net Worth Graph.

Prior to this commit my 12 month net worth history chart was correct and
matched Net Worth shown on the home page assets and liability summary. After
this commit it seems that the amount of the Opening Balances equity account is
being subtracted from each net worth value shown on the graph.

Applying later commits to the 4.8 branch allows me to deselect equity accounts
in the report settings but this produces an even stranger graph where the
current net worth shown on the graph is correct but going back in time over the
12 months shown on the graph, the net worth becomes less and less than it
should be.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 381399] Can't retrieve stock prices

2017-06-20 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=381399

David Houlden <djhoul...@gmail.com> changed:

   What|Removed |Added

 CC||djhoul...@gmail.com

--- Comment #14 from David Houlden <djhoul...@gmail.com> ---
(In reply to Ralf Habacker from comment #3)
> (In reply to David Houlden from comment #1)
> > FT.com have changed that page layout recently. I got it working by changing
> > the KMyMoney settings to these.
> > 
> > URL:   http://funds.ft.com/uk/Tearsheet/Summary?s=%1:GBX
> ... 
> > Price:   Price \(GBX\) > class="mod-ui-data-list__value">([\d,]*\.\d*)
> 
> How should this work for non GBX currencies ?
> 
> The initial url uses http://funds.ft.com/uk/Tearsheet/Summary?s=%1 
> 
> and the website redirects to the currency related result e.g. if I enter
> 
> http://funds.ft.com/uk/Tearsheet/Summary?s=AT639083
> 
> I get
> 
> https://markets.ft.com/data/funds/tearsheet/summary?s=AT639083:EUR.

You are correct Ralf, this was just my fix which works for me. I added the GBX
for a good reason a long time ago and I am not sure if I need it anymore. In
the past, that web site has changed the investment prices from GBX to GBP and
back again on some investments. If the factor (number of decimal places) in
KMyMoney is set to assume the price will be in GBX and they change to GBP then
the stored price is wrong. Therefore I added GBX to the regexp so I got an
error if ft,com changed the price units.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 381399] Can't retrieve stock prices

2017-06-19 Thread David Houlden
https://bugs.kde.org/show_bug.cgi?id=381399

--- Comment #1 from David Houlden <djhoul...@gmail.com> ---
FT.com have changed that page layout recently. I got it working by changing the
KMyMoney settings to these.

URL:   http://funds.ft.com/uk/Tearsheet/Summary?s=%1:GBX
Symbol:   data-display-symbol="(.*):
Price:   Price \(GBX\)([\d,]*\.\d*)
Date:   Data delayed at least 15 minutes, as of (.*)
Date Format:   %m %d %y

Hope that helps.

David

On Monday 19 June 2017 14:38:11 StephenJH wrote:
> https://bugs.kde.org/show_bug.cgi?id=381399
> 
> Bug ID: 381399
>Summary: Can't retrieve stock prices
>Product: kmymoney4
>Version: 4.8.0
>   Platform: Other
> OS: Linux
> Status: UNCONFIRMED
>   Severity: normal
>   Priority: NOR
>  Component: onlinebanking
>   Assignee: kmymoney-devel@kde.org
>   Reporter: stephen.henstri...@gmail.com
>   Target Milestone: ---
> 
> Cannot get stock prices. Returns error:
> 
> ---
> Fetching URL http://funds.ft.com/uk/Tearsheet/Summary?s=GB00074476255...
> Unable to update price for GB000744762 (no price or no date)
> ---
> 
> Same error for every other stock price.
> 
> Have tried other sources (Yahoo, Yahoo UK, etc.) & get same error.
> 
> System is running Manjaro 7.0.1. I've tried on a second system with same 
> update
> level & get the same problem.
> 
> This was working until a week ago. Not clear if caused by Manjaro update or 
> new
> KMyMoney version.
> 
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [kmymoney4] [Bug 381399] New: Can't retrieve stock prices

2017-06-19 Thread David Houlden
FT.com have changed that page layout recently. I got it working by changing the 
KMyMoney settings to these.

URL:   http://funds.ft.com/uk/Tearsheet/Summary?s=%1:GBX
Symbol:   data-display-symbol="(.*):
Price:   Price \(GBX\)([\d,]*\.\d*)
Date:   Data delayed at least 15 minutes, as of (.*)
Date Format:   %m %d %y

Hope that helps.

David

On Monday 19 June 2017 14:38:11 StephenJH wrote:
> https://bugs.kde.org/show_bug.cgi?id=381399
> 
> Bug ID: 381399
>Summary: Can't retrieve stock prices
>Product: kmymoney4
>Version: 4.8.0
>   Platform: Other
> OS: Linux
> Status: UNCONFIRMED
>   Severity: normal
>   Priority: NOR
>  Component: onlinebanking
>   Assignee: kmymoney-devel@kde.org
>   Reporter: stephen.henstri...@gmail.com
>   Target Milestone: ---
> 
> Cannot get stock prices. Returns error:
> 
> ---
> Fetching URL http://funds.ft.com/uk/Tearsheet/Summary?s=GB00074476255...
> Unable to update price for GB000744762 (no price or no date)
> ---
> 
> Same error for every other stock price.
> 
> Have tried other sources (Yahoo, Yahoo UK, etc.) & get same error.
> 
> System is running Manjaro 7.0.1. I've tried on a second system with same 
> update
> level & get the same problem.
> 
> This was working until a week ago. Not clear if caused by Manjaro update or 
> new
> KMyMoney version.
> 
> 


Re: Review Request 127678: Register metatypes that are used in Qt Designer files to eliminate warnings.

2017-06-04 Thread Christian David


> On April 22, 2016, 8:19 vorm., Christian David wrote:
> > Hi Mitch,
> > 
> > according to the [Qt 
> > Docu](http://doc.qt.io/qt-5/qmetatype.html#qRegisterMetaType-1) 
> > ```qRegisterMetaType``` is (only) needed under some circumstances:
> > 
> > To use the type T in QVariant, using Q_DECLARE_METATYPE() is 
> > sufficient. To use the type T in queued signal and slot connections, 
> > qRegisterMetaType() must be called before the first connection is 
> > established.
> > 
> > To prevent complicated issues if we use queued connections ourself in the 
> > future the ```qRegisterMetaType``` should go somewhere else. I think it 
> > should be ```mymoneymoney.cpp``` for ```MyMoneyMoney``` but I am unsure 
> > here.
> 
> Mitch Frazier wrote:
> In terms of logically where it ought to go I don't know, I'm not that 
> familiar with the organization of the code base.  However, in terms of 
> satisfying the requirement that it "must be called before the first 
> connection is established," making it a static variable initializer should be 
> sufficient regardless of where it is placed.  Static initializers are run 
> when the .so is loaded so they'll be executed before any "real" code gets run.
> 
> Christian David wrote:
> In your case they are loaded in another (kind of unrelated) library than 
> the library of the original objects. This violates the concept of enclosed 
> units. To be specific; the ```qRegisterMetaType()``` call should be in the 
> ```kmm_mymoney``` library. To suppress the warnings only they could go in the 
> ```kmymoneywidgets``` library (but not ```kmm_widgets```). Your static 
> initializer trick is cool.
> 
> Thomas Baumgart wrote:
> Ping: Christian / Mitch what is the status on this one? Did you come to a 
> conclusion what to do with the patch?

I recommend to use my recommended relocation of the ´´´qRegisterMetaType()´´´.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127678/#review94753
---


On April 22, 2016, 5:01 nachm., Mitch Frazier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127678/
> ---
> 
> (Updated April 22, 2016, 5:01 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Register metatypes to eliminate Qt Desinger warnings.
> 
> Registering metatypes for a type used in a widget eliminates
> the following types of warnings from Qt Designer on start up
> (displayed when designer is started from a console window):
> 
> QMetaProperty::read: Unable to handle unregistered datatype
>   '' for property '::'
> 
> 
> Diffs
> -
> 
>   kmymoney/widgets/kmymoneycurrencyselector.cpp 41be539 
>   kmymoney/widgets/kmymoneyedit.cpp ac79db7 
> 
> Diff: https://git.reviewboard.kde.org/r/127678/diff/
> 
> 
> Testing
> ---
> 
> Tested dialogs that use the data types.
> 
> 
> Thanks,
> 
> Mitch Frazier
> 
>



Re: Review Request 130009: Use qCDebug instead of qDebug

2017-06-04 Thread Christian David


> On Juni 4, 2017, 11:36 vorm., Christian David wrote:
> > I suggest to discard this review request. Mainly because I do not think 
> > that we will write the long text ```qCDebug(LOG_KMYMONEY)``` in future. 
> > Maybe we can use this for some submodules of KMyMoney in future.

Btw: For what do you need or want this?


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130009/#review103275
---


On März 13, 2017, Mittag, José Arthur Benetasso Villanova wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130009/
> ---
> 
> (Updated März 13, 2017, Mittag)
> 
> 
> Review request for KMymoney and José Arthur Benetasso Villanova.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Use qCDebug instead of qDebug
> 
> 
> Diffs
> -
> 
>   kmymoney/CMakeLists.txt 585c7d4 
>   kmymoney/converter/existingtransactionmatchfinder.cpp 7bedd28 
>   kmymoney/converter/mymoneygncreader.cpp 4c6d28c 
>   kmymoney/converter/mymoneyqifreader.cpp 3ad6723 
>   kmymoney/converter/mymoneyqifwriter.cpp da796a3 
>   kmymoney/converter/mymoneystatementreader.cpp 825b490 
>   kmymoney/converter/scheduledtransactionmatchfinder.cpp 4713a2b 
>   kmymoney/converter/tests/converter-test.cpp 3b596ee 
>   kmymoney/converter/transactionmatchfinder.cpp 56e97dd 
>   kmymoney/converter/webpricequote.cpp 15b1467 
>   kmymoney/dialogs/kgeneratesqldlg.cpp 5d20c1d 
>   kmymoney/dialogs/kselectdatabasedlg.cpp c281fc8 
>   kmymoney/kmymoney.h dd37972 
>   kmymoney/kmymoney.cpp 674f251 
>   kmymoney/kmymoneyutils.cpp 0492578 
>   kmymoney/logging.h PRE-CREATION 
>   kmymoney/logging.cpp PRE-CREATION 
>   kmymoney/main.cpp 77d68a7 
>   kmymoney/models/accountsmodel.cpp 12aac8d 
>   kmymoney/models/costcentermodel.cpp ac2d671 
>   kmymoney/models/ledgermodel.cpp 47e7b06 
>   kmymoney/models/modeltest.cpp 225e5de 
>   kmymoney/models/payeesmodel.cpp 35ff045 
>   kmymoney/mymoney/CMakeLists.txt 33b6177 
>   kmymoney/mymoney/mymoneyfile.h 2494af3 
>   kmymoney/mymoney/mymoneyfile.cpp d39a1d6 
>   kmymoney/mymoney/mymoneyforecast.cpp b286a85 
>   kmymoney/mymoney/onlinejobadministration.cpp d5f44f6 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 4a68175 
>   kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp dbaf6d0 
>   kmymoney/mymoney/tests/mymoneymoney-test.cpp ef1dd26 
>   kmymoney/mymoney/tests/mymoneyschedule-test.cpp 5c911fe 
>   kmymoney/mymoney/tests/mymoneytransaction-test.cpp f6d52c6 
>   kmymoney/plugins/CMakeLists.txt 6b235fb 
>   kmymoney/plugins/csvexport/CMakeLists.txt 454d7d2 
>   kmymoney/plugins/csvexport/csvwriter.cpp 83365bb 
>   kmymoney/plugins/csvimport/csvwizard.cpp e9ca8a6 
>   kmymoney/plugins/icalendarexport/CMakeLists.txt e30245f 
>   kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp ed14916 
>   kmymoney/plugins/kbanking/mymoneybanking.cpp 3e2f25b 
>   kmymoney/plugins/ofximport/dialogs/CMakeLists.txt b913db8 
>   kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp 2ddbb39 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp cff2ed9 
>   kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 83be16e 
>   kmymoney/plugins/reconciliationreport/CMakeLists.txt b28dc02 
>   kmymoney/plugins/reconciliationreport/reconciliationreport.cpp ee2d42f 
>   kmymoney/reports/kreportchartview.cpp d1f0c51 
>   kmymoney/reports/pivottable.cpp 833dc45 
>   kmymoney/reports/querytable.cpp 4d5a843 
>   kmymoney/reports/reporttable.cpp 1acec56 
>   kmymoney/reports/tests/reportstestcommon.cpp f64d3b6 
>   kmymoney/tests/kmymoneyutils-test.h 3faac41 
>   kmymoney/views/kforecastview.cpp 13c8b1a 
>   kmymoney/views/kmymoneyview.cpp 91750fa 
>   kmymoney/views/konlinejoboutbox.cpp 0708346 
>   kmymoney/views/kpayeesview.cpp fbe6fd0 
>   kmymoney/views/kreportsview.cpp a98d5b8 
>   kmymoney/views/ktagsview.cpp f361a4b 
>   kmymoney/views/ledgerdelegate.cpp 7274966 
>   kmymoney/views/ledgerview.cpp 8807d40 
>   kmymoney/views/newspliteditor.cpp 707117a 
>   kmymoney/views/newtransactioneditor.cpp b7f070d 
>   kmymoney/views/simpleledgerview.cpp 6793fdf 
>   kmymoney/views/splitdelegate.cpp 510d55f 
>   kmymoney/views/splitdialog.cpp becdfcf 
>   kmymoney/widgets/CMakeLists.txt 7560682 
>   kmymoney/widgets/kmymoneymvccombo.cpp 29e378f 
>   kmymoney/widgets/transaction.cpp 4061ae2 
> 
> Diff: https://git.reviewboard.kde.org/r/130009/diff/
> 
> 
> Testing
> ---
> 
> For now just compiled
> 
> 
> Thanks,
> 
> José Arthur Benetasso Villanova
> 
>



Re: Review Request 130009: Use qCDebug instead of qDebug

2017-06-04 Thread Christian David

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130009/#review103275
---



I suggest to discard this review request. Mainly because I do not think that we 
will write the long text ```qCDebug(LOG_KMYMONEY)``` in future. Maybe we can 
use this for some submodules of KMyMoney in future.

- Christian David


On März 13, 2017, Mittag, José Arthur Benetasso Villanova wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130009/
> ---
> 
> (Updated März 13, 2017, Mittag)
> 
> 
> Review request for KMymoney and José Arthur Benetasso Villanova.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Use qCDebug instead of qDebug
> 
> 
> Diffs
> -
> 
>   kmymoney/CMakeLists.txt 585c7d4 
>   kmymoney/converter/existingtransactionmatchfinder.cpp 7bedd28 
>   kmymoney/converter/mymoneygncreader.cpp 4c6d28c 
>   kmymoney/converter/mymoneyqifreader.cpp 3ad6723 
>   kmymoney/converter/mymoneyqifwriter.cpp da796a3 
>   kmymoney/converter/mymoneystatementreader.cpp 825b490 
>   kmymoney/converter/scheduledtransactionmatchfinder.cpp 4713a2b 
>   kmymoney/converter/tests/converter-test.cpp 3b596ee 
>   kmymoney/converter/transactionmatchfinder.cpp 56e97dd 
>   kmymoney/converter/webpricequote.cpp 15b1467 
>   kmymoney/dialogs/kgeneratesqldlg.cpp 5d20c1d 
>   kmymoney/dialogs/kselectdatabasedlg.cpp c281fc8 
>   kmymoney/kmymoney.h dd37972 
>   kmymoney/kmymoney.cpp 674f251 
>   kmymoney/kmymoneyutils.cpp 0492578 
>   kmymoney/logging.h PRE-CREATION 
>   kmymoney/logging.cpp PRE-CREATION 
>   kmymoney/main.cpp 77d68a7 
>   kmymoney/models/accountsmodel.cpp 12aac8d 
>   kmymoney/models/costcentermodel.cpp ac2d671 
>   kmymoney/models/ledgermodel.cpp 47e7b06 
>   kmymoney/models/modeltest.cpp 225e5de 
>   kmymoney/models/payeesmodel.cpp 35ff045 
>   kmymoney/mymoney/CMakeLists.txt 33b6177 
>   kmymoney/mymoney/mymoneyfile.h 2494af3 
>   kmymoney/mymoney/mymoneyfile.cpp d39a1d6 
>   kmymoney/mymoney/mymoneyforecast.cpp b286a85 
>   kmymoney/mymoney/onlinejobadministration.cpp d5f44f6 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 4a68175 
>   kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp dbaf6d0 
>   kmymoney/mymoney/tests/mymoneymoney-test.cpp ef1dd26 
>   kmymoney/mymoney/tests/mymoneyschedule-test.cpp 5c911fe 
>   kmymoney/mymoney/tests/mymoneytransaction-test.cpp f6d52c6 
>   kmymoney/plugins/CMakeLists.txt 6b235fb 
>   kmymoney/plugins/csvexport/CMakeLists.txt 454d7d2 
>   kmymoney/plugins/csvexport/csvwriter.cpp 83365bb 
>   kmymoney/plugins/csvimport/csvwizard.cpp e9ca8a6 
>   kmymoney/plugins/icalendarexport/CMakeLists.txt e30245f 
>   kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp ed14916 
>   kmymoney/plugins/kbanking/mymoneybanking.cpp 3e2f25b 
>   kmymoney/plugins/ofximport/dialogs/CMakeLists.txt b913db8 
>   kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp 2ddbb39 
>   kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp cff2ed9 
>   kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 83be16e 
>   kmymoney/plugins/reconciliationreport/CMakeLists.txt b28dc02 
>   kmymoney/plugins/reconciliationreport/reconciliationreport.cpp ee2d42f 
>   kmymoney/reports/kreportchartview.cpp d1f0c51 
>   kmymoney/reports/pivottable.cpp 833dc45 
>   kmymoney/reports/querytable.cpp 4d5a843 
>   kmymoney/reports/reporttable.cpp 1acec56 
>   kmymoney/reports/tests/reportstestcommon.cpp f64d3b6 
>   kmymoney/tests/kmymoneyutils-test.h 3faac41 
>   kmymoney/views/kforecastview.cpp 13c8b1a 
>   kmymoney/views/kmymoneyview.cpp 91750fa 
>   kmymoney/views/konlinejoboutbox.cpp 0708346 
>   kmymoney/views/kpayeesview.cpp fbe6fd0 
>   kmymoney/views/kreportsview.cpp a98d5b8 
>   kmymoney/views/ktagsview.cpp f361a4b 
>   kmymoney/views/ledgerdelegate.cpp 7274966 
>   kmymoney/views/ledgerview.cpp 8807d40 
>   kmymoney/views/newspliteditor.cpp 707117a 
>   kmymoney/views/newtransactioneditor.cpp b7f070d 
>   kmymoney/views/simpleledgerview.cpp 6793fdf 
>   kmymoney/views/splitdelegate.cpp 510d55f 
>   kmymoney/views/splitdialog.cpp becdfcf 
>   kmymoney/widgets/CMakeLists.txt 7560682 
>   kmymoney/widgets/kmymoneymvccombo.cpp 29e378f 
>   kmymoney/widgets/transaction.cpp 4061ae2 
> 
> Diff: https://git.reviewboard.kde.org/r/130009/diff/
> 
> 
> Testing
> ---
> 
> For now just compiled
> 
> 
> Thanks,
> 
> José Arthur Benetasso Villanova
> 
>



Re: Review Request 130143: Add support for dedicated opening balance account.

2017-06-04 Thread Christian David

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103274
---



Here are some things that came to my mind while reading through this review 
request. Unfortunatly I cannot try the patch because I cannot compile the 4.8 
branch.

What happens if the user creates a new account (no opening balances account) 
and enters a opening balance and there is no opening balances account, yet? Is 
a opening balance account created (silently)? The user can rename it later then 
(less user interaction, so this is my preferred behavior).

What if the user creates a opening balances account with a opening balance?


kmymoney/converter/mymoneytemplate.cpp (line 416)
<https://git.reviewboard.kde.org/r/130143/#comment68695>

I think setting a value is not needed. Also someone who only reads the XML 
file could think setting ```value="0"``` could deactivate the flag. Then it 
would be ``.



kmymoney/dialogs/knewaccountdlg.cpp (line 239)
<https://git.reviewboard.kde.org/r/130143/#comment68700>

This could confuse the user. Because he selected his new account to become 
an opening balances account but this option is silently ignored.

To solve this the checkbox to make an account an opening balances account 
could be disabled and a notice or label inform the user why.



kmymoney/dialogs/knewaccountdlg.cpp (line 243)
<https://git.reviewboard.kde.org/r/130143/#comment68699>

```transactionList.isEmpty()``` is faster



kmymoney/mymoney/mymoneyfile.cpp (line 1104)
<https://git.reviewboard.kde.org/r/130143/#comment68697>

The RegExp could be replaced by ```QString::startsWith()```

http://doc.qt.io/qt-5/qstring.html#startsWith



kmymoney/mymoney/mymoneyfile.cpp (line 1107)
<https://git.reviewboard.kde.org/r/130143/#comment68698>

I know you did not write but I see it now: The ```if```s could be combinde 
with ```&&```? Also ```(*it).foobar()``` is ```it->foobar()```.


- Christian David


On Mai 30, 2017, 9:45 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> ---
> 
> (Updated Mai 30, 2017, 9:45 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
> http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This patch introduce a feature to specify a dedicated account
> to be used as opening balance account instead of using an account
> with a predefined name which may be language specific.
> 
> The "opening balance account" flag could be set in the account
> editor if no other account contains this flag. Also changing
> the state of the flag is only possible if no transactions are
> assigned to the account having this flag.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a related template account flag if specified
> in the following form
> 
> 
>
> 
> 
> If specified the template admin needs to make sure that only one
> template account has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> BUG:370290
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/mymoneytemplate.cpp 
> 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui 
> bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 
> 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 
> 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 
> 40b103ca965e0a1973b6fd0a351ddb976aa10471 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> ---
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given 
> account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an 
> additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if 
> transactions are assigned to the opening balance account -> check box is 
> disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the 
> template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>



Severe bug in reports in master branch

2017-05-31 Thread Christian David
Hello,

I just noticed a severe bug in the reports which is probably not very old. In 
a tax report I ordered the transactions by category. However, in a category a 
split is shown which has a different category but another split of the 
transaction is in that category.

Has somebody change something is this area?

Best
Chris


Re: Review Request 130143: Add support for dedicated opening balance account.

2017-05-31 Thread Christian David

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103259
---



Without reading the details: I think we should put all effort into the master 
branch. The 4.8 branch should be for bug-fixes only because there is no chance 
that we can keep support for Qt 4/kdelibs 4.

- Christian David


On Mai 30, 2017, 9:45 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> ---
> 
> (Updated Mai 30, 2017, 9:45 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
> http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> This patch introduce a feature to specify a dedicated account
> to be used as opening balance account instead of using an account
> with a predefined name which may be language specific.
> 
> The "opening balance account" flag could be set in the account
> editor if no other account contains this flag. Also changing
> the state of the flag is only possible if no transactions are
> assigned to the account having this flag.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a related template account flag if specified
> in the following form
> 
> 
>
> 
> 
> If specified the template admin needs to make sure that only one
> template account has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> BUG:370290
> 
> 
> Diffs
> -
> 
>   kmymoney/converter/mymoneytemplate.cpp 
> 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.cpp 
> dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui 
> bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp 
> b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 
> 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 
> 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 
> 40b103ca965e0a1973b6fd0a351ddb976aa10471 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> ---
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given 
> account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an 
> additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if 
> transactions are assigned to the opening balance account -> check box is 
> disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the 
> template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>



Re: Review Request 130135: Removed national credit transfers

2017-05-31 Thread Christian David (c.david)
Hello Andreas,

I noticed that build.kde.org fails since this review request was checked in 
[1]. Do you know why? Or can you even fix it (I cannot compile the 4.8 branch)? 
If not, we can just revert the commit. This change cleans our codebase but 
does not change anything for the user (and the branch 4.8 is at end of 
lifetime).

Best,
Christian


[1] https://build.kde.org/job/kmymoney%204.8%20latest-qt4/89/

On Dienstag, 23. Mai 2017 20:16:21 CEST Andreas Sturmlechner wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130135/
> ---
> 
> (Updated May 23, 2017, 6:16 p.m.)
> 
> 
> Status
> --
> 
> This change has been marked as submitted.
> 
> 
> Review request for KMymoney.
> 
> 
> Changes
> ---
> 
> Submitted with commit c78183f18201b16436008ea4306a974f180141d7 by Andreas
> Sturmlechner on behalf of Christian Dávid to branch 4.8.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> They are not supported by the banks anymore. So they can be removed.
> 
> Unfortunately they contained the only example for a task converter.
> Due to the removed plugin the CMakeLists.txt for sepa could be
> simplified.
> 
> Cherry-picked from d514e650
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/kbanking/aqbankingkmmoperators.h
> a314cd7218118cd695ade0d2344fbb450c698b16
> kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp
> 6c2b5d8a9963c0506c52d2e105fa2443f8350a52
> kmymoney/plugins/kbanking/mymoneybanking.h
> c2559ae73aa5ae5c5480ffac8512d6936a94
> kmymoney/plugins/kbanking/mymoneybanking.cpp
> d8c4a5711548ef5b0f29e228100b35d2d675f238
> kmymoney/plugins/kbanking/tasksettings/credittransfersettingsbase.h
> 28d55a06f1e4446bd1840e8be368533824b6e5d1
> kmymoney/plugins/onlinetasks/CMakeLists.txt
> 7be531376bdf24bd415a9af32812b3a7c47a07b6
> kmymoney/plugins/onlinetasks/national/CMakeLists.txt
> d3e7c44f937d001fed67dcb4b58ba14f293ea774
> kmymoney/plugins/onlinetasks/national/converter/CMakeLists.txt
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.h
> 7653c231fd4d142956a39ac47307f43998cc1344
> kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.c
> pp d10b3933271235186fe81cceea0cdb2cd1b30d02
> kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.h
> 900f8d8025ba88f3c2d8fe90bcb9b873dc2897c5
> kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.c
> pp a7aae64d153a6af9f21586f97fca27865df76b77
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalorders.desktop.in
> af817eed71f4f3aa6f444d3064b2b612824660f1
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalordersui.desktop.in
> f548a33df084cd08d39cdc99356025fbf7052f3b
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalstorageplugin.deskto
> p.in 86db1b08b116ecdab174025faef107a52ae93239
> kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.h
> 44157e412b27b0f759d2607ebea65d663eced0da
> kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.cpp
> 4a0c9e7586646c162021e66e5146912fc335c151
> kmymoney/plugins/onlinetasks/national/nationalstorageplugin.h
> c61054b3e892838318e60302ed90ca37c5345eac
> kmymoney/plugins/onlinetasks/national/nationalstorageplugin.cpp
> 5464fb94495b4ecbf0d73a498e9b4badccc6aa94
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransfer.h
> 660b4aa481696b58245e3b638a7827e7cb4d23b0
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.h
> 0b9745574ecdfd17a168ccad5543a8883e92225e
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.cpp
> a7b4421f2ea0403f4aaf187d39e3c22ae5b19e93
> kmymoney/plugins/onlinetasks/national/tests/CMakeLists.txt
> e606d2d2cbec0c4cc1418f6b23aab20392606da8
> kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.h
> 9c2ca335b7454ec745fa70b56e0b4e3780f0740a
> kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.cpp
> 63834e7952b15fc4f43b0dac40a7d612ea5b97c0
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.h
> aa07cdaa7fcb315cddd6b0ec91090c039d661570
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.cpp
> 8e0da0815e6938cd8b7086e2d955e6de0d452fd9
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.ui
> 5c0b7ff818d95482e10a1d3b052b25ed275849d3
> kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt
> 3c2d9db16c1e3ee3a44f21e008bb1ef884cbb8fb
> 
> Diff: https://git.reviewboard.kde.org/r/130135/diff/
> 
> 
> Testing
> ---
> 
> Successfully builds again with the patch (there was a moc error after
> upgrade to boost-1.63).



Re: Review Request 130135: Removed national credit transfers

2017-05-21 Thread Christian David

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130135/#review103231
---


Ship it!




Ship It!

- Christian David


On Mai 18, 2017, 9:45 nachm., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130135/
> ---
> 
> (Updated Mai 18, 2017, 9:45 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> They are not supported by the banks anymore. So they can be removed.
> 
> Unfortunately they contained the only example for a task converter.
> Due to the removed plugin the CMakeLists.txt for sepa could be
> simplified.
> 
> Cherry-picked from d514e650
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/kbanking/aqbankingkmmoperators.h 
> a314cd7218118cd695ade0d2344fbb450c698b16 
>   kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp 
> 6c2b5d8a9963c0506c52d2e105fa2443f8350a52 
>   kmymoney/plugins/kbanking/mymoneybanking.h 
> c2559ae73aa5ae5c5480ffac8512d6936a94 
>   kmymoney/plugins/kbanking/mymoneybanking.cpp 
> d8c4a5711548ef5b0f29e228100b35d2d675f238 
>   kmymoney/plugins/kbanking/tasksettings/credittransfersettingsbase.h 
> 28d55a06f1e4446bd1840e8be368533824b6e5d1 
>   kmymoney/plugins/onlinetasks/CMakeLists.txt 
> 7be531376bdf24bd415a9af32812b3a7c47a07b6 
>   kmymoney/plugins/onlinetasks/national/CMakeLists.txt 
> d3e7c44f937d001fed67dcb4b58ba14f293ea774 
>   kmymoney/plugins/onlinetasks/national/converter/CMakeLists.txt 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.h 
> 7653c231fd4d142956a39ac47307f43998cc1344 
>   
> kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.cpp 
> d10b3933271235186fe81cceea0cdb2cd1b30d02 
>   kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.h 
> 900f8d8025ba88f3c2d8fe90bcb9b873dc2897c5 
>   
> kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.cpp 
> a7aae64d153a6af9f21586f97fca27865df76b77 
>   kmymoney/plugins/onlinetasks/national/kmymoney-nationalorders.desktop.in 
> af817eed71f4f3aa6f444d3064b2b612824660f1 
>   kmymoney/plugins/onlinetasks/national/kmymoney-nationalordersui.desktop.in 
> f548a33df084cd08d39cdc99356025fbf7052f3b 
>   
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalstorageplugin.desktop.in
>  86db1b08b116ecdab174025faef107a52ae93239 
>   kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.h 
> 44157e412b27b0f759d2607ebea65d663eced0da 
>   kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.cpp 
> 4a0c9e7586646c162021e66e5146912fc335c151 
>   kmymoney/plugins/onlinetasks/national/nationalstorageplugin.h 
> c61054b3e892838318e60302ed90ca37c5345eac 
>   kmymoney/plugins/onlinetasks/national/nationalstorageplugin.cpp 
> 5464fb94495b4ecbf0d73a498e9b4badccc6aa94 
>   kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransfer.h 
> 660b4aa481696b58245e3b638a7827e7cb4d23b0 
>   kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.h 
> 0b9745574ecdfd17a168ccad5543a8883e92225e 
>   kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.cpp 
> a7b4421f2ea0403f4aaf187d39e3c22ae5b19e93 
>   kmymoney/plugins/onlinetasks/national/tests/CMakeLists.txt 
> e606d2d2cbec0c4cc1418f6b23aab20392606da8 
>   kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.h 
> 9c2ca335b7454ec745fa70b56e0b4e3780f0740a 
>   kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.cpp 
> 63834e7952b15fc4f43b0dac40a7d612ea5b97c0 
>   kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.h 
> aa07cdaa7fcb315cddd6b0ec91090c039d661570 
>   kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.cpp 
> 8e0da0815e6938cd8b7086e2d955e6de0d452fd9 
>   kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.ui 
> 5c0b7ff818d95482e10a1d3b052b25ed275849d3 
>   kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt 
> 3c2d9db16c1e3ee3a44f21e008bb1ef884cbb8fb 
> 
> Diff: https://git.reviewboard.kde.org/r/130135/diff/
> 
> 
> Testing
> ---
> 
> Successfully builds again with the patch (there was a moc error after upgrade 
> to boost-1.63).
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>



[kmymoney4] [Bug 249844] wrong memo field after duplicating and editing transaction

2017-05-20 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=249844

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

   Version Fixed In|5.0 |4.8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 378379] Segfault if a Report is deleted from reports menu whilst it is open in a tab.

2017-05-20 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=378379

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

   Version Fixed In|5.0 |4.8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 379169] installed mymoneyaccount.h references non-existent payeeidentifier/ headers

2017-05-07 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=379169

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

 CC||christian-da...@web.de
   Assignee|kmymoney-devel@kde.org  |christian-da...@web.de

--- Comment #2 from Christian David <christian-da...@web.de> ---
Hi Rex,

do you need this bug to be fixed in 4.8? I will definitely fix it for 5.x soon.

Greetings
Christian

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-12-29 Thread Christian David


> On Dez. 25, 2016, 1:37 nachm., Łukasz Wojniłowicz wrote:
> > After this change, CSV Importer plugin isn't displayed in File->Import 
> > menu, even after steps suggested in following post
> > http://kmymoney-devel.kde.narkive.com/hSaamIlT/plugins-path-in-master-branch
> > So please add making this working again to your TODO list.

Hi ?ukasz,

are the other plugins shown? Unfortunatly it will take a week (or two) before I 
can have a look on this issue. However, I am quite sure I checked the 
import/export plugins before I send this patch. Let me revaluate that…

Greetings
Christian


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129393/#review101572
---


On Nov. 26, 2016, 4:12 nachm., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129393/
> ---
> 
> (Updated Nov. 26, 2016, 4:12 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Hi,
> 
> this is my long overdue change on the plugin system. It actually started in 
> Randa.
> 
> Sorry for such a long review request! I think it is ready for publishing, I 
> made this review request only to give everybody a chance to ask questions :)
> 
> 
> Commit 1
> 
> 
> This is a major change. Instead of a KPluginFactory based plugin
> loading, Qt's plugin system is used. The docu was adopeted to reflect
> this.
> 
> Commit 2
> 
> 
> The plugins for onlineTasks are now loaded with QPluginLoader on demand.
> The necessary information is encoded in Qt's json plugin header.
> 
> Commit 3
> 
> 
> Moved plugin loader out of kmm_plugin and put it into the executable
> 
> The plugin shared library is for plugins now and does not include the
> loading of plugins (which was kind of wired). All loading operations of
> standard plugins is done in KMyMoneyApp now.
> 
> Therefor the interface system for plugins needed do be reworked to
> great degree. Some overly complex operations were replaced by simpler
> ones. All plugins were adopted to that. Also it is more type safe now.
> 
> Now the user configuration which plugins should be loaded or not is
> respected (standard plugins only).
> 
> An old bug was fixed: If the configuration in the plugin settings
> changed the plugins are loaded/unloaded after the user accepts the
> dialog (perviously this was done when the checkbox was clicked).
> 
> Todos
> =
> 
> The new system is still not finished. However, it is a great step in
> the right direction. An uncomplete list of FIXMEs (or bugs?):
> 
> 1. pluginloader.{h,cpp} are gui only now and should be merged into the
> settings dialog.
> 2. The UI for plugins still has some issues, e.g. the online banking
> plugins which are loaded on demand (and are not deactivatable) have a
> checkbox for loading and unloading which has no function.
> 3. Unloading plugins may not work correctly (I think it never did).
> 4. The payeeIdentifiers are not listet in the plugin settings page.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 09970dd5626e308c443ea20ee20ecf8503b21209 
>   kmymoney/CMakeLists.txt acbe6a3c91a62a15871a0061486a7d0771b3a5e6 
>   kmymoney/dialogs/konlinetransferform.h 
> e4761904d68a92471c0b05cc9e5b2bcd1461511d 
>   kmymoney/dialogs/konlinetransferform.cpp 
> 07e73ab17f93cd8fd804b9d11ede2b049f76eefe 
>   kmymoney/dialogs/settings/ksettingsplugins.cpp 
> 007a59d4be08fe779245dd5d52f664ebfcee447d 
>   kmymoney/kmymoney.h 8d10023b5e35be8f4449973ea16e0ec0cc0acca2 
>   kmymoney/kmymoney.cpp 043342dd87cbc03557c5e2b29eb3b9dfcd1083dd 
>   kmymoney/mymoney/onlinejobadministration.h 
> e72d1a6e46c7c8bcc7cf05193e04bdc8bd9103f5 
>   kmymoney/mymoney/onlinejobadministration.cpp 
> 52658747a44bc5477ccd75a531aef471b4553b19 
>   kmymoney/pluginloader.h PRE-CREATION 
>   kmymoney/pluginloader.cpp PRE-CREATION 
>   kmymoney/plugins/CMakeLists.txt fd7cad75256c0a43d7d1fd3a23b37cef7fab8bf9 
>   kmymoney/plugins/csvexport/CMakeLists.txt 
> 9f2e29fd43e32cd3c6acc7f597c45d522eac4eaf 
>   kmymoney/plugins/csvexport/csvexport.json.in PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.h 
> f163ade2d59ae1b6eb32958a317384e77a658523 
>   kmymoney/plugins/csvexport/csvexporterplugin.cpp 
> 31027c65111edbad8ca78b00f5b7df572056bb37 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop 
> 95

Openning of Databases fails

2016-12-03 Thread Christian David
Hello,

I cannot open my old databases anymore. The query which causes the problem is 
attached. Note that there are more colums in INSERT INTO than in the SELECT 
(the costCenterId) — which will obviously fail.

We really need a new strategy for the database backend, the current state is 
not tenable.

Greetings
Christian


Driver = QSQLITE, Host = localhost, User = xxx, Database = xxx/kmymoney-
testfiles/tset.sqlite
Driver Error: 
Database Error No -1: 
Text:  
Error type 0
Executed: INSERT INTO kmmSplits (transactionId, txType, splitId, payeeId, 
reconcileDate, action, reconcileFlag, value, valueFormatted, shares, 
sharesFormatted, price, priceFormatted, memo, accountId, costCenterId, 
checkNumber, postDate, bankId) SELECT transactionId, txType, splitId, payeeId, 
reconcileDate, action, reconcileFlag, value, valueFormatted, shares, 
sharesFormatted, price, priceFormatted, memo, accountId, checkNumber, postDate, 
bankId FROM kmmtmpSplits;
Query error No -1: No query Unable to fetch row
Error type 1
void MyMoneyStorageSql::cancelCommitUnit(const QString&) - bool 
MyMoneyStorageSql::alterTable(const MyMoneyDbTable&, int) s/be int 
MyMoneyStorageSql::upgradeToV9()
terminate called after throwing an instance of 'MyMoneyException'



[kmymoney4] [Bug 373217] New: The defaults button in KMyMoney's settings does not reset all options

2016-12-03 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=373217

Bug ID: 373217
   Summary: The defaults button in KMyMoney's settings does not
reset all options
   Product: kmymoney4
   Version: git (master)
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: christian-da...@web.de
  Target Milestone: ---

Not all elements are reset to their default value if the corresponding button
is pressed.

A not complete list of such elements:

Scheduled transactions -> Use holiday calendar for region
Ledger -> Data entry -> Autofill

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-26 Thread Christian David
/kbanking/kmm_kbanking.desktop 
414964f6c9fe3d34f03189783aa915d3ba37ff18 
  kmymoney/plugins/kbanking/mymoneybanking.h 
fe0cb5c5feeeac9ffb4657e49da318cc429d2ac4 
  kmymoney/plugins/kbanking/mymoneybanking.cpp 
ad53d4ba608e221a920a4899ebbfab7466c0293f 
  kmymoney/plugins/kmymoney-onlinetaskui.desktop 
23cfd182a0e12c0be9a97f0490ceedc3456f1b84 
  kmymoney/plugins/kmymoney-payeeidentifierdelegate.desktop 
cc2689f5c1f36ac4d75d1d6bd7ce0c0877b7ca18 
  kmymoney/plugins/kmymoney-plugin.desktop 
28673a8ed8ff8578f046c02b67da4e305f610ecf 
  kmymoney/plugins/kmymoneyplugin.h 12748dc80cca025212d53db13f0e7ccce71cc465 
  kmymoney/plugins/kmymoneyplugin.cpp b55b497607089c4cf036696695b79fd341ec9a3a 
  kmymoney/plugins/ofximport/CMakeLists.txt 
e97b1e87bf1b2141dca623903480691f1f5d0455 
  kmymoney/plugins/ofximport/kmm_ofximport.desktop 
393a0887abbecbf4efb931b8d0ef1da474572025 
  kmymoney/plugins/ofximport/ofximport.json.in PRE-CREATION 
  kmymoney/plugins/ofximport/ofximporterplugin.h 
667a0996654911d58a6d183ba2d0b244a9457172 
  kmymoney/plugins/ofximport/ofximporterplugin.cpp 
46842eee0870c8f2c21678dde112f497b7c8e2a0 
  kmymoney/plugins/onlinejobpluginmockup/CMakeLists.txt 
17db89d743b4f5871aa720654f9fb1af0591bde1 
  kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.desktop 
2b5d33c495b342b1cade6d4cbd2b62165c18e29d 
  kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.json.in 
PRE-CREATION 
  kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.h 
f6165d3545d45c1fae6cc72543ffa7750d2a29ee 
  kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 
561cf4fa8d925194950e93273810f1d862acf6bf 
  kmymoney/plugins/onlinepluginextended.h 
ec84a2c8867cfbcfb1a54a8d81a484a0c036a656 
  kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt 
30f5e14246a3d63a42e63c886822011fb4496256 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaorders.desktop.in 
c622722047ce8f789f876d4808abd5ee33200bd3 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaorders.json.in PRE-CREATION 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaordersui.desktop.in 
966eb5e7c25938dbb2d12c6427a2f67ec643ff35 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepastorageplugin.desktop.in 
a118770c40bfd2040cc9bfd3f68c1538ec44fb09 
  kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.h 
fa6e54f60fffec913bf3f68256aa370b4e5a07b6 
  kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.cpp 
5bf528e9b3cbece1f37af6101f159793bc0c35a6 
  kmymoney/plugins/pluginloader.h 3f7f2ec42d0ef60a6ad2d83601a7dfdc397f4fd6 
  kmymoney/plugins/pluginloader.cpp 20c3b1120c380d3ccec91f412673f18906f5b5f0 
  kmymoney/plugins/printcheck/CMakeLists.txt 
1303f29138a4098824bd5d8209d3a4baadee25da 
  kmymoney/plugins/printcheck/kmm_printcheck.desktop 
97bec6edd7af67582340c14355421e0b121de969 
  kmymoney/plugins/printcheck/kmm_printcheck.json.in PRE-CREATION 
  kmymoney/plugins/printcheck/printcheck.h 
2f16753e35a632593cee5ffb1890b14f6d6a3ff5 
  kmymoney/plugins/printcheck/printcheck.cpp 
8fa469857db50dbb9a3c00f02df38f225ed56017 
  kmymoney/plugins/reconciliationreport/CMakeLists.txt 
19751f5bf13926f60310d1b42be123f5e4ca11ca 
  kmymoney/plugins/reconciliationreport/kmm_reconciliationreport.desktop 
ec3019df28a881dbec5cda3dd1a30df4aa3ec175 
  kmymoney/plugins/reconciliationreport/kmm_reconciliationreport.json.in 
PRE-CREATION 
  kmymoney/plugins/reconciliationreport/reconciliationreport.h 
4d33aa349431deb5b5eb8526d07bfa18a1d77e6d 
  kmymoney/plugins/reconciliationreport/reconciliationreport.cpp 
304b032d5b5ea60114447fb72ff7ac1f317b9e99 
  kmymoney/plugins/weboob/CMakeLists.txt 
b99cc0729847d8217fdec483568b42e6069b9974 
  kmymoney/plugins/weboob/dialogs/mapaccount.h 
041620d2585a5e0e289ba53d89ac7a2ab19768c6 
  kmymoney/plugins/weboob/dialogs/mapaccount.cpp 
f5e36e5a515b58d5a53cb51559569d6fba267bdd 
  kmymoney/plugins/weboob/kmm_weboob.desktop 
1b0ab9e22d7bc3397744eae3ed44fbb30943963b 
  kmymoney/plugins/weboob/kmm_weboob.json.in PRE-CREATION 
  kmymoney/plugins/weboob/plugin.h c7a8ab13c92988b5ea59e4a06035c399e1e2a76d 
  kmymoney/plugins/weboob/plugin.cpp 49dee5e1b3c6190f05ec478e2dac8bb9c3dac5ce 

Diff: https://git.reviewboard.kde.org/r/129393/diff/


Testing
---

Opened KMyMoney with aqbanking enabled and disabled. Checked if the Aqbanking 
Settings menu entry exists.


Thanks,

Christian David



Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-18 Thread Christian David


> On Nov. 17, 2016, 9:09 a.m., Thomas Baumgart wrote:
> > CMakeLists.txt, line 199
> > <https://git.reviewboard.kde.org/r/129393/diff/1/?file=485339#file485339line199>
> >
> > Where did this go? We need it for LIBOFX, don't we?

Hi Thomas,

I moved it into ```kmymoney/plugins/ofximport/CMakeLists.txt``` (I have no clue 
why it is not marked properly). My idea is to keep things which belong together 
in areas as small as possible. Hopefully that encourages people to work on 
small units and taking the fear of working through the hole code base.

Greetings and have a nice weekend!


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129393/#review100896
---


On Nov. 13, 2016, 9:50 p.m., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129393/
> ---
> 
> (Updated Nov. 13, 2016, 9:50 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Hi,
> 
> this is my long overdue change on the plugin system. It actually started in 
> Randa.
> 
> Sorry for such a long review request! I think it is ready for publishing, I 
> made this review request only to give everybody a chance to ask questions :)
> 
> 
> Commit 1
> 
> 
> This is a major change. Instead of a KPluginFactory based plugin
> loading, Qt's plugin system is used. The docu was adopeted to reflect
> this.
> 
> Commit 2
> 
> 
> The plugins for onlineTasks are now loaded with QPluginLoader on demand.
> The necessary information is encoded in Qt's json plugin header.
> 
> Commit 3
> 
> 
> Moved plugin loader out of kmm_plugin and put it into the executable
> 
> The plugin shared library is for plugins now and does not include the
> loading of plugins (which was kind of wired). All loading operations of
> standard plugins is done in KMyMoneyApp now.
> 
> Therefor the interface system for plugins needed do be reworked to
> great degree. Some overly complex operations were replaced by simpler
> ones. All plugins were adopted to that. Also it is more type safe now.
> 
> Now the user configuration which plugins should be loaded or not is
> respected (standard plugins only).
> 
> An old bug was fixed: If the configuration in the plugin settings
> changed the plugins are loaded/unloaded after the user accepts the
> dialog (perviously this was done when the checkbox was clicked).
> 
> Todos
> =
> 
> The new system is still not finished. However, it is a great step in
> the right direction. An uncomplete list of FIXMEs (or bugs?):
> 
> 1. pluginloader.{h,cpp} are gui only now and should be merged into the
> settings dialog.
> 2. The UI for plugins still has some issues, e.g. the online banking
> plugins which are loaded on demand (and are not deactivatable) have a
> checkbox for loading and unloading which has no function.
> 3. Unloading plugins may not work correctly (I think it never did).
> 4. The payeeIdentifiers are not listet in the plugin settings page.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 09970dd5626e308c443ea20ee20ecf8503b21209 
>   kmymoney/CMakeLists.txt acbe6a3c91a62a15871a0061486a7d0771b3a5e6 
>   kmymoney/dialogs/konlinetransferform.h 
> e4761904d68a92471c0b05cc9e5b2bcd1461511d 
>   kmymoney/dialogs/konlinetransferform.cpp 
> 07e73ab17f93cd8fd804b9d11ede2b049f76eefe 
>   kmymoney/dialogs/settings/ksettingsplugins.cpp 
> 007a59d4be08fe779245dd5d52f664ebfcee447d 
>   kmymoney/kmymoney.h 8d10023b5e35be8f4449973ea16e0ec0cc0acca2 
>   kmymoney/kmymoney.cpp 043342dd87cbc03557c5e2b29eb3b9dfcd1083dd 
>   kmymoney/mymoney/onlinejobadministration.h 
> e72d1a6e46c7c8bcc7cf05193e04bdc8bd9103f5 
>   kmymoney/mymoney/onlinejobadministration.cpp 
> 52658747a44bc5477ccd75a531aef471b4553b19 
>   kmymoney/pluginloader.h PRE-CREATION 
>   kmymoney/pluginloader.cpp PRE-CREATION 
>   kmymoney/plugins/CMakeLists.txt fd7cad75256c0a43d7d1fd3a23b37cef7fab8bf9 
>   kmymoney/plugins/csvexport/CMakeLists.txt 
> 9f2e29fd43e32cd3c6acc7f597c45d522eac4eaf 
>   kmymoney/plugins/csvexport/csvexport.json.in PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.h 
> f163ade2d59ae1b6eb32958a317384e77a658523 
>   kmymoney/plugins/csvexport/csvexporterplugin.cpp 
> 31027c65111edbad8ca78b00f5b7df572056bb37 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop 
>

[kmymoney4] [Bug 372453] KMyMoney 4.8 crashes on opening some files

2016-11-15 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=372453

--- Comment #5 from Christian David <christian-da...@web.de> ---
(In reply to Ralf Habacker from comment #3)
> According to https://scan.coverity.com/projects/kmymoney?tab=overview has
> kmymoney 4.8 about 80 issues related to null pointer deferences. It may help
> to fix them.

That is probably right. I made a commit for KMyMoney 5 to fix this. It should
be easy to back port the patch (unfortunately I cannot make/test it at the
moment). Then we need to evaluate if the bug was actually fixed or if this is
an upstream bug.

However, this shows again that the plugins should have their own thread. A
crash of a plugin (even if we give it invalid data) should not take down
KMyMoney.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 372453] KMyMoney 4.8 crashes on opening some files

2016-11-14 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=372453

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

 CC||christian-da...@web.de
   Priority|NOR |HI
   Severity|crash   |major

--- Comment #1 from Christian David <christian-da...@web.de> ---
Mhh, this looks like a bug for (or caused by) me :(

Can you open KMyMoney within a terminal and send me the console output?

Do you use aqBanking (HBCI/FinTS)? If not, you can disable the aqbanking plugin
in the settings. This work around could solve the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 372263] KMyMoney crashes on opening

2016-11-14 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=372263

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||christian-da...@web.de

--- Comment #2 from Christian David <christian-da...@web.de> ---
Thank you for this update!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-14 Thread Christian David


> On Nov. 14, 2016, 7:17 a.m., Marko Käning wrote:
> > Why do you migrate away from KService to something Qt'ish?

Because there is no use of KService for us. Also this is way simpler. The new 
system is recommended by the Frameworks developers (if KService is not needed).

The on demand plugins still use KService to find plugins.

Btw: This patch includes the KF5/Qt5 port of the plugin load system.


- Christian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129393/#review100826
---


On Nov. 13, 2016, 9:50 p.m., Christian David wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129393/
> ---
> 
> (Updated Nov. 13, 2016, 9:50 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Hi,
> 
> this is my long overdue change on the plugin system. It actually started in 
> Randa.
> 
> Sorry for such a long review request! I think it is ready for publishing, I 
> made this review request only to give everybody a chance to ask questions :)
> 
> 
> Commit 1
> 
> 
> This is a major change. Instead of a KPluginFactory based plugin
> loading, Qt's plugin system is used. The docu was adopeted to reflect
> this.
> 
> Commit 2
> 
> 
> The plugins for onlineTasks are now loaded with QPluginLoader on demand.
> The necessary information is encoded in Qt's json plugin header.
> 
> Commit 3
> 
> 
> Moved plugin loader out of kmm_plugin and put it into the executable
> 
> The plugin shared library is for plugins now and does not include the
> loading of plugins (which was kind of wired). All loading operations of
> standard plugins is done in KMyMoneyApp now.
> 
> Therefor the interface system for plugins needed do be reworked to
> great degree. Some overly complex operations were replaced by simpler
> ones. All plugins were adopted to that. Also it is more type safe now.
> 
> Now the user configuration which plugins should be loaded or not is
> respected (standard plugins only).
> 
> An old bug was fixed: If the configuration in the plugin settings
> changed the plugins are loaded/unloaded after the user accepts the
> dialog (perviously this was done when the checkbox was clicked).
> 
> Todos
> =
> 
> The new system is still not finished. However, it is a great step in
> the right direction. An uncomplete list of FIXMEs (or bugs?):
> 
> 1. pluginloader.{h,cpp} are gui only now and should be merged into the
> settings dialog.
> 2. The UI for plugins still has some issues, e.g. the online banking
> plugins which are loaded on demand (and are not deactivatable) have a
> checkbox for loading and unloading which has no function.
> 3. Unloading plugins may not work correctly (I think it never did).
> 4. The payeeIdentifiers are not listet in the plugin settings page.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 09970dd5626e308c443ea20ee20ecf8503b21209 
>   kmymoney/CMakeLists.txt acbe6a3c91a62a15871a0061486a7d0771b3a5e6 
>   kmymoney/dialogs/konlinetransferform.h 
> e4761904d68a92471c0b05cc9e5b2bcd1461511d 
>   kmymoney/dialogs/konlinetransferform.cpp 
> 07e73ab17f93cd8fd804b9d11ede2b049f76eefe 
>   kmymoney/dialogs/settings/ksettingsplugins.cpp 
> 007a59d4be08fe779245dd5d52f664ebfcee447d 
>   kmymoney/kmymoney.h 8d10023b5e35be8f4449973ea16e0ec0cc0acca2 
>   kmymoney/kmymoney.cpp 043342dd87cbc03557c5e2b29eb3b9dfcd1083dd 
>   kmymoney/mymoney/onlinejobadministration.h 
> e72d1a6e46c7c8bcc7cf05193e04bdc8bd9103f5 
>   kmymoney/mymoney/onlinejobadministration.cpp 
> 52658747a44bc5477ccd75a531aef471b4553b19 
>   kmymoney/pluginloader.h PRE-CREATION 
>   kmymoney/pluginloader.cpp PRE-CREATION 
>   kmymoney/plugins/CMakeLists.txt fd7cad75256c0a43d7d1fd3a23b37cef7fab8bf9 
>   kmymoney/plugins/csvexport/CMakeLists.txt 
> 9f2e29fd43e32cd3c6acc7f597c45d522eac4eaf 
>   kmymoney/plugins/csvexport/csvexport.json.in PRE-CREATION 
>   kmymoney/plugins/csvexport/csvexporterplugin.h 
> f163ade2d59ae1b6eb32958a317384e77a658523 
>   kmymoney/plugins/csvexport/csvexporterplugin.cpp 
> 31027c65111edbad8ca78b00f5b7df572056bb37 
>   kmymoney/plugins/csvexport/kmm_csvexport.desktop 
> 957a9edc4101504e0db08378392e29358327b1c6 
>   kmymoney/plugins/csvimport/CMakeLists.txt 
> c3e13285944f3624d69f7cc7cde0d4d9014a2a2c 
>   kmymoney/plugins/csvimport/csvimport.json.in PRE-CREATION 
>   kmymon

Review Request 129393: Use Qt's plugin system instead of KService

2016-11-13 Thread Christian David
 
ad53d4ba608e221a920a4899ebbfab7466c0293f 
  kmymoney/plugins/kmymoney-onlinetaskui.desktop 
23cfd182a0e12c0be9a97f0490ceedc3456f1b84 
  kmymoney/plugins/kmymoney-payeeidentifierdelegate.desktop 
cc2689f5c1f36ac4d75d1d6bd7ce0c0877b7ca18 
  kmymoney/plugins/kmymoney-plugin.desktop 
28673a8ed8ff8578f046c02b67da4e305f610ecf 
  kmymoney/plugins/kmymoneyplugin.h 12748dc80cca025212d53db13f0e7ccce71cc465 
  kmymoney/plugins/kmymoneyplugin.cpp b55b497607089c4cf036696695b79fd341ec9a3a 
  kmymoney/plugins/ofximport/CMakeLists.txt 
e97b1e87bf1b2141dca623903480691f1f5d0455 
  kmymoney/plugins/ofximport/kmm_ofximport.desktop 
393a0887abbecbf4efb931b8d0ef1da474572025 
  kmymoney/plugins/ofximport/ofximport.json.in PRE-CREATION 
  kmymoney/plugins/ofximport/ofximporterplugin.h 
667a0996654911d58a6d183ba2d0b244a9457172 
  kmymoney/plugins/ofximport/ofximporterplugin.cpp 
46842eee0870c8f2c21678dde112f497b7c8e2a0 
  kmymoney/plugins/onlinejobpluginmockup/CMakeLists.txt 
17db89d743b4f5871aa720654f9fb1af0591bde1 
  kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.desktop 
2b5d33c495b342b1cade6d4cbd2b62165c18e29d 
  kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.json.in 
PRE-CREATION 
  kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.h 
f6165d3545d45c1fae6cc72543ffa7750d2a29ee 
  kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp 
561cf4fa8d925194950e93273810f1d862acf6bf 
  kmymoney/plugins/onlinepluginextended.h 
ec84a2c8867cfbcfb1a54a8d81a484a0c036a656 
  kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt 
30f5e14246a3d63a42e63c886822011fb4496256 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaorders.desktop.in 
c622722047ce8f789f876d4808abd5ee33200bd3 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaorders.json.in PRE-CREATION 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepaordersui.desktop.in 
966eb5e7c25938dbb2d12c6427a2f67ec643ff35 
  kmymoney/plugins/onlinetasks/sepa/kmymoney-sepastorageplugin.desktop.in 
a118770c40bfd2040cc9bfd3f68c1538ec44fb09 
  kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.h 
fa6e54f60fffec913bf3f68256aa370b4e5a07b6 
  kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.cpp 
5bf528e9b3cbece1f37af6101f159793bc0c35a6 
  kmymoney/plugins/pluginloader.h 3f7f2ec42d0ef60a6ad2d83601a7dfdc397f4fd6 
  kmymoney/plugins/pluginloader.cpp 20c3b1120c380d3ccec91f412673f18906f5b5f0 
  kmymoney/plugins/printcheck/CMakeLists.txt 
1303f29138a4098824bd5d8209d3a4baadee25da 
  kmymoney/plugins/printcheck/kmm_printcheck.desktop 
97bec6edd7af67582340c14355421e0b121de969 
  kmymoney/plugins/printcheck/kmm_printcheck.json.in PRE-CREATION 
  kmymoney/plugins/printcheck/printcheck.h 
2f16753e35a632593cee5ffb1890b14f6d6a3ff5 
  kmymoney/plugins/printcheck/printcheck.cpp 
8fa469857db50dbb9a3c00f02df38f225ed56017 
  kmymoney/plugins/reconciliationreport/CMakeLists.txt 
19751f5bf13926f60310d1b42be123f5e4ca11ca 
  kmymoney/plugins/reconciliationreport/kmm_reconciliationreport.desktop 
ec3019df28a881dbec5cda3dd1a30df4aa3ec175 
  kmymoney/plugins/reconciliationreport/kmm_reconciliationreport.json.in 
PRE-CREATION 
  kmymoney/plugins/reconciliationreport/reconciliationreport.h 
4d33aa349431deb5b5eb8526d07bfa18a1d77e6d 
  kmymoney/plugins/reconciliationreport/reconciliationreport.cpp 
304b032d5b5ea60114447fb72ff7ac1f317b9e99 
  kmymoney/plugins/weboob/CMakeLists.txt 
b99cc0729847d8217fdec483568b42e6069b9974 
  kmymoney/plugins/weboob/dialogs/mapaccount.h 
041620d2585a5e0e289ba53d89ac7a2ab19768c6 
  kmymoney/plugins/weboob/dialogs/mapaccount.cpp 
f5e36e5a515b58d5a53cb51559569d6fba267bdd 
  kmymoney/plugins/weboob/kmm_weboob.desktop 
1b0ab9e22d7bc3397744eae3ed44fbb30943963b 
  kmymoney/plugins/weboob/kmm_weboob.json.in PRE-CREATION 
  kmymoney/plugins/weboob/plugin.h c7a8ab13c92988b5ea59e4a06035c399e1e2a76d 
  kmymoney/plugins/weboob/plugin.cpp 49dee5e1b3c6190f05ec478e2dac8bb9c3dac5ce 

Diff: https://git.reviewboard.kde.org/r/129393/diff/


Testing
---

Opened KMyMoney with aqbanking enabled and disabled. Checked if the Aqbanking 
Settings menu entry exists.


Thanks,

Christian David



Re: More libalkimia problems/questions was: problems compiling 4.8 on system with both qt4 and qt5

2016-11-05 Thread Christian David
Hi Ralf,

I still do not like this. The reason is that this just fixes the symptom, not 
the problem. With these changes we make a huge technical dept. Exept for 
version 4.8 we solved nearly all problems mentioned here already. So all 
changes are only a workaround to enable coinstallablity with a 5 years old 
release (which got perfectly replaced by alkimia 5).

Also adding the version of Qt – a third party library – to the library sounds 
really strange to me. I am sure this will cause more issues in future.

Regarding packaging; if there is really a fine grained configuration needed,  
there are a lot of cmake variables like

CMAKE_SHARED_LIBRARY_SUFFIX [1]
LIBRARY_OUTPUT_PATH [2]
INCLUDEDIR [3]

and probably even more ECM variables to achive this. With them not a single 
line of alkimia has to be changed. The packager can tune everything just the 
way he wants to. This way, someone who just wants to compile alkimia does not 
need to learn our naming conventions.

I really want to get away from the idea to encode any kind of version in the 
library name.

Greetings
Christian


[1] 
https://cmake.org/cmake/help/v3.1/variable/CMAKE_SHARED_LIBRARY_SUFFIX.html
[2] https://cmake.org/cmake/help/v3.1/variable/LIBRARY_OUTPUT_PATH.html
[3] https://api.kde.org/ecm/kde-module/KDEInstallDirs.html?highlight=includedir

P.S.:
The code
> if(QT4_FOUND)
>find_package(LibAalkimia4)
>if(NOT LIBALKIMIA4_FOUND)
>   find_package(LibAalkimia)
>endif()
> else()
>find_package(LibAalkimia5)
> endif()
> 
> if(QT4_FOUND)
>set(QT_SLOT 4)
> else()
>set(QT_SLOT 5)
> endif()
> 
> find_package(LibAalkimia${QT_SLOT})
> ...
> 
> |add_executable( ...) target_link_libraries(
> Alkimia::alkimia)

is way to long. find_package and the config scripts have the task to take such 
burdens of the package user. Probably the last line has to be changed from 
Alkimia::alkimia to Alkimia5::alkimia or so, too.


Am Mittwoch, 2. November 2016, 19:35:49 schrieb Ralf Habacker:
> Am 01.11.2016 um 00:05 schrieb Jack:
> > For Gentoo, if two versions are coinstallable, they get assigned to
> > different "slots" and in this case, I think the slot number would
> > easily correspond to the qt version (4 or 5) to align with other qt
> > and kde packages.  Also, as Gentoo is a source based distro, they
> > really cannot install any files with the same name, so the base
> > libalkimia.so should go to libalkimia4.so and libalkimia5.so.  (One of
> > them could stay libalkimia.so, but why not make things consistent if
> > were changing that much anyway?)
> 
> Collecting all requirements we get the following installation path layout:
> 
> Alikima 6.0.90 Qt4: [on a x86_64 system using /usr/local install prefix]
> -- Installing: /usr/local/lib64/libalkimia4.so.6.0.90
> -- Installing: /usr/local/lib64/libalkimia4.so.6
> -- Installing: /usr/local/lib64/libalkimia4.so
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia4-6.0/LibAlkimia4Targets.cmake --
> Installing:
> /usr/local/lib64/cmake/LibAlkimia4-6.0/LibAlkimia4Targets-noconfig.cmake --
> Installing: /usr/local/include/alkimia4-6.0/alkimia/alkvalue.h
> -- Installing: /usr/local/include/alkimia4-6.0/alkimia/alkquoteitem.h
> -- Installing: /usr/local/include/alkimia4-6.0/alkimia/alkcompany.h
> -- Installing: /usr/local/include/alkimia4-6.0/alkimia/alk_export.h
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia4-6.0/LibAlkimia4Config.cmake [1] --
> Installing:
> /usr/local/lib64/cmake/LibAlkimia4-6.0/LibAlkimia4ConfigVersion.cmake --
> Installing: /usr/local/lib64/cmake/LibAlkimia4-6.0/FindGMP.cmake --
> Installing: /usr/local/lib64/pkgconfig/libalkimia4.pc [2]
> 
> [1] with LIBALKIMIA4_INCLUDE_DIR=${PACKAGE_PREFIX_DIR}/include/alkimia4-6.0/
> and LIBALKIMIA4_LIBRARIES=${PACKAGE_PREFIX_DIR}/lib64/libalkimia4.so.6.0.90
> [2] with includedir=include/alkimia4-6.0 and Libs:-lalkimia4
> 
> Alkimia 6.0.90 Qt5:  [on a x86_64 system using /usr/local install prefix]
> -- Installing: /usr/local/lib64/libalkimia5.so.6.0.90
> -- Installing: /usr/local/lib64/libalkimia5.so.6
> -- Installing: /usr/local/lib64/libalkimia5.so
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia5-6.0/LibAlkimia5Targets.cmake --
> Installing:
> /usr/local/lib64/cmake/LibAlkimia5-6.0/LibAlkimia5Targets-noconfig.cmake --
> Installing: /usr/local/include/alkimia5-6.0/alkimia/alkvalue.h
> -- Installing: /usr/local/include/alkimia5-6.0/alkimia/alkquoteitem.h
> -- Installing: /usr/local/include/alkimia5-6.0/alkimia/alkcompany.h
> -- Installing: /usr/local/include/alkimia5-6.0/alkimia/alk_export.h
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia5-6.0/LibAlkimia5Config.cmake [1] --
> Installing:
> /usr/local/lib64/cmake/LibAlkimia5-6.0/LibAlkimia5ConfigVersion.cmake --
> Installing: /usr/local/lib64/cmake/LibAlkimia5-6.0/FindGMP.cmake --
> Installing: /usr/local/lib64/pkgconfig/libalkimia5.pc [2]
> 
> [1] with LIBALKIMIA5_INCLUDE_DIR=${PACKAGE_PREFIX_DIR}/include/alkimia5-6.0/
> and 

Re: More libalkimia problems/questions was: problems compiling 4.8 on system with both qt4 and qt5

2016-10-31 Thread Christian David
Hi Ralf,

Thanks for this perfect overview! I notice that Alkimia 5 should install its 
cmake files into .../cmake/LibAlkimia-5.0/..., everything else looks okay. The 
cmake files should be in seperate directories because cmake expects it that 
way.

However, we could rename the include directory into alkimia-6.0 (and -5.0). 
Then installing multiple versions is not an issue anymore. It is set by cmake 
anyway. Maybe it should be prefix/include/alkimia-6.0/alkimia/alkvalue.h. Then 
the includes could be #include  and if needed someone 
could create a symlink prefix/include/alkimia -> prefix/include/alkimia-6.0. I 
will check how the frameworks are doing this. 

The /usr/local/lib64/libalkimia.so link should not be an issue. The 
distributions usually do not install it (except in -devel packages). Also the 
find_package() call ensures that the right libalkimia.so.* is selected  (if a 
version is set). All other *.so* shared objects have unique names.

About pkgconfig: Since pkgconfig has no support for multiple versions we could 
rename these files to /usr/local/lib64/pkgconfig/libalkimia-6.0.pc (and change 
the line "Libs: -lalkimia" to contain the so-version). Or is there another 
style for pkgconfig?  Also I doubt that anybody is using it — it was used by 
the former FindAlkimia.cmake script, though. So we are probably save to drop 
it, all projects which use alkimia (KMyMoney, Kraft and Scrooge?!) should be 
cmake based.

Greetings
Christian

Am Montag, 31. Oktober 2016, 12:52:49 schrieb Ralf Habacker:
[…]
> > I would test it myself but have not enought time at the moment (and I do
> > not have any KDE 4 installed anymore, so that would take some time).
> 
> Thanks for your offer. I currently have both KDE4  available, so I can
> check it by myself
> 
> alkimia 6.0 installs
> -- Installing: /usr/local/lib64/libalkimia.so.6.0.90
> -- Installing: /usr/local/lib64/libalkimia.so.6
> -- Installing: /usr/local/lib64/libalkimia.so
> -- Installing: /usr/local/lib64/cmake/LibAlkimia-6.0/LibAlkimiaTargets.cmake
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia-6.0/LibAlkimiaTargets-noconfig.cmake
> -- Installing: /usr/local/include/alkimia/alkvalue.h
> -- Installing: /usr/local/include/alkimia/alkquoteitem.h
> -- Installing: /usr/local/include/alkimia/alkcompany.h
> -- Installing: /usr/local/include/alkimia/alk_export.h
> -- Installing: /usr/local/lib64/cmake/LibAlkimia-6.0/LibAlkimiaConfig.cmake
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia-6.0/LibAlkimiaConfigVersion.cmake
> -- Installing: /usr/local/lib64/cmake/LibAlkimia-6.0/FindGMP.cmake
> -- Installing: /usr/local/lib64/pkgconfig/libalkimia.pc
> 
> and alkimia 5.0
> -- Installing: /usr/local/lib64/libalkimia.so.5.0.0
> -- Installing: /usr/local/lib64/libalkimia.so.5
> -- Installing: /usr/local/lib64/libalkimia.so
> -- Installing: /usr/local/lib64/cmake/LibAlkimia/LibAlkimiaTargets.cmake
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia/LibAlkimiaTargets-relwithdebinfo.cmake
> -- Installing: /usr/local/include/alkimia/alkvalue.h
> -- Installing: /usr/local/include/alkimia/alkquoteitem.h
> -- Installing: /usr/local/include/alkimia/alkcompany.h
> -- Installing: /usr/local/include/alkimia/alk_export.h
> -- Installing: /usr/local/lib64/cmake/LibAlkimia/LibAlkimiaConfig.cmake
> -- Installing:
> /usr/local/lib64/cmake/LibAlkimia/LibAlkimiaConfigVersion.cmake
> -- Installing: /usr/local/lib64/pkgconfig/libalkimia.pc
> 
> I tried setting
> 
>  find_package(LibAlkimia 5.0.0 REQUIRED NO_MODULE) and got installed
> version 5.0
>  find_package(LibAlkimia 6.0.0 REQUIRED NO_MODULE) and got installed
> version 6.0
> 
> which works as long as the cmake files are installed in separate
> directories.
> 
> But looking at the file lists above there are still file name conflicts
> for include headers, pkg-config file and /usr/local/lib64/libalkimia.s*o**
> 
> Ralf
> *



Re: More libalkimia problems/questions was: problems compiling 4.8 on system with both qt4 and qt5

2016-10-30 Thread Christian David
Am Sonntag, 30. Oktober 2016, 18:49:51 schrieb Ralf Habacker:
[…]
> Your approach also includes the case of a coinstallation, say a stable
> 4.8.x version for real work and kf5 based version for development ?
[…]

Hi Ralf,

If you mean KMyMoney 4.8.x and KF5 then yes. We only need to add the required 
alkimia version to find_package() in KMyMoney.

I would test it myself but have not enought time at the moment (and I do not 
have any KDE 4 installed anymore, so that would take some time).

Greetings
Christian



[kmymoney4] [Bug 370227] Crash on exit

2016-10-30 Thread Christian David
https://bugs.kde.org/show_bug.cgi?id=370227

Christian David <christian-da...@web.de> changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|NEEDSINFO   |UNCONFIRMED

--- Comment #7 from Christian David <christian-da...@web.de> ---
Then my assumption is wrong – seems to be too simple to be true :(

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   5   >