[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #12 from Erich --- (In reply to Ralf Habacker from comment #10) > > Is there any chance that someone can apply and check attachment 122967 > [details] if it works with unpatched kdelibs ? This patch provides print > preview support and I would add it to the next release. I tested attachment 122967 on top of branch 4.8 (195f84d09 Avoid showing the print dialog twice with an unpatched kdelibs). kdelibs is version 4.14.38. Print preview works correctly for report charts. Printing from the print preview dialog works correctly. However, print preview for anything else (report tables and home screen tested) brings up the print dialog and KMyMoney goes through the print process instead. If printing to a file, the PDF is created as if "Print" were chosen instead. THEN, the print preview windows shows up, showing the last "successful" print preview. This is either blank, or if a print preview was previously generated for a report chart, that report chart is shown in the print preview dialog. My opinion as a user: Print preview is new functionality, so previously it wasn't even an option. KDE4 is extremely old at this point. If most of your users of KMyMoney 4.8 are on kdelibs >= 4.14.65 and print preview works correctly there, you should just keep your patch as is. When I asked about my original bug report on the slackbuilds mailing list, only 1 person responded, and he doesn't even use the Print to File feature. Eventually Slackware 15 will be released (nobody knows when...) and I can only assume it will have Qt5/KDE5, at which point I would move to KMyMoney 5. So I don't care if print preview is broken for everything except report charts. I wouldn't want you to waste time trying to make it work correctly just for me if it already works for all other users. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #11 from Erich --- (In reply to Ralf Habacker from comment #10) > Is there any chance that someone can apply and check attachment 122967 > [details] if it works with unpatched kdelibs ? This patch provides print > preview support and I would add it to the next release. Yes I will test it later today. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #7 from Erich --- I can confirm that the following all work: Attachment 122884 (https://bugs.kde.org/attachment.cgi?id=122884) to kdelibs adds the required functionality to kdelibs so that KMyMoney 4.8.4 print works correctly. (Of course KMyMoney must be recompiled after upgrading kdelibs so that the new behavior to print() is enabled.) OR Commit beca6d920 (https://cgit.kde.org/kmymoney.git/commit/?id=beca6d92002eabc52ebd1da52d6edf4c06c9c22c) restores print functionality on stock Slackware64 14.2. The print dialog appears twice, but this is acceptable for me. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #2 from Erich --- Hi Ralf, I will try your patch. Are there any concerns with updating KDE_VERSION_RELEASE to 65? The patch file increases it from 60 to 65, whereas Slackware has it at 38. I assume I'll be missing additional functionality that was added along the way? Where can I find these additional patches to kdelibs? I was under the impression that 4.14.38 was the last release of kdelibs. Erich -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] New: Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 Bug ID: 412366 Summary: Print to File (PDF) broken on KDE4 in 4.8.4 Product: kmymoney Version: 4.8.4 Platform: Slackware Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: reports Assignee: kmymoney-devel@kde.org Reporter: erich.public+bugs.kde@protonmail.com Target Milestone: --- Created attachment 122879 --> https://bugs.kde.org/attachment.cgi?id=122879&action=edit Restore "Print to File (PDF)" functionality for KDE4 SUMMARY Commit 15ac7d472af41fc503dc5209643cfc8b392b0089, introduced in KMyMoney 4.8.4, breaks Print to File (PDF) functionality on KDE4 in Slackware64 14.2. Reverting that commit on branch 4.8 HEAD restores Print to File (PDF) functionality. STEPS TO REPRODUCE 1. Choose Reports, 1. Income and Expenses -> Income and Expenses This Month (Default Report) 2. Then choose Print, Print to File (PDF). OBSERVED RESULT KMyMoney goes through all the motions - including asking for confirmation to overwrite an existing file - but the PDF does not get created. Versions 4.8.3 and earlier create the PDF as expected. EXPECTED RESULT PDF file gets created by KMyMoney. SOFTWARE/OS VERSIONS Linux: Slackware64 14.2 KDE Platform Version: 4.14.38 Qt Version: 4.8.7 ADDITIONAL INFORMATION I also developed a small patch which restores Print to File (PDF) functionality for me, but the print dialog appears twice (I did expect that to happen when I tried out the patch). So it is not a proper patch. What I believe is the cause of the problem: The net result of patches: 5f4f90e83565647f3579660e4c5d9ac447547a02 Fix 'Printer settings are not saved' 15ac7d472af41fc503dc5209643cfc8b392b0089 Add print support for report charts Changes the "print" command from m_part->view()->print() to q->m_part->view()->print(true); when KDE_IS_VERSION(4, 14, 65) is false (which is the case for me). >From what I can tell from reading the docs (I am not a KDE developer), this changes the "print" command from "print by asking the user how to print" to "print using the default settings". Unfortunately, those "default settings" are not what KMyMoney asked about in the code immediately preceding the "print" command, they must be the system-wide defaults. My minimally-invasive patch simply changes the print command back to what it used to be, with the net effect that the print dialog appears twice when printing a report. I did not test printing charts, which is what 15ac7d472af41fc503dc5209643cfc8b392b0089 addressed in the first place. Another Slackware user was able to reproduce the issue. See thread at: https://lists.slackbuilds.org/pipermail/slackbuilds-users/2019-September/023367.html -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 405061] No chart printing support
https://bugs.kde.org/show_bug.cgi?id=405061 Erich changed: What|Removed |Added CC||erich.public+bugs.kde.org@p ||rotonmail.com --- Comment #5 from Erich --- Commit 15ac7d472af41fc503dc5209643cfc8b392b0089 breaks "Print to PDF" for me. I noticed after upgrading to 4.8.4 that "Print to File (PDF)" no longer worked for printing report tables. Doing a git bisect, I learned that 15ac7d472 "Add print support for report charts" is what broke "Print to File (PDF)". Reverting this commit on top of branch 4.8 (HEAD was at 0ae5377fd "Fix reverse sort order handling in register" at time of testing) restored "Print to PDF" functionality for me. I am using Slackware64 14.2 (latest stable version of Slackware 64-bit, with all patches installed). KMyMoney was compiled using the build script from https://slackbuilds.org/repository/14.2/office/kmymoney/ Steps to reproduce: Choose Reports, 1. Income and Expenses -> Income and Expenses This Month (Default Report) Then choose Print, Print to File (PDF). 4.8.4 fails to create the PDF (but it does ask for confirmation when trying to overwrite an existing PDF). It gets weirder, though: on my home laptop, choosing the "Print to File (PDF)" option actually sends the job to my physical printer. This caused me to burn through a lot of paper, because the printer is in a different room, and I didn't realize it was printing... -- You are receiving this mail because: You are the assignee for the bug.
