[kmymoney4] [Bug 349139] Crash on CSVImport window close if CSVWizard window is gone
https://bugs.kde.org/show_bug.cgi?id=349139 NSLW changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/c0073108f83af30218a05a ||568c74c5efac20728e Version Fixed In||5.0 --- Comment #4 from NSLW --- Git commit c0073108f83af30218a05a568c74c5efac20728e by Łukasz Wojniłowicz. Committed on 10/09/2016 at 16:18. Pushed by wojnilowicz into branch 'master'. Handle CSV Importer exits the right way 1) restore eventFilter only this time it's working right, 2) after pressing cancel button, CSV Wizard should close without any save, 3) CSV Wizard window should be modal and closed before main window. REVIEW:128876 FIXED-IN:5.0 M +23 -9kmymoney/plugins/csvimport/csvwizard.cpp M +9-8kmymoney/plugins/csvimport/csvwizard.h M +7-1kmymoney/plugins/csvimport/csvwizard.ui http://commits.kde.org/kmymoney/c0073108f83af30218a05a568c74c5efac20728e -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 352789] Investment CSV import case sensitivity
https://bugs.kde.org/show_bug.cgi?id=352789 NSLW changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/84eaeecc2e48a9d9391d77 ||154243d6ea052a0c6f Version Fixed In||4.8.0 Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363429] KMM windows open behind CSV import wizard
https://bugs.kde.org/show_bug.cgi?id=363429 NSLW changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/d129b22e2da6e7972008f2 ||b5ef3eccc95d758201 Status|CONFIRMED |RESOLVED --- Comment #2 from NSLW --- Git commit d129b22e2da6e7972008f2b5ef3eccc95d758201 by Łukasz Wojniłowicz. Committed on 06/08/2016 at 11:14. Pushed by wojnilowicz into branch '4.8'. Remove Qt::WindowStaysOnTopHint from CSV dialog M +0-1kmymoney/plugins/csvimport/csvdialog.cpp http://commits.kde.org/kmymoney/d129b22e2da6e7972008f2b5ef3eccc95d758201 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364425] CSV import only shows checking accounts when selecting Banking
https://bugs.kde.org/show_bug.cgi?id=364425 NSLW changed: What|Removed |Added CC||m...@mober.at --- Comment #3 from NSLW --- *** Bug 365802 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 365802] Cannot import into Credit-Card Account
https://bugs.kde.org/show_bug.cgi?id=365802 NSLW changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||lukasz.wojnilow...@gmail.co ||m --- Comment #2 from NSLW --- *** This bug has been marked as a duplicate of bug 364425 *** -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/aabb1b8e917a3245a849d4 |oney/5e883c11a3ef5001c67ceb |56d8e5e0bd5b2ee09a |680701dbc4bb97ce95 --- Comment #11 from NSLW --- Git commit 5e883c11a3ef5001c67ceb680701dbc4bb97ce95 by Łukasz Wojniłowicz. Committed on 02/07/2016 at 12:52. Pushed by wojnilowicz into branch 'master'. Set type of QIF statement according to account type stored M +20 -2kmymoney/converter/mymoneyqifreader.cpp http://commits.kde.org/kmymoney/5e883c11a3ef5001c67ceb680701dbc4bb97ce95 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 NSLW changed: What|Removed |Added Version Fixed In||4.8.1 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 NSLW changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/aabb1b8e917a3245a849d4 ||56d8e5e0bd5b2ee09a Status|CONFIRMED |RESOLVED --- Comment #10 from NSLW --- Git commit aabb1b8e917a3245a849d456d8e5e0bd5b2ee09a by Łukasz Wojniłowicz. Committed on 02/07/2016 at 12:49. Pushed by wojnilowicz into branch '4.8'. Set type of QIF statement according to account type stored M +20 -2kmymoney/converter/mymoneyqifreader.cpp http://commits.kde.org/kmymoney/aabb1b8e917a3245a849d456d8e5e0bd5b2ee09a -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 --- Comment #8 from NSLW --- Thanks for the files. As I wrote before, CSV should be already fixed in upcoming KMM 4.8.1. Something is wrong with QIF importer in KMM, because file has correct type "!Type:CCard" and its account type is being incorrectly recognized. That needs to be fixed. As temporary fix you can use workaround provided by Allan Anderson https://mail.kde.org/pipermail/kmymoney-devel/2016-June/016810.html -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 NSLW changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #4 from NSLW --- Ok, I suppose you don't use master branch version (please choose your KMM version in header of this bug). How come you've got three files: QIF, OFX, CSV; do you somehow convert between them? Could you attach anonymized QIF or OFX file which shows that problem? I wonder why your "Account selection" dialog shows "Current" under "Account Type", when you try to import credit card. There was similar problem with CSV imports showing always "Checking" under "Account Type" but it was changed to "Unknown", so all account types could be showed (see bug #364425 if interested). -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364777] The importer filtering accounts enhancement forget credit cards/liabilities accounts
https://bugs.kde.org/show_bug.cgi?id=364777 NSLW changed: What|Removed |Added CC||lukasz.wojnilow...@gmail.co ||m --- Comment #1 from NSLW --- (In reply to Pierre from comment #0) > Hello, > > Import QIF or CSV does not allow to select Credit Card account (set as > Liability account) in order to import to it. This seems to be due to below > enhancement. > > Liability accounts should still be usable for imports, otherwise how we > import Credit Card transactions on a Liability account ? > > > (source: https://kmymoney.org/changelogs/ChangeLog-4.8.0.txt) > commit bfa7b5ac37d2203e4a88d9ac73b1ec43ce5211b4 > Author: Åukasz WojniÅ‚owicz > Date: Sat May 28 19:59:22 2016 +0200 > > Present only right accounts during import of statements > > During import of investment statement user is asked to select account > into which he wants to import. He should choose investment account, but > he is also presented with all other sorts of accounts. This patch makes > sure that user is presented only with the right account types. > > FEATURE: 363069 > REVIEW: 127915 > > Signed-off-by: Åukasz WojniÅ‚owicz > > Reproducible: Always > > Steps to Reproduce: > 1. Select / > 2. Then or > 3. Select file to import > 4. Next screen shows only Current accounts (no liability accounts) > > Actual Results: > Only current accounts are available. > > Expected Results: > Liability accounts should be available too. Hello, there is no problem with CSV imports of credit cards in KMM > 4.8. What do you try to import actually: CSV or QIF? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363633] Add fees calculation based on amount and fee rate
https://bugs.kde.org/show_bug.cgi?id=363633 NSLW changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/kmym ||oney/cc95c6f617ccbefde2e4b9 ||84554ee92254332555 --- Comment #2 from NSLW --- Git commit cc95c6f617ccbefde2e4b984554ee92254332555 by Łukasz Wojniłowicz. Committed on 25/06/2016 at 16:19. Pushed by wojnilowicz into branch 'master'. Add fees calculation based on amount and fee rate REVIEW: 128037 M +3-0kmymoney/plugins/csvimport/csvwizard.cpp M +2-0kmymoney/plugins/csvimport/investmentdlg.cpp M +320 -232 kmymoney/plugins/csvimport/investmentwizardpage.ui M +148 -4kmymoney/plugins/csvimport/investprocessing.cpp M +19 -0kmymoney/plugins/csvimport/investprocessing.h http://commits.kde.org/kmymoney/cc95c6f617ccbefde2e4b984554ee92254332555 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363082] Brokerage account isn't s selectable during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363082 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/daffd1caf5c52656b1fbc5 |oney/b1c0ef8a2553ab44938829 |20a497cad5dc8a6501 |dc0870ea6796e27c8f --- Comment #3 from NSLW --- Git commit b1c0ef8a2553ab44938829dc0870ea6796e27c8f by Łukasz Wojniłowicz. Committed on 24/06/2016 at 18:45. Pushed by wojnilowicz into branch 'master'. Use KAccountSelectDlg to select brokerage account If there is no "Account (Brokerage)" user should be asked to select brokerage account. REVIEW: 127920 M +14 -0kmymoney/converter/mymoneystatementreader.cpp M +8-0kmymoney/converter/mymoneystatementreader.h http://commits.kde.org/kmymoney/b1c0ef8a2553ab44938829dc0870ea6796e27c8f -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363955] CSV importer should accept datetime as date column
https://bugs.kde.org/show_bug.cgi?id=363955 NSLW changed: What|Removed |Added Version Fixed In||5.0 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 349033] option to invert transaction amounts during import
https://bugs.kde.org/show_bug.cgi?id=349033 NSLW changed: What|Removed |Added Version Fixed In||5.0 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363082] Brokerage account isn't s selectable during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363082 NSLW changed: What|Removed |Added Version Fixed In||5.0 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 349033] option to invert transaction amounts during import
https://bugs.kde.org/show_bug.cgi?id=349033 NSLW changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/kmym ||oney/94154a8211b40ecc53560c ||891cd9fd532e4fefce --- Comment #6 from NSLW --- Git commit 94154a8211b40ecc53560c891cd9fd532e4fefce by Łukasz Wojniłowicz. Committed on 24/06/2016 at 18:41. Pushed by wojnilowicz into branch 'master'. Add checkbox to change amount sings to opposite in CSV Importer REVIEW: 128154 M +124 -111 kmymoney/plugins/csvimport/bankingwizardpage.ui M +22 -0kmymoney/plugins/csvimport/csvdialog.cpp M +3-0kmymoney/plugins/csvimport/csvdialog.h M +6-0kmymoney/plugins/csvimport/csvwizard.cpp M +6-0kmymoney/plugins/csvimport/csvwizard.h http://commits.kde.org/kmymoney/94154a8211b40ecc53560c891cd9fd532e4fefce -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363955] CSV importer should accept datetime as date column
https://bugs.kde.org/show_bug.cgi?id=363955 NSLW changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym ||oney/943cd52b91f37b451736a6 ||8034d8faa6f9afaac9 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from NSLW --- Git commit 943cd52b91f37b451736a68034d8faa6f9afaac9 by Łukasz Wojniłowicz. Committed on 24/06/2016 at 18:39. Pushed by wojnilowicz into branch 'master'. Accept datetime format in CSV importer REVIEW: 128099 M +62 -21 kmymoney/plugins/csvimport/convdate.cpp http://commits.kde.org/kmymoney/943cd52b91f37b451736a68034d8faa6f9afaac9 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363082] Brokerage account isn't s selectable during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363082 NSLW changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/daffd1caf5c52656b1fbc5 ||20a497cad5dc8a6501 Status|UNCONFIRMED |RESOLVED --- Comment #2 from NSLW --- Git commit daffd1caf5c52656b1fbc520a497cad5dc8a6501 by Łukasz Wojniłowicz. Committed on 24/06/2016 at 18:43. Pushed by wojnilowicz into branch 'master'. Get rid of inputParameter for brokerage account Functionality of inputParameter is replaced with KAccountSelectDlg. REVIEW: 128101 M +0-10 kmymoney/plugins/csvimport/investprocessing.cpp M +0-9kmymoney/plugins/csvimport/redefinedlg.cpp http://commits.kde.org/kmymoney/daffd1caf5c52656b1fbc520a497cad5dc8a6501 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 364425] CSV import only shows checking accounts when selecting Banking
https://bugs.kde.org/show_bug.cgi?id=364425 NSLW changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/kmym ||oney/9c5397238947c8a010eb2e ||0939cb34d729dfb751 Resolution|--- |FIXED --- Comment #1 from NSLW --- Git commit 9c5397238947c8a010eb2e0939cb34d729dfb751 by Łukasz Wojniłowicz. Committed on 18/06/2016 at 17:16. Pushed by wojnilowicz into branch '4.8'. Set type of banking statement to unknown during CSV import Type of banking statement shouldn't be set to 'checkings' by default, bacause statement to be imported could be 'checking' but also 'credit card'. M +1-2kmymoney/plugins/csvimport/csvdialog.cpp http://commits.kde.org/kmymoney/9c5397238947c8a010eb2e0939cb34d729dfb751 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363954] CSV Importer doesn't import fees with comma as decimal separator
https://bugs.kde.org/show_bug.cgi?id=363954 NSLW changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym ||oney/5796089e8cc2b9951ce8e3 ||2cfb87f7a1dd9d9f20 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #3 from NSLW --- Git commit 5796089e8cc2b9951ce8e32cfb87f7a1dd9d9f20 by Łukasz Wojniłowicz. Committed on 18/06/2016 at 17:22. Pushed by wojnilowicz into branch '4.8'. Fix importing fees with comma as decimal separator REVIEW: 128100 M +21 -11 kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/5796089e8cc2b9951ce8e32cfb87f7a1dd9d9f20 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 349033] option to invert transaction amounts during import
https://bugs.kde.org/show_bug.cgi?id=349033 --- Comment #4 from NSLW --- (In reply to harry bennett from comment #2) > Created attachment 99382 [details] > sample csv of how data is provided by credit card company Thanks for the data. Did you already multiply amount column by -1 in that file, because it looks OK to me? Amount "-1915.16" is the only payment in that file and it's imported correctly into KMyMoney under Payment column. Is that not right for you? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 349139] Crash on CSVImport window close if CSVWizard window is gone
https://bugs.kde.org/show_bug.cgi?id=349139 NSLW changed: What|Removed |Added CC||lukasz.wojnilow...@gmail.co ||m Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #3 from NSLW --- I can reproduce this bug, so confirming. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 349033] option to invert transaction amounts during import
https://bugs.kde.org/show_bug.cgi?id=349033 NSLW changed: What|Removed |Added CC||lukasz.wojnilow...@gmail.co ||m --- Comment #1 from NSLW --- Are you sure that your bank "shows debits as credits and credits as debits" and not "shows debits and credits as credits" (i.e. all values are positive)? Could you provide sample csv file? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363955] CSV importer should accept datetime as date column
https://bugs.kde.org/show_bug.cgi?id=363955 --- Comment #2 from NSLW --- Created attachment 99370 --> https://bugs.kde.org/attachment.cgi?id=99370&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363955] CSV importer should accept datetime as date column
https://bugs.kde.org/show_bug.cgi?id=363955 --- Comment #1 from NSLW --- Created attachment 99369 --> https://bugs.kde.org/attachment.cgi?id=99369&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363954] CSV Importer doesn't import fees with comma as decimal separator
https://bugs.kde.org/show_bug.cgi?id=363954 --- Comment #2 from NSLW --- Created attachment 99368 --> https://bugs.kde.org/attachment.cgi?id=99368&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363954] CSV Importer doesn't import fees with comma as decimal separator
https://bugs.kde.org/show_bug.cgi?id=363954 --- Comment #1 from NSLW --- Created attachment 99366 --> https://bugs.kde.org/attachment.cgi?id=99366&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363955] New: CSV importer should accept datetime as date column
https://bugs.kde.org/show_bug.cgi?id=363955 Bug ID: 363955 Summary: CSV importer should accept datetime as date column Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com CSV importer should accept datetime as date column Reproducible: Always Steps to Reproduce: 1. File->Import->CSV 2. Select "Investments" and create new profile 3. Press select file and choose attached "test file.csv" 4. Set field delimiter to "comma" and text delimiter to "quotes" and press next 5. Assign columns according to attached image and press next 6. Set date format as "y m d" and press next 7. Set decimal symbol to "comma" and press "Import CSV" Actual Results: I get warning that date "2011-02-22-09.32.35" is not valid. Expected Results: CSV Importer should extract date from "2011-02-22-09.32.35". -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363954] New: CSV Importer doesn't import fees with comma as decimal separator
https://bugs.kde.org/show_bug.cgi?id=363954 Bug ID: 363954 Summary: CSV Importer doesn't import fees with comma as decimal separator Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com CSV Importer doesn't import fees with comma as decimal separator Reproducible: Always Steps to Reproduce: 1. File->Import->CSV 2. Select "Investments" and create new profile 3. Press select file and choose attached "test file.csv" 4. Set field delimiter to "comma" and text delimiter to "quotes" and press next 5. Assign columns according to attached image and press next 6. Set date format as "y m d" and press next 7. Set decimal symbol to "comma" and press "Import CSV" Actual Results: Fee 3,56 isn't imported for this transaction 2016-01-20,MONNARI,Kupno,20,12,240,MON,"3,56" Expected Results: Fee 3,56 should be imported for this transaction 2016-01-20,MONNARI,Kupno,20,12,240,MON,"3,56" -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/bfa7b5ac37d2203e4a88d9 |oney/1ab18d6b13b20af947a3c4 |ac73b1ec43ce5211b4 |3e9a67a1db1e97d430 --- Comment #8 from NSLW --- Git commit 1ab18d6b13b20af947a3c43e9a67a1db1e97d430 by Łukasz Wojniłowicz. Committed on 28/05/2016 at 18:27. Pushed by wojnilowicz into branch 'frameworks'. Present only right accounts during import of statements During import of investment statement user is asked to select account into which he wants to import. He should choose investment account, but he is also presented with all other sorts of accounts. This patch makes sure that user is presented only with the right account types. REVIEW: 127915 Signed-off-by: Łukasz Wojniłowicz M +14 -2kmymoney/converter/mymoneystatementreader.cpp M +8-0kmymoney/dialogs/kaccountselectdlg.cpp M +11 -7kmymoney/kmymoneyutils.h http://commits.kde.org/kmymoney/1ab18d6b13b20af947a3c43e9a67a1db1e97d430 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/d9a042a0322a7d76633f0c |oney/d6ac96c17fe5d4af18e34b |9bc53a367036ed684a |f63635a810cafb4ca0 |http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/d6ac96c17fe5d4af18e34b |oney/6605675815914296c5ebc9 |f63635a810cafb4ca0 |b7d8e90658de1708a2 --- Comment #18 from NSLW --- Git commit d6ac96c17fe5d4af18e34bf63635a810cafb4ca0 by Łukasz Wojniłowicz. Committed on 28/05/2016 at 18:27. Pushed by wojnilowicz into branch 'frameworks'. Allow importing negative sell transaction Buy transactions should be negative and sell transactions are generally positive but can be negative if fees are higher than proceeds. Let OFX, QIF, and CSV importer and not statement reader decide about transaction amount signs. REVIEW: 127983 Signed-off-by: Łukasz Wojniłowicz M +9-17 kmymoney/converter/mymoneystatementreader.cpp http://commits.kde.org/kmymoney/d6ac96c17fe5d4af18e34bf63635a810cafb4ca0 --- Comment #19 from NSLW --- Git commit 6605675815914296c5ebc9b7d8e90658de1708a2 by Łukasz Wojniłowicz, on behalf of Jeff Lundblad. Committed on 28/05/2016 at 18:26. Pushed by wojnilowicz into branch 'frameworks'. Set signs properly for buy/sell transactions in QIF importer Send to statement reader negative buy transactions and positive or negative sell transactions, which is dependend on fees and proceeds relationship. REVIEW: 124957 Signed-off-by: Łukasz Wojniłowicz M +4-1kmymoney/converter/mymoneyqifreader.cpp http://commits.kde.org/kmymoney/6605675815914296c5ebc9b7d8e90658de1708a2 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/d9a042a0322a7d76633f0c |oney/d6ac96c17fe5d4af18e34b |9bc53a367036ed684a |f63635a810cafb4ca0 |http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/d6ac96c17fe5d4af18e34b |oney/6605675815914296c5ebc9 |f63635a810cafb4ca0 |b7d8e90658de1708a2 --- Comment #18 from NSLW --- Git commit d6ac96c17fe5d4af18e34bf63635a810cafb4ca0 by Łukasz Wojniłowicz. Committed on 28/05/2016 at 18:27. Pushed by wojnilowicz into branch 'frameworks'. Allow importing negative sell transaction Buy transactions should be negative and sell transactions are generally positive but can be negative if fees are higher than proceeds. Let OFX, QIF, and CSV importer and not statement reader decide about transaction amount signs. REVIEW: 127983 Signed-off-by: Łukasz Wojniłowicz M +9-17 kmymoney/converter/mymoneystatementreader.cpp http://commits.kde.org/kmymoney/d6ac96c17fe5d4af18e34bf63635a810cafb4ca0 --- Comment #19 from NSLW --- Git commit 6605675815914296c5ebc9b7d8e90658de1708a2 by Łukasz Wojniłowicz, on behalf of Jeff Lundblad. Committed on 28/05/2016 at 18:26. Pushed by wojnilowicz into branch 'frameworks'. Set signs properly for buy/sell transactions in QIF importer Send to statement reader negative buy transactions and positive or negative sell transactions, which is dependend on fees and proceeds relationship. REVIEW: 124957 Signed-off-by: Łukasz Wojniłowicz M +4-1kmymoney/converter/mymoneyqifreader.cpp http://commits.kde.org/kmymoney/6605675815914296c5ebc9b7d8e90658de1708a2 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 NSLW changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/8b3eac05eaa8437215232d |oney/8b3eac05eaa8437215232d |fd4f7ddb3da5c49ad8 |fd4f7ddb3da5c49ad8 ||http://commits.kde.org/kmym ||oney/d9a042a0322a7d76633f0c ||9bc53a367036ed684a --- Comment #16 from NSLW --- Git commit 8b3eac05eaa8437215232dfd4f7ddb3da5c49ad8 by Łukasz Wojniłowicz, on behalf of Jeff Lundblad. Committed on 28/05/2016 at 17:48. Pushed by wojnilowicz into branch 'master'. Set signs properly for buy/sell transactions in QIF importer Send to statement reader negative buy transactions and positive or negative sell transactions, which is dependend on fees and proceeds relationship. REVIEW: 124957 Signed-off-by: Łukasz Wojniłowicz M +4-1kmymoney/converter/mymoneyqifreader.cpp http://commits.kde.org/kmymoney/8b3eac05eaa8437215232dfd4f7ddb3da5c49ad8 --- Comment #17 from NSLW --- Git commit d9a042a0322a7d76633f0c9bc53a367036ed684a by Łukasz Wojniłowicz. Committed on 28/05/2016 at 17:53. Pushed by wojnilowicz into branch 'master'. Allow importing negative sell transaction Buy transactions should be negative and sell transactions are generally positive but can be negative if fees are higher than proceeds. Let OFX, QIF, and CSV importer and not statement reader decide about transaction amount signs. REVIEW: 127983 Signed-off-by: Łukasz Wojniłowicz M +9-17 kmymoney/converter/mymoneystatementreader.cpp http://commits.kde.org/kmymoney/d9a042a0322a7d76633f0c9bc53a367036ed684a -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 NSLW changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/kmym ||oney/bfa7b5ac37d2203e4a88d9 ||ac73b1ec43ce5211b4 Resolution|--- |FIXED --- Comment #7 from NSLW --- Git commit bfa7b5ac37d2203e4a88d9ac73b1ec43ce5211b4 by Łukasz Wojniłowicz. Committed on 28/05/2016 at 17:59. Pushed by wojnilowicz into branch 'master'. Present only right accounts during import of statements During import of investment statement user is asked to select account into which he wants to import. He should choose investment account, but he is also presented with all other sorts of accounts. This patch makes sure that user is presented only with the right account types. REVIEW: 127915 Signed-off-by: Łukasz Wojniłowicz M +14 -2kmymoney/converter/mymoneystatementreader.cpp M +8-0kmymoney/dialogs/kaccountselectdlg.cpp M +11 -7kmymoney/kmymoneyutils.h http://commits.kde.org/kmymoney/bfa7b5ac37d2203e4a88d9ac73b1ec43ce5211b4 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363633] Add fees calculation based on amount and fee rate
https://bugs.kde.org/show_bug.cgi?id=363633 --- Comment #1 from NSLW --- Created attachment 99233 --> https://bugs.kde.org/attachment.cgi?id=99233&action=edit Graphics showing new feature implemented -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363633] New: Add fees calculation based on amount and fee rate
https://bugs.kde.org/show_bug.cgi?id=363633 Bug ID: 363633 Summary: Add fees calculation based on amount and fee rate Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com If broker doesn't list fees in investment statement at all, then user has to generate fees manually in spreadsheet. If one knows fee rate, amount and minimal fee it can be done automatically. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363429] KMM windows open behind CSV import wizard
https://bugs.kde.org/show_bug.cgi?id=363429 NSLW changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED CC||lukasz.wojnilow...@gmail.co ||m --- Comment #1 from NSLW --- I can confirm that and I'm about to do something with that in near future. Just be patient :) -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 --- Comment #14 from NSLW --- Jeff please test your patch from review #124957 together with my patch from review #127983 atop git master branch to see if you can import your QIF and OFX files properly. I hope we will be able to close this bug soon. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 --- Comment #13 from NSLW --- Thank you both for valuable comments. I posted patch for review which should allow importing negative CashDividend through CSV importer. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 --- Comment #11 from NSLW --- (In reply to allan from comment #10) > (In reply to NSLW from comment #9) > > (In reply to allan from comment #7) > > > > I think I've traced it, possibly, to the recent fee patch. > > > In investprocessing.cpp(), at circa line 1723 - > > > tr.m_amount = tr.m_amount.abs() - m_trInvestData.fee.abs(); > > > appears to drop the sign. > > > > I'm glad you did it and gave feedback. I apologize if something is broken > > for you lately with CSV imports. > > I don't have any problem, as I was using a test file, not live data. > > > I would like to help fixing that. Could you > > send your problematic, anonymized CSV test file and explain me what result > > you expect after importing? > > As I understand, you've got two CashDividends: one negative and one > > positive. Frankly I don't get it, shouldn't CashDividends be always > > positive, as it its you who gets the cash? > > The test file is one I've used for several years, and originally I obtained > it from another user. At that time, I was developing the CSV investment > handling and I found the file quite useful, as the data was not the usual > straight-forward simple investment transactions. I cannot now remember if > the CashDividend with the negative amount was an original entry, or whether > I modified it for the purpose. My "justification/rationale" for the entry > was that it was documenting a refund of an erroneous earlier transaction. I > suppose a "miscexp" would be similar (or perhaps not). The file was from a > US broker, who did produce some odd methods in his files. As it's quite > small, here it is below. > > "Trade Date","Settlement Date","Type","Description 1 ","Description > 2","Symbol/CUSIP","Quantity","Price ($)","Amount ($)" > "","2/24/2010","DividendAndInterest","Div","description","NECZX","","","504. > 72" > > "","3/28/2010","Other","Div","description",""NECZX"","","","-504.72" If it's some kind of "refund of an erroneous earlier transaction" then in my opinion it's not CashDividend. I read more on dividends on folowing websites: http://www.investopedia.com/terms/c/cashdividend.asp?o=40186&l=dir&qsrc=999&qo=investopediaSiteSearch&ap=investopedia.com http://www.investopedia.com/ask/answers/011215/how-are-dividends-usually-paid-out.asp http://www.investopedia.com/walkthrough/corporate-finance/5/dividends/cash-payment.aspx?o=40186&l=dir&qsrc=999&qo=investopediaSiteSearch&ap=investopedia.com and I cannot find any real life situation where stockholder would pay money to corporation under term dividend. Are you sure this case is real world case? BTW. Do you've got more test files for CSV imports? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 --- Comment #10 from NSLW --- (In reply to Jack from comment #5) > I import to investment accounts from OFX frequently, and it works just fine. > (Well, mostly, but my problems are mainly in what my broker provides, not > how KMM handles it, and I've complained about it in the past on the mailing > list.) I can probably provide some example files, but I'd have to choose > carefully for ones that don't show any of the problems. I wonder how you test if OFX imports are correct? Is your test based only on fact that KMM doesn't show you warning signs in ledger? My problem with CSV was that buy and sell amounts with commissions were wrong but warning sing was shown only for sell transactions. I patched CSV code in such way that no warning sign was shown, but both buy and sell amounts still were wrong. In my opinion, I tried every combination in CSV code to make amounts right but I failed, so statement reader was to blame. I'm going to code on weekend, so your OFX file would help me embrace it all at one time. (In reply to Jeff from comment #6) > There is still a problem with the QIF import with your change. My test file > also tested the case where the commission was greater than the proceeds from > the sale (which can happen when trading options.) Your fix changed a "sell" > trade that actually cost money into one that brought in money. The example > in my test file was the "sell" of the "NFLX Aug 18 2012 110.0 Call". The > price is 0.02, times 100 shares = 2.00. The commission is 10.77. So income > of 2.00, outgo of 10.77 makes the total -8.77 (as shown in the U and T > values in the QIF file). The cash account should decrease by 8.77. Your > change turned that into a positive 8.77, and increased the cash account. > This is admittedly a corner case, and I think I am the only KMM user that > trades options because I have made a bunch of other changes to the KMM code > to support that. Now I see that too and it needs to be fixed. As you've said it's corner case and I didn't take it into account. Summarizing it: It didn't work for you in general case and corner case. Now it works for you in general case but still not in corner case :) (In reply to allan from comment #7) > The OFX specification 2.0.3 includes - > "CHAPTER 13 INVESTMENTS > OFX supports download of security information and detailed investment > account statements including > transactions, open orders, balances, and positions. > " plus a lot more in detail. > Allan Thanks for the info. It looks like I was searching in the wrong area. Regards Łukasz -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 --- Comment #9 from NSLW --- (In reply to allan from comment #7) > Today, and the first for a while, I updated from HEAD and to ensure all was > OK, I did a CSV import of an investment file, which contained two similar > entries. They were both CashDividends, with the main difference being that > one had an identical but negative amount. On import, the negative sign had > been dropped. > I think I've traced it, possibly, to the recent fee patch. > In investprocessing.cpp(), at circa line 1723 - > tr.m_amount = tr.m_amount.abs() - m_trInvestData.fee.abs(); > appears to drop the sign. I'm glad you did it and gave feedback. I apologize if something is broken for you lately with CSV imports. I would like to help fixing that. Could you send your problematic, anonymized CSV test file and explain me what result you expect after importing? As I understand, you've got two CashDividends: one negative and one positive. Frankly I don't get it, shouldn't CashDividends be always positive, as it its you who gets the cash? >This comment of mine, #7, was added to this bug when I first discovered this >problem, but on >investigating, it seems that it doesn't really belong here, >but probably to BUG: 361021. I can >add this entry to that bug report, but >that might cause confusion about which bug to follow. >So, do I leave as is? I would say don't bother. For the first time I used an feature, that Thomas Baumgart explained to me, and I wasn't too careful with that, so you confused right patch with wrong bug. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 --- Comment #4 from NSLW --- Statement reader did it wrong also for CSV imports (see bug #361021) so I made corrections to the code which seemed to help also QIF reader. Honestly at that time I didn't know that investment statements are imported by anything else than CSV and thanks to your bug and code review I see bigger picture now. I proposed two next patches to statement reader which now I must review myself because I already see mixed logic between QIF and CSV imports, which somehow worked by now. It would be nice if you could send me for testing an anonymized QIF file with less frequent transaction types such as "dividends" etc. I don't know about OFX imports because valid ACCTTYPEs are only: CHECKING, SAVINGS, MONEYMRKT, and CREDITLINE, and there are no investment ACCTTYPE, so I assume OFX doesn't support that. Correct me if I'm wrong. Is this bug solved for you then? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 351874] QIF import of investment buys and sells mishandles commissions
https://bugs.kde.org/show_bug.cgi?id=351874 NSLW changed: What|Removed |Added CC||lukasz.wojnilow...@gmail.co ||m --- Comment #2 from NSLW --- Hi Jeff, could you please check with KMM from git master branch to see if the problem persists. I import your QIF file and there are no warning triangles. Commissions seems to me correct either. Earlier I've got the same problem with CSV importer but I managed to patch KMM to solve that problem and to me it seems that inadvertently it solved this bug too. Regards Łukasz -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363082] Brokerage account isn't s selectable during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363082 --- Comment #1 from NSLW --- Created attachment 98976 --> https://bugs.kde.org/attachment.cgi?id=98976&action=edit New way of selecting brokerage account -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363082] New: Brokerage account isn't s selectable during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363082 Bug ID: 363082 Summary: Brokerage account isn't s selectable during import of investment statement Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com It's not a bug, it's proposal of improvement. If during import of CSV investment statement, brokerage account isn't automatically detected user has to type it in manually. User can make a typo and if he doesn't have brokerage account yet, he has no possibility to create it at site. Reproducible: Always Steps to Reproduce: 1. File->Import->CSV... 2. choose Investing, 3. proceed with importing till question about brokerage account Actual Results: KMM asks user about brokerage account through simple input window. Expected Results: KMM should ask user about brokerage like in case of investment account i.e. through account selector because ui is more consistent with it and account selector is comfortable to handle. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 --- Comment #6 from NSLW --- (In reply to Jack from comment #5) > I can't comment on the code itself, but in the initial bug report, you talk > about csv import, but it looks to me like your proposed changes will apply > to any import. How are you checking that the import is for an investment > account? If there is actually something in the import, this is great. If > it is only because you have to specify that it is an investment import for > the csv importer, then it should be restricted to that situation. If the > proposed changes actually take care of that, you can ignore my comment. Yes, you're right. It will apply to any import because it was easy to extend this feature on all imports. Type of import is today determined right before "Account selection" so no problem to identify which kind of import we make. If you want to analyze code yourself, then look into mymoneystatementreader.cpp, function "import", place right before "selectOrCreateAccount". -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 NSLW changed: What|Removed |Added Attachment #98966|0 |1 is obsolete|| --- Comment #4 from NSLW --- Created attachment 98967 --> https://bugs.kde.org/attachment.cgi?id=98967&action=edit Account selection proposal -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 --- Comment #3 from NSLW --- Created attachment 98966 --> https://bugs.kde.org/attachment.cgi?id=98966&action=edit Account selection proposal -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 NSLW changed: What|Removed |Added Attachment #98964|0 |1 is obsolete|| --- Comment #2 from NSLW --- Created attachment 98965 --> https://bugs.kde.org/attachment.cgi?id=98965&action=edit Account selection -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 --- Comment #1 from NSLW --- Created attachment 98964 --> https://bugs.kde.org/attachment.cgi?id=98964&action=edit Account selection -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 363069] New: Wrong accounts are presented during import of investment statement
https://bugs.kde.org/show_bug.cgi?id=363069 Bug ID: 363069 Summary: Wrong accounts are presented during import of investment statement Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com It's not a bug, it's proposal of improvement. During import of CSV investment statement my investment account isn't automatically detected so I get asked about "Account selection". I should choose an investment account, but I can also choose e.g. savings account which isn't appropriate for securities to be imported. Such accounts should be filtered out and only right ones should be shown. Reproducible: Always Steps to Reproduce: 1. File->Import->CSV... 2. choose Investing, 3. proceed with importing till question about "Account Selection" Actual Results: All asset and liabilities accounts are presented. Expected Results: Only investment accounts should be presented, as it's single right choice and other choices are wrong. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 352789] Investment CSV import case sensitivity
https://bugs.kde.org/show_bug.cgi?id=352789 NSLW changed: What|Removed |Added CC||lukasz.wojnilow...@gmail.co ||m --- Comment #12 from NSLW --- Hi Marcel, It might be that there is duplicate of your but at #360435. Anyways the latter bug is fixed in master branch. If you know how to compile code yourself, then please try it, and if not then please wait for next KMM release Cheers Łukasz -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/4debce51fe4afa867db9d3 |oney/70b85864c91151bc68fe8f |3baaa1a0185b031379 |dae9c432bb93a44ba9 --- Comment #6 from NSLW --- Git commit 70b85864c91151bc68fe8fdae9c432bb93a44ba9 by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Use parseLine() to determine most likely fieldDelimiter Current routine doesn't calculate columns well when FieldDelimiter=DecimalSymbol. parseLine() from csvutil.cpp does it properly. REVIEW: 127712 M +3-3kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/70b85864c91151bc68fe8fdae9c432bb93a44ba9 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/58d9b27f84f9cdc43ea981 |oney/bcd0cd05110264d5104b20 |006ebfd04df15e934f |c53e3bcf4a6cf506be |http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/58d9b27f84f9cdc43ea981 |oney/b73a474fdd43f1eecf2dd9 |006ebfd04df15e934f |7253db883f3fc1439e --- Comment #5 from NSLW --- Git commit bcd0cd05110264d5104b20c53e3bcf4a6cf506be by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Check if CSV profile has been removed in UI before its deletion REVIEW: 127722 M +1-1kmymoney/plugins/csvimport/csvwizard.cpp http://commits.kde.org/kmymoney/bcd0cd05110264d5104b20c53e3bcf4a6cf506be --- Comment #6 from NSLW --- Git commit b73a474fdd43f1eecf2dd97253db883f3fc1439e by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Remember transaction type identified by user Transaction type identified by user isn't remembered, so in case of consecutive transaction of the same type user is asked again about identification. For KMM it is better to ask only once for unknown transaction and use that answer to identify further transactions. REVIEW: 127718 M +18 -0kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/b73a474fdd43f1eecf2dd97253db883f3fc1439e -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/58d9b27f84f9cdc43ea981 |oney/bcd0cd05110264d5104b20 |006ebfd04df15e934f |c53e3bcf4a6cf506be |http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/58d9b27f84f9cdc43ea981 |oney/b73a474fdd43f1eecf2dd9 |006ebfd04df15e934f |7253db883f3fc1439e --- Comment #5 from NSLW --- Git commit bcd0cd05110264d5104b20c53e3bcf4a6cf506be by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Check if CSV profile has been removed in UI before its deletion REVIEW: 127722 M +1-1kmymoney/plugins/csvimport/csvwizard.cpp http://commits.kde.org/kmymoney/bcd0cd05110264d5104b20c53e3bcf4a6cf506be --- Comment #6 from NSLW --- Git commit b73a474fdd43f1eecf2dd97253db883f3fc1439e by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Remember transaction type identified by user Transaction type identified by user isn't remembered, so in case of consecutive transaction of the same type user is asked again about identification. For KMM it is better to ask only once for unknown transaction and use that answer to identify further transactions. REVIEW: 127718 M +18 -0kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/b73a474fdd43f1eecf2dd97253db883f3fc1439e -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 NSLW changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/7d7e398cf180b21f3ab9e9 |oney/9b054dac7c81131a31c4af |0c5184290aced161a0 |e57b589750208ddd6f --- Comment #13 from NSLW --- Git commit 9b054dac7c81131a31c4afe57b589750208ddd6f by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:14. Pushed by wojnilowicz into branch 'frameworks'. Add fee for buy and sell operation in the right way Fee should be added to buy and substracted from sell operations. Difference between balance for banking and investment account should include fees. REVIEW: 127711 M +18 -18 kmymoney/converter/mymoneystatementreader.cpp M +6-4kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/9b054dac7c81131a31c4afe57b589750208ddd6f -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 NSLW changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/7d7e398cf180b21f3ab9e9 ||0c5184290aced161a0 --- Comment #12 from NSLW --- Git commit 7d7e398cf180b21f3ab9e90c5184290aced161a0 by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:02. Pushed by wojnilowicz into branch 'master'. Add fee for buy and sell operation in the right way Fee should be added to buy and substracted from sell operations. Difference between balance for banking and investment account should include fees. REVIEW: 127711 M +18 -18 kmymoney/converter/mymoneystatementreader.cpp M +6-4kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/7d7e398cf180b21f3ab9e90c5184290aced161a0 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 NSLW changed: What|Removed |Added Latest Commit||http://commits.kde.org/kmym ||oney/f610c254a72ca5fda20759 ||b2bd39501f75b14f54 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym |oney/f610c254a72ca5fda20759 |oney/58d9b27f84f9cdc43ea981 |b2bd39501f75b14f54 |006ebfd04df15e934f --- Comment #3 from NSLW --- Git commit f610c254a72ca5fda20759b2bd39501f75b14f54 by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:07. Pushed by wojnilowicz into branch 'master'. Remember transaction type identified by user Transaction type identified by user isn't remembered, so in case of consecutive transaction of the same type user is asked again about identification. For KMM it is better to ask only once for unknown transaction and use that answer to identify further transactions. REVIEW: 127718 M +18 -0kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/f610c254a72ca5fda20759b2bd39501f75b14f54 --- Comment #4 from NSLW --- Git commit 58d9b27f84f9cdc43ea981006ebfd04df15e934f by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:04. Pushed by wojnilowicz into branch 'master'. Check if CSV profile has been removed in UI before its deletion REVIEW: 127722 M +1-1kmymoney/plugins/csvimport/csvwizard.cpp http://commits.kde.org/kmymoney/58d9b27f84f9cdc43ea981006ebfd04df15e934f -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 NSLW changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/kmym ||oney/4debce51fe4afa867db9d3 ||3baaa1a0185b031379 Resolution|--- |FIXED --- Comment #5 from NSLW --- Git commit 4debce51fe4afa867db9d33baaa1a0185b031379 by Łukasz Wojniłowicz. Committed on 08/05/2016 at 07:11. Pushed by wojnilowicz into branch 'master'. Use parseLine() to determine most likely fieldDelimiter Current routine doesn't calculate columns well when FieldDelimiter=DecimalSymbol. parseLine() from csvutil.cpp does it properly. REVIEW: 127712 M +3-3kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/4debce51fe4afa867db9d33baaa1a0185b031379 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation in Polish
https://bugs.kde.org/show_bug.cgi?id=360129 NSLW changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||4.8.0 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/59cd58a72ed13c6d69d8a9 ||ebf8c8533e863ba55a -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004 NSLW changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Version Fixed In||4.8.0 Latest Commit||http://commits.kde.org/kmym ||oney/bff610f87df9575ded6b7c ||3a78229e6f1df2ec45 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 NSLW changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kmym ||oney/84eaeecc2e48a9d9391d77 ||154243d6ea052a0c6f Version Fixed In||4.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 --- Comment #2 from NSLW --- Actual Results: Question from attachment is asked twice if I answer "Keep". -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 --- Comment #1 from NSLW --- Created attachment 98535 --> https://bugs.kde.org/attachment.cgi?id=98535&action=edit Delete or Keep -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 362139] New: CSV Importer asks the same question twice during profile deletion
https://bugs.kde.org/show_bug.cgi?id=362139 Bug ID: 362139 Summary: CSV Importer asks the same question twice during profile deletion Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com When I want to delete importing profile, CSV Importer asks me twice whether I want to keep or delete that profile. Reproducible: Always Steps to Reproduce: 1. File->Import->CSV 2. Select Investment 3. Select existing profile 4. Click on clear text button Actual Results: Question from attachment is asked twice. Expected Results: Question from attachment should be asked once. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #18 from NSLW --- (In reply to allan from comment #17) > That sounds good to me. > Would you check on the Frameworks side please, as Christian committed only > my 'partial' patch. Yeah, I'll check on both branches: frameworks and master. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #16 from NSLW --- (In reply to allan from comment #15) > Unfortunately, I am unable to follow the detail of the latest proposed > patch, but I would like to urge some caution. It may be that the proposal > does not affect the config file - csvimporterrc, but in its current > implementation, it is possible for the user to edit the entries in the file > to suit his needs. If instead the entries are moved into the coding, then > recompilation would be required for any changes, which most users would not > wish to face. If this is not the case, then that's fine. The second version of the patch is different from the first you've committed only in asking m_map for security name using its symbol in uppercase instead of lowercase, because m_map is from now on filled by default with symbols in uppercase and m_map won't return correct name if asked in lowercase. AFAIK no part of csvimporterrc shouldn't impact the behavior changed here. In fact we make the behavior lax, so user can in any time change his symbol from uppercase to lowercase or mixed case and still get it detected as the same symbol. If that's fine I think I can apply second version of patch just like you've applied the first one. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation in Polish
https://bugs.kde.org/show_bug.cgi?id=360129 --- Comment #18 from NSLW --- Created attachment 98417 --> https://bugs.kde.org/attachment.cgi?id=98417&action=edit Fill parameters of new investment profiles with translated strings Additionally to previous patch, I recommend applying also this patch. It in some kind moves [Profiles-New Profile###] template from /usr/share/config/csvimporterrc to KMyMoney code, thus making it easy translatable. Please revise it and apply to master branch. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #12 from NSLW --- (In reply to allan from comment #11) > Are you sure about the change to csvwizard.cpp? As far as I can see, with > "exists = false;" in the while loop, it works correctly. As long as list variable is not empty. If it's empty you wont even enter while loop (thus wont even define exists variable) and it is empty if you have no securities on "securities tab". It's corner case, I'm sure of. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #11 from NSLW --- (In reply to allan from comment #10) > (In reply to NSLW from comment #9) > > (In reply to allan from comment #8) > > > (In reply to NSLW from comment #0) > > > > Buy transactions imported by CSV importer always have missing assignment > > > > > > It's not correct to say that they '...always have missing assignment' it > > > is > > > only under certain conditions. > > > > For me it always has missing assignment during import from CSV and empty > > ledger. Do you know conditions under which it doesn't happen? > > Yes. Often, the problem is that a Buy/Sell/ReinvDiv, which involve funds > transfers, does not have the name of the relevant checking/brokerage account > provided. During CSV import of these types, an extra dialog opens that asks > for the name of the checking/brokerage account that is to be used. If this > is correctly entered, then the transaction is not unbalanced. In general, I > do not have a problem, over many years, with missing assignments. I enter the name of checking/brokerage account always correctly and only once for every CSV file. I always have wrong amounts, even for transactions that show as balanced. Can you provide investment statement, you don't have problems with? > > (In reply to allan from comment #7) > > > There is also another issue, with fees sometimes getting the wrong sign, > > > which I identified in https://bugs.kde.org/show_bug.cgi?id=360129. I > > > think > > > the patch in this current bug may be related. > > > > According to my research bug #360129 can be independently fixed from this > > bug and this bug can be independently fixed from bug #360129. > > Moreover through simple sign changes in my patch I can cause both operations > > to display warning about assignment and not only for sell operations. > > How do you see them correlated? > > I don't see the two bugs as related, except that > https://bugs.kde.org/show_bug.cgi?id=361029 highlighted the fee sign issue. > I'm assuming/hoping that your patch here is for that same problem. I > haven't yet had a chance to look into it. Yes, that's the same issue but the other report supposed to concern other bug, so patch for this bug doesn't fix the other bug. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #9 from NSLW --- (In reply to allan from comment #8) > (In reply to NSLW from comment #0) > > Buy transactions imported by CSV importer always have missing assignment > > It's not correct to say that they '...always have missing assignment' it is > only under certain conditions. For me it always has missing assignment during import from CSV and empty ledger. Do you know conditions under which it doesn't happen? (In reply to allan from comment #7) > There is also another issue, with fees sometimes getting the wrong sign, > which I identified in https://bugs.kde.org/show_bug.cgi?id=360129. I think > the patch in this current bug may be related. According to my research bug #360129 can be independently fixed from this bug and this bug can be independently fixed from bug #360129. Moreover through simple sign changes in my patch I can cause both operations to display warning about assignment and not only for sell operations. How do you see them correlated? Nevertheless, Allan please analyze this and another bug with patches for them. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435
NSLW changed:
What|Removed |Added
Attachment #97972|0 |1
is obsolete||
--- Comment #10 from NSLW ---
Created attachment 98111
--> https://bugs.kde.org/attachment.cgi?id=98111&action=edit
[PATCH] Make matching securities by their symbols case insensitive v2
(In reply to allan from comment #9)
> (In reply to NSLW from comment #8)
> > That seems reasonable. Do you need me to send you another patch?
>
> No, thanks. I think we have enough.
>
> Allan
It seems that it will be necessary. During search for another bug I found out
that QMap is sadly case sensitive and occasionally my security names were
wrong. Attached patch addresses this issue, so please revise it again and apply
to master.
In patch I also modified following code from csvwizard.cpp
>
bool exists;
QString name;
QList::ConstIterator it = list.constBegin();
while (it != list.constEnd()) {
exists = false;
if (!symbl.isEmpty()) { // symbol already exists
sec = *it;
name.clear();
if (sec.tradingSymbol() == symbl) {
exists = true;
name = sec.name();
break;
}
}
++it;
}
if (!exists) {
name = securityName;
}
>
I put "exists = false;" out of while loop, otherwise condition "if (!exists)"
will newer be met and thus if security was not in "securities tab" from outset,
then it couldn't be created in "equities tab" automatically during import. Do
you want me to open another bug report for that?
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #6 from NSLW --- (In reply to Jack from comment #5) > Without looking at the details, I believe this is not a problem with the CSV > importer, but with any KMM import of an investment transaction which > requires a brokerage account for transfer of funds. (I have it with OFX > import.) The issue is that when KMM imports an investment transaction, it > does not specify the brokerage account, so the missing assignment refers to > the amount which would go to that account. When you edit the transaction, > KMM automatically enters the brokerage account, so the error disappears. It makes no sense for me that sell operations are properly assigned and buy operation not. Which error do you refer to Jack? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #4 from NSLW --- Created attachment 98106 --> https://bugs.kde.org/attachment.cgi?id=98106&action=edit [PATCH] Add fee for buy and sell operation in the right way -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #3 from NSLW --- Created attachment 98105 --> https://bugs.kde.org/attachment.cgi?id=98105&action=edit Problem description -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #2 from NSLW --- Created attachment 98104 --> https://bugs.kde.org/attachment.cgi?id=98104&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 --- Comment #1 from NSLW --- Created attachment 98103 --> https://bugs.kde.org/attachment.cgi?id=98103&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361021] New: CSV importer: The transaction has missing assignment of...
https://bugs.kde.org/show_bug.cgi?id=361021 Bug ID: 361021 Summary: CSV importer: The transaction has missing assignment of... Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com Buy transactions imported by CSV importer always have missing assignment (see attachment). Reproducible: Always Steps to Reproduce: 1. file->import csv 2. choose investment 3. create new profile 4. open "test file.csv" and assign columns to values (see attachment) 5. FieldDelimiter to comma 6. TextDelimiter to double quotes 7. DecimalSymbol to comma 8. ImportCSV Actual Results: In ledger: All buy operations have missing assignment On home page: Balance for banking and investment account are equal. Expected Results: In ledger: All operations should have assignment On home page: Balance for banking and investment account should be equal only in special cases. Correct difference in balance is shown in attachment. To get good balance without the need of patching one has to double click every operation in ledger and press enter button. Upon completion column value will have exact same values as column from patched KMM. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #8 from NSLW --- (In reply to allan from comment #7) > I did fix this a while ago, following > https://bugs.kde.org/show_bug.cgi?id=352789, but somehow things got > side-tracked, and it was not committed. > > The proposed patch looks, good, but I would make one change, in > " > securityName = m_wizDlg->m_csvDialog->ui->tableWidget->item(row, > detail)->text().toUpper().trimmed();" > > I would propose removing the '.toUpper()', allowing the user's > value/preference to be maintained. That seems reasonable. Do you need me to send you another patch? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004 --- Comment #4 from NSLW --- Created attachment 98099 --> https://bugs.kde.org/attachment.cgi?id=98099&action=edit Patch to fix this issue Please revise it and apply to master branch. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004 --- Comment #2 from NSLW --- Created attachment 98097 --> https://bugs.kde.org/attachment.cgi?id=98097&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004 --- Comment #3 from NSLW --- Created attachment 98098 --> https://bugs.kde.org/attachment.cgi?id=98098&action=edit Warning about decimal symbol -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004 --- Comment #1 from NSLW --- Created attachment 98096 --> https://bugs.kde.org/attachment.cgi?id=98096&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 361004] New: CSV Importer doesn't read DecimalSymbol stored in csvimporterrc
https://bugs.kde.org/show_bug.cgi?id=361004
Bug ID: 361004
Summary: CSV Importer doesn't read DecimalSymbol stored in
csvimporterrc
Product: kmymoney4
Version: git master
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: csvimporter
Assignee: kmymoney-devel@kde.org
Reporter: lukasz.wojnilow...@gmail.com
During creation of Investment profile I choose my DecimalSymbol to be comma.
That setting is saved in csvimporterrc as DecimalSymbol=1. If I want to reuse
my investment profile to import some more CSV files I get warning (see
attachment) about DecimalSymbol not found in my CSV file and afterwards
DecimalSymbol in csvimporterrc is overridden to 0 ie. DecimalSymbol=1 which
means dot. That's unwanted bec
Reproducible: Always
Steps to Reproduce:
1. File->Import->CSV
2. Select investment
3. Create new profile
4. Field delimiter to comma, Text delimiter to double quotes
5. Assign columns (see attachment)
6. Next on start line/end line
7. Change Decimal Symbol from dot to comma and press exit
8. For information purposes: Open ~/.kde/share/config/csvimporterrc and see
that under your newly created profile DecimalSymbol=1, which means comma
9. File->Import->CSV
10. Select investment
11. Select your newly created profile
12. Select "Skip setup" checkbox and do as you would normally import CSV file
then close importer.
Actual Results:
1) Warning about decimal symbol
2) DecimalSymbol gets changed in ~/.kde/share/config/csvimporterrc from 1
(comma) to 0 (dot) without my will
Expected Results:
1) No warning at all
2) DecimalSymbol shouldn't be changed without my will or without informing me
The problem is in readSettings() of investprocessing.cpp. There is a line
tmp = profilesGroup.readEntry("", 0);
which reads nothing at all from csvimporterrc so DecimalSymbol is always set to
0. That line should look like this
tmp = profilesGroup.readEntry("DecimalSymbol", 0);
which will read DecimalSymbol parameter and if nothing is there it will be set
to 0.
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747
--- Comment #4 from NSLW ---
Created attachment 97981
--> https://bugs.kde.org/attachment.cgi?id=97981&action=edit
[PATCH] Use parseLine() to determine most likely fieldDelimiter
The place where warning is displayed is this:
>>
if (m_columnList.count() < m_endColumn) {
if (!m_csvDialog->m_accept) {
QString row = QString::number(m_row);
int ret = KMessageBox::questionYesNoCancel(0, i18n("Row number %1
does not have the expected number of columns."
"This might not be a problem, but it may be a header
line."
"You may accept all similar items, or just this one, or
cancel.",
row), i18n("CSV import"),
KGuiItem(i18n("Accept All")),
KGuiItem(i18n("Accept This")),
KGuiItem(i18n("Cancel")));
if (ret == KMessageBox::Cancel) {
return ret;
}
if (ret == KMessageBox::Yes) {
m_csvDialog->m_accept = true;
}
}
>>
Where m_columnList:
m_columnList = m_parse->parseLine(data);
and
m_endColumn = m_maxColumnCount = colCount =
data.count(m_parse->m_fieldDelimiterCharList[count]) + 1;
Data.count doesn't handle following lines well:
2016-01-25,MONNARI,Sprzedaż,20,"12,7",254,MON,3
It return 9 columns, while in fact it should return 8 (single value in double
quotes "12,7" is treated as two columns). parseLine(data) returns correct
value, which is 8 columns. Attached patch fixes this issue. Please revise it
and apply to master
branch.
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 --- Comment #3 from NSLW --- Created attachment 97980 --> https://bugs.kde.org/attachment.cgi?id=97980&action=edit Warning about columns number -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 --- Comment #2 from NSLW --- Created attachment 97979 --> https://bugs.kde.org/attachment.cgi?id=97979&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360747] CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 --- Comment #1 from NSLW --- Created attachment 97978 --> https://bugs.kde.org/attachment.cgi?id=97978&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360747] New: CSV Importer detects more columns than are assigned
https://bugs.kde.org/show_bug.cgi?id=360747 Bug ID: 360747 Summary: CSV Importer detects more columns than are assigned Product: kmymoney4 Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com My file is correct, KMM displays correct preview of CSV file, but I get warning about incorrect column number (see attachment) Reproducible: Always Steps to Reproduce: 1. file->import csv 2. choose investment 3. create new profile 4. open "test file.csv" and assign columns to values (see attachment) 5. FieldDelimiter to comma 6. TextDelimiter to double quotes 7. DecimalSymbol to comma 8. ImportCSV Actual Results: Get warning that file doesn't have expected number of columns. Expected Results: No warning at all. FieldDelimiter=DecimalSymbol ! -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #4 from NSLW --- Created attachment 97972 --> https://bugs.kde.org/attachment.cgi?id=97972&action=edit [PATCH] Make matching securities by their symbols case insensitive Here is patch to make matching securities by trading symbol case insensitive. Please revise it and apply to master branch. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation in Polish
https://bugs.kde.org/show_bug.cgi?id=360129 NSLW changed: What|Removed |Added Attachment #97870|0 |1 is obsolete|| --- Comment #17 from NSLW --- Created attachment 97970 --> https://bugs.kde.org/attachment.cgi?id=97970&action=edit Do not fetch from csvimporterrc if it's empty Patch to fix this and similar issues. Please revise it and apply to master branch. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation in Polish
https://bugs.kde.org/show_bug.cgi?id=360129
--- Comment #16 from NSLW ---
(In reply to allan from comment #15)
> > > I know no Polish financial terms. If the Buy list contains a correct
> > > Polish
> > > term, then that I presume was added by the translator. A possible
> > > explanation is that at line 161 (in my version) of investprocessing.cpp
> > > the
> > > following appears - "m_buyList += i18nc("verb", "buy"); //
> > >
> > > some basic entries in case rc file missing". It may be that that was when
> > > the translation for Buy was added. However, the next line is similar for
> > > the Sell operation, and that was not translated apparently.
> >
> > All terms are and were translated.
>
> In the rc file snippet you attached, only Buy and Reinvdiv have content.
That's right and that also shows that KMM has bug inside.
Please see translation progress of KMM to Polish to know that it is translated
fully
http://l10n.kde.org/stats/gui/trunk-kf5/team/pl/extragear-office/
Please read also what I wrote you about the bug I'm seeing
> > After the patch my csvimporterrc is
> > filled out automatically with all the data whereas before the patch only
> > BuyParam and ReinvdivParam were filled out.
And finally please see into code of investprocessing.cpp
BuyParam and ReinvdivParam are assigned like this
QStringList list = profilesGroup.readEntry("BuyParam", QStringList());
if (!list.isEmpty()) {
m_buyList = list;
}
whereas other parameters and it includes SellParam is assigned like this
m_sellList = profilesGroup.readEntry("SellParam", QStringList());
and that's the reason why you don't see SellParam in rc file and not the
missing translation.
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation in Polish
https://bugs.kde.org/show_bug.cgi?id=360129
--- Comment #14 from NSLW ---
(In reply to allan from comment #13)
> What I'm not sure about just now is whether, once the user has chosen to
> make a substitution, that new term is added to the resource file
> automatically. It's a few ears since I wrote that code.
That's worth checking. That might be a second bug.
> I know no Polish financial terms. If the Buy list contains a correct Polish
> term, then that I presume was added by the translator. A possible
> explanation is that at line 161 (in my version) of investprocessing.cpp the
> following appears - "m_buyList += i18nc("verb", "buy"); //
> some basic entries in case rc file missing". It may be that that was when
> the translation for Buy was added. However, the next line is similar for
> the Sell operation, and that was not translated apparently.
All terms are and were translated.
> I would suggest that you include both noun and verb versions for Sell in
> your resource file.
I already have them and it works for me.
> > As it is now was also misleading to me, to today although I'm an fresh
> > KMyMoney user :) and translator, so maybe another suggestion will sound
> > better to an layman:
> > "Type of operation as in financial statement"
> >
> That does sound more understandable, although it would have to be added to
> every transaction type.
I think you're right, is there any problem for it to be added to every
transaction type?
> > > So, apart from the fee query, are you now in business?
> >
> > After manually editing csvimporterrc file, fee is imported just right for
> > all operations. What do you mean by me being in business?
>
> Apologies for that. I'm extremely impressed by the general level of
> knowledge of English shown by the users, and developers, and I forget myself
> sometimes and lapse into the vernacular. "being in business" is used to
> indicate that a problem has been solved and normal service may be resumed.
> I hope it didn't cause offence.
No, none at all. You've suggested me a workaround and it worked for me as
expected.
> So far as your suggested patch is concerned, I'm not sure of its purpose.
> The Subject is "[PATCH] Read operation's type explicitly as QStringList",
> and in it you add a number of QStringList definitions, which are already
> included in investprocessing.h, c. line 164.
I think that after my patch, every variable is defined anew locally, which I
think is not clean way to do this and doesn't remove the source of the problem,
but it works flawlessly. After the patch my csvimporterrc is filled out
automatically with all the data whereas before the patch only BuyParam and
ReinvdivParam were filled out.
I tell you what, I'm going to see into the problem once again soon and I will
try to find its source, cause I really want it to see it fixed.
> Oh, and just as a post script, I've added "in Polish" to the bug heading, as
> the import operation is otherwise as expected.
I would say "in non-English"
Łukasz
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney4] [Bug 360129] CSV Importer doesn't recognize sell operation
https://bugs.kde.org/show_bug.cgi?id=360129 --- Comment #12 from NSLW --- Created attachment 97870 --> https://bugs.kde.org/attachment.cgi?id=97870&action=edit Patch to fix this and simillar issues Please revise it and apply to master branch. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #3 from NSLW --- Created attachment 97857 --> https://bugs.kde.org/attachment.cgi?id=97857&action=edit Column Assignment for CSV file -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #2 from NSLW --- Created attachment 97856 --> https://bugs.kde.org/attachment.cgi?id=97856&action=edit CSV Test File -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 --- Comment #1 from NSLW --- Created attachment 97855 --> https://bugs.kde.org/attachment.cgi?id=97855&action=edit Recoginition of security is case sensitive -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney4] [Bug 360435] New: CSV Importer doesn't recognize security if its symbol isn't lower case
https://bugs.kde.org/show_bug.cgi?id=360435 Bug ID: 360435 Summary: CSV Importer doesn't recognize security if its symbol isn't lower case Product: kmymoney4 Version: 4.7.1 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: minor Priority: NOR Component: csvimporter Assignee: kmymoney-devel@kde.org Reporter: lukasz.wojnilow...@gmail.com See first attachment. Reproducible: Always Steps to Reproduce: 1. create your investment account 2. go to investment tab and create new investment 3. type in the security in upper case details (see first attachment) and press next 4. choose GPW as quotes source and press finish 5. import CSV (see attachment) Actual Results: Security "NET" isn't recognized (see first attachment) Expected Results: Security "NET" should be recognized If the security symbol from point 3 of steps to reproduce is typed in lower case then the security is recognized correctly (see first attachment) -- You are receiving this mail because: You are the assignee for the bug.
