Re: [Kmymoney-devel] Overly wide Details column in ledger
Hi all, On Monday 06 January 2014 10:26:04 Cristian Oneț wrote: 2013/12/26 Thomas Baumgart t...@net-bembel.de: Hi all, On Thursday 05 December 2013 08:27:36 Cristian Oneț wrote: It's definitely caused by this commit [1]. I'll check if it can be caused by whitespace as Allan suggests, then that case can be solved. But if you have a really long details string in some transaction then I guess the scrollbar is appropriate. Not sure. I do see a scrollbar here, but using it jumps by the column and not smooth (maybe just another setting for the widget that is missing). The problem Marko sees is caused by the following change at the very end of void Register::resize(int col, bool force) from: setColumnWidth(col, w); to:setColumnWidth(col, qMax(w, minimumColumnWidth(col))); While I agree with all the other changes contained in this commit, this one annoys me, as it is mostly due to wide memo fields. I do give an example that I have here (and displaying that all in one line is just nonsense): SEPA-BASISLASTSCHRIFT EREF+ B##V# 41 MREF+ - CRED+ DE36ZZZ### S VWZ+ sonstige Zahlung KNR:2 ##/faellig 13.11.20 13 Netto ##,##faellig 13.11.2013 Netto ##,## That's 205 chars. Even if using the full 1920 width I cannot display all of the above on the screen. My feeling here is that we need a more modern widget to display all of the transaction data. It should certainly be based on the MVD model which gives us more control over things than we have today. I would really like to revert that one line shown above to what it was before but want to hear some comments from others before (esp. Crisitan who made the change). Hi Thomas, Sorry for the late reply, I was away for a few weeks. The current behavior annoys me as well so please improve it (or revert it). I intended to but haven't had time to do so. By improvement I would suggest improving the value returned by minimumColumnWidth(col) for the details column or you can just revert it if you think this approach would not work in all cases. Reverted that one change back to the original. That should solve the annoyance while keeping the other improvements. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - I can break things just fine by myself, I don't need (KDE) 4.2 to help me. -- Bill Suit - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
2013/12/26 Thomas Baumgart t...@net-bembel.de: Hi all, On Thursday 05 December 2013 08:27:36 Cristian Oneț wrote: It's definitely caused by this commit [1]. I'll check if it can be caused by whitespace as Allan suggests, then that case can be solved. But if you have a really long details string in some transaction then I guess the scrollbar is appropriate. Not sure. I do see a scrollbar here, but using it jumps by the column and not smooth (maybe just another setting for the widget that is missing). The problem Marko sees is caused by the following change at the very end of void Register::resize(int col, bool force) from: setColumnWidth(col, w); to:setColumnWidth(col, qMax(w, minimumColumnWidth(col))); While I agree with all the other changes contained in this commit, this one annoys me, as it is mostly due to wide memo fields. I do give an example that I have here (and displaying that all in one line is just nonsense): SEPA-BASISLASTSCHRIFT EREF+ B##V# 41 MREF+ - CRED+ DE36ZZZ### S VWZ+ sonstige Zahlung KNR:2 ##/faellig 13.11.20 13 Netto ##,##faellig 13.11.2013 Netto ##,## That's 205 chars. Even if using the full 1920 width I cannot display all of the above on the screen. My feeling here is that we need a more modern widget to display all of the transaction data. It should certainly be based on the MVD model which gives us more control over things than we have today. I would really like to revert that one line shown above to what it was before but want to hear some comments from others before (esp. Crisitan who made the change). Hi Thomas, Sorry for the late reply, I was away for a few weeks. The current behavior annoys me as well so please improve it (or revert it). I intended to but haven't had time to do so. By improvement I would suggest improving the value returned by minimumColumnWidth(col) for the details column or you can just revert it if you think this approach would not work in all cases. Regards, Cristian -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - An optimist laughs to forget. A pessimist forgets to laugh. - ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
On 06/01/14 08:26, Cristian Oneț wrote: 2013/12/26 Thomas Baumgart t...@net-bembel.de: Hi all, On Thursday 05 December 2013 08:27:36 Cristian Oneț wrote: It's definitely caused by this commit [1]. I'll check if it can be caused by whitespace as Allan suggests, then that case can be solved. But if you have a really long details string in some transaction then I guess the scrollbar is appropriate. Not sure. I do see a scrollbar here, but using it jumps by the column and not smooth (maybe just another setting for the widget that is missing). The problem Marko sees is caused by the following change at the very end of void Register::resize(int col, bool force) from: setColumnWidth(col, w); to:setColumnWidth(col, qMax(w, minimumColumnWidth(col))); While I agree with all the other changes contained in this commit, this one annoys me, as it is mostly due to wide memo fields. I do give an example that I have here (and displaying that all in one line is just nonsense): SEPA-BASISLASTSCHRIFT EREF+ B##V# 41 MREF+ - CRED+ DE36ZZZ### S VWZ+ sonstige Zahlung KNR:2 ##/faellig 13.11.20 13 Netto ##,##faellig 13.11.2013 Netto ##,## That's 205 chars. Even if using the full 1920 width I cannot display all of the above on the screen. My feeling here is that we need a more modern widget to display all of the transaction data. It should certainly be based on the MVD model which gives us more control over things than we have today. I would really like to revert that one line shown above to what it was before but want to hear some comments from others before (esp. Crisitan who made the change). I have made a change in this area, which is in https://git.reviewboard.kde.org/r/114352/. 8th Dec. b) When a transaction is opened for editing, the above columns are widened for the buttons. However, this window widening is not helped by potentially surplus white-space appearing in the Description column. This can frequently happen if the memo text is wide and possibly originally multi-line. When not editing, the multi-lines are combined into a wider field, but the multi-lines are restored when editing but the Details column does not notice this, so retains its full width. I've remedied this by reducing the width to that of the widest sub-string. I've just made a transaction including Thomas's memo and it does not overflow when first loaded, but stays within about 1000px overall. It will need a little more work because, after being opened for editing, and then re-entered, it does expand again to full width. So, it's not perfect at the moment and will need a little more work, but it might help temporarily while a rework is in progress. Allan Hi Thomas, Sorry for the late reply, I was away for a few weeks. The current behavior annoys me as well so please improve it (or revert it). I intended to but haven't had time to do so. By improvement I would suggest improving the value returned by minimumColumnWidth(col) for the details column or you can just revert it if you think this approach would not work in all cases. Regards, Cristian -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - An optimist laughs to forget. A pessimist forgets to laugh. - ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
Hi all, first of all: Merry Christmas to all who celebrate it. On Thursday 05 December 2013 08:33:45 mk-li...@email.de wrote: Hi Allan and Cristian, turns out that that is indeed the case that here are several very long lines which increase the column width that much, ALTHOUGH there are spaces where one could insert a line break. I suggest to simply limit the maximum length to something more sensible. Just display three dots at the end of the comment and if the user wants to know details he has to go into the transaction editor to find out what’s written at the end. That way one can also handle lines which are very long and have no spaces. This annoys me as well and I will take a look into it. My Memos do contain multiple lines with data downloaded which cause the lines to be wider than the screen (the screen, not the window) can possibly show (and I do have 1920 px width). This is getting worse recently, as my bank stucks in the full IBAN and BIC information for each transaction. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - 'Never underestimate the determination of a kid who is time-rich and cash-poor.' -- Cory Doctorow: Little brother - signature.asc Description: This is a digitally signed message part. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
[Kmymoney-devel] Overly wide Details column in ledger
Hi, I am not sure when it started, but I am seeing a problem with the width of the “Details column in the ledger for one of my accounts. It takes the whole width of the application’s window. I have to scroll left and right to see the date or the amount and status. (Funnily enough it only affects one account out of several.) Shall I file a ticket for this? Greets, Marko ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
On 04/12/13 19:01, mk-li...@email.de wrote: Hi, I am not sure when it started, but I am seeing a problem with the width of the “Details column in the ledger for one of my accounts. It takes the whole width of the application’s window. I have to scroll left and right to see the date or the amount and status. (Funnily enough it only affects one account out of several.) Shall I file a ticket for this? Greets, Marko ___ Hi Marko Firstly, what is your rev? Secondly, there have been some residual problems with column widths, that Cristian and I have been working on. Cristian did a commit last night which affects this area, so it might be worth trying that first. Thirdly, there are still some minor issues which I an finishing tests for. Lets know how it goes. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
Sorry, Allan, of course I forgot something important… I am using the latest git version 921c9a70a147d55a903ed9644f14d6ddc08054ad committed today. As I said, it’s an issue I tripped over just today, but it might exist already a little longer. Definitely also f3ac957d713585fd5dce0017d764468e80a1950e shows the same behaviour. Greets, Marko ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
On 04/12/13 19:21, mk-li...@email.de wrote: Sorry, Allan, of course I forgot something important… I am using the latest git version 921c9a70a147d55a903ed9644f14d6ddc08054ad committed today. As I said, it’s an issue I tripped over just today, but it might exist already a little longer. Definitely also f3ac957d713585fd5dce0017d764468e80a1950e shows the same behaviour. Greets, Marko Well, there have been a few issues, but I haven't seen anything displaying those symptoms. As it seems to affect just one of your accounts, if you load a different account, to get a different window size with normal column widths, then close KMM, and reopen and select the problem account, does it immediately go haywire? It sounds like I'll need an anomymous file. Could you do one of those, check that you still get those symptoms with it, and send it to me, stating which file it is, and I'll see if I can see anything. I do have a newly patched version which I'm testing, although I can't think of anything that could cause or fix that at the moment. Thanks Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
On 04/12/13 19:21, mk-li...@email.de wrote: Sorry, Allan, of course I forgot something important… I am using the latest git version 921c9a70a147d55a903ed9644f14d6ddc08054ad committed today. As I said, it’s an issue I tripped over just today, but it might exist already a little longer. Definitely also f3ac957d713585fd5dce0017d764468e80a1950e shows the same behaviour. Greets, Marko Of course, it's possible to get this effect be having a stupidly long Detail content, which might not be obvious if the extra characters were spaces. But, that would be too easy, I suppose. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
It's definitely caused by this commit [1]. I'll check if it can be caused by whitespace as Allan suggests, then that case can be solved. But if you have a really long details string in some transaction then I guess the scrollbar is appropriate. Regards, Cristian [1] https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/f3ac957d713585fd5dce0017d764468e80a1950e 2013/12/5 Allan agande...@gmail.com: On 04/12/13 19:21, mk-li...@email.de wrote: Sorry, Allan, of course I forgot something important… I am using the latest git version 921c9a70a147d55a903ed9644f14d6ddc08054ad committed today. As I said, it’s an issue I tripped over just today, but it might exist already a little longer. Definitely also f3ac957d713585fd5dce0017d764468e80a1950e shows the same behaviour. Greets, Marko Of course, it's possible to get this effect be having a stupidly long Detail content, which might not be obvious if the extra characters were spaces. But, that would be too easy, I suppose. Allan ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
Re: [Kmymoney-devel] Overly wide Details column in ledger
Hi Allan and Cristian, turns out that that is indeed the case that here are several very long lines which increase the column width that much, ALTHOUGH there are spaces where one could insert a line break. I suggest to simply limit the maximum length to something more sensible. Just display three dots at the end of the comment and if the user wants to know details he has to go into the transaction editor to find out what’s written at the end. That way one can also handle lines which are very long and have no spaces. Greets, Marko ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
