[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #17 from Ralf Habacker --- (In reply to Wolfgang Bauer from comment #16) > But kmymoney 5.x doesn't use KHTML anymore. It can either be built with > QtWebKit or QtWebEngine. I can confirm that. Unfortunately with the transition to QtWebKit/QWebEngine the printout of headers and footers gets lost, see bug 413352. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #16 from Wolfgang Bauer --- (In reply to Ralf Habacker from comment #15) > (In reply to Ralf Habacker from comment #13) > > > Qt5/KDE5, at which point I would move to KMyMoney 5. > > KHtmlView/KF5 provides the QPainter parameter. This means that there will be > > no issue, if print preview would be added to KF5 port. > > I need to correct this statement: KHTMLView/KF5 also do not has a print > method with QPrinter parameter (see > https://cgit.kde.org/khtml.git/tree/src/khtmlview.h#n200). I filed a bug > report for this (see https://bugs.kde.org/show_bug.cgi?id=405011) But kmymoney 5.x doesn't use KHTML anymore. It can either be built with QtWebKit or QtWebEngine. Or am I misunderstanding something here? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #15 from Ralf Habacker --- (In reply to Ralf Habacker from comment #13) > > Qt5/KDE5, at which point I would move to KMyMoney 5. > KHtmlView/KF5 provides the QPainter parameter. This means that there will be > no issue, if print preview would be added to KF5 port. I need to correct this statement: KHTMLView/KF5 also do not has a print method with QPrinter parameter (see https://cgit.kde.org/khtml.git/tree/src/khtmlview.h#n200). I filed a bug report for this (see https://bugs.kde.org/show_bug.cgi?id=405011) -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #14 from Ralf Habacker --- Git commit 04af112832af9307c6a2c82bb83e8bf993a19433 by Ralf Habacker. Committed on 11/10/2019 at 10:38. Pushed by habacker into branch '4.8'. Disable the print preview with an unpatched kdelibs to avoid problems with the print settings See https://bugs.kde.org/show_bug.cgi?id=412366#c12 for details Related: bug 406338 M +4-0kmymoney/kmymoney.cpp https://commits.kde.org/kmymoney/04af112832af9307c6a2c82bb83e8bf993a19433 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #13 from Ralf Habacker --- (In reply to Erich from comment #12) Thanks for reporting. > However, Then it looks that disabling print preview for unpatched kdelibs is the secure way. > Qt5/KDE5, at which point I would move to KMyMoney 5. KHtmlView/KF5 provides the QPainter parameter. This means that there will be no issue, if print preview would be added to KF5 port. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #12 from Erich --- (In reply to Ralf Habacker from comment #10) > > Is there any chance that someone can apply and check attachment 122967 > [details] if it works with unpatched kdelibs ? This patch provides print > preview support and I would add it to the next release. I tested attachment 122967 on top of branch 4.8 (195f84d09 Avoid showing the print dialog twice with an unpatched kdelibs). kdelibs is version 4.14.38. Print preview works correctly for report charts. Printing from the print preview dialog works correctly. However, print preview for anything else (report tables and home screen tested) brings up the print dialog and KMyMoney goes through the print process instead. If printing to a file, the PDF is created as if "Print" were chosen instead. THEN, the print preview windows shows up, showing the last "successful" print preview. This is either blank, or if a print preview was previously generated for a report chart, that report chart is shown in the print preview dialog. My opinion as a user: Print preview is new functionality, so previously it wasn't even an option. KDE4 is extremely old at this point. If most of your users of KMyMoney 4.8 are on kdelibs >= 4.14.65 and print preview works correctly there, you should just keep your patch as is. When I asked about my original bug report on the slackbuilds mailing list, only 1 person responded, and he doesn't even use the Print to File feature. Eventually Slackware 15 will be released (nobody knows when...) and I can only assume it will have Qt5/KDE5, at which point I would move to KMyMoney 5. So I don't care if print preview is broken for everything except report charts. I wouldn't want you to waste time trying to make it work correctly just for me if it already works for all other users. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #11 from Erich --- (In reply to Ralf Habacker from comment #10) > Is there any chance that someone can apply and check attachment 122967 > [details] if it works with unpatched kdelibs ? This patch provides print > preview support and I would add it to the next release. Yes I will test it later today. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #10 from Ralf Habacker --- (In reply to Wolfgang Bauer from comment #8) Thanks for providing this patch Is there any chance that someone can apply and check attachment 122967 if it works with unpatched kdelibs ? This patch provides print preview support and I would add it to the next release. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #9 from Ralf Habacker --- Git commit 195f84d09633ecd8939468ce455c793048ca4ab5 by Ralf Habacker, on behalf of Wolfgang Bauer. Committed on 01/10/2019 at 17:11. Pushed by habacker into branch '4.8'. Avoid showing the print dialog twice with an unpatched kdelibs M +2-0kmymoney/views/kreportsview.cpp https://commits.kde.org/kmymoney/195f84d09633ecd8939468ce455c793048ca4ab5 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366
Wolfgang Bauer changed:
What|Removed |Added
CC||wba...@tmo.at
--- Comment #8 from Wolfgang Bauer ---
This additional patch would avoid showing the print dialog twice with an
unpatched kdelibs:
diff --git a/kmymoney/views/kreportsview.cpp b/kmymoney/views/kreportsview.cpp
index 5adcdb2..4afc024 100644
--- a/kmymoney/views/kreportsview.cpp
+++ b/kmymoney/views/kreportsview.cpp
@@ -152,9 +152,11 @@
void KReportsView::KReportTab::print()
{
+#if KDE_IS_VERSION(4, 14, 65)
QPrintDialog dlg(kmymoney->printer(), this);
if (!dlg.exec())
return;
+#endif
d->slotPaintRequested(kmymoney->printer());
}
--
You are receiving this mail because:
You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #7 from Erich --- I can confirm that the following all work: Attachment 122884 (https://bugs.kde.org/attachment.cgi?id=122884) to kdelibs adds the required functionality to kdelibs so that KMyMoney 4.8.4 print works correctly. (Of course KMyMoney must be recompiled after upgrading kdelibs so that the new behavior to print() is enabled.) OR Commit beca6d920 (https://cgit.kde.org/kmymoney.git/commit/?id=beca6d92002eabc52ebd1da52d6edf4c06c9c22c) restores print functionality on stock Slackware64 14.2. The print dialog appears twice, but this is acceptable for me. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 Ralf Habacker changed: What|Removed |Added Flags||Version_5- -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 Ralf Habacker changed: What|Removed |Added Latest Commit||https://commits.kde.org/kmy ||money/beca6d92002eabc52ebd1 ||da52d6edf4c06c9c22c Status|REPORTED|RESOLVED Version Fixed In||4.8.5 Resolution|--- |FIXED --- Comment #6 from Ralf Habacker --- Git commit beca6d92002eabc52ebd1da52d6edf4c06c9c22c by Ralf Habacker. Committed on 26/09/2019 at 18:52. Pushed by habacker into branch '4.8'. Fix 'Print to File (PDF) broken on KDE4 in 4.8.4 on Slackware' Using the KHtmlView quick print support does not work if a user does not select the default system printer in kmymoney. FIXED-IN:4.8.5 M +1-1kmymoney/views/kreportsview.cpp https://commits.kde.org/kmymoney/beca6d92002eabc52ebd1da52d6edf4c06c9c22c -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #5 from Ralf Habacker --- (In reply to Ralf Habacker from comment #4) > At > https://build.opensuse.org/package/show/windows:mingw:win32/mingw32-kdelibs4 > there is a tarball for 4.14.60 and several patches I collected in the past. Most patches are intended for cross compiling windows packages. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #4 from Ralf Habacker --- (In reply to Erich from comment #2) > Hi Ralf, > > I will try your patch. > > Are there any concerns with updating KDE_VERSION_RELEASE to 65? The patch > file increases it from 60 to 65, whereas Slackware has it at 38. I assume > I'll be missing additional functionality that was added along the way? Mostly fixes > Where can I find these additional patches to kdelibs? At https://build.opensuse.org/package/show/windows:mingw:win32/mingw32-kdelibs4 there is a tarball for 4.14.60 and several patches I collected in the past. To be find kdelibs4 with method print(QPrinter* printer, bool quick) I raised the kdelibs patch level to 65. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 --- Comment #2 from Erich --- Hi Ralf, I will try your patch. Are there any concerns with updating KDE_VERSION_RELEASE to 65? The patch file increases it from 60 to 65, whereas Slackware has it at 38. I assume I'll be missing additional functionality that was added along the way? Where can I find these additional patches to kdelibs? I was under the impression that 4.14.38 was the last release of kdelibs. Erich -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 412366] Print to File (PDF) broken on KDE4 in 4.8.4
https://bugs.kde.org/show_bug.cgi?id=412366 Ralf Habacker changed: What|Removed |Added CC||ralf.habac...@freenet.de --- Comment #1 from Ralf Habacker --- Created attachment 122884 --> https://bugs.kde.org/attachment.cgi?id=122884=edit Patch for kdelibs to support requested print operation On Windows builds the appended patch add related support to kdelibs. This need to be applied to Slackware's kdelibs4 package. -- You are receiving this mail because: You are the assignee for the bug.
