[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-06-02 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

Ralf Habacker  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/offi
   ||ce/kmymoney/commit/5b5aa00c
   ||db4e4376056b2dddf7c4db932b0
   ||e091d
 Resolution|--- |FIXED
   Version Fixed In||5.1.3

--- Comment #9 from Ralf Habacker  ---
Git commit 5b5aa00cdb4e4376056b2dddf7c4db932b0e091d by Ralf Habacker, on behalf
of Thomas Baumgart.
Committed on 02/06/2022 at 15:04.
Pushed by habacker into branch '5.1'.

Include user supplied paypal note in memo field
FIXED-IN:5.1.3
(cherry picked from commit 74ba29e8c0a31a29bb48236f3b01b38968c58485)

M  +15   -3kmymoney/plugins/kbanking/kbanking.cpp

https://invent.kde.org/office/kmymoney/commit/5b5aa00cdb4e4376056b2dddf7c4db932b0e091d

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-13 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #8 from Ralf Habacker  ---
In an ideal world, kmymoney could, at the next launch after an update that
brings this feature, tell the user that there is now the possibility to apply
memos to Paypal accounts and ask the user if this should be done once for all
existing transactions. This would require skipping the transactions where the
memo text is already included.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-12 Thread Thomas Baumgart via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #7 from Thomas Baumgart  ---
Git commit 74ba29e8c0a31a29bb48236f3b01b38968c58485 by Thomas Baumgart.
Committed on 11/01/2022 at 17:14.
Pushed by tbaumgart into branch 'master'.

Include user supplied paypal note in memo field

M  +15   -3kmymoney/plugins/kbanking/kbanking.cpp

https://invent.kde.org/office/kmymoney/commit/74ba29e8c0a31a29bb48236f3b01b38968c58485

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-12 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #6 from Ralf Habacker  ---
> If an operation is a duplicate, it has already been imported once. How can it 
> change if it is imported a second time? 

Before aqbanking 6.3.1, (paypal) transactions were imported without memo,
although there might be a memo, i.e. Aqbanking now provides more data than
before.

Since the duplicate check does not include the memo field, this change is not
detected and therefore this commit checks for the detected duplicates if the
memo field of the present transaction is empty and imports the memo field only
in this case. This is effectively a one-time attribute update of the memo
field.

> If this is only for paypal transactions imported with a previous version of 
> AqBanking, I vote against it because it could affect other importers as well.

This functionality can in principle be extended to all aqbanking sources, but
requires that the aqbanking backend in question populates the memo field. If
the memo field is not filled by aqbanking, nothing happens.

> If you want to do this, remove the transaction in the general ledger and 
> import it again.

That's what I did at first, but found out that if you have a large number of
transactions, this is very time consuming as you have to manually find and
delete all the transactions that don't have a memo in order to re-import those.

To give the user control over this process, an option could be added in the
online settings of an account to explicitly enable this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-11 Thread Thomas Baumgart via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #5 from Thomas Baumgart  ---
I don't understand the patch "to update memos on present transactions". If a
transaction is a duplicate, it is already imported once. How could it change
when imported a second time? That can't be. If this is meant only for paypal
transactions imported with a prior version of AqBanking, I vote against it,
because it might also affect other importers. If you want that, remove the
transaction in the ledger and re-import.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-10 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #4 from Ralf Habacker  ---
Created attachment 145298
  --> https://bugs.kde.org/attachment.cgi?id=145298&action=edit
Patch from 4.8 branch to update memos on present transactions

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-10 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #3 from Ralf Habacker  ---
Created attachment 145297
  --> https://bugs.kde.org/attachment.cgi?id=145297&action=edit
Patch from 4.8 branch  to fetch transaction note from a paypal account

P

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2022-01-10 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #2 from Ralf Habacker  ---
aqbanking 6.3.1 got support to fetch transactions notes from a paypal account.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 444414] Transaction notes are not imported from paypal account

2021-10-26 Thread Ralf Habacker via KMyMoney-devel
https://bugs.kde.org/show_bug.cgi?id=14

--- Comment #1 from Ralf Habacker  ---
Current versions of aqbanking do not provide the required attribute, therefore
bugreport https://www.aquamaniac.de/rdm/issues/246 was submitted.

-- 
You are receiving this mail because:
You are the assignee for the bug.