[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #11 from Ralf Habacker --- Git commit eec2645f3a5623a32390d209169c780a8c5c653e by Ralf Habacker. Committed on 30/10/2024 at 14:14. Pushed by habacker into branch 'master'. Fix conversion to base currency for reports containing categories The previously used logic to recognize the conversion to the base currency was not correct for the report mentioned in this error. It was added to fix bug 448788 and worked there because the base currency was taken from the first split, which happened to be the same as the one from the file. In general, when converting to the base currency, the base currency of the file should be used and not the currency from the first split, which has been corrected with this commit. Related: bug 382245 FIXED-IN:5.2.0 M +2-2kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/eec2645f3a5623a32390d209169c780a8c5c653e -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #12 from Ralf Habacker --- Git commit 95e46fc151cfdabc5493983800facb32475d41a2 by Ralf Habacker. Committed on 30/10/2024 at 14:15. Pushed by habacker into branch 'master'. Correction of the expected test report values for “test-448788.xml” After the problem reported in bug 382245 was fixed, the expected values in the report “Bookings by category without conversion” from the mentioned test have changed and need to be adjusted. M +5-5 kmymoney/plugins/views/reports/core/tests/data/test-448788-report-querytable-Buchungen-nach-Kategorie-_ohne-Umrechnung_.csv https://invent.kde.org/office/kmymoney/-/commit/95e46fc151cfdabc5493983800facb32475d41a2 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Ralf Habacker changed: What|Removed |Added Version Fixed In||5.2 Resolution|--- |FIXED Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/offi ||ce/kmymoney/-/commit/26c6a5 ||c827be45c2021f4d53af03c4a7f ||142ecb9 --- Comment #10 from Ralf Habacker --- Git commit 26c6a5c827be45c2021f4d53af03c4a7f142ecb9 by Ralf Habacker. Committed on 15/09/2024 at 06:33. Pushed by habacker into branch 'master'. Fix not showing correct currency in multi currency category report The basic fix has been extracted from the 4.8 branch. FIXED-IN:5.2 M +15 -8kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/26c6a5c827be45c2021f4d53af03c4a7f142ecb9 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Ralf Habacker changed: What|Removed |Added Blocks||382245 Depends on|382245 | Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=382245 [Bug 382245] Reports not showing correct totals for split transactions -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #9 from Ralf Habacker --- Git commit bf6ec53563beff53c52c0d0eabc82e664be0bad9 by Ralf Habacker. Committed on 15/09/2024 at 06:24. Pushed by habacker into branch 'master'. Add reference file with expected behavior without currency conversion A +9-0 kmymoney/plugins/views/reports/core/tests/data/test-448788-report-querytable-Buchungen-nach-Kategorie-_ohne-Umrechnung_.csv https://invent.kde.org/office/kmymoney/-/commit/bf6ec53563beff53c52c0d0eabc82e664be0bad9 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #8 from Ralf Habacker --- Git commit b71085f8ad71eb614b69483190056b53d7264081 by Ralf Habacker. Committed on 15/09/2024 at 06:24. Pushed by habacker into branch 'master'. Add test case for working reports Currently the report with currency conversion has been added for testing as it looks as expected. M +1-0kmymoney/plugins/views/reports/core/tests/data/CMakeLists.txt A +9-0 kmymoney/plugins/views/reports/core/tests/data/test-448788-report-querytable-Buchungen-nach-Kategorie-_mit-Umrechnung_.csv A +200 -0kmymoney/plugins/views/reports/core/tests/data/test-448788.xml https://invent.kde.org/office/kmymoney/-/commit/b71085f8ad71eb614b69483190056b53d7264081 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Ralf Habacker changed: What|Removed |Added Blocks||488491 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=488491 [Bug 488491] Make 5.2 release -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/231 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/230 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Ralf Habacker changed: What|Removed |Added Depends on||382245 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=382245 [Bug 382245] Reports not showing correct totals for split transactions -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Bug 448788 depends on bug 382245, which changed state. Bug 382245 Summary: Reports not showing correct totals for split transactions https://bugs.kde.org/show_bug.cgi?id=382245 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #5 from Ralf Habacker --- Commit https://invent.kde.org/office/kmymoney/commit/467f0cc2d07104d4770868c8b8b3b6d16345700d has been added to fix the error 382245 is responsible for this problem. A revert shows the amount in the currency of the account in question. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #4 from Ralf Habacker --- (In reply to Ralf Habacker from comment #3) > (In reply to Ralf Habacker from comment #2) > > while in the report "Buchungen nach Kategorie (ohne Umrechnung)" there is > > > > dividend 29.08.2024 [Leerer Zahlungsempfänger] [Kein Stichwort] > > checking (BTC) EUR 0,57 > > > > Shouldn't “BTC 0,1000” be displayed there ? > > .. which is displayed with kmymoney version 4.8 Also the tooltip in the checkbox for "Convert values to base currency" (https://invent.kde.org/office/kmymoney/-/blob/master/kmymoney/plugins/views/reports/reporttabgeneral.ui#L68) shows > Select this option to convert all values in the report to your base currency. > Leave it unchecked if you would like to see values in their original > currency. > If currencies are not converted, then subtotals will not be shown. -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 --- Comment #3 from Ralf Habacker --- (In reply to Ralf Habacker from comment #2) > while in the report "Buchungen nach Kategorie (ohne Umrechnung)" there is > > dividend 29.08.2024 [Leerer Zahlungsempfänger] [Kein Stichwort] checking > (BTC) EUR 0,57 > > Shouldn't “BTC 0,1000” be displayed there ? .. which is displayed with kmymoney version 4.8 -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Ralf Habacker changed: What|Removed |Added CC||ralf.habac...@freenet.de --- Comment #2 from Ralf Habacker --- Created attachment 173063 --> https://bugs.kde.org/attachment.cgi?id=173063&action=edit test case I checked this with a build from the master branch with the appended test case and think that there is an issue. In the report "Buchungen nach Kategorie (mit Umrechnung)" there is dividend 29.08.2024 [Leerer Zahlungsempfänger] [Kein Stichwort] checking (BTC) 0,57 while in the report "Buchungen nach Kategorie (ohne Umrechnung)" there is dividend 29.08.2024 [Leerer Zahlungsempfänger] [Kein Stichwort] checking (BTC) EUR 0,57 Shouldn't “BTC 0,1000” be displayed there ? -- You are receiving this mail because: You are the assignee for the bug.
[kmymoney] [Bug 448788] Incorrect Currency Conversion in Reports
https://bugs.kde.org/show_bug.cgi?id=448788 Thomas Baumgart changed: What|Removed |Added CC||pet...@fotodomain.com --- Comment #1 from Thomas Baumgart --- *** Bug 451269 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
