Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/ --- (Updated Sept. 16, 2016, 6:38 p.m.) Status -- This change has been marked as submitted. Review request for KMymoney. Changes --- Submitted with commit d0ab700f4dc14f0d990e30bfc5e4246bd4fc3a0b by ?ukasz Wojni?owicz to branch master. Repository: kmymoney Description --- 1) It's now possible to save qif file with investments, 2) If account is available, then it will be added to qif file, 3) If type of import is available, then it will be added to qif file, 4) Handled canceling of QFileDialog, 5) QFileDialog saves only .qif files now, 6) Date format is hardcoded to MM/dd/, because it is so in files, that I saw. Diffs - kmymoney/plugins/csvimport/csvdialog.h 3cedd92 kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 kmymoney/plugins/csvimport/csvwizard.h 48c15ea kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 Diff: https://git.reviewboard.kde.org/r/128878/diff/ Testing --- Thanks, Łukasz Wojniłowicz
Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this on the lists several times without receiving any > > protests. It's possible, I suppose, that on implementation, a non-lister > > might discover that a much needed feature had been removed. I would still > > have gone ahead, but the change would have had to be reverted in that > > circumstance. > > Perhaps you see a need? > > Łukasz Wojniłowicz wrote: > I didn't know that you wanted to remove QIF facility. I don't use it > personally. Initially I wanted to move it as separate CSV->QIF converter but > it would involve the same steps you do during CSV import, so I left it where > it is. > I think defeaturing CSV importer of QIF converter would be loss of work. > > Allan Anderson wrote: > It's certainly not causing any harm, that I'm aware of. It was purely to > remove clutter. No hard views, either way, though. > > Łukasz Wojniłowicz wrote: > We can hide it deep with an option through recent configuration dialog to > remove clutter, if all you devs think it would be a good idea :) > > Allan, do you use CSV Importer from master branch? Lots of code have been > changed recently and I'm little bit concerned about usablity in all cases. I'm afraid I have not had a lot of time lately, what with my hospital appointments, dental troubles and now my wife was admitted to hospital 10 days ago. Also, I've been waiting on my distro, and as it happens only two days ago it released a new version. As soon as I can find time, I'll try to upgrade, etc. - Allan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/#review99081 --- On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128878/ > --- > > (Updated Sept. 10, 2016, 4:35 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > 1) It's now possible to save qif file with investments, > 2) If account is available, then it will be added to qif file, > 3) If type of import is available, then it will be added to qif file, > 4) Handled canceling of QFileDialog, > 5) QFileDialog saves only .qif files now, > 6) Date format is hardcoded to MM/dd/, because it is so in files, that I > saw. > > > Diffs > - > > kmymoney/plugins/csvimport/csvdialog.h 3cedd92 > kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 > kmymoney/plugins/csvimport/csvwizard.h 48c15ea > kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd > kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 > kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 > > Diff: https://git.reviewboard.kde.org/r/128878/diff/ > > > Testing > --- > > > Thanks, > > Łukasz Wojniłowicz > >
Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
> On Wrz 11, 2016, 12:09 po południu, Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this on the lists several times without receiving any > > protests. It's possible, I suppose, that on implementation, a non-lister > > might discover that a much needed feature had been removed. I would still > > have gone ahead, but the change would have had to be reverted in that > > circumstance. > > Perhaps you see a need? > > Łukasz Wojniłowicz wrote: > I didn't know that you wanted to remove QIF facility. I don't use it > personally. Initially I wanted to move it as separate CSV->QIF converter but > it would involve the same steps you do during CSV import, so I left it where > it is. > I think defeaturing CSV importer of QIF converter would be loss of work. > > Allan Anderson wrote: > It's certainly not causing any harm, that I'm aware of. It was purely to > remove clutter. No hard views, either way, though. We can hide it deep with an option through recent configuration dialog to remove clutter, if all you devs think it would be a good idea :) Allan, do you use CSV Importer from master branch? Lots of code have been changed recently and I'm little bit concerned about usablity in all cases. - Łukasz --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/#review99081 --- On Wrz 10, 2016, 6:35 po południu, Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128878/ > --- > > (Updated Wrz 10, 2016, 6:35 po południu) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > 1) It's now possible to save qif file with investments, > 2) If account is available, then it will be added to qif file, > 3) If type of import is available, then it will be added to qif file, > 4) Handled canceling of QFileDialog, > 5) QFileDialog saves only .qif files now, > 6) Date format is hardcoded to MM/dd/, because it is so in files, that I > saw. > > > Diffs > - > > kmymoney/plugins/csvimport/csvdialog.h 3cedd92 > kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 > kmymoney/plugins/csvimport/csvwizard.h 48c15ea > kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd > kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 > kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 > > Diff: https://git.reviewboard.kde.org/r/128878/diff/ > > > Testing > --- > > > Thanks, > > Łukasz Wojniłowicz > >
Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
> On Sept. 11, 2016, 10:09 a.m., Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this on the lists several times without receiving any > > protests. It's possible, I suppose, that on implementation, a non-lister > > might discover that a much needed feature had been removed. I would still > > have gone ahead, but the change would have had to be reverted in that > > circumstance. > > Perhaps you see a need? > > Łukasz Wojniłowicz wrote: > I didn't know that you wanted to remove QIF facility. I don't use it > personally. Initially I wanted to move it as separate CSV->QIF converter but > it would involve the same steps you do during CSV import, so I left it where > it is. > I think defeaturing CSV importer of QIF converter would be loss of work. It's certainly not causing any harm, that I'm aware of. It was purely to remove clutter. No hard views, either way, though. - Allan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/#review99081 --- On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128878/ > --- > > (Updated Sept. 10, 2016, 4:35 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > 1) It's now possible to save qif file with investments, > 2) If account is available, then it will be added to qif file, > 3) If type of import is available, then it will be added to qif file, > 4) Handled canceling of QFileDialog, > 5) QFileDialog saves only .qif files now, > 6) Date format is hardcoded to MM/dd/, because it is so in files, that I > saw. > > > Diffs > - > > kmymoney/plugins/csvimport/csvdialog.h 3cedd92 > kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 > kmymoney/plugins/csvimport/csvwizard.h 48c15ea > kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd > kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 > kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 > > Diff: https://git.reviewboard.kde.org/r/128878/diff/ > > > Testing > --- > > > Thanks, > > Łukasz Wojniłowicz > >
Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
> On Wrz 11, 2016, 12:09 po południu, Allan Anderson wrote: > > It was actually on my todo list to remove the QIF facility as it no longer > > had any purpose. It was a relict from early days before CSV import became > > fully established. > > I had indicated this on the lists several times without receiving any > > protests. It's possible, I suppose, that on implementation, a non-lister > > might discover that a much needed feature had been removed. I would still > > have gone ahead, but the change would have had to be reverted in that > > circumstance. > > Perhaps you see a need? I didn't know that you wanted to remove QIF facility. I don't use it personally. Initially I wanted to move it as separate CSV->QIF converter but it would involve the same steps you do during CSV import, so I left it where it is. I think defeaturing CSV importer of QIF converter would be loss of work. - Łukasz --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/#review99081 --- On Wrz 10, 2016, 6:35 po południu, Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128878/ > --- > > (Updated Wrz 10, 2016, 6:35 po południu) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > 1) It's now possible to save qif file with investments, > 2) If account is available, then it will be added to qif file, > 3) If type of import is available, then it will be added to qif file, > 4) Handled canceling of QFileDialog, > 5) QFileDialog saves only .qif files now, > 6) Date format is hardcoded to MM/dd/, because it is so in files, that I > saw. > > > Diffs > - > > kmymoney/plugins/csvimport/csvdialog.h 3cedd92 > kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 > kmymoney/plugins/csvimport/csvwizard.h 48c15ea > kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd > kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 > kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 > > Diff: https://git.reviewboard.kde.org/r/128878/diff/ > > > Testing > --- > > > Thanks, > > Łukasz Wojniłowicz > >
Re: Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/#review99081 --- It was actually on my todo list to remove the QIF facility as it no longer had any purpose. It was a relict from early days before CSV import became fully established. I had indicated this on the lists several times without receiving any protests. It's possible, I suppose, that on implementation, a non-lister might discover that a much needed feature had been removed. I would still have gone ahead, but the change would have had to be reverted in that circumstance. Perhaps you see a need? - Allan Anderson On Sept. 10, 2016, 4:35 p.m., Łukasz Wojniłowicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128878/ > --- > > (Updated Sept. 10, 2016, 4:35 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > --- > > 1) It's now possible to save qif file with investments, > 2) If account is available, then it will be added to qif file, > 3) If type of import is available, then it will be added to qif file, > 4) Handled canceling of QFileDialog, > 5) QFileDialog saves only .qif files now, > 6) Date format is hardcoded to MM/dd/, because it is so in files, that I > saw. > > > Diffs > - > > kmymoney/plugins/csvimport/csvdialog.h 3cedd92 > kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 > kmymoney/plugins/csvimport/csvwizard.h 48c15ea > kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd > kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 > kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 > > Diff: https://git.reviewboard.kde.org/r/128878/diff/ > > > Testing > --- > > > Thanks, > > Łukasz Wojniłowicz > >
