Re: [Koha] Koha ILS Driver for Vufind
Hello, On Fri, Mar 6, 2015 at 8:54 AM, Galen Charlton g...@esilibrary.com wrote: Hi, On Thu, Mar 5, 2015 at 3:14 PM, Galen Charlton g...@esilibrary.com wrote: Thanks for testing! I've opened a pull request to have the VuFind folk merge the patch: https://github.com/vufind-org/vufind/pull/311 And as of this morning, it has been merged. Great. Good job Galen -- Olugbenga Adara ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
Hi, On Thu, Mar 5, 2015 at 3:14 PM, Galen Charlton g...@esilibrary.com wrote: Thanks for testing! I've opened a pull request to have the VuFind folk merge the patch: https://github.com/vufind-org/vufind/pull/311 And as of this morning, it has been merged. Regards, Galen -- Galen Charlton Infrastructure and Added Services Manager Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web:http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
Hello Mark, On Thu, Mar 5, 2015 at 1:30 PM, Mark Tompsett mtomp...@hotmail.com wrote: Further tweaks: mtompset@ubuntu:~/vufind/module/VuFind/src/VuFind/ILS/Driver$ git diff origin/master -- Koha.php diff --git a/module/VuFind/src/VuFind/ILS/Driver/Koha.php b/module/VuFind/src/VuFind/ILS/Driver/Koha.php index 6a609a5..7f5011e 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/Koha.php +++ b/module/VuFind/src/VuFind/ILS/Driver/Koha.php I have tried Galen's patch and it did work for me. I also tried yours but was not able to login. It gives the error message We cannot log you in at this time. Please try again later. Thanks very much to you and Galen. I appreciate your quick responses. -- Olugbenga Adara ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
HI, On Thu, Mar 5, 2015 at 2:43 PM, Olugbenga Adara gbengaad...@gmail.com wrote: I have tried Galen's patch and it did work for me. I also tried yours but was not able to login. It gives the error message We cannot log you in at this time. Please try again later. Thanks very much to you and Galen. I appreciate your quick responses. Thanks for testing! I've opened a pull request to have the VuFind folk merge the patch: https://github.com/vufind-org/vufind/pull/311 Regards, Galen -- Galen Charlton Infrastructure and Added Services Manager Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web:http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
Thanks Galen and Mark. I will try these ASAP and give a feedback. Cheers On Thu, Mar 5, 2015 at 12:17 PM, Mark Tompsett mtomp...@hotmail.com wrote: Greetings, https://github.com/gmcharlt/vufind/commit/bbb6e89717627412bb516b0ea84160 f55b183df2 Galen's is better. :) gmcharlton++ GPML, Mark Tompsett -- Olugbenga Adara ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
Hi, On Thu, Mar 5, 2015 at 10:07 AM, Olugbenga Adara gbengaad...@gmail.com wrote: The problem seems to be the password encryption used in the Koha ILS driver and the encryption used for passwords in the current Koha version. The Vufind Koha driver still uses MD5 while I have been informed that current Koha uses BCRYPT. That's correct, modern Koha uses bcrypt. Can anyone provide me with the Koha driver for Vufind or point me towards how I can update the driver to successfully authenticate with current Koha version? I've made a patch to Vufind's Koha driver that allows it to recognize both MD5 and bcrypt password hashes. https://github.com/gmcharlt/vufind/commit/bbb6e89717627412bb516b0ea84160f55b183df2 Please note that this patch is not tested at all, but hopefully it should at least give you the idea. If you try it, I would appreciate feedback on whether it works. Regards, Galen -- Galen Charlton Infrastructure and Added Services Manager Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web:http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org ___ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha
Re: [Koha] Koha ILS Driver for Vufind
Greetings,
The Koha did not write the driver. This is a VuFind issue.
I took a quick look by:
$ git clone https://github.com/vufind-org/vufind.git
$ vi ~/vufind/module/VuFind/src/VuFind/ILS/Driver/Koha.php
-- And around line 484:
// Koha uses MD5_BASE64 encoding to save borrowers' passwords, function
// 'rtrim' is used to discard trailing '=' signs, suitable for pushing
// into MySQL database
$db_pwd = rtrim(base64_encode(pack('H*', md5($password))), '=');
Correct that code on the VuFind repository and happiness should be restored.
Sorry, but how to correct these lines is left as an exercise for someone who
knows:
- how to provide patches to VuFind
- Koha, and
- PHP.
Sorry, but I don't know the first.
In summary, this is a VuFind issue, not a Koha issue.
GPML,
Mark Tompsett
P.S. I have an untested attempt at a re-write of the problematic function.
___
Koha mailing list http://koha-community.org
Koha@lists.katipo.co.nz
http://lists.katipo.co.nz/mailman/listinfo/koha
