[Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix.

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787

Srdjan Jankovic  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix.

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|kyle.m.h...@gmail.com   |srd...@catalyst.net.nz

--- Comment #1 from Srdjan Jankovic  2011-07-22 
05:58:36 UTC ---
Created attachment 4710
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4710
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6621] Javascript error in cloning subfields

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6621

--- Comment #1 from Justin @ Prosentient  
2011-07-22 05:35:22 UTC ---
Created attachment 4709
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4709
makes var buttonDotOnClick a String for IE7

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6621] New: Javascript error in cloning subfields

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6621

 Bug #: 6621
   Summary: Javascript error in cloning subfields
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: rel_3_2
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P5
 Component: Cataloging
AssignedTo: gmcha...@gmail.com
ReportedBy: prosentientsyst...@gmail.com
 QAContact: koha-bugs@lists.koha-community.org
CC: ian.wa...@bywatersolutions.com


While cataloguing using IE7, the clone subfields button doesn't do anything.
Delete subfields does, strangely enough. This is most likely a JavaScript
error. (This problem can be worked around by switching to IE8.)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5928] Allow selection of "purchase for" library in Purchase Suggestions

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #4705|0   |1
is obsolete||

--- Comment #17 from Srdjan Jankovic  2011-07-22 
04:11:15 UTC ---
Created attachment 4708
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4708
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4415] child record only using parent's info

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415

--- Comment #20 from Chris Cormack  2011-07-22 
03:43:04 UTC ---
By alternate contact ... do you mean alternate address nicole?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4873] Debian packaging should avoid /var/run and /var/lock in the package

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4873

Robin Sheat  changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
 CC||ro...@catalyst.net.nz
   Patch Status|--- |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4873] Debian packaging should avoid /var/run and /var/lock in the package

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4873

--- Comment #3 from Robin Sheat  2011-07-22 03:36:19 UTC 
---
Created attachment 4707
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4707
Bug 4873 - Ensure that the required directories exist on init

As systems (Ubuntu already, Debian testing is doing it too) move to
ramdisking /var/run and /var/lock, or otherwise clearing them on boot,
we need to ensure that they're there when we need them. This patch
autocreates any directories that are missing when the init script runs.

Signed-off-by: Robin Sheat 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #1 from Srdjan Jankovic  2011-07-22 
03:25:20 UTC ---
Created attachment 4706
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4706
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4873] Debian packaging should avoid /var/run and /var/lock in the package

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4873

--- Comment #2 from Robin Sheat  2011-07-22 01:35:04 UTC 
---
This will have the nice side effect of fixing installations on Ubuntu that
refuse to come up after boot. I'll have a look to make sure there's nothing
funny that this would cause, but I expect it'll be a quick signoff.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4873] Debian packaging should avoid /var/run and /var/lock in the package

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4873

john.seym...@nal.gov.au changed:

   What|Removed |Added

 CC||john.seym...@nal.gov.au
Version|rel_3_2 |rel_3_4
   Severity|normal  |major

--- Comment #1 from john.seym...@nal.gov.au 2011-07-22 01:26:40 UTC ---
In the current version of debian testing the  /var/run and /var/lock
directories are recreated at each boot (this is part of the migration from
/var/run to /run). This means that the koha directories are not available after
each boot. I fixed this issue by modifying the /etc/init.d/koha-common script
as follows.

--- koha-common.orig2011-07-22 11:07:58.0 +1000
+++ koha-common 2011-07-22 11:06:43.0 +1000
@@ -42,6 +42,8 @@
 #
 do_start()
 {
+# We insure all required directories exist, including disabled ones.
+koha-create-dirs $(koha-list)
 koha-start-zebra $(koha-list --enabled)
 }

yours
John

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5928] Allow selection of "purchase for" library in Purchase Suggestions

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928

--- Comment #16 from Nicole C. Engard  2011-07-22 01:15:24 
UTC ---
I'm confused by this patch - the preference is already there, but this patch
adds it again (I think) and also it doesn't look like it's Template Toolkit but
the old templating system (I did not try to apply the patch).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4415] child record only using parent's info

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415

Nicole C. Engard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

--- Comment #19 from Nicole C. Engard  2011-07-22 01:12:35 
UTC ---
Okay,

One more problem. It now shows the right primary phone based on the edits I
make, but the parent's number under alternate contacts is also changed now -
and it is the one that should stay set the way it was originally.

Also, I didn't know that the alternate contact would be there because that data
wasn't in the form when I was filling it out - and it's not there when I go to
edit the child.  All data that is in the DB should show on the entry form and
on the detail screen for the patron so that you can edit any of it when you
want.

No decisions should be made by Koha and be left unable to edit (when it comes
to patrons).

Nicole

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5928] Allow selection of "purchase for" library in Purchase Suggestions

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928

Srdjan Jankovic  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5917
   Patch Status|Does not apply  |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5928] Allow selection of "purchase for" library in Purchase Suggestions

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #3721|0   |1
is obsolete||

--- Comment #15 from Srdjan Jankovic  2011-07-22 
01:00:51 UTC ---
Created attachment 4705
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4705
patch

Depends on bug 5917

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4415] child record only using parent's info

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #4672|0   |1
is obsolete||

--- Comment #18 from Srdjan Jankovic  2011-07-21 
23:51:36 UTC ---
Created attachment 4704
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4704
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917

Chris Cormack  changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #17 from Chris Cormack  2011-07-21 
20:53:17 UTC ---
Latest patch pushed

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5922] Show waiting items for patron on return

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922

Nicole C. Engard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5922] Show waiting items for patron on return

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922

--- Comment #11 from Owen Leonard  2011-07-21 15:48:55 UTC 
---
Created attachment 4703
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4703
Screenshot of the proposed change

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5922] Show waiting items for patron on return

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922

Owen Leonard  changed:

   What|Removed |Added

   Patch Status|Patch Pushed|Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5922] Show waiting items for patron on return

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922

--- Comment #10 from Owen Leonard  2011-07-21 15:47:29 UTC 
---
Created attachment 4702
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4702
Follow-up change

- Adding patron name to dialog
- Styling dialog as a message rather than an alert since it's
  informational rather than a warning

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6611] patron barcode removed when editing an attribute

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6611

Liz Rea  changed:

   What|Removed |Added

   Attachment #4688|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6611] patron barcode removed when editing an attribute

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6611

Liz Rea  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4415] child record only using parent's info

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415

--- Comment #17 from Liz Rea  2011-07-21 14:27:37 UTC ---
Agreed with Nicole -- seeing the changes on moremember.pl is a necessary part
of this development and what was intended.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6611] patron barcode removed when editing an attribute

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6611

--- Comment #4 from Liz Rea  2011-07-21 13:58:47 UTC ---
Created attachment 4700
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4700
[Signed Off] Bug 6611 : With the change to making cardnumber a nullable field,
we need to pass it around when we are updating borrowers, to make sure we don't
null it

Tested with every small edit link on moremember.pl.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917

Ian Walls  changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
   Patch Status|Signed Off  |Passed QA

--- Comment #16 from Ian Walls  2011-07-21 
13:31:10 UTC ---
Latest follow up from Owen passes QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917

--- Comment #15 from Nicole C. Engard  2011-07-21 12:53:01 
UTC ---
Follow up signed off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4415] child record only using parent's info

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415

--- Comment #16 from Nicole C. Engard  2011-07-21 12:22:41 
UTC ---
Well that explains it - we need to actually see the right phone number (and all
other right details) on the screen.

Nicole

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

--- Comment #2 from Paul Poulain  2011-07-21 
12:15:12 UTC ---
I agree with Ian : SingleBranch is here to hide branch lists for the case of a
single branch library (the list is useless)
So, it shouldn't be here, and should just be detected through the number of
lines in branches table.

Having SingleBranch mode set and more than one branch sounds strange to me.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Ian Walls  changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
Version|unspecified |rel_3_6
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5053

--- Comment #1 from Ian Walls  2011-07-21 
11:55:07 UTC ---
I would contest that we shouldn't HAVE a singleBranchMode system preference. 
Rather, if only one branch is configured in the system, Koha should detect
that, and not offer branch selection options.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

Frédéric Demians  changed:

   What|Removed |Added

   Attachment #4697|0   |1
is obsolete||

--- Comment #11 from Frédéric Demians  2011-07-21 11:44:28 
UTC ---
Created attachment 4699
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4699
Proposed patch (2)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6620] Sip Server Output may be buffered

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620

Colin Campbell  changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
 Status|NEW |ASSIGNED
   Patch Status|--- |Needs Signoff
   Severity|enhancement |major

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6620] Sip Server Output may be buffered

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620

--- Comment #1 from Colin Campbell  2011-07-21 
11:26:50 UTC ---
Created attachment 4698
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4698
Proposed Patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6620] New: Sip Server Output may be buffered

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6620

 Bug #: 6620
   Summary: Sip Server Output may be buffered
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5
 Component: SIP2
AssignedTo: colin.campb...@ptfs-europe.com
ReportedBy: colin.campb...@ptfs-europe.com
 QAContact: koha-bugs@lists.koha-community.org


Bug fix 5586 correctly removed the linefeed from sipserver output. However as
the server writes to stdout which is by default buffered this means that we
cannot guarantee that responses are being returned in a timely fashion.

In practice this can be perceived as extremely slow performance by the
self-check unit or a cease of functioning altogether (the unit timesout).

In practice reverting 5586 fixes this but as 5586 'does the right thing' this
is not a good solution. The proposed solution is that autoflush is specifically
set on the output filehandle, to ensure the response message is not buffered.

Note because of the nature of the problem it is hard to reproduce the bug
consistently,

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

Frédéric Demians  changed:

   What|Removed |Added

   Attachment #4695|0   |1
is obsolete||

--- Comment #10 from Frédéric Demians  2011-07-21 11:06:25 
UTC ---
Created attachment 4697
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4697
Amended proposed patch

Please try this new version of test case. It uses TTParser.
Tell me if more invalid constructions are found.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3624] Basket group delivery place

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624

--- Comment #17 from Paul Poulain  2011-07-21 
10:49:52 UTC ---
an idea :
The deliveryplace & deliverycomment are added in 3.01.00.0094
and the 03.00.0023 does a test/check :
my $sth = $dbh->prepare("SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'billingplace'");
$sth->execute;
$dbh->do("ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10)") if !
$sth->fetchrow_hashref;

maybe there is something wrong with this check and the ALTER TABLE is not done.
Do you have a backup with what you had before the update ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

Frédéric Demians  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
  Change sponsored?|--- |Seeking developer

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

--- Comment #9 from Frédéric Demians  2011-07-21 10:38:04 
UTC ---
> There are multiples problems with this perl version:

You're correct. I have no solution in Perl, neither time. We have
TTParser module. So we should use it to parse properly templates and
identify invalid constructions.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

--- Comment #8 from Frère Sébastien Marie  2011-07-21 
09:36:24 UTC ---
(In reply to comment #7)
> Created attachment 4695 [details]
> Proposed patch
> 
> Could you try this test case and check that it detects the appropriate TT
> issues?

Issues are incomplete: haskell version report 269 issues in 45 files, versus
perl 34 issues in 14 files.

The list could be consulted here:
http://lists.koha-community.org/pipermail/koha-devel/2011-July/035922.html , in
the attachment (but *.inc are not included, and "269 in 45 files" is the last
count on master repo)

There are multiples problems with this perl version:
 - it is line oriented versus stream oriented. So in case of opening tag on one
line, and inclusion of directive in other line, the issue is not reported.
(for examples:
  see ./koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt, line 74
  see ./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc, line 42
)

 - it only check directive near the tagname (like http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5549] Hourly Loans

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549

--- Comment #7 from Colin Campbell  2011-07-21 
09:12:44 UTC ---
installer/data/mysql/atomicupdate/hourlyloans.sql 
needs to be called to add the lengthunit


Testing shows that fines handling needs to be rethought to deal with production
size databases. In fact for hourly loans its probably more paractical to
recalculate as required.

We need to maintain branch opening and closing times as well. If fining on an
hourly basis closed times need to be taken into account much as closed days
are.
It should be possible with a bit of refactoring to have a more consistent
approach to closed days/times

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6540] Add more options to koha-create

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6540

Magnus Enger  changed:

   What|Removed |Added

   Attachment #4694|0   |1
is obsolete||

--- Comment #20 from Magnus Enger  2011-07-21 09:09:37 
UTC ---
Created attachment 4696
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4696
Signed-off Robin's patch

Thanks for fixing my mistakes and signing off, Robin. I'm signing off on your
followup patch, so it should all be signed off now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

--- Comment #7 from Frédéric Demians  2011-07-21 08:28:36 
UTC ---
Created attachment 4695
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4695
Proposed patch

Could you try this test case and check that it detects the appropriate TT
issues?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing

2011-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458

--- Comment #6 from Frère Sébastien Marie  2011-07-21 
07:12:56 UTC ---
Currently, the parser search the string "[%" in *every* HTML tag.

But it isn't a HTML parser. It just track when the string "[%" in placed after
the string "<" (and not ">" between "<" and "[%"), and not between two string
'"'. (but need to track also CDATA and COMMENT because of false-positive else).

It follow a *very simplified* HTML syntax for parsing.

It is relatively simple (and commented), and based on a "context" concept: it
just defined rules for enter in a "context", and to change the "context", when
a specific string is encounter.

For the INITIAL context (the default one):
 - when "" encounter ;
 or in COMMENT context: "-->"
)

That's all... (but the parser keep track the line number for reporting).

I hope I answer your question, and that I have clarified how work the parser...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/