[Koha-bugs] [Bug 4877] koha-* scripts have no manual pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877 Magnus Enger changed: What|Removed |Added Priority|P1 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4877] koha-* scripts have no manual pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877 --- Comment #14 from Magnus Enger 2011-09-13 06:34:21 UTC --- Created attachment 5413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5413 Proposed patch This patch - deletes debian/scripts/koha-create.8 - adds debian/docs/koha-create.xml and koha-remove.xml To test: Check that something like this: xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl koha-*.xml produces sensible output. The output from koha-create.xml should be very similar to the old koha-create.8. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #21 from Frédéric Demians 2011-09-13 04:54:18 UTC --- > But if someone wants to sign off and then it makes it through QA I > will revisit. Ok, thanks. So I see two options: (1) As you said someone can confirm that my patch, which has the advantage of cleaning code, solves this bug and hasn't side effect ; (2) Marcel amends its initial patch, taking into account your comment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6360] all messages on checkin should have sounds if soundson
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6360 Robin Sheat changed: What|Removed |Added Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|kyle.m.h...@gmail.com |ro...@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6360] all messages on checkin should have sounds if soundson
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6360 --- Comment #3 from Robin Sheat 2011-09-13 04:19:25 UTC --- Created attachment 5412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5412 Bug 6360 - add some more sounds to some happenings on returns This adds an alert sound to various events around transfers and holds when items are being returned, to make it more apparent that attention is needed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6866] New: Accessing 'additem.pl' with no CGI params causes error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6866 Bug #: 6866 Summary: Accessing 'additem.pl' with no CGI params causes error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcha...@gmail.com ReportedBy: ro...@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org CC: ian.wa...@bywatersolutions.com If you access /cgi-bin/koha/cataloguing/additem.pl directly, you get: Can't call method "fields" on an undefined value at /mnt/catalyst/koha/C4/Biblio.pm line 2133. This is in the 'TransformMarcToKoha' function, which is called from additem.pl. It should probably do something sensible (redirect to the main cataloguing page?) if there is no record found from the supplied biblionumber. This can happen, for example, if you change libraries when on the additem page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6360] all messages on checkin should have sounds if soundson
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6360 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #2 from Liz Rea 2011-09-13 02:48:42 UTC --- agreed. Robin, the current sounds are in koha-tmpl/intranet-tmpl/prog/sound -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2349] Allow CSS customization of circulation receipts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2349 Liz Rea changed: What|Removed |Added Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6636] a syspref to display 'powered by Koha' text to OPAC footer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6636] a syspref to display 'powered by Koha' text to OPAC footer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #32 from Robin Sheat 2011-09-13 01:03:17 UTC --- Created attachment 5411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5411 Bug 6636 - add 'powered by Koha' text to OPAC footer Signed-off-by: Robin Sheat -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic changed: What|Removed |Added Attachment #5369|0 |1 is obsolete|| --- Comment #12 from Srdjan Jankovic 2011-09-13 00:29:44 UTC --- Created attachment 5410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5410 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6496] authors appearing incorrectly in OPAC and Staff Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6496 Robin Sheat changed: What|Removed |Added Attachment #5400|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6496] authors appearing incorrectly in OPAC and Staff Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6496 --- Comment #15 from Robin Sheat 2011-09-12 23:13:10 UTC --- Created attachment 5409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5409 Bug 6496 - correct the order of the author display in the OPAC This sets the order the fields are displayed in to be as it is in the MARC (typically numerical order), rather than 100,700,110,710,... like it was. Basically, it's a port of the way it's done in the staff client. As such, it should be able to handle a lot more than it could previously, including relator codes. (replaces the previous commit, just removing an erronious comment and making the commit message more accurate) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6651] koha-upgrade-to-3.4 fails when multiple instances are present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6651 Chris Cormack changed: What|Removed |Added Patch Status|Signed Off |Patch Pushed --- Comment #3 from Chris Cormack 2011-09-12 22:30:17 UTC --- Changes for packages only, has been tested in production at catalyst -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6609] Clean up guided reports dictionary entry process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6609 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #2 from Chris Cormack 2011-09-12 22:28:48 UTC --- HTML changes, works fine, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5226] MARC21 field 545 missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5226 Chris Cormack changed: What|Removed |Added Patch Status|Pushed For QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4945] Patron search is limited by default to the currently logged-in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Chris Cormack changed: What|Removed |Added Patch Status|Pushed For QA |Needs Signoff --- Comment #15 from Chris Cormack 2011-09-12 22:17:26 UTC --- This is still sitting awaiting a sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6458] incorrect parsing result in translation processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #81 from Chris Cormack 2011-09-12 21:35:36 UTC --- I have pushed up to Signed off patch correcting results.tt, please sign off the others and I will push the rest -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6716] Database Documentation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Patch Status|Needs Signoff |Patch Pushed --- Comment #34 from Chris Cormack 2011-09-12 21:08:39 UTC --- All patches attached have been pushed, please test, then reset the status if you add more patches -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3498] Allow partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3498 Chris Cormack changed: What|Removed |Added Patch Status|Passed QA |Patch Pushed --- Comment #27 from Chris Cormack 2011-09-12 20:41:27 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6865] New: Replace image-based gradient backgrounds with CSS3 gradients
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6865 Bug #: 6865 Summary: Replace image-based gradient backgrounds with CSS3 gradients Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleon...@myacpl.org ReportedBy: oleon...@myacpl.org QAContact: koha-bugs@lists.koha-community.org Browser support for CSS3 background gradients is good enough to stop using background images for the same effect. This will make the interface a little more efficient. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Owen Leonard changed: What|Removed |Added Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #2 from Owen Leonard 2011-09-12 19:55:20 UTC --- Created attachment 5408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5408 Proposed fix Adding some more specific CSS to help Webkit browsers display the list bullets correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #20 from Chris Cormack 2011-09-12 19:45:40 UTC --- Hi Frédéric I think you may have misunderstood, I was quoting marcel, then I pointed out the existing code is checking the cookie. So I dont think that is actually the problem. The new patch changes a lot of things including reintroducing a behaviour that was removed. It may also have the effect of making the language picker work, but I dont think it has anything to do with the cgi object not being passed. I would rather we understand what the problem is, and just change the themelanguage sub in C4::Template. But if someone wants to sign off and then it makes it through QA I will revisit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #19 from Katrin Fischer 2011-09-12 19:08:32 UTC --- One of the problems with detecting the language from the browser settings was, that not only the selected languages from the system preferences were taken into account, but all existing templates. Often libraries had installed all templates because the big tarball was used and customized only one language in a way, that broke the layout for other languages that were not activated. Language chooser is often deactivated so you end up trapped in a broken layout, broken templates (becaues they were not updated when the system was) and/or broken/incorrect/incomplete translations. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #18 from Frédéric Demians 2011-09-12 18:57:20 UTC --- (In reply to comment #17) > "1) The call in Output/gettemplate did not pass the CGI object to > C4::Templates->new. This routine called themelanguage but WITHOUT cgi > object! So it ignored the cookie. My patch now optionally adds the > query parameter to Templates->new and corrects the themelanguage call. > " Thanks a lot for taking care of all those subtleties. Have you apply my last patch? gettemplate isn't anymore in Output.pm. For my myopic eyes, it seems correct. The above comment may not say exactly what is the code... > So I think the bug is something different, the new patch (and the old > one) reintroduce the behaviour of using the browsers language setting > if no cookie is set. Which was removed because it was causing > problems. ? Isn't it a desirable behavior? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755
--- Comment #17 from Chris Cormack 2011-09-12
18:19:39 UTC ---
"1) The call in Output/gettemplate did not pass the CGI object to
C4::Templates->new. This routine called themelanguage but WITHOUT cgi object!
So it ignored the cookie. My patch now optionally adds the query parameter to
Templates->new and corrects the themelanguage call. "
I think this original contention is not correct
Looking at C4::Templates themelanguage
my ( $htdocs, $tmpl, $interface ) = @_;
my $query = new CGI;
# Set some defaults for language and theme
# First, check the user's preferences
my $lang;
# But, if there's a cookie set, obey it
$lang = $query->cookie('KohaOpacLanguage')
if ( defined $query and $query->cookie('KohaOpacLanguage') );
Its true $query is not passed, but its initiated there, and the cookie is
checked.
So I think the bug is something different, the new patch (and the old one)
reintroduce the behaviour of using the browsers language setting if no cookie
is set. Which was removed because it was causing problems.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6800] Koha authentication should handle proxies better
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6800 Paul Poulain changed: What|Removed |Added Severity|enhancement |major --- Comment #2 from Paul Poulain 2011-09-12 16:07:11 UTC --- I think it's not en ENH: * the current Koha does not work for ppl with a load balancer/proxy/... so even if this patch improves the behaviour, for ppl with such a network, it's a problem and it should be considered as a bug. * shouldn't we remove the IP checking at all ? For libraries that really need security, https is a better way to go isn't it ? Anyway, i'm upgrading severity (patch untested yet) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6800] Koha authentication should handle proxies better
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6800 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5511 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 Frédéric Demians changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 Frédéric Demians changed: What|Removed |Added Attachment #5385|0 |1 is obsolete|| --- Comment #16 from Frédéric Demians 2011-09-12 15:27:59 UTC --- Created attachment 5407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5407 Revised patch This patch move templates related function from C4::Output to C4::Templates. It impacts various pages, and modules. Should be tested closely. It works for me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3498] Allow partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3498 Ian Walls changed: What|Removed |Added Patch Status|Needs Signoff |Passed QA --- Comment #26 from Ian Walls 2011-09-12 15:25:07 UTC --- Thank you to Elliott, Nicole and Liz for a most thorough testing of this patch, and for putting up with my pesky style and documentation demands. I'm happy to pass this patch through QA. Bug 6427 can now be re-evaluated in the context of this fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3498] Allow partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3498 Liz Rea changed: What|Removed |Added Attachment #5383|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3498] Allow partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3498 Liz Rea changed: What|Removed |Added Attachment #5360|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3498] Allow partial fine payments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3498 --- Comment #25 from Liz Rea 2011-09-12 15:12:17 UTC --- Created attachment 5406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5406 Bug 3498 Allow Partial Payment of Fines Allow partial payment of outstanding fines against either individual fine entries or as a lump payment Sponsered by East Brunswick Public Library, East Brunswick, NJ, USA NB: Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables Signed-off-by: Liz Rea Bug 3498 - Documentation update to explain what every button does. Help file updated to the following: Pay and Writeoff Fines Each line item can be paid in full, partially paid, or written off. Pay a fine in full Click "Pay" next to the fine you want to pay in full The full amount of the fine will be populated for you in the "Collect From Patron" box Click "Confirm" The fine will be removed from outstanding fines, and displayed as fully paid. Pay a partial fine Click "Pay" next to the fine you want to partially pay Enter the amount you are collecting from the patron in the "Collect From Patron" box Click "Confirm" The fine will be updated to show the original Amount, and the current Amount Outstanding Writeoff a single fine Click "Writeoff" next to the fine you wish to writeoff. The fine will be removed from outstanding fines, and displayed as fully paid. Pay an amount towards all fines Click the "Pay Amount" button Enter the amount you are collecting from the patron in "Collect from Patron." The sum of all fines is shown in "Total Amount Outstanding" Click "Confirm" The fine totals will be updated with the payment applied to oldest fines first. Writeoff All fines Click the "Writeoff All" button All fines will be removed from outstanding fines, and displayed as written off. Pay Selected fines Check the selection boxes next to the fines you wish to pay, click "Pay Selected" Enter an amount to pay towards the fines. Click "Confirm" The fine totals will be updated with the payment applied to the oldest selected fines first. Bug 3498 - adding parens to TT IF Statements for style pay.tt Bug 3498 - Add parens to TT IF statements for style paycollect.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Patch Status|Needs Signoff |Failed QA --- Comment #11 from Paul Poulain 2011-09-12 14:01:30 UTC --- frenchy/UNIMARC guy comment: Looking at this patch I heavily suspect some MARC things are hardcoded and it would heavily break non MARC21 instances... A if (marcflavour eq "marc21") would be a bare minimum PS : are you sure *everybody* using marc21 will have field 952 with those subfields & content ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511
Paul Poulain changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
Patch Status|Needs Signoff |Failed QA
--- Comment #6 from Paul Poulain 2011-09-12
13:47:48 UTC ---
QA comment(s)
Before testing this patch, some QA comments :
+remoteipcheck=> C4::Context->preference("remoteipcheck"),
seems useless to me = there's no need to send this syspref to the templates
(and you don't doo anything with it anyway)
Also note that this patch won't apply anymore due to the changes in the syspref
system that has been pushed recently (see bug 6537)
Also note that we have suggested/proposed that updatedatabase are provided in a
separate patch, so as you take care of the previous suggestion, can you do this
as well ?
Could you submit an enhanced patch please, and reset to "need signoff", I set
"failed QA"
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5725] Batch modifications for Biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #37 from Paul Poulain 2011-09-12 13:39:46 UTC --- Created attachment 5405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5405 proposed patch follow-up 2 follow-up 2, fixes leader changes that was not working (see owen comment 33) Owen, you can sign-off my 3 patches for this ENH (or add a new comment ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5725] Batch modifications for Biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain changed: What|Removed |Added Attachment #4897|0 |1 is obsolete|| --- Comment #36 from Paul Poulain 2011-09-12 13:37:26 UTC --- Created attachment 5404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5404 owen fix signed-off signing off owen's patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5574] 3.4 cataloguing improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5574 Paul Poulain changed: What|Removed |Added Priority|P5 |P1 Patch Status|Needs Signoff |--- --- Comment #6 from Paul Poulain 2011-09-12 12:31:33 UTC --- hehe... seems i've found a small glitch in bugzilla: if you remove the patch-SENT but don't remove the patch status, it's still "needs signoff". So, i'll update the bug to fix this problem 1st try: select "patch-SENT", remove "needs signoff", remove patch-SENT, save bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|unspecified |master AssignedTo|oleon...@myacpl.org |m...@kohaaloha.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5636] clean borrowers run from command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5636 --- Comment #6 from Paul Poulain 2011-09-12 11:30:38 UTC --- seems Marcel & me have the same opinion : don't decide anything, there are only a few cases where it's functionnally relevant. No one elses answered.( http://lists.koha-community.org/pipermail/koha-devel/2011-August/036126.html) Ian QA welcomed ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #15 from Chris Cormack 2011-09-12 10:23:33 UTC --- I'll refactor the patch to use themelanguage in C4::Template. Unless someone beats me to do that, I'm currently reinstalling debian so you have a bit of a head start :) It shouldn't be a big job, just changing the calls to use the local themelanguage instead of the one in C4::Output and testing it still works -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6755] Problems with switching languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6755 --- Comment #14 from M. de Rooy 2011-09-12 09:53:45 UTC --- I understand the issues raised, but do/did not have the time to send the theoretically best solution. So, it is a pragmatic patch to solve an annoying issue for non-English users. Failed QA is fine with me, but the current code should have failed QA too! I can send another patch, but it will take some weeks. No problem if someone else does the job now. The problem is clear. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6576] changing framework while cataloging looses data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Srdjan Jankovic changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6576] changing framework while cataloging looses data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Srdjan Jankovic changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|gmcha...@gmail.com |srd...@catalyst.net.nz --- Comment #1 from Srdjan Jankovic 2011-09-12 09:16:32 UTC --- Created attachment 5403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5403 patch This will only apply for new records, will not apply for modifying existing ones. Please check if there are no fields that are retaining values that are not applicable for the new (changed) framework -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
