[Koha-bugs] [Bug 6868] Need a script to fix bad accountno data in accountlines

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  2011-12-06 
07:20:34 UTC ---
I am not sure how to test this. Can you provide a test plan?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Katrin Fischer  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

--- Comment #90 from Katrin Fischer  2011-12-06 
07:08:32 UTC ---
Applied patches and created a new database. No errors were reported and all
documented tables were created.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Katrin Fischer  changed:

   What|Removed |Added

   Attachment #6591|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #89 from Katrin Fischer  2011-12-06 
07:07:40 UTC ---
Created attachment 6599
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6599
[SIGNED-OFF] Bug 6716 Update biblio & deletedbiblio tables

The comments on the biblio and deletedbiblio table
didn't mention the MARC21 subfields. This patch adds
that documentation in.

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #88 from Katrin Fischer  2011-12-06 
07:07:32 UTC ---
Created attachment 6598
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6598
[SIGNED-OFF] 6717 Documenting need_merge_authorities table

Documentation only.

http://bugs.koha-community.org/show_bug.cgi?id=6716
Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #87 from Katrin Fischer  2011-12-06 
07:07:25 UTC ---
Created attachment 6597
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6597
[SIGNED-OFF] Bug 6716 : Categories table

This patch documents the patron categories table in Koha.
There are a couple fields marked unused and a couple that aren't
documented because I wasn't sure:

* dateofbirthrequired
* bulk

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #86 from Katrin Fischer  2011-12-06 
07:07:12 UTC ---
Created attachment 6596
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6596
[SIGNED-OFF] Bug 6716: Document biblioitems and deletedbiblioitems

This patch documents the biblioitems and the deletedbiblioitems
tables.  There are many fields left undocumented because I didn't see
information in them, but this is enough of a start to be helpful to
those writing reports.

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #85 from Katrin Fischer  2011-12-06 
07:07:04 UTC ---
Created attachment 6595
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6595
[SIGNED-OFF] Bug 6716 Document deleteditems table

This patch documents the deleted items table. Some fields were left
undocumented because I was unsure of what data was stored there:

stack - might be linked to shelving number, but need confirmation
paidfor - pretty sure this is unused, but don't want to document it that way

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #84 from Katrin Fischer  2011-12-06 
07:06:56 UTC ---
Created attachment 6594
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6594
[SIGNED-OFF] Bug 6716 - Document Items Table

This patch documents the items table. Some fields were left
undocumented because I was unsure of what data was stored there:

stack - might be linked to shelving number, but need confirmation
paidfor - pretty sure this is unused, but don't want to document it that way

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #83 from Katrin Fischer  2011-12-06 
07:06:48 UTC ---
Created attachment 6593
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6593
[SIGNED-OFF] bug6716 - document the aqbooksellers table

This documents the table that stores vendor info in Koha.

There were 4 unused fields found:
  `accountnumber`
  `othersupplier`
  `currency`
  `booksellerurl`

Signed-off-by: Katrin Fischer 
Accountnumber is no longer unused and can be managed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

--- Comment #82 from Katrin Fischer  2011-12-06 
07:06:39 UTC ---
Created attachment 6592
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6592
[SIGNED-OFF] bug6716: documenting reserves and old_reserves tables

This patch documents the reserves and the old_reserves table.
Note that a few fields are marked unused: notificationdate and
reminderdate. Also two fields are left undocumented: lowestPriority
which never seems to be anything other than 0 and constrainttype which
is either 'a' or 0, but there doesn't appear to be any explanation
as to what each stands for.

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Katrin Fischer  changed:

   What|Removed |Added

   Attachment #5663|0   |1
is obsolete||
   Attachment #5664|0   |1
is obsolete||
   Attachment #5686|0   |1
is obsolete||
   Attachment #5687|0   |1
is obsolete||
   Attachment #5706|0   |1
is obsolete||
   Attachment #5829|0   |1
is obsolete||
   Attachment #6004|0   |1
is obsolete||
   Attachment #6015|0   |1
is obsolete||

--- Comment #81 from Katrin Fischer  2011-12-06 
07:04:56 UTC ---
Created attachment 6591
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6591
bug6716: documenting reserves and old_reserves tables

This patch documents the reserves and the old_reserves table.
Note that a few fields are marked unused: notificationdate and
reminderdate. Also two fields are left undocumented: lowestPriority
which never seems to be anything other than 0 and constrainttype which
is either 'a' or 0, but there doesn't appear to be any explanation
as to what each stands for.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

Katrin Fischer  changed:

   What|Removed |Added

   Attachment #6580|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  2011-12-06 
06:25:08 UTC ---
Created attachment 6590
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6590
[SIGNED-OFF] Bug 7319 - Improving title and breadcrumbs on acquisitions Z39.50
search pages

Changing title and breadcrumbs so that they correctly reflect
the curent stage of the process.

To test: Add to an order from an external source. When filling
out the Z39.50 search form the title and breadcrumbs should read
"Order from external sources." After searching they should read
"Order from external sources -> Search results"

Signed-off-by: Katrin Fischer 
Works as described.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7239] Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239

Katrin Fischer  changed:

   What|Removed |Added

   Patch Status|Does not apply  |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7239] Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239

Katrin Fischer  changed:

   What|Removed |Added

   Attachment #6588|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  2011-12-06 
06:01:52 UTC ---
Created attachment 6589
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6589
[SIGNED-OFF] bug 7239 fix to avoid error being thrown even though a record is
created

Signed-off-by: Katrin Fischer 
When creating an item in acquisitions while ordering and not filling out
any fields, there is no longer shown a perl error message.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7239] Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239

Chris Hall  changed:

   What|Removed |Added

   Attachment #6324|0   |1
is obsolete||

--- Comment #7 from Chris Hall  2011-12-06 03:05:30 UTC 
---
Created attachment 6588
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6588
Patch adds a stronger check on adding a closing  tag

Sorry about that, it seems I generated that using git diff rather than
format-patch.

Corrected formatted patch attached.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163

Marijana  changed:

   What|Removed |Added

 CC||mglav...@ffzg.hr

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5359] Parcel receive improvement

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5359

Marijana  changed:

   What|Removed |Added

 CC||mglav...@ffzg.hr

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Marijana  changed:

   What|Removed |Added

 CC||mglav...@ffzg.hr

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5344] Invoice management improvements

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5344

Marijana  changed:

   What|Removed |Added

 CC||mglav...@ffzg.hr

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7178] Improve order item creation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178

Marijana  changed:

   What|Removed |Added

 CC||mglav...@ffzg.hr

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6740] can add items at ordering but not remove items

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740

--- Comment #19 from Paul Poulain  2011-12-05 
21:43:48 UTC ---
Wonderfull Katrin ! you probably got it !
I'll QA this patch tomorrow, when waiting for my plane to go back home. It's a
little bit late for now, heading to bed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #28 from Paul Poulain  2011-12-05 
21:42:29 UTC ---
(In reply to comment #25)
> Comments from some (nut full) testing (no QA):
> 
> I see 3.07.01.xxx in the db revs.
> But what is 3.07.01 ? When do you reach 3.07.02 now? After you installed all 
> 50
It's just here for testing purposes, and won't be pushed.
With this new system, the numbers don't matter. That's why I started a thread
about that in koha-devel.
We could decide to mark all DB revs 3.08.01 immediatly, or use an increasing
number, like 4, 5, 6, ...

> Listing them all is not helpful. 
Yep, I plan to add an improvement to display applied patches like this
3.07.01.001...3.07.01.015 (if we have applied all revs btw 001 and 0015)
and 3.07.01.001...3.07.01.015, 3.07.01.0017 (if we have applied all revs
between 001 and 015, and the 017)

> So this would be: 3.07.01 with 36 db revisions installed; 23 db revisions
> pending.
> Question: Do you allow someone to install dbrev 3.07.03.xxx while not all
> 3.07.02 are installed? I would say No. 
> Code should check that. Can we test it? 

I've proposed, and will provide an improvement for that, the following
behaviour:
* if DEBUG=0, then you will reach the update page from mainpage.pl until you've
made all update. So you *can't* switch an update.
* if DEBUG=1, then you won't reach the update page automatically. For
testers/testing purposes, it's a desired behaviour (improvement: today, you
have only the DEBUG=0 behaviour, which is OK)

Thus, you'll get:
* non linear updates, with almost the same behaviour as today, for productions
setups
* mandatory updates, except if you've DEBUG=1 (and in this case, you know what
you're doing)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5801] C4::Circulation::_GetCircControlBranch doesn't work in opac-reserve.pl

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5801

Ian Walls  changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com

--- Comment #5 from Ian Walls  2011-12-05 
21:23:49 UTC ---
Just looking at the code, it's pretty clear there are some problems;

_GetCircControlBranch is an internal function (hence the _ at the beginning),
so it shouldn't be called in this script.

Also, as Fridoyln points out, the hashref passed doesn't contain the necessary
information, so results are inaccurate.

And shouldn't we be using ReservesControlBranch, not CircControl and
HomeOrHoldingBranch, to get our rules for a hold?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7239] Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239

Katrin Fischer  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Does not apply

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7239] Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239

--- Comment #6 from Katrin Fischer  2011-12-05 
20:59:50 UTC ---
Hi Chris,

something seems to be wrong with your patch:

git bz apply 7239
Bug 7239 - Acquisitions basket, add order to basket, from new, Source of
classification or shelving scheme being blank caused internal error

Patch adds a stronger check on adding a closing  tag
Apply? [yn] y

Patch format detection failed.

git am -is3
/tmp/Patch-adds-a-stronger-check-on-adding-a-closing-da-zOWPN2.patch
Patch format detection failed.

Can you check and attach a new file please? Thx!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7321] Silence warns in Koha.pm

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7321

Katrin Fischer  changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff
 AssignedTo|gmcha...@gmail.com  |katrin.fisc...@bsz-bw.de

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7321] Silence warns in Koha.pm

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7321

--- Comment #1 from Katrin Fischer  2011-12-05 
20:54:04 UTC ---
Created attachment 6587
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6587
Bug 7321: Silence some warns in Koha.pm

While testing bug 7013 I noticed a lot of warns in the koha error log.
This patch is silencing them.

To test:
Add or edit an authorised value and check your log files before and after
applying the patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7276] member entry Performance improvement

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7276

--- Comment #5 from Paul Poulain  2011-12-05 
20:47:45 UTC ---
This patch show a big improvement in performance when we bulk load patrons,
using a specific script we're using at BibLibre when doing our migrations. I
think the improvement can be seen in tools > import patrons, when loading large
sets of patrons.

Note this patch is a porting of what we've made in git.biblibre.com and use in
productions for months (if not years)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6663] would be nice to put ranges of dates in the calendar

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663

Owen Leonard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

--- Comment #9 from Owen Leonard  2011-12-05 20:45:55 UTC 
---
This looks good. A couple of possible future improvements:

- Prevent the user from choosing a date which falls before the "From Date"
- Only show the "To Date" if one of the "range" options is selected

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6663] would be nice to put ranges of dates in the calendar

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663

Owen Leonard  changed:

   What|Removed |Added

   Attachment #6569|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  2011-12-05 20:41:59 UTC 
---
Created attachment 6586
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6586
Signed-off patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7321] New: Silence warns in Koha.pm

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7321

 Bug #: 7321
   Summary: Silence warns in Koha.pm
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
AssignedTo: gmcha...@gmail.com
ReportedBy: katrin.fisc...@bsz-bw.de
 QAContact: ian.wa...@bywatersolutions.com


When testing bug 7013 I noticed a lot of warns in the koha error log. The patch
is silencing them.

To test:
Add or edit an authorised value and check your log files before and after
applying the patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7164] add Koha history timeline tab to 'About' page

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7164

Owen Leonard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7164] add Koha history timeline tab to 'About' page

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7164

Owen Leonard  changed:

   What|Removed |Added

   Attachment #6226|0   |1
is obsolete||
   Attachment #6534|0   |1
is obsolete||
   Attachment #6547|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  2011-12-05 20:27:41 UTC 
---
Created attachment 6585
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6585
Signed-off patch

I hope it's okay I signed off and included one minor edit: Adding an html
filter ("|html") to the output of the history description for the sake of HTML
validity.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Owen Leonard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

--- Comment #8 from Owen Leonard  2011-12-05 20:14:09 UTC 
---
I tried submitting an invalid value for a CCODE and did get an error message,
but the error messages was on the Authorised Values home page
(/cgi-bin/koha/admin/authorised_values.pl) rather than on the submission form
for CCODE
(/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=CCODE).

The error messages should show on the same page from which the user submitted
the invalid value, ideally with all the other values retained in the form so
that they don't have to be re-typed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2346] consolidate duplicate methods C4::Overdues::UpdateBorrowerDebarred and C4::Members::DebarMember

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2346

Chris Cormack  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2346] consolidate duplicate methods C4::Overdues::UpdateBorrowerDebarred and C4::Members::DebarMember

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2346

Chris Cormack  changed:

   What|Removed |Added

   Attachment #6564|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  2011-12-05 
19:57:55 UTC ---
Created attachment 6584
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6584
Bug 2346: Remove C4::Overdues::UpdateBorrowerDebarred in favour of
C4::Members::DebarMember

Removes now-unused subroutine from C4::Overdues, as well as the db_dependent
unit test

Signed-off-by: Chris Cormack 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #3 from Sarah Clatterbuck  2011-12-05 
19:54:35 UTC ---
Katrin, 

I will be documenting the current functionality and developing and RFC wiki
over the next week or so. 

Owen, 

My understanding is that the FulfILLment project will not be ready for some
time yet. I'm thinking about creating an iterative feature where we support ILL
"base", which would allow the receiving library to track a request and manage
the asset and then in the future add the enhanced functionality that would be a
holistic system for both sides of the transaction (likely via FulfiLLment).
Thoughts? 

-Sarah

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7316] Missing escaping in search results

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7316

Owen Leonard  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7316] Missing escaping in search results

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7316

Owen Leonard  changed:

   What|Removed |Added

   Attachment #6565|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  2011-12-05 19:36:03 UTC 
---
Created attachment 6583
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6583
Signed-off patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7320] Return notes for circulation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7320

--- Comment #2 from Katrin Fischer  2011-12-05 
19:22:40 UTC ---
Yes, that would work :)

I think it should be controlled by a system preference so that it does not slow
down circ for busy libraries.

Fines and waiting holds are controlled by FineNotifyAtCheckin and
WaitingNotifyAtCheckin.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7320] Return notes for circulation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7320

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack  2011-12-05 
19:17:51 UTC ---
How about have it flag for items that are attached to a Fast Add framework with
a note at returns.

Similar to the ones for waiting holds, or fines

Would that work?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7320] New: Return notes for circulation

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7320

 Bug #: 7320
   Summary: Return notes for circulation
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
AssignedTo: kyle.m.h...@gmail.com
ReportedBy: katrin.fisc...@bsz-bw.de
 QAContact: ian.wa...@bywatersolutions.com
CC: gmcha...@gmail.com


Make it possible to add a note to an item which is not visible for the patron
and shows up on return of the item.

Example: Fast adds.
A return note for a fast add could be 'send to cataloging'.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Owen Leonard  2011-12-05 16:17:37 UTC 
---
I second the recommendation to look at the FulfILLment project. I've just
volunteered to help test the project's Koha connector. I haven't gotten as far
as seeing anything in action yet but Equinox has a great reputation so I'm
looking forward to it.

At the very least getting to know that project better might give you some
guidance on what problems it *doesn't* solve that you would have yours do or
vice versa.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

--- Comment #7 from Chris Cormack  2011-12-05 
15:49:00 UTC ---
Created attachment 6582
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6582
Bug 7013 : Fixing sql injection problems

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  2011-12-05 
15:47:27 UTC ---
I agree with comment 3, this code is still vulnerable to sql injection. 

I will add a follow up, but I would encourage all developers to fix any bad
coding practices like this that they say, as they change code. It is the
perfect opportunity and really, there is no good reason to ever not use sql
placeholders.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6740] can add items at ordering but not remove items

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6740] can add items at ordering but not remove items

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740

Owen Leonard  changed:

   What|Removed |Added

   Attachment #6571|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  2011-12-05 15:36:05 UTC 
---
Created attachment 6581
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6581
Signed-off patch

Tested both test plans and found both to be working properly.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6786] False detection of index names in Search; make index names case insensitive

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6786

Ian Walls  changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #12 from Ian Walls  2011-12-05 
14:52:59 UTC ---
Adds hyphen back into regex, which is required for many/most of the search
indexes in bib1.att.

Please note that / is also used in several of the bib1.att indexes... now as to
whether we actually support those particular indexes, I'm not sure, but
theoretically, we should probably also include regex matching for / as well.

Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

Owen Leonard  changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

--- Comment #1 from Owen Leonard  2011-12-05 14:48:31 UTC 
---
Created attachment 6580
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6580
Proposed fix

Changing title and breadcrumbs so that they correctly reflect
the curent stage of the process.

To test: Add to an order from an external source. When filling
out the Z39.50 search form the title and breadcrumbs should read
"Order from external source." After searching they should read
"Order from external source -> Search results"

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

Ian Walls  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=3068

--- Comment #5 from Ian Walls  2011-12-05 
14:45:56 UTC ---
Adding See Also link to bug 3068

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7319] New: Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319

 Bug #: 7319
   Summary: Improve specificity of title and breadcrumbs on
acquisitions Z39.50 search pages
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Platform: All
OS/Version: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
AssignedTo: oleon...@myacpl.org
ReportedBy: oleon...@myacpl.org
 QAContact: ian.wa...@bywatersolutions.com


If you search for an item via Z39.50 search to add to an order the initial
search page says "Z39.50 Search Results." The title and breadcrumbs should
reflect the correct stage of the operation.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #3 from Nicole C. Engard  2011-12-05 14:29:34 
UTC ---
(In reply to comment #2)
> New proposal to the list:
> 
> 1  Do not allow to create a public list in the OPAC. (Only private lists.) 
> Public lists are only created by staff users in the staff client. 


I think this should be a preference that the librarians can choose from the
following options :

   1. Allow anyone to create public lists without moderation
   2. Allow patrons to create public lists with moderation
   3. Allow only staff (with permission) to create public lists

> 2  Add three permission options to any list: a) Allow adding entries b) Allow
> deleting your own entries (that you added)  and c) Allow deleting entries that
> someone else added.
>This makes the distinction between public list and open list no longer
> needed and adds some refinement in lists management. 
>Only the owner of the list can change these permissions.

In addition I'd say we need general staff list permissions which we don't have
right now.

> 3  Add a new (opac) feature to private lists: Share a list (with another
> patron).
>Let the user share access to a list by Koha sending an email with a URL
> including some (temporary) invitation key. When the invited patron clicks that
> URL (when logged in) he gains access (in accordance with the described
> permission options for that specific list).
>The invited patron can always 'delete' the shared list, i.e. delete the
> share.
>The owner can 'unshare' the list and remove all shares for that list.

I like!

> 4  With respect to user privacy, a feature may be added in staff client to
> moderate shared list names. 
> 5  Possibly, libraries do not want patrons sharing lists. So the option could
> be disabled with a preference. In that case points 2 and 3 still apply.

Yes, preferences to turn things off are always good.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #27 from M. de Rooy  2011-12-05 14:10:38 
UTC ---
> I am not sure we should encourage that. It will make it really hard to find 
> out
> what's going wrong. People should at least be forced to resolve their database
> updates. Like marking something 'OK' that did not apply, but was a duplicate
> message.

With some discussion on IRC in mind, it might be interesting to add a
preference (yet another ;) on the Admin page that defaults to Linear updating
(and enforces to run all updates in sequence before using Koha). Only if
Delinear would be selected (by a developer), allow selective updating and do
not force running all updates before using Koha. Just remind an admin at login
time.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #6 from Adrien SAURAT  2011-12-05 
14:04:57 UTC ---
In fact, the syspref text says the following :

The OPAC is located at http://[INPUT ZONE] . (This must be filled in correctly
for RSS, unAPI, and search plugins to work.) 

The http part is not supposed to be typed, and only the addition of "http://";
seems to be expected.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #5 from Adrien SAURAT  2011-12-05 
14:01:06 UTC ---
I don't know and the developper of the first version of this patch (developped
for a specific customer) can't remember why he did this. I guess we can remove
this, I'll make another patch.

The following check :
if ( $OPACRssURL !~ m/^http:\/\// ) { $OPACRssURL = "http://"; . $OPACRssURL }
will then have to handle https cases.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Adrien SAURAT  changed:

   What|Removed |Added

   Attachment #6577|0   |1
is obsolete||

--- Comment #5 from Adrien SAURAT  2011-12-05 
13:17:32 UTC ---
Created attachment 6579
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6579
patch

Diff show a lot of modified lines because the indentation of a few blocks
changed, but I actually added a just few lines.

What I did :
- added the regex "$new_authorised_value =~ /^[a-zA-Z0-9\-_]+$/" to allow only
letters, numbers, dash and underscore for a new value;
- added a new hint next to the input box;
- added a new error message when the user types an incorrect value.

Also removed a few trailing spaces (they caused warnings when applying the
patch).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2092] Koha should support Unicode 6

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2092

--- Comment #2 from Colin Campbell  2011-12-05 
12:52:37 UTC ---
Unicode 6.0 is supported as of perl 5.14.0

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #26 from Katrin Fischer  2011-12-05 
12:43:22 UTC ---
>I assumed that we allowed the situation now that not all dbrevs are executed,
>but the code does not. Should be adjusted.

I am not sure we should encourage that. It will make it really hard to find out
what's going wrong. People should at least be forced to resolve their database
updates. Like marking something 'OK' that did not apply, but was a duplicate
message.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #25 from M. de Rooy  2011-12-05 12:36:50 
UTC ---
Comments from some (nut full) testing (no QA):

I see 3.07.01.xxx in the db revs.
But what is 3.07.01 ? When do you reach 3.07.02 now? After you installed all 50
dbrevs that are marked with 3.07.01?
Is that mechanism implemented in current code? When and how are we stepping to
3.07.02 ? 

About/version: 3.062 / 3.07.01.0002 / 3.07.01.0003
Listing them all is not helpful. 
I would say list the version number: 3.07.01 meaning something like: everything
below has been installed. And list the numbers of dbrevs installed for 3.07.02
and higher and the number pending. 
So this would be: 3.07.01 with 36 db revisions installed; 23 db revisions
pending.
I agree that this kind of change is cosmetic but should follow quickly. 

Question: Do you allow someone to install dbrev 3.07.03.xxx while not all
3.07.02 are installed? I would say No. 
Code should check that. Can we test it? 

Non-superlibrarian could not login while not all updates were executed. But he
should! 
Superlibrarian is able to login. Clicking homepage goes to update page, but
clicking modules works fine. But I want homepage! I only like the warning if I
am logging in. 
I assumed that we allowed the situation now that not all dbrevs are executed,
but the code does not. Should be adjusted.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

--- Comment #4 from Adrien SAURAT  2011-12-05 
11:07:29 UTC ---
I didn't change the SQL parts, they could be indeed enhanced but it would be
better to make a specific bug about this, to make things clear.

But thanks to your remark, I noticed a version problem :/ the script has
probably been modified as I was working on this. I'll handle the conflicts and
upload a new patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7281] Hide some lists (virtual shelves) from OPAC

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7281

--- Comment #1 from M. de Rooy  2011-12-05 10:49:17 
UTC ---
See bug 7310. If we use the concept of shared lists, this report may not be
needed after all.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #2 from M. de Rooy  2011-12-05 10:42:33 
UTC ---
New proposal to the list:

1  Do not allow to create a public list in the OPAC. (Only private lists.) 
Public lists are only created by staff users in the staff client. 
2  Add three permission options to any list: a) Allow adding entries b) Allow
deleting your own entries (that you added)  and c) Allow deleting entries that
someone else added.
   This makes the distinction between public list and open list no longer
needed and adds some refinement in lists management. 
   Only the owner of the list can change these permissions.
3  Add a new (opac) feature to private lists: Share a list (with another
patron).
   Let the user share access to a list by Koha sending an email with a URL
including some (temporary) invitation key. When the invited patron clicks that
URL (when logged in) he gains access (in accordance with the described
permission options for that specific list).
   The invited patron can always 'delete' the shared list, i.e. delete the
share.
   The owner can 'unshare' the list and remove all shares for that list.
4  With respect to user privacy, a feature may be added in staff client to
moderate shared list names. 
5  Possibly, libraries do not want patrons sharing lists. So the option could
be disabled with a preference. In that case points 2 and 3 still apply.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #6538|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  2011-12-05 
10:38:37 UTC ---
Created attachment 6578
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6578
Proposed patch

Adds sql modifications for all languages (contains de-DE, es-ES, it-IT, nb-NO)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

--- Comment #11 from Katrin Fischer  2011-12-05 
10:36:37 UTC ---
Hi Jonathan, thx for your comments :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5347] late order management

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

--- Comment #10 from Jonathan Druart  2011-12-05 
10:30:15 UTC ---
Hi Katrin,

1/ Exactly, my example is not good :-/

A good example : 
<>
<>
<>
<>
<>
<>

Ordernumber <> (<>)
(<> ordered) ($<> each) has not been
received.

For the ACQCLAIM notice, we can select fields from tables branches,
aqbooksellers, aqorders, biblio and biblioitems.

2/ Ok, I'm going to create a new patch containing modifications for all
languages

3/ Yes, it's desirable but it's not the goal of this development

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

--- Comment #3 from Frère Sébastien Marie  2011-12-05 
10:17:25 UTC ---
Comment on attachment 6577
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6577
proposed patch

This patch is vulnerable to SQL injection.

Please use placeholders in SQL query (using prepare/execute), instead of
$variable.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

M. de Rooy  changed:

   What|Removed |Added

   Patch Status|Signed Off  |Failed QA

--- Comment #4 from M. de Rooy  2011-12-05 09:43:16 
UTC ---
QA Comment:
I did not test this patch, but have some comments on the code that is not
directly touched by this patch but is in the direct context.

I think that the check if ($ip !~ /^$domain/) does not work. If domain is a
full IP address it works. But if domain is a subnet mask like 199.1.*, the
check will also approve addresses like 199.11.12.13 which it should not (.*
will `eat` 1.12.13).

>From a QA standpoint, I do not like it that the code here takes its regex here
directly from the database. The point in the database column is not meant as a
regex wildcard.

My recommendation therefore is that this patch should also correct this regex,
since it directly deals with the if-condition on top of it.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Adrien SAURAT  changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

--- Comment #2 from Adrien SAURAT  2011-12-05 
09:42:18 UTC ---
Two sentences created (a hint and an error message) in the proposed patch, to
be translated.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7013] required format is not enforced for authorized values

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

--- Comment #1 from Adrien SAURAT  2011-12-05 
09:41:17 UTC ---
Created attachment 6577
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6577
proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #3 from Frère Sébastien Marie  2011-12-05 
09:25:37 UTC ---
Does opac/opac-sendshelf.pl should be have a separated bug report ?

As there have same features (send email to someone), corrections (or
enhancements) should be consistent.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #2 from Frère Sébastien Marie  2011-12-05 
09:21:46 UTC ---
Created attachment 6576
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6576
Bug 3280 Restrict Send-basket feature

Here a proposal (should be discussed):
 - permit send basket only for authenticated user
 - permit send basket only if basket contains items
 - use surname, firstname and email of authenticated user for 'To' field (with
fallback to KohaAdminEmailAddress)
 - add field X-Orig-IP with IP of sender
 - add field X-Abuse-Report with KohaAdminEmailAddress

Please comments.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
Version|rel_3_6 |master
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart  2011-12-05 
09:05:20 UTC ---
Why replace https with http ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7020] Items with no checkouts report does not output call number, barcode or item details

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7020

M. de Rooy  changed:

   What|Removed |Added

   Patch Status|Signed Off  |Failed QA

--- Comment #4 from M. de Rooy  2011-12-05 09:04:53 
UTC ---
QA Comment:

Jon or Sophie:
Thanks for your work.
Small note: I see that title still does not appear. In this line:

[% DEFAULT loopro.title="NO TITLE" %]

Please correct that too and it is perfect!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7020] Items with no checkouts report does not output call number, barcode or item details

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7020

M. de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|rel_3_4 |master
 AssignedTo|gmcha...@gmail.com  |ja...@mvwsd.org
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart  changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #6536|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  2011-12-05 
08:50:13 UTC ---
Created attachment 6575
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6575
Proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6132] System preferences are case sensitive

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6132

M. de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Patch Status|Signed Off  |Passed QA
  QAContact|ian.walls@bywatersolutions. |m.de.r...@rijksmuseum.nl
   |com |

--- Comment #7 from M. de Rooy  2011-12-05 08:45:15 
UTC ---
QA: Looks good. Updating patch status.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2616] unnecessary 'use HTML::Template'

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2616

M. de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Patch Status|Needs Signoff   |Passed QA
 AssignedTo|gmcha...@gmail.com  |ian.walls@bywatersolutions.
   ||com

--- Comment #4 from M. de Rooy  2011-12-05 08:26:19 
UTC ---
QA: Updating patch status to Passed QA now too.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2616] unnecessary 'use HTML::Template'

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2616

M. de Rooy  changed:

   What|Removed |Added

   Attachment #6566|0   |1
is obsolete||

--- Comment #3 from M. de Rooy  2011-12-05 08:24:27 
UTC ---
Created attachment 6574
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6574
Signed patch

Signed off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6786] False detection of index names in Search; make index names case insensitive

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6786

--- Comment #11 from M. de Rooy  2011-12-05 08:09:50 
UTC ---
Can and should be applied to 3.6.X too.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/