[Koha-bugs] [Bug 7338] link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Katrin Fischer changed: What|Removed |Added Attachment #6690|0 |1 is patch|| Attachment #6690|application/octet-stream|text/plain mime type|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7338] link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #3 from Frédéric Demians 2011-12-09 07:35:27 UTC --- Created attachment 6690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7338] link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #2 from Katrin Fischer 2011-12-09 06:45:05 UTC --- Created attachment 6689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6689 Bug 7338: Link on serial collection page wrong This was a scoping error. The links are not supposed to show up when you open that page with a subscription id in the URL. To test: 1) Check links don't show up now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7338] link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 --- Comment #1 from Katrin Fischer 2011-12-09 06:38:44 UTC --- Created attachment 6688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6688 screenshot of record with more than 1 subscription and manipulated URL It's a scoping problem, but I made an interesting find: http://localhost:8080/cgi-bin/koha/serials/serials-collection.pl?biblionumber=1 If you have more than one subscription for that record and you add the biblionumber of the subscription to the URL instead of the subscriptionid, you get an overview of your entire serial collection for that record. Why do we never link this page like this? Am I missing something? Will send a patch to fix the scoping problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 --- Comment #24 from Srdjan Jankovic 2011-12-09 04:15:48 UTC --- Please retest. Again, if changing item records zebra needs reindexing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Srdjan Jankovic changed: What|Removed |Added Attachment #6310|0 |1 is obsolete|| --- Comment #23 from Srdjan Jankovic 2011-12-09 04:14:25 UTC --- Created attachment 6687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6687 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #11 from Liz Rea 2011-12-09 01:47:23 UTC --- I think failed QA is ok - except this *is* a partial fix to the problem - neither setting works to limit holds, and both should. So, the question for me becomes - accept this as a partial fix and address the circ rules later (as we i'm sure intended) or forego this patch for a potential future, better patch. I'm not sure what's best. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Ian Walls changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com Version|rel_3_0 |master --- Comment #1 from Ian Walls 2011-12-09 01:25:46 UTC --- The issue of <> tokens not working in digests is due to an ambiguity of what branch to use, and the potential multiplicity of branches that comes with checkouts from multiple branches. The only constant branchcode on a per-notice basis I could see would be the patron's branch. Can anyone think of a case where a different branch's contact information should be parsed into a PREDUEDGST or DUEDGST notice? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Melia Meggs changed: What|Removed |Added CC||me...@bywatersolutions.com Patch Status|Needs Signoff |Failed QA --- Comment #10 from Melia Meggs 2011-12-08 23:56:35 UTC --- With maxreserves sys pref set to allow 100 holds and circ rules set to allow 5 holds (as in Liz's example), I was also able to place 6 holds. So I have changed the status to "Failed QA." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6504] no way to enter shipping price in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6504 --- Comment #16 from Melia Meggs 2011-12-08 23:41:57 UTC --- Created attachment 6686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6686 Receipt Summary after receiving 3 items (with changed shipping cost on the second and third items) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6504] no way to enter shipping price in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6504 --- Comment #15 from Melia Meggs 2011-12-08 23:40:29 UTC --- Created attachment 6685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6685 Shipping on pending orders changes when you receive first item -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6504] no way to enter shipping price in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6504 --- Comment #14 from Melia Meggs 2011-12-08 23:39:37 UTC --- Ok, I did the same testing as last time. 1) Order creation - pass 2) Receiving order I clicked on Receive Shipment and entered a "Shipping Cost" of 10.00. There were 3 items, and the shipping cost was correctly divided up to make it $3.33 for each item. >From the receipt summary I clicked on receive (to the right of the item), and "Freight" is now changed to "Shipping Cost." The $3.33 is already filled in for me here, so this all looks good so far. When I click save, the shipping costs and totals for the Already Received item at the bottom are correct, but I found that the shipping costs for the two pending orders had now changed from $3.33 each to $1.67 each. So originally all pending orders had shipping of $3.33, but after receiving one item, the two pending orders that were left had the shipping changed to $1.67 each. Screenshot attached. This did not happen when I received the second and third items - this time the shipping remained the same. I have attached another screenshot showing the final result after receiving all three items. Then I went back to Budgets & Funds and found that the correct amount has been deducted from the fund, so this part looks good, too. However, the budget remains at $100. So I have to ask this question again in hopes that someone in the community can answer it: If you have a budget of $100 that has a fund of $100, and you spend some money out of the fund, should the same amount also be deducted from the budget? That would make sense to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7332] Translated title (MARC21 field 242) doesn't display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7332 Duncan changed: What|Removed |Added CC||dun...@catalyst.net.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7332] Translated title (MARC21 field 242) doesn't display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7332 Duncan changed: What|Removed |Added Attachment #|0 |1 is obsolete|| --- Comment #2 from Duncan 2011-12-08 23:25:09 UTC --- Created attachment 6684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6684 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Duncan changed: What|Removed |Added CC||dun...@catalyst.net.nz --- Comment #49 from Duncan 2011-12-08 22:34:28 UTC --- (In reply to comment #48) > Created attachment 6683 [details] > Added test coverage for TTParser Meant to add this on the attachment, this test relies on the patch submitted by Chris in comment 47. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #48 from Duncan 2011-12-08 22:33:23 UTC --- Created attachment 6683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6683 Added test coverage for TTParser -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6956] lists printing messed up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6956 Chris Hall changed: What|Removed |Added Status|NEW |RESOLVED CC||chr...@catalyst.net.nz Resolution||FIXED --- Comment #4 from Chris Hall 2011-12-08 22:20:44 UTC --- I can confirm that the lists print correctly (both OPAC and intranet) since the 6291 revert. ~Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #47 from Chris Hall 2011-12-08 22:06:52 UTC --- Created attachment 6682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6682 Patch removes unneeded self=shift from TTParser::unshift_token While Duncan was creating unit tests for TTParser I found an unneeded 'my $self=shift' within TTParser::unshift_token, however ::peep_token and ::next_token do not take a $self argument. No client code uses this so it shouldn't break anything. ~Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #21 from Liz Rea 2011-12-08 22:00:17 UTC --- I'm with Katrin and Chris, I think the tag behavior should be consistent across all notices. Making it different = making it confusing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #20 from Chris Cormack 2011-12-08 21:53:48 UTC --- Hmm, I disagree, I think being consistent is not being more complex, if we use the to mean different things in 2 places in the notices, I think that actually introduces complexity. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #46 from Duncan 2011-12-08 21:21:05 UTC --- Created attachment 6681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6681 Added unit test for Scrubber.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 --- Comment #11 from Chris Hall 2011-12-08 21:18:27 UTC --- Hey Katrin This patch is dependent on 7248 being applied first. On kc/master I am able to apply the 7248 patch and then this one without any errors, does this work for you? Thanks, ~Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What|Removed |Added Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #45 from Chris Cormack 2011-12-08 21:13:45 UTC --- (In reply to comment #37) > Comment on attachment 6622 [details] > [Signed off] Bug 5327: Fixing the Members.t test > > Patch pushed today > > HOWEVER: > Chris, could you explain why BRANCH_IDX now need to be 4 instead of 5 ? Because the branchcode is the 5th (not 6th) element in the array (starts at 0 of course) These two fixes were me fixing tests that others had broken, so hopefully in future I won't be doing this :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6917] Acquisitions reports: Dates filters doesn't work when they are not selected on row or column
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6917 Doug Dearden changed: What|Removed |Added CC|dear...@sarsf.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #44 from Chris Cormack 2011-12-08 21:12:08 UTC --- (In reply to comment #36) > Comment on attachment 6621 [details] > Bug 5327 : Fixing unit test for SQLHelper.pm > > This patch pushed today, HOWEVER: > > Chris, could you explain why you removed the SearchInTable tests and replace > it > by nothing ? > I see it fixes the test, but why are those 2 tests irrelevant now ? Because the SearchInTable function has changed, it does OR, not AND, those tests will never ever pass -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6917] Acquisitions reports: Dates filters doesn't work when they are not selected on row or column
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6917 Doug Dearden changed: What|Removed |Added CC||dear...@sarsf.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6919] Implementing XSLTResultsDisplay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Doug Dearden changed: What|Removed |Added CC||dear...@sarsf.org --- Comment #21 from Doug Dearden 2011-12-08 21:10:54 UTC --- On this line: + OPACDisplay856uAsImage should be changed to Display856uAsImage so it picks up the correct system preference from the Staff Client area instead of the OPAC area. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7330] System preferences editor generates errors in the log with each search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 --- Comment #2 from Liz Rea 2011-12-08 20:55:56 UTC --- Created attachment 6680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6680 Bug 7330 - System preferences editor generates errors in the log with each search Adding a check for an empty value in a couple of places which seem to always get one. As far as I can tell these places in the script are looping over ALL the data in the pref files, and sometimes an empty value comes through. I wonder if this is because of a minor syntax error in the pref file? My correction is a stab in the dark since I haven't determined where the empty value is actually coming from. This change quiets the errors in the log and doesn't seem to affect preference search results. Signed-off-by: Liz Rea No more messages in the logs. Yay! Ran unit tests on this (t, xt/author, xt, t/db_dependent)- nothing out of the ordinary in any. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7330] System preferences editor generates errors in the log with each search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7330] System preferences editor generates errors in the log with each search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7330 Liz Rea changed: What|Removed |Added Attachment #6638|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7341] New: Clicking cancel on system preferences search results causes error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7341 Bug #: 7341 Summary: Clicking cancel on system preferences search results causes error Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client AssignedTo: paul.poul...@biblibre.com ReportedBy: wizzy...@gmail.com QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com Software error: Template process failed: file error - /home/liz/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/HASH(0xa7d8af8).pref: not found at /home/liz/kohaclone/C4/Templates.pm line 125. For help, please send mail to the webmaster (webmaster@koha-deb), giving this error message and the time and date of the error. This happens when you click cancel on a system preferences result listing after a search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #43 from Duncan 2011-12-08 19:58:34 UTC --- Created attachment 6679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6679 Test for AuthoritiesMarc/UNIMARC.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7340] New: emailLibrarianWhenHoldIsPlaced enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7340 Bug #: 7340 Summary: emailLibrarianWhenHoldIsPlaced enhancement Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.h...@gmail.com ReportedBy: s...@metrocast.net QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com This preference currently results in an email to the librarian whenever a hold is placed, even if the hold is placed by staff. I think it would be good to add a preference that excludes those holds, limiting emails to instances where holds are patron-initiated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea changed: What|Removed |Added Priority|PATCH-Sent |P5 - low Patch Status|Patch Pushed|--- Severity|major |trivial --- Comment #10 from Liz Rea 2011-12-08 19:38:23 UTC --- Re-marking as trivial due to the problem with IE - would be nice to get a fix for that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #46 from Chris Cormack 2011-12-08 19:27:12 UTC --- Created attachment 6678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6678 [3.6.x] Bug 6679 : Adding license statement and stopping declaring variables in a conditional -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #45 from Chris Cormack 2011-12-08 19:26:46 UTC --- Created attachment 6677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6677 [3.6.x] Bug 6679 : cataloguing/ now passing critic tests Declare variables outside of conditionals Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html Use ":encoding(UTF-8)" to get strict validation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #44 from Chris Cormack 2011-12-08 19:26:14 UTC --- Created attachment 6676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6676 [3.6.x] Bug 6679: catalogue/ now passing perl critic tests Signed-off-by: Paul Poulain -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #43 from Chris Nighswonger 2011-12-08 19:14:15 UTC --- (In reply to comment #41) > Which patches chris_n .. they have been marked obsolete and I have lost track > of them, > > If you list the ones you need ill rebase them. Here are the commit ids: 4a14e7dbe69db0517d1d333a644c4abeb0a42cb8 a047dea5e46338d3d664935451764fffe56e6d9e dc6e1031f8c2aa36e88ca39a70c5b7d9fd63065d -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7339] Help System in IE8-9 Does Not Load With 500 Error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339 --- Comment #3 from lzua...@collsk12.org 2011-12-08 18:23:21 UTC --- Help system will open if right-clicked and opened in new tab or new window, but not directly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7339] Help System in IE8-9 Does Not Load With 500 Error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339
--- Comment #2 from Owen Leonard 2011-12-08 18:21:18 UTC
---
Template process failed: file error -
/koha-tmpl/intranet-tmpl/prog/en/modules/help/.tt: not found at
/C4/Templates.pm line 125.
For help, please send mail to the webmaster (webmaster@oleonard-desktop),
giving this error message and the time and date of the error.
Software error:
[Thu Dec 8 13:19:38 2011] help.pl: Template process failed: file error -
e/koha-tmpl/intranet-tmpl/prog/en/modules/help/.tt: not found at
/C4/Templates.pm line 125.
at /usr/share/perl/5.12/CGI/Carp.pm line 354
CGI::Carp::realdie('[Thu Dec 8 13:19:38 2011] help.pl: Template process
failed: ...') called at /usr/share/perl/5.12/CGI/Carp.pm line 446
CGI::Carp::die('Template process failed: ',
'Template::Exception=ARRAY(0x8bedbd0)') called at /C4/Templates.pm line 125
C4::Templates::output('C4::Templates=HASH(0x8b40064)') called at /help.pl
line 42
For
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7339] Help System in IE8-9 Does Not Load With 500 Error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339 Owen Leonard changed: What|Removed |Added Component|Staff Client|Browser compatibility Version|rel_3_6 |master --- Comment #1 from Owen Leonard 2011-12-08 18:20:26 UTC --- Confirmed in master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7339] New: Help System in IE8-9 Does Not Load With 500 Error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339 Bug #: 7339 Summary: Help System in IE8-9 Does Not Load With 500 Error Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: PC OS/Version: Windows Status: NEW Severity: critical Priority: P5 - low Component: Staff Client AssignedTo: paul.poul...@biblibre.com ReportedBy: lzua...@collsk12.org QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com When attempting to load the help system [?], I receive a 500 error from both IE8 and IE9 on two different library systems/servers. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off QAContact|koha-b...@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Cormack changed: What|Removed |Added Attachment #6670|0 |1 is obsolete|| --- Comment #42 from Chris Cormack 2011-12-08 18:04:41 UTC --- Created attachment 6675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6675 Bug 6679: fix missing use strict The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it 4XX.pl also has some perlcritic fixes: Variable declared in conditional statement at line XXX, column 9. Declare variables outside of the condition. (Severity: 5) Signed-off-by: Chris Cormack -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #41 from Chris Cormack 2011-12-08 17:57:27 UTC --- Which patches chris_n .. they have been marked obsolete and I have lost track of them, If you list the ones you need ill rebase them. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added Attachment #6671|1 |0 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added Attachment #6673|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 --- Comment #6 from Liz Rea 2011-12-08 17:49:26 UTC --- Created attachment 6674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6674 [Signed off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. Revision adds missing handling of debarred status with regard to renewal operations. Renew links and buttons were not being hidden from debarred users. Signed-off-by: Liz Rea Renewal buttons are gone, message looks good. liz@koha-deb:~/kohaclone$ prove xt xt/permissions.t .. ok xt/tt_valid.t . ok All tests successful. Files=2, Tests=27, 9 wallclock secs ( 0.05 usr 0.01 sys + 8.28 cusr 0.08 csys = 8.42 CPU) Result: PASS -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Owen Leonard changed: What|Removed |Added Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Owen Leonard changed: What|Removed |Added Attachment #6671|0 |1 is obsolete|| --- Comment #5 from Owen Leonard 2011-12-08 17:36:50 UTC --- Created attachment 6673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6673 Revised fix Revision adds missing handling of debarred status with regard to renewal operations. Renew links and buttons were not being hidden from debarred users. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7028] koha-conf.xml template that comes with the packages needs updating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7028 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #3 from Paul Poulain 2011-12-08 16:52:01 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7338] New: link to serial detail wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7338 Bug #: 7338 Summary: link to serial detail wrong Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/serials/serials-collection.pl?subscripti onid=5427 OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Serials AssignedTo: colin.campb...@ptfs-europe.com ReportedBy: neng...@gmail.com QAContact: ian.wa...@bywatersolutions.com Created attachment 6672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6672 subscription # links When on this page: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=5427 if you click the serial # at the top it takes you to the detail which I think is right. But if you click the serial # next to the issue history it just refreshes the page you're on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6865] Replace image-based gradient backgrounds with CSS3 gradients
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6865 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #4 from Paul Poulain 2011-12-08 16:42:22 UTC --- QA comment: it's worth having another signoff from someone that tested the OPAC under IE -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6818] acquisitions basket groups could use some design work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain 2011-12-08 16:40:07 UTC --- QA comment: * templates still passing tests : prove xt/author/valid-templates.t says xt/author/valid-templates.t .. ok All tests successful. Files=1, Tests=672, 38 wallclock secs ( 0.31 usr 0.01 sys + 36.97 cusr 0.50 csys = 37.79 CPU) Result: PASS * template only markup * there was a tiny merge conflict I solved (an added empty line) passed QA Patch pushed, please test Chris_n = no change in the workflow, but important changes in the design (for more consistency though). I would not object any decision (merging in 3.6 or no), both are debatable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added Attachment #6668|0 |1 is obsolete|| --- Comment #4 from Liz Rea 2011-12-08 16:32:40 UTC --- Comment on attachment 6668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6668 [Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year Found a problem with the template renewing books for debarred patrons. Owen says he'll revise and I'll provide a new signoff. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 --- Comment #3 from Liz Rea 2011-12-08 16:31:55 UTC --- Created attachment 6671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6671 Bug 7337 - Followup - Correcting instances of "debar" that crept back in. To test: Restrict one of your patrons - Make sure that on memberentrygen.tt (Edit Patron) the radio button label says "Restricted" Make sure that on moremember.tt (Patron detail) the button to lift debarment says "Restricted" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7014] sorting of call numbers in Inventory tool is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7014 Cindy Murdock Ames changed: What|Removed |Added CC||cmurd...@ccfls.org --- Comment #1 from Cindy Murdock Ames 2011-12-08 16:20:32 UTC --- I'm seeing this in 3.4 also, but for me it's listing the ones without decimal points first. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7336] memberentry.pl generates an error in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7336 Ian Walls changed: What|Removed |Added Patch Status|Needs Signoff |Passed QA --- Comment #2 from Ian Walls 2011-12-08 16:14:38 UTC --- Trivial fix to quite logs. Signing off and passing QA in a go. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #40 from Paul Poulain 2011-12-08 16:14:24 UTC --- Created attachment 6670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6670 Bug 6697: fix missing use strict The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it 4XX.pl also has some perlcritic fixes: Variable declared in conditional statement at line XXX, column 9. Declare variables outside of the condition. (Severity: 5) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7336] memberentry.pl generates an error in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7336 Owen Leonard changed: What|Removed |Added AssignedTo|kyle.m.h...@gmail.com |oleon...@myacpl.org --- Comment #1 from Owen Leonard 2011-12-08 16:12:09 UTC --- Created attachment 6669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6669 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Chris Nighswonger changed: What|Removed |Added CC||cnighswon...@foundations.ed ||u --- Comment #39 from Chris Nighswonger 2011-12-08 16:11:50 UTC --- The latest round of patches for this bug do not apply cleanly to 3.6.x. Please attach corrected patches to this bug report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7336] memberentry.pl generates an error in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7336 Owen Leonard changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Liz Rea changed: What|Removed |Added Attachment #6667|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 --- Comment #2 from Liz Rea 2011-12-08 15:43:30 UTC --- Created attachment 6668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6668 [Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. Signed-off-by: Liz Rea I like this change, nice fix for the bug. Thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Owen Leonard changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Version|rel_3_8 |master Patch Status|--- |Needs Signoff Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 --- Comment #1 from Owen Leonard 2011-12-08 15:25:43 UTC --- Created attachment 6667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6667 Proposed fix This patch copies the debarred handling method from circulation.pl for use on opac-user.pl so that debarred dates and comments can be handled properly. I have slightly reworded the message in the OPAC and on circulation.pl to make the display of the debarred comment a little clearer. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7093] Placeholders for suggestion table in suggestion related mails broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Ian Walls changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #4 from Ian Walls 2011-12-08 15:23:34 UTC --- Assigning to Marcel for QA, since I wrote -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7337] New: "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7337 Bug #: 7337 Summary: "Debarred Until" display in the opac tells patrons they are debarred until the year Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: oleon...@myacpl.org ReportedBy: wizzy...@gmail.com QAContact: ian.wa...@bywatersolutions.com When you debar a patron, and then log in to the opac as that patron, the patron is told their account is restricted until the year . See screenshot: http://screencast.com/t/QKvVMFzTbi -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 Francois Charbonnier changed: What|Removed |Added CC||francois.charbonnier@biblib ||re.com --- Comment #19 from Francois Charbonnier 2011-12-08 14:24:41 UTC --- Hi Katrin, To me, your proposition introduce complexity. It looks like you are focusing on the idea of "item" vs "biblios" but actually, to me, it's a distinction that we can do because we know the database structure. But on a librarian perspective, I order a book and I claim a book. Either way, I buy or claim a physical document and i don't make any difference if the information comes from the biblio or the item table. At the end, it's just a list of documents (items) that i want. It can be books that I bought or overdue books... So, I think it's easier to handle only one tag. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7332] Translated title (MARC21 field 242) doesn't display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7332 Jared Camins-Esakov changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7332] Translated title (MARC21 field 242) doesn't display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7332 --- Comment #1 from Jared Camins-Esakov 2011-12-08 14:21:44 UTC --- Created attachment --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id= Bug 7332: Translated title (MARC21 242) not shown The cataloger-supplied translated title stored in MARC21 field 242 was not being displayed when XSLT was enabled. Test plan: 1) Enable XSLT for OPAC Details and Results, and Intranet Details. 2) Create or add a record with a 242 field 3) See that the translated title is not displayed in OPAC Details or Results, or Intranet Details 4) Apply patch 5) See that the translated title is now displayed in OPAC Details and Results, and Intranet Details -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #7 from Paul Poulain 2011-12-08 14:18:55 UTC --- (In reply to comment #6) > I also checked with NYTProf > * with YAML = Profile of mainpage.pl for 1.97s (of 2.58s), executing 201727 > statements and 52079 subroutine calls in 253 source files and 63 string evals. > * with XML = Profile of mainpage.pl for 1.97s (of 2.60s), executing 201727 > statements and 52079 subroutine calls in 253 source files and 63 string evals. > > still investigating, there must be something wrong... OK, I was testing twice with XML (forgot to update env variable) Here is the result: * with YAML: Profile of mainpage.pl for 1.92s (of 2.37s), executing 144420 statements and 33523 subroutine calls in 246 source files and 62 string evals. * with XML = Profile of mainpage.pl for 1.97s (of 2.60s), executing 201727 statements and 52079 subroutine calls in 253 source files and 63 string evals. it result in a *big* lowering of the number of statements executed, but not a big change in the duration of the page. If someone has an idea why... Looking at the details of NYTProf, I see: * 262ms is spent in XMLin (XML version) * 1.20ms is spent in YAML::Syck::LoadFile (YAML version) That's a 260ms difference, why don't we see it in the benchmark and/or in the total duration of mainpage reported by NYTProf -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6919] Implementing XSLTResultsDisplay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6919 Owen Leonard changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #20 from Owen Leonard 2011-12-08 14:09:34 UTC --- *** Bug 4813 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4813] implement XSLTResultsDisplay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4813 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Owen Leonard 2011-12-08 14:09:34 UTC --- *** This bug has been marked as a duplicate of bug 6919 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7336] New: memberentry.pl generates an error in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7336
Bug #: 7336
Summary: memberentry.pl generates an error in the log
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Patrons
AssignedTo: kyle.m.h...@gmail.com
ReportedBy: oleon...@myacpl.org
QAContact: ian.wa...@bywatersolutions.com
CC: gmcha...@gmail.com
Use of uninitialized value $data{"debarred"} in string ne at
/members/memberentry.pl line 652.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7331] Circulation.pl generates errors in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7331 Owen Leonard changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off AssignedTo|kyle.m.h...@gmail.com |dun...@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7331] Circulation.pl generates errors in the log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7331 Owen Leonard changed: What|Removed |Added Attachment #6654|0 |1 is obsolete|| --- Comment #6 from Owen Leonard 2011-12-08 13:54:40 UTC --- Created attachment 6665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6665 Signed-off patch Quick work, thank you! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7335] New: Allow custom parameters for sorting in sql reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335 Bug #: 7335 Summary: Allow custom parameters for sorting in sql reports Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports AssignedTo: gmcha...@gmail.com ReportedBy: katrin.fisc...@bsz-bw.de QAContact: ian.wa...@bywatersolutions.com I was trying to find a solution to make it possible to select how a report is sorted before running it. Perhaps we could have a table sorter on tables generated by reports? I tried using the placeholders to provide a pull down with search options, but this didn't work. The replaced text is always in quotes, so the generated sql will not work: select concat(surname, ", ", firstname) as Name, cardnumber from borrowers order by 'cardnumber desc' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6956] lists printing messed up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6956 Ian Walls changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com --- Comment #3 from Ian Walls 2011-12-08 13:35:26 UTC --- Can anyone confirm is the reversion of 6291 has fixed this issue? I have a suspicion that it might. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #6 from Paul Poulain 2011-12-08 13:32:17 UTC --- I've tested ian script with misc/load_testing/benchmark_staff.pl, here are the results: (1st column with XML, 2nd column with YAML. Numbers are in ms, less is better) 23709|22453 30049|30749 27487|26463 52924|50355 35922|29679 33168|30388 The improvement is surprisingly low. Also note xsltproc xml2yaml.xsl koha-conf.xml returned nasty results, and I had to build the yaml manually, here is what it look like: db_scheme: mysql database: hostname: localhost port: 3306 user: XX pass: XX biblioserver: biblios biblioservershadow: 1 authorityserver: authorities authorityservershadow: 1 intranetdir: /home/paul/koha.dev/koha-community opacdir: /home/paul/koha.dev/koha-community/opac opachtdocs: /home/paul/koha.dev/koha-community/koha-tmpl/opac-tmpl intrahtdocs: /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl includes: /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/en/includes/ logdir: /home/paul/koha.dev/installs/lecannetdesmaures/var/log install_log: home/paul/koha.dev/installs/lecannetdesmaures/misc/koha-install-log useldapserver: 0 I also checked with NYTProf * with YAML = Profile of mainpage.pl for 1.97s (of 2.58s), executing 201727 statements and 52079 subroutine calls in 253 source files and 63 string evals. * with XML = Profile of mainpage.pl for 1.97s (of 2.60s), executing 201727 statements and 52079 subroutine calls in 253 source files and 63 string evals. still investigating, there must be something wrong... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 --- Comment #4 from M. de Rooy 2011-12-08 12:42:30 UTC --- I have created a page on the wiki for the results of this discussion on the mailing list about improving list permissions. See: http://wiki.koha-community.org/wiki/List_permissions Will add a section there to describe the patches implementing this change. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7281] Hide some lists (virtual shelves) from OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7281 M. de Rooy changed: What|Removed |Added Status|ASSIGNED|RESOLVED See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7310 Blocks|7310| Resolution||WONTFIX --- Comment #2 from M. de Rooy 2011-12-08 12:21:43 UTC --- Closing this report. Patches for bug 7310 will resolve this too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 M. de Rooy changed: What|Removed |Added Depends on|7281| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 --- Comment #18 from Katrin Fischer 2011-12-08 12:00:55 UTC --- :) Let me explain 4) ODUE notices gives you item information. You can also display the title information, but it's one line per item. The ACQCLAIM gives you one line per ordered title and you can't display item information in there yet. (And it would only make sense for libraries using AcqCreateItem = on order anyway) But if we keep the "1 line per title" and "1 line per item" in separate tags, we could perhaps later have a construct like: <> <>. And it would be always clear if you get a list of records, or a list of items. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 Jonathan Druart changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5347] late order management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347 Jonathan Druart changed: What|Removed |Added Attachment #6634|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart 2011-12-08 11:41:18 UTC --- Created attachment 6664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6664 Proposed patch Hi Katrin, 1/ 2/ Ok, it's fixed 3/ Ok, I modified */sample_notices.sql by adding tag 4/ I use tag because this tag already exists in koha (misc/cronjobs/overdue_notices.pl and 'ODUE' notices). I think it's better to keep a general term to simplify things. > Sorry for not spotting those things earlier :( No problem, I can do everything for chocolate ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7259] Show a count of items pending approval on staff client home and tools pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #7 from Paul Poulain 2011-12-08 11:07:20 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7116] Item form when ordering in batch from staged marc has lots of white space for hidden fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7116 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #5 from Paul Poulain 2011-12-08 10:53:42 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7083] Show creator name on list of public lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7083 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #6 from Paul Poulain 2011-12-08 10:50:20 UTC --- patch pushed, please test Chris_n this is an enhancement, but don't change the workflow, change only for staff, so OK for 3.6 imo -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7020] Items with no checkouts report does not output call number, barcode or item details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7020 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #9 from Paul Poulain 2011-12-08 10:27:58 UTC --- Patch pushed, please test (and welcome Jon Aker, you're our 164th contributor !) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6987] C4::Overdues::GetFine returns inconsistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6987 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|unspecified |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #4 from Paul Poulain 2011-12-08 10:20:16 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What|Removed |Added Attachment #6271|0 |1 is obsolete|| --- Comment #38 from Paul Poulain 2011-12-08 09:38:20 UTC --- Comment on attachment 6271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6271 Fixing critic complaint: Don't change $_ in a list context patch already applied (bug 7207) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What|Removed |Added Attachment #6270|0 |1 is obsolete|| --- Comment #37 from Paul Poulain 2011-12-08 09:37:49 UTC --- Comment on attachment 6270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6270 Reverting lines which break label-print.pl patch already applied (bug 7207) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What|Removed |Added Attachment #6663|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #36 from Paul Poulain 2011-12-08 09:34:34 UTC --- Comment on attachment 6663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6663 Bug 6679 : Allowing eval require patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What|Removed |Added Attachment #6139|0 |1 is obsolete|| --- Comment #35 from Paul Poulain 2011-12-08 09:34:24 UTC --- Comment on attachment 6139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6139 Bug 6679 : Adding license statement and stopping declaring variables in a conditional patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What|Removed |Added Attachment #6123|0 |1 is obsolete|| --- Comment #34 from Paul Poulain 2011-12-08 09:34:10 UTC --- Comment on attachment 6123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6123 Bug 6679 : cataloguing/ now passing critic tests patch pushed. trying to prove cataloguing show me some errors in plugins though: prove t/00-testcritic.t t/00-testcritic.t .. 196/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/stocknumber.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/stocknumber.pl": # Code before strictures are enabled at line 30, column 1. See page 429 of PBP. (Severity: 5) t/00-testcritic.t .. 239/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/unimarc_field_210c.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/unimarc_field_210c.pl": # Code before strictures are enabled at line 40, column 1. See page 429 of PBP. (Severity: 5) # Variable declared in conditional statement at line 113, column 9. Declare variables outside of the condition. (Severity: 5) t/00-testcritic.t .. 243/246 # Failed test 'Test::Perl::Critic for "cataloguing/value_builder/unimarc_field_4XX.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "cataloguing/value_builder/unimarc_field_4XX.pl": # Variable declared in conditional statement at line 272, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 286, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 292, column 9. Declare variables outside of the condition. (Severity: 5) # Variable declared in conditional statement at line 377, column 13. Declare variables outside of the condition. (Severity: 5) t/00-testcritic.t .. 245/246 # Looks like you failed 3 tests of 246. I think it's worth activating the test (it's better to have a test showing something is wrong than doing no test and thinking things are OK ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
