[Koha-bugs] [Bug 6145] ModBiblio double encoding items information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6145 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6145] ModBiblio double encoding items information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6145 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-03 09:04:14 UTC --- Not sure this problem still exists in master. Patch still applies according to Julian, so we should try to reproduce the bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6145] ModBiblio double encoding items information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6145 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|rel_3_2 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03 10:31:09 UTC --- Created attachment 7025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7025 proposed patch Displays description for copynumber (staff and OPAC) + corrects a small bug which was generating error messages in logs + corrects indentations -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-03 10:36:42 UTC --- I am not sure about the indentation changes - it makes it hard to read your patch and spot the real changes. I think in the past it was said to do things like this in a separate patch (http://wiki.koha-community.org/wiki/Coding_Guidelines#Refactoring_Code) Not sure how we want to handle this now - perhaps a question for the QA team? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379
--- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03
10:51:25 UTC ---
Well, refactoring could take some time and is not necessarily useful. Indenting
is quick to do and makes the file more readable (but the patch far less
readable indeed).
I'll follow any line, but it needs to be clear, Chris told me a few weeks ago
that it was good to enhance the code whenever possible without creating new
bugs for this.
==
I'll help you read this patch.
I used the same code already used for ccode, adding this in opac-detail.pl :
my $copynumbers =
GetKohaAuthorisedValues('items.copynumber',$dat-{'frameworkcode'}, 'opac');
...
if ( my $copynumber = $itm-{'copynumber'} ) {
$itm-{'copynumber'} = $copynumbers-{$copynumber} if (
defined($copynumbers) exists( $copynumbers-{$copynumber} ) );
}
and this in detail.pl :
my $copynumbers = GetKohaAuthorisedValues('items.copynumber', $fw);
...
my $copynumber = $item-{'copynumber'};
$item-{'copynumber'} = $copynumbers-{$copynumber} if ( defined(
$copynumber ) defined($copynumber) exists( $copynumbers-{$copynumber} )
);
==
Next time I'll try to modify only the code surrounding the bug fix.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #4 from Magnus Enger mag...@enger.priv.no 2012-01-03 10:53:56 UTC --- I think there is some relevant advice here: http://wiki.koha-community.org/wiki/Perltidy We just need to figure out what a code block is... ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-03 11:00:35 UTC --- Magnus: agreed :) For the record, meeting minutes and decided style: http://librarypolice.com/koha-meetings/2011/koha.2011-10-05-10.00.html AGREED: perl-style (Brooke, 12:37:05) I also discovered the bugzilla 'Diff' view is quite helpful to spot the real changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 --- Comment #6 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 11:25:01 UTC --- This works fine on the admin side. On the OPAC side however, it doesn't work when the authorized value is 0. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #25 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-03 12:09:26 UTC --- branchcode is part of the primary key and it belongs to the top. I'm not sure what the policy is for field moving (application should not care about the field position). I can put it back if moving it is a problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-03 12:30:26 UTC --- I don't like the idea much of having a difference in the database structure between older and newer installations of Koha. I am not sure there are other/better reasons for doing or not doing it. Perhaps someone else can comment on this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #7025|0 |1 is obsolete|| --- Comment #7 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03 13:07:38 UTC --- Created attachment 7026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7026 proposed patch #2 Corrected. Works on Staff/OPAC even if value is 0. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 --- Comment #8 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 13:15:21 UTC --- The 0 problem is solved! I discovered a new one though : on the items tab on the admin interface the informations are displayed in a different layout, this still displays the authorised value and not it's description. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Patch Status|Signed Off |Failed QA --- Comment #8 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 13:40:29 UTC --- I turns out there are actually two search forms on the admin side concerned with this issue. (Maybe more?) From the home of the admin interface, there is a quick search field and a link to advanced search, both using the same search which is now fixed. But in the cataloguing section it is a different search. The patch needs to fix this part too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Attachment #7016|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #7014|0 |1 is obsolete|| --- Comment #9 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03 14:32:41 UTC --- Created attachment 7027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7027 proposed patch #3 Modifies also the addbooks result page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #10 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 14:43:59 UTC --- Created attachment 7028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7028 [SIGNED-OFF] Works beautifully! Bug 6374: default value for Size in result pages When no size info is available, an empty string is sent to the TT (if nothing is sent, the TT engine will display another information, irrelevant for Koha). Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7286] fix rebuild_zebra.pl to add rebuild_zebra_sliced.zsh
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com 2012-01-03 15:14:28 UTC --- It looks like a wrapper to the rebuild_zebra.pl script to filter the records being indexed by 'where' clauses or caount limits. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #7026|0 |1 is obsolete|| --- Comment #9 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03 15:41:26 UTC --- Created attachment 7029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7029 proposed patch #3 Handles now the page moredetail (items). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6000] Performance enhancements for C4::Context and C4::Languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 --- Comment #10 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 16:07:46 UTC --- Created attachment 7030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7030 [SIGNED-OFF] Works on the OPAC and in the admin, both in normal and item view. Bug 7379: display of copynumber description The biblio/items detail pages display the copynumber description if an authorized value is configured accordingly. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] New: Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 Bug #: 7399 Summary: Holds Queue should show reserve notes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P4 Component: Hold requests AssignedTo: ian.wa...@bywatersolutions.com ReportedBy: ian.wa...@bywatersolutions.com QAContact: ian.wa...@bywatersolutions.com CC: gmcha...@gmail.com While the notes from the hold request are processed into the tmp_holdsqueue table by misc/cronjobs/holds/build_holds_queue.pl, they are not displayed in the staff client interface. If staff have gone through the trouble of adding notes, it would be valuable to display them here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 --- Comment #1 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-03 17:06:20 UTC --- Created attachment 7031 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7031 Proposed Patch Adds Notes column to view_holdsqueue.pl table, on the far right. If the reserve in question has a note, it will display here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Priority|P4 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3430] Title matches in OPAC - need to remove control from OpacHighlightedWords preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3430 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Owen Leonard oleon...@myacpl.org 2012-01-03 18:11:14 UTC --- I see markup related to this still in the template but no related code. [% IF ( SEARCH_RESULT.searchhighlightblob ) %]span class=results_summaryspan class=labelMatch:/span [% SEARCH_RESULT.searchhighlightblob %]/span[% END %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7394] Broken detail page for last link from result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-03 18:31:57 UTC --- Moves code to different area of script to avoid scoping issues. Fixes issue without introducing any new complexities. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7031|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard neng...@gmail.com 2012-01-03 19:48:27 UTC --- Created attachment 7032 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7032 [SIGNED-OFF] Bug 7399: Holds Queue should show reserve notes The notes for a specific hold, if they existed, were being added to the tmp_holdsqueue table by build_holds_queue.pl, but they were not displayed anywhere, which seems a waste. This patch adds the Notes column to the far right of view_holdsqueue.pl. To Test: Place a hold with a note Run build_holds_queue.pl to place it in the Holds Queue View the Holds Queue; you should see the note on the far right of the table Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Attachment #6891|0 |1 is obsolete|| --- Comment #9 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-03 20:12:07 UTC --- Created attachment 7033 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7033 Revised Patch Fixes bug with my original patch; was using a hashref in scalar context. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7399] Holds Queue should show reserve notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7399 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added QAContact|ian.walls@bywatersolutions. |jonathan.dru...@biblibre.co |com |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #26 from Paul Poulain paul.poul...@biblibre.com 2012-01-03 21:42:27 UTC --- QA comment: 1 this patch adds a lot of reindentation, he's quite hard to read. But those indentations are needed, so it's OK 2 prove t/00-perlcritic.t is OK 3 prove xt/author/valid-templates.t is OK 4 the patch works if XSLT is ON. With XSLT OFF there is no difference before and after applying the patch. 5 about the removed numbering, which one is it. On my setup test I still see a numbering after each item, for example: Availability: Copies available for loan: Médiathèque Cannet des Maures[800] (43). Copies available for reference: Médiathèque Cannet des Maures[800] (1). Checked out (2). Marking failed QA until I've some feedback for points 4 and 5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #7018|0 |1 is obsolete|| --- Comment #27 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-03 23:54:58 UTC --- Created attachment 7034 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7034 patch I've put the field back where it was. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6829] Remove two warnings for opac-MARCdetail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #5257|0 |1 is obsolete|| Attachment #6931|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-04 06:49:21 UTC --- Created attachment 7035 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7035 [SIGNED-OFF] Bug 6829 Follow up patch To reproduce the bug: - Open OPAC MARC View for a specific biblio record - Fields which are affected to tab 0 are all hidden Signed-off-by: Katrin Fischer katrin.fischer...@web.de Patch fixes bug for 0xx fields in OPAC MARC view. Note: the problem only exists for 0xx fields with real subfields, control fields display correctly, fields like 040 only display after patch was applied. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6829] Remove two warnings for opac-MARCdetail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6829] Remove two warnings for opac-MARCdetail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch Status|Needs Signoff |Failed QA --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-04 07:15:15 UTC --- Hi srdjan, thx for your new patch. The database updates and changes are all ok now. I found another problem though when I was trying to configure my installaton for testing: Your patch removes the OPACItemHolds system preference from .../prog/en/modules/admin/preferences/opac.pref. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
