[Koha-bugs] [Bug 7433] New: french translation add a bad single quote into js function

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433

 Bug #: 7433
   Summary: french translation add a bad single quote into js
function
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: rel_3_6
  Platform: All
OS/Version: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
AssignedTo: frede...@tamil.fr
ReportedBy: stephane.dela...@biblibre.com
 QAContact: ian.wa...@bywatersolutions.com


in staff, the french version of cgi-bin/koha/tools/stage-marc-import.pl have
this line into a javascript's function : 

alert(_('Echec de l'envoi du formulaire : ') + textStatus);

(original text : alert(_('Failed to submit form: ') + textStatus);)

the single quote isn't escaped

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7433] french translation add a bad single quote into js function

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433

stephane.dela...@biblibre.com changed:

   What|Removed |Added

URL||cgi-bin/koha/tools/stage-ma
   ||rc-import.pl

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7433] french translation add a bad single quote into js function

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 AssignedTo|frede...@tamil.fr   |stephane.delaune@biblibre.c
   ||om

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7433] french translation add a bad single quote into js function

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433

--- Comment #1 from stephane.dela...@biblibre.com 2012-01-10 14:17:33 UTC ---
Created attachment 7103
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7103
fix 7433

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7433] french translation add a bad single quote into js function

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

--- Comment #2 from stephane.dela...@biblibre.com 2012-01-10 14:22:28 UTC ---
to test  : misc/translator$ ./translate install fr-FR
select fr-FR on language syspref
go to cgi-bin/koha/tools/stage-marc-import.pl
import a file (clic on Télécharger fichier) and clic on traiter pour import
if it works, it's ok

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5877] Offline circulation improvements : upload all files, apply at once

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5877

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch Status|Signed Off  |Needs Signoff

--- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 14:52:29 
UTC ---
Before starting QA, I would say that a patch of this size needs external
signoff. From the comments I understand that several tested, but nobody signed
off until now..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

--- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-10 
14:55:14 UTC ---
Created attachment 7104
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7104
proposed patch

Ensures that :
- name is not a space only string
- name is unique 
- name does not contain quotation marks

All controls on client side (JavaScript alert).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7348] Fix error in IE where the serials toolbar buttons do not show.

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7348

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch Status|Signed Off  |Passed QA
  QAContact|ian.walls@bywatersolutions. |m.de.r...@rijksmuseum.nl
   |com |

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 14:58:05 
UTC ---
QA: Trivial change eliminating one comma. Updating status.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6694] Anonymous sessions not kept when casAuthentication is on

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6694

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 15:05:14 
UTC ---
QA Question: I did not dive into the cas specs (yet..) but does anyone of you
know some external users of cas willing to test/sign this (small) patch too?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #25 from Liz Rea wizzy...@gmail.com 2012-01-10 15:06:55 UTC ---
apologies - I found the NoticeCSS - it was under my nose and I didn't see it.
Sorry!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch Status|Signed Off  |Passed QA
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #94 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 15:08:42 
UTC ---
QA: Documentation changes only. OK

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7426] Let koha-mysql pass on SQL to mysql -e

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7426

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #2 from Magnus Enger mag...@enger.priv.no 2012-01-10 15:12:48 UTC 
---
Ah, yes, I had a hunch there was something I was missing. Marking as
resolved/wontfix.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7342] aqbudgets statistics doesn't work when using Authorized values on sort1_authcat or sort2_authcat

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7342

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 15:19:22 
UTC ---
Just a (dumb) question: Patch creates a new script, but where does Koha call
it? Couldn't see that just browsing through..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7127] Templates must be valid XHTML

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch Status|Signed Off  |Passed QA
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-01-10 15:21:34 
UTC ---
QA: Looks good. Updating status..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7434] New: Display of issue number for serials in overdues

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434

 Bug #: 7434
   Summary: Display of issue number for serials in overdues
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
AssignedTo: kyle.m.h...@gmail.com
ReportedBy: adrien.sau...@biblibre.com
 QAContact: ian.wa...@bywatersolutions.com
CC: gmcha...@gmail.com


The overdue listing could be enhanced by displaying the issue number for serial
results.

For example,
Géo, by Axel Ganz
would become:
Géo, by Axel Ganz, No. 379

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7434] Display of issue number for serials in overdues

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|kyle.m.h...@gmail.com   |adrien.sau...@biblibre.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7434] Display of issue number for serials in overdues

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-10 
16:35:26 UTC ---
Hmm, I am surprised that it's not possible - but on the other hand have never
tried to do it.

We have 2 different syntax for item information in overdues. 
In theory this should work:

itemitems.enumchron/item 

or

items.content + Cronjob with enumchron specified in the field list

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4877] Create and update the manual pages for the koha-* scripts.

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   Priority|PATCH-Sent  |P3
   Severity|enhancement |normal

--- Comment #39 from Magnus Enger mag...@enger.priv.no 2012-01-10 17:11:28 
UTC ---
The manual pages work in current master, but I can't find a manual page for
koha-run-backups, so I'm resetting the status of this bug.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5877] Offline circulation improvements : upload all files, apply at once

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5877

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

--- Comment #26 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
20:46:54 UTC ---
Marcel, it seems Sophie made a mistake when signing off the patch: i'm the
author of the patch (see obsoletes), Sophie just signed it off. I don't know
why she appears as the author !

going back to signed off for QA, thx

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #26 from Liz Rea wizzy...@gmail.com 2012-01-10 21:32:35 UTC ---
More notes:

* Notices on the Tools page should probably be Notices and Slips or
Notices and Receipts.
* News items for slips are still global, but not in the scope of this dev.
Needs to be fixed, just making a note.
* WORKS: Copy notice - works like I expect re: library selection, nice.
* Which code, if any, is used for the Print Page template?
* it would be nice to have an explicit indication of which entries are a
notice and which are slips - I know it should be clear from the code name,
but it could be clearer.
* How do you add the borrower extended attribute to the notice? I don't see it
under the Borrowers section.
* Preview slip/notice might be nice, but probably beyond the scope of this dev.
Just making a note.
* I wonder about the utility of New Notice at all - if we can only define
notices within the codes in the default data (is that true?) then copying them
from the defaults is probably the easiest way to go. Or, make the code field a
drop down to select the type of notice so one doesn't mess up and put a quick
slip under the cataloging module (like I did in my testing because I wasn't
paying attention).
* WORKS: Checkout slips and quick slips work both in html mode and plain text
mode for multiple branches. 

On to email notices!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7278] In the items table, make items.materials of type text, and show its contents at circulation

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7278

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8
   Patch Status|Passed QA   |Patch Pushed

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
22:00:47 UTC ---
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok 

prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. ok   

patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5503] comments shouldn't show patron's full name

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Passed QA   |Failed QA

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
22:23:45 UTC ---
QA comment 
Well, it seems this patch has not be tested. When upgrading, I get a mySQL
error:

[Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You
have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 's identity is presented
alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at
/home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line
4610.
[Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You
have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 's identity is presented
alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at
/home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line
4611.


Looking at the code, I see :
$dbh-do( UPDATE  `koha`.`systempreferences` SET  `value` =  'none',
`options` =  'none|full|first|surname|firstandinitial|username', `explanation`
=  'Choose how a commenter\'s identity is presented alongside comments in the
OPAC', `type` =  'Choice' WHERE  `systempreferences`.`variable` = 
'ShowReviewer' AND `systempreferences`.`variable` = 0);

Should be commenter''s I think.

Also note, as you'll have to send a follow-up that ` should be removed from
table  column names, it's a mysql-ism

thx

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5543] Date ISO format wrong separator

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
22:31:24 UTC ---
Patch pushed, please test

(removed the updatedatabase stuff, that is useless

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2629] Diacritics not being ignored when searching

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6171|0   |1
is obsolete||

--- Comment #37 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
22:34:59 UTC ---
Comment on attachment 6171
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6171
Bug 2629: Add diacritic support for Ů (U with ring)

patch obsoleted, already applied

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2629] Diacritics not being ignored when searching

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_6
   Patch Status|Passed QA   |Patch Pushed

--- Comment #38 from Paul Poulain paul.poul...@biblibre.com 2012-01-10 
22:37:36 UTC ---
Patch pushed, as it works, 
BUT katrin is right: you should investigate ICU, that solves all diacritics
(well, there are some remaining problems, and that's why we should get rid of
zebra, but that's another matter. And using ICU is better than trying to have
everything in word-phrase !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

Duncan dun...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #7104|0   |1
is obsolete||

--- Comment #2 from Duncan dun...@catalyst.net.nz 2012-01-11 01:21:58 UTC ---
Created attachment 7105
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7105
Patch to ensure vendor names are unique and do not contain  or only spaces.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

Duncan dun...@catalyst.net.nz changed:

   What|Removed |Added

 CC||dun...@catalyst.net.nz
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7356] Fix various typos and mis-spellings

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
   Patch Status|Signed Off  |Passed QA

--- Comment #15 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-11 
02:20:43 UTC ---
A bunch of typo corrections.  Mostly fixing 'the the' and missing/extra
letters.  Marking as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7360] Importing a SQL file for frameworks based on Default Framework deletes the default framework

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7360

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #5 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-11 
02:24:24 UTC ---
Just adds support for 0 character frameworks (down from minimum 1).  Marking
Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7363] Downloading a list in CSV format doesn't work

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7363

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #3 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-11 
02:25:59 UTC ---
Template Toolkit scope issue only; easy to read, marking Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7379] some database fields are displayed 'as is' when they are linked to autorised values

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379

--- Comment #11 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-11 
02:39:29 UTC ---
Perhaps I'm missing something, but it does seem to me that copynumber is a
field that makes sense to link to an authorised values field.  Unlike location
and ccode, which are a discrete set of values, copynumbers are sequential, with
a potentially infinite number of values.  Preconfiguring a set of values seems
like a very uncommon practice.

If we're going to add support for copynumber authorised values, I think we
should add support for ANY item field being linked to authorised values (since
that can be changed by any library in the Frameworks)

This is where I'd change the status to In Discussion...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7381] wrong isbn showing on the staff search results

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7381

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #4 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-11 
02:41:49 UTC ---
Template only change to use raw ISBN and a simple replacement.  Marking Passed
QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7420] Add max fines to circulation matrix

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|kyle.m.h...@gmail.com   |srd...@catalyst.net.nz

--- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-11 
03:29:44 UTC ---
Created attachment 7106
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7106
patch

Repurposed MaxFine syspref. This means that new translations are in order.

MaxFine is now a global maximum for all overdue charges for a patron combined.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7420] Add max fines to circulation matrix

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
   Patch Status|--- |Needs Signoff
  Change sponsored?|--- |Sponsored

--- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-11 
03:31:16 UTC ---
It actually made no sense to place Overdue Fines Cap on its own, so it is in
the main table

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #27 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-11 
04:11:28 UTC ---
There's a mysterious table message_transports. If letter code is in that table
it is considered protected. I am not familiar with logic behind that.

If system has patron attributes switched on, those should appear in the fields
list for pick up as borrower_attribute.*

Also, we should compile a list of remarks and possibly make corrections for the
inportant ones immediately, and leave the rest as later enhancements

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-11 
05:20:33 UTC ---
* I wonder about the utility of New Notice at all - if we can only define
notices within the codes in the default data (is that true?) then copying them
from the defaults is probably the easiest way to go. Or, make the code field a
drop down to select the type of notice so one doesn't mess up and put a quick
slip under the cataloging module (like I did in my testing because I wasn't
paying attention).

Hi Liz, defining your own notices can make sense. One example is overdues where
you tell the notice triggers which notices to use. It's not relying on a
special code there. And there are some other places where it only relies on the
correct module (acq and serials).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/