[Koha-bugs] [Bug 6913] Improving koha-list and koha-create
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 08:16:47 UTC --- QA comment * nothing to say about the code, everything consistent and clearly written * haven't tested it myself, but chris_c is a trustable tester passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6913] Improving koha-list and koha-create
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #12 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 08:18:00 UTC --- Patch pushed, versionned for 3.8 as this patch contains improvements that should be announced explained widely. chris_n, is you disagree, let me know -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6933] Add a view of titles with a particular tag to the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6933 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 09:19:16 UTC --- QA comment: I was about to say perfect, nothing to say, when I realised list.pl was a new script so we could apply PERL1 coding guideline (perltidy). list.pl was not perfectly perltidied, i've added a follow-up other than that, passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6933] Add a view of titles with a particular tag to the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6933 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6943] Create new budget from a copy of a previous budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |paul.poul...@biblibre.com |ity.org | --- Comment #18 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 10:14:16 UTC --- QA comment: #2 The code does not respect the HTML3 coding guideline. however, it was submitted before the inclusion of this new behaviour, and there are also many dates managed elsewhere in the script, so maybe it's more consistent #1 the cloning does not let the user updating the description of the budget. Thus, the cloned budget has exactly the same name as the previous one, only the dates differ. As there is a form to enter the dates of the new budget, why not add the description of the budget ? (pre-filled with the previous value). Would you agree to add this feature to your patch ? Katrin, as you've signed-off, your opinion is welcomed ! Not marking failed QA, #2 is more a question. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Version|master |rel_3_8 Severity|minor |enhancement --- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 10:43:44 UTC --- QA comment: * tiny patch, nothing to say about the code, it's OK * I think it's an ENH, that could surprise some libraries. Changing the severity version to have it for 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7005] no confirmation for write off all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7005 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6990] TransformKohaToMarc enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6990
--- Comment #30 from Janusz Kaczmarek janus...@gmail.com 2012-02-02 11:10:01
UTC ---
I can confirm. After switching to current master the error does not occur any
more when playing with mod_perl. But since Nicole was not using mod_perl and
because there was no change to the code of C4::Biblio::TransformKohaToMarc (nor
C4::Context::_new_marcfromkohafield on which it depends), it would mean that
under *unpredictable*circumstances*, not just under mod_perl, it could happen
that the result of the attribution
$dtm = $db_to_marc-{''}-{$name}
is something defined (like a reference to an empty table [], as it is in my
case) while it would be rather expected to be undefined. (This is why Nicole,
and me, got $tag being '' in line 1849, etc.)
In that context the version
my $dtm = $db_to_marc-{''}-{$name};
next unless $dtm-[0];
is more verbose, but does the same in a more robust way.
But since nobody else experienced this error I do not know if I should send a
patch...?
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7080] Clean up interface on fine payment screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7080 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Patch doesn't apply CC||paul.poul...@biblibre.com --- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 11:12:31 UTC --- Sorry, but this patch is conflicting a little with the bug 7005 I just pushed before this one Should be easy to fix, and switch back to signed-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6943] Create new budget from a copy of a previous budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-02-02 11:23:23 UTC --- Hi Paul, see comment 13 ;) I noted there that an option to edit the description while copying would be good. Still this feature works as advertised and it is useful - so didn't want to scope creep it. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7493] New: Deleting a record with comments breaks Recent Comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7493 Bug #: 7493 Summary: Deleting a record with comments breaks Recent Comments Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC AssignedTo: oleon...@myacpl.org ReportedBy: mag...@enger.priv.no QAContact: koha.sek...@gmail.com A library deleted a record that had comments attached to it, and now they get an error when they click on Recent Comments in the OPAC: Software error: Can't call method field on an undefined value at /usr/share/koha/lib/C4/Koha.pm line 1216. This is version 3.6.3. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7148] Add some error handling to Acquisitions' Z39.50 search to match Cataloging's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7148 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Version|master |rel_3_6 --- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 13:14:05 UTC --- QA comment * also include some code cleaning (removing dead lines, adding $DEBUG and warn instead of unconditionnal warns, +1 passed QA. this is at the frontier of ENH and bugfix, so assigning to 3.6, chris_n it's worth including it in 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7148] Add some error handling to Acquisitions' Z39.50 search to match Cataloging's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7148 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #34 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-02 13:24:39 UTC --- Warning like below apparently come from the latest commit on Search.pm: [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl: Unable to parse OpacHiddenItems syspref : YAML Error: Stream does not end with newline character, referer: http://libdevelop.rijksmuseum.nl:8008/ [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl:Code: YAML_PARSE_ERR_NO_FINAL_NEWLINE, referer: http://libdevelop.rijksmuseum.nl:8008/ [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl:Line: 0, referer: http://libdevelop.rijksmuseum.nl:8008/ [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl:Document: 0, referer: http://libdevelop.rijksmuseum.nl:8008/ [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl: at /usr/local/lib/perl5/site_perl/5.10.0/YAML.pm line 36, referer: http://libdevelop.rijksmuseum.nl:8008/ [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl: Unable to parse OpacHiddenItems syspref : YAML Error: Stream does not end with newline character, referer: http://libdevelop.rijksmuseum.nl:8008/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6210] Choose framework on Merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-02 13:57:17 UTC --- (In reply to comment #26) thx owen for the new display, thanks srdjan for your answers, passed QA Probably, these new warnings (like below) come from this first patch, making changes in GetMarcFromKohaField: [Thu Feb 02 14:46:00 2012] [error] [client 192.87.126.61] [Thu Feb 2 14:46:00 2012] opac-search.pl: No marc tags for framework field items.biblionumber at /usr/share/koha/testclone/C4/Biblio.pm line 1051., referer: http://libdevelop.rijksmuseum.nl:8008/cgi-bin/koha/opac-search.pl?q=vermeer Note that it repeats for multiple fields!! Just a side note: When writing/testing your patches, please check your error log too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6488] opachiddenitems not working in master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 --- Comment #35 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 14:22:28 UTC --- (In reply to comment #34) Warning like below apparently come from the latest commit on Search.pm: [Thu Feb 02 13:33:42 2012] [error] [client 192.87.126.61] [Thu Feb 2 13:33:42 2012] opac-search.pl: Unable to parse OpacHiddenItems syspref : YAML Error: OK, I get the error, but only when the syspref is empty. That's strange, because in the code there is: +$yaml = $yaml\n; # YAML is anal on ending \n. Surplus does not hurt so yaml should never be empty... Adding 2 \n solve the problem. follow-up with a 2nd \n pushed, thanks to confirm the log is silenced now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6210] Choose framework on Merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210
--- Comment #28 from Paul Poulain paul.poul...@biblibre.com 2012-02-02
14:34:53 UTC ---
In Comment #16 I wrote:
QA comments:
1- there is an unconditionnal warn: warn qq{No marc tags for framework
$frameworkcode field $kohafield};
Srdjan answered in comment #25:
Issues from comment 16:
1. warn is not unconditional, sub returns before warn if all is ok
Why didn't I checked, I don't know. But the result is the verbose logs !
In UNIMARC, there are many fields that are in items table and not connected to
a MARC field. And that should not trouble anyone.
So we should not issue any warning.
I've pushed a follow-up removing the warning, the logs are silenced now
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6490] Lost and paid not updated when book is checked out.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6490 --- Comment #2 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-02 15:22:24 UTC --- Created attachment 7421 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7421 Add call to _FixAccountForLostAndReturned from AddIssue -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7190] written off fines being refunded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7190
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
--- Comment #5 from Paul Poulain paul.poul...@biblibre.com 2012-02-02
17:17:03 UTC ---
QA comment:
Srdjan, I couldn't understand why you write
my $sth = $dbh-prepare(SELECT * FROM accountlines WHERE itemnumber = ?
AND accounttype IN ('L', 'Rep', 'W') ORDER BY date DESC, accountno DESC);
and a few lines below:
$data or return;# bail if there is nothing to do
$data-{accounttype} eq 'W' and return;# Written off
It's equivalent to
my $sth = $dbh-prepare(SELECT * FROM accountlines WHERE itemnumber = ?
AND accounttype IN ('L', 'Rep') ORDER BY date DESC, accountno DESC);
followed by
$data or return;# bail if there is nothing to do
?
Thinking of it, a little bit more, the date DESC is important. As the sub
returns only 1 line, you can have more than 1 line in the SQL, we assume the W
is the most recent one (that sound reasonable: you writeoff a fine you've
already set)
At the end, my feeling is that the sub is quite strange (could I say clumsy ?
probably...), but it was before your patch, so it's OK
Otherwise, small patch, passed QA
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7190] written off fines being refunded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7190 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7190] written off fines being refunded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7190 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7238] The SIPconfig.xml is stored in the C4/SIP dir
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #8 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 17:24:21 UTC --- QA question: Am I right if I say it changes the signature of sip_run ? before the patch: you could run without any arg, the SIPconfig.xml was taken from C4/Sip, but you could also pass a parameter with the config file after the patch: you must provide a parameter if i'm right, this patch is an ENH, and will be for 3.8 to avoid any regression for existing users during maintenante update. Otherwise, passed QA, but i'm waiting for the answer to push -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #25 from Paul Poulain paul.poul...@biblibre.com 2012-02-02 17:25:37 UTC --- I think we must discuss of where to put those files. I plan to send mails to koha-devel about all in discussion bugs, will do that tomorrow -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6490] Lost and paid not updated when book is checked out.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6490 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #7421|0 |1 is obsolete|| --- Comment #3 from Liz Rea wizzy...@gmail.com 2012-02-02 17:58:47 UTC --- Created attachment 7422 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7422 Bug 6490 - Lost and paid not updated when book is checked out. Signed-off-by: Liz Rea wizzy...@gmail.com Tested: item checked out and marked lost - item is removed from borrower's checkouts and charged to patron Checking out the item (without checking it in first) removed the fines and issued the item normally. Passed prove t xt t/db_dependent (results congruent with current master failures) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6490] Lost and paid not updated when book is checked out.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6490 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7147] Style Z39.50 search errors according to style patterns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7147 --- Comment #1 from Owen Leonard oleon...@myacpl.org 2012-02-02 18:01:59 UTC --- Created attachment 7423 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7423 Bug 7147 - Style Z39.50 search errors according to style patterns Styles Z39.50 errors and messages in the standard style. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7147] Style Z39.50 search errors according to style patterns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7147 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 --- Comment #2 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-02 18:36:28 UTC --- Created attachment 7424 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7424 Adds the ability to use branches.* fields in digest notices and have them be parsed correctly. Also adds a warning to the notices editor for digests. Not a complete fix, but it does address one of the issues mentioned in this bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||kyle.m.h...@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7494] New: Use partial barcode or callnumber as a fallback for the barcode search in checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Bug #: 7494 Summary: Use partial barcode or callnumber as a fallback for the barcode search in checkout Classification: Unclassified Change sponsored?: Seeking cosponsors Product: Koha Version: master Platform: All URL: http://koha:8080/cgi-bin/koha/circ/circulation.pl OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.h...@gmail.com ReportedBy: m...@ttllp.co.uk QAContact: koha.sek...@gmail.com CC: gmcha...@gmail.com This could be done in a similar manner to Bug 1081. Probably should be optional, as should that search. An alternative implementation may be to add a Checkout button under Available entries in the Status column of the item table in the catalogue/detail.pl output. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7495] New: Tax calculations problem for new orders.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495
Bug #: 7495
Summary: Tax calculations problem for new orders.
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: rel_3_6
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
AssignedTo: henridam...@koha-fr.org
ReportedBy: fcapovi...@live.ca
QAContact: koha.sek...@gmail.com
When creating a new order, the automatic tax calculations may sometimes be
wrong because of loss of precision.
Example :
With gist=0, create a new order and put 18.99 into the Vendor price field.
The Budgeted cost and Total fields are automatically set to 18.98 when they
should be 19.99
The same happens with 16.99 .
Possible cause of the problem :
http://stackoverflow.com/questions/3730019/why-not-use-double-or-float-to-represent-currency
Here are some utility functions that could be used to correct the problem :
function to_Cents(val) {
return Math.round(val*100);
}
function to_Dollars(val) {
return (Math.round(val)/100).toFixed(2);
}
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7496] New: Personally identifying information sent in opac user TITLE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7496 Bug #: 7496 Summary: Personally identifying information sent in opac user TITLE Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC AssignedTo: oleon...@myacpl.org ReportedBy: wizzy...@gmail.com QAContact: koha.sek...@gmail.com We show the name of the user in the OPAC in the TITLE of the user pages, so on public stations if the history is not cleared after every session, the next user would be able to see who had logged in last. The name also appears in place hold for pages. Is this reason for concern? Surely this runs afoul of privacy laws *somewhere*. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3215] It would be nice if Add to Cart changed to Remove from Cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3215 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #7387|0 |1 is obsolete|| --- Comment #4 from Liz Rea wizzy...@gmail.com 2012-02-02 21:30:01 UTC --- Created attachment 7425 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7425 Bug 3215 - It would be nice if Add to Cart changed to Remove from Cart Add to Cart links in the OPAC should reflect whether a title is already in the Cart. On the results, list, and detail pages the Add to Cart link will say In your cart (remove) if the title is in your cart. The (remove) link will remove the title. This patch adds a check of the biblionumbers in the cart to the relevant scripts and sets a variable for the template governing whether to show Add to cart or In your cart. Pages to test: - the search results page - any detail page (normal, MARC, ISBD) - any list contents page (/cgi-bin/koha/opac-shelves.pl?viewshelf=XX) Situations to test: - Add a single item to the Cart from the above pages The link should change from Add to cart to In your cart (remove) The count of items in your cart should reflect the addition, and the notification box should appear. - Remove a single item from the Cart from the above pages The link should change from In your cart (remove) to Add to cart. The count of items in your cart should reflect the removal, and the notification box should appear. - View an item which is already in the cart from the above pages The cart links should reflect whether the title is already in the cart. - Remove one or more items from the Cart via the cart pop-up window View the above pages as you do so to verify that the operation is reflected immediately by the state of the in your cart links. - Empty the Cart from the cart pop-up window View the above pages as you do so to verify that the operation is reflected immediately by the state of the in your cart links. Tested in Firefox 9, Chrome 16, IE 7, and Opera 11.6 on Win 7 Signed-off-by: Liz Rea wizzy...@gmail.com Stepped through test plan - no issues found. prove t xt t/db_dependent congruent with current master failures. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7496] Personally identifying information sent in opac user TITLE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7496 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #1 from Magnus Enger mag...@enger.priv.no 2012-02-02 21:30:23 UTC --- It could also be seen as a problem with statistics-systems like Piwik and Google Analytics, that show the titles of pages visited during a session. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7458] New call number allocation plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458 --- Comment #13 from Melia Meggs me...@bywatersolutions.com 2012-02-02 22:56:14 UTC --- This is very nearly perfect now. Only one thing - is it possible to prevent it from ever returning FREN ? Can we make it start with FREN 0 - returns FREN 0001 as the first possible value? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Priority|P5 - low|P1 - high Status|NEW |ASSIGNED CC||ch...@bigballofwax.co.nz Severity|normal |critical --- Comment #1 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:32:53 UTC --- This is a bug in the way we are using memoize_memcached I will do patches to fix it in all the places we use it. The first one will be for C4/Biblio and will show what we are doing wrong. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:36:24 UTC --- Now they will only be cached for 10 mins max, so will reflect the change without needing a restart. I will do this for all instances of memoize_memcached and attach them here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:36:54 UTC --- Created attachment 7426 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7426 Bug 7432 : Fix how we are setting expiry time when caching -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:41:17 UTC --- Created attachment 7427 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7427 Bug 7432 : Fixing caching for SQLHelper -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #7427|0 |1 is obsolete|| --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:43:13 UTC --- Created attachment 7428 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7428 Bug 7432 : Fixing caching for SQLHelper -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7432] Changing frameworks should refresh cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432 --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-02 23:44:51 UTC --- Created attachment 7429 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7429 Bug 7432 : Fixing caching for C4::Languages -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7238] The SIPconfig.xml is stored in the C4/SIP dir
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #9 from Liz Rea wizzy...@gmail.com 2012-02-03 00:04:16 UTC --- Paul: that is correct. My opinion is that it can wait for 3.8. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7001] User Configurable Slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 --- Comment #62 from Liz Rea wizzy...@gmail.com 2012-02-03 00:08:03 UTC --- srdjan: no worries. This one caused you no end of grief. It can be revised later. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7190] written off fines being refunded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7190
--- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-03
00:26:05 UTC ---
Paul,
It is not equivalent. The purpose is to catch 'W'.
* With SELECT * FROM accountlines WHERE itemnumber = ? AND accounttype IN
('L', 'Rep') ORDER BY date DESC, accountno DESC 'W' is ignored. It says The
latest fine and the latest fine is acted upon.
* With accounttype IN ('L', 'Rep', 'W') it says Latest fine or writeoff,
and if it is a writeoff we walk away.
Re clumsiness, well it is not just this sub, it is the accounting side as a
whole. There's no proper accounting/billing implemented, and the best thing
would be to integrate a third party solution, but that is another subject.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6210] Choose framework on Merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210 --- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-03 07:41:38 UTC --- Confirming that follow up fixed noise in the log. Thx! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-03 07:47:05
UTC ---
Note that a follow-up fixed missing comma after total_due:
diff --git a/members/paycollect.pl b/members/paycollect.pl
index cbddc05..e05a5a6 100755
--- a/members/paycollect.pl
+++ b/members/paycollect.pl
@@ -138,6 +138,7 @@ $template-param(
borrowenumber = $borrowernumber,# some templates require global
borrower = $borrower,
total = $total_due
+activeBorrowerRelationship =
(C4::Context-preference('borrowerRelationship') ne ''),
);
As Paul noted in commit: Seems everybody forgot to test paycollect, as there
was a syntax error!
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #7317|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-03 07:54:31 UTC --- Created attachment 7430 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7430 Followup for typo on borrowernumber Fixing trivial typo, setting status to Passed QA again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|rel_3_8 |master QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6964] 'Add child' function should be dependant on system preference 'borrowerRelationship'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6964 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #7430|0 |1 is obsolete|| --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-03 07:58:10 UTC --- Created attachment 7431 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7431 Follow-up fixing typo Second try to add attachment.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
