[Koha-bugs] [Bug 7001] User Configurable Slips

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #96 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8196
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8196action=edit
Bug 7167 Followup FIX conflicts with Bug 5347

- Fix sql syntax error
- Fix Encoding
- SendAlerts must return an error if no email is defined
- Get error if no email in memberentry

ps: the 'no email' error for serials/claims.pl is caught in Bug 5342

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7706] New: AuthorisedValueImages not displaying all images on the OPAC

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7706
  Assignee: adrien.sau...@biblibre.com
   Summary: AuthorisedValueImages not displaying all images on the
OPAC
QA Contact: koha.sek...@gmail.com
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: adrien.sau...@biblibre.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: OPAC
   Product: Koha

The system preference AuthorisedValueImages is supposed to display/hide
images for authorized values (such as lost statuses and locations) in search
results and item detail pages on the OPAC.
The ccode images should appear too.

As it is now :
* no images are displayed on the result page
* ccode and lost are displayed on the detail page
* location is never displayed

To be added :
* ccode, lost and location in the result page
* location in the detail page

Note :
There's also a translation problem (in french) for the AuthorisedValueImages
system preference. When you choose to activate it, it is disabled instead (and
enabled when you want to disable it...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #9 from delaye stephane.del...@biblibre.com ---
Disregard my previous comment, I forgot to prohibit transfers from B to A.
sorry

so it's ok But...

But the rules (limit) of tranfers is not interpreted with the requests for
holds to the OPAC and intranet
and more specialy with the system preference OPACAllowUserToChooseBranch(=ON)
If OPACAllowUserToChooseBranch activated the transfers limits are not read. The
system preference displays all sites (= select * from branches) instead of
displaying only those sites that allow transfers.

Example:
A network of four sites: A, B, C and D
The adherents of A, B and C can reserve copies of A, B and C. Items with
branches A, B and C can transit in sub-network A, B and C. The items with
branch D can not be reserved and site D does not accept the items with branches
A, B and C.

The holds rules are the following :
Branch A - All sites
Branch B - All sites
Branch C - All sites
Branch D - No holds

Rules of transfers
branch A - A, B, C
branch B - A, B, C
branch C - A, B, C
branch D - D

OPACAllowUserToChooseBranch is activated

From  OPAC a borrower located A want to book a title. The title have 3 items in
use with branches A, B, and D.
Koha display all the branches A, B, C and D for pickup instead of proposing the
branches A, B and C. So when returning an item (A, B or C) there is a risk that
the pickuplocation will be D if the borrower have been chose D. While D don't
want manage holds within the network.

Paul I have an example of sandbox1
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-reserve.pl?biblionumber=2220
(user: password and mozart: mozart)

it's important for few customers. See also ticket 7534

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #97 from Paul Poulain paul.poul...@biblibre.com ---
I just pushed 
* follow-up patch fix protected letters = thx srdjan, it fixes my comment 89 !
* Bug 7167 Followup FIX conflicts with Bug 5347 = thx jonathan, it fixes the
SQL error.

About this last one, jonathan, i've a question:
I can't reproduce the no_email display = isn't it supposed to appear when you
have mails on new patrons set and don't enter a mail ? In this case, the
message is not appearing or i'm doing something wrong.

I've pushed the patch because it fixes the SQL error ( the utf-8 encoding), so
it's worth pushing even if the no_mail thing don't work.

If you have an explanation, it will be welcomed though ;-)

Katrin, you're welcomed to test once again if you want !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #98 from Paul Poulain paul.poul...@biblibre.com ---
oups... hit save changes too quickly... I also have pushed a small POD
update, to fix a jenkins complain about C4/Print POD invalid !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #99 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Paul, 

the message is for when you try to send out claims to a vendor with no email
address. There is still a small bug though - it will still increase the claim
count and set a claim date.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7705] IE postdata issue - expiring sessions when back button is used

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7705

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Can you provide the steps required to reproduce the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
I'd add to this Item status can be set to lost from: that it can be marked
lost from the longoverdue cron as well (not sure of the file).

Before changing additem.pl to charge for lost items, we might need to add
another system preference that asks if marking lost charges patrons the
replacement fee .. anyone else have any ideas on this? The last time changes
were made to how lost is assigned there were some issues.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7638] one page notice for printing per student?

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
For this section:

Following filters will be made available during report generation:

Branch
Patron category
Transaction date range

I would note with branch we're talking about - the patron's branch?

Also, will the notice allow for customization of what fields show from the
accountlines table? You mention the defaults that will be in the template, but
I just want to be clear.

Thanks a ton!
Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7704] Independent Branches sys pref change to let librarians choose which things to share

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7704

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com ---
I agree with Nicole's comment, and want to add a very minor detail. I would
suggest instead of forgivefinewhenlost, use ForgiveFineWhenLost. It seems to be
the custom now to capitalize each word in a system preference, it certainly
makes them easier to read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7645] System preferences editor save button obscured by language chooser

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com ---
Comment : to test this patch, it's required to flush FF cache (CTRL-F5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

--- Comment #27 from stephane.dela...@biblibre.com ---
(In reply to comment #26)
 I tried putting the OPAC xsl files on a different server and linking to them
 via a full URL and I'm getting this error:
 
 I/O warning : failed to load external entity MARC21slimUtils.xsl
 compilation error: file unknown-a19e318 element import
 xsl:import : unable to load MARC21slimUtils.xsl
  at /home/oleonard/kohaclone/C4/XSLT.pm line 214
 
 I have copied MARC21slimUtils.xsl to the same remote directory as the OPAC
 detail xsl file. Is there something else I'm missing?

It is normal, it come from your xsl file that uses a relative path.
if your syspref OPACXSLTDetailsDisplay have as value :
http://www.myurl.com/myxslfiles/MARC21slim2OPACDetail.xsl;
you need edit this file (MARC21slim2OPACDetail.xsl) to replace the line :
xsl:import href=MARC21slimUtils.xsl/
with this :
xsl:import href=http://www.myurl.com/myxslfiles/MARC21slimUtils.xsl/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7638] one page notice for printing per student?

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com ---
As an alternative to PDF, it may be better to use html and css. I've done this
before, it's possible to create page breaks using css, and it is much easier to
work with HTML than it is to create PDF files. I know this from personal
experience. This also means we could use the notices system to make this
template-able. Customizing a PDF would be far more difficult.

http://davidwalsh.name/css-page-breaks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6751] Link in readingrec.pl to export a barcode file

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7704] Independent Branches sys pref change to let librarians choose which things to share

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7704

--- Comment #1 from Kyle M Hall kyle.m.h...@gmail.com ---
I think hiding items between branches would be a complicated and messy affair.
The current version of IndependentBranches allows a library to see other
library's items, but not modify them, which I think is fair enough.

So the list so far would be:
Patrons
Holds

which is basically what we already have. It seems that in LL Koha, if
IndependentBranches is enabled, and canreserverfromotherbranches is also
enabled, libraries can place holds and transfer items, but there is a bug where
the item cannot be transferred back to the home library. Perhaps we should
focus on that first, but also try to expand this list for future development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix.

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #20 from delaye stephane.del...@biblibre.com ---
I have the new column in the table of holds rules == ok
But when I return the copy who have been reserved
 this message
Software error:

Could not find a letter Called 'HOLD_PRINT' in the 'reserved' module at /
home/koha/src/C4/Reserves.pm line 1740.

After  F5 the message disappears then the request is well recorded in table
reserves but without expirationdate

select * from reserves where borrowernumber='7853'\G
*** 1. row ***
  borrowernumber: 7853
 reservedate: 2012-03-13
biblionumber: 5
  constrainttype: a
  branchcode: MAURES
notificationdate: NULL
reminderdate: NULL
cancellationdate: NULL
reservenotes: 
priority: 0
   found: W
   timestamp: 2012-03-13 14:47:03
  itemnumber: 67
 waitingdate: 2012-03-13
  expirationdate: NULL
  lowestPriority: 0


PS : HOLD_PRINT is in the table letter...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7636] error when trying to email cart when opacuserlogin set to don't allow

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7636

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7665] Bibs with no ISBN's show broken images for covers when using Syndetics cover images.

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7665

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com

--- Comment #5 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed, (untested as I don't have syndetics credentials)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6
   Severity|minor   |enhancement

--- Comment #17 from Paul Poulain paul.poul...@biblibre.com ---
this patch can also be considered as an ENH, but it's worth having it in 3.6

I also checked the JS message was translatable

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7633] Move display of patron image in self checkout

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7633

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com ---
not really a big ENH, so can be pushed on 3.6, no doubt

owen: are you really the traitor ? :D :D (see
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7969)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7144] Floating collection

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #26 from Kyle M Hall kyle.m.h...@gmail.com ---
Maybe I'm a bit late in asking this, but why use itemtype for the floating
collection rules instead of collection code? It seems odd to require a separate
item type for floating items that are really Books, Audiobooks, etc.

For example, at the Crawford County Federated Library System, there are a
number of 'rotating collections'. The books and audiobooks move from from one
library to the next each month. 

I have written a rotating collections feature for them that lets the
librarian's create 'collections' of items, and set what branch the collection
is currently at. Koha currently tracks who owns and item, and where an item is
at, but not where an item should be. For example, Collection1 is at LibraryA,
and is now to be moved to LibraryB. It my system, a librarian simply goes into
the rotating collections system and changes the current library for Collection1
from LibraryA to LibraryB. LibraryA then packs up all the items that are
currently on the shelf and ships them to LibraryB. When any books in
Collection1 that are currently circulating are checked in, the librarian
recieves a notice that the item is part of a rotating collection and should be
transferred to LibraryB immediately.

Could this feature be used to replicate this scenario? If not, I would be more
than happy to open a bug and submit my rotating collections code. I suppose
rotating collections are different than floating collections in how they
behave.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_8

--- Comment #83 from Paul Poulain paul.poul...@biblibre.com ---
(forgot to set version 3.8)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Depends on||7587

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7587] Wrong table name for local cover images

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7587

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8
 Blocks||1633
   Severity|critical|enhancement

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com ---
It's a follow-up of an enhancement, so, even if it's a CRI fix, switching
severity to ENH, and version to

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_8

--- Comment #37 from Paul Poulain paul.poul...@biblibre.com ---
(forgot to set to 3.8)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, this feature is in 3.6 already - so shouldn't it be 3.6?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7602] Spent and Ordered pages require full acquisition permissions

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8
 Blocks||929

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 929] See details of a budget

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Depends on||7602

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7698] Add ICU option to Koha out of the box

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7698

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3216] UNIMARC author facets

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3216

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_6

--- Comment #17 from Paul Poulain paul.poul...@biblibre.com ---
I like this patch very much ;-)

However = wouldn't it be better to add 710a, 711a and 712a to authors ?

patch pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7654] Add location an callnumber at opac subscription view

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #1 from delaye stephane.del...@biblibre.com ---
l'application du patch dans une sandbox a echoué

Applying: Add location and callnumber at OPAC subscription view
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Add location and callnumber at OPAC subscription view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7707] New: Add fines placeholders in notices to display fine information on notices

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7707

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7707
  Assignee: henridam...@koha-fr.org
   Summary: Add fines placeholders in notices to display fine
information on notices
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: wizzy...@gmail.com
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Notices
   Product: Koha

Add fines.total and other fines placeholders in notices to display total
owed in fines on notices.

It would be cool to be able to let patrons know how much they owed in fines in
their overdue notices. This could take a couple forms

* Per item fines (fines.item or items.content.fines
* Total balance of account (fines.total)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7707] Add fines placeholders in notices to display fine information on notices

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7707

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Using the item syntax it is possible to output the fine for each item in the
notice with the other item information:

Example:
itembiblio.title, Signatur: items.itemcallnumber, Barcode:
items.barcode, Mahngebühr: fineEUR/fine/item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7708] New: Import/export from a special library (french BDPs)

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7708

  Priority: P2
 Change sponsored?: Sponsored
Bug ID: 7708
CC: claire.hernan...@biblibre.com
  Assignee: paul.poul...@biblibre.com
   Summary: Import/export from a special library (french BDPs)
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: paul.poul...@biblibre.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: Tools
   Product: Koha

In France, each département (roughly a little bit larger than a US county)
has a bibliothèque départementale.
This special library is dedicated to provide books to tiny libraries, by group
of 200+
The tiny library go to the BDP (that does not use Koha), takes 200+ books, and
also get a iso2709 file to include the catalogue directly into his local ILS
(that is Koha ;-) )
When the tiny library send book backs (usually after a 6 months period), the
BDP give a list of barcode in a file.

When the tiny library checkout books from the BDP, she add them into Koha. When
the tiny library checkin books from the BDP, she removes them from Koha.

The script provided here is dedicated to manage this import/export.

Note = import can't be done through reservoir import, as there are some
specific things to do during import that depends on the BDP giving the file and
the tiny library including it.

This script is a wrapper for import/export specific to each BDP/tiny. We will
also provide many specific scripts we've made for each of our libraries.

Note 2 = you can now understand why we've developped bug 6751 feature : this is
why the BDP can export checked in barcodes

(we have one BDP using Koha, and many tiny libraries -depending from other
BDP-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5341] Serial issues improvements

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5341

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|rel_3_4 |rel_3_6

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7661] Moving C4::tests to unit tests

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7661

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_6

--- Comment #8 from Paul Poulain paul.poul...@biblibre.com ---
trying to prove t/db_dependent/Record/Record.t after applying the patch, I get
a nasty:

t/db_dependent/Record/Record.t .. 1/23 Aucun fichier ou dossier de ce type at
t/db_dependent/Record/Record.t line 46.
# Looks like you planned 23 tests but ran 1.
# Looks like your test exited with 2 just after 1.
t/db_dependent/Record/Record.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 22/23 subtests 

Test Summary Report
---
t/db_dependent/Record/Record.t (Wstat: 512 Tests: 1 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 23 tests but ran 1.
Files=1, Tests=1,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.37 cusr  0.03
csys =  0.45 CPU)
Result: FAIL


What's wrong ?
I also had a problem applying the patch:
git bz apply 7661
Bug 7661 - Moving C4::tests to unit tests

7661 Moving C4::tests to unit tests
Apply? [yn] y

Applying: 7661 Moving C4::tests to unit tests
Can't open perl script C4/tests/Record_test.pl: Aucun fichier ou dossier de
ce type

Are you sure you want to commit ?
You can commit with the --no-verify argument
Patch left in /tmp/7661-Moving-C4tests-to-unit-tests-EEw6sJ.patch


that was caused by the pre-apply hook I think, I had to force --no-verify

I'll push it, we will see if things are OK on jenkins, but I have some doubts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7144] Floating collection

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

--- Comment #27 from Ian Walls koha.sek...@gmail.com ---
This code works off of item type because item types are the What parameter in
circulation rules (where being branch, and who being patron category). 
Collection codes to not factor into circulation rules, and I don't believe they
should.  If you need materials to have a different set of behaviours, assign
them different item types.  If that set of types isn't what you'd want your
users to search on, that's okay, Collection Code can be used for searching
instead.

Rotating Collections wouldn't be well covered by this code; as you say, we need
to track not only who owns a material and where it currently is, but where it
should be.  If you abstract this a little further, we could have temporary
item information of any kind.  This would support Course Reserves, in that
materials could have their item types and shelving locations changed for the
term, then reverted back.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7638] one page notice for printing per student?

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638

--- Comment #4 from Ian Walls koha.sek...@gmail.com ---
I highly recommend avoiding direct PDF generation; better to use HTML and CSS,
then let the browser print to PDF.  Lots of the open source PDF tools are...
limited... as we've seen with the Labels tool bug 2246.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7709] New: Cover Images Template plugin

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7709
  Assignee: oleon...@myacpl.org
   Summary: Cover Images Template plugin
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: koha.sek...@gmail.com
  Hardware: All
Status: NEW
   Version: master
 Component: Templates
   Product: Koha

As we add more and more sources for cover images, and use them in more and more
places, it becomes increasingly difficult to keep the code synchronized.  I
propose we move the logic of picking and displaying a cover image out of the
templates and into a T:T Plugin.

Usage would be like:

[% biblionumber | KohaCoverImage %]

I say biblionumber instead of normalised_isbn (which is common for most all
external services) because it will also work for local cover images.  This does
add the overhead of having to look up the normalized ISBN again, even if we
already had it on the page.  Anyone more familiar with passing variables
(particularly hashes) to T:T plugins, would be welcome to step up here.

This would simplify out templates by several dozen lines of code, and provide a
uniform logic for selection.  New selection methods, as well as new sources,
would be easy to add, since they'd only need to be coded in one place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] New: multiple holds per title

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7710
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: multiple holds per title
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: me...@bywatersolutions.com
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

Users shall be able to place holds on multiple items attached to a single
biblio, subject to two circulation policies (configurable on the branch/item
type/patron category level).  One policy shall indicate the number of holds
that can be placed on items with different enumchron values (different
volumes), while another shall indicate the number of holds that can be placed
on items with the same enumchron field (different copies).  This will allow
libraries to allow patrons to place holds on multiple volumes of a title, up to
a reasonable limit, while limiting or preventing multiple holds on 'equivalent'
copies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7065] reserves table needs a primary key

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||7710

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7065

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||5609

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5609] Holds Rewrite

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7710

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks|5609|7065
 Depends on|7065|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5609] Holds Rewrite

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on|7710|

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7065] reserves table needs a primary key

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks|7710|
 Depends on||7710

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7711] New: clear holds statuses and workflow

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7711
CC: gmcha...@gmail.com
  Assignee: koha.sek...@gmail.com
   Summary: clear holds statuses and workflow
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: me...@bywatersolutions.com
  Hardware: All
Status: NEW
   Version: master
 Component: Hold requests
   Product: Koha

Created attachment 8197
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8197action=edit
Status Workflow Mapping

Clear statuses
For each hold in the system, there should be a clear, single status to describe
it's current state.  These statuses should include:

Waiting (in holds queue)
Ready to pull
Pulled and awaiting pickup
Filled
Expired
Long waiting
In transit
Suspended
Canceled

Since these statuses have concrete system states attached to them, they must be
hard coded into the system.  The use of an Authorized Value list would not be
sufficient.

Status Workflow
Not every status should be reachable from every other status.  Attached is a
mapping of which statuses a hold shall be able change between.  O with a green
background indicates possible, while X with a red background indicates
impossible.  Grey cells are for self-references.

[Please see attachment.]

Holds shall be considered 'waiting in queue' until they reach the top position
of the queue, at which time they change to 'ready to pull'.  While in the
queue, they can expire, be suspended, or be canceled.

Once the hold is ready to pull, the next natural next step for the hold to
transition to the “Pulled” state, where it awaits being picked up by the
patron.  Since this status just means the hold is at the top of the queue, if
the queue is rearranged, the status of the hold could go back to 'Waiting in
queue'.  The hold can also expire, be suspended or be canceled.

After the hold is pulled, it should either be picked up by the patron and
marked as 'filled', or put 'in transit' to the pick up location.  It can also
still expire or be canceled.  If the hold waits to be picked up for more than
appropriate MaxReservePickupDelay circ rule, it will be marked as 'long
waiting'.

If a hold needs to be transferred to another branch, the status shall go from
'Ready to Pull' to 'In Transit'.  Once the item arrives at it's destination and
is received, it shall be marked as 'Pulled and ready for pickup'

Expired, Suspended and Canceled holds can be brought back into the queue. 
“Filled” is a terminal status; the hold record can now be archived.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7065] reserves table needs a primary key

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7711

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7711] clear holds statuses and workflow

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||7065

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7711] clear holds statuses and workflow

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks|7065|7641

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7065] reserves table needs a primary key

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on|7711|

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7711

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7712] a single holds report

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7712

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||7711

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7711] clear holds statuses and workflow

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7712

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5609] Holds Rewrite

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||7641

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #100 from Srdjan Jankovic srd...@catalyst.net.nz ---
Comment on attachment 8196
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8196
Bug 7167 Followup FIX conflicts with Bug 5347

I'm not against the patch, but I have to comment:
* Having to use Encode::encode() is wrong - all content comes from the
database, therefore should be utf8 already. This looks as curing the symptom,
not the cause.
* Even if it needs to be done, I suggest the right place would be where the
$letter is generated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7597] fines not recording the right info in the stats table

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7597

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #8100|0   |1
is obsolete||

--- Comment #18 from Nicole C. Engard neng...@gmail.com ---
Created attachment 8198
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8198action=edit
[SIGNED-OFF] Bug 7597 - Part 5 - Remove my from $branch, which was masking
previous declaration

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7597] fines not recording the right info in the stats table

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7597

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix.

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788

--- Comment #21 from Srdjan Jankovic srd...@catalyst.net.nz ---
That's strange. can you please
* paste the output of select * from letter where module='reserves' and
code='HOLD_PRINT';
* check what is in the apache error log after the first submission that throws
an error

Because the notice is the last thing that gets done the hold is successful the
first time, only the server error is thrown. reserves records are always
created with expirationdate null

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #50 from Mason James m...@kohaaloha.com ---
so heres my patch... with all the outstanding issued resolved ;)


1/ Why did you comment some unit tests ? They are ok.
FIXED

2/ You declare OpacStarRatings for template in C4::Auth, but it is only used in
2 tmpl (opac-results.tt and opac-detail.tt). Isn't it better to declare them in
their respective pl file ?
FIXED

3/ Why have you set the POD in the end of the module and not before each
function like (nearly) everywhere in Koha ? (C4::Ratings)
FIXED

4/ There is a TODO in opac/opac-ratings-ajax.pl :) 
FIXED

Moreover, in this script, why the use warnings line is commented ?
FIXED

I think the use of C4::Dates can be deleted
FIXED

5/ Why don't you create a foreign key for biblionumber and borrowernumber with
on delete cascade in the ratings table ?
FIXED

6/ It appears that a more recent version of jquery.ratings.js exists (v3.13 vs
v3.10) it is certainly not important, but why don't have choose the lastest ? I
don't have checked the difference between both.
FIXED

7/ Some useless comment lines are still present (#use Smart::Comments '';)
FIXED

8/ As said Katrin, javascript code is generated into a .pl file, isn't it
possible to open an alert into the javascript code ? After returns of ajax
response for example ?
FIXED

A couple of markup issues: 
input class=auto-submit-star type=radio  name=rating[% biblionumber %] 
value=1 [% IF (rating_val_1) %]checked=1[% END %] [% IF (rating_readonly)
%]disabled=disabled[% END %]   /
FIXED

'checked=1' should be 'checked=checked', and embedding [% IF %] inside a
tag goes against a coding guideline we have to prevent errors with the
translation script:
FIXED

oleonard@oleonard-desktop:~/kohaclone$ prove xt
# Looks like you failed 1 test of 1.

FIXED
-
mason@xen1:~/g/head$ prove xt
xt/permissions.t .. ok
xt/tt_valid.t . ok   
All tests successful.
Files=2, Tests=27,  3 wallclock secs ( 0.02 usr  0.01 sys +  2.92 cusr  0.03
csys =  2.98 CPU)
Result: PASS  
-

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Attachment #8027|0   |1
is obsolete||

--- Comment #51 from Mason James m...@kohaaloha.com ---
Created attachment 8199
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8199action=edit
Bug 5668 - Star ratings in the opac

applied to commit  49c387cddf6de083343fe6c88ad9f167844521b4

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/