[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James  changed:

   What|Removed |Added

   Attachment #8705|0   |1
is obsolete||

--- Comment #78 from Mason James  ---
Created attachment 8706
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8706&action=edit
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard 

Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Srdjan Jankovic  changed:

   What|Removed |Added

 Depends on||7854

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7854] preferences.pl: cannot have choice options of yes and no

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854

Srdjan Jankovic  changed:

   What|Removed |Added

 Blocks||7825

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7854] New: preferences.pl: cannot have choice options of yes and no

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7854

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7854
CC: gmcha...@gmail.com
  Assignee: paul.poul...@biblibre.com
   Summary: preferences.pl: cannot have choice options of yes and
no
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: srd...@catalyst.net.nz
  Hardware: All
Status: NEW
   Version: master
 Component: System Administration
   Product: Koha

$YAML::Syck::ImplicitTyping is set, thus preventing yes and no choices.
This should be turned off and explicit translations provided.

So far I've identifired:

All: null => ""
YesNo: yes => 1, no => 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James  changed:

   What|Removed |Added

   Attachment #8537|0   |1
is obsolete||
   Attachment #8613|0   |1
is obsolete||
   Attachment #8704|0   |1
is obsolete||

--- Comment #77 from Mason James  ---
Created attachment 8705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8705&action=edit
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard 

Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #76 from Mason James  ---
Created attachment 8704
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8704&action=edit
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard 

Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #75 from Mason James  ---
(In reply to comment #72)
> sorry, there's still a problem:
> * many files now have a conflict (just pushed bug 7470, that is probably the
> cause)
> I prefer not doing something wrong, and ask for a rebased patch, really sorry
> 
> (Even if I "feature freeze" today, i'll accept this patch if you provide a
> rebased version this week)

heya Paul, no problem :)

here's the rebased patch, 
tested and applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James  changed:

   What|Removed |Added

   Attachment #8537|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Mason James  changed:

   What|Removed |Added

   Attachment #8548|0   |1
is obsolete||

--- Comment #74 from Mason James  ---
Comment on attachment 8548
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8548
[PASSED QA] Bug 5668 - Star ratings in the opac

this patch was a rebase from an older patch, marking this obsolete

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #73 from Mason James  ---
(In reply to comment #68)
> Comment on attachment 8537 [details]
> Bug 5668 - Star ratings in the opac
> 
> Had to rebase anyway, so the above mention change (remove use C4::Serials
> line) is followed into rebase, along with some whitespace cleanup

hmm, Ian, it looks like you grabbed and rebased an old patch of mine, rather
than my latest patch (attachment 8537)

http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8537&action=edit

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

--- Comment #1 from Mason James  ---
(In reply to comment #0)
> opac-maintanance.pl should correctly redirect back to opac-main.pl, if no
> updates are outstanding
> 
> because of this bug, it's possible for the system to appear unavailable
> after an update, when it is actually available
> 
> a redirect from opac-maintance.pl would fix this problem :)

oops, i speld 'maintenance' worng 3 times... :p

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] New: opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7853
  Assignee: oleon...@myacpl.org
   Summary: opac-maintanance.pl should correctly redirect back to
opac-main.pl, if no updates are outstanding
QA Contact: koha.sek...@gmail.com
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: m...@kohaaloha.com
  Hardware: All
Status: NEW
   Version: master
 Component: OPAC
   Product: Koha

opac-maintanance.pl should correctly redirect back to opac-main.pl, if no
updates are outstanding

because of this bug, it's possible for the system to appear unavailable after
an update, when it is actually available

a redirect from opac-maintance.pl would fix this problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Elliott Davis  changed:

   What|Removed |Added

   Assignee|tda...@uttyler.edu  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7852] Hourly loan fines are not working

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852

Elliott Davis  changed:

   What|Removed |Added

   Assignee|tda...@uttyler.edu  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #2 from Elliott Davis  ---
Created attachment 8703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8703&action=edit
Adds Instant fine calculation at checkin

To Test:

Check out an Item, hourly items are best but any will do.  Make sure the item
is overdue, and when you check the item in you should see a fine reflected that
is correct for the amount of time it is overdue according to your smart rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7852] Hourly loan fines are not working

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852

Elliott Davis  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|kyle.m.h...@gmail.com   |tda...@uttyler.edu

--- Comment #1 from Elliott Davis  ---
Created attachment 8702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8702&action=edit
Add private function to calculate chargeable units and reconfigure
Koha/Calendar.pm to use this function.

To test:

Check out an hourly item, manipulate the database to backdate the checkin or
let the item go overdue whilst enjoying a sandwich.  After the Item is overdue
Check the item back in and wait for the fines cron job to run (or run it
yourself).  You should see a fine assessed for this item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

--- Comment #28 from Srdjan Jankovic  ---
Sequence will always be 0 for webservice batches. Those records are added
individually and sequence makes no sense in that context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7852] Hourly loan fines are not working

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852

Elliott Davis  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7852] New: Hourly loan fines are not working

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7852
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: Hourly loan fines are not working
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: tda...@uttyler.edu
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

When The fines cron runs there are no fines assessed for hourly items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #8625|0   |1
is obsolete||

--- Comment #18 from Srdjan Jankovic  ---
Created attachment 8701
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8701&action=edit
patch

It looks ok except when one person puts a specific item hold, and another
person has a non-specific hold. Can you please have a look and comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] OPAC search dies with plack

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] OPAC search dies with plack

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

--- Comment #1 from Chris Cormack  ---
Created attachment 8700
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8700&action=edit
Bug 7847 Undefined subroutine &C4::Search::GetHiddenItemnumbers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Marijana Glavica  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||mglav...@ffzg.hr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7851] New: circ/circulation.pl plack checkouts table empty

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7851

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7851
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: circ/circulation.pl plack checkouts table empty
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: mglav...@ffzg.hr
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7836] Poor English on Patron Attribute Form

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7836

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7836] Poor English on Patron Attribute Form

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7836

Chris Cormack  changed:

   What|Removed |Added

   Attachment #8690|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 8699
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8699&action=edit
Bug 7836 - Poor English on Patron Attribute Form

Signed-off-by: Chris Cormack 

(Poor being subjective, being an en-NZ speaker, all the US
misspellings are poor to me :))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7836] Poor English on Patron Attribute Form

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7836

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
(In reply to comment #1)
> Created attachment 8690 [details]
> Bug 7836 - Poor English on Patron Attribute Form
> 
> Sorry for my (very) poor english :-/

No need to be sorry, it's a million times better than my French is :) Thank you
very much for changing your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #1 from Kyle M Hall  ---
fyi, I have written a module to do fines on checkin for the Crawford County
Federated Library System. I will find the code and post it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7850] New: Fix values for hidden in subfields of 952 in NORMARC frameworks

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7850
  Assignee: mag...@enger.priv.no
   Summary: Fix values for hidden in subfields of 952 in NORMARC
frameworks
QA Contact: koha.sek...@gmail.com
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: mag...@enger.priv.no
  Hardware: All
Status: NEW
   Version: master
 Component: MARC Bibliographic data support
   Product: Koha

Some subfields of 952 in the NORMARC frameworks have hidden = -1 when they
should be 0, resulting in the fields not being displayed correctly in the item
edit screen. Gonna fix that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5337] acq EAN search

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337

Ian Walls  changed:

   What|Removed |Added

 CC||koha.sek...@gmail.com

--- Comment #25 from Ian Walls  ---
This patch does some pretty heavy-weight changes:  adds a new field to
biblioitems, modifies the parameters sent to a subroutine, and exports the MARC
flavour as a template variable on some pages.  All this is done for one of the
benefit of one of the three potential MARC flavours.  This doesn't mean we
shouldn't implement this, but it does mean we need to do so carefully, as there
are lots of places where new bugs could be introduced.


In terms of discussion, I contribute the following (though it may be a little
late in the game):

I think we may be better served by taking a wider view of the issue.  We've got
lots of kinds of identifiers floating around:  ISBN, ISSN, EAN, LCCN, UPC, OCLC
number, etc.  Depending on when they were invented, and what MARC flavour
you're working in, they can be mapped all kinds of different ways.  It would be
good to have an extensible framework where we can associate any given biblio
with a set of keys, of any kind.  Each type of key could be associated with a
normalization routine to weed out the formatting that is applied to the value
(added bonus: we could have just one key for ISBN, and have both 10 and 13
expressions connect to it).

We'd probably need to rely on Zebra with DOM indexing to get these values
properly extracted from our records, but once that's done, they could be
stashed in the database.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] New: Instant Fine Calculation at Checkin

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7849
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: Instant Fine Calculation at Checkin
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: tda...@uttyler.edu
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

Add the ability for fines to be calculated at checkin.  This will be helpful
for hourly based items so the cronjob for fines doesn't have to be run on such
a frequent interval.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #7992|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #8697|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 8698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8698&action=edit
Bug 7641 - Add ability to suspend reserves - Followup - Switch from C4::Dates
to $KohaDates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #8695|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 8697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8697&action=edit
Bug 7641 - Add ability to suspend reserves - Followup - Switch from C4::Dates
to $KohaDates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5742] batch edit patrons

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5742] batch edit patrons

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #8687|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 8696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8696&action=edit
But 5742 Batch edit patrons

Oups, perl v5.10 don't like an hashref for values. (It's ok in 5.14)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

--- Comment #9 from Kyle M Hall  ---
Created attachment 8695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8695&action=edit
Bug 7641 - Add ability to suspend reserves - Followup - Switch from C4::Dates
to $KohaDates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7848] Issues data missing from circulation notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|henridam...@koha-fr.org |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7848] Issues data missing from circulation notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7848] Issues data missing from circulation notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7848] Issues data missing from circulation notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848

--- Comment #1 from Kyle M Hall  ---
Created attachment 8694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8694&action=edit
Bug 7848 - Issues data missing from circulation notices

For the CHECKIN and CHECKOUT notices, any data that is issue specific
does not show. For example, date due.

This is caused not passing in the issues table as part of the
'table' hash used by C4::Letters::GetPreparedLetter.

Simple fix, add the issues table to the 'tables' hash passed
in to GetPreparedLetter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7848] New: Issues data missing from circulation notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7848
  Assignee: henridam...@koha-fr.org
   Summary: Issues data missing from circulation notices
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: kyle.m.h...@gmail.com
  Hardware: All
Status: NEW
   Version: rel_3_6
 Component: Notices
   Product: Koha

For the CHECKIN and CHECKOUT notices, any data that is issue specific does not
show. For example, date due.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

Paul Poulain  changed:

   What|Removed |Added

Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7821] XSLT systempreference multi-language support

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7821

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7821] XSLT systempreference multi-language support

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7821

Paul Poulain  changed:

   What|Removed |Added

Version|master  |rel_3_8

--- Comment #6 from Paul Poulain  ---
(In reply to comment #5)
> I agree. Something like \Q{langcode}\E would be much better. Should I
> re-submit patch or can QA fix this?

I've fixed it, by using \{ and \}

It work fine, thanks.

Note that the result will be broken if you use {langcode} but don't provide a
localised stylesheet for each language

For example, you have 
en/stylesheet.xsl
fr-FR/stylesheet.xsl
set the syspref to
{langcode}/stylesheet.xsl

and activate german at the OPAC: displaying in english and french will be OK,
in german, you'll get a nasty Perl error. Worth specifying it in the
documentation!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Dobrica Pavlinusic  changed:

   What|Removed |Added

   Attachment #8684|0   |1
is obsolete||

--- Comment #2 from Dobrica Pavlinusic  ---
Created attachment 8693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8693&action=edit
Bug 7844 - plack intranet tooling for developers

koha.psgi example and script to run any Koha site intranet or opac under plack

It also defines new enviroment variables:

PLACK_DEBUG=1  - turn Plack debug panels on
PLACK_MINIFY=1 - minify JavaScript and CSS which saves us ~10k on each page
load

Test scenario:
1. install plack and dependencies, using ./cpanm-install.pl

2. start ./intranet-plack.sh sitename

3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl
   and verify that it works

4. start ./opac-plack.sh sitename

5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl
   and very that it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] OPAC search dies with plack

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Blocks||7844

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Depends on||7847

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5337] acq EAN search

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #40 from Paul Poulain  ---
patch pushed. The "biblibre test" stuff is related to how we called at first
the syspref, and it have been made live for some of our customers. We would be
really unlucky if somone had had the idea of developing something with a local
syspref that has the same name !!! (or, we're very lucky and should go to Las
Vegas ;-) )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5337] acq EAN search

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337

Matthias Meusburger  changed:

   What|Removed |Added

   Attachment #8380|0   |1
is obsolete||

--- Comment #24 from Matthias Meusburger  ---
Created attachment 8692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8692&action=edit
Bug 5337: EAN management : Adds ean for various searches

- in various acquisition pages and serials home
  - in database : biblioitems.ean
  - adds ean and its mapping in default english bibliographic framework
  - adds ean mapping in default french bibliographic framework
  - ean search is not enabled for MARC21

The required mapping between the ean marc field and the biblioitems.ean
database field will be automatically added on an existing unimarc installation.

However, if you already have records with ean, you will have to
run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7729] svc API should allow modification of items

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7729

Paul Poulain  changed:

   What|Removed |Added

Version|unspecified |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7729] svc API should allow modification of items

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7729

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Paul Poulain  ---
(In reply to comment #9)
> Pasting the reply that I emailed in and it never appeared:


I'm not sure I understand your answer, but I'm not sure I can explain clearly
my concern either.

So pushing, please everybody double check to be sure there's no problem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7172] Data Persistency

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Depends on||7847

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] OPAC search dies with plack

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||7172
   Assignee|gmcha...@gmail.com  |dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] New: OPAC search dies with plack

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7847
  Assignee: gmcha...@gmail.com
   Summary: OPAC search dies with plack
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: dpav...@rot13.org
  Hardware: All
Status: NEW
   Version: master
 Component: Searching
   Product: Koha

Undefined subroutine &C4::Search::GetHiddenItemnumbers called at
/srv/koha_fer/opac/../C4/Search.pm line 1627.
 at /srv/koha_fer/opac/opac-search.pl line 780

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5742] batch edit patrons

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

Julien Sicot  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||julien.si...@gmail.com

--- Comment #2 from Julien Sicot  ---
I applied the patch and followed the plan test but I've got an error on step 1
by clicking on Patrons modification link (/cgi-bin/koha/tools/modborrowers.pl).

The error message is below :

"Software error:
Type of arg 1 to values must be hash (not private variable) at
/home/koha/src/tools/modborrowers.pl line 89, near "$patron_attribute_types ) "
Execution of /home/koha/src/tools/modborrowers.pl aborted due to compilation
errors."

Tested on sandbox.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

MJ Ray (software.coop)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

MJ Ray (software.coop)  changed:

   What|Removed |Added

   Attachment #8678|0   |1
is obsolete||

--- Comment #27 from MJ Ray (software.coop)  ---
Created attachment 8691
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8691&action=edit
bug_7613: OCLC Connexion gateway

svc/import_bib:
* takes POST request with parameters in url and MARC XML as DATA
* pushes MARC XML to an impoort bach queue of type 'webservice'
* returns status and imported record XML
* is a drop-in replacement for svc/new_bib

misc/cronjobs/import_webservice_batch.pl:
* a cron job for processing impoort bach queues of type 'webservice'
* batches can also be processed through the UI

misc/bin/connexion_import_daemon.pl:
* a daemon that listens for OCLC Connexion requests and is compliant
  with OCLC Gateway spec
* takes request with MARC XML
* takes import batch params from a config file and forwards the lot to
  svc/import_bib
* returns status

ImportBatches:
* Added new import batch type of 'webservice'
* Changed interface to AddImportBatch() - now it takes a hashref
* Replaced batch_type = 'batch' with
  batch_type IN ( 'batch', 'webservice' ) in some SELECTs

Signed-off-by: MJ Ray 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

--- Comment #26 from MJ Ray (software.coop)  ---
Now there's a 0 to the left of every bib shown on screens like
http://intranet/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=14

I can't be sure (cleaned all old imports during testing) but I'm
pretty sure that was working until this patch.  Sorry!

I think I'm willing to sign it off without fixing that problem as it
seems to be merely cosmetic, but I'm checking with #koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6802] with IndependantBranches on can still edit items

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6802

--- Comment #3 from Nicole C. Engard  ---
This is fixed in master. Is it still a problem is 3.6?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #5 from Paul Poulain  ---
My tests show 2 problems:
* when you set the syspref to "allow", the user should be able to choose "next
available" or any item. I can't have the item list appearing !
* when you set the syspref to "force", it seems good, as you get the items list
and no option to say "next available". BUT, you can submit the form without
choosing any item, and in this case, it seems that you've placed a "next
available" hold.

The 3rd option (don't allow) is OK

Overall, it may be easy to fix, but for now it does not work.

PS: anyone who tests and want to switch back to master =
DELETE from systempreferences WHERE variable="OPACItemHolds";
INSERT INTO `systempreferences` (variable,value,explanation,options,type)
VALUES('OPACItemHolds','1','Allow OPAC users to place hold on specific items.
If OFF, users can only request next available copy.','','YesNo');

will revert you to "without 7825 applied"
If you just switch to master branch, things go crazy because the syspref is no
more 0/1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7836] Poor English on Patron Attribute Form

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7836

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7836] Poor English on Patron Attribute Form

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7836

--- Comment #1 from Jonathan Druart  ---
Created attachment 8690
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8690&action=edit
Bug 7836 - Poor English on Patron Attribute Form

Sorry for my (very) poor english :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3521] Items table in catalogue/detail.pl and cataloguing/additem.pl is sorted nonsensically

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3521

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3521] Items table in catalogue/detail.pl and cataloguing/additem.pl is sorted nonsensically

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3521

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #8688|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 8689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8689&action=edit
Bug 3521 - Items table in catalogue/detail.pl and cataloguing/additem.pl is
sorted nonsensically

Based on patch submitted by Ian Walls

Items were sorted by branch, then date accessioned, in GetItemsInfo.  While
this can be
helpful in some circumstances, more often it is useful for items to be sorted
first by
their enumchron (volume/issue, if applicable) then by their copy number.  This
patch changes the
sort on GetItemsInfo to branch, enumcrhon, copynumber then date accessioned.

As sorting on copynumber will be incorrect based on standard sorting ( e.g. 1,
10, 2, 20 ),
the copynumber is now padded with leading zeros to correct the sorting ( e.g.
01, 02, 10 20 ).
This function appears to be a standard SQL function and not a mysql-ism. I have
verfified
that is available in MySQL, Postgres, and Oracle.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3521] Items table in catalogue/detail.pl and cataloguing/additem.pl is sorted nonsensically

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3521

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #5180|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 8688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8688&action=edit
Bug 3521 - Items table in catalogue/detail.pl and cataloguing/additem.pl is
sorted nonsensically

Based on patch submitted by Ian Walls

Items were sorted by branch, then date accessioned, in GetItemsInfo.  While
this can be
helpful in some circumstances, more often it is useful for items to be sorted
first by
their enumchron (volume/issue, if applicable) then by their copy number.  This
patch changes the
sort on GetItemsInfo to branch, enumcrhon, copynumber then date accessioned.

As sorting on copynumber will be incorrect based on standard sorting ( e.g. 1,
10, 2, 20 ),
the copynumber is now padded with leading zeros to correct the sorting ( e.g.
01, 02, 10 20 ).
This function appears to be a standard SQL function and not a mysql-ism. I have
verfified
that is available in MySQL, Postgres, and Oracle.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5742] batch edit patrons

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5742] batch edit patrons

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

--- Comment #1 from Jonathan Druart  ---
Created attachment 8687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8687&action=edit
But 5742: Batch edit patrons

new permission : edit_patrons

Plan test:
- Go on the page: tools > Patrons modification (modborrowers.pl)
- Enter a list of cardnumbers (or use a file)
- Modify one or more patron's fields (you can modify surname, firstname,
branchname, category, sort1, sort2, date of enrollment, date of expiry,
debarred date, debarred comment and borrower note)
- Save
- Check on the result page (or in database for non-displayed fields) if
modifications have been correctly made.
- re test with different attributes. For each attributes filled with an
authorized value category, you can select a value in a drop-down list.
Else it's a free input text. If your attribute is filled with a patron
category, the modification performs only on patrons belonging to this
category
- Save
- Verify on the result page

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Dobrica Pavlinusic  changed:

   What|Removed |Added

Summary|plack scripts for startup   |plack scripts for
   ||developers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7821] XSLT systempreference multi-language support

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7821

--- Comment #5 from Dobrica Pavlinusic  ---
I agree. Something like \Q{langcode}\E would be much better. Should I re-submit
patch or can QA fix this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7846] get_batch_summary massive speedup

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|cnighswon...@foundations.ed |dpav...@rot13.org
   |u   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7846] get_batch_summary massive speedup

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

--- Comment #1 from Dobrica Pavlinusic  ---
Created attachment 8686
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8686&action=edit
Bug 7846 - get_batch_summary massive speedup

current code is using DISTINCT and another SQL query which can be replaced with
GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time
decreased
from 24.762 s to 0.147 s

Aside from correct usage of relational database, this change also cleans up
code nicely.

Test scenario:

1. open Manage Batches screen and take note of time needed to generate it
2. apply this patch
3. reload page and check page genration time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7846] New: get_batch_summary massive speedup

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7846
  Assignee: cnighswon...@foundations.edu
   Summary: get_batch_summary massive speedup
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: dpav...@rot13.org
  Hardware: All
Status: NEW
   Version: master
 Component: Label printing
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7845] New: Multiple 260s don't display properly in search results

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7845

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7845
  Assignee: katrin.fisc...@bsz-bw.de
   Summary: Multiple 260s don't display properly in search results
QA Contact: koha.sek...@gmail.com
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: OPAC
   Product: Koha

If you have multiple 260 fields in a record, they are all run together in the
search results, so that there is no space between the 260$c in the first field
and the 260$a in the second field. They display properly in the details
display, with spacing and a semicolon between them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7482] overdues report downloads without names

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7482] overdues report downloads without names

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482

--- Comment #1 from Kyle M Hall  ---
Created attachment 8685
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8685&action=edit
Bug 7482 - overdues report downloads without names

This bug is caused by the build_csv subroutine in
overdue.pl using the hash key 'name' for the name field
which does not exist.

Fixed by adding the name field as a concatenation of
firstname and surname to the loop that builds the array of
hashrefs, @overduedata. It will be ignored by the Koha 'html'
view of the overdue data and will only be used when exporting
overdues to csv.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7701] Error when sending serial alerts

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7701

--- Comment #9 from Katrin Fischer  ---
:(

I am not sorry what went wrong in my tests, but I am worried about getting no
email. I know this used to work on our 3.2.2 installations and want to do more
tests, but not sure when I will have the time. Could someone with working email
setup test on master and report of a mail is sent or not? The template used
normally is RLIST. I noted the test plan in my sign off comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7835] submit and cancel buttons on diff lines on notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7835

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7835] submit and cancel buttons on diff lines on notices

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7835

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||paul.poul...@biblibre.com

--- Comment #3 from Paul Poulain  ---
QA comment: tiny patch, passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

koala  changed:

   What|Removed |Added

 CC||programm...@tyndale.cam.ac.
   ||uk

--- Comment #9 from koala  ---
(In reply to comment #7)
> Is anyone thinking/working on getting this into Koha?

yes, we are. We do not allow patrons to check out books, so the
self-registration would be great.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Paul Poulain  ---
patch pushed.

(In reply to comment #7)
> PostgreSQL has the CASE statement as well.  I will check if it is compatible
> with the standard and MySQL.  For now, I say treat CASE as non mysqlism, I
> took a note to recheck this file in case it is one

thx marc for the very quick reply !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

--- Comment #7 from Marc Balmer  ---
PostgreSQL has the CASE statement as well.  I will check if it is compatible
with the standard and MySQL.  For now, I say treat CASE as non mysqlism, I took
a note to recheck this file in case it is one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7641] Add ability to suspend reserves.

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@msys.ch

--- Comment #6 from Paul Poulain  ---
tests  comments:
* I tested many cases, could not find any problem
* a possible enhancement could be for a patron to suspend holds one by one from
the opac-user page. The common use-case is a patron that is unavailable for a
long trip, another is "i placed a hold on volume 1 and 2, but want to suspend
volume 2 until I have volume 1 in my hands". but that could be a future ENH

QA comments:
* There are 2 unconditional warnings in the logs:
[Thu Mar 29 14:46:24 2012] [error] [client 127.0.0.1] [Thu Mar 29 14:46:24
2012] opac-modrequest-suspend.pl: C4::Reserves::SuspendAll( borrowernumber =>
7852, biblionumber => , suspend_until => , suspend => 0 ) at
/home/paul/koha.dev/koha-community/C4/Reserves.pm line 1562., referer:
http://lecannet/cgi-bin/koha/opac-user.pl
I've removed them in a follow-up

* not worth failing QA because the rule is still at early stage, but a
follow-up is requested for :
+my $query = "UPDATE reserves SET suspend = 0, suspend_until = NULL WHERE
DATE( suspend_until ) < DATE( CURDATE() )"; CURDATE is a mysqlism (see
http://wiki.koha-community.org/wiki/PostgreSQL => CAST(now as date)

* MARC BALMER (our mysqlism specialist :-) ) putting you in the loop: this
patch contains 
+"UPDATE reserves SET suspend = NOT suspend,
+suspend_until = CASE WHEN suspend = 0 THEN NULL ELSE suspend_until END
=> is it a mysqlism or no ? If yes, add it to your wiki page

* prove translatable_templates and valid_templates are OK

* misc/cronjobs/holds/auto_unsuspend_holds.pl had use strict/use warning
commented, I've uncommented them in a follow-up, works fine
* opac/opac-modrequest-suspend.pl and reserve/modrequest_suspendall.pl passes
perlcritic

* the 
+[% IF ( reservloo.suspend ) %]Suspended [% IF (
reservloo.suspend_until ) %] until [% reservloo.suspend_until %][% END %][% END
%]
should use kohaDates, not
+$getreserv{suspend_until} = C4::Dates->new(
$num_res->{'suspend_until'}, "iso")->output("syspref");;

I'll pass QA & push because everything is OK except thig kohaDates display, but
please provide a follow-up ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6655] Sorting order of serial issues in OPAC

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6655

--- Comment #3 from Savitra Sirohi  ---
Design: we will change the default sort order, table sorters or datatables can
be used to resort the data once the screen is displayed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740

--- Comment #2 from Savitra Sirohi  ---
Customer would like to have this behavior for users not logged in to the OPAC. 

Modified design:

We will use the OPAC URL being used (e.g. library1.domain.org) to identify the
user's library. Once the library is known we can highlight the items in that
library in the OPAC search results and in the OPAC detail page.

The assumption here is that a different URL can be setup for each library on
the system that wants to use this feature.

So there could be a common URL for all libraries that are on the particular
Koha install, say www.domain.org. And then each library that needs this feature
will have their own URL, say library1.domain.org, library2.domain.org.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7810] C4/Auth.pm - on plack restart session is undefined

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7810

--- Comment #5 from Dobrica Pavlinusic  ---
I can easily reproduce this bug by changing Koha site for plack using tools
from Bug 7844

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

--- Comment #5 from Jared Camins-Esakov  ---
(In reply to comment #4)
> (In reply to comment #2)
> > In particular, note that 245$c in the GRS-1 configuration does *not* get put
> > into the Title index. In C4::Search, hits in the Title index are marked as
> > r3, which (under GRS-1) ignores the statement of responsibility in 245$c.
> > With the conversion of record.abs to DOM indexes, the Title:w, Title:p
> > indexes now include the statement of responsibility, which means that
> > authors' names will be given r3 ranking, *plus* the additional weighting for
> > appearing additional times elsewhere in the record.
> 
> My inclination would be to add a "title-rel" index to the index config that
> includes (say) the 245$a and $b and have that be used for the hard-coded
> relevance ranking, with suitable shimming to leave GRS-1-based configs
> unaffected.  Thoughts?

+1 from me. I'd suggest adding title-rel to record.abs, and just adjust the r3
configuration for all installations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

--- Comment #4 from Galen Charlton  ---
(In reply to comment #2)
> In particular, note that 245$c in the GRS-1 configuration does *not* get put
> into the Title index. In C4::Search, hits in the Title index are marked as
> r3, which (under GRS-1) ignores the statement of responsibility in 245$c.
> With the conversion of record.abs to DOM indexes, the Title:w, Title:p
> indexes now include the statement of responsibility, which means that
> authors' names will be given r3 ranking, *plus* the additional weighting for
> appearing additional times elsewhere in the record.

My inclination would be to add a "title-rel" index to the index config that
includes (say) the 245$a and $b and have that be used for the hard-coded
relevance ranking, with suitable shimming to leave GRS-1-based configs
unaffected.  Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for startup

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

--- Comment #1 from Dobrica Pavlinusic  ---
Created attachment 8684
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8684&action=edit
Bug 7844 - plack intranet tooling for developers

intranet.psgi example and script to run any Koha intranet under plack

This assumes that intranetdir in koha-conf.xml points to source code checkout.

It also defines new enviroment variables:

PLACK_DEBUG - turn debugging panels on
PLACK_MINIFY - minify JavaScript and CSS which saves us ~10k on each page load

Test scenario:
1. install plack, using ./cpanm-install.pl
2. start ./intranet-plack.sh sitename
   from misc/plack directory so it can find intranet.psgi here
3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #8335|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  ---
Created attachment 8683
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8683&action=edit
Bug 5342: Followup: Delete all occurrences of preview

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #8611|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  ---
Created attachment 8682
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8682&action=edit
Bug 5342: Adds a claims_count field in the serial table

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7821] XSLT systempreference multi-language support

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7821

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #4 from M. de Rooy  ---
Just mentioning: Think the test /{langcode}/ works, but to my knowledge(..)
curly braces should better be escaped in a regex. Normally they are used for
repetition (a{2} means two characters a).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

M. de Rooy  changed:

   What|Removed |Added

   Priority|P1 - high   |P3
 Status|Signed Off  |Passed QA
 CC||m.de.r...@rijksmuseum.nl
   Hardware|PC  |All
Version|rel_3_4 |master
 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #39 from M. de Rooy  ---
Like this patch. Just have the impression that we once had this already?
Anyhow, looks good. Two minor remarks:

Error checking: What happens when GetURI returns undef on a URL? Could you fall
back to default or no xslt view? 
Now you have a perl error: Empty String at /usr/share/koha/testclone/C4/XSLT.pm
line 208
This needs a followup.

You test Biblibre by: SELECT 1 FROM systempreferences WHERE
variable="IntranetXSLTDetailsDisplay"
Just theoretically, but someone else using this local pref could run into
problems.. No blocker.

Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7175] Improve order receiving page

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7175] Improve order receiving page

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

Julian Maurice  changed:

   What|Removed |Added

   Attachment #7853|0   |1
is obsolete||

--- Comment #21 from Julian Maurice  ---
Created attachment 8681
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8681&action=edit
Allow to choose which items to receive

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >