[Koha-bugs] [Bug 7929] Duplicate id "availability" on XSLT result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7929 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com --- Comment #6 from Mason James --- trivial patch - passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7929] Duplicate id "availability" on XSLT result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7929 Mason James changed: What|Removed |Added Attachment #9243|0 |1 is obsolete|| --- Comment #5 from Mason James --- Created attachment 9362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9362&action=edit Bug 7929 - Duplicate id "availability" on XSLT result page Changes id="availability" to class="availability" for XHTML valididy (ids have to be unique on a page). Signed-off-by: mveron Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8024] 'cart' icon is duplicated, and spelt incorrectly (panier)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8024 Mason James changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Mason James --- (In reply to comment #1) > I don't see this in master. Can you provide more details about the > circumstances? oops, my mistake :) (i had some goofy jquery added when testing) closing ticket... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7949] a different favicon for the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7949 Mason James changed: What|Removed |Added Attachment #9347|0 |1 is obsolete|| --- Comment #7 from Mason James --- Created attachment 9361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9361&action=edit Bug 7949 - a different favicon for the staff client Different favicon proposal Signed-off-by: Jared Camins-Esakov Signed-off-by: Mason James Important note: you need to clear your web cache in order for the change to take effect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com --- Comment #34 from Mason James --- passing QA - passes perlcritic OK, and both tests pass OK i've squashed the two patches into one, applied to 142c62081fc15bbd994e737eef55e29b61a6d730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Mason James changed: What|Removed |Added Attachment #9352|0 |1 is obsolete|| Attachment #9353|0 |1 is obsolete|| --- Comment #33 from Mason James --- Created attachment 9360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9360&action=edit Bug 7248 Added caching support and and moved Caching into Koha namespace Unit test for Koha/Cache.pm (which includes Koha/Cache/Memcached.pm) Note that in order to test Koha::Cache you must export the environment variable MEMCACHED_SERVERS. For example: $ export MEMCACHED_SERVERS=127.0.0.1:11211 Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8024] 'cart' icon is duplicated, and spelt incorrectly (panier)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8024 --- Comment #1 from Owen Leonard --- I don't see this in master. Can you provide more details about the circumstances? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8024] New: 'cart' icon is duplicated, and spelt incorrectly (panier)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8024 Priority: P5 - low Change sponsored?: --- Bug ID: 8024 Assignee: oleon...@myacpl.org Summary: 'cart' icon is duplicated, and spelt incorrectly (panier) Severity: enhancement Classification: Unclassified OS: All Reporter: m...@kohaaloha.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 9359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9359&action=edit image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5184] Upgrade jQuery to the latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James changed: What|Removed |Added Attachment #9357|0 |1 is obsolete|| --- Comment #19 from Mason James --- Created attachment 9358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9358&action=edit Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger Signed-off-by: Mason James -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5184] Upgrade jQuery to the latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James changed: What|Removed |Added Attachment #9285|0 |1 is obsolete|| --- Comment #18 from Mason James --- Created attachment 9357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9357&action=edit Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5184] Upgrade jQuery to the latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James changed: What|Removed |Added Attachment #9286|0 |1 is obsolete|| --- Comment #17 from Mason James --- Created attachment 9356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9356&action=edit Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger Signed-off-by: Mason James -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 Katrin Fischer changed: What|Removed |Added Attachment #9354|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 9355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9355&action=edit [SIGNED-OFF] Bug 7249: Syspref to control number of rows in web service results The original patches for bug 7249 had a hardcoded limit of ten rows in the results returned by the web service. This patch adds a SvcMaxReportRows syspref which allows the librarian to choose how many rows should be returned by the web service. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 --- Comment #24 from Jared Camins-Esakov --- Created attachment 9354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9354&action=edit Bug 7249: Syspref to control number of rows in web service results The original patches for bug 7249 had a hardcoded limit of ten rows in the results returned by the web service. This patch adds a SvcMaxReportRows syspref which allows the librarian to choose how many rows should be returned by the web service. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 --- Comment #32 from Katrin Fischer --- Created attachment 9353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9353&action=edit [SIGNED-OFF] Bug 7248 Unit test for Koha/Cache.pm (which includes Koha/Cache/Memcached.pm) Note that in order to test Koha::Cache you must export the environment variable MEMCACHED_SERVERS. For example: $ export MEMCACHED_SERVERS=127.0.0.1:11211 Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Katrin Fischer changed: What|Removed |Added Attachment #9348|0 |1 is obsolete|| Attachment #9349|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 9352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9352&action=edit [SIGNED-OFF] Bug 7248 Added caching support and and moved Caching into Koha namespace Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 Katrin Fischer changed: What|Removed |Added Attachment #9350|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 9351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9351&action=edit Bug 7249 : Allow reports to be called through a restful interface Hands back JSON, and supports caching Squashed commit of the following: commit 5c93506079738b9a13139417d3a0734289a4b007 Author: Chris Hall Date: Mon Nov 21 15:41:14 2011 +1300 Fixed bugs when creating reports, added more user friendly input and feedback commit c62430bb358ee4af6ee5331b4d3a2ed67f723032 Author: Chris Hall Date: Mon Nov 21 12:00:27 2011 +1300 Added caching to intranet report webservices, added cache expiry and public options to reports commit 2d89f0777d95b26bf08635782070b6367d0698f3 Author: Chris Cormack Date: Wed Nov 9 20:29:26 2011 +1300 Working on caching for services commit e0511f180cebd81747858ad776433fe3a1cf6854 Author: Chris Cormack Date: Wed Nov 9 08:28:26 2011 +1300 Starting work on webservices Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Patch includes database update adding 2 new fields to the saved_sql table. 1) Checked that adding/deleting/editing of sql reports still works and new fields are correctly saved to the database. 2) The saved reports page now lists the new fields correctly. 3) Checking URLs with JSON output - if report is not public http://localhost/cgi-bin/koha/svc/report?id=2 fails, but http://localhost:8080/cgi-bin/koha/svc/report?id=2 works - if report is public, both links work 4) Checking results are cached Created a report listing my borrowers, setting caching to 60 seconds and added new borrowers before doing following tests. - URL doesn't show new borrower immediately - correct - Turning off the usecache system preference updates data - correct - Restarting memcached updates data '/etc/init.d/memcached restart' - correct - Waiting until cache time runs out updates data - correct Signed-off-by: Jared Camins-Esakov Signed-off-by: Katrin Fischer Retested the feature and renewing my sign-off. There are some things that should be noted: - currently there is a hardcoded limit of 10 results for the reports webservice - reports with runtime parameters are currently not supported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8023] New: Facebook share link not used current localization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Priority: P5 - low Change sponsored?: --- Bug ID: 8023 Assignee: frede...@tamil.fr Summary: Facebook share link not used current localization Severity: enhancement Classification: Unclassified OS: All Reporter: du...@library.lviv.ua Hardware: All Status: NEW Version: unspecified Component: I18N/L10N Product: Koha When share link on Facebook, cover, link and description was shared great, but in title used "catalog › Details for:" in English undepended from current choosed language in Koha. For example: http://koha.tntu.edu.ua/cgi-bin/koha/opac-detail.pl?biblionumber=47944 Share title: Науково-технічна бібліотека ТНТУ ім. Івана Пулюя catalog › Details for: Вогнесміх but must: Науково-технічна бібліотека ТНТУ ім. Івана Пулюя › Електронний каталог › Подробиці щодо: „Вогнесміх“ (or in other native language of reader) I try append share link with "&language=uk-UA" (http://www.facebook.com/sharer.php?u=koha.tntu.edu.ua/cgi-bin/koha/opac-detail.pl?biblionumber=47944&t=%D0%92%D0%BE%D0%B3%D0%BD%D0%B5%D1%81%D0%BC%D1%96%D1%85&language=uk-UA) but it not help -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 Jared Camins-Esakov changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7249] Report webservices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7249 Jared Camins-Esakov changed: What|Removed |Added Attachment #6774|0 |1 is obsolete|| Attachment #6775|0 |1 is obsolete|| Attachment #6803|0 |1 is obsolete|| --- Comment #22 from Jared Camins-Esakov --- Created attachment 9350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9350&action=edit Bug 7249 : Allow reports to be called through a restful interface Hands back JSON, and supports caching Squashed commit of the following: commit 5c93506079738b9a13139417d3a0734289a4b007 Author: Chris Hall Date: Mon Nov 21 15:41:14 2011 +1300 Fixed bugs when creating reports, added more user friendly input and feedback commit c62430bb358ee4af6ee5331b4d3a2ed67f723032 Author: Chris Hall Date: Mon Nov 21 12:00:27 2011 +1300 Added caching to intranet report webservices, added cache expiry and public options to reports commit 2d89f0777d95b26bf08635782070b6367d0698f3 Author: Chris Cormack Date: Wed Nov 9 20:29:26 2011 +1300 Working on caching for services commit e0511f180cebd81747858ad776433fe3a1cf6854 Author: Chris Cormack Date: Wed Nov 9 08:28:26 2011 +1300 Starting work on webservices Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Patch includes database update adding 2 new fields to the saved_sql table. 1) Checked that adding/deleting/editing of sql reports still works and new fields are correctly saved to the database. 2) The saved reports page now lists the new fields correctly. 3) Checking URLs with JSON output - if report is not public http://localhost/cgi-bin/koha/svc/report?id=2 fails, but http://localhost:8080/cgi-bin/koha/svc/report?id=2 works - if report is public, both links work 4) Checking results are cached Created a report listing my borrowers, setting caching to 60 seconds and added new borrowers before doing following tests. - URL doesn't show new borrower immediately - correct - Turning off the usecache system preference updates data - correct - Restarting memcached updates data '/etc/init.d/memcached restart' - correct - Waiting until cache time runs out updates data - correct Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Jared Camins-Esakov changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Jared Camins-Esakov changed: What|Removed |Added Attachment #7367|0 |1 is obsolete|| --- Comment #30 from Jared Camins-Esakov --- Created attachment 9349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9349&action=edit Bug 7248 Unit test for Koha/Cache.pm (which includes Koha/Cache/Memcached.pm) Note that in order to test Koha::Cache you must export the environment variable MEMCACHED_SERVERS. For example: $ export MEMCACHED_SERVERS=127.0.0.1:11211 Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7248] Caching for services
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7248 Jared Camins-Esakov changed: What|Removed |Added Attachment #7366|0 |1 is obsolete|| --- Comment #29 from Jared Camins-Esakov --- Created attachment 9348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9348&action=edit Bug 7248 Added caching support and and moved Caching into Koha namespace Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/