[Koha-bugs] [Bug 8083] Granular parameters permissions

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Srdjan, 
I think adding granular permissions for administration is a good idea and I can
think of more to be added later :)

But I am not sure the system preference is needed here. We already have
granular permissions for other modules. All granular permissions used to be
controlled by a system preference that got removed after some time, because
granular got to be standard over permissions on module level only.

I think it should also be ok on update if both granular permissions are checked
by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8083] New: Granular parameters permissions

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8083
CC: gmcha...@gmail.com
  Assignee: paul.poul...@biblibre.com
   Summary: Granular parameters permissions
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: srd...@catalyst.net.nz
  Hardware: All
Status: NEW
   Version: unspecified
 Component: System Administration
   Product: Koha

Introduce 'manage_circ_rules' and 'parameters_remaining_permissions' parameters
subpermissions.

Add "GranularParametersPermissions" boolean syspref, No default. If set to yes
use aforementioned subpermissions in admin/* functions, otherwise just use
parameters flag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #5 from Frédéric Demians  ---
I confirm the bug, its severity, and your diagnostic. There should be
already get an issue before 3.8. Email sent by Koha comes from a
template which isn't strictly a template. There is a pseudo-syntax
allowing subject/message extraction. But this mini-templating system
isn't compliant with our current translation system which doesn't
preserve new lines: it doesn't matter in HTML; it's important in raw
text, which is used in basket email.

We must rewrite in HTML the email sent by OPAC Send your Basket
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #4 from Katrin Fischer  ---
After giving it some thought I think the main problem here is that our
translation scripts are not made to parse a plain text file, but TT and HTML. I
also tried adding the line breaks back in Poedit, but they get taken out again
on saving the file. We can also not use \n or similar, because that will also
cause problems (bug 4883)

Without the line breaks the formatting is broken and the regex searching for
the markers ( etc) are not working.

I am a bit out of ideas right now on how to fix that.

This is a big problem for every translated Koha installation. It's not only
affecting the OPAC cart, but also staff cart and sending lists from both staff
and cart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #8 from David Cook  ---
Thanks for pointing that out, Chris! Much appreciated.

(In reply to comment #6)
> 
> You are right :)
> 
> But it is your patch creating the file with 644
> 
> create mode 100644 members/routing-lists.pl
> 
> So you might want to chmod +x it in your repo, git add, git commit --amend
> and send a new patch that sets the right permissions. Or everyone will face
> this problem on install.
> 
> Chris

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook  changed:

   What|Removed |Added

   Attachment #8855|0   |1
is obsolete||

--- Comment #7 from David Cook  ---
Created attachment 9550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9550&action=edit
Updated patch (w/ proper file permissions)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8056] CircAutoPrintQuickSlip set to clear doesn't work

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8056

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #9506|0   |1
is obsolete||

--- Comment #6 from Srdjan Jankovic  ---
Created attachment 9549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9549&action=edit
patch

Good catch, corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589

--- Comment #7 from Mason James  ---
(In reply to comment #5)
> I tried this patch, and it didn't seem to fix the problem.

i just built and installed a Koha debian package, from these instruction...
http://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way


i applied this patch, and confirmed tiny_mce is now working


screen-shot attached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589

--- Comment #6 from Mason James  ---
Created attachment 9548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9548&action=edit
pix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse.

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #3 from Chris Cormack  ---
.pref file text now matches reality

 if ( C4::Context->preference("IssuingInProcess") ) {

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse.

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082

--- Comment #2 from Chris Cormack  ---
Created attachment 9547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9547&action=edit
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse.

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack  ---
Yep at some point the description was changed

It is still right in the database

| IssuingInProcess   | 1 | NULL| If ON, disables fines if the
patron is issuing item that accumulate debt | YesNo |

Yes = On  ... but now
Prevent = On

So if switch prevent on, it does the checks about being in process and lets the
issue proceed if it is in process.

So it is backwards.

Easiest fix is to fix the circulation.pref file, so the description matches
reality.

Patch forthcoming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8034] Enable server print queue selection

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #9386|0   |1
is obsolete||

--- Comment #3 from Srdjan Jankovic  ---
Created attachment 9546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9546&action=edit
patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8034] Enable server print queue selection

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7846] get_batch_summary reimplements GROUP BY in perl code

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7846] get_batch_summary reimplements GROUP BY in perl code

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9175|0   |1
is obsolete||

--- Comment #15 from Chris Cormack  ---
Created attachment 9545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9545&action=edit
Bug 7846 - get_batch_summary massive speedup

current code is using DISTINCT and another SQL query which can be replaced with
GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time
decreased
from 24.762 s to 0.147 s

Aside from correct usage of relational database, this change also cleans up
code nicely.

This change removed semi-columns from SQL query which broke Manage Patron
batches.

Test scenario:

1. open Manage Batches screen and take note of time needed to generate it
2. apply this patch
3. reload page and check page genration time

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7926] Acq search results show empty parenthesis for orders without basket group

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7926

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7926] Acq search results show empty parenthesis for orders without basket group

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7926

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9043|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 9544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9544&action=edit
Bug 7926: Acq search results show empty () for orders without basket group

To test:
- search for orders by title or vendor
- make sure some results are attached to a basket group, while others are not
- make sure correct information shows in the basket group column of search
results

Signed-off-by: Chris Cormack 

- Fixed merge conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8082] New: The: IssuingInProcess configuration setting is working in reverse.

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8082
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: The:  IssuingInProcess  configuration setting is
working in reverse.
  Severity: major
Classification: Unclassified
OS: All
  Reporter: jran...@library.org.nz
  Hardware: PC
Status: NEW
   Version: rel_3_6
 Component: Circulation
   Product: Koha

In the system preferences it is possible to nominate a $ value limit using a
couple of confurable settings: maxoutstanding ang noissuescgarge  

A further system preference (IssuingInProcess) can be set to prevent / not
prevent issues in a single session from being blocked if that threshold is
reached.

For example: Koha Patrons have  $5 limit on their account. Patrons often borrow
more than that in one transaction/session. So a transaction/session may be
carried out to completion even if the amount owed goes over $5. They will
however be blocked from any new borrowing until that debt is reduced below $5.

If the IssuingInProcess is set to  it, illogically, doesn't prevent -
and vice versa. It is working backwards.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8040] a menu misnamed in budgets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8040

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8040] a menu misnamed in budgets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8040

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9395|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 9543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9543&action=edit
Bug 8040: bad name in acquisitions-menu

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5795] Missing ReservesControlBranch system pref in database installer

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5795] Missing ReservesControlBranch system pref in database installer

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9451|0   |1
is obsolete||

--- Comment #10 from Chris Cormack  ---
Created attachment 9542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9542&action=edit
Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has
null then update the table to insert a ItemHomeLibrary as value

To Test:
1) Go to mysql use koha database
2) select * from systempreferences where variable = 'ReservesControlBranch';
Check if value set to ItemHomeLibrary.
+---+-+---+-++
| variable  | value   | options   |
explanation | type   |
+---+-+---+-++
| ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary |
Branch checked for members reservations rights. | Choice |
+---+-+---+-++

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5795] Missing ReservesControlBranch system pref in database installer

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9320|0   |1
is obsolete||

--- Comment #9 from Chris Cormack  ---
Created attachment 9541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9541&action=edit
Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database
installer

sysprefs.sql file was missing ReservesControlBranch.

To test:
1) Create a new installation and check sysprefs.sql loads correctly.
2) Check ReservesControlBranch shows up correctly in the sys pref editor.
3) Check sys pref can be edited and new value saves correctly.

Signed-off-by: Marc Veron 

- Line is added at the end of installer/data/mysql/sysprefs.sql
- Tested Line diretly in MySQL with a systempreferences table where variable
'ReservesControlBranch' was missing. Data inserted correctly.
- Syspref shows up in Staff client

Signed-off-by: Chris Cormack 

- Fixed merge conflict

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7604] Link on basket group name for closed basket groups is broken

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7604

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Simple typo fix, signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7604] Link on basket group name for closed basket groups is broken

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7604

Chris Cormack  changed:

   What|Removed |Added

   Attachment #9194|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 9540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9540&action=edit
Bug 7604 - Link on basket group name for closed basket groups is broken

Fixes the intended behaviour of the link on the basket group name
for closed basket groups by adding a missing '='.

Clicking the link will reopen the basket group.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ch...@bigballofwax.co.nz

--- Comment #8 from Chris Cormack  ---
Just to add my voice to chorus of fix the default view with a syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Chris Cormack  ---
(In reply to comment #5)
> Hi Jared:
> 
> Check the security settings for routing-lists.pl on your server. You should
> have it set so that your public/everyone users can Read & Execute this file.
> I can assure you that you're getting the "(13)Permission denied: exec of..."
> error, because your users can only Read the file. 

You are right :)

But it is your patch creating the file with 644

create mode 100644 members/routing-lists.pl

So you might want to chmod +x it in your repo, git add, git commit --amend and
send a new patch that sets the right permissions. Or everyone will face this
problem on install.

Chris

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from David Cook  ---
Hi Jared:

Check the security settings for routing-lists.pl on your server. You should
have it set so that your public/everyone users can Read & Execute this file. I
can assure you that you're getting the "(13)Permission denied: exec of..."
error, because your users can only Read the file. 

(In reply to comment #4)
> When I apply this patch and try to view the new page, I get a 500 error, and
> the following message in the logs:
> 
> [Sat May 12 10:23:57 2012] [error] [client 192.168.56.1] (13)Permission
> denied: exec of '/home/jcamins/kohaclone/members/routing-lists.pl' failed,
> referer:
> http://192.168.56.57:8080/cgi-bin/koha/members/moremember.
> pl?borrowernumber=217
> [Sat May 12 10:23:57 2012] [error] [client 192.168.56.1] Premature end of
> script headers: routing-lists.pl, referer:
> http://192.168.56.57:8080/cgi-bin/koha/members/moremember.
> pl?borrowernumber=217

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #3 from Katrin Fischer  ---
Ok, the error is starting even before line 7. Still investigating.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #2 from Katrin Fischer  ---
Ok, I compared the English with the translated German templates. The translated
file is missing all line breaks after line 7  and is broken because of
that. I am not sure how to fix it as it seems to be a problem with the
translation scripts not preserving the line breaks correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941

--- Comment #5 from Chris Cormack  ---
I think I just used cpan, in theory should only be rm and rmaint doing it just
pre release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

--- Comment #4 from Jared Camins-Esakov  ---
Katrin just clarified what csv profiles are for me. I think it would be better
to eliminate the DontExportFields syspref, and just use a profile that matches
what you want. Less confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I think negative preferences are often a bit confusing - perhaps it could be
something like ExportFields where empty means all and else you can list those
you want to export?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8081] MARC-8 character set isn't preselected properly when editing Z39.50 servers

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8081

--- Comment #1 from Jared Camins-Esakov  ---
The problem appears to be the hyphen, which is not permitted in variable names.
The offending code is:
$template->param( $_ . $data->{$_} => 1)
for ( qw( syntax encoding ) );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8081] New: MARC-8 character set isn't preselected properly when editing Z39.50 servers

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8081

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8081
CC: gmcha...@gmail.com
  Assignee: paul.poul...@biblibre.com
   Summary: MARC-8 character set isn't preselected properly when
editing Z39.50 servers
  Severity: minor
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Staff Client
   Product: Koha

If you edit a Z39.50 server with the character set to MARC-8, the selected
attribute is not set for MARC-8, and the character set dropdown defaults to the
first item in the list, UTF-8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8080] New: login and password is pre-filled by the browser when creating a new patron

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8080

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8080
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: login and password is pre-filled by the browser when
creating a new patron
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: gaetan.bois...@biblibre.com
  Hardware: All
Status: NEW
   Version: master
 Component: Patrons
   Product: Koha

When creating a new patron, if you have chosen to let your browser remember
your login and password for you, the login and password fields will be
pre-filled with them, leading to a systematic error "the passwords entered do
not match" since the second password field was not filled.

These fields should be blank.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7792] redefine the field branchcode as PRIMARY KEY of branches

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7792

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7792] redefine the field branchcode as PRIMARY KEY of branches

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7792

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #8485|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov  ---
Created attachment 9539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9539&action=edit
Bug 7792:redefine the field branchcode as PRIMARY KEY of branches

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Jared Camins-Esakov  ---
I'm concerned about this patch because there is nothing to prevent two rows
having duplicate message_ids. The existing index is KEY and not UNIQUE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7998] 3.8 UI cleanup, tweaks to new styles

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7998

--- Comment #42 from Gaetan Boisson  ---
Looks great and takes care of a lot of thing that needed to be fixed. Signed
off and approved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7794] redefine the field id as PRIMARY KEY of sessions

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7794

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7794] redefine the field id as PRIMARY KEY of sessions

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7794

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #8490|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov  ---
Created attachment 9538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9538&action=edit
Bug 7794:redefine the field id as PRIMARY KEY of sessions

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7998] 3.8 UI cleanup, tweaks to new styles

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7998

--- Comment #41 from Jared Camins-Esakov  ---
Created attachment 9537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9537&action=edit
Bug 7998: Don't make the news all bold

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941

--- Comment #4 from Jared Camins-Esakov  ---
Oddly perl-reversion does not appear to be included in the libperl-version-perl
package for Debian. Any idea where it might be hiding, or how to get it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

--- Comment #2 from Jared Camins-Esakov  ---
Could you provide a bit more detail on the CSV profiles? I have no idea what to
expect, so I can't test the bug. Also, what goes into the DontExportFields
syspref? A comma-separated list of MARC tags? Something else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Jared Camins-Esakov  ---
I just tried applying these patches and all 19 tests fail, even after I install
Test::YAML::Valid. I get the same error for every single one:

#   Failed test
'../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref
is YAML'
#   at xt/yaml_valid.t line 50.
# Looks like you failed 19 tests of 19.

Shouldn't the tests pass?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #9317|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov  ---
Created attachment 9536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9536&action=edit
Bug 8017 reduce manipulation of GetAllIssues return

GetAllIssues can produce large lists
For performance purposes:
Dont loop over the list without cause
Dont do expensive processing in the loop
Dont needlessly copy the array
Do display formatting in the template
Dont extract the barcode list unless we are producing it
Reduce db calls by using the data to hand

Make the table in the template a bit more readable
where everything was stuffed into one line

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8034] Enable server print queue selection

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Jared Camins-Esakov  ---
The printer selection box still comes up, even when UsePrintQueues is set to
"Don't use." Other than that, the patch seems to work fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

--- Comment #4 from Jared Camins-Esakov  ---
Chris,

Make sure you proof your patches for spelling, particularly of syspref names.
Is the syspref supposed to be CircPayFinesRedirect or CircPayFindsRedirect? I
think the first, but before I changed all instances of the second to the first
I wanted to check that I understood correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
Version|rel_3_8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #9295|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov  ---
Created attachment 9535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9535&action=edit
Bug 8009: Item descriptive data not populated on pay.pl

GetBorNotifyAcctRecord was not populating the {title} element of the
hash, which pay.tt will use.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7488] Errors with logs about moremember.pl / Messaging.pm

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

--- Comment #6 from Jared Camins-Esakov  ---
(In reply to comment #5)
> Adrien,
> I have got the same problem on my install. I don't know why. Execute queries
> in installer/data/mysql/.../sample_notices_message_transports.sql to
> populate your message_transports table.
> It should fix these warnings.

Jonathan,

Does that mean that this bug should be marked INVALID or WONTFIX?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8014] On the patron entry form hide "restricted until" field if "Restricted: No" is checked

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8014] On the patron entry form hide "restricted until" field if "Restricted: No" is checked

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8014

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #9312|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov  ---
Created attachment 9534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9534&action=edit
Bug 8014 - On the patron entry form hide "restricted until" field if
"Restricted: No" is checked

This patch adds JavaScript to automatically hide the "Restricted
unil" form field on the patron entry form if "Restricted: No" is
selected. If "Restricted: Yes" is chosen the "Until:" field
is shown and focus is given to it.

The patch also adds a note, "(optional)" after the "Until:" field
to make it clearer that a date is not required.

To test, open a patron record and try moving the selection
between "Restricted: No" and "Restricted: Yes." Confirm that
the "Until:" field is shown and hidden as expected. Confirm
that the restricted flag is correctly set or unset upon save,
including setting the flag with or without a date.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5295] ctype index Zebra configuration

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

--- Comment #3 from Jared Camins-Esakov  ---
Fridolyn,

Could you please resubmit this as a git patch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] itemnumber not populated in the serial table

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

--- Comment #3 from Jared Camins-Esakov  ---
(In reply to comment #2)
> Assuming this patch is pushed to master, is there any reason we should not
> phase out the serialitems table?

Yes, serials:items is a 1:many relationship. It seems to me that the correct
solution here is not to populate serial.itemnumber, but rather to remove it so
that no one thinks that they should be using it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7722] Insidious problem with searching

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7722

--- Comment #2 from Jared Camins-Esakov  ---
Do you have any suggestions how to test this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7951] Suspending holds needs a system preference

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Jared Camins-Esakov  ---
Even with the patch for 7641, this patch will not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Jared Camins-Esakov  ---
I tried setting this BlockExpiredPatronOpacActions to "block," but it doesn't
seem to have any effect. I'm still able to place holds in the OPAC.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6684] koha-remove should check the number of arguments it gets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6684

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||4880

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4880] koha-remove sometimes fails because user is logged int

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880

Jared Camins-Esakov  changed:

   What|Removed |Added

 Depends on||6684

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6416] koha-remove fails when dropping user

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416

Jared Camins-Esakov  changed:

   What|Removed |Added

 Depends on||6684

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6684] koha-remove should check the number of arguments it gets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6684

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||6416

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7924] Fix handling of command line arguments in koha-remove

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||6684

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6684] koha-remove should check the number of arguments it gets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6684

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 Depends on||7924

--- Comment #7 from Jared Camins-Esakov  ---
The signed off patch will not apply without 7924.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6684] koha-remove should check the number of arguments it gets

2012-05-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6684

Jared Camins-Esakov  changed:

   What|Removed |Added

   Attachment #9003|0   |1
is obsolete||

--- Comment #6 from Jared Camins-Esakov  ---
Created attachment 9533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9533&action=edit
Bug 6684: Fixes to koha-remove

Fixes bugs 6684 6997 4880:
6684 koha-remove should check the number of arguments it gets
6997 koha-remove leaves system in inconsistent state if there is an error
4880 koha-remove sometimes fails because user is logged in

Amended by chr...@catalyst.net.nz
Trying to resolve conflicts.

Signed-off-by: Jared Camins-Esakov 
Rebased on top of bug 7924.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/