[Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart changed: What|Removed |Added Attachment #8955|0 |1 is obsolete|| --- Comment #36 from Jonathan Druart --- Created attachment 9674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9674&action=edit Bug 7470: Followup: Changes mailto links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #18 from Jonathan Druart --- (In reply to comment #15) > Created attachment 9594 [details] > Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch does not apply (I just test this one), can you rebase it please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #30 from Chris Cormack --- Created attachment 9675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9675&action=edit Bug 4330 : Fixing FSF address and copyright headers for acqui/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #31 from Chris Cormack --- Created attachment 9676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9676&action=edit Bug 4330 : Adding copyright headers and fixing FSF addresses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Adrien SAURAT changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #67 from Chris Nighswonger --- As this bug appears to have passed QA, please set the status accordingly so this can be pushed on to master. It will be difficult to keep rebased if too much time elapses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard changed: What|Removed |Added Attachment #9594|0 |1 is obsolete|| --- Comment #19 from Owen Leonard --- Created attachment 9677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9677&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl, ||m...@kohaaloha.com --- Comment #68 from Chris Nighswonger --- Adding the other members of the QA team to the CC list and requesting a second QA opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8125] SIP should send Zipcode with address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Liz Rea changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard changed: What|Removed |Added Attachment #9677|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #20 from Owen Leonard --- Created attachment 9678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9678&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard changed: What|Removed |Added Attachment #9678|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #21 from Owen Leonard --- Created attachment 9679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9679&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7907] PDF printing of lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907 Owen Leonard changed: What|Removed |Added Version|rel_3_6 |master Summary|Permissions regarding the |PDF printing of lists |virtualshelves and pdf | |printing| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Jonathan Druart changed: What|Removed |Added Attachment #9679|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 9680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9680&action=edit Bug 7500 [SIGNED-OFF][FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #28 from Paul Poulain --- (In reply to comment #13) > Did you remember to try applying it with a 3 way merge > > git bz is cool, but without the patch from paul, it doesnt try to merge. Just as a reminder, the patch is here: https://depot.biblibre.com/ppoulain/0001-Add-3-parameter-to-git-am.patch (otherwise, checking this patch again, to see if I was wrong refusing QA, or arguing a little bit more to justify) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Julian Maurice changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|claire.hernandez@biblibre.c |julian.maur...@biblibre.com |om | --- Comment #1 from Julian Maurice --- Created attachment 9681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9681&action=edit More permissions for budgets - Possibility to add users to a budget - Restrictions changed to: - None - Owner - Owner and users - Owner, users and library - Restricted users cannot spent on these budgets (they cannot modify them either) Modified pages: - admin/aqbudgets.pl - admin/aqplan.pl - suggestion/suggestion.pl - acqui/acqui-home.pl - acqui/addorderiso2709.pl - acqui/neworderempty.pl Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t --- Restriction rules: If restriction is 'None', every users with basic acquisition permission can spent on this budget, and every users with budget_modify permission can modify it If 'owner', only the owner can spent on it and modify it (only with 'budget_modify' permission). If there is no owner, we are in the same case as 'None' If 'owner and users' only owner and users can spent on it and modify it (with 'budget_modify'). If no owner, same as 'None'. If 'owner, users and library', owner, users and borrowers connected to the budget library can spent on it and modify it. If no owner or no library is set for the budget, same as 'None'. TO TEST: In admin/aqbudgets.pl, users cannot click on 'Edit' button for restricted budgets In admin/aqplan.pl, users cannot modify planning for restricted budgets In other modified pages, the restricted budgets are simply not displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #2 from Julian Maurice --- PS: This patch also add a 'budget_manage_all' permission which allow user to modify (and use) every budget, whatever the restrictions are. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #3 from Julian Maurice --- *** Bug 7305 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7305] Show budgets according to the library management (centralized or decentralized libraries)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7305 Julian Maurice changed: What|Removed |Added Status|NEW |RESOLVED CC||julian.maur...@biblibre.com Resolution|--- |DUPLICATE --- Comment #1 from Julian Maurice --- RESOLVED DUPLICATE This is included in Bug 7304 *** This bug has been marked as a duplicate of bug 7304 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7305, which changed state. Bug 7305 Summary: Show budgets according to the library management (centralized or decentralized libraries) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7305 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Owen Leonard changed: What|Removed |Added Depends on||4048 --- Comment #3 from Owen Leonard --- I'm making this bug dependent on Bug 4048 because it doesn't make sense to modify hard-coded paths if the path is going to change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Owen Leonard changed: What|Removed |Added Blocks||2774 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #19 from Kyle M Hall ---
It looks like your automated test is failing in 2 places.
1..15
ok 1 - use C4::Reserves;
ok 2 - use C4::HoldsQueue;
ok 3 - take from homebranch (don't use cost matrix) pick up branch
ok 4 - take from homebranch (don't use cost matrix) holding branch
ok 5 - take from homebranch ( use cost matrix) pick up branch
ok 6 - take from homebranch ( use cost matrix) holding branch
ok 7 - take from holdingbranch (don't use cost matrix) pick up branch
not ok 8 - take from holdingbranch (don't use cost matrix) holding branch
# Failed test 'take from holdingbranch (don't use cost matrix) holding
branch'
# at t/db_dependent/HoldsQueue.t line 149.
# got: 'CPL'
# expected: 'MPL'
# Wrong pick-up/hold: $VAR1 = 'MPL';
# $VAR2 = 'MPL';
# $VAR3 = [
# {
# 'priority' => '1',
# 'reservenotes' => undef,
# 'reservedate' => '2012-05-20',
# 'suspend_until' => undef,
# 'expirationdate' => undef,
# 'found' => undef,
# 'reminderdate' => undef,
# 'timestamp' => '2012-05-21 11:03:12',
# 'biblionumber' => '5',
# 'borrowernumber' => '19',
# 'notificationdate' => undef,
# 'branchcode' => 'MPL',
# 'itemnumber' => undef,
# 'constrainttype' => '',
# 'lowestPriority' => '0',
# 'suspend' => '0',
# 'waitingdate' => undef,
# 'cancellationdate' => undef
# }
# ];
# $VAR4 = [
# {
# 'itemnumber' => '117',
# 'biblionumber' => '5',
# 'source_branchcode' => 'CPL',
# 'borrowernumber' => '19',
# 'item_level_request' => '0'
# }
# ];
# $VAR5 = [
# {
# 'pickbranch' => 'MPL',
# 'firstname' => 'Henry',
# 'itemnumber' => '117',
# 'itemcallnumber' => undef,
# 'reservedate' => '2012-05-20',
# 'barcode' => '463975280138',
# 'phone' => '(212) 555-1212',
# 'item_level_request' => '0',
# 'surname' => 'Acevedo',
# 'holdingbranch' => 'CPL',
# 'biblionumber' => '5',
# 'notes' => undef,
# 'cardnumber' => '2352935676',
# 'title' => 'Test Holds Queue XXX',
# 'borrowernumber' => '19'
# }
# ];
ok 9 - take from holdingbranch ( use cost matrix) pick up branch
not ok 10 - take from holdingbranch ( use cost matrix) holding branch
# Failed test 'take from holdingbranch ( use cost matrix) holding branch'
# at t/db_dependent/HoldsQueue.t line 149.
# got: 'UPL'
# expected: 'MPL'
# Wrong pick-up/hold: $VAR1 = 'MPL';
# $VAR2 = 'MPL';
# $VAR3 = [
# {
# 'priority' => '1',
# 'reservenotes' => undef,
# 'reservedate' => '2012-05-20',
# 'suspend_until' => undef,
# 'expirationdate' => undef,
# 'found' => undef,
# 'reminderdate' => undef,
# 'timestamp' => '2012-05-21 11:03:12',
# 'biblionumber' => '5',
# 'borrowernumber' => '19',
# 'notificationdate' => undef,
# 'branchcode' => 'MPL',
# 'itemnumber' => undef,
# 'constrainttype' => '',
# 'lowestPriority' => '0',
# 'suspend' => '0',
# 'waitingdate' => undef,
# 'cancellationdate' => undef
# }
# ];
# $VAR4 = [
# {
# 'itemnumber' => '114',
# 'biblionumber' => '5',
# 'source_branchcode' => 'UPL',
# 'borrowernumber' => '19',
# 'item_level_request' => '0'
# }
# ];
# $VAR5 = [
# {
# 'pickbranch' => 'MPL',
# 'firstname' => 'Henry',
# 'itemnumber' => '114',
# 'itemcallnumber' => undef,
# 'reservedate' => '2012-05-20',
# 'barcode' => '463975280135',
# 'phone' => '(212) 555-1212',
# 'item_level_request' => '0',
# 'surname' => 'Acevedo',
# 'holdingbranch' => 'UPL',
# 'biblionumber' => '5',
# 'notes' => undef,
# 'cardnumber' => '2352935676',
# 'title' => 'Test Holds Queue XXX',
# 'borrowernumber' => '19'
# }
# ];
ok 11 - take from lowest cost branch (don't use cost matrix) pick up branch
ok 12 - take from lowest cost branch (don't use cost matrix) holding branch
ok 13 - take from lowest cost branch ( use cost matrix) pick up branch
ok 14 - take from
[Koha-bugs] [Bug 8131] New: date runtime parameter buggy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8131 Priority: P5 - low Change sponsored?: --- Bug ID: 8131 Assignee: gmcha...@gmail.com Summary: date runtime parameter buggy Severity: normal Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Reports Product: Koha Using the date runtime parameter pops up the calendar the first time, but not the second. So if I do this: BETWEEN <> and <> Clicking the calendar on the first works, but the second never pops up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] New: batch delete tool deletes items with holds on them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Priority: P5 - low Change sponsored?: --- Bug ID: 8132 Assignee: gmcha...@gmail.com Summary: batch delete tool deletes items with holds on them Severity: critical Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha I don't think it always did this - but I tested today on 3.8 and it deleted an item and a bib record (cause I checked that box) that had holds on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8133] New: hourly loans doesn't know when library closed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Priority: P5 - low Change sponsored?: --- Bug ID: 8133 CC: gmcha...@gmail.com Assignee: kyle.m.h...@gmail.com Summary: hourly loans doesn't know when library closed Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The calendar only asks for dates the library is open closed, so if you have an hourly loan it doesn't know that the library is closed between 8pm and 9am for example and is marking things overdue that maybe the library doesn't consider overdue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8134] New: what is the export option under the more menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8134 Priority: P5 - low Change sponsored?: --- Bug ID: 8134 CC: gmcha...@gmail.com Assignee: kyle.m.h...@gmail.com Summary: what is the export option under the more menu Severity: normal Classification: Unclassified OS: All Reporter: neng...@gmail.com URL: cgi-bin/koha/members/notices.pl?borrowernumber=51 Hardware: All Status: NEW Version: master Component: Patrons Product: Koha On the Notices tab on the patron record there is an option in the more menu to export - but it doesn't do anything except generate a blank text file. This option isn't under More on any other patron related tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #29 from Paul Poulain --- After testing again, I confirm my failed QA: * add 2 manual invoices, say 1€ and 2€ * head to "Pay fine" (pay.pl) tab * you can: - check or uncheck a line - add a comment on each line * uncheck line 2€, keep line 1€ checked, add a note to line 1€ * clic "Pay selected": you are asked to pay 1€, if you save,the comment you've entered is not saved I also tried to reproduce the behaviour shown on http://screencast.com/t/bPYEhgtAj, but since the bug 3498 Allow partial payments of fines, things have changed, and I can't reproduce the buggy behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7175] Improve order receiving page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175
Paul Poulain changed:
What|Removed |Added
Status|Signed Off |Passed QA
Version|master |rel_3_10
--- Comment #42 from Paul Poulain ---
(In reply to comment #41)
> (In reply to comment #38)
> > Could you rebase & resubmit (switch back to signed-off, it's probably an
> > easy rebase)
>
> It was very easy in fact, I had no conflict... I wonder if you took patches
> in the right order. It must be "Bug 7175: orderreceive.pl cosmetic changes"
> first
That's definetly the cause of my problem = it was not written that the patches
were to be applied in reverse order !
QA comments:
* the code update a line using format_date (+date =>
format_date($order->{entrydate}),), which is deprecated, but it was here
before, so it's OK
* perlcritic OK for Acquisition.pm acqui/orderreceive.pl
acqui/finishreceive.pl acqui/orderreceive.pl catalogue/getitem-ajax.pl
cataloguing/additem.pl
* prove xt/author/translatable-templates.t xt/author/valid-templates.t is OK
passed QA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7175] Improve order receiving page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #43 from Paul Poulain --- works well. Just a side comment: when you save an item with a (or some) field empty you get "undefined" on each empty column. Is it the intented behaviour ? Why not just let the field empty on the screen ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8077] overdues with fines won't run
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8077 Paul Poulain changed: What|Removed |Added Priority|P5 - low|P1 - high Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7604] Link on basket group name for closed basket groups is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7604 Paul Poulain changed: What|Removed |Added Priority|P5 - low|P3 Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8106] DataTables in Acquisision module: addorderiso2709.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8106 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|unspecified |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8125] SIP should send Zipcode with address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #2 from Colin Campbell --- The zip code is just part of the address in sip terms, but the patch as is does not do that it appends address to adr but it never appends zip you probably want two lines and make the second test on $adr && $zip the test (is there a string of greater than 0 length in both elsements?) is there to decide whether to add a space before appending the new element. I think $adr .= ($adr && $address ) ? " $address" : $address; $adr .= ($adr && $zip) ? " $zip" : $zip; is what you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7704] Independent Branches sys pref change to let librarians choose which things to share
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7704 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_10 --- Comment #6 from Paul Poulain --- This should not be applied to 3.8 IMO, because that's a behaviour change that can be a trouble for a library not spotting the change during the update ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Ian Walls changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #69 from Ian Walls --- QA comments: 1) Introduces a new system dependency, DateTime::Format::MySQL, which only seems to be used to format datetimes into ISO for querying the quotes table. We already have Koha::DateUtils, which can process a datetime in ISO, or many other formats, so I'm not seeing the need to add a dependency on DateTime::Format::MySQL. Does this module do something more that I'm missing? 2) Also, the varchar(45) on the 'source' for the quote seems a bit short... I think having this as a 'text' field would provide more flexibility. 3) Minor typo in tools/quotes-upload.tt: "...you will be promoted to..." should be "...you will be prompted to..." 4) Link to documentation is hardcoded to 3.8 manual page... should it be this way? Won't that require maintenance every release, to keep pointing at the right version? 5) Hardcoded styling in tools/quotes.tt (the under QOTD Editor) Marking as Failed QA primarily for 1), but 3) and 5) need t be addressed, as well. 2) and 4) are up for discussion. I think this would be a prime candidate for a Plugin as per Bug 7804... it seems like a pretty stand-alone thing, if it's basic requirements are met. The only complication I see is getting permissions handled properly, but that's just a matter of a small database update script, which would need to run anyway to install the table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Jared Camins-Esakov changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #21 from Jared Camins-Esakov --- I've done some more thinking about the security implications of the plugin system. I think the following are required for this to be sufficiently secure for use: * Both a syspref *and* a configuration setting in koha-conf.xml should be required to enable plugins, and both should be disabled by default. * Even when plugins are enabled, a separate koha-conf.xml configuration setting should be required to enable upload from the staff client. * The plugins should be loaded with Module::Load::Conditional, and each type of plugin (Tools, Reports, etc.) should use a different interface. e.g. Koha::Plugin::Foobar->run_report() and Koha::Plugin::Foobar->run_tool() * The plugin host should enable mandatory taint checking. * Under no circumstances should the plugin feature add a +Exec directory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #70 from Jared Camins-Esakov --- (In reply to comment #69) > QA comments: > I think this would be a prime candidate for a Plugin as per Bug 7804... it > seems like a pretty stand-alone thing, if it's basic requirements are met. > The only complication I see is getting permissions handled properly, but > that's just a matter of a small database update script, which would need to > run anyway to install the table. I just commented on bug 7804. I am profoundly concerned about the security implications of the current implementation there. I think it would be better to integrate this into the Koha codebase as is, while work on bug 7804 is underway. I documented what I feel would be necessary for a plugin host to be safe, and I don't think the fixes are trivial. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #71 from Chris Nighswonger --- (In reply to comment #69) > QA comments: > > 1) Introduces a new system dependency, DateTime::Format::MySQL, which only > seems to be used to format datetimes into ISO for querying the quotes table. > We already have Koha::DateUtils, which can process a datetime in ISO, or > many other formats, so I'm not seeing the need to add a dependency on > DateTime::Format::MySQL. Does this module do something more that I'm > missing? Looking at the perldoc for Koha::DateUtils it appears that we are transitioning to DateTime and that the K::DU module is merely meant to ease that transition by hiding "the complexity of switch to DateTime." I would suggest that using DateTime::Format::MySQL is the better approach as we work toward phasing out Koha::DateUtils and moving completely to DateTime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #72 from Chris Nighswonger --- (In reply to comment #69) > QA comments: > > 2) Also, the varchar(45) on the 'source' for the quote seems a bit short... > I think having this as a 'text' field would provide more flexibility. Agreed. I'll do this with a followup patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #73 from Chris Nighswonger --- (In reply to comment #69) > QA comments: > > > 3) Minor typo in tools/quotes-upload.tt: "...you will be promoted to..." > should be "...you will be prompted to..." > > > 5) Hardcoded styling in tools/quotes.tt (the under QOTD Editor) > I'll fix these in the followup as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #74 from Chris Nighswonger --- (In reply to comment #69) > QA comments: > 4) Link to documentation is hardcoded to 3.8 manual page... should it be > this way? Won't that require maintenance every release, to keep pointing at > the right version? > This was copied from existing references, so I'm assuming this is the normal method, but I'll defer to Nicole on that and make any changes she recommends. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #75 from Chris Nighswonger --- (In reply to comment #69) > QA comments: > I think this would be a prime candidate for a Plugin as per Bug 7804... it > seems like a pretty stand-alone thing, if it's basic requirements are met. > The only complication I see is getting permissions handled properly, but > that's just a matter of a small database update script, which would need to > run anyway to install the table. I've pretty much burned up the hours allotted for development on this feature, so I will not be able to port it over to a plugin. That does not, however, prevent someone else from doing so if that is desirable. Or for funding the additional hours needed to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #76 from Chris Nighswonger --- Created attachment 9682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9682&action=edit Making source a text field rather than a varchar to avoid potential length limitations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 --- Comment #77 from Chris Nighswonger --- Created attachment 9683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9683&action=edit Fixing a typo in the quotes-upload help file and hardcoded css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8077] overdues with fines won't run
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8077 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Small fix, no string changes, will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977 Chris Nighswonger changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #78 from Chris Nighswonger --- These patches address #'s 2,3,5 of Ian's concerns. I'd like to have a better handle on our long term use of Koha::DateUtils before removing DateTime::Format::MySQL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7604] Link on basket group name for closed basket groups is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7604 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #6 from Chris Cormack --- Small fix, no string changes, will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #22 from Kyle M Hall --- (In reply to comment #21) > I've done some more thinking about the security implications of the plugin > system. I think the following are required for this to be sufficiently > secure for use: > * Both a syspref *and* a configuration setting in koha-conf.xml should be > required to enable plugins, and both should be disabled by default. > * Even when plugins are enabled, a separate koha-conf.xml configuration > setting should be required to enable upload from the staff client. > * The plugins should be loaded with Module::Load::Conditional, and each type > of plugin (Tools, Reports, etc.) should use a different interface. e.g. > Koha::Plugin::Foobar->run_report() and Koha::Plugin::Foobar->run_tool() > * The plugin host should enable mandatory taint checking. > * Under no circumstances should the plugin feature add a +Exec directory. I can understand the configuration setting requirements. However, I cannot understand how to use Module::Load::Conditional, even after looking at the example patch you pointed me to. I don't feel it is quite fair to require the use of a poorly documented perl module. Can you please justify these requirements? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #23 from Chris Cormack --- (In reply to comment #22) > (In reply to comment #21) > > I've done some more thinking about the security implications of the plugin > > system. I think the following are required for this to be sufficiently > > secure for use: > > * Both a syspref *and* a configuration setting in koha-conf.xml should be > > required to enable plugins, and both should be disabled by default. > > * Even when plugins are enabled, a separate koha-conf.xml configuration > > setting should be required to enable upload from the staff client. > > * The plugins should be loaded with Module::Load::Conditional, and each type > > of plugin (Tools, Reports, etc.) should use a different interface. e.g. > > Koha::Plugin::Foobar->run_report() and Koha::Plugin::Foobar->run_tool() > > * The plugin host should enable mandatory taint checking. > > * Under no circumstances should the plugin feature add a +Exec directory. > > I can understand the configuration setting requirements. However, I cannot > understand how to use Module::Load::Conditional, even after looking at the > example patch you pointed me to. I don't feel it is quite fair to require > the use of a poorly documented perl module. Can you please justify these > requirements? You have read http://search.cpan.org/dist/Module-Load-Conditional/lib/Module/Load/Conditional.pm eh? I don't find it particularly badly documented. ABd it is part of Perl core, so is not a new dependency Module::Load::Conditional is but one way of solving a loading modules on the fly. I am sure you understand why an +Exec directory is a bad idea, and why using taint is a good one. As well as being off by default and unable to be turned on via the web is a good one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #1 from Kyle M Hall --- Created attachment 9684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9684&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #24 from Jared Camins-Esakov --- (In reply to comment #22) > (In reply to comment #21) > > I've done some more thinking about the security implications of the plugin > > system. I think the following are required for this to be sufficiently > > secure for use: > > * Both a syspref *and* a configuration setting in koha-conf.xml should be > > required to enable plugins, and both should be disabled by default. > > * Even when plugins are enabled, a separate koha-conf.xml configuration > > setting should be required to enable upload from the staff client. > > * The plugins should be loaded with Module::Load::Conditional, and each type > > of plugin (Tools, Reports, etc.) should use a different interface. e.g. > > Koha::Plugin::Foobar->run_report() and Koha::Plugin::Foobar->run_tool() > > * The plugin host should enable mandatory taint checking. > > * Under no circumstances should the plugin feature add a +Exec directory. > > I can understand the configuration setting requirements. However, I cannot > understand how to use Module::Load::Conditional, even after looking at the > example patch you pointed me to. I don't feel it is quite fair to require > the use of a poorly documented perl module. Can you please justify these > requirements? You can also use Module::Load if you'd prefer to handle error conditions yourself. As for why I think this is necessary, consider a plugin which is nothing but a one-line forkbomb. Having an executable file doesn't even require someone to follow an API. They can simply download one of the gazillion of examples of how to take down your server with one line (just, what, 9 characters if you're using bash?), zip it up with your example ini file, and bring down the server. Or a plugin which actually just contains a command line script for reinitializing your Koha database for testing. Accidentally zip that up with your plugin, have someone connect to it (and there's no need for authentication to access a plugin, notice!), and your production server is pristine. Like the cheese shop, it is very clean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Kyle M Hall changed: What|Removed |Added Attachment #9684|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 9685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9685&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #25 from Kyle M Hall --- > As for why I think this is necessary, consider a plugin which is nothing but > a one-line forkbomb. Having an executable file doesn't even require someone > to follow an API. They can simply download one of the gazillion of examples > of how to take down your server with one line (just, what, 9 characters if > you're using bash?), zip it up with your example ini file, and bring down > the server. Or a plugin which actually just contains a command line script > for reinitializing your Koha database for testing. Accidentally zip that up > with your plugin, have someone connect to it (and there's no need for > authentication to access a plugin, notice!), and your production server is > pristine. Like the cheese shop, it is very clean. I understand your examples, but I feel like this is more of a buyer beware issue. If you are uploading random plugins to your system without vetting them first, then of course you will have problems, Module::Load::Conditional or not! The design is meant to have plugins deal with their own authentication. My examples do indeed use C4::Auth::checkauth for authentication. After examining the issues involved, I just feel that this requirement is very very onerous, and would require huge amounts of time to understand and implement. If you could please show me how Module::Load::Conditional would prevent any of your scenarios from taking place, I may reconsider my position. However, as it stands, even with said implementation, I could easily write a plugin to perform any of the damaging tasks you have mentioned. What I would like to see is a plugin repository that contains only plugins that have been uploaded to bugs.koha-community.com so that they may be vetted and qa'ed just like any other modification to Koha. If a library wishes to use plugins from elsewhere, it is up to themselves to vet those plugins before use, or to trust the source itself. I understand that time is a limited resource for everyone ( including myself ), but if you feel strongly enough about this issue, I would welcome a followup patch to add this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 --- Comment #20 from Srdjan Jankovic --- This is most inconvenient, because it passes here. Can you please tell me how you run it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8083] Granular parameters permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #7 from Srdjan Jankovic --- Created attachment 9686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9686&action=edit pa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8083] Granular parameters permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Srdjan Jankovic changed: What|Removed |Added Attachment #9686|pa |patch description|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8083] Granular parameters permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Srdjan Jankovic changed: What|Removed |Added Attachment #9578|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Savitra Sirohi changed: What|Removed |Added Status|NEW |In Discussion CC||savitra.sir...@osslabs.biz Assignee|gmcha...@gmail.com |savitra.sir...@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8110] Fines accruing on closed days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Savitra Sirohi changed: What|Removed |Added Status|NEW |In Discussion CC||savitra.sir...@osslabs.biz Assignee|henridam...@koha-fr.org |savitra.sir...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8110] Fines accruing on closed days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Savitra Sirohi changed: What|Removed |Added CC||me...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8110] Fines accruing on closed days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #1 from Savitra Sirohi --- The code to skip holidays during fine calculation seems to be present. Has the user set finescalendar syspref to noFinesWhenClosed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
