[Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 9867
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9867action=edit
Proposed patch

Checking the variable with the ternary will generate a warning about comparison
with an undefined var. (test needs to be defined $sqlwhere) The underlying
problem is that we havent given an initial value to the var before either
overwriting or concatening with it so this initializes it to an empty string,
that done it should not log warnings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
Version|rel_3_6 |unspecified

--- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com ---
Changed version to unspecified patch should apply to 3.6  and current
development HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

--- Comment #14 from Adrien SAURAT adrien.sau...@biblibre.com ---
Where should we go then?

I created this patch because one of our librarians asked for this but maybe
it's not really useful. Do we keep the idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7992] new plugin about Automatic Number incrementing inventory. Prefix management from a authorised values list

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7992

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #9402|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 9868
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9868action=edit
Bug 7992: Specific plugin stocknumberam123 improvements

Bugzilla description (from delaye):
1 / Create a list of authorised values(INVENTORY_NUMBER). In which the
code is the prefix and the description the last number assigned.

2/A space between the prefix and number.

3 / From a holding record, after indicate the prefix when you click on
the plugin - koha search the last number from authorised values
assigned in the list and increment n +1 level meter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7992] new plugin about Automatic Number incrementing inventory. Prefix management from a authorised values list

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7992

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7351] ability to edit a range of holidays

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

--- Comment #30 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Hum, Paul,
I have tested again, on a branch up to date, I have applyed my patch and the
pages are ok...
I join a snapshot
Could anyone test ?
Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7351] ability to edit a range of holidays

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

--- Comment #31 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Created attachment 9869
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9869action=edit
the page is ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|colin.campbell@ptfs-europe. |pelletiermax...@gmail.com
   |com |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com ---
Dobrika, hello,

I'm reviewing your patches related to plack, and find this one.
In the attachment 9113, is written:
+1. install plack and dependencies, using ./cpanm-install.pl

but I can't find cpanm-install.pl anywhere. Is it a mistake ?
I can see cpanm-install.pl in the attachment the attachment 8893, but it's an
obsolete one.

Any explanation welcomed !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #9710|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 9871
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9871action=edit
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings

To simplify the sentence structure for better translation flexibility
the message now reads:

Item in your cart:  + number

Fixed in both OPAC and staff client, although I'm not sure
the message is actually triggered in the staff client.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Strings become translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #9867|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 9872
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9872action=edit
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere

warnings in log because of undefined value in
string concatenation
variable should be initialized to empty string rather
than left undefined

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Removes a warning in logs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8129] quick slips issuing does not work

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Blocks||6430

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6430] DB changes needed for Hourly Circulation

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||8129

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7351] ability to edit a range of holidays

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #32 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
I have seen with Paul, maybe due to his hook git...
Tested with two others PC.
thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #9865|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 9873
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9873action=edit
Bug-7161 Open Library - Larger image, Read, borrow and checked-out status

To test:
1. go into system administration and search for cover
2. change OpenLibraryCovers to add and all other to don't show
3. verify that opac search results have small covers, while
   detail page has big ones

Signed-off-by: Dobrica Pavlinusic dpav...@rot13.org

Addressing M. de Rooy's concerns

* remove console.log
* removed some comments that looked like debug code?
* remove ebook display -  I couldn't get it to work properly, and we want the
bigger images. So it's gone.
* remove get_cover

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7570] Add Item availability status to cart

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570

Meenakshi meenaksh...@osslabs.biz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Assignee|ebin.jos...@osslabs.biz |meenaksh...@osslabs.biz

--- Comment #1 from Meenakshi meenaksh...@osslabs.biz ---
Created attachment 9874
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9874action=edit
Attached Patch.

Attached Patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #7 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
The patch doesn't apply anymore

git bz apply 7304
Bug 7304 - Working on funds ergonomic display and funds management by multi
librarians

More permissions for budgets
Apply? [yn] y

Applying: Bug 7304: More permissions for budgets
error: patch failed: installer/data/mysql/updatedatabase.pl:5284
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Patch failed at 0001 Bug 7304: More permissions for budgets
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/More-permissions-for-budgets-wqIY11.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

--- Comment #12 from Dobrica Pavlinusic dpav...@rot13.org ---
I removed cpanm-install.pl since installation of dependencies is something that
should be done by Debian package.

I don't think that installing packages using cpanm on production is something
we should recommend.

Installing dependencies is documented at wiki page
http://wiki.koha-community.org/wiki/Plack but it does depend on platform
availability of perl packages. Currently squeeze miss quite a few packages,
while wheezy does include most packages needed for Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #9551|0   |1
is obsolete||
   Attachment #9572|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 9875
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9875action=edit
Bug 8062 [SIGNED-OFF] Cart email broken for non english templates

Fix basket email sent from OPAC. The email body is now generated HTML
(to be translatable), and converted into TEXT before beeing sent by
email.

To test that it works in other language than English, you have to update
your language .po file:

  perl translate update de-DE

Then, translated strings coming from opac-sendbasket.tt, and install the
translation:

  perl translate install de-DE

New dependency: Template::Plugin::HtmlToText

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
It works fine :)

Perharps a followup is required to specified the new dependency (in
C4/Installer/PerlDependencies.pm ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

--- Comment #8 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Patch doesn't apply...
git bz apply 7304
Bug 7304 - Working on funds ergonomic display and funds management by multi
librarians

More permissions for budgets
Apply? [yn] y

Applying: Bug 7304: More permissions for budgets
error: patch failed: installer/data/mysql/updatedatabase.pl:5284
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Patch failed at 0001 Bug 7304: More permissions for budgets
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/More-permissions-for-budgets-zwG92l.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

D Ruth Bavousett r...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED
 CC||r...@bywatersolutions.com
   Assignee|srd...@catalyst.net.nz  |r...@bywatersolutions.com

--- Comment #33 from D Ruth Bavousett r...@bywatersolutions.com ---
Reopening--the OCLC Connexion client for Windows can't use this
daemon--something is happening in there, and the socket payload is not getting
to the import_bib phase, at all.  I'm working on it now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8178] New: circ/circulation.pl under plack duplicates checkout rows

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8178
CC: gmcha...@gmail.com
  Assignee: kyle.m.h...@gmail.com
   Summary: circ/circulation.pl under plack duplicates checkout
rows
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: dpav...@rot13.org
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Circulation
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7172] Data Persistency

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Depends on||8178

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||7172
   Assignee|kyle.m.h...@gmail.com   |dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8150] Patron circulation history has a fossil navagation bar

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150

--- Comment #7 from Colin Campbell colin.campb...@ptfs-europe.com ---
Could be that one is being added due to something in .gitconfig or in a git
hook but that the mailer is setting it too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178

--- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 9877
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9877action=edit
Bug 8178 - circ/circulation.pl under plack duplicates checkout rows

Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)

Test scenario:
1. start intranet under plack
2. open /cgi-bin/koha/circ/circulation.pl and reload page few time
   confirming that rows gets duplicated
3. apply patch and reload page to verify that it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7570] Add Item availability status to cart

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 9878
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9878action=edit
Screenshot showing inaccurate availability information

The availability information shown now in the cart is inaccurate. As this
screenshot shows, for a title with 4 items, 1 checked out, the cart says
Available once.

For this information to be accurate there needs to be a way to connect the
availability/status information directly to each copy listed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7570] Add Item availability status to cart

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
Version|rel_3_8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7844] plack scripts for developers

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

   Attachment #9113|0   |1
is obsolete||

--- Comment #13 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 9879
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9879action=edit
Bug 7844 - plack intranet tooling for developers

koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server

  plackup.sh site-name [intranet]

site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml

All configuration is specified in koha.psgi, which you are welcomed to edit
and tune according to your development needs.

When you are happy with it, rename it to site name and save it for
safe-keeping.

Test scenario:
1. install plack and dependencies, as documented at
   http://wiki.koha-community.org/wiki/Plack

2. start ./plackup.sh sitename

3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl
   and verify that it works

4. start ./plackup.sh sitename i[ntranet]

5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl
   and verify that it works

6. next step is to take a look into koha.psgi and enable additional
   debug modules, save file and reload page (plackup will reload
   code automatically)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] New: Receiving items requires repetitive clicking.

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8179
  Assignee: henridam...@koha-fr.org
   Summary: Receiving items requires repetitive clicking.
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: fred.pie...@smfpl.org
  Hardware: All
Status: NEW
   Version: rel_3_6
 Component: Acquisitions
   Product: Koha

Our Acquisitions workflow is currently hindered by a repetitive process of
receiving individual items. The parcel.pl and orderreceive.pl scripts in Koha
3.5 do not provide us with a way to checkbox individual items for receipt, or
alternatively, Receive All. We have to click receive on each item, then save
the individual item and return to the receive screen. On orders where we have a
hundred items, you can imagine this process of receiving is very tiresome, when
a Receive All function could be implemented.

  Because several Acquisitions team members may be receiving items in the same
basket, a checkbox on each line and a Receive checked would allow each worker
to receive their specific items - giving the option to check all and receive,
or just receive the items on your specific physical cart. This would be a
benefit when large orders are being processed.

  By combining orderreceive.pl and finishreceive.pl we expect to be able to
automate the process for batch receiving of items on an order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Pushed to Stable|ASSIGNED
Version|rel_3_10|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving items requires repetitive clicking.

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #1 from Fred P fred.pie...@smfpl.org ---
Created attachment 9881
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9881action=edit
Our local Acquisitions Workflow

What are alternative workflows? I understand we can also create items through
cataloging or when receiving them, using the AcqCreateItems system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8180] New: cataloguing/additem.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8180
  Assignee: gmcha...@gmail.com
   Summary: cataloguing/additem.pl plack scoping
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: dpav...@rot13.org
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Cataloging
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7351] ability to edit a range of holidays

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

--- Comment #33 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Created attachment 9882
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9882action=edit
this is an addon after M. de Rooy's patch

As stated in patch comment, I have just put a space between the radio button
and the text for the new lines..
And I have replaced tabulations by space.
You must have applied before :
[SIGN OFF]Bug 7351 : feature that allows to delete a range of dates
Patch for minor textual changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8174] OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8174

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #0)
 When a Patron logs in and clicks the back button on their browser or clicks
 on a Home link that links back to /koha/opac-main.pl, the OpacNavBottom
 content shows between OpacNav and the Patron Links.

I don't understand. If I log in and then go to the OPAC home page I won't see
the patron links anymore. Patron links aren't shown on the home page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

--- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 9884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9884action=edit
Bug 8180 - cataloguing/additem.pl plack scoping

$dbh needs our scoping when using Add item to prevent error
Can't call method prepare on an undefined value at
/srv/koha/cataloguing/additem.pl line 88.

Test scenario:

1. start intranet with plack
2. select one Edit items on one record
3. fill in new item and click on Add item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7172] Data Persistency

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Depends on||8180

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Blocks||7172
   Assignee|gmcha...@gmail.com  |dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to potential malicious code execution

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171

--- Comment #2 from William Hurley bhur...@aihs.org ---
You may be correct that I have not identified the source of the bug.  You are
incorrect when you say that the problem is that the quotation marks are not
escaped during the actual search.  The problem is that the quotation marks are
not escaped when one chooses edit- replace record via z39.50.  If the title
contains double quotes, everything from the first set of quotes back
disappears, and is not transferred into the search window.  The quoted text
never makes it into the actual search.  

It is easy to replicate this bug.  Pick any title in your collection and edit
marc field $245a by appending test quotes at the end of the title.  Then
click on z39.50 search.  The words test quote do not appear in the pop-up
search window. Therefore, whatever module controls this behavior is not
properly escaping the quotes.  If you would kindly identify this module I would
be greatly appreciative.  Thanks for your quick response and all your help in
this matter.  

(In reply to comment #1)
 Hi William
 
 On line 228 term is the name of the column. It is not the variable.
 
 The variable is in 
 $sth-execute($query, $type, $serverlist, $requestid);
 
 The query is escaped by use of placeholders ie the (?,?,?,?)
 
 Which means $query is escaped and replaces the first ? in that list.
 
 So that part is not the problem, I suspect the actual problem is that the 
 are not escaped when doing the actual search.
 
 Ill leave this open because it is a valid but, bug I don't think your
 solution will work (or addresses the problem :))
 
 If you want to read up about placeholders please look here
 http://search.cpan.org/dist/DBI/DBI.pm#Placeholders_and_Bind_Values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #12 from Frédéric Demians frede...@tamil.fr ---
 Perharps a followup is required to specified the new dependency (in
 C4/Installer/PerlDependencies.pm ?)

The template contains a 'USE HtmlToText' directive, which use a
Template::Toolkit module. It's not a Perl module, and it's included by
default with Template::Toolkit. Is it the dependency we were thinking
about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708

--- Comment #4 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Tested again using the biblibre sandboxs.. 

All seems to work as expected now giving out good clean markup.

Will try and grab a copy locally to sign-ff on properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #2 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
 * there is an unconditional warn added:
+warn ## Name [$opts{Name}] $fh;

please remove it of write $ENV{DEBUG} and warn ## Name [$opts{Name}] $fh;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] New: Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8182
  Assignee: gmcha...@gmail.com
   Summary: Problem with overdue fine calculations after upgrade
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: kyle.m.h...@gmail.com
  Hardware: All
Status: NEW
   Version: master
 Component: Database
   Product: Koha

Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26.  When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin.  Therefore the
patron is being charged double overdue fines from the original date up to 5/26.

This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

--- Comment #1 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9889
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9889action=edit
Bug 8182 - Problem with overdue fine calculations after upgrade

Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26.  When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin.  Therefore the
patron is being charged double overdue fines from the original date up to 5/26.

This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00
instead.

This is an unusual patch as it modifies a previous database update. This
make sense because if a install has already been updated past the db rev
update, this fix will be too late. It will only help those that have not
updated past that db revision.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8183] New: acqui/parcels.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8183
  Assignee: henridam...@koha-fr.org
   Summary: acqui/parcels.pl plack scoping
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: dpav...@rot13.org
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Acquisitions
   Product: Koha

Can't call method param on an undefined value at
/srv/koha_ffzg/acqui/parcels.pl line 177.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8184] New: Duplicate budget page lacks heading and breadcrumbs

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8184
  Assignee: oleon...@myacpl.org
   Summary: Duplicate budget page lacks heading and breadcrumbs
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: oleon...@myacpl.org
  Hardware: All
Status: NEW
   Version: master
 Component: Acquisitions
   Product: Koha

When you use the menu option to duplicate a budget the resulting page doesn't
have a heading or a breadcrumb.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

--- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9891
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9891action=edit
Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

--- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 9892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9892action=edit
Bug 8183 - acqui/parcels.pl plack scoping

Scope our $template for plack to prevent following error:

Can't call method param on an undefined value at
/srv/koha_ffzg/acqui/parcels.pl line 177.

Test scenario:

1. Home  Acquisitions  Search for vendor
2. click on Receive shipment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

   Attachment #9161|0   |1
is obsolete||

--- Comment #3 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 9893
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9893action=edit
Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser

Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.

This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or CGI) to pick up.

DEBUG=1 it will debugging output

Test secenario:

1. Home › Tools › Patron Card Creator › Manage Card Batches
2. select batch checkbox and click Export
3. select template and click Export
4. click on pdf file to download it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|henridam...@koha-fr.org |dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8165] due date of 00:00 instead of 23:59

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8165

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Melia Meggs me...@bywatersolutions.com ---


*** This bug has been marked as a duplicate of bug 8182 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
 CC||ch...@bigballofwax.co.nz
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Are we sure we can't fix those who have upgraded already too? With an update
statement?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9894
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9894action=edit
Bug 8182 - Problem with overdue fine calculations after upgrade

Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26.  When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin.  Therefore the
patron is being charged double overdue fines from the original date up to 5/26.

This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00
instead.

This is an unusual patch as it modifies a previous database update. This
make sense because if a install has already been updated past the db rev
update, this fix will be too late. It will only help those that have not
updated past that db revision.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9890|0   |1
is obsolete||
   Attachment #9894|0   |1
is obsolete||

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9895
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9895action=edit
Bug 8182 - Problem with overdue fine calculations after upgrade

Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26.  When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin.  Therefore the
patron is being charged double overdue fines from the original date up to 5/26.

This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00
instead.

This is an unusual patch as it modifies a previous database update. This
make sense because if a install has already been updated past the db rev
update, this fix will be too late. It will only help those that have not
updated past that db revision.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Signed off the fix, it will fix anyone upgrading from 3.6/3.4 .. but I think we
still need a follow up to catch the ones who already have. Or at least a nice
easy recipe for them to follow to clean up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
NOTE: This is only a problem on upgrades, fresh installs are ok

I'd definitely like it in before the 3.8.2 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8140] Error when exporting label xml

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8140

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8177] Correct a double declaration of variable in Addreturn subroutine

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8177

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack ch...@bigballofwax.co.nz ---
Applying: Correct double declaration of variable in Addreturn
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Correct double declaration of variable in Addreturn
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9896
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9896action=edit
Bug 7304: More permissions for budgets

- Possibility to add users to a budget
- Restrictions changed to:
  - None
  - Owner
  - Owner and users
  - Owner, users and library
- Restricted users cannot spent on these budgets (they cannot modify them
  either)

Modified pages:
 - admin/aqbudgets.pl
 - admin/aqplan.pl
 - suggestion/suggestion.pl
 - acqui/acqui-home.pl
 - acqui/addorderiso2709.pl
 - acqui/basket.pl
 - acqui/neworderempty.pl

Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9837|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||ch...@bigballofwax.co.nz
Version|rel_3_8 |master

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
Fixed merge conflict on updatedatabase.pl.

Works welll, and yay for more unit tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

Summary|Improper escaping of quotes |Improper escaping of quotes
   |during z39.50 queries leads |during z39.50 queries leads
   |to potential malicious code |to broken html
   |execution   |

--- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #2)
 You may be correct that I have not identified the source of the bug.  You
 are incorrect when you say that the problem is that the quotation marks are
 not escaped during the actual search.  The problem is that the quotation
 marks are not escaped when one chooses edit- replace record via z39.50.  If
 the title contains double quotes, everything from the first set of quotes
 back disappears, and is not transferred into the search window.  The quoted
 text never makes it into the actual search.  

I was just guessing where the problem was, since I haven't tried to replicate.
But I can guarantee that changing the column name in the sql, will have utterly
no effect on value that is stored in that column.

 
 It is easy to replicate this bug.  Pick any title in your collection and
 edit marc field $245a by appending test quotes at the end of the title. 
 Then click on z39.50 search.  The words test quote do not appear in the
 pop-up search window. Therefore, whatever module controls this behavior is
 not properly escaping the quotes.  If you would kindly identify this module
 I would be greatly appreciative.  Thanks for your quick response and all
 your help in this matter.  
 

I would look into the perl code that is outputting it and/or the template.

It is not being stored in the database incorrectly, the placeholders are
escaping all bad characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Hmm I think the plan is to slowly kill C4::Dates, because it doesnt understand
times at all.

I am not sure on that, so will check but I think that was the plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9455|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171

--- Comment #5 from William Hurley bhur...@aihs.org ---
Ok cool. I will try this patch on a fresh install of the latest stable branch
on my development box and see if the problem resolves it's self.  Should be
able to let you know by early next week, as I almost certainly won't finish
that before the end of the work day here in NYC.  

(In reply to comment #4)
 Check line 95 in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
 
 ollilabel for=titleTitle: /labelinput type=text id=title 
 name=title value=[% title %] //li
 
 My theory is if [% title %] starts with a  then you get value= and there
 is the problem.
 
 So you could try adding [% title |html %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #5)
 Ok cool. I will try this patch on a fresh install of the latest stable
 branch on my development box and see if the problem resolves it's self. 
 Should be able to let you know by early next week, as I almost certainly
 won't finish that before the end of the work day here in NYC.  

That's ok, its already 8.30am on Saturday here anyway, if it does work you
could make an actual patch and attach it to here, and set the bug to needs
signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #172 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9897
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9897action=edit
Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/



[Koha-bugs] [Bug 8061] Koha's templates do not cope well with right-to-left languages

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Hi Ruth

Unfortunately the first patch no longer applies

Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css
Failed to merge in the changes.
Patch failed at 0001 Bug 8061: RTL CSS overrides (OPAC)

The second one conflicts too

Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9842|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9898action=edit
Bug 8160 - Link to cataloging appears for users without cataloging permission

This patch wraps cataloging links on the staff client home
page and in the header menu with checks for edit_catalogue
OR edit_items permission.

To test, access the staff client as a user with various
permissions. The cataloging link on the main page and
in the header menu should only appear to a user with
edit_catalogue permission, edit_items permission, or both.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9622|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 9899
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9899action=edit
Bug 8111 - Language chooser display problem in self-checkout

- Adds required JavaScript and JavaScript linked files
- Updates CSS with changes relevant to this feature which had
  been made to the main CSS file.
- Removes an image file which has been made obsolete now that
  sco.css uses the main image sprite like opac.css does.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout

2012-06-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/