[Koha-bugs] [Bug 8239] Z39.50 Search/Import doesn't work with unicode characters from a specific server

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239

--- Comment #2 from Derryn  ---
Exactly the same result with both marc-8 and utf8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Jared Camins-Esakov  ---
I'm not sure the changes I made will have fixed it, but could you please try
again? At the very least, you shouldn't get that error about fetchall_arrayref
not working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #10309|0   |1
is obsolete||

--- Comment #4 from Jared Camins-Esakov  ---
Created attachment 10314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10314&action=edit
Bug 8256: Teach webservice to select reports by name

Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report
which specifies a name or id to select the report.

Test plan:
1. Create a report (or choose an existing one), and mark it public
2. Run the report using the web service:
[IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever
3. Confirm you get the expected results
4. Run the report by name using the web service:
[IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in
the name)
5. Confirm you get the same results
6. Run the report using the public web service:
[OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever
7. Confirm you get the same results
8. Run the report by name using the public web service:
[OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the
name)
9. Confirm you get the same results
10. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8203] Should be possible to save individual authorities

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8203] Should be possible to save individual authorities

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #10306|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 10313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10313&action=edit
[SIGNED-OFF] Bug 8203: Add ability to save individual authorities

Adds the ability to save individual authority records in MADS, MARCXML, or
binary MARC format to the staff client.

To test:
1. Apply patch
2. View authority record in staff client
3. Try saving record as MADS, MARCXML, and MARC, and confirm that the
   resulting files are what you expect

Signed-off-by: Katrin Fischer 
Works nicely, tested different export options on different records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Jared,

I can't get this to work :( The id works nicely for OPAC and for staff, but the
name does not work for me. 

http://localhost:8080/cgi-bin/koha/svc/report?name=Borrowers

Can't call method "fetchall_arrayref" on an undefined value at
/home/katrin/kohaclone/svc/report line 65.

or

http://localhost/cgi-bin/koha/svc/report?name=Borrowers

Sorry this report is not public

With id=2 both URLs work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #3 from Chris Cormack  ---
(In reply to comment #2)
> I manage to replicate this problem, but and it happen when you are logged in
> with koha admin account which doesn't have library (branch) assigned.
> 
Ahh yeah, we really really should stop people doing this, or at least strongly
recommend they don't. Should only ever use the kohaadmin user for upgrades and
setting up your first real user.


> Adding batch dies because of referential integrity error (since branch is
> NULL) and editing dies because there is no row created to edit.
> 
> It does work for CGI version, more research needs to be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Koha does not have a logging module

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Perhaps also take a look at Log4Perl 
http://search.cpan.org/~mschilli/Log-Log4perl-1.37/lib/Log/Log4perl.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8130] attach PDF files to a patron record

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Liz Rea  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8130] attach PDF files to a patron record

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Liz Rea  changed:

   What|Removed |Added

  Attachment #10185|0   |1
is obsolete||

--- Comment #13 from Liz Rea  ---
Created attachment 10312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10312&action=edit
Bug 8130 - attach PDF files to a patron record

Adds the ability to attach unlimited arbitrary files to
a borrower record.

Test Plan:
1) Enable system preference EnableBorrowerFiles
2) Look up borrower record, click 'Files' tab on left
3) Upload a file, download the file, delete the file.

Signed-off-by: Liz Rea 
rebased for current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8202] Add authorities to export tool

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8202] Add authorities to export tool

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #10305|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 10311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10311&action=edit
[SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl

Adds a separate tab on tools/export.pl for exporting authority records.

To test:
1. Try exporting authority records from the "Export data" tool

Signed-off-by: Katrin Fischer 
Tried different exports and everything worked nicely:
- removing fields from export (example: 942)
- limiting to one authority type
- changing the given file name
- exporting as MARC or XML

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8239] Z39.50 Search/Import doesn't work with unicode characters from a specific server

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack  ---
What happens if you tell it to get utf8 instead of marc8?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Chris Cormack  ---
Pushed both the original and follow up to 3.8.x, will be in 3.8.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #10304|0   |1
is obsolete||

--- Comment #4 from Jared Camins-Esakov  ---
Created attachment 10310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10310&action=edit
Bug 8206: Specify index in OPAC authority search

Adds a dropdown to allow the user to choose to search the 'mainentry,'
and 'match-heading'indexes, in addition to the 'any' index which is
the default.

To test (you will need authority records with see-from and
see-also headings):
1. Go to the browse subjects and authors section in the OPAC
2. Do a search for a fairly generic term that is used as a
   see-also term in a lot of records. Note that your search
   results include both the record that you wanted and all
   the other records that refer to it.
3. Apply the patch.
4. Repeat the search from step 2. Notice there is no change
   to the results.
5. Repeat the search from step 2, but choose "in main entry"
   and observe that you are now only seeing authority records
   with the search entered in their main entry.
6. Repeat the search from step 2, but choose "in any heading"
   and observe that the results are the same as in step 2. This
   is intentional, so that in the future notes in authorities
   can be made searchable.
7. Search for an obsolete form of heading with the "in keyword"
   option selected. Notice what results you get.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |jcam...@cpbibliography.com

--- Comment #2 from Jared Camins-Esakov  ---
Test plan:
1. Create a report (or choose an existing one), and mark it public
2. Run the report using the web service:
[IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever
3. Confirm you get the expected results
4. Run the report by name using the web service:
[IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in
the name)
5. Confirm you get the same results
6. Run the report using the public web service:
[OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever
7. Confirm you get the same results
8. Run the report by name using the public web service:
[OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the
name)
9. Confirm you get the same results
10. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10309&action=edit
Bug 8256: Teach webservice to select reports by name

Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report
which specifies a name or id to select the report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221

--- Comment #2 from Dobrica Pavlinusic  ---
I manage to replicate this problem, but and it happen when you are logged in
with koha admin account which doesn't have library (branch) assigned.

Adding batch dies because of referential integrity error (since branch is NULL)
and editing dies because there is no row created to edit.

It does work for CGI version, more research needs to be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Ian Walls  ---
Mostly just adding the new plugin, which appears to be functional.  Example of
usage in intranet-main, to get the doc-head-open.inc for 6 minutes.  Should be
an easy enough thing to revert if we later find some deep dark nastiness, but I
can't see any right now, and will mark Passed QA.

Note that 3-way merge is required... git bz is not applying for me here
directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6448] EAN-13 barcode support

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Ian Walls  ---
First patch does not update sysprefs.sql to reflect the new EAN13 option.  DB
Rev is also at 3.07 instead of 3.09.. (though the RM has to fix that
manually, anyway).

In Patch 2, C4/Barcodes/EAN13 is missing copyright statement.  Also,
subroutines are prototyped, which fails our perlcritic.  Another syspref
altered without changes to sysprefs.sql.

Marking Failed QA for above reasons.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8256] New: Reports webservice should allow selection by name

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8256
  Assignee: gmcha...@gmail.com
   Summary: Reports webservice should allow selection by name
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Reports
   Product: Koha

At the moment, reports cannot be selected from the reports webservice by name,
only by report ID. It would be very useful to be able to select a report by
name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #10290|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 10308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10308&action=edit
Bug 8251 - Patrons get incorrectly debarred

Patrons get incorrectly debarred because of the use of Datetime->delta_days
wich happens to always return a positive number.

Also changed the use of Datetime->truncate function so it follows the docs,
using 'day' instead of 'days' (which is used in DateTime::Duration).

This patch has been tested against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8130] attach PDF files to a patron record

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||koha.sek...@gmail.com

--- Comment #12 from Ian Walls  ---
Patch does not apply; probably a merge conflict in updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8255] Local cover images should be cacheable

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8255] Local cover images should be cacheable

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10307&action=edit
Bug 8255: allow local cover images to be cached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8255] New: Local cover images should be cacheable

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8255
  Assignee: jcam...@cpbibliography.com
   Summary: Local cover images should be cacheable
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: OPAC
   Product: Koha

At the moment, local cover images cannot be cached by the web browser or any
intermediate reverse proxies. This results in an unnecessary load on the
server, and is entirely unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Adds new syspref in standard manner.  Original behavior of system is kept,
making this 'opt-in'.

Greps through authority results for whether used > 0.  Changes template display
language to 'fuzzify' (my own word) the description when the syspref is turned
off.

Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Ian Walls  ---
Patch 1:  uses DelItemCheck instead of DelItem, with logic to handle when an
item cannot be deleted.  Good use of existing subroutine.  Passed QA.

Patch 2 + 3:  Work together to prevent the biblio from being NULLifed if the
item isn't deleted.  SQL only change, with a comment, marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7961] Local cover images should support CSV link files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Ian Walls  ---
Changes are well-reviewed by now, optimized over several QAings.  Code is
simple change, handles split more elegantly, and scrubs for leading/trailing
whitespace instead of whitespace anywhere in filename.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7686] Tax rate wrong calculation in reception summary page

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7686

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #7 from Ian Walls  ---
Setting status to "In Discussion" while 5335 is checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Koha does not have a logging module

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #3 from Jared Camins-Esakov  ---
I had a thought about this. Would it be possible to have the logging module
serve dual purposes, for both debug logging and for action_logs logging?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5349] Moving an order

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||koha.sek...@gmail.com

--- Comment #9 from Ian Walls  ---
First patch no longer applies... probably a conflict in updatedatabase

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8244] Script to find exporter problems

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Jared Camins-Esakov  ---
I am not sure about using requiring arguments to an xt/ test. Would it be
possible to have it automatically know that kohaclone is in dirname($0)/.. and
then use tempdir for a destination directory? If we did that, then this test
could safely be included in Koha?

Also, much more significantly, this script does not work for me. I ran the
following command:
> perl xt/find-undefined-subroutines.pl --src-path=/home/jcamins/kohaclone 
> --dest-path=/home/jcamins/kohatmp -v

It copied everything into /home/jcamins/kohatmp/home/jcamins/kohaclone, then
gave the following error:
cp: cannot create regular file `/home/jcamins/kohatmp/C4/Context.pm': No such
file or directory
sh: cannot create /home/jcamins/kohatmp/misc/kohalib.pl: Directory nonexistent
Unknown option: trap
Unable to continue at /usr/bin/prove line 10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8006] Loading offline circulation does not anonymize

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #3 from Ian Walls  ---
Simple fix to add another value to exported params.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #9 from Ian Walls  ---
Template only change, includes JS, CSS, and includes strings.  Minor table
structure fixes.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #7 from Ian Walls  ---
Template only change, includes JS, CSS and includes strings.  Fixes some table
structure.  Also includes new sort functions... possible conflict with bug
8099.  But, in terms of Master, it's good, so marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6634] manager_id not populated when paying fines

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #25 from Ian Walls  ---
Adds managerid recording to recordpayment(), chargelostitem(), and
recordpayment_selectaccts() subroutines.  Marking Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8099] DataTables in Acquisision module: acqui-home.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #6 from Ian Walls  ---
Template only change, includes JS, CSS and includes strings, as well as a new
sort method, which is called on the page.  No changes to the table structure.

Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #11 from Ian Walls  ---
Adds a new system preference (OpacNavRight) correctly, and shows it in the
place in the diagram where expected.  Strips out some YUI divs that may not be
necessary... I differ to Owen on such user interface changes.

Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8203] Should be possible to save individual authorities

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8203] Should be possible to save individual authorities

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10306&action=edit
Bug 8203: Add ability to save individual authorities

Adds the ability to save individual authority records in MADS, MARCXML, or
binary MARC format to the staff client.

To test:
1. Apply patch
2. View authority record in staff client
3. Try saving record as MADS, MARCXML, and MARC, and confirm that the
   resulting files are what you expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Ian Walls  ---
Patch 1:  adds new template param to get the Auth Type properly, then displays
it in the template.  Passed QA.

Patch 2:  replaces an empty string with the actual Auth Type.  Marking Passed
QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8202] Add authorities to export tool

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8202] Add authorities to export tool

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10305&action=edit
Bug 8202: Add authority export to tools/export.pl

Adds a separate tab on tools/export.pl for exporting authority records.

To test:
1. Try exporting authority records from the "Export data" tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #7 from Ian Walls  ---
Plack scoping only, safe for CGI environments, marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #10 from Ian Walls  ---
Plack scoping change only, ruled safe for CGI environments, marking Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #10266|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov  ---
Created attachment 10304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10304&action=edit
Bug 8206: Specify index in OPAC authority search

Adds a dropdown to allow the user to choose to search the 'mainentry,'
and 'match-heading'indexes, in addition to the 'any' index which is
the default.

To test (you will need authority records with see-from and
see-also headings):
1. Go to the browse subjects and authors section in the OPAC
2. Do a search for a fairly generic term that is used as a
   see-also term in a lot of records. Note that your search
   results include both the record that you wanted and all
   the other records that refer to it.
3. Apply the patch.
4. Repeat the search from step 2. Notice there is no change
   to the results.
5. Repeat the search from step 2, but choose "in main entry"
   and observe that you are now only seeing authority records
   with the search entered in their main entry.
6. Repeat the search from step 2, but choose "in any heading"
   and observe that the results are the same as in step 2. This
   is intentional, so that in the future notes in authorities
   can be made searchable.
7. Search for an obsolete form of heading with the "in keyword"
   option selected. Notice what results you get.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls  ---
Mostly a template change, but also adds the dateformat param to exported
template variables.  Includes JS, CSS, includes strings and reformats table to
make it work.

Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Ian Walls  ---
Both patches together add the "all authority types" option for UNIMARC in a
safe and sane way.  Marking Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls  ---
Template only change, includes JS, CSS and includes strings, as well as
reformatting of the table to make it all work.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8243] calendar being ignored

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243

Melia Meggs  changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #2 from Melia Meggs  ---
Is this the same as Bug 8110?  Or two different problems?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||koha.sek...@gmail.com

--- Comment #6 from Ian Walls  ---
First patch is okay, just adds ccode to the stats table so you don't have to do
a multi-table join to get it from items and deleteditems.

The database update, though, looks a little janky:

ALTER TABLE `statistics` ADD `ccode` VARCHAR( 80 ) NULL ;

should be more like 

ALTER TABLE `statistics` ADD COLUMN `ccode` VARCHAR ( 10 ) AFTER
`associatedborrower`

The update message is also inaccurate ("Category code" instead of "collection
code")

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

--- Comment #18 from Liz Rea  ---
Lol dangit. I want to see these patches get another look - this is no trivial
issue for libraries - we can't have patrons requesting and getting items over
the limits libraries have set in policy.

At this point, I am convinced that it is better to look at a partial fix to get
SOME limit, SOMEWHERE working. 

I will look at both fixes by Monday, june 18 2012.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

--- Comment #23 from Paul Poulain  ---
(In reply to comment #22)
> > 4/ You add a new dependency Test::YAML::Valid. I dont know if we have to add
> > this dependency to koha (given that it is used for unit tests).
> 
> I think we should be free to add new test libraies if we need it for
> testing. For discusion irl monday :)

I agree with claire = it's not a Koha dependency, it's a jenkins one, I think
it's OK not to add it to Koha

(claire = shouldn't you switch back to signed-off ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #17 from Liz Rea  ---
I want to see both patches get anot

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Liz Rea  changed:

   What|Removed |Added

   Attachment #6371|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect to the suggestion detail

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Template only change removing some query params in order to show the preferred
content.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8104] DataTables in Acquisision module: lateorders.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Template change only.  Includes JS, CSS, strings include and some reformatting
of the table for consistency.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8105] DataTables in Acquisision module: basketgroup.tt

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Template change only.  Adds DataTables JS and CSS, and reformats table layout
slightly to conform to it.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

--- Comment #22 from claire.hernan...@biblibre.com 
 ---
(In reply to comment #18)

> 1/ Usage is not correct:
> +=head1 USAGE
> +
> +From Koha root directory:
> +
> +prove -v xt/tt_valid.t

Yep done.

> 2/ It not possible to launch the test file from the koha home directory
> (prove xt/yaml_valid.t) (see the FindBin module) 

Done but too much code for me for adding this "feature" - nothing more sexy?

> 3/ Don't you think it would be more friendly to do a test file (thus using
> Test::More) for your pl file ?

I don't know how to give a parameter to a test file and I wanted to have a "-f"
option to test whatever you want (sudoc yaml file for example).

> 4/ You add a new dependency Test::YAML::Valid. I dont know if we have to add
> this dependency to koha (given that it is used for unit tests).

I think we should be free to add new test libraies if we need it for testing.
For discusion irl monday :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Ian Walls  ---
$dbh->quote takes care of the cleanliness, so my original objection is
withdrawn.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

  Attachment #10229|0   |1
is obsolete||

--- Comment #21 from claire.hernan...@biblibre.com 
 ---
Created attachment 10303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10303&action=edit
[SIGNED-OFF] Bug 7994: Fix pref yaml errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

  Attachment #10205|0   |1
is obsolete||
  Attachment #10301|0   |1
is obsolete||

--- Comment #20 from claire.hernan...@biblibre.com 
 ---
Created attachment 10302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10302&action=edit
[SIGNED-OFF] Bug 7994: scripts to check yaml files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #4 from Ian Walls  ---
Adjust length check by 1 to conform to standards.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

--- Comment #19 from claire.hernan...@biblibre.com 
 ---
Created attachment 10301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10301&action=edit
Bug 7994: scripts to check yaml files

$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7129] actual cost showing too many zeros

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Ian Walls  ---
Same work that passed QA the first time, just updated to reflect new variable
names.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7129] actual cost showing too many zeros

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129

Ian Walls  changed:

   What|Removed |Added

  Attachment #10216|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7129] actual cost showing too many zeros

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129

--- Comment #12 from Ian Walls  ---
Created attachment 10300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10300&action=edit
[PASSED QA] Bug 7129: Added a sprintf to format the actual cost.

Signed-off-by: Katrin Fischer 
Rebased to current master, please test.

Signed-off-by: Kyle M Hall 
Signed-off-by: Ian Walls 

QA note: changed call to use $order instead of @$results[0], for consistency
with surrounding variables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #10267|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 10299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10299&action=edit
[SIGNED-OFF] Bug 8205: Add OPACShowUnusedAuthorities syspref

Rather than list authorities that are not actually used by a library,
this commit introduces a new syspref: OPACShowUnusedAuthorities to
enable libraries to hide unused authorities in the OPAC authority browser.

To test:
1) Do a search in the OPAC authority browser that brings up multiple
   results, including some that are used in the bibliographic database
   and some that are not.
2) Observe that the results include both used and unused authorities.
3) Set OPACShowUnusedAuthorities to "Do not."
4) Repeat the same search as in step 1.
5) Observe that the results no longer include unused authorities.

Signed-off-by: Katrin Fischer 
Preference is implemented cleanly and works like advertised.
As a note: The unused authority records will be hidden from display,
but the result list paging does not adjust for the hidden records.
So the result pages will show more or less records total, depending
on how many records are hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Ian Walls  ---
Code is cleanly written and well documented.  Followup is simple, providing a
small consistency change to enable further work.  New template block is
translatable, which is the ultimate goal.

More followup may be required to address Katrin's enhancement requests, and as
other work comes in, but this as it stands Passes QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

--- Comment #3 from Owen Leonard  ---
Created attachment 10298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10298&action=edit
Bug 8194 - Layout problem on subscription add when showing manual history

Markup errors were causing display problems when the "manual history"
section is shown.

To test, apply the patch, load the subscription add page, and check
the "manual history" checkbox. The "Serials planning" section
should appear directly below the "manual history" section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|rel_3_8 |master
Summary|Subscription-add.tt |Layout problem on
   ||subscription add when
   ||showing manual history

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5295] ctype index Zebra configuration

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #7 from Ian Walls  ---
Replaces bib1.att ctype with Content-type, which is the correct index according
to external sources, as well as ccl.properties.  Marking Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8254] New: issn and isbn search on Z targets not working

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8254

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8254
  Assignee: gmcha...@gmail.com
   Summary: issn and isbn search on Z targets not working
  Severity: major
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
  Hardware: All
Status: NEW
   Version: master
 Component: Cataloging
   Product: Koha

I have tried on several targets that I know have a popular ISBN but the search
returns no results in master. I have had similar reports from those using 3.8.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #7 from Katrin Fischer  ---
Thx Jared for providing an additional patch for the staff side problem!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #10295|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 10297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297&action=edit
[SIGNED-OFF] Bug 6720: show authority type in auth details

Signed-off-by: Katrin Fischer 
Authority type on detail page in staff now shows correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4255] Add item type to facet list

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Ian Walls  ---
According to coding guideline HTML4, the string in the templates should be
"Item types" not "ItemTypes".

Otherwise, this patch is very good, even if it's MARC21-only.  I'm so pleased
with it, I've made the capitalization fixes myself, and resubmitted with QA
signoff.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4255] Add item type to facet list

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255

Ian Walls  changed:

   What|Removed |Added

  Attachment #10184|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4255] Add item type to facet list

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255

--- Comment #5 from Ian Walls  ---
Created attachment 10296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10296&action=edit
[PASSED QA] Bug 4255 - Add item type to facet list

This is for MARC 21 only.

Made following changed:

- In getFacets in C4/Koha.pm added item type facet for 952y and 942c
- In getRecords in C4:Search.pm added code to get description of itemtype codes
- facets.inc in both staff and opac to show item types related label in the
facets block

To test:

Add records such that a certain itype (say BK) is present in both 942c and 952y
in two DIFFERENT records.

Run a search where both test records are present. Test to see if itype types
are presented in the facets block (both OPAC and staff).

Click on the itype (say BK), both the test records should appear in the refined
results. This shows that the feature works for both 942c and 952y.

Signed-off-by: Kyle M Hall 

Signed-off-by: Ian Walls 

QA Comment: fixed capitalization in template includes according to HTML4 coding
guideline ("Item types" instead of "ItemTypes")

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6846] Dont allow staff to change own permissions

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Nicole C. Engard  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8253

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8253] Fine doubling

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Nicole C. Engard  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8182

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
New search option "in see from headings" does not work for me. Talking to Jared
it probably needs a follow-up - failing QA for the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving items requires repetitive clicking.

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8173] Have Full title (245) to always display in system

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8173

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
Version|rel_3_6 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #5 from Jared Camins-Esakov  ---
Created attachment 10295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10295&action=edit
Bug 6720: show authority type in auth details

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7444

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Nicole C. Engard  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8182

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Nicole C. Engard  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8165

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8165] due date of 00:00 instead of 23:59

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8165

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7444

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Adds missing required parameter to ModBasketHeader, and that's all.  Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls  ---
Reformats the datetime in issue->{returndate} into iso-formatted date.  Uses
C4::Dates, rather than DateTime, though, which we're looking to phase out.

if ( ($input->param('op') eq 'export_barcodes')
and ($today eq C4::Dates->new( $issue->{'returndate'}, 'iso' )->output("iso"))
) {

could be

my $return_dt = Koha::DateUtils::dt_from_string($issue->{'returndate'}, 'iso');
if ( ($input->param('op') eq 'export_barcodes')
and ($today eq $return_dt->ymd() ) {

My initial testing shows this change should work, and it won't introduce a new
dependence on C4::Dates we'll just have to replace later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Katrin Fischer  ---
Small note: Bug should remain open after pushing this patch. The problem also
still exists on the authority detail page in staff.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #10265|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 10294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10294&action=edit
[SIGNED-OFF] Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer 
Works nicely, result list for OPAC search now shows the authority type
for each record.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7382] normalization on isbn matching rule

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382

David Schuster  changed:

   What|Removed |Added

 CC||dschu...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >