[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Marc Véron changed: What|Removed |Added Attachment #10511|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 10534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10534&action=edit [SIGNED-OFF] Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313 Marc Véron changed: What|Removed |Added Attachment #10482|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 10533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10533&action=edit [SIGNED-OFF] Bug 8313 - add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311 Marc Véron changed: What|Removed |Added Attachment #10481|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 10532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10532&action=edit [SIGNED-OFF] Bug 8311: Fix scoping error in C4::Auth There is a mis-scoped function call in C4::Auth, on line 154, where GetMembers is called without explicit scoping and before 'require C4::Members;'. This does not actually have any functional ramifications as far as I can tell, but it would be a good idea to fix it. This patch also corrects a bit of indenting in that area, because it was an unnecessary challenge to understand the code with the mis-indenting. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #13 from Marc Véron --- Chris, Thanks for taking care of the additional functionality I need, see 3) below. I tried out the patch and found the following: -- - If a patron has a credit (instead of fines), the redirect is done as well. This should not be. -- - CircAutoPrintQuickSlip should have 3 possibilities: 1) Clear the screen (EXISTS) 2) Open a print quick slip window [...and do not change the screen] (EXISTS, behaviour until now, we should not change it) 3) Open a print quick slip window and clear the screen (NEW and needs to be an explicit choice) - CircPayFinesRedirect (if set and if there are fines) should override the options above and redirect to pay fines screen. If patron has no fines or if patron has a credit, it should leave the options above as set. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall changed: What|Removed |Added Attachment #10528|0 |1 is obsolete|| --- Comment #12 from Chris Hall --- Created attachment 10531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10531&action=edit Allows pay fines redirect to work with print spooling. Attached proper patch, somehow the old patch got attached rather than the new one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8323] User created lists not sorting properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Hall changed: What|Removed |Added CC||chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6402] Lists sorted by year appear to be empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6402 Chris Hall changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #5 from Chris Hall --- I have uploaded a possible fix for Owen's bug to bug8323 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8323] User created lists not sorting properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Hall changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |chr...@catalyst.net.nz --- Comment #1 from Chris Hall --- Created attachment 10530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10530&action=edit Fixing year sorting of OPAC lists Patch attached to fix, will pass sort field through the the SQL and will change 'year' to 'copyrightdate'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8323] New: User created lists not sorting properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Priority: P5 - low Change sponsored?: --- Bug ID: 8323 Assignee: oleon...@myacpl.org Summary: User created lists not sorting properly Severity: trivial Classification: Unclassified OS: All Reporter: chr...@catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha Sorting by year in opac lists doesn't work due to trying to use biblioitems.publicationyear which is not mapped in the default MARC21 mapping. My patch passes through the sorting field and will change 'year' to 'copyrightdate' to instead sort by biblio.copyrightdate (marc 260$c). Patch incoming (have to get bug number first). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8322] Removing space between end of marc data and fullstops
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322 Chris Hall changed: What|Removed |Added CC||chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8322] Removing space between end of marc data and fullstops
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322 Chris Hall changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |chr...@catalyst.net.nz --- Comment #1 from Chris Hall --- Created attachment 10529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10529&action=edit Removes space between end of data and fullstop. Attached patch removes these unneeded spaces. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8322] New: Removing space between end of marc data and fullstops
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322 Priority: P5 - low Change sponsored?: --- Bug ID: 8322 Assignee: oleon...@myacpl.org Summary: Removing space between end of marc data and fullstops Severity: enhancement Classification: Unclassified OS: All Reporter: chr...@catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha On both opac-detail and catalogue/detail there are some unneeded spaces between the end of information and fullstops on various marc fields. Patch to fix coming soon (have to submit to get bug number first). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall changed: What|Removed |Added Attachment #9574|0 |1 is obsolete|| --- Comment #11 from Chris Hall --- Created attachment 10528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10528&action=edit Allows pay fines redirect to work with print spooling. Scratch that last comment, by removing the return statement from the javascript for quickslip and moving the code for CircPayFinesRedirect in to the perl code I am able to get the functionality you desired Marc Veron :) Attached is my work so far, there are 4 combinations. CircPayFinesRedirect: do nothing, CircAutoPrintQuickSlip: clear the screen -> clears the screen CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: clear the screen -> redirects if borrower has fines, otherwise clears the screen CircPayFinesRedirect: do nothing and CircAutoPrintQuickSlip: open quickslip window -> opens quick print slip and then clears the screen CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: open quickslip window -> opens quick print slip and then redirects if the borrower has fines, otherwise clears the screen (after opening print slip window). It may be wise to combine these in to a single syspref or change the wording to explain the options better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #10 from Chris Hall --- I have done some more work since my last patch, I will upload it shortly. In order to get this to work with print spooling I have moved the CircPayFinesRedirect code from the javascript and in to perl. In order to make this work with correctly CircAutoPrintQuickSlip I may also have move the relevant code in to perl (so any redirects happen after the code dealing with print spooling). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Just need to make sure the pref works with printing without the windows too. IE printing direct to a printqueue. And then that would be fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #8 from Chris Hall --- I quite like your suggestion Marc Veron, I think having all the related options immediately visible in the same syspref is an improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #124 from Mason James --- Created attachment 10527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10527&action=edit Bug 6679 - fix 2 perlcritic violations in C4/AuthoritiesMarc.pm "return" statement with explicit "undef" at line 853, column 5. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 1191, column 3. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #123 from Mason James --- Created attachment 10526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10526&action=edit Bug 6679 - fix 2 perlcritic violations in C4/BackgroundJob.pm "return" statement with explicit "undef" at line 234, column 5. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 256, column 9. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #122 from Mason James --- Created attachment 10525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10525&action=edit Bug 6679 - fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #121 from Mason James --- Created attachment 10524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10524&action=edit Bug 6679 - fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm "return" statement with explicit "undef" at line 170, column 13. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 407, column 9. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #120 from Mason James --- Created attachment 10523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10523&action=edit Bug 6679 - fix 2 perlcritic violations in C4/Print.pm Bareword file handle opened at line 80, column 9. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 80, column 9. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #119 from Mason James --- Created attachment 10522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10522&action=edit Bug 6679 - fix 2 perlcritic violations in C4/Utils.pm Subroutine prototypes used at line 38, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 43, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #118 from Mason James --- Created attachment 10521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10521&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings Subroutine prototypes used at line 561, column 1. See page 194 of PBP. (Severity: 5) Bareword file handle opened at line 606, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 606, column 5. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Chris Cormack changed: What|Removed |Added Assignee|gmcha...@gmail.com |ro...@catalyst.net.nz --- Comment #39 from Chris Cormack --- git/catalyst-koha/debian% ls templates apache-shared.conf apache-site.conf.in zebra-authorities-site.cfg.in apache-shared-disable.conf koha-conf-site.xml.in zebra-biblios-site.cfg.in apache-shared-intranet.conf SIPconfig.xmlzebra.passwd.in apache-shared-opac.conf zebra-authorities-dom-site.cfg.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #18 from Melia Meggs --- Yes, that's exactly it, Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #17 from Katrin Fischer --- Hi Paul, the use case that comes to my mind are signed registration forms or other forms that need a signature from the patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8130] attach PDF files to a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #16 from Paul Poulain --- Hi Melia, Could you explain the use case for this feature ? I can't see why it's something we would need in an ILS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #20 from Nicole C. Engard --- Why yes you did! Somehow I missed that. Signed off!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Nicole C. Engard changed: What|Removed |Added Attachment #10410|0 |1 is obsolete|| --- Comment #19 from Nicole C. Engard --- Created attachment 10520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10520&action=edit [SIGNED-OFF] Bug 7955: Followup: Fix badly use of dbh->quote Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8321] fix OPACShowBarcode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321 Nicole C. Engard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8321] fix OPACShowBarcode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321 --- Comment #1 from Nicole C. Engard --- Created attachment 10519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10519&action=edit Bug 8321: Fix OPACShowBarcode description This preference had a few grammar errors and repeated the word 'show.' This patch resolves those issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8321] New: fix OPACShowBarcode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321 Priority: P5 - low Change sponsored?: --- Bug ID: 8321 Assignee: neng...@gmail.com Summary: fix OPACShowBarcode description Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha OPACShowBarcode has a description of: Show/Don't show Show items barcode in holding tab. It's repeating the "show" bit. Patch coming fixing this and the grammar on this preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #18 from Jonathan Druart --- Hi Nicole, I proposed a followup to fix this issue. See attachment 10410 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #7 from Marc Véron --- Opened Bug 8320 as replacement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip' with more options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320 Marc Véron changed: What|Removed |Added CC||jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip' with more options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320 Marc Véron changed: What|Removed |Added CC||chr...@catalyst.net.nz, ||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #17 from Nicole C. Engard --- Created attachment 10518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10518&action=edit item type, collections,locations not showing I'm on master as of this morning and my stats look like the attached. It doesn't show item types, locations or collection - instead it just repeats the headings again ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip' with more options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8058 Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8320 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8320] New: Expand choices of 'CircAutoPrintQuickSlip' with more options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320 Priority: P5 - low Change sponsored?: --- Bug ID: 8320 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Expand choices of 'CircAutoPrintQuickSlip' with more options Severity: enhancement Classification: Unclassified OS: All Reporter: ve...@veron.ch Hardware: All Status: NEW Version: master Component: Circulation Product: Koha This enhancement is to replace "Bug 8058 - Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines" by Chris Hall with a more flexible solution. Instead of having a preference 'circpayfinesredirect' (as proposed in Bug 8058) I plan to expand the choices of 'CircAutoPrintQuickSlip' with two more options: "open a print quick slip window and clear the screen" (that's what I need to have) "open a print quick slip window and redirect to outstanding fines (if any)" (that's what Chris needs to have) The values can be evaluated in circulation.tt (near the comment '// listen submit to trigger qslip on empty checkout'). This can be expanded for any needs. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #117 from Mason James --- Created attachment 10517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517&action=edit Bug 6679 - fix 3 perlcritic violations in C4/ClassSortRoutine.pm Expression form of "eval" at line 55, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 57, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 58, column 13. See page 161 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8319] headings on statistics tab are confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319 Nicole C. Engard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8319] headings on statistics tab are confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319 --- Comment #1 from Nicole C. Engard --- Created attachment 10516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10516&action=edit Bug 8319: Update headings on Patron Statistics tab The patron statistics tab had had headings that were too hard to understand for the average library user. This patch changes the language to something less technical. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8319] New: headings on statistics tab are confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319 Priority: P5 - low Change sponsored?: --- Bug ID: 8319 Assignee: neng...@gmail.com Summary: headings on statistics tab are confusing Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com URL: cgi-bin/koha/members/statistics.pl?borrowernumber=51 Hardware: All Status: ASSIGNED Version: master Component: Templates Depends on: 7955 Product: Koha On the statistics tab on the patron record the table headings are confusing to the average library staff member. I propose changing the language to something a bit clearer. Patch to come -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Nicole C. Engard changed: What|Removed |Added Blocks||8319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #116 from Mason James --- Created attachment 10515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10515&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Items.pm "return" statement with explicit "undef" at line 508, column 44. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 2267, column 5. See page 199 of PBP. (Severity: 5) Variable declared in conditional statement at line 2642, column 21. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #115 from Mason James --- Created attachment 10514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10514&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Message.pm "return" statement with explicit "undef" at line 109, column 9. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 145, column 9. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 319, column 9. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #114 from Mason James --- Created attachment 10513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10513&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Output.pm "return" statement with explicit "undef" at line 128, column 74. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 270, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 308, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #113 from Mason James --- Created attachment 10512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10512&action=edit Bug 6679 - fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Nicole C. Engard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 --- Comment #1 from Nicole C. Engard --- Created attachment 10511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10511&action=edit Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #112 from Mason James --- Created attachment 10510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10510&action=edit Bug 6679 - fix 3 perlcritic violations in C4/SQLHelper.pm Subroutine prototypes used at line 251, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 287, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 317, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Nicole C. Engard changed: What|Removed |Added Blocks||8318 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] New: update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Priority: P5 - low Change sponsored?: --- Bug ID: 8318 Assignee: neng...@gmail.com Summary: update StatisticsFields description Severity: minor Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: ASSIGNED Version: master Component: Templates Depends on: 7955 Product: Koha StatisticsFields says "___ Define Fields (from the items table) used for statistics members (separate fields with |, for example:"location|itype|ccode")." Originally I thought this was related to the statistical member type - so I recommend the following language change for this preference: "Show the following fields from the items database table as columns on the statistics tab on the patron record: ___ (separate fields with |)" Patch to follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #111 from Mason James --- Created attachment 10509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10509&action=edit Bug 6679 - fix 4 perlcritic violations in C4/Branch.pm Subroutine prototypes used at line 157, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 375, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 385, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 418, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #110 from Mason James --- Created attachment 10508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10508&action=edit Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm - "return" statement with explicit "undef" at line 171, column 8. See page 199 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 201, column 8. See page 199 of PBP. (Severity: 5) - Bareword file handle opened at line 212, column 11. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 212, column 11. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8317] New: Cursor appears again not in Search box of catalogue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Priority: P5 - low Change sponsored?: --- Bug ID: 8317 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Cursor appears again not in Search box of catalogue Severity: enhancement Classification: Unclassified OS: All Reporter: programm...@tyndale.cam.ac.uk Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha While two bugs (3189, 5125) in the past dealt with this issue and were resolved, now again the cursor is not in the right place. Thus when a patron in firefox enters the catalogue, it is not directly in the only search-box on the screen. (Tested in firefox and IE.) Entered for the Tyndale House library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #109 from Mason James --- Created attachment 10507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10507&action=edit Bug 6679 - fix 4 perlcritic violations in C4/Installer.pm - Bareword file handle opened at line 157, column 13. See pages 202,204 of PBP. (Severity: 5) - I/O layer ":utf8" used at line 157, column 13. Use ":encoding(UTF-8)" to get strict validation. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #108 from Mason James --- Created attachment 10506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10506&action=edit Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm - Variable declared in conditional statement at line 183, column 5. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #107 from Mason James --- Created attachment 10505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10505&action=edit Bug 6679 - fix 5 perlcritic violations in C4/Serials.pm - Subroutine prototypes used at line 161, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #106 from Mason James --- Created attachment 10504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10504&action=edit Bug 6679 - fix 5 perlcritic violations in C4/VirtualShelves.pm, and comment-out obselete sub() - Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) - Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #105 from Mason James --- Created attachment 10503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10503&action=edit Bug 6679 - fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm - Subroutine prototypes used at line 45, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 Albert Oller changed: What|Removed |Added CC||jwag...@ptfs.com --- Comment #7 from Albert Oller --- *** Bug 3686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3686] Hold slips sometimes don't print barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3686 Albert Oller changed: What|Removed |Added Status|NEW |RESOLVED CC||a...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Albert Oller --- This looks like a dupe of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 *** This bug has been marked as a duplicate of bug 7255 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #22 from Robin Sheat --- OK, it is a dependency of Template::Plugin::HtmlToText, however that doesn't declare it as a dependency in the META.yml, so the packages don't either, and so it never gets installed. Guess I'll have to redo the packages some time soon to account for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #104 from Mason James --- Created attachment 10502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10502&action=edit Bug 6679 - fix 6 perlcritic violations in C4/Reports/Guided.pm - Subroutine prototypes used at line 376, column 1. See page 194 of PBP. (Severity: 5) - Bareword file handle opened at line 757, column 2. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 757, column 2. See page 207 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #103 from Mason James --- Created attachment 10501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10501&action=edit Bug 6679 - fix 7 perlcritic violations in C4/Biblio.pm - Expression form of "eval" at line 492, column 12. See page 161 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 891, column 5. See page 199 of PBP. (Severity: 5) - Subroutine prototypes used at line 1148, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #6 from Marc Véron --- Chris and Jared, I was asked to add an additional functionality after printing: Automaticalle clear the screen. This would be in conflict with Chris' solution. So I think we could implement both using a more flexible approach. I propose to drop the preference 'circpayfinesredirect' Instead, expand the choices of 'CircAutoPrintQuickSlip' with two more options: "open a print quick slip window and clear the screen" (that's what I need to have) "open a print quick slip window and redirect to outstanding fines (if any)" (that's what Chris needs to have) The values then can be evaluated in circulation.tt (near the comment '// listen submit to trigger qslip on empty checkout'). This can be expanded for any needs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #102 from Mason James --- Created attachment 10500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10500&action=edit Bug 6679 - fix 8 perlcritic violations in C4/Barcodes.pm - "return" statement with explicit "undef" at line 57, column 2. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #101 from Mason James --- Created attachment 10499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10499&action=edit Bug 6679 - fix 8 perlcritic violations in C4/Circulation.pm - "return" statement with explicit "undef" at line 994, column 39. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679
--- Comment #100 from Jonathan Druart ---
(In reply to comment #88)
> Created attachment 10485 [details]
> Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm
FAILED QA for this patch, I think the following lines don't have to be
modified:
-return unless exists $params->{'letter'};
-return unless exists $params->{'borrowernumber'};
-return unless exists $params->{'message_transport_type'};
+return exists $params->{'letter'};
+return exists $params->{'borrowernumber'};
+return exists $params->{'message_transport_type'};
It's unless, not undef :-)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Robin Sheat changed: What|Removed |Added CC||ro...@catalyst.net.nz --- Comment #21 from Robin Sheat --- I think this patch introduces a bug: +use HTML::FormatText; this isn't mentioned in the dependency list, and doesn't appear to be used in the code. Thus, opac-sendbasket.pl breaks unless you happen to have that module installed. Can someone confirm that this is the case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What|Removed |Added Attachment #10494|Bug 6679 - fix 12 |Bug 6679 - [SIGNED-OFF]fix description|perlcritic violations in|12 perlcritic violations in |C4/External/BakerTaylor.pm |C4/External/BakerTaylor.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8316] New: authority add form still has + and - and ...
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8316 Priority: P5 - low Change sponsored?: --- Bug ID: 8316 Assignee: oleon...@myacpl.org Summary: authority add form still has + and - and ... Severity: enhancement Classification: Unclassified OS: All Reporter: neng...@gmail.com URL: cgi-bin/koha/authorities/authorities.pl?authtypecode=P ERSO_NAME Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 10498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10498&action=edit authority add form The authority add form still has the old syntax for duplicating (+), subtracting (-) and plugins (...). This form should probably match the cataloging interface in terms of icons for these actions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What|Removed |Added Attachment #10484|0 |1 is obsolete|| --- Comment #99 from Jonathan Druart --- Created attachment 10497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10497&action=edit Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violations in C4/Tags.pm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What|Removed |Added Attachment #10487|0 |1 is obsolete|| --- Comment #98 from Jonathan Druart --- Created attachment 10496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10496&action=edit Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm "return" statement with explicit "undef" at line 486, column 5. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 548, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What|Removed |Added Attachment #10488|0 |1 is obsolete|| --- Comment #97 from Jonathan Druart --- Created attachment 10495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10495&action=edit Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm Subroutine prototypes used at line 73, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 74, column 24. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What|Removed |Added Attachment #10489|0 |1 is obsolete|| --- Comment #96 from Jonathan Druart --- Created attachment 10494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10494&action=edit Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 83, column 22. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #95 from Mason James --- Created attachment 10493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10493&action=edit Bug 6679 - fix 9 perlcritic violations in C4/Koha.pm - Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 1112, column 4. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #94 from Mason James --- Created attachment 10492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10492&action=edit Bug 6679 - fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Julian Maurice --- Ok, I mark it as 'failed QA' and will resubmit a patch soon ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #93 from Mason James --- Created attachment 10491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10491&action=edit Bug 6679 - fix 11 perlcritic violations in C4/Dates.pm - Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 102, column 28. See page 199 of PBP. (Severity: 5) - Expression form of "eval" at line 108, column 20. See page 161 of PBP. (Severity: 5) - Variable declared in conditional statement at line 126, column 5. Declare variables outside of the condition. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #3 from Robin Sheat --- Created attachment 10490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490&action=edit Bug 8315 - fix 'C4::Output 3.02' errors in Koha modified: opac/opac-ratings-ajax.pl modified: opac/opac-tags.pl modified: tags/review.pl Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #92 from Mason James --- Created attachment 10489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10489&action=edit Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 83, column 22. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #91 from Mason James --- Created attachment 10488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10488&action=edit Bug 6679 - fix 12 perlcritic violations in C4/Auth_with_ldap.pm Subroutine prototypes used at line 73, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 74, column 24. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #90 from Mason James --- Created attachment 10487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10487&action=edit Bug 6679 - fix 12 perlcritic violations in C4/Context.pm "return" statement with explicit "undef" at line 486, column 5. See page 199 of PBP. (Severity: 5) Subroutine prototypes used at line 548, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #19 from Marc Véron --- I spent some time to find out what happens. It seems that the popup functionality is implemented with the JavaScript function transfer_order_popup() in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt but it is *not* implemented in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt (this is the place where I tested, see the first page in my screenshots http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441 ) Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
