[Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff CC||mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064
--- Comment #1 from M. Tompsett ---
Created attachment 10572
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10572&action=edit
Optimized two if statements, but otherwise fixed already in master.
I was hunting through opac-search.pl and only found two references to
$params->{'offset'} other than the initialization line that oleonard pointed
out.
616:if (($params->{'offset'}||'') eq '') {
594:if (($params->{'offset'}||'') eq '') {
If the parameter is undefined, the two lines above will be true.
If the parameter is an empty string, the two lines above will be true.
If the parameter is 0 or "0", the two lines above will be true.
If the parameter is a non-zero value or an otherwise non-empty string, the two
lines above will be false.
It would seem to me that the above code on lines 594 and 616 in master is
sufficient.
Additionally, oleonard mentioned $borrowernumber.
592:if (!$borrowernumber || $borrowernumber eq '') {
This is the only line that resembles what oleonard referred to.
It would seem to me that the above code on line 592 in master is sufficient.
The initialization of $offset is now on line 400 in master:
my $offset = $params->{'offset'} || 0;
This implies that the parameter is expected to be numeric, not a string.
I think oleonard's observation that there is a $offset variable is useful to
note as everywhere else in opac-search.pl uses the $offset variable.
Based on the initialization line above:
If the parameter is undefined, $offset is 0.
If the parameter is an empty string, $offset is 0.
If the parameter is 0 or "0", $offset is 0.
If the parameter is a non-zero value or an otherwise non-empty string, $offset
is that value or string.
This means that lines 616 and 594 could be optimized to:
616:if (!$offset) {
594:if (!$offset) {
Lines 592 and 594 correspond to the two lines oleonard mentions. This means I
believe the bug is fixed already. I am changing the status to Needs Signoff, as
this is not NEW. I'm attaching a patch accordingly, but feel free to reject it
and just close this.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217
--- Comment #16 from Chris Cormack ---
Follow up does not apply to 3.8.x
<<< HEAD
$('#bibliodetails > ul').tabs();
===
$('#bibliodetails').tabs();
$('#search-form').focus();
>>> a4d2a99... Bug 8217: Followup: move code to the document.ready function
>>>
Please
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Chris Cormack changed: What|Removed |Added Version|rel_3_8 |rel_3_10 --- Comment #18 from Chris Cormack --- Because this now makes it impossible to send a cart without being logged in (which is probably a valid change) it is a big behaviour change which I dont want to spring on people mid cycle. Holding for 3.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #12 from Chris Cormack --- First patch pushed to 3.8.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8087] Calendar not working in dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Albert that issue sounds totally unrelated to the dropbox, So either we should change this bug description. Or make it resolved duplicate of bug 5644 (which is to do with the calendar and dropbox) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #12 from Chris Cormack --- +++-++---+-+-++--+-+-+ | borrowernumber | itemnumber | date_due| branchcode | issuingbranch | returndate | lastreneweddate | return | renewals | timestamp | issuedate | +++-++---+-+-++--+-+-+ | 15861 | 23035 | 2012-07-21 23:59:00 | ME | NULL | 2012-06-29 09:10:00 | NULL| NULL | NULL | 2012-06-30 09:10:43 | 2012-06-30 09:09:00 | +++-++---+-+-++--+-+-+ Looks to be working now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #11 from Chris Cormack --- Created attachment 10571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10571&action=edit Bug 5644 : Fixing dropbox mode calculation -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644
Chris Cormack changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #10 from Chris Cormack ---
The problem is in Koha::Calendar
if ( $add_duration->is_negative() ){
$day_dur->inverse();
}
This does not do what we expect, namely it does not invert the value.
Working on a fix now
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #9 from Melia Meggs --- Thank you, Chris! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Melia Meggs changed: What|Removed |Added Depends on||5644 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs changed: What|Removed |Added Blocks||8338 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] New: fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Priority: P5 - low Change sponsored?: --- Bug ID: 8338 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: fines not cleared with dropbox mode Severity: enhancement Classification: Unclassified OS: All Reporter: me...@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha >From Nicole: It was my understanding that checking the dropbox mode option on the check in screen made the due date effectively the last day the library was open and as such wiped out fines for the extra day. It appears that is not the case. Fines for the item being late remain on the patron's account. The only way around this is to 'forgive fines' when using dropbox mode, but that forgives all fines and really we only want to forgive one day of fines. So if the fines script has already run, then fines are not wiped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs changed: What|Removed |Added Summary|fines not cleared with |dropbox mode doesn't set |dropbox mode|the correct date -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #8 from Chris Cormack --- Right that is a separate issue from the one nicole reported, which was an ehancement request to wipe fines already charged. Two choices, rename the description of this to be, dropbox mode doesnt set the correct date and leave it critical, and make a new one for the wiping fines, an ehancement, that is blocked by this. Or vice versa. I'm looking into the dropbox not setting the date issue now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #7 from Melia Meggs --- Ah ok. Thanks for the explanation. I'm saying that backdating the checkin date is not working. (Maybe this needs a new bug report?) The library runs the fines script at noon. Before they upgraded to 3.8, they used to checkin the books from the dropbox in the morning and backdate the checkin date, so no fines were added for that day when the fines script ran at noon. Now they cannot backdate the checkin date, so fines get charged on those books. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #6 from Chris Cormack --- Hmm there are 2 different things here Melia. Backdating the checkin date, and wiping fines. Backdating the checkin date always used to work, and was working with this bug was logged. What wasn't working was that if the fines had already run things were not wiped. If you are saying now that you can't even backdate the checkin date that is a different problem and something broken recently. Is that the case? IF so, fixing the backdating will still not remove the fines, but if the books are checked in before the fines script runs they will not get fines added to them. So .. is setting the backdate broken now too? Or can you still do that and is the problem that you still don't wipe fines? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc Véron changed: What|Removed |Added Attachment #10557|0 |1 is obsolete|| --- Comment #24 from Marc Véron --- Created attachment 10570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10570&action=edit [REBASED] Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference ...to version 3.09.00.021 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #2 from Maxime Pelletier --- Created attachment 10569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10569&action=edit patch to add longoverdue syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Maxime Pelletier changed: What|Removed |Added Change sponsored?|--- |Sponsored --- Comment #1 from Maxime Pelletier --- Sponsored by the koha-CCSR community. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] New: System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Priority: P5 - low Change sponsored?: --- Bug ID: 8337 Assignee: gmcha...@gmail.com Summary: System preferences for longoverdue cron Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermax...@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Command-line Utilities Product: Koha Patch to follow that adds 3 new system preferences to control the parameters for the longoverdue script. New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and DefaultLongOverdueDays. These preferences are used when you call the longoverdue.pl script without their parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs changed: What|Removed |Added CC||me...@bywatersolutions.com Severity|major |critical --- Comment #5 from Melia Meggs --- This bug is kind of a big deal. Libraries need to be able to use dropbox mode to prevent the fine calculation from happening in the morning when they are checking in books that were put in the dropbox the night before. Right now in 3.8, they are not able to backdate the checkin date, so fines are being incorrectly charged on all books that come in from the dropbox. That's a lot of extra fines to remove manually every single day! Can we fix just the checkin date part of this without waiting on the entire Accountlines Rewrite? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell --- Corrected status of this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8087 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8087] Calendar not working in dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5644 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 --- Comment #1 from Marc Véron --- Created attachment 10568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10568&action=edit Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 10567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10567&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] New: SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Priority: P5 - low Change sponsored?: --- Bug ID: 8336 CC: colin.campb...@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: SIP Server does not process renewal transaction correctly Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campb...@ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: SIP2 Product: Koha Sip renewal transactions are rejected by bogus error messages. If we suppress that it is not setting some data correctly e.g. the new duedate. Most people will not notice this as selfcheck units use the checkout transaction to do renewal, however if you want to use Itiva/Talking Tech telephone renewals you need to support this transaction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8335] New: Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Priority: P5 - low Change sponsored?: --- Bug ID: 8335 Assignee: oleon...@myacpl.org Summary: Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl Severity: minor Classification: Unclassified OS: All Reporter: ve...@veron.ch Hardware: All Status: NEW Version: master Component: OPAC Product: Koha koha-error_log complains the following: File does not exist: /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/img/famfamfam/PR.png, referer: http://(--)/cgi-bin/koha/catalogue/detail.pl?biblionumber=9 It seems that this is triggered by: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl in follwoing lines: (...) PR Two possibilities: - Icon PR.png is really missing - Typo in MARC21slim2OPACDetail.xsl Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Nicole C. Engard changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21 from Nicole C. Engard --- Actually I think this is adding another Notices tab to the patron record. I see Notices, Statistics, Notices on the left hand side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Paul Poulain changed: What|Removed |Added Assignee|gmcha...@gmail.com |koha.sek...@gmail.com --- Comment #18 from Paul Poulain --- (In reply to comment #17) > Reverted from 3.8.x, so needs to be fixed before the 3.10.0 release Patch also reverted from master. Switching status to failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175
--- Comment #3 from M. Tompsett ---
Created attachment 10566
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10566&action=edit
Undefined $items->{'materials'} fails a string check, so drop it.
Dropping the "ne ''" was more elegant.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 M. Tompsett changed: What|Removed |Added CC||fred.pie...@smfpl.org --- Comment #4 from M. Tompsett --- *** Bug 7352 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7352] moremember.pl generates error in Template.pm related to missing $key value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352 M. Tompsett changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett --- *** This bug has been marked as a duplicate of bug 7630 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6840] error in Template.pm in logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840 --- Comment #10 from M. Tompsett --- I have posted a patch on bug 7630 which should address Fred P's issues. This patch is still live. I like it. It's a friendly warning, rather than an error to track down. Thanks to jcamins for helping me get my DEV setup done. :) Can someone close this bug? It's not an issue, in my opinion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Paul Poulain --- new patch pushed (on master branch, not new/bug_6350) follow-up made because decmember is not a month afaik ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 --- Comment #1 from M. Tompsett --- Created attachment 10565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10565&action=edit Reduced memory requirements of a massive select statement SELECT * joining items, bibioitems, and biblio is bad. The MARC and XML fields will eat memory very quickly. Our server has ridiculously low memory and lots of items marked as lost. We were getting Error 500 pages as output as a result. Since the GetLostItems function is only used by the Items Lost report, I looked at the template in reports/itemslost.tt to get an idea of what might better be suited in the SELECT statement. It was horribly slow, but finally worked. I need to get more than 512MB for our server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #15 from Paul Poulain --- Follow-up pushed on master branch directly, does not apply on new/bug_8217 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #6 from Paul Poulain --- (In reply to comment #5) > Paul, > > I just did a fetch from master and applied the patch just fine ... ??? That's strange, I get the following conflict: 134 <<< HEAD 135 - Define Fields (from the items table) used for statistics members (separate fields with |, for example:"location|itype|ccode"). 136 - 137 - pref: EnableBorrowerFiles 138choices: 139yes: Do 140no: "Don't" 141 - enable the ability to upload and attach arbitrary files to a borrower record. 142 === 143 - (separate fields with |) 144 >>> Bug 8318: Update StatisticsFields preference language I've rewritten you patch, and pushed, this will remain a mistery -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #2 from M. Tompsett --- Created attachment 10564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10564&action=edit Added a missing dereference marker for an array parameter. As our library has been adding and editing lots of items, I have yet to see the bug resurface. I think the patch is self-evident. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 Assignee|gmcha...@gmail.com |semarie-k...@latrappe.fr --- Comment #17 from Paul Poulain --- (assignee changed, to reflect who sent the patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8334] New: Authority UNIMARC 100 field plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Priority: P5 - low Change sponsored?: --- Bug ID: 8334 Assignee: gmcha...@gmail.com Summary: Authority UNIMARC 100 field plugin Severity: enhancement Classification: Unclassified OS: All Reporter: vfernan...@keep.pt Hardware: All Status: NEW Version: unspecified Component: MARC Authority data support Product: Koha There is no 100 authority field plugin. It would be nice to have it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #6 from Paul Poulain --- OK, got it. Patch pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7352] moremember.pl generates error in Template.pm related to missing $key value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352 --- Comment #2 from M. Tompsett --- I believe the patch I just submitted to Bug 7630 will make this bug report obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 --- Comment #3 from M. Tompsett --- Created attachment 10563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10563&action=edit Proposed Patch to the BUG After getting a DEV install set up, I tweaked moremember.pl as described. To trigger the error: - Staff Client - Login - Patrons - Search for a patron somehow and then look at their details. - When moremember.pl is called, because there is no $error, it will trigger: [Fri Jun 29 21:37:32 2012] [error] [client 192.168.69.34] [Fri Jun 29 21:37:32 2012] moremember.pl: Problem = a value of 1 has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 187., referer: http://192.168.69.37:8080/ By moving the "$error => 1" to a conditional $template->param(), the error log no longer gets spammed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6557] biblioitems.totalissues unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #32 from Paul Poulain --- Patch pushed but NOTE : * i've provided a follow-up for french UNIMARC frameworks, that had no 942$0 at all, making the script badly fail: $ misc/cronjobs/update_totalissues.pl --use-items Tag "0" is not a valid tag. at /home/paul/koha.dev/koha-community//C4/Biblio.pm line 3870 A follow-up could be written to add a more clear error message: if biblioitems.totalissues isn't linked to a MARC field, issue a message before dying. * I'll also send a mail to koha-devel & koha-translate to warn ppl in case there is another language framework that has this problem * I'll advertise this patch in my RM newsletter * chris_c = in my opinion, it's a bugfix, but a very long standing one, and, if you want to backport it to 3.8, you'll have to write very clearly how to deal with it in the release note ! (I think it [c|sh]ould wait for 3.10) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6557] biblioitems.totalissues unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Paul Poulain changed: What|Removed |Added Attachment #10561|0 |1 is obsolete|| --- Comment #31 from Paul Poulain --- Created attachment 10562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10562&action=edit Bug 6557 follow-up UNIMARC 942$0 in default french frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6557] biblioitems.totalissues unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 --- Comment #30 from Paul Poulain --- Created attachment 10561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10561&action=edit Bug 6557 follow-up UNIMARC 924$0 in default french frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8318] update StatisticsFields description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318 Nicole C. Engard changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable Version|rel_3_10|rel_3_8 --- Comment #4 from Chris Cormack --- Star ratings are in 3.8.x so pushing to there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8288] showmarc.tt should not include full doc-head-close.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #4 from Chris Cormack --- Bugfix pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Chris Cormack changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #41 from Chris Cormack --- Patch to allow the packages to build. Still needs another followup to make use of the dom config, but at least now the packages can build -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Chris Cormack changed: What|Removed |Added Priority|P5 - low|P1 - high Status|Pushed to Stable|ASSIGNED Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Chris Cormack changed: What|Removed |Added Attachment #8965|0 |1 is obsolete|| Attachment #8966|0 |1 is obsolete|| Attachment #8967|0 |1 is obsolete|| Attachment #8968|0 |1 is obsolete|| Attachment #8969|0 |1 is obsolete|| Attachment #8970|0 |1 is obsolete|| Attachment #8971|0 |1 is obsolete|| Attachment #8972|0 |1 is obsolete|| Attachment #8973|0 |1 is obsolete|| Attachment #8974|0 |1 is obsolete|| Attachment #9798|0 |1 is obsolete|| Attachment #9968|0 |1 is obsolete|| --- Comment #40 from Chris Cormack --- Created attachment 10560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10560&action=edit Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311
--- Comment #5 from Jared Camins-Esakov ---
(In reply to comment #4)
> QA comment:
>
> Why did you put the line
> require C4::Members;
> outside from
> if (!defined($borrowernumber) && defined($user)) {
> ?
>
> The way you made it, C4::Members will be loaded on everypage, that will
> impact performances !
C4::Members was always loaded whenever $user was set. I just moved the require
up so that it was before *both* calls to routines in C4::Members (if you scroll
down about a page, you'll see a call to GetMemberDetails.
> Written:
> if (!defined($borrowernumber) && defined($user)) {
> require C4::Members;
> my $borrower = C4::Members::GetMember(borrowernumber => $user);
> will load the C4::Members only if the getborrowernumber does not return the
> user (which should never happen)
>
> waiting for your feedback, not pushing not marking failed QA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain changed: What|Removed |Added Status|Passed QA |ASSIGNED CC||paul.poul...@biblibre.com Version|master |rel_3_8 Assignee|gmcha...@gmail.com |dpav...@rot13.org --- Comment #11 from Paul Poulain --- Switching back to "assigned", the patch provided has been pushed, other patches welcomed ! Assigning to Dobrica, as you seem to be motivated by this topic ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain changed: What|Removed |Added Attachment #10490|0 |1 is obsolete|| --- Comment #10 from Paul Poulain --- Comment on attachment 10490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490 Bug 8315 - fix 'C4::Output 3.02' errors in Koha This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #9 from Chris Cormack --- This still needs a follow up for all the other version numbers Robin listed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain changed: What|Removed |Added Attachment #10483|0 |1 is obsolete|| --- Comment #8 from Paul Poulain --- Comment on attachment 10483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10483 Bug 8315 - fix 'C4::Output 3.02' errors in Koha Robin, seems you forgot to obsolete the original patch when you uploaded the signed-off one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8321] fix OPACShowBarcode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311
Paul Poulain changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
--- Comment #4 from Paul Poulain ---
QA comment:
Why did you put the line
require C4::Members;
outside from
if (!defined($borrowernumber) && defined($user)) {
?
The way you made it, C4::Members will be loaded on everypage, that will impact
performances !
Written:
if (!defined($borrowernumber) && defined($user)) {
require C4::Members;
my $borrower = C4::Members::GetMember(borrowernumber => $user);
will load the C4::Members only if the getborrowernumber does not return the
user (which should never happen)
waiting for your feedback, not pushing not marking failed QA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #18 from Robin Sheat --- Also, the size calculation logic should probably get moved to template toolkit rather than javascript. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED --- Comment #17 from Robin Sheat --- I've found this causes a regression: the tags no longer display in their correct size, they all appear the same, as the value in the 'title' field was used by javascript to calculate the font-size attribute. I'm hoping to get this fixed in not too long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7869] Correct bad link to item in patron modification log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7869 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Repeating Liz's question, is this still needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 Chris Cormack changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P4 Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz Change sponsored?|Seeking cosponsors |--- --- Comment #3 from Chris Cormack --- Applies cleanly, didn't break zebra, I can't vouch it works right for UNIMARC but it doesn't break anything else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 Chris Cormack changed: What|Removed |Added Attachment #7089|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 10559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10559&action=edit Bug 7421 Add UNIMARC DOM Filter Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 --- Comment #15 from Chris Cormack --- Created attachment 10558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10558&action=edit Bug 7839 : Follow up, fixing copyright -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc Véron changed: What|Removed |Added Attachment #10428|0 |1 is obsolete|| --- Comment #23 from Marc Véron --- Created attachment 10557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10557&action=edit [REBASED] Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference (Rebased to Koha version: 3.09.00.018) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 Chris Cormack changed: What|Removed |Added Attachment #10554|0 |1 is patch|| Attachment #10554|application/octet-stream|text/plain mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Chris Cormack changed: What|Removed |Added Attachment #10555|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 10556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10556&action=edit Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
