[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #129 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #128) Paul/Jonathan, were your tests run over a clean install on a fresh branch or over a branch which was developed on? On a quick perusal of Auth.pm changes, I'm not sure how this step could ever work with the value of $koha39 hard-coded to 3.0900027. Perhaps I'm misunderstanding your test plan? Yikes... when we made the tests, we made some changes to run installer (like adding fake revisions -new and old mechanism-) and, murphy's law, I made a mistake reverting them. The following re-uploaded patches are exactly the same except for reimplementing Reimplementing Marcel's suggestions fixes that check against 3.0900028 instead of 3.0900027 We have found another hidden problem, we will upload another follow-up in the next 2 hours -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8546] New: OPAC Advanced Search Publication date range guide text FAIL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546 Priority: P5 - low Change sponsored?: --- Bug ID: 8546 Assignee: oleon...@myacpl.org Summary: OPAC Advanced Search Publication date range guide text FAIL Severity: trivial Classification: Unclassified OS: All Reporter: m.kirjasto.hailu...@gmail.com Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha Guide text in the advanced search form is incorrect: For example: 1999-2001. You could also use -1987 for everything published before 1987 or 2008- for everything published after 2008. is illogical. The logically and functionally correct way being: For example: 1999-2001. You could also use -1987 for everything published before 1988 or 2008- for everything published after 2007. Reproducing the bug: Search date range 2008- for everything published _after_2008_ and you'll get also books published 2008, not only after 2008. @ http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl This text bug prevails in community's demo runs 3.8, 3.6, 3.2 and master, provided by Bywater, CALYX, Equinox, Libriotech, software.coop http://koha-community.org/demo/ The four TOF demo Opacs on the list. Also in Bywater sandbox OPAC http://catalog.bywatersolutions.com/ EVEN THOUGH text bug has been fixed in Bywater sandbox Intranet (ver.3.09.00.026, whatever that would mean) (login bywater - bywater reqrd): http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl Bug shows in live instances too, e.g. Farmington Koha, http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl Most likely in KOHA 3.10 too. FIX SUGEGSTION, that do not age along the years: like w Bywater format: - PS. All in all, when I patron-eyed Farmington Adv search, I started to miss guide text feature. The advSearch page is so long. It could be shortened. Esp. the Item type list should be made drop-down type and also divided into 2 or more categories: Item types and thematical types. Or newest item types? Now the list doesn't work for, well, anybody. Schratching here my head: some patrons could use this as an itemtype browsing feature. (Well but this is now off-topic already.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8478] Update Ubuntu related files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- *** Bug 8192 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #130 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11235 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11235action=edit Bug 7167: New version for updatedatabase This patch use DataTable, see BUG|BZ 6836 - css/datatables.css - lib/jquery/plugins/jquery.dataTables.min.js - js/datatables.js http://bugs.koha-community.org/show_bug.cgi?id=7167 Bug 7167 follow-up Major changes: * creating database tables for update on the fly, the 1st time the update script is called * version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached * kohaversion check on each page is now useless in Auth.pm, removed dead code * Updated installer: at the end of the process, retrieve all updates and automatically mark them OK, as they're included in installer Minor changes: * adding copyright * adding poddoc * updating a warning, for better clarity * switching from $$var to $var- * small TT glitch fixed in updatedatabase.tt * about.pl now returns the Version systempreference PLUS all the patches that have been applied Bug 7167 follow-up perlcritic numbers display partial apply depending on DEBUG * add use strict to updatedatabase, that is now perlcritic compliant * partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one Display: * in updatedatabase, small spelling changes * in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1) * improve the display of applied numbers on about.pl - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10 - after this patch you have N..N+3 / N+10 * add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #131 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11236 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11236action=edit Bug 7167: Now, we check versions on mainpage.pl and after login Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #132 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11237 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11237action=edit Bug 7167: Improve the update.pl script * Added CLI options to update.pl * Call update.pl from the installer. Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #133 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11238 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11238action=edit Bug 7167: Reimplementing Marcel's suggestions fixes * Fixing the bugguy old version check (that was made against 3.090 instead of 3.0900027 -the last current kohaversion number * in the CLI script, if there is nothing to report, just say it Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #134 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11239 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11239action=edit Bug 7167: Remove check_coherency As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it. Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #135 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11240 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11240action=edit Bug 7167: Changing in .sql parsing We first split on delimiter and then extract comments. You can now put \n for delimiter comments. ex: DELIMITER ; -- this is a comment SELECT * FROM my_table; -- another comment Before this patch, we had to write: DELIMITER ; -- this is a comment; SELECT * FROM my_table; -- another comment; Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #136 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11241 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11241action=edit Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #137 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11242 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11242action=edit Bug 7167: Improve display + factorize get_queries Despite it's size, this patch is dealing with display questions only: * The text comments and queries was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, comments: and queries: is now in the template, making it translatable * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red) * Reordering the column headers for more readability: * Status column is merged with availability, column is after status * Status/availability terms more clear: Not applied instead of unknown, Applied and OK, Applied and failed, Applied and forced are the 3 other statuses * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click Show details, then Get comments, now, Get comments is enough Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #138 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11243 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11243action=edit Bug 7167: FIX typos moving a script to a proper place * renamed availables to available * renamed already_knows to already_applied * fixed FSF copyright headers * removing a use strict because we already had use Modern::Perl * fixed a tiny typo in about.tt * moving update.pl to misc/bin because it's a CLI script Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #139 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11244 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11244action=edit Bug 7167: Add dependency File::Find::Rule Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #141 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 11246
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11246action=edit
Bug 7167 reindentation removing dead code
* The if (! defined $ENV{PERL5LIB}... block was wrongly intented
* The 3 lines running update.pl are useless: the update (new mechanism) is run
from admin/updatedatabase.pl script. This part of install.pl is run only when
you have old style DB revisions.
Summary:
* old mechanism = it's run as previously, by reaching the
installer/install.pl?step=3 page, that applies all revisions
* new mechanism = when you log-in or reach mainpage.pl, you reach
admin/updatedatabase.pl, where you can see what will be run, and run it
Tiny side effect = the check for old mechanism is now done *after*
authentification (thus it's not done on each page call). It means that the user
will have to enter login/password twice :
* first to log-in to Koha
* second to run installer/updatedatabase.pl?step=3
As the old mechanism is deprecated, we can expect this will happend only a few
time in the history of a setup, it's not a big deal.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #140 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 11245
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11245action=edit
Bug 7167: We want to execute non-numeric version with the -all option
Dealing with Marcel comment 100:
Note that the current code around line 52/53 does not
handle that correctly:
Argument \x{74}\x{65}... isn't numeric in numeric ge (=) at
installer/data/mysql/update.pl line 52.
Now, a non-numeric DBRev will be applied if you provide the --all parameter,
without throwing the error
Signed-off-by: Paul Poulain paul.poul...@biblibre.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11222|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11223|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11224|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11225|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11227|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11229|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11231|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11232|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6832] Validation of total budget in neworderempty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- The proposed patch does not apply : fatal: cannot convert from UTF-8utf-8 to UTF-8 Please resubmit this patch well formated. On the way, replace the french commit message ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #142 from Paul Poulain paul.poul...@biblibre.com --- The 12 patches attached does not differ a lot from the 11 attached yesterday: * The Bug 7167: Reimplementing Marcel's suggestions fixes fixes the 3.09.00.028 problem (see comment 129) * The Bug 7167 reindentation removing dead code reindent a block and remove some useless ( bugguy) code I've amended our test plan, so repeating it here: Tests made: • Start from a clean situation (drop the 3 tables created by the new mechanism drop table updatedb_error;drop table updatedb_query;drop table updatedb_report;) • Checked that the old updatedatabase is still working by ∘ adding a 3.09.00.028 update, that is empty ∘ checked that we're redirected and the update is OK • Created a 3.09/sample.sql that contains UPDATE systempreferences SET value='nothing' WHERE variable='NOTHING_TOO'; with a comment test doing nothing ∘ verified that, on mainpage, we're redirected to new updatedatabase ∘ verified that, trying to acces, unidentified, to a page (in circulation), we're redirected to new updatedatabase ∘ going to mode DEBUG=1 in Apache config, confirmed that the button Execute appears. Checked that DEBUG=0 make the link disappearing • Tested the 2 sample files (the .sql.sample and the .pl.sample) by copying them in 3.09/ directory ∘ Checked that Koha displays 2 updates available, let apply both in one click (UPDATE ALL) • Tested that forcing applying a given update (by manually entering the number: /cgi-bin/koha/admin/updatedatabase.pl?op=updateversion=3.09.01.001) result in a message saying it has already been executed • checked that, if you have 2 files with the same content (ie: same md5sum, but not same name), the installer detect it's a duplicate • Created an invalid update file, ∘ Checked that applying it result in a message, with a link to force mark as applied. ∘ Checked that the link mark the DBRev as applied and the updater understand it must not bother • Verified what happen when you have an invalid .pl file that does not even compile ∘ checked that there is an error thrown ∘ checked that the Perl error is reported (if the pl is invalid, it means the patch has not been applied, the librarian is a developer, displaying the Perl error is relevant) ∘ checked that you can't force OK this error = the .pl must be fixed, no reason to be able to force • Verified non numeric behaviour ∘ created a file 3.09/Bug_1234.sql ∘ Tested that it appears first and can be applied ∘ Tested that, once the but has been renamed to a number (ie: it has been pushed), Koha detect it's a duplicate already applied ∘ Possible improvement = if you apply many non-numeric DBRevs because you're testing, they all appear in first place. This can be fixed by removing the entries in tables updatedb_error, updatedb_query, updatedb_report. An improvement could be to have this in the staff interface. For now: ‣ DELETE FROM updatedb_error WHERE version=?; ‣ DELETE FROM updatedb_query WHERE version=?; ‣ DELETE FROM updatedb_report WHERE version=?; • Checked that, in CLI, misc/bin/updatedb.pl --all execute all available DB updates • Checked mix of old and new updatedatabase mechanism: ∘ Applied some new system revisions ∘ Added some lines in installer/data/mysql/updatedatabase.pl, and checked the old versioning system runs • Tested that a full install (drop database / create database / run installer.pl) works well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6832] Validation of total budget in neworderempty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, this patch will apply if you change the patch file and remove one line: Content-Type: text/plain; charset=utf-8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8544] Make RSS icon styleable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11234|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11247 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11247action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8544] Make RSS icon styleable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Plack and database backup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||dpav...@rot13.org --- Comment #2 from Paul Poulain paul.poul...@biblibre.com --- Dobrica, could you sign-off this one pls ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11179|0 |1 is obsolete|| --- Comment #12 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11248 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11248action=edit Bug 8486 - Follow up making the tests db independent Signed-off-by: Paul Poulain paul.poul...@biblibre.com Makes the test db independant by specifying the date format. Thus, there is no call to -preference() that retrieve a systempreference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- Patch signed off. Will also pass QA and push in one go, trivial valid fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- Follow-up making the tests db independant pushed on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- This patch fixes the reported issue. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #143 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #126) Hi Paul and Jonathan, I know that you have put a lot of work and thought into this, but it is a big change in a critical area. I would like to see this pass QA first before being pushed. 1 day (tomorrow, if you want to push on Thursday) seems a very short amount of time for the QA team or for anyone who wants to follow your test plan. If we deviate from the standard workflow, please check with the community or dev list first. Note also that many hours have been spent on QA+ing several versions of this development, but it never reached the final status yet (although I certainly hope that it will!). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #144 from M. de Rooy m.de.r...@rijksmuseum.nl --- Just from glancing through some code: +# check if you're uptodate, and if you're not, head to updater +my $koha39 =~ 3.090; Should this be an assignment? Note that I also corrected this before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #145 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #144) Just from glancing through some code: +# check if you're uptodate, and if you're not, head to updater +my $koha39 =~ 3.090; Should this be an assignment? Note that I also corrected this before. Maybe too fast. Seems to be corrected by another patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #36 from Paul Poulain paul.poul...@biblibre.com --- QA comment: tiny follow-up to please jenkins, passed QA (but I agree it's a workaround, valid because solr is experimental) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Kyle, I can't reproduce the issue without your patch. I am under the impression, your patch is useless: mysql SELECT CAST( P13000 AS SIGNED ); ++ | CAST( P13000 AS SIGNED ) | ++ | 0 | ++ Indeed, a non-numeric cast as SIGNED is equal to 0 Maybe I missed something ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- However, mysql raises a warning with the previous query: | Warning | 1292 | Truncated incorrect INTEGER value: 'P13000' | Which it does not exist with your patch. Then I will sign off your patch :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11221|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11249 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11249action=edit Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Removes a warning from mysql: Truncated incorrect INTEGER value: 'P13000' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #147 from Jared Camins-Esakov jcam...@cpbibliography.com --- I had a thought on this. Would it be possible to change the code to figure out the highest version in updatedatabase programmatically rather than hardcoding it in? It seems to me that pushing it when you get back would be a lot easier if you didn't have to edit the patch on your return and/or change the database update methods for all patches that have passed QA by then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #12) switching to english, I get a very nasty: One must read switching to french, I get a very nasty:...3 In english, everything is OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] New: Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Priority: P5 - low Change sponsored?: --- Bug ID: 8547 Assignee: oleon...@myacpl.org Summary: Enabling star ratings causes javascript errors that cause IE to have a boo boo Severity: enhancement Classification: Unclassified OS: All Reporter: ro...@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha I think this is due to a trailing comma in a list. Real browser are OK with it, but IE is dumb. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11145|0 |1 is obsolete|| --- Comment #51 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 11145 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11145 [SIGNED-OFF] Bug 7143: Updating history and about file This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8548] New: overdue report not sortable by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Priority: P5 - low Change sponsored?: --- Bug ID: 8548 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: overdue report not sortable by call number Severity: normal Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The overdue report (cgi-bin/koha/circ/overdue.pl) has sort options in the filters but call number isn't there and it does appear on the report so it should be a column you can sort on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I guess that proves that the problem still exists with TT :( So we shouldn't change the test and fix the templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #148 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #147) I had a thought on this. Would it be possible to change the code to figure out the highest version in updatedatabase programmatically rather than hardcoding it in? It seems to me that pushing it when you get back would be a lot easier if you didn't have to edit the patch on your return and/or change the database update methods for all patches that have passed QA by then. That's what we'd like to do, but failed to find how. If you've an idea... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #6701|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 11250 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11250action=edit Bug 6151: Add AllowReturnToBranch system preference In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn, this patch changes the mechanism by which the question can I return this material here? is answered. Before, the conditions were if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item, then no, otherwise yes. Now, the question is answered by consulting CanBookBeReturned (new subroutine) New system preference: AllowReturnToBranch Possible values: - anywhere (default for new installs, and for existing systems with IndependantBranches turned off) - homebranch - holdingbranch (which is also the issuing branch in all normal circumstances) - homeorholdingbranch (default for existing systems with IndependantBranches turned on) New subroutine: CanBookBeReturned Input: $item hash (from GetItems), and $branchcode Output: 0 or 1 to indicate allowed or not, and an optional message if not allowed. Message is the 'correct' branchcode to return the material to To Test: 1. Install patch and new syspref 2. Check that default value of the preference: - if IndependantBranches was OFF at install time, should be 'anywhere' - if IndependantBranches was ON at install time, should be 'homeorholdingbranch' Case: 'anywhere' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should be successful 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B and Library C Case: 'homebranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to Library A should be successful 4. Repeat step 3 with Library B and Library C. Both should FAIL (returning message to return at A) Case: 'holdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should FAIL (returning message to return at B) 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at B) Case: 'homeorholdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at A) Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #149 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #148) That's what we'd like to do, but failed to find how. If you've an idea... Wouldn't just searching for the last occurrence of /^\$DBversion =/ and then evaluating that line do it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #199 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #195) Created attachment 11186 [details] Patch of 'ItemType.t' - added a few tests Hi Bart, just for information = your git config is not correct. Git says that submit patches with a mail address of : From: Bart Jorgensen bartjorgensen@ubuntu I suspect it's not your real mail address ;-) Check here to fix it: http://wiki.koha-community.org/wiki/Version_Control_Using_Git#Fill_some_parameters Could you resubmit with a valid mail address please ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #1 from Robin Sheat ro...@catalyst.net.nz --- Seeing this issue seems to be a bit hit and miss, I haven't worked out the combination of parameters that causes it, just that sometimes it'll happen and sometimes it won't (even with the same browser.) I suspect it's to do with the order that certain ajax loads take place relative to JS rendering. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #2 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 11251 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11251action=edit Bug 8547 - JS error in star ratings breaks IE Writing code with best practices in mind breaks IE. Thanks Internet Explorer. Now go DiaF. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #10741|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11252 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11252action=edit Bug 8405 : add IntranetBiblioDefaultView and BiblioDefaultView in XSLT.pm Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #29 from Paul Poulain paul.poul...@biblibre.com --- follow-up pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #11 from koala programm...@tyndale.cam.ac.uk --- I have simply created a html and php page that speaks with the db. It would have been better if it was in perl and in the koha package, but I need to find some time to get more used with the koha implementation. Regardless, if you'd like, I could share the info here, i.e. the html and php pages. Cheers -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6617] table of contents not printing right if entered right
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |jcam...@cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #3 from Robin Sheat ro...@catalyst.net.nz --- This patch is based on a hunch of what the issue is and is still waiting for someone who has IE to test it for me, but if anyone else is interested, here's what it looks like when it's going bad: http://i.imgur.com/Jhc3z.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #11028|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11253action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, Cooking has the alternate form Cookery, if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for Cookery you get the record you just modified Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Rebased on master 1 August 2012 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #10724|0 |1 is obsolete|| --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11254 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11254action=edit Bug 8332: Add relationships to auth_finder for authority links In addition to the work in bug 8207 that enables auth_finder use, it would be very useful when creating authorities to have the auth_finder plugin automatically fill out the relationship information in $w (in MARC21). To test (note that you must either apply the patch for bug 8207 or manually add a thesaurus to a 5xx linking field in one of the authority type frameworks): 1. Create a new authority record. 2. Go to the 5xx tab. 3. Click the authority control plugin ellipsis. 4. Do a search for an authority. 5. Select a relationship type. 6. Note that after you choose an authority, that the $w control field is automatically populated with the relationship type. Signed-off-by: Frédéric Demians f.demi...@tamil.fr After applying patch for bug 8207, I had been able to follow the test plan step by step, and get the expected result. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Rebased on master 1 August 2012 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Assignee|frede...@tamil.fr |jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Problem is in routine text_replace_tag (tmpl_process3.pl). I don't know how we can fix it :-/ I abandon this bug (for now...) and will submit a patch for Bug 8385 ;-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- OK, I understood the origin of my comment 6. I was wrong, everything is OK. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #150 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to comment #149) (In reply to comment #148) That's what we'd like to do, but failed to find how. If you've an idea... Wouldn't just searching for the last occurrence of /^\$DBversion =/ and then evaluating that line do it? I think this is a great idea if it can be implemented. Hardcoding-- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #151 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to comment #146) (In reply to comment #143) (In reply to comment #126) Hi Paul and Jonathan, I know that you have put a lot of work and thought into this, but it is a big change in a critical area. I would like to see this pass QA first before being pushed. 1 day (tomorrow, if you want to push on Thursday) seems a very short amount of time for the QA team or for anyone who wants to follow your test plan. If we deviate from the standard workflow, please check with the community or dev list first. Note also that many hours have been spent on QA+ing several versions of this development, but it never reached the final status yet (although I certainly hope that it will!). As I've announced already, i'll be afk for 3 weeks, on friday. passed QA or not, I think/feel it's unwise to push such a patch just before leaving. If something goes wrong, everybody will be scared (including me !) So I won't push this patch before coming back from holiday. I will also be afk until Monday beginning tomorrow, so I will not be able to continue testing and sign-off until then. I'd really like to be able to go through this test plan completely as well as read through the code another time before signing off. Paul, I'll touch base with you Monday. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||mag...@enger.priv.no Version|master |rel_3_10 --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed, does nothing for UNIMARC, as expected Added Magnus to this bug = Magnus, this patch changes something when upgrading a NORMARC setup. OTOH, it does not change the default NORMARC frameworks. I feel there's a follow-up for NORMARC that could be useful ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #26) I see that this report lost its signoff. Could you clarify, mtj? IMO it is still at signed off and I will continue with this report soon. No response: resetting status to Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #11220|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 11255 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11255action=edit Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3462] Link see alsos in authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #11147|0 |1 is obsolete|| --- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11256 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11256action=edit Bug 3462: Links in authorities should be hyperlinks Make see also links in both the OPAC and authority module search results into hyperlinks and not just textual strings. To test: 1. Do a search for an authority that will bring up a heading with a see also reference in the staff client and the OPAC. 2. Confirm that the see also references listed in the search results are now hyperlinks, which work. Bug 3462: quiet warn Quiets an unnecessary warning about an uninitialized value. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Patch works nicely and is a great improvement. Tests: - Checked links for existing and non existing see alsos give correct search results - Verified links show up for all see alsos in a result list - Verified links are properly linked with the correct names - Checked logs don't show errors Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Rebased 26 July 2012 Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Rebased on master 1 August 2012 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Component|OPAC|Browser compatibility --- Comment #4 from Owen Leonard oleon...@myacpl.org --- For what it's worth, I don't see this problem in IE9 on Windows 7. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10916|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11257 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11257action=edit Bug 8385: Dirty patch to make tt_valid.t happy A problem in routine text_replace_tag (tmpl_process3.pl) have to be fixed to prevent this kind of dirty patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Bug 8385 depends on bug 8407, which changed state. Bug 8407 Summary: xt/tt_valid.t is too strict http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #10901|0 |1 is obsolete|| --- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11259 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11259action=edit Bug 7475: Teach matching rules to handle authorities * Add the code necessary to handle authorities with matching rules and import batches. * Update all the scripts that use the matcher and import batch code to use the new API. * Add authority records to the matching rules interface in the staff client. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis elli...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8546] Error in description of OPAC Advanced Search Publication date range search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|OPAC Advanced Search|Error in description of |Publication date range |OPAC Advanced Search |guide text FAIL |Publication date range ||search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #10902|0 |1 is obsolete|| --- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 11260 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11260action=edit Bug 2060: Update command line MARC import scripts Expose authority import functionality to the command line import scripts, and rename them from commit_biblios_file.pl and stage_biblios_file.pl to commit_file.pl and stage_file.pl. To test (note that these instructions assume you have a MARC21 installation and are using the provided sample file): 1. Find a file of authorities (a sample file with MARC21 authorities is attached to bug 7475) and download it to your server 2. Stage the file using the following command (replace filename with the name of the file you saved in step 1): misc/stage_file.pl --file filename --authorities 3. Note the batch number the script assigns to your batch 4. Commit the records using the following command (replace batchnumber with the batch number you made note of in step 3): misc/commit_file.pl --batch-number batchnumber 5. Index the authorities Zebraqueue (or wait) 6. Confirm that the new authorities appear. 7. Create a matching rule with the following settings: Code: AUTHTEST Description: Personal name main entry Match threshold: 999 Record type: Authority record Search index: Heading-main Score: 1000 Tag: 100 Subfields: a Offset: 0 Length: 0 (note the ID of this matching rule) 8. Stage the authority file again, this time using the following command: misc/stage_file.pl --file filename --authorities \ --match matchingrule 7. Revert the import with the following command: misc/commit_file.pl --batch-number batchnumber --revert 8. Index the authorities Zebraqueue (or wait) 9. Confirm that the records have been removed 10. Import an authority record with the Stage MARC/Manage staged MARC tools in exactly the way you would for a bibliographic record, but choose Authority instead of Bibliographic for the record type. Signed-off-by: Elliott Davis elli...@bywatersolutions.com Testing plan delivers as it should. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Simple patch, adds 2 sysprefs for xslts. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I was testing IE 8 on Windows 7 and saw it sometimes. Most of the time it happened after closing the browser completely and going to the detail page directly following a link from my bookmarks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #31 from Paul Poulain paul.poul...@biblibre.com --- QA comment: small follow-up required to have the feature working. passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7955] Statistics tab in patron module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- QA Comment: * Owen/Kyle, I need a confirmation: is the upgrade - * jQuery UI CSS Framework 1.8.20 + * jQuery UI CSS Framework 1.8.22 needed, why ? are you sure it's harmless ? * If you don't use hourly loans, is it possible not to have the hour/minute picker ? (not sure) Other than this, nothing against a passed QA status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8532] Old/iffy data causes error checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11216|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11261 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11261action=edit Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com I replace return undef with just return to pass perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8532] Old/iffy data causes error checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Paul, I think at the moment we don't have a system prefernce for hourly loans, so to not see the minutes the system would have to check the circulation rules? I would like it a bit better too, if it possible to easily differentiate between loans in days and hourly loans. For example I think 'normal' loans shouldn't display the minute part, as it will probably be confusing to some libraries. But probably way out of scope for this bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #18 from Paul Poulain paul.poul...@biblibre.com --- QA comment: running this script under plack, on the web interface does not work at all. I get a nasty: An Error Occurred 500 Internal Server Error In the log, I can see: Variable $backupdir is not available at /home/paul/koha.dev/koha-community/tools/export.pl line 452. Unknown option: port Unknown option: i Unknown option: i Unknown option: e Unknown option: reload Trying to reload the page result in CPU being 100% used, Firefox waiting for a long long time, There is no problem in CGI mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Corinne HAYET corinne.ha...@bulac.fr changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||corinne.ha...@bulac.fr --- Comment #2 from Corinne HAYET corinne.ha...@bulac.fr --- ISSN and Bookseller search don't work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #19 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #18) QA comment: running this script under plack, on the web interface does not work at all. I get a nasty: An Error Occurred 500 Internal Server Error In the log, I can see: Variable $backupdir is not available at /home/paul/koha.dev/koha-community/tools/export.pl line 452. Unknown option: port Unknown option: i Unknown option: i Unknown option: e Unknown option: reload Trying to reload the page result in CPU being 100% used, Firefox waiting for a long long time, There is no problem in CGI mode There is a patch to fix this on another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #3 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Corinne HAYET corinne.ha...@bulac.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10433|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11263 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11263action=edit Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Corinne HAYET corinne.ha...@bulac.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Corinne HAYET corinne.ha...@bulac.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #11263|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5357] Subscription search and displays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 11264 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11264action=edit Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET corinne.ha...@bulac.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
