[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

--- Comment #221 from Bart Jorgensen  ---
Created attachment 11633
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11633&action=edit
Added unit tests to 'Installer_perlmodules'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8650] running misc/batchRebuildBiblioTables.pl messes up tables and creates duplicates

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8650

Elliott Davis  changed:

   What|Removed |Added

 CC||elli...@bywatersolutions.co
   ||m

--- Comment #3 from Elliott Davis  ---
Geanina,

I think probably the quickest solution would be to restore those tables from a
backup if you have one.  Depending on how long this has been a problem you may
consider just restoring the whole database since it would be quicker than
extracting the tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8650] running misc/batchRebuildBiblioTables.pl messes up tables and creates duplicates

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8650

--- Comment #2 from Chris Cormack  ---
Geanina

When you look at that order, do both biblios have the same biblionumber?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8650] running misc/batchRebuildBiblioTables.pl messes up tables and creates duplicates

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8650

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack  ---
Hmmm

 (e.g., Title or Local-Number) NOTE: If you change this value you must ask your
administrator to run misc/batchRebuildBiblioTables.pl. 

This note is next to the link field, not the Koha link field.

The rebuild is for if you change the link, not the Koha link field. 

I'm not sure what it will have done in your case :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8650] New: running misc/batchRebuildBiblioTables.pl messes up tables and creates duplicates

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8650

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8650
  Assignee: gmcha...@gmail.com
   Summary: running misc/batchRebuildBiblioTables.pl messes up
tables and creates duplicates
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: gba...@uttyler.edu
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Command-line Utilities
   Product: Koha

Created attachment 11632
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11632&action=edit
Screenshot of duplicate order

The other day we added a new framework. 

Under MARC frameworks › CML framework structure › Tag 005 subfield structure ›
Edit subfields constraints, we changed the Koha link field in tag 005 to
biblio.timestamp. There is a note that says this:

NOTE: If you change this value you must ask your administrator to run
misc/batchRebuildBiblioTables.pl.

Therefore, last night we ran misc/batchRebuildBiblioTables.pl and this morning
we noticed that all our tables are messed up. We noticed duplicate orders in
Acquisitions, duplicate serials entries as well as duplicate biblios. 

We would appreciate any help with this issue. 

Thanks,

Geanina

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8649] C4::Search needs a unit test

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649

Jared Camins-Esakov  changed:

   What|Removed |Added

 Depends on||8648

--- Comment #1 from Jared Camins-Esakov  ---
Please sign off the patch in the search_t branch of my GitHub repo:
https://github.com/jcamins/koha/tree/search_t

I tried to attach the patch but it is too large.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8648] searchResults uses SQL query rather than GetMarcFromKohaField

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8648

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||8649

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

wajasu  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||matted-34...@mypacks.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

--- Comment #7 from wajasu  ---
Created attachment 11631
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11631&action=edit
POSTPATCH acquisitions_receiveorder_with filter_withoutReceiveCancel.png

After applying the patch, I could not see the Receive/Cancel link to try to
Cancel.  I wasn't sure if this is what you wanted, so I attached a POSTPATH
image of what I see. Maybe a clearer test plan, or a further fix is needed.

wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

--- Comment #6 from wajasu  ---
Created attachment 11630
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11630&action=edit
PREPATCH acquisitions_recieveorder_with filter_withReceiveCancel.png

I attempted a test, but to clarify where this applies, I attached this PREPATCH
image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8649] C4::Search needs a unit test

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Jared Camins-Esakov  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8649

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8649] C4::Search needs a unit test

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649

Jared Camins-Esakov  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5327

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8649] New: C4::Search needs a unit test

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8649
  Assignee: jcam...@cpbibliography.com
   Summary: C4::Search needs a unit test
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Test Suite
   Product: Koha

Due to the size of the patch, it seems better to put this test on a separate
bug than 5327 where other unit tests for C4 are going.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8648] searchResults uses SQL query rather than GetMarcFromKohaField

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8648

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 11629
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11629&action=edit
Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Around line 1470-something:

my $sth =
$dbh->prepare(
"SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE
'items.itemnumber'"
);
$sth->execute;

This patch replaces that with a call to GetMarcFromKohaField.

To test:
1) Apply patch.
2) Do a search that returns both available and unavailable items.
   You'll know if the patch isn't working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8648] searchResults uses SQL query rather than GetMarcFromKohaField

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8648

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8647] Modified quickslip only prints from Checkout tab

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8647

Jorge de Cardenas  changed:

   What|Removed |Added

 CC||jd...@smfpl.org

--- Comment #1 from Jorge de Cardenas  ---
The behavior is because on the 'Check Out' tab circ-toolbar.inc is loaded, on
the other tabs members-toolbar.inc is loaded instead.

Circ-toolbar.inc has:
var slip_re = /slip/;
function printx_window(print_type) {
  var handler = print_type.match(slip_re) ? "printslip" : "moremember";
  window.open("/cgi-bin/koha/members/" + handler + ".pl?borrowernumber=[%
borrowernumber %]&print=" + print_type, "printwindow");
  return false;
}

and members-toolbar.inc has:

function printx_window(print_type) {
  window.open("/cgi-bin/koha/members/moremember.pl?borrowernumber=[%
borrowernumber %]&print=" + print_type, "printwindow");
  return false;
}

copying those lines to members-toolbar.inc fixes the problem but I don't know
if it will introduce other unwanted behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] syntax not working on overdues anymore

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

wajasu  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||matted-34...@mypacks.net

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8607] overdue_notices is broken

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607

--- Comment #4 from wajasu  ---
I investigated the reason for the Fine: USD instead of Fine $0.00

I fixed that in Bug 8378, as I found that existed.

Please refer to that patches comments for details.

When this patch gets applied, one should then apply the Bug 8378 patch
as the setup is similiar and it will save time.

Instead of a followup patch here, I am just refering to Bug 8378
as the followup.

wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] syntax not working on overdues anymore

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

--- Comment #1 from wajasu  ---
Created attachment 11628
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11628&action=edit
0001-Bug-8378-fine-syntax-not-working-on-overdues-anymore

This patch returns the behavior for handling the USD tag in
overdue_notices.pl

It seems this behavior got lost during other changes.

At the time of writing this patch, I needed another patch that I had signed off
on, so you will need
to apply SIGNED-OFF-Bug-8607-FIX-overdues_notices-script-date.patch first to
get overdue_notice.pl working.
That patch fixed substitution of a date variable that had incorrect quotes, and
enables overdues to be returned.

Test Plan:
1) I added a student patron  (be sure overdues notices can be received with the
correct patron type)
2) I checked out a book  (in my case i checked out 2 because I wanted to see if
multiple were supported)
3) As mysql -uroot -p  koha   (connect to your test database)
> select * from borrowers;( to find the borrowernumber for your test patron)
> select * from issues;   ( to see the checkout outs. )
> update issues set date_due='2012-07-01 23:59:00' where borrowernumber=55;  ( 
> set the date_due to make the book overdue)
4) login as the patron and see that the checkouts are overdue ( check
circulation rules or sysprefs if needed )
5) I applied SIGNED-OFF-Bug-8607-FIX-overdues_notices-script-date.patch   (if
you are on master around 2012-08-15)
6) As root in dev environment kohaclone:
misc/cronjobs/overdue_notices.pl -n  (I got no amount after the Fine:
with the currency format code)
...
The following item(s) is/are currently overdue:

"Paul and his theology " by , 227/.06, Barcode: 111 Fine: USD
"Apostolic history and the Gospel" by , , Barcode: 333 Fine: USD
...
7) I applied Bug-8378-fine-syntax-not-working-on-overdues-anymore.patch   (what
we are really testing)
8) As root in dev environment kohaclone: (be sure the patched 
C4/Letters.pm is in /usr/share/koha/lib if you use an std install)
misc/cronjobs/overdue_notices.pl -n  (I got the amount ==> Fine: $0.00
)
...
The following item(s) is/are currently overdue:

"Paul and his theology " by , 227/.06, Barcode: 111 Fine: $0.00
"Apostolic history and the Gospel" by , , Barcode: 333 Fine: $0.00
...

Notes:
I would apply this patch after Bug8607 to save time on setup steps, and start
from step 6)

How was it fixed:
In overdue_notices.pl the parse_letter routine needed the 'letter' in params to
get the  tag and
the currency format.  It replaced the  tag with <>, which
should have been <>.
The routine also iterated over the items to format and pushed for use in
GetPreparedLetter, but that routine
queried the database again for the letter template, and thus would see the
 tag and not <>.
So I had to factor out GetLetter from GetPreparedLetter, keeping
GetPreparedLetter the same behavior, since its
called in many places (Reserves.pm, etc).  I also added a GetProcessedLetter to
Letters.pm that did the same thing
as GetPreparedLetter, but accepted a 'letter' param, so it doesn't query the
database. I edited overdue_notice.pl
to GetLetter, earlier in the code so its retrieved less often, and supply it to
parse_letter which originally
wanted to do its magic.

wajasu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8648] New: searchResults uses SQL query rather than GetMarcFromKohaField

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8648

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8648
  Assignee: jcam...@cpbibliography.com
   Summary: searchResults uses SQL query rather than
GetMarcFromKohaField
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Architecture, internals, and plumbing
   Product: Koha

Around line 1470-something:

my $sth =
  $dbh->prepare(
"SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE
'items.itemnumber'"
  );
$sth->execute;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8647] New: Modified quickslip only prints from Checkout tab

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8647

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8647
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: Modified quickslip only prints from Checkout tab
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: fred.pie...@smfpl.org
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Patrons
   Product: Koha

Koha tools allows us to define a user-specific print slip, quick slip, and
other slips. These user-defined print slips work fine from the patron's circ
tab, accessed from the "Check Out" button on the patron screen, and selecting
the pull-down "Print" menu.

However the Details, Fines, and other left-side tabs do not use the
user-defined print slip - instead they use the old method's moremember.pl
script. Although the pull-down "Print" menu looks exactly the same, the code on
the member page and borrower account page is inconsistent with the code on the
circ page, and does not print the user-defined fields.

For visual consistency and full functionality the pull-down "Print" menu should
be consistent across all Patron buttons/tabs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #59 from Marc Balmer  ---
(Mit Bezug zu comment 58)
> Anhang 11550 angelegt (attachment 11550 [details])
> [SIGNED-OFF] BUG 7621 [ENH] Circulation: Match age restriction of title with
> borrower's age without using categories
> 
> Signed-off-by: Chris Cormack 
> 
> New version implementing Paul's advice.
> See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion
> 
> Signed-off-by: Jonathan Druart 
> fix updatedatabase.pl
> 
> New fix updatedatabase.pl to apply to current master by Marc Veron
> ve...@veron.ch

The wiki page is actually at
http://wiki.koha-community.org/wiki/Age_restriction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] Certain search terms cause browser "script taking too long" error

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

Robin Sheat  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] New: Certain search terms cause browser "script taking too long" error

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8646
CC: gmcha...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: Certain search terms cause browser "script taking too
long" error
  Severity: minor
Classification: Unclassified
OS: All
  Reporter: ro...@catalyst.net.nz
  Hardware: All
Status: NEW
   Version: master
 Component: Staff Client
   Product: Koha

Some search terms, particularly those with space characters and similar
non-alpha things at the end, can cause the javascript highlighter to go into an
infinite loop which causes an error in the browser.

Search queries such as:
http://koha-intra/cgi-bin/koha/catalogue/search.pl?kw=idx&q=ti:book%20
reproduce this.

Curiously, the OPAC is unaffected by this, however it has similar code
processes that mean it may be possible for this to happen there too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #13 from Owen Leonard  ---
I'm going to mark this as "signed off" so that the first couple of patches can
go through QA. If anyone wants to argue for the inclusion of one of the
attached CSS revisions they can comment and add their signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Assignee|gmcha...@gmail.com  |pelletiermax...@gmail.com

--- Comment #3 from Owen Leonard  ---
This patch clearly does no harm, so I will trust that it does good. Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard  changed:

   What|Removed |Added

  Attachment #11623|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 11627
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11627&action=edit
[SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations

Respect coding guidelines for translations in javascript by replacing ' by ".
Fixes the page for the french translation (that contains a ').
Sponsored by the CCSR.

http://bugs.koha-community.org/show_bug.cgi?id=8645
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8498] can't specify an hour when specifying due date

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498

--- Comment #14 from Owen Leonard  ---
FYI I have added (In reply to comment #3)

> Sounds OK/fair to me. What about adding a wiki page (linked to coding
> guidelines -maybe not coding guidelines page itself) about those rules ?

I updated this section with the information:

http://wiki.koha-community.org/wiki/Coding_Guidelines#Using_jQueryUI_widgets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

--- Comment #2 from Owen Leonard  ---
Created attachment 11626
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11626&action=edit
Proposed fix for the OPAC

Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the OPAC. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in the OPAC to confirm continued functinality: tabs
and datepickers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

Owen Leonard  changed:

   What|Removed |Added

  Attachment #11625|Proposed fix|Proposed fix for the staff
description||client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8620] Barcode searching not working correctly

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620

--- Comment #3 from Jorge de Cardenas  ---
This is not a good fix but I replaced:

if(not $index){
   $index = 'kw';
}

in Search.pm (around line 1182) with:

if(not $index){
if($operand =~ m/[0-9]{14}/){
$index = 'bc';
}else{
 $index = 'kw';
}
}

Our barcodes are 14 digits long, it tests for 14 digits and sets the index to
'bc' instead of 'kw' when no index was submitted. There is probably a way to
fix this through the zebra configuration files but I don't understand them well
enough to try it.

Jorge

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

--- Comment #1 from Owen Leonard  ---
Created attachment 11625
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11625&action=edit
Proposed fix

Bug 8644 [staff client] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the staff client. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in Koha to confirm continued functinality: tabs,
autocomplete, and datepickers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6494] opacmysummaryhtml on reading history

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6494

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8510] Selecting a framework on import does not modify leader or 008 correctly

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8510

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8620] Barcode searching not working correctly

2012-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #2 from Martin Renvoize  ---
We're also having this issue in a few places.  It appears to be direclty
related to DOM indexing.

Martin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/