[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #16 from wajasu  ---
Here is an article that helps one see how perl has things internally encoded.
Just for future reference.  
http://blog.twoshortplanks.com/2009/12/02/under-the-hood/
But I'm sure you experts know about this sort of stuff.

I think its worth investigating the truetype option.  Although I agree that
some web font css label solution or such may be the worth pursuing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743

Doug Kingston  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Doug Kingston  ---
I have tested this and completely fixes the problem described.  Tested on a
3.08.4 system.  Patch applied cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766

--- Comment #1 from David Cook  ---
(In reply to comment #0)
> OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt
> 
> It also shows up in many Poodle files. 
> 
> Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but
> it's still probably a good idea to have it spelled correctly.

Pootle :P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6975

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6975] OPACBaseURL called as OPACBaseurl in many templates

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6975

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8766

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8766] New: OPACBaseURL still called as OPACBaseurl in many files

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8766
  Assignee: oleon...@myacpl.org
   Summary: OPACBaseURL still called as OPACBaseurl in many files
  Severity: minor
Classification: Unclassified
OS: All
  Reporter: dc...@prosentient.com.au
  Hardware: All
Status: NEW
   Version: master
 Component: Templates
   Product: Koha

OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt

It also shows up in many Poodle files. 

Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but it's
still probably a good idea to have it spelled correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty.

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty.

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454

David Cook  changed:

   What|Removed |Added

  Attachment #11499|0   |1
is obsolete||

--- Comment #7 from David Cook  ---
Created attachment 12181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12181&action=edit
Bug 8454 - Show pull list on load. Otherwise, it looks like the pull list is
empty - Amended

Ahh, I see your logic now. 

Here's an amended patch that uses your idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #44 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Created attachment 12180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12180&action=edit
Bug 8765 - Add series title to intranet search results

I suppose this could be referred to as an enhancement, but it seems more like a
bug to have the series volume but not the series title. 

If we don't want to include the series title in the intranet search results
(after all, it's not included in the opac search results), I would propose
removing the series volume from the intranet search results, as it is
essentially meaningless without the context of the series title.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] New: Add series title to intranet search results

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8765
  Assignee: oleon...@myacpl.org
   Summary: Add series title to intranet search results
  Severity: minor
Classification: Unclassified
OS: All
  Reporter: dc...@prosentient.com.au
  Hardware: All
Status: NEW
   Version: master
 Component: Templates
   Product: Koha

Currently, the series volume is shown in the intranet search results completely
on its own without the series title. 

It's also prefaced with a comma that currently creates 2 commas in a row and
will provide double punctuation when series title is included (provided that
people are including their punctuation when they catalogue as they should).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Created attachment 12179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12179&action=edit
Bug 8764 - Template change "Authors" to "Additional authors" in OPAC

Super simple template change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8708] RSS feed for new comments is broken

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #11 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8764] New: Template change "Authors" to "Additional authors" in OPAC

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8764
  Assignee: oleon...@myacpl.org
   Summary: Template change "Authors" to "Additional authors" in
OPAC
  Severity: trivial
Classification: Unclassified
OS: All
  Reporter: dc...@prosentient.com.au
  Hardware: All
Status: NEW
   Version: master
 Component: Templates
   Product: Koha

The OPAC is incorrectly labelling Additional authors as Authors. By changing
this label to "Additional authors", the OPAC will match the Intranet and order
will be restored to the force.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8763] default messaging not saving if you pick digests

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8763

--- Comment #1 from Nicole C. Engard  ---
Btw this happens in 3.8.3 and master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8763] New: default messaging not saving if you pick digests

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8763

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8763
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: default messaging not saving if you pick digests
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
   URL: cgi-bin/koha/admin/categorie.pl
  Hardware: All
Status: NEW
   Version: master
 Component: Patrons
   Product: Koha

when setting default messaging for patron categories it doesn't save if you
choose digest, you have to choose email and digest, but there is no error to
tell you that's what's happening. also i think if you select email and digest
you get 2 messages instead of just the digest, but that might be another bug.

Either way we need to make it clear why the messaging preference wasn't saved
or add a note that both email and digest have to be checked for it to save.

See: http://screencast.com/t/gA9v3qmYas

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8473] Different favicon in the staff client only shows in the english templates

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8473

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Owen Leonard  ---
I still can't reproduce this. If you're still having this problem and can
provide more details, please re-open.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8715] Receiving all serials for a year

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715

--- Comment #3 from Owen Leonard  ---
Created attachment 12178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12178&action=edit
Follow-up: Markup changes to improve consistency with other interfaces

Follow-up: For consistency, I would prefer to have the column of checkboxes at
the beginning of the table and the select/clear links above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Colin Campbell  changed:

   What|Removed |Added

  Attachment #11330|0   |1
is obsolete||

--- Comment #13 from Colin Campbell  ---
Created attachment 12177
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12177&action=edit
Patch rebased against current head

Rebased to incorporate changes introduced by the opachtmlsummary code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #59 from Chris Cormack  ---
DBD::mysql::db do failed: Can't create table 'koha.transport_cost' (errno: 150)
at ./installer/data/mysql/updatedatabase.pl line 5703.

(150 is foreign key constraints)

This might be specific to the jenkins machine, but just noting why it didnt
update properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8715] Receiving all serials for a year

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8715] Receiving all serials for a year

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715

Owen Leonard  changed:

   What|Removed |Added

  Attachment #11945|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 12176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12176&action=edit
[SIGNED-OFF] Bug 8715: Receive all serials for a year.

This patch adds
- 2 links in the table header (select all and clear all).
- Datatable on these tables

Test plan:
Try to select all serials for a year and receive them.
Test there is no regression (ergonomic) on this page

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8762] New: Authority links (6xx $9) should not be exported by default

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8762

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8762
  Assignee: gmcha...@gmail.com
   Summary: Authority links (6xx $9) should not be exported by
default
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Tools
   Product: Koha

Similar to the "Export standard MARC only" option added by bug 7345, the export
data tool should at the very least have the option to not export non-standard
fields (in particular, authority links).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
Version|rel_3_8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508

Owen Leonard  changed:

   What|Removed |Added

  Attachment #12122|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 12175
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12175&action=edit
[SIGNED-OFF] Bug 8508 - Holds to Pull : Library dropdown options are
erroneously concatenated by br tags

This patch introduces a new javascript function that breaks apart option
strings that are erroneously concatenated by br tags. The split strings
are then checked against non-concatenated option strings, and pushed into
the option array if there is no duplication.

This function is nestled into the JQuery datatable function for populating
the drop-down menu.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

--- Comment #50 from Paul Poulain  ---
Created attachment 12174
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12174&action=edit
Qote Of The day Breaking display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

--- Comment #49 from Paul Poulain  ---
OK, it's much better when you add opac.css to opacusercss sypref, but still not
perfect (screenshot coming)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #18 from Kyle M Hall  ---
> So, 2 options:
>   * populate ccode in Accounts.pm, when there is an item
>   * UPDATE by discarding statistics.type='payment' or 'writeoff' (maybe
> there are other values, not 100% sure)
> 
> Please choose and resubmit. I suggest you squash the 4 current patches, and
> add a follow-up for this QA question

Since a payment may be for multiple items, I don't think we should add a ccode
for payments, so I have chosen the latter option.

I have also squashed the earlier patches per your suggestion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118

--- Comment #17 from Kyle M Hall  ---
Created attachment 12173
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12173&action=edit
Bug 4118 - Add Collection Code to Statistics Table - Followup

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #48 from Paul Poulain  ---
I have some problems making it work. What I did:
 * apply all patches
 * updated opacthemes syspref to ccsr
 * checked that other css-related sysprefs are empty
 * cleared all FF cache

The display changes when I reduce windows size, but it is ugly (reduced or
large)

(I also checked with chrome, freshly launched)

source code says:






which seems OK to me

Any hint about something I could have missed welcomed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10603|0   |1
is obsolete||
  Attachment #10604|0   |1
is obsolete||
  Attachment #10887|0   |1
is obsolete||
  Attachment #11322|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 12172
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12172&action=edit
Bug 4118 - Add Collection Code to Statistics Table

Signed-off-by: Martin Renvoize 
Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189

--- Comment #21 from Kyle M Hall  ---
(In reply to comment #20)
> > > When I open 
> > > catalogue/moredetail.pl?biblionumber=21668&itemnumber=23170#item23170
> > > I see the "LOST list". If I choose one of them, the book is automatically
> > > checked-in, that's OK, but the price is not charged to the patron.
> > > What did I miss ?
> > > 
> > > (marking passed QA, it's probably me, but I won't push until I could test)

If you mark a checked out item as lost when on master, does it charge a fee to
the borrower?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189

--- Comment #20 from Kyle M Hall  ---
> > When I open 
> > catalogue/moredetail.pl?biblionumber=21668&itemnumber=23170#item23170
> > I see the "LOST list". If I choose one of them, the book is automatically
> > checked-in, that's OK, but the price is not charged to the patron.
> > What did I miss ?
> > 
> > (marking passed QA, it's probably me, but I won't push until I could test)

I just retested the patch, and everything appears to be working correctly for
me. I'm not sure why you are not seeing the replacement price getting charged
to the patron when you mark it lost. This patch does not touch that part of the
codebase, and there does not appear to be any way to configure Koha to not
charge a lost fee when an item is marked as lost from moredetail.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #82 from Owen Leonard  ---
Thanks for the clarifications Kyle. Unfortunately I have to ask you to rebase
this again since we got a new database revision and changes to SQLHelper.pm

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #16 from Paul Poulain  ---
This time it's OK, patch pushed to master !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall  ---
That sounds like a good plan to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #81 from Kyle M Hall  ---
I guess I should note that no cron script deletes modification to existing
borrowers. Those changes will sit in the borrower_modifications table until a
librarian either approves or denies the changes, no matter how long that will
take.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #12154|0   |1
is obsolete||

--- Comment #80 from Kyle M Hall  ---
Created attachment 12171
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12171&action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060

--- Comment #28 from Katrin Fischer  ---
Really, it would be a great addition - and more sign-offs are always helpful.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #79 from Kyle M Hall  ---
(In reply to comment #77)
> Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It
> deletes from borrower_modifications. But that's just for pending updates to
> existing patrons isn't it? Is that how it's supposed to work?
> 
> Either way, that script needs help added to it, and should not run without
> setting an explicit flag to proceed with deletions.

I think the script you are thinking of is
misc/cronjobs/delete_expired_opac_registrations.pl

That script will delete patrons with the category set in
PatronSelfRegistrationDefaultCategory after the specified delay.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #27 from Katrin Fischer  ---
Hi SJeffery, you could help getting this in by testing it very well and then
giving it another sign-off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060

SJeffery  changed:

   What|Removed |Added

 CC||steven_jeff...@fmi.com

--- Comment #26 from SJeffery  ---
Is this going to make it into 3.10? We have some major projects in our library
that would make extensive use of this functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #12 from Paul Poulain  ---
Sorry, but the patch does not apply anymore, because of bug 6494.

Could you rebase & resubmit (conflict not trivial to solve: I feel most of it
is tidying code, but to avoid any mistake, I let you do)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #78 from Kyle M Hall  ---
(In reply to comment #77)
> Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It
> deletes from borrower_modifications. But that's just for pending updates to
> existing patrons isn't it? Is that how it's supposed to work?
> 
> Either way, that script needs help added to it, and should not run without
> setting an explicit flag to proceed with deletions.

It doesn't touch modifications to existing borrowers. If someone submits a
registration from the opac, but never clicks the verification link, that row
will just sit in the borrower_modifications table forever. This script deletes
rows that have been sitting in the table for more than 24 hours.

I'll add some help to it, and while I'm at it, I can make the hours part
configurable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #12 from Jonathan Druart  ---
(In reply to comment #11)
> That's exactly the point. It removes the ambiguity between what  id="login"> refers to. The  on auth.tt will now be identified
> differently than the  in the staff client header.

Ok thank you Owen.

So I marked it as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #16 from Jonathan Druart  ---
(In reply to comment #13)
> Epic fail:
> 
> syntax error at acqui/parcel.pl line 84, near ");"
> Global symbol "$datereceived" requires explicit package name at
> acqui/parcel.pl line 85.
> Global symbol "$datereceived" requires explicit package name at
> acqui/parcel.pl line 85.

Outch sorry !
A parenthesis was missing after the conflict, I solved it like:

-my $datereceived = ($op eq ('new' or 'search' )
+my $datereceived = ( $op eq ('new' or 'search' ) )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12038|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  ---
Created attachment 12170
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12170&action=edit
Bug 7583 follow-up: Prevent users to cancel receipt if they can't

Disable the link for cancelling instead of displaying an error message
after the click. This is only valid if parent order line is received,
not if it's deleted.
When the user gets his mouse over the disabled link, he gets a message
telling him which order (ordernumber) blocks him so he knows immediately
which receipt to cancel.
Also improve error messages for non technical people

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12037|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  ---
Created attachment 12169
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12169&action=edit
Bug 7583: Cancel a receipt

In acqui/parcel.pl, there is now the possibility to cancel a receipt.
In "Already received" table, just click on "Cancel receipt" and the
order line will go back to pending orders.
If it was a partial receipt, order line is merged to its 'parent' line.
Attached items are modified so that they become attached to the merged
order line.
If AcqCreateItem is 'receiving', attached items are deleted.
If an order line was first partially received, and then completed. You
must cancel the 'parent' order line before cancelling the 'child'.

Signed-off-by: Marc Veron 

The patch behaves like expected, and the feature is really helpfull.

Just a tiny remark about the following message:

-
Cannot cancel receipt. Possible reasons :
You are trying to cancel the receipt of an order line whose parent order line
is already received. Cancel this parent order line and retry.
-

Maybe it would be good
- to explain a little bit more why it happend and re-word the message for non
technical people (not everybody understands 'parent' the same way)

- prevent the situation to happen (e.g. forbid order lines to be deleted if
they are already received) - but that would be in the scope of an other bug, I
think.

I think such things could be fixed in the future during the ongoing work for
Acquisitions module. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #13 from Paul Poulain  ---
(In reply to comment #12)
> Rebased patches

Epic fail:

syntax error at acqui/parcel.pl line 84, near ");"
Global symbol "$datereceived" requires explicit package name at acqui/parcel.pl
line 85.
Global symbol "$datereceived" requires explicit package name at acqui/parcel.pl
line 85.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #43 from Paul Poulain  ---
"Do not try to debar patrons if returns are not overdue" follow-up pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
Simple template modification patch.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

--- Comment #11 from Owen Leonard  ---
That's exactly the point. It removes the ambiguity between what  refers to. The  on auth.tt will now be identified differently
than the  in the staff client header.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz
   |ity.org |
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart  ---
QA comments:
works as expected, simple fix.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #77 from Owen Leonard  ---
Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It
deletes from borrower_modifications. But that's just for pending updates to
existing patrons isn't it? Is that how it's supposed to work?

Either way, that script needs help added to it, and should not run without
setting an explicit flag to proceed with deletions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #76 from Kyle M Hall  ---
(In reply to comment #75)
> (In reply to comment #74)
> >  * Add invalid token page
> 
> This works great, thanks,
> 
> As for the potential duplicate patrons when not requiring email
> notification, I guess the upside is that
> delete_unverified_opac_registrations.pl job will deal with them. However,
> that assumes that the patron is coming in to the library to confirm their
> identity (or whatever procedure changes them from a temp category to a
> permanent one), and that the library is running that cron job. It remains a
> potential problem for libraries which allow patrons to register for
> full-fledged accounts without confirmation (however unlikely that scenario
> seems to me).

Agreed. Perhaps just adding a caveat in the manual should suffice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

--- Comment #9 from Kyle M Hall  ---
I should also note that if don't use a quick flag in the borrowers table, we
wouldn't need a cronjob either. We could remove expired debarments when
checking if the patron is currently debarred.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3456] Serials receipt note

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #6 from Jonathan Druart  ---
QA comments:

Display a new information (internalnotes) on the receipt page.
Simple patch.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

--- Comment #8 from Kyle M Hall  ---
(In reply to comment #7)
> (In reply to comment #6)
> > We can have a cronjob that runs
> > nightly to remove any expired debarments, and reset the borrowers.debarment
> > field to 0 if the borrower no longer has any active debarments.
> 
> If we're relying on a cron job to remove debarments, then I wonder why we
> bother with the extra table? Why not run a cron job which checks for
> borrowers with no overdues for whom borrowers.debarred = '-12-31' ? This
> would exclude patrons which were restricted under a suspension in days rule.
> 
> If we're trying to exclude patrons for whom borrowers.debarred was set
> manually, maybe we need to instead create a new flag for manual restriction?

I guess my idea is to have a more flexible and extensible system. Having
multiple debarment fields in the borrowers table seems kludgy to me. What if a
borrower is debarred for different reasons at different branches? With my
proposed design, we could allow patrons to be debarred at only specific
libraries if we add a branch code to the debarments table. I guess I'm just
making the case that it would be better to in the long run to develop a
separate table rather than keep adding more fields to the borrowers table. If
plack ever becomes the primary way to run Koha, we wouldn't even need a 'quick'
flag in the borrowers table, as the result could be cached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #75 from Owen Leonard  ---
(In reply to comment #74)
>  * Add invalid token page

This works great, thanks,

As for the potential duplicate patrons when not requiring email notification, I
guess the upside is that delete_unverified_opac_registrations.pl job will deal
with them. However, that assumes that the patron is coming in to the library to
confirm their identity (or whatever procedure changes them from a temp category
to a permanent one), and that the library is running that cron job. It remains
a potential problem for libraries which allow patrons to register for
full-fledged accounts without confirmation (however unlikely that scenario
seems to me).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart  ---
QA Comments:

This patch duplicates code but it is like this in so many members/* files

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart  ---
QA Comments:
works as expected, nothing to say.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #10 from Jonathan Druart  ---
The template file modules/auth.tt still use the login id for a div element.
Please clarify if it is normal.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
QA comments:
This patch allows $supplierid to be a string or an integer.
We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==)

Maybe a better option would be to set the "all suppliers" value with -1.

Marked as Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Owen Leonard  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8496] show local cover images on lists view in opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #8 from Paul Poulain  ---
Patch pushed to master

(Nice enhancement !)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #11998|0   |1
is obsolete||
  Attachment #11999|0   |1
is obsolete||
  Attachment #12000|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  ---
Created attachment 12168
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12168&action=edit
Bug 7986: Export issues for patron

Rebased and squashed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

--- Comment #7 from Owen Leonard  ---
(In reply to comment #6)
> We can have a cronjob that runs
> nightly to remove any expired debarments, and reset the borrowers.debarment
> field to 0 if the borrower no longer has any active debarments.

If we're relying on a cron job to remove debarments, then I wonder why we
bother with the extra table? Why not run a cron job which checks for borrowers
with no overdues for whom borrowers.debarred = '-12-31' ? This would
exclude patrons which were restricted under a suspension in days rule.

If we're trying to exclude patrons for whom borrowers.debarred was set
manually, maybe we need to instead create a new flag for manual restriction?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7986] Export issues

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #25 from Paul Poulain  ---
The last patch does not apply

Applying: Bug 7986: Followup: Replace DontExportFields and CsvProfileForExport
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 7986: Followup: Replace DontExportFields and
CsvProfileForExport
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Patch left in
/tmp/Bug-7986-Followup-Replace-DontExportFields-and-Csv-kNu3V9.patch


Jonathan, note that you can also squash the 3 patches in one, that will be
easier to solve updatedatabase conflict !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #68 from Jonathan Druart  ---
adapting status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12133|0   |1
is obsolete||

--- Comment #67 from Jonathan Druart  ---
Comment on attachment 12133
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12133
[SIGNED-OFF] Bug 7621: Followup: FIX warnings "Scalar value @values[$take]
better written as $values[$take]"

Fix with Bug 8761

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Jonathan Druart  ---
I proposed exactly the same patch in Bug 7621 (which introduces these
warnings). So I mark it as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750

--- Comment #6 from Joy Nelson  ---
Valid point!  I'm testing on my local install and assumed it was running, I
will double check and retest.  Thanks!

> Are you sure the zebra daemon started properly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8708] RSS feed for new comments is broken

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

--- Comment #10 from Paul Poulain  ---
Patch pushed to master
(Not sure this patch applies or is relevant for 3.8)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12158|Bug 7143: Adding Kathryn|[PASSED-QA]Bug 7143: Adding
description|Tyree to the history and|Kathryn Tyree to the
   |About page. |history and About page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #54 from Jonathan Druart  ---
passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #58 from Paul Poulain  ---
Patch pushed to master

I tried to find things that could have been broken by this feature (testing
with syspref=off, without hold_queue at all), and could not find anything
wrong.

I can edit the admin/transport-matrix.pl correctly.
I haven't tested the rest of the feature work perfectly, but no regression =>
patch pushed !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

--- Comment #2 from Jonathan Druart  ---
Created attachment 12167
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12167&action=edit
Bug 8369: Followup: indent sql queries in admin/smart-rules.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

--- Comment #1 from Jonathan Druart  ---
Created attachment 12166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12166&action=edit
Bug 8369: Merge tables for circulation rules.

This patch adds 3 new tables:
 - circ_rules
 - borrower_circ_rules
 - item_circ_rules
It removes 6 tables:
 - default_borrower_circ_rules
 - default_branch_circ_rules
 - default_branch_item_rules
 - default_circ_rules
 - branch_borrower_circ_rules
 - branch_item_rules

The goal is to merge circulations rules into 3 tables instead of 6 without
add or remove features. Previous behaviours do not change.
The wildcard '*' character is a rule for the default values. Then it is
possible to merge 2 tables into one if we consider that the default value is
the value with a branchcode eq '*'.
I removed the foreign key constraint with branchcode and added 3 queries
in the C4::Branch::DelBranch routine in order to remove records about a
deleted branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Owen Leonard  changed:

   What|Removed |Added

Summary|Fines that debar|Overdues which debar
   |automatically, should   |automatically should
   |undebar automatically when  |undebar automatically when
   |paid.   |returned

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid.

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

--- Comment #6 from Kyle M Hall  ---
(In reply to comment #5)
> (In reply to comment #4)
> > I would say we keep borrowers.debarred, but convert it to a boolean value.
> 
> Convert it *back* to a boolean value! And move the date information into
> borrower_debarment?

Yes. It will just be a quick check to know if the borrower is currently
debarred without checking the debarments table.

> > We can then have that value updated each time the debarments table is
> > altered.
> 
> Which is when? Is there a line in borrower_debarment for each overdue item
> which is past the limit? And the table is reviewed each time an item is
> renewed or checked in?+

Each time a debarment is added to the borrower_debarments table, or a debarment
is removed from the borrower_debarments table, a check will then be performed
to determine if the borrower is currently debarred or not, and
borrowers.debarred will be updated accordingly.

> > I believe we will then need a nightly cronjob to remove expired
> > debarments and update borrowers.debarred.
> 
> I don't understand. Are we talking about a cron job or is this something
> which updates each time something is checked in or renewed?

Right now, Koha checks the debarment field as a date to see if it is still
valid. This will no longer be effective, as we will be able to have multiple
debarments with different expiration dates. We can have a cronjob that runs
nightly to remove any expired debarments, and reset the borrowers.debarment
field to 0 if the borrower no longer has any active debarments.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #31 from Paul Poulain  ---
(In reply to comment #30)
> (In reply to comment #29)
> > (In reply to comment #28)
> > > (In reply to comment #27)
> > > > Your change is line-for-line identical (other than one indentation 
> > > > change)
> > > > to the follow-up that did not work for Paul.
> > > 
> > > That's both funny and odd. It definitely works for me.
> > 
> > For both Chris and me, too. It seems to be an interaction of the patch with
> > data on Paul's system.
> 
> my investigations shows that the PrimaryKey is not found, resulting in a SQL
> that is:
> UPDATE borrowers SET ... WHERE =?
> which is, obviously, wrong :\

I've tested with and without cache and with and without Plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #30 from Paul Poulain  ---
(In reply to comment #29)
> (In reply to comment #28)
> > (In reply to comment #27)
> > > Your change is line-for-line identical (other than one indentation change)
> > > to the follow-up that did not work for Paul.
> > 
> > That's both funny and odd. It definitely works for me.
> 
> For both Chris and me, too. It seems to be an interaction of the patch with
> data on Paul's system.

my investigations shows that the PrimaryKey is not found, resulting in a SQL
that is:
UPDATE borrowers SET ... WHERE =?
which is, obviously, wrong :\

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500

Owen Leonard  changed:

   What|Removed |Added

   Attachment #9680|0   |1
is obsolete||

--- Comment #30 from Owen Leonard  ---
Created attachment 12165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12165&action=edit
Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page
loading

This patch adds a new sprite image for social network links.
The page markup has been modified to accommodate the image-
replacement technique used to display the images.

When testing be sure to clear your cache to load the new CSS.

Revision: Rebased, and unused social network images removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750

--- Comment #5 from Jared Camins-Esakov  ---
I can't test this at the moment, but it is worth noting that there are several
implied steps for testing this patch:
1) apply patch
2) rerun Makefile.PL to choose GRS-1 indexing for authorities
3) update Zebra configuration files by running make && make install
4) reindex zebra using rebuild_zebra.pl -a -r
5) search for chronological term

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #29 from Jared Camins-Esakov  ---
(In reply to comment #28)
> (In reply to comment #27)
> > Your change is line-for-line identical (other than one indentation change)
> > to the follow-up that did not work for Paul.
> 
> That's both funny and odd. It definitely works for me.

For both Chris and me, too. It seems to be an interaction of the patch with
data on Paul's system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #28 from Kyle M Hall  ---
(In reply to comment #27)
> Your change is line-for-line identical (other than one indentation change)
> to the follow-up that did not work for Paul.

That's both funny and odd. It definitely works for me.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8412] add color icon set

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #17 from Paul Poulain  ---
Patch pushed to master

Final comment: definitely, I'm not a big fan of this patch. I feel it could
have been written another way. However, it's highly not intrusive, so easy to
remove if another option for picking a color is written. So I've pushed the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to comment #3)
> I attempted to sign off on this patch.  I first tried searching for
> authority records on master and was unable to retrieve any authority
> records.  (I can search for authority records on 3.8.4)  

Are you sure the zebra daemon started properly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #9 from Paul Poulain  ---
(In reply to comment #8)
> bump ! Frédéric, see comment 7, I can't make it work !

Frédéric, bump again !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #27 from Jared Camins-Esakov  ---
Your change is line-for-line identical (other than one indentation change) to
the follow-up that did not work for Paul.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #26 from Kyle M Hall  ---
(In reply to comment #25)
> The follow-up does not fix the problem for me.
> After discussion with Jared on IRC, the initial patches have been reverted.
> Dobrica said he will work on another patch for caching.

I have a fix for it integrated into my followup patch for Bug 7067. Someone
could just steal that code out and post if up as a patch here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >