[Koha-bugs] [Bug 8912] Remove unused hold-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8912 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8912] Remove unused hold-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8912 Chris Cormack changed: What|Removed |Added Attachment #12788|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 12897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12897&action=edit Bug 8912 - Remove unused hold-menu.inc hold-menu.inc is not used on any page in Koha and can be safely removed. To confirm, search the Koha source for "hold-menu.inc." No instances should be found. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8899] Remove unused CSS declarations from staff client CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8899] Remove unused CSS declarations from staff client CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Chris Cormack changed: What|Removed |Added Attachment #12794|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 12896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12896&action=edit Bug 8899 - Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8914] Blank search that returns invalid authorities fails under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8914 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8914] Blank search that returns invalid authorities fails under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8914 Chris Cormack changed: What|Removed |Added Attachment #12798|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 12895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12895&action=edit Bug 8914: Blank search that returns invalid authorities fails under Plack When doing a search with no terms for the default authority type under Plack, you will get a segfault if it returns any records that do not have any authority type. As far as I can tell, this cannot be reproduced under CGI/Apache. To test: Confirm that you don't get an error if you click the Submit button in the authorities sections in the staff client and OPAC without entering a term or changing the authority type. You may or may not be able to reproduce the problem prior to applying the patch, but that is the only situation in which I managed to trigger it. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Robin Sheat changed: What|Removed |Added CC||ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8939] Fines Charged During Grace Period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8939] Fines Charged During Grace Period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Hi Robert Next time, can you make your patch using git format-patch This one had no commit message, or authorship details, I fixed that when signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8939] Fines Charged During Grace Period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939 Chris Cormack changed: What|Removed |Added Attachment #12893|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 12894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12894&action=edit Bug 8939 : Fines being charged during the grace period Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #14 from Srdjan Jankovic --- No disrespect, I understand the motivation, but I deliberately created 7854 in order to be able to avoid 0, 1, force. I could have done it that way myself, but it is wrong and perpetuates a deficiency in the config system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8939] Fines Charged During Grace Period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939 --- Comment #1 from Robert Williams --- Created attachment 12893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12893&action=edit Fine calculation condition update Proposed fix for errant grace period fine calculation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8939] New: Fines Charged During Grace Period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8939
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8939
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Assignee: koha-bugs@lists.koha-community.org
Summary: Fines Charged During Grace Period
Severity: major
Classification: Unclassified
OS: Linux
Reporter: willi...@amigos.org
Hardware: PC
Status: NEW
Version: rel_3_8
Component: Circulation
Product: Koha
When grace period specified in a circulation rule is greater than one day
(fines charged daily) and a user returns an item (matching the circ rule)
within the grace period, the fine is charged rather than ignored (zero). In one
example, with a 14-day grace period, the fines log produced nightly by fines.pl
shows:
22903STU[snipped]122012-09-29 23:59:0024
22951STU[snipped]1257412012-10-11 23:59:00-101
22965STU[snipped]775362012-10-14 23:59:00-130.25
The negative numbers indicate how many days of grace period remain (-10 means
the item is 4 days overdue); positive numbers shows how many days is overdue
after the grace period. The negative values should result in no processing.
There appears to be an error in the if condition that determines whether to
process/charge a fine on an overdue (negative values result in a TRUE as well
as positive values):
if ($data->{'chargeperiod'} && $units_minus_grace ) {
would work as expected if the second condition is changed:
if ($data->{'chargeperiod'} && ($units_minus_grace > 0) ) {
I've tested on 3.8.3 (Debian package installation) and the change works for
daily accruing fines. I have not yet tested using an hourly fine rule, but
after a quick glance it seems it should work as well.
I'll try (I'm new to Git) to add/submit a patch next.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8791] OPAC UNIMARC XSLT details : subject with subfield 3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- No string changes pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8873] JavaScript error in Opac displaying tag cloud
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8873 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 --- Comment #4 from Owen Leonard --- I would like to know what guidelines are being followed with regard to the changes in attachment 12871. Is there a particular reference guide we're following? I'm thinking that as each new kind of template change is submitted, a page in the wiki could also be updated adding the new coding guideline? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3504] Recurring patron fees.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3504 abhijit changed: What|Removed |Added CC||myd...@yahoo.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard --- Marking failed qa because of the broken link. Other comments are just suggestions, not bugs. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 --- Comment #3 from Nicole C. Engard --- Created attachment 12892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12892&action=edit vendor buttons on contract confusing At the top of the contract page there are buttons to edit and delete the vendor - they kind of seem out of place there. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Owen Leonard changed: What|Removed |Added Attachment #12869|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 12891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12891&action=edit [SIGNED-OFF] Bug 8712 - We should use WAI-ARIA guidelines to help with accessibility Added title to the search box Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 --- Comment #2 from Nicole C. Engard --- Owen, The Uncertain Prices tab links to: http://localhost:/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=1&owner=1 Also, it's kind of annoying that clicking basket and basket groups makes the menu on the left go away. Still poking around to see what else I can find. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 --- Comment #1 from Owen Leonard --- Created attachment 12890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12890&action=edit Bug 8913 - Improve acquisitions navigation This patch adds a new menu for vendor-related pages in which vendor related "views" can be linked to: baskets, basket groups, contracts, invoices, uncertain prices. The acquisitions toolbar is pared down to vendor-related actions: New basket, contract, or vendor; edit vendor, delete vendor, receive shipment. Other small improvements have been made to other pages: corrections to breadcrumbs and title tags, adding useful links betweeen pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8913] Improve acquisitions navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8882] Hourly circ doesn't work with the calendar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8882 --- Comment #2 from Melia Meggs --- Created attachment 12889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12889&action=edit screenshot of pop-up asking for date due Here's a screenshot of what happens when you try to check out an hourly item. As Elliott said, you get a pop-up asking you to confirm the due date. The pop-up has a blank due date box. If you click on Yes, it gives a due date of today 00:00, which means your item is instantly overdue, instead of giving a due date of one hour from now (or whatever your hourly circ rule says). As a result, you can't circulate hourly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||elli...@bywatersolutions.co ||m Assignee|savitra.sir...@osslabs.biz |elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Nicole C. Engard changed: What|Removed |Added Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Nicole C. Engard changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 --- Comment #19 from Nicole C. Engard --- David, After a patch is pushed it's marked obsolete to avoid clutter and make it clear which patches were pushed. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8935] transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8935] transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Nicole C. Engard changed: What|Removed |Added Attachment #12887|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 12888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12888&action=edit [SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 Signed-off-by: Nicole C. Engard still works as expected and is much more visually appealing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Jane Wagner changed: What|Removed |Added CC||jwag...@ptfs.com --- Comment #18 from Jane Wagner --- For background, see Bug 2368 -- the original default date range was 10 years. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8870] UNIMARC authorities search doesn't display properly information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8870 --- Comment #8 from Frédéric Demians --- > * digging for any side effect, I was wondering what was the reason for: > +[% BLOCK language %] > + [% SWITCH lang %] > + [% CASE ['en', 'eng'] %]English > + [% CASE ['fr', 'fre'] %]French > + [% CASE ['it', 'ita'] %]Italian UNIMARC authorities can contain translated headings. The language is coded in a subfield. The template decodes it, and so it's translatable. If required, more language codes could be added. 2 and 3 letters codes are "acceptable". > Other question: does this patch remove the use of auth_types.summary we had > before ? (I think, but want a confirmation) It has already been done by Jared patch: bug 8523. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 --- Comment #3 from Owen Leonard --- Sorry for the incorrect attachment, git bz typo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Owen Leonard changed: What|Removed |Added Attachment #12886|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8938] New: Transport cost matrix script and template contain untranslatable strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8938
CC: gmcha...@gmail.com
Assignee: koha-bugs@lists.koha-community.org
Summary: Transport cost matrix script and template contain
untranslatable strings
Severity: normal
Classification: Unclassified
OS: All
Reporter: oleon...@myacpl.org
Hardware: All
Status: NEW
Version: master
Component: System Administration
Product: Koha
In the template, a string in JavaScript is not wrapped in the proper function:
alert("Cost must be expressed as a decimal number >= 0");
In the script, error messages are built with English strings and passed whole
to the template:
push @errors, "Invalid value for $from_row{name} ->
$from_to_input_def{name}"
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #7 from David Cook --- Hi Jonathan: I just tried applying your patch against master with git bz, but it looks like it needs a rebase: Applying: Bug 8782: Close a subscription error: patch failed: installer/data/mysql/updatedatabase.pl:5795 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:189 error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:33 error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt: patch does not apply Patch failed at 0001 Bug 8782: Close a subscription Looking forward to testing this one out though! (In reply to comment #5) > (In reply to comment #4) > > I'd like to start testing and signing off on larger patches, but I want to > > make sure that I'm doing a thorough enough job. > > Hi David! > The patch is large but there is no complex code. There are a lot of template > modifications and a new status for serials. > I think if > 1/ you agree with this new status > 2/ you don't find any regression in the serials module pages > 3/ the feature works as expected > 4/ you don't have any question > > You can sign off this patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] cannot renew items on hold even with override
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #8 from mathieu saby --- Hi We discovered this problem some days ago, but I have just find this bug in BZ. As a librarian I completely agree with Nicole Engard : an override should be an override... M. Saby Rennes 2 University -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8935] transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 --- Comment #1 from Owen Leonard --- Created attachment 12887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12887&action=edit Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8935] transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 --- Comment #2 from Owen Leonard --- Created attachment 12886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12886&action=edit Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 --- Comment #17 from David Cook --- I might be missing something, but where did the original patch and other follow-ups go? It looks like they've been mistakenly marked as obsolete... While circulation.pref looks good in master, it seems to me that no one will be able to apply this patch using git bz. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8870] UNIMARC authorities search doesn't display properly information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8870 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #7 from Paul Poulain --- QA comment: * patch applies, passes koha-qa.pl, work well * digging for any side effect, I was wondering what was the reason for: +[% BLOCK language %] + [% SWITCH lang %] + [% CASE ['en', 'eng'] %]English + [% CASE ['fr', 'fre'] %]French + [% CASE ['it', 'ita'] %]Italian + [% CASE ['de', 'ger', 'deu'] %]German + [% CASE ['es', 'spa'] %]Spanish + [% CASE %][% lang %] + [% END %] +[% END %] (in cunjunction with +[% PROCESS language lang=otherscrip.lang | trim %]: ) Other question: does this patch remove the use of auth_types.summary we had before ? (I think, but want a confirmation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain --- Robin, I'm unable to efficiently QA this patch, and I think other QA team have the same problem. Could you give me your opinion ? (Note that I could push this patch to 3.10 if it's validated before the end of the week because there's no side-effect risk, so it's not concerned by the current Feature Freeze) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8935] transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Paul Poulain changed: What|Removed |Added Version|master |rel_3_12 --- Comment #19 from Paul Poulain --- Changes Circulation.pm, Members.pm and circulation. Adds a column to the database I won't push this patch for 3.10 because of the Feature Freeze. Affecting rel_3_12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Severity|critical|enhancement --- Comment #27 from Paul Poulain --- follow-up pushed, (back to ENH) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #13 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #37 from Paul Poulain --- tiny follow-up tested, fixes the problem by using a smaller font, well done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3652] XSS vulnerabilities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652
--- Comment #39 from Jared Camins-Esakov ---
(In reply to comment #38)
> Comment on attachment 12835 [details]
> Bug 3652: close XSS vulnerabilities on biblionumber and authid
>
> About this patch, Jared, why do you add
> || $query->param('bib');
> to opac-ISBD|MARCdetail.pl ?
> I see it's in opac-detail, but it's an oldies and not goodies (in early
> versions of Koha, biblionumber was sometimes written bib, bn, ... It has
> been fixed, and I favour removing
> || $query->param('bib');
> from opac-detail.pl, because we must not have param('bib')
I wanted to make sure the behavior was identical, and I figured there must
surely be a good reason for the $query->param('bib'). If you wanted to remove
the || $query->param('bib') from all three files, I would not object at all.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3652] XSS vulnerabilities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652
--- Comment #38 from Paul Poulain ---
Comment on attachment 12835
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12835
Bug 3652: close XSS vulnerabilities on biblionumber and authid
About this patch, Jared, why do you add
|| $query->param('bib');
to opac-ISBD|MARCdetail.pl ?
I see it's in opac-detail, but it's an oldies and not goodies (in early
versions of Koha, biblionumber was sometimes written bib, bn, ... It has been
fixed, and I favour removing
|| $query->param('bib');
from opac-detail.pl, because we must not have param('bib')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3652] XSS vulnerabilities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652 Paul Poulain changed: What|Removed |Added Attachment #12809|0 |1 is obsolete|| --- Comment #37 from Paul Poulain --- Comment on attachment 12809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12809 Bug 3652: [SIGNED-OFF] XSS fixes - follow up QA comment, trivial patch, passes QA & pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Severity|normal |enhancement --- Comment #16 from Paul Poulain --- back to pushed to master & ENH, follow-up pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Paul Poulain --- follow-up passes QA of course -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #13 from Paul Poulain --- (In reply to comment #12) > if the force mode is active in 'OPACItemHolds' there must be one item is > selected by default in this screen > > ../cgi-bin/koha/opac-reserve.pl?biblionumbers=... > > and in the table 'Select a specific copy' I add my word to what stephane says, because he just showed me the problem: if you set the value to "force" and validate your hold without selecting an item, the hold is placed ... 1st available, which should be forbidden by the "Force" syspref. The easiest solution to this problem is to select the 1st item in the list of items (that will avoid one click to all holds placed on records with just one item !) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 --- Comment #12 from Kyle M Hall --- (In reply to comment #11) > I would favor pushing this patch, if we fix the constraint stuff on another > report (including some lines in updatedatabase to correct the historical > "ballast" from MyISAM etc.) > This patches fixes a display problem that theoretically should not occur, > but in practice does. The other report would deal with the wrong data. I tend to agree. This patch may just be 'hiding' the underlying problem, but we are now aware of it. As long as we follow up on this issue with a correction 'under the hood', I see no reason not to push this as a quick fix from the user stand point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #12 from delaye --- if the force mode is active in 'OPACItemHolds' there must be one item is selected by default in this screen ../cgi-bin/koha/opac-reserve.pl?biblionumbers=... and in the table 'Select a specific copy' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #11 from Jonathan Druart --- Created attachment 12885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12885&action=edit Bug 7825: Followup values are 1, 0 or 'force' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #10 from Jonathan Druart --- Created attachment 12884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12884&action=edit Bug 7825: Followup prevent submission without choosing an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What|Removed |Added Attachment #8646|0 |1 is obsolete|| Attachment #12881|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 12883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12883&action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 --- Comment #17 from M. de Rooy --- (In reply to comment #16) > What MARC-flavour did you test with, Marcel? I just ran the tests on current > master without any problems: MARC21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1963] Problem with deleted biblio in a virtual shelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1963 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #11 from M. de Rooy --- I would favor pushing this patch, if we fix the constraint stuff on another report (including some lines in updatedatabase to correct the historical "ballast" from MyISAM etc.) This patches fixes a display problem that theoretically should not occur, but in practice does. The other report would deal with the wrong data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #54 from Jonathan Druart --- (In reply to comment #52) > I hope you don't mind, but I updated your patch to show the preference in a > bit clearer of a sentence Quite the opposite ! Thank you to correct me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #8 from delaye --- i want test in a sandbox (biblibre) but i have the message CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What|Removed |Added Attachment #12850|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 12882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12882&action=edit Bug 7986 Follow Up: Fix ExportRemoveFields This preference was in the code as a choice but should be a list of fields to exclude. This patch makes that change and updates the description to fit more with the standard set by other preferences. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8925] Late orders : checkbox to claim order shouldn't appear if no email is known
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8925 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Adrien, I think this could be a bit hard to figure out for the library why the checkbox is not displaying. I think it will give you a good error message when you try to send an email and there is no email address - I am not sure which is better. But maybe worth giving it some thought before putting work into a solution? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart --- (In reply to comment #5) > My tests show 2 problems: > * when you set the syspref to "allow", the user should be able to choose > "next available" or any item. I can't have the item list appearing ! I can't reproduce, "it works for me" > * when you set the syspref to "force", it seems good, as you get the items > list and no option to say "next available". BUT, you can submit the form > without choosing any item, and in this case, it seems that you've placed a > "next available" hold. I think my patch solves this problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #6 from Jonathan Druart --- Created attachment 12881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12881&action=edit Bug 7825: Followup prevent submission without choosing an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8937 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Fridolyn SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8936 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8937] New: Translation process removes CDATA in HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Priority: P5 - low Change sponsored?: --- Bug ID: 8937 Assignee: gmcha...@gmail.com Summary: Translation process removes CDATA in HTML Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.som...@biblibre.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha The translation process seams to manage CDATA tags in JS but not in HTML directly. This exists in RSS feed 'opac-opensearch.tt' : is translated in fr-FR : Search results [% IF ( query_desc ) %]for '[% query_desc |html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc |html %]'[% END %] at [% LibraryName |html %] This is another cause of bug 8936. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300
--- Comment #16 from Magnus Enger ---
(In reply to comment #13)
> t/db_dependent/www/batch.t .. 14/20
> # Failed test 'found book'
> # at t/db_dependent/www/batch.t line 165.
> # searched: "\x{0a}\x{0a} Tra"...
> # can't find: "Data structures"
> # LCSS: "Data str"
> # LCSS context: "" rel="gb_page_center[600,500]">Englewood Data str"
> t/db_dependent/www/batch.t .. 19/20 # Looks like you failed 1 test of 20.
> t/db_dependent/www/batch.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/20 subtests
What MARC-flavour did you test with, Marcel? I just ran the tests on current
master without any problems:
$ prove -v t/db_dependent/www/batch.t
t/db_dependent/www/batch.t ..
1..20
ok 1 - connect to intranet
ok 2 - login to staff client
ok 3 - load main page
ok 4 - open tools module
ok 5 - go to stage MARC
ok 6 - uploaded file
ok 7 - upload succeeded
ok 8 - reopen stage MARC page
ok 9 - stage MARC
ok 10 - have job ID
ok 11 - job was completed
ok 12 - reopen stage MARC page at end of upload
ok 13 - stage MARC
ok 14 - view batch
ok 15 - found book
ok 16 - imported records into catalog
ok 17 - successfully imported record
ok 18 - revert import
ok 19 - getting reverted bib
ok 20 - bib is gone
ok
All tests successful.
Files=1, Tests=20, 25 wallclock secs ( 0.04 usr 0.00 sys + 0.56 cusr 0.04
csys = 0.64 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS --- Created attachment 12880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12880&action=edit Proposed patch It appears a paragraph tag is broken when RequestOnOpac is on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8936] New: Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Priority: P5 - low Change sponsored?: --- Bug ID: 8936 Assignee: oleon...@myacpl.org Summary: Search RSS feeds does not show there items when subscribing in Firefox Severity: minor Classification: Unclassified OS: All Reporter: fridolyn.som...@biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha In OPAC and with Firefox, after a search, click on RSS icon. When language is not english (translated templates), the subscribing page does not show items. When adding RSS feeds to a reader, the items are well displayed. Small bug but most readers will think the RSS feeds does not work. 'RequestOnOpac' syspref must be off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #6 from Jonathan Druart --- Created attachment 12879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12879&action=edit Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of "disabled" serials -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8300] Koha should have mechanized testing suite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 --- Comment #15 from Magnus Enger --- I have started to collect some ideas here: http://wiki.koha-community.org/wiki/Mechanized_testing_suite_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8934] fix typo and language on transport cost matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8934 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8934] fix typo and language on transport cost matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8934 Chris Cormack changed: What|Removed |Added Attachment #12866|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 12878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12878&action=edit Bug 8934: Fix transport cost matrix help language The transport cost matrix has a typo (arbitrarymax) and the help text could be worded better. This patch makes those changes. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack changed: What|Removed |Added Attachment #12734|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 12877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12877&action=edit Bug 8665: DOM indexing fails to index some bib records Use a user-specified field for z:id. This patch also fixes an excess space before the index in the MARC21 biblio index definitions, which someone fixed in the generated file but not in the source file it should have been fixed in. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack changed: What|Removed |Added Attachment #12837|0 |1 is obsolete|| --- Comment #9 from Chris Cormack --- Created attachment 12875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12875&action=edit Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
