[Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries.

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries.

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826

Chris Cormack  changed:

   What|Removed |Added

  Attachment #12582|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 13165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13165&action=edit
Bug 8826 - Initialization of hash triggers error log entries - Followup

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Mason James  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #15 from Mason James  ---
(In reply to comment #14)
> The test fails unless BOTH patches are pushed, I have signed off the second
> one, putting it back to signed off for QA


test works as stated - passing QA on 2 patches...
(awesome stuff Jared)

$ sudo /etc/init.d/mysql stop
$ export KOHA_CONF=''
$ perl  t/db_dependent/SuggestionEngine_ExplodedTerms.t
ok 1 - use Koha::SuggestionEngine;
unable to locate Koha configuration file koha-conf.xml at
/home/mason/git/head/C4/Context.pm line 360.
unable to locate Koha configuration file koha-conf.xml at
/home/mason/git/head/C4/Context.pm line 360.
Use of uninitialized value in concatenation (.) or string at
/home/mason/git/head/C4/Templates.pm line 208.
ok 2 - Created suggestion engine
ok 3 - Suggested correct alternatives for keyword search 'Cookery'
ok 4 - Suggested correct alternatives for subject search 'Cookery'
ok 5 - No suggestions for fielded search
ok 6 - No suggestions for CCL search
1..6


$ koha-qa.pl -c 2 -v 2

testing 2 commit(s) (applied to commit ea9e867)
 * a9729fd Bug 8846 conflict resolution: correct path
  t/db_dependent/SuggestionEngine_ExplodedTerms.t

 * 3207eb3 Bug 8846: Exploded Terms test sneakily uses database
  t/db_dependent/SuggestionEngine_ExplodedTerms.t

* t/db_dependent/SuggestionEngine_ExplodedTerms.t  OK
pod OK
forbidden patterns  OK
valid   OK
critic  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8636] Some dependencies are not listed by the installer

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636

--- Comment #33 from Jared Camins-Esakov  ---
(In reply to comment #32)
> This only applies to XS packages, everything pure-perl ends up in the amd64
> part as well.

And we now have the one XS package for AMD64, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8636] Some dependencies are not listed by the installer

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636

--- Comment #32 from Robin Sheat  ---
This only applies to XS packages, everything pure-perl ends up in the amd64
part as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8636] Some dependencies are not listed by the installer

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636

--- Comment #31 from Jared Camins-Esakov  ---
Note, however, that the package dependencies for 3.10 are available for Squeeze
only for i386 at this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8636] Some dependencies are not listed by the installer

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #13029|0   |1
is obsolete||

--- Comment #30 from Jared Camins-Esakov  ---
Created attachment 13164
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13164&action=edit
Bug 8636 - add Moose dependency to the dependencies

Koha::SearchEngine requires moose, but it wasn't declared as a
dependency.

Also update the debian/control dependencies to match the current state
of the requirements.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8636] Some dependencies are not listed by the installer

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8636

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5490] Is smsoverdues.pl an orphan

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5490

--- Comment #3 from Jared Camins-Esakov  ---
Created attachment 13163
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13163&action=edit
Bug 5490: smsoverdues.pl is an orphan

The script misc/cronjobs/smsoverdues.pl requires HTML::Template::Pro and
uses templates that do not exist in Koha. Since this has been true for
at least a year and a half, and no one is aware of anyone who is using
it, it seems prudent to remove the script so that no one is confused
and/or distressed by its non-functioning nature.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5490] Is smsoverdues.pl an orphan

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5490

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5490] Is smsoverdues.pl an orphan

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5490

Jared Camins-Esakov  changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #1 from MJ Ray (software.coop)  ---
This bug is mentioned in:
Bug 5490: Update Lists and About Help Filesfor 3.4
http://lists.koha-community.org/pipermail/koha-patches/2011-March/014228.html

--- Comment #2 from Jared Camins-Esakov  ---
*** Bug 8999 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8999] check misc/cronjobs/smsoverdues.pl uses H:T:P

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8999

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Jared Camins-Esakov  ---


*** This bug has been marked as a duplicate of bug 5490 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9003] Add css fix for opac news items with strong and em

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003

David Cook  changed:

   What|Removed |Added

  Attachment #13161|0   |1
is obsolete||

--- Comment #2 from David Cook  ---
Created attachment 13162
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13162&action=edit
Bug 9003 - Add css fix for opac news items with strong and em

Replaced child selector with descendant selector to match the rest the
staff-global.css file...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #12926|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #12836|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #12835|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8978] Patron's dateexpiry is erroneously updated if dateexpiry in UnWantedField syspref

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8978

Jared Camins-Esakov  changed:

   What|Removed |Added

Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8978] Patron's dateexpiry is erroneously updated if dateexpiry in UnWantedField syspref

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8978

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #3 from Jared Camins-Esakov  ---
This patch has been pushed to master.

As a reminder, please include bug numbers in the subject line of your patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8978] Patron's dateexpiry is erroneously updated if dateexpiry in UnWantedField syspref

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8978

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #13124|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9003] New: Add css fix for opac news items with strong and em

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 9003
  Assignee: oleon...@myacpl.org
   Summary: Add css fix for opac news items with strong and em
  Severity: minor
Classification: Unclassified
OS: All
  Reporter: dc...@prosentient.com.au
  Hardware: All
Status: NEW
   Version: master
 Component: OPAC
   Product: Koha

Currently, if you have nested strong and em tags in Opac News, you will only
get the properties of the inner tag, since reset-fonts-grids.css resets the
font weight and style (for both strong and em) to normal. 

So if you have em as your inner tag, you'll have italics but
reset-fonts-grids.css also makes em have a font-weight of normal, so your
strong tag is bypassed.

I suggest adding some css that takes into account this descendant/nested
situation, so that users can actually both bold and italicize news items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8982] koha-create rejects --database option

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8982

Jared Camins-Esakov  changed:

   What|Removed |Added

Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8982] koha-create rejects --database option

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8982

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #13125|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8982] koha-create rejects --database option

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8982

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #13144|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #14 from Chris Cormack  ---
The test fails unless BOTH patches are pushed, I have signed off the second
one, putting it back to signed off for QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Chris Cormack  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Chris Cormack  changed:

   What|Removed |Added

  Attachment #13158|0   |1
is obsolete||

--- Comment #13 from Chris Cormack  ---
Created attachment 13160
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13160&action=edit
Bug 8846 conflict resolution: correct path

The test was moved since the original patch was written, making the
revised test fail. This patch corrects the mocked template patch so that
the test will pass.

To test:
1) Before applying patch, run
   `prove t/db_dependent/SuggestionEngine_ExplodedTerms.t`
2) Note that it fails.
3) Apply patch.
4) Run `prove t/db_dependent/SuggestionEngine_ExplodedTerms.t`
5) Note that it passes.
6) Celebrate.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9002] Remove Problematic Logic from Patron Messaging Preferences Form

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

--- Comment #1 from David Cook  ---
Created attachment 13159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13159&action=edit
Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form

It's a super basic code removal. In most cases, its presence would probably not
cause a problem. 

Currently, if SMSSendDriver isn't set, then there is no SMS column and no SMS
checkbox. However, the logic says that if there is a message_transport_type,
there should be a checkbox, and if there is not, there should be a hyphen.
Since there is no heading, this could cause layout issues for people without
the right message_transport_types.

It makes sense to use SMSSendDriver as the condition rather than the
message_transport_type...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9002] New: Remove Problematic Logic from Patron Messaging Preferences Form

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 9002
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: Remove Problematic Logic from Patron Messaging
Preferences Form
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: dc...@prosentient.com.au
  Hardware: All
Status: NEW
   Version: master
 Component: Patrons
   Product: Koha

If you do not have SMSSendDriver set and you do not have a
message_transport_type of "sms", you will get an extra table column filled with
a hyphen "-" and no corresponding table heading in the Patron Messaging
Preferences table.  

This pushes the table out of alignment so the email checkbox goes under
"Digests Only?", the digests checkbox goes under "Do not notify", and the Do
not notify checkbox is pushed to the side with no heading.

---

While this doesn't affect new installs, it might affect upgrades, unless the
upgrade scripts insert message_transport_type preferences.

---

In any case, it's a couple lines of useless code. It makes more sense to use
the same logic as TalkingTechItivaPhone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2832] Make alphabet localizable

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2832

Jared Camins-Esakov  changed:

   What|Removed |Added

Version|master  |rel_3_12

--- Comment #18 from Jared Camins-Esakov  ---
This feature will go into 3.12 since it introduces string changes and the 3.10
string freeze has already begun.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

--- Comment #12 from Jared Camins-Esakov  ---
Created attachment 13158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13158&action=edit
Bug 8846 conflict resolution: correct path

The test was moved since the original patch was written, making the
revised test fail. This patch corrects the mocked template patch so that
the test will pass.

To test:
1) Before applying patch, run
   `prove t/db_dependent/SuggestionEngine_ExplodedTerms.t`
2) Note that it fails.
3) Apply patch.
4) Run `prove t/db_dependent/SuggestionEngine_ExplodedTerms.t`
5) Note that it passes.
6) Celebrate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #12710|0   |1
is obsolete||

--- Comment #11 from Jared Camins-Esakov  ---
Created attachment 13157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13157&action=edit
Bug 8846: Exploded Terms test sneakily uses database

Even though there is no need for anything stored in the database for the
test, C4::Templates requires the database and a koha-conf.xml. The
solution is to mock all database- and koha-conf-using routines.

To test:
1) Stop MySQL
2) Unset KOHA_CONF
3) Run test

Signed-off-by: Kyle M Hall 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #24 from Nicole C. Engard  ---
(In reply to comment #17)
> So, everyone agree that we could just obsolete the two previous patches and
> reset bug status to pushed to master, leaving the two menu entries 'Delete
> all items' and 'Delete items in batch' ?

It does look that way - most people using it seem to prefer to keep both of
them.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #23 from Nicole C. Engard  ---
"We agree that keeping both buttons is the best option."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #22 from Nicole C. Engard  ---
"I second everything Cathi wrote.

Catherine Callegari, Director"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

SJeffery  changed:

   What|Removed |Added

 CC||steven_jeff...@fmi.com

--- Comment #21 from SJeffery  ---
We would prefer to keep the existing "delete all items" button as it is still
more efficient to use than the batch delete function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #20 from Nicole C. Engard  ---
Another:

I agree with keeping both buttons.  There is a time and place for both
depending on the permissions of the people needing those buttons and the task
at hand.  Those needing to use these buttons will not find them confusing.  If
functionality is already there and working well, why remove it and force users
to use features not intuitive to their task.  My vote is to keep the two
buttons.  Thanks for listening.

Cathi Wiggins
Arcadia Public Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #11558|0   |1
is obsolete||
  Attachment #11724|0   |1
is obsolete||

--- Comment #14 from Jared Camins-Esakov  ---
Created attachment 13156
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13156&action=edit
Bug 8519 - Make koha-index-daemon run on startup

[This patch was split out from tcohen's excellent patches for bug 8519
--jcamins 2012/10/31]

Added a new koha-index-daemon-ctl.sh script that uses the
'koha-index-daemon' provided by Koha::Contrib::Tamil (install via CPAN)
to process the indexing queue ('zebraqueue' for now, 'indexqueue' in the
future I guess :-P).

This script could be easily modified in the future for using another
index queue processing script (a more abstract indexing script for both Solr
and Zebra, etc). I removed all zebra-ish stuff from it.

Documentation patches will be provided as followups, once Mark Tompsett's
docs are pushed to avoid continous rebasing.

Tested to work on an up-to-date Ubuntu 12.04.

Sponsored-by: Universidad Nacional de Córdoba

Signed-off-by: wajasu 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9001] zebraqueue_daemon is deprecated and must go

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9001

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 13155
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13155&action=edit
Bug 9001: Remove Zebraqueue_daemon

[This patch was split out from tcohen's excellent patches for bug 8519
 --jcamins]

It removes the obsolete zebraqueue_daemon.pl and koha-zebraqueue-ctl.sh
obsolete scripts too.

Several files are modified to address te removal/addition of these files.

I didn't run the install procedure as I was working on my laptop with a dev
setup, just set the symlinks. Now fixed things as proposed by wajasu
on comment #4. Any other suggestion please let me know.

Tested to work on an up-to-date Ubuntu 12.04.

Asked by wajasu, remove remaining obsolete zebraqueue stuff.

Sponsored-by: Universidad Nacional de Córdoba

Signed-off-by: wajasu 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9001] zebraqueue_daemon is deprecated and must go

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9001

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9001] New: zebraqueue_daemon is deprecated and must go

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9001

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 9001
  Assignee: gmcha...@gmail.com
   Summary: zebraqueue_daemon is deprecated and must go
  Severity: critical
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8960] Typo 'Carnumber list' in modborrowers.tt

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8960

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8960] Typo 'Carnumber list' in modborrowers.tt

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8960

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8960] Typo 'Carnumber list' in modborrowers.tt

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8960

Nicole C. Engard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||neng...@gmail.com
Version|master  |rel_3_10
   Assignee|koha-b...@lists.koha-commun |neng...@gmail.com
   |ity.org |

--- Comment #2 from Nicole C. Engard  ---
String change, but it fixes a typo to a word that is on the page already and so
translated (I think).

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8960] Typo 'Carnumber list' in modborrowers.tt

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8960

--- Comment #1 from Nicole C. Engard  ---
Created attachment 13154
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13154&action=edit
Bug 8960: Fix typo on batch patron modify

Change Carnumber to Cardnumber.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #13152|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 13153
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13153&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

--- Comment #9 from Kyle M Hall  ---
On further view, I don't think it does solve the problem. I'll have to post a
followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

--- Comment #8 from Kyle M Hall  ---
This new patch solves the problem Chris brought up in comment 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #11089|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 13152
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13152&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000

--- Comment #1 from Owen Leonard  ---
I remember trying to work with this RSS feed generator years ago but I don't
think it's used anymore. As far as I know misc/cronjobs/rss can be removed
altogether.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Owen Leonard  changed:

   What|Removed |Added

  Attachment #12939|0   |1
is obsolete||

--- Comment #13 from Owen Leonard  ---
Created attachment 13151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13151&action=edit
[SIGNED-OFF] Bug 8942 Fix translation of JS strings containing simple/double
quote

With this patch, translated strings containing simple or double quotes
are escaped. This prevent breaking JavaScript strings.

For example:

  Today, translated in French is Aujourd'hui. And so this JS line:

var m = _('Today');

  become in French:

var m = _('Aujourd'hui');

  It breaks the whole JS code. With this patch:

var m = _('Ajourd\'hui');

Same issue with ", and JS strings like "foo".

Signed-off-by: Owen Leonard 

Confirmed that the example above is handled correctly after
applying the patch and generating a fresh set of French
templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9000] New: misc/cronjobs/rss/rss.pl uses HTP

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 9000
  Assignee: gmcha...@gmail.com
   Summary: misc/cronjobs/rss/rss.pl uses HTP
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

The file check misc/cronjobs/rss/rss.pl uses HTML::Template::Pro. It should
be converted to use Template::Toolkit, or, if it is a legacy script, removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8999] New: check misc/cronjobs/smsoverdues.pl uses H:T:P

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8999

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8999
  Assignee: gmcha...@gmail.com
   Summary: check misc/cronjobs/smsoverdues.pl uses H:T:P
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

The file check misc/cronjobs/smsoverdues.pl uses HTML::Template::Pro. It should
be converted to use Template::Toolkit, or, if it is a legacy script, removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8998] New: misc/migration_tools/koha-svc.pl has odd dependencies

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8998

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8998
  Assignee: gmcha...@gmail.com
   Summary: misc/migration_tools/koha-svc.pl has odd dependencies
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

The file misc/migration_tools/koha-svc.pl depends on File::Slurp, which is not
listed as a dependency. If the file is useful, this should be added as a
dependency. If not, the file should be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8997] Dead code in C4/Language causing useless SQL queries

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8997

Paul Poulain  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #2 from Paul Poulain  ---
Test plan:
 * apply patch
 * use Koha (with some languages activated on staff & OPAC)

=> you won't see any differences
(i've tested both Plack & CGI)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8997] Dead code in C4/Language causing useless SQL queries

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8997

--- Comment #1 from Paul Poulain  ---
Created attachment 13150
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13150&action=edit
Bug 8997: In C4/Language, getTranslatedLanguages calls getAllLanguage, passes
it to _build_languages_arrayref, that does nothing of it

removing this dead code will clean & reduce SQL overhead

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8997] New: Dead code in C4/Language causing useless SQL queries

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8997

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8997
  Assignee: paul.poul...@biblibre.com
   Summary: Dead code in C4/Language causing useless SQL queries
  Severity: major
Classification: Unclassified
OS: All
  Reporter: paul.poul...@biblibre.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: Architecture, internals, and plumbing
   Product: Koha

In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it to
_build_languages_arrayref, that does nothing of it

removing this dead code will clean & reduce SQL overhead

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #13069|0   |1
is obsolete||

--- Comment #9 from Jared Camins-Esakov  ---
Created attachment 13149
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13149&action=edit
Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix)

Patch re-done so it applies, had that double-utf8 problem

There was no entry in authority's record.abs for indexing chronological
terms. They couldn't be searched and (obviously) linked.

I've added those entries using the index names defined in
authorities/etc/bib1.att

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

--- Comment #2 from Kyle M Hall  ---
Created attachment 13148
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13148&action=edit
Bug 8943 - Add table sorting to labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #19 from Nicole C. Engard  ---
And another:

" I think only one button is necessary."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #18 from Nicole C. Engard  ---
Another comment from a librarian using Koha: 

"I agree. When there is a ‘’delete items in  batch’’ button, we do not need
‘’delete all items’’ option any more."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8996] In result page items with negative notforloan are available

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

Owen Leonard  changed:

   What|Removed |Added

  Attachment #13145|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 13147
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13147&action=edit
[SIGNED-OFF] Bug 8996: In result page items with negative notforloan are
available

Signed-off-by: Owen Leonard 

--- Before ---

4 items, 2 available:

Athens [YA Taylor] (2)
Circulating

2 unavailable:

Athens [YA Taylor] Download (1)
Circulating
The Plains [YA Taylor] Staff Collection (1)
Circulating

--- After ---

4 items, 1 available:

Athens [YA Taylor] (1)
Circulating

3 unavailable:

Athens [YA Taylor] Ordered (1)
Circulating
Athens [YA Taylor] Download (1)
Circulating
The Plains [YA Taylor] Staff Collection (1)
Circulating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8996] In result page items with negative notforloan are available

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #17 from Julian Maurice  ---
So, everyone agree that we could just obsolete the two previous patches and
reset bug status to pushed to master, leaving the two menu entries 'Delete all
items' and 'Delete items in batch' ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8989] Availability facet needs an id

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989

--- Comment #2 from Owen Leonard  ---
I didn't add anything to the default CSS because as far as I can tell the limit
to available feature isn't working perfectly but is working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8989] Availability facet needs an id

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989

--- Comment #1 from Owen Leonard  ---
Created attachment 13146
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13146&action=edit
Bug 8989 - Availability facet needs an id

This patch adds an id to the  which contains
the "limit to available" facet in the OPAC and
staff client.

To test, add custom CSS for the staff client and
OPAC to hide the id "availability_facet" and
confirm that the link is no longer visible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8989] Availability facet needs an id

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8989] Availability facet needs an id

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8989

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #20 from Julian Maurice  ---
Yes you are probably right.
I reset status to Assigned and will send a follow up soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Owen Leonard  changed:

   What|Removed |Added

Summary|limit to available not  |Limit to available does not
   |limiting anymore|exclude in-transit items
   Severity|critical|normal

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8996] In result page items with negative notforloan are available

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

--- Comment #2 from Fridolyn SOMERS  ---
Created attachment 13145
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13145&action=edit
Proposed patch

Small patch.

Test with an item with notforloan < 0.
Without patch, it is available.
With patch, it is unavailable and notforloan description is displayed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8978] Patron's dateexpiry is erroneously updated if dateexpiry in UnWantedField syspref

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8978

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr
   |ity.org |
 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8978] Patron's dateexpiry is erroneously updated if dateexpiry in UnWantedField syspref

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8978

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart  ---
QA Comment:

Good catch !

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8982] koha-create rejects --database option

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8982

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |m...@software.coop
   |ity.org |
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
QA Comments:
I didn't test but it looks good.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8996] In result page items with negative notforloan are available

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

--- Comment #1 from Fridolyn SOMERS  ---
On intranet result page, items with notforloan < 0 are available.
But this negative value is used when item is on order.
It should be unavailable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8996] In result page items with negative notforloan are available

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

Fridolyn SOMERS  changed:

   What|Removed |Added

Summary|In result page, |In result page items with
   ||negative notforloan are
   ||available

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8996] New: In result page,

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8996
CC: gmcha...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: In result page,
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: fridolyn.som...@biblibre.com
  Hardware: All
Status: NEW
   Version: master
 Component: Staff Client
   Product: Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org
 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #8 from Jonathan Druart  ---
QA Comments:

Easy fix, just one 
:

I think this line could be removed in the review.pl file
  approved => 0,# dummy value (also EXPR)

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #16 from Nicole C. Engard  ---
I figured my opinion doesn't matter as much as the opinion of the librarians so
I solicited some feedback. Here's the first answer I got:



Hi, Nicole--

I use "Delete all items" (from the "Edit" menu on a record) all the time when
weeding. When looking at the details for a record, I can verify the barcode(s),
verify that I have the correct item(s), and then it's just easy enough to click
through everything to delete all items and the bib record, but without being
*too* easy!:)

I would absolutely hate to have to move off of the record to go into a Batch
Item Deletion for weeding--I would have to verify that I'm deleting the correct
items all over again, and go into an area in the catalog that is not needed for
normal cataloging & technical services operations.

Also, frankly, we don't find Batch Item Deletion useful for weeding or much of
anything else--we never use it. The search interface is cludgy, compared to
just tweeping a barcode in the Advanced Search screen (where one can select the
barcode index), or just searching for the title if the entire title and all its
items are being weeded. If certain items are being weeded off of a title, we
think this should be done very carefully, and is best done via the Edit Items
function off of the record where we can see all the items, and use the "find"
function of the browser with our barcode reader to locate the correct item for
deletion, which is very fast--but not *too* fast! It's just, "tweep!" "click"
(then the next item on the title, etc.)

Chris Cormack's comment, "I agree, I might want to just delete all items from a
record, I dont want to have to go and batch delete it, im already on the record
:)" is right on the money, IMO.

If people really want to go to Batch Item Deletion from the record display in
the staff client, it's just three clicks away ("More," "Tools," "Batch item
deletion"). If people really like to have it handy, they can just have a tab in
their browser opened to it, no?

I really, really hope that everything is either left as is, or one will be able
to choose to reveal a link to Batch Item Deletion in the "Edit" menu--or
not--in the Koha Administration.

Thanks,
heather

P.S. Feel free to share my comments on the Bugzilla or anywhere. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801

--- Comment #15 from Owen Leonard  ---
(In reply to comment #13)
> I agree, I might want to just delete all items from a record, I dont want to
> have to go and batch delete it, im already on the record :)

I second this. The immediacy of the "delete all items" option is useful and
familiar to current users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
Version|rel_3_8 |rel_3_10

--- Comment #7 from Nicole C. Engard  ---
If this can go in to 3.10 and 3.8 that would be awesome!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #13118|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8707] tags always say approved

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707

--- Comment #6 from Nicole C. Engard  ---
Created attachment 13144
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13144&action=edit
[SIGNED-OFF] Bug 8707 - tags always say approved

Template scope error caused an incorrect state on the
approval/rejection buttons when viewing rejected tags.

To test, go to Tags and view the list of rejected tags.
In the "Actions" column, the "rejected" button should be
greyed out, and the "approve" button active.

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5521] item edit form appears if no items found

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5521] item edit form appears if no items found

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #13117|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 13143
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13143&action=edit
[SIGNED-OFF] Bug 5521 - item edit form appears if no items found

This patch changes the template so that if no items are
found the page doesn't show "The following barcodes were found"
and doesn't show the item edit form.

To test, submit a batch which contains no valid barcodes.
Compare to a batch which contains some or all valid barcodes.

Signed-off-by: Nicole C. Engard 
All tests succeed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #13134|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 13142
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13142&action=edit
Bug 8992: Interfacing with the Idref webservice

On the detail page (in the opac), if the biblio comes from the Sudoc,
you must have a link (on the right of the author link) which open a popup with
informations about this author (publications by role).

To test:

1/ Switch on the Idref system preference

2/ Simulate a SUDOC record:
  Fill a 7..$3 field with a ppn (032581270 for example).
  Fill the 009 field with an integer

3/ Go to the opac detail page of this notice.
You should see the IDREF link.
If you click on it, a popup displays a loading icon and after a few
seconds (depending of the productivity of the authority :)), a list of
roles. For each role, a table displays all his corresponding publications.

4/ On the right, you have 2 links: 1 for a koha search for this result
and 1 for a SUDOC link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

--- Comment #3 from Jonathan Druart  ---
(In reply to comment #2)

> Wouldn't it be much better to include the necessary changes in your patch?

Yes, of course.
I will propose a new patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #1 from Julian Maurice  ---
Created attachment 13141
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13141&action=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled. Changes are made for
UNIMARC and MARC21 xslt.

Note: this patch also moves the Babeltheque code outside an if
statement "if (C4::Context->preference('COinSinOPACResults'))" (was
misplaced because Babeltheque don't need COinS)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] New: Show OpenURL links in OPAC search results

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8995
  Assignee: julian.maur...@biblibre.com
   Summary: Show OpenURL links in OPAC search results
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: julian.maur...@biblibre.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: OPAC
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #13140|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Jonathan Druart  ---
(In reply to comment #2)

> Not sure if this is a real error or whether I made a mistake in merging?

Maybe both :)
The merge was not easy to resolve and errors exist in the previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740

--- Comment #7 from Kyle M Hall  ---
Created attachment 13140
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13140&action=edit
Bug 7740 - Highlight items in own library in search results/detail page in OPAC
[v3.08.03]

This feature enables a particular library's items to be emphasized and moved
to the first position on the search results and details pages of the OPAC.

It is enabled by the sytem preference HighlightOwnItemsOnOPAC.

To choose which branches items are emphasized, use the system preference
HighlightOwnItemsOnOPACWhich. It has two modes.

If set to PatronBranch, the items emphasized will be those of the same
library as the patron's library. If no one is logged into the opac, no
items will be highlighted.

If set to OpacURLBranch, the library is chosen based on the Apache
environment variable BRANCHCODE.

For example, this could be added to the OPAC section of koha-httpd.conf:
SetEnv BRANCHCODE "CPL"

The point of this feature is to allow each library on a given Koha server
to have a specific subdomain for the opac where that library's items are
empasized. That was http://branch1.opac.mylibrary.org will emphasize the
items of branch1, while http://branch2.opac.mylibrary.org will emphasize
the items of branch2.

Conflicts:

installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/opac-tmpl/prog/en/css/opac.css
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2012-10-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #12130|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 13139
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13139&action=edit
Bug 8367: Add more granular level for ReservesMaxPickUpDelay

This patch adds:
- a new column in the issuing rules
- a new field issuingrules.holdspickupdelay

You can now specify a pickup delay for an hold function of a patron
category and/or a item type and/or a library.

To test:
Check there is no regression with a normal reserve workflow.
Add one or more issuingrules.
In 4 templates, you can see the max pickup delay for an hold
(circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt,
opac-user.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >