[Koha-bugs] [Bug 8757] Longer size text for authorised values description

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Summary|Longer size text for|Longer size text for
   |authorised values lib |authorised values
   ||description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Summary|Items on Hold Lose Transfer |Items on hold lose transfer
   |After Being Scanned Twice   |after being scanned twice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9091] Error in logic CheckBorrowerDebarred

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
debarred is now a date field in the database (connected to the fines in days
feature) - which version are you looking at?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch cannot work.

the following line is wrong:
if( undef $run_as_root and $run_user eq 'root')

undef $run_as_root is always false.

You wanted write
if ( not defined $run_as_root and $run_user eq 'root' )

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #63 from Magnus Enger mag...@enger.priv.no ---
(In reply to comment #62)
 Created attachment 13473 [details]
 Bug 9066: VirtualShelves db access not Plack+MariaDB compatible

Is this patch on the right bug, Mason?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
I changed for a 'CheckValidity' option.
When present in LinkerOptions, the authorities found by linker will be checked
for validity by comparing a to z subfields values between authority field and
biblio field.

This is based on C4::Biblio-_check_valid_auth_link behavior. I could not use
this method because like said in method comment, this method can not be moved
and I could not add a dependency to C4::Biblio in C4::Linker::Default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13481
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13481action=edit
Proposed patch (main)

Patch adding CheckValidity option.

Small other changes :
In C4::AuthoritiesMarc-GetAuthorizedHeading() : a 'k' was missing in a to z
list.
In C4::Biblio__check_valid_auth_link() : I added test of strings used in equal
to avoid warning in logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13482
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13482action=edit
Proposed patch (follow-up 1)

Follow up patch containing only perltidy formatting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #21)

Hi Koha Team Lyon 3,

 May I remove them in this patch or has it to be done in a separate patch ?

It is better in a new patch.

 There's actually a bunch of tabulations that were still there before my patch 
  (lines 157-220) and that are still there in master.

All new patches have to respect some guidelines.
One of them is to not introduce new tabulation characters.
So if a patch add a new line (+ in the git diff) cannot contain a tab.

This issue is not blocker but the 2 others are.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7247] rebuild_zebra.pl -v should show all Zebra log output

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7247

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7247] rebuild_zebra.pl -v should show all Zebra log output

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7247

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7847] OPAC search dies with plack

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #13341|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13483
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13483action=edit
Proposed patch (follow-up 2)

Small additional correction :
GetAuthorizedHeading was missing in exported methods of C4::AuthoritiesMarc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #6)
 Created attachment 13483 [details]
 Proposed patch (follow-up 2)
 
 Small additional correction :
 GetAuthorizedHeading was missing in exported methods of C4::AuthoritiesMarc.

This export was present in Bug 7475 (Teach matching rules to handle
authorities) but was removed, certainly unwanted, by Bug 8523 (Display auth
hierarchies w/all marcflavours).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] New: 'Welcome mail' for new library users

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

Bug ID: 9097
   Summary: 'Welcome mail' for new library users
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

One of our libraries asked, if Koha can send a welcome mail to new patrons.
Ideally this would be an option in the patron account, so a mail can by the
librarian to the patron whenever the registration process is completed at the
circulation desk.
The email could include important information about how to use the library,
loan periods, services etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #178 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #177)
 Below is the log of my testing.

Hi Chris,
Thank you very much for testing :)

 - BUG: Koha fails to pick up on the version change, and I am taken to
 mainpage.pl

Yes, a line has to be replaced by the RM when this patch will be pushed (see
installer/instal.pl l.323 to set $koha39 with your last (+1) version number.

 - Tested install of updates by clicking Update All. The PL file applied
 fine while the SQL file failed due to some SQL syntax error.
 - Text of error as displayed in the interface: update_sample -- Error :
 1064 = You have an error in your SQL syntax; check the manual that
 corresponds to your MySQL server version for the right syntax to use near
 'INSERT INTO `systempreferences` VALUES ('TestSyspref3','2','set the level
 of err' at line 2;
 - BUG: A quick look at the SQL file shows that the SQL for the complex
 example is correct; I'm assuming that there is a bug in the updater code.

I can't reproduce that. Could you provide your test files please?

 - BUG: I was not given the option of marking the aforementioned update as
 applied and consequently could not navigate away from the updater interface.
 This was unexpected behavior to me, as I would have expected to be able to
 return to normal operation of the staff interface in spite of the update
 failing. This probably needs to be added. If we do not want to permit
 forcing of this sort of thing, we should offer the user the option of
 completeing the updates at a later time perhaps setting a highly visible
 notification on the staff homepage to that effect. In any case, a more
 graceful recovery should be possible since we don't know the circumstances
 surrounding the user when such failure occurs.

If a .pl file raises an error (here a syntax error), the queries are not
executed (inevitably). So there are no entry in the sql tables and we don't
know the history of this file. On master, the RM will not push an
unexecutable file; on a dev install the developper will know what happen and
will have to fix that (a simple way is to remove or move the file out of the
versions directory).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
AutoEmailOpacUser will only work, if you create a new patron from scratch and
finish the registering process in one session. If you use patron data import no
mails are sent out when the account is created. If I understood correctly the
library wanted an option to do it manually or when actually activating an
account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9098] New: Replace tabulations by spaces in opac-user.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9098

Bug ID: 9098
   Summary: Replace tabulations by spaces in opac-user.pl
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: k...@univ-lyon3.fr

The file was indented with tabulations from line 153 and a bunch of following
ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9098] Replace tabulations by spaces in opac-user.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9098

--- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 13484
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13484action=edit
Replace tabulations by spaces in opac-user.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9098] Replace tabulations by spaces in opac-user.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9098

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #13484|0   |1
is obsolete||

--- Comment #2 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 13485
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13485action=edit
Replace tabulations by spaces in opac-user.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #4)
 With the sample data, there are 5 staff patrons defined (or so - I had 6 but
 I believe I added one more). This tool, when asked to delete staff patrons,
 indicated there were no patrons that met the criteria of category: staff.
 The other categories worked as expected.
 
 Can this tool not delete staff patrons? Is that by design? If it is by
 design, then that categorycode needs to be removed from the list.

That is correct. It has never been able to delete staff patrons. I would assume
that was a 'safety' feature.

I'll add a followup to remove staff from the list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9099] New: Checked-in barcode export should not send empty file

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099

Bug ID: 9099
   Summary: Checked-in barcode export should not send empty file
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a patron has no checked-in barcodes to export, Koha should not prompt to
download an empty file. The pop-up window should instead give a message saying
there are none.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13486
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13486action=edit
Bug 6261 - Consolidate patron toolbar include files

The staff client has two almost identical include files which
can be consolidated: circ-toolbar.inc and members-toolbar.inc.
This patch marges the slight differences between them and
eliminates circ-toolbar.inc, that being the one which was used
on fewer pages.

In order to accommodate the different destination variable
for operations which redirect back either to circ or patrons,
circulation.pl defines destination in the template.

To test, perform various operations from the toolbar on different
patron-related pages.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #13481|0   |1
is obsolete||
  Attachment #13482|0   |1
is obsolete||
  Attachment #13483|0   |1
is obsolete||

--- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13487
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13487action=edit
Proposed patch (main)

I revized patch for performance and for a more clear syntax.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #9 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #8)
 Created attachment 13487 [details]
 Proposed patch (main)
 
 I revised patch for performance and for a more clear syntax.

Patch adding CheckValidity option.
+ Search for linked authorities can return more that 20 results, I set a max of
1 (in C4::Heading-_search).
+ In C4::AuthoritiesMarc-GetAuthorizedHeading() : a 'k' was missing in a to z
list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13488
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13488action=edit
Proposed patch (follow-up 1)

Perltidy formatting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #11 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13489
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13489action=edit
Proposed patch (follow-up 2)

Avoid null for string compare in C4::Biblio::_check_valid_auth_link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072

--- Comment #12 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13490
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13490action=edit
Proposed patch (follow-up 3)

Missing method export in C4::AuthoritiesMarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #179 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to comment #178)
  - BUG: Koha fails to pick up on the version change, and I am taken to
  mainpage.pl
 
 Yes, a line has to be replaced by the RM when this patch will be pushed (see
 installer/instal.pl l.323 to set $koha39 with your last (+1) version number.

I'll test this out today.

  - Tested install of updates by clicking Update All. The PL file applied
  fine while the SQL file failed due to some SQL syntax error.
  - Text of error as displayed in the interface: update_sample -- Error :
  1064 = You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use near
  'INSERT INTO `systempreferences` VALUES ('TestSyspref3','2','set the level
  of err' at line 2;
  - BUG: A quick look at the SQL file shows that the SQL for the complex
  example is correct; I'm assuming that there is a bug in the updater code.
 
 I can't reproduce that. Could you provide your test files please?

I used the included sample files:

installer/data/mysql/versions/update_sample.pl.sample
installer/data/mysql/versions/update_sample.sql.sample

 
  - BUG: I was not given the option of marking the aforementioned update as
  applied and consequently could not navigate away from the updater interface.
  This was unexpected behavior to me, as I would have expected to be able to
  return to normal operation of the staff interface in spite of the update
  failing. This probably needs to be added. If we do not want to permit
  forcing of this sort of thing, we should offer the user the option of
  completeing the updates at a later time perhaps setting a highly visible
  notification on the staff homepage to that effect. In any case, a more
  graceful recovery should be possible since we don't know the circumstances
  surrounding the user when such failure occurs.
 
 If a .pl file raises an error (here a syntax error), the queries are not
 executed (inevitably). So there are no entry in the sql tables and we don't
 know the history of this file. On master, the RM will not push an
 unexecutable file; on a dev install the developper will know what happen and
 will have to fix that (a simple way is to remove or move the file out of the
 versions directory).

Ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9091] Error in logic CheckBorrowerDebarred

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091

Fred P fred.pie...@smfpl.org changed:

   What|Removed |Added

 CC||fred.pie...@smfpl.org

--- Comment #2 from Fred P fred.pie...@smfpl.org ---
I believe this is a legacy data issue. New patrons are given a debarred date of
12-31-, debarred patrons are assigned a specific debarred date, while
legacy patrons retain a [NULL] for debarred status in the borrowers table. 

Custom scripts will need to address these three possibilities.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13449|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13491
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13491action=edit
Bug 9076 - Add ability to delete borrowers by expiration date and category code
to cleanborrowers.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13450|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13492
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13492action=edit
Bug 9076 - Followup - Perltidy cleanborrowers.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #180 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to comment #179)
 (In reply to comment #178)
   - BUG: Koha fails to pick up on the version change, and I am taken to
   mainpage.pl
  
  Yes, a line has to be replaced by the RM when this patch will be pushed (see
  installer/instal.pl l.323 to set $koha39 with your last (+1) version number.
 
 I'll test this out today.

This still does not work for me.

1. Kohaversion shown in the staff interface is 3.9.0.65 with the following
database revisions applied: bug_1234_2 update_sample update_sample_2

2. kohaversion.pl is our $VERSION = '3.09.00.066';

3. version in database is 3.0900065

4. installer/install.pl line 323 is my $koha39 = 3.0900066;

I am still not redirected to the webinstaller to run updatedatabase.pl.

Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9061] DataTables date sort does not work with date in uk format (dd/mm/yyyy)

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9061] DataTables date sort does not work with date in uk format (dd/mm/yyyy)

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13493
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13493action=edit
Bug 9061 - DataTables date sort does not work with date in uk format
(dd/mm/)

The DataTables plugin doesn't include native support for sorting date
in uk/euro format (dd/mm/). This patch adds a plugin to be
optionally included in cases where the Koha dateformat preference
is set to metric.

The patron circulation history page is the only page affected by this
patch. If it is found to be working well I will submit follow-ups
to cover other instances where sorting by date occurs.

To test, load the patron circulation history page (members/readingrec.pl)
for a patron with a circulation history. Sorting by date, checked out
on, date due, and Return date should work correctly with under
all three dateformat settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #181 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #180)
 4. installer/install.pl line 323 is my $koha39 = 3.0900066;
 
 I am still not redirected to the webinstaller to run updatedatabase.pl.

Checking if you need to updatedatabase cost much more than previously, so it's
done only on mainpage.pl
Could it be because you're not looking at mainpage.pl ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9053] Test::MockModule and DBD::Mock should be required

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9053

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #7 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6428] refered column 'items.coded_location_qualifier' does not exist

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428

--- Comment #38 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8915] Referential integrity constraints and InnoDB vs MyISAM storage engine

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #182 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to comment #181)
 (In reply to comment #180)
  4. installer/install.pl line 323 is my $koha39 = 3.0900066;
  
  I am still not redirected to the webinstaller to run updatedatabase.pl.
 
 Checking if you need to updatedatabase cost much more than previously, so
 it's done only on mainpage.pl
 Could it be because you're not looking at mainpage.pl ?

Navigating directly to cgi-bin/koha/mainpage.pl does not redirect me to the
webinstaller.

Interestingly enough: adding a 'die' at 322 in installer/install.pl has no
effect, so it appears that we're never getting to that block of code.

I'll look somemore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9036] 00-load.t checks Koha::Cache::Memcached when it should not

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036

--- Comment #8 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9054] 00-load should not try to load modules with optional dependencies

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9054

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8892] Plack variable scoping in basket.pl

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8892

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #183 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to comment #182)
 (In reply to comment #181)
  (In reply to comment #180)
   4. installer/install.pl line 323 is my $koha39 = 3.0900066;
   
   I am still not redirected to the webinstaller to run updatedatabase.pl.
  
  Checking if you need to updatedatabase cost much more than previously, so
  it's done only on mainpage.pl
  Could it be because you're not looking at mainpage.pl ?
 
 Navigating directly to cgi-bin/koha/mainpage.pl does not redirect me to the
 webinstaller.
 
 Interestingly enough: adding a 'die' at 322 in installer/install.pl has no
 effect, so it appears that we're never getting to that block of code.
 
 I'll look somemore.

Mystery solved!

C4/Auth.pm line 588 must also have the correct version set. After I corrected
this line, I was correctly redirected to the webinstaller for the dummy update
using the old system.

That leaves only the issue with the complext SQL file example to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8945] Koha 3.10 Help Files Update

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8945

--- Comment #65 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9050] rebuild_zebra should use the adelete action so it doesn't fail when deleting a record not in the index

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9039] Tests in the basic test suite should only test code based on required dependencies/modules

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9039

--- Comment #7 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500

--- Comment #39 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8968] JavaScript String not translatable

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8968

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to branch 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9090] Cannot add item without barcode

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9090

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
This does not appear to be a problem in master with the standard sample data.
I'll have to do some more digging and see if this is possibly an interaction
with other system settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9090] Cannot add item without barcode

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9090

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9012] Allow bulkmarcimport to specify a framework code when importing MARC

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9012

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||me...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9061] DataTables date sort does not work with date in uk format (dd/mm/yyyy)

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13493|0   |1
is obsolete||

--- Comment #2 from Melia Meggs me...@bywatersolutions.com ---
Created attachment 13494
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13494action=edit
[Signed off] Bug 9061 - DataTables date sort does not work with date in uk
format (dd/mm/)

The DataTables plugin doesn't include native support for sorting date
in uk/euro format (dd/mm/). This patch adds a plugin to be
optionally included in cases where the Koha dateformat preference
is set to metric.

The patron circulation history page is the only page affected by this
patch. If it is found to be working well I will submit follow-ups
to cover other instances where sorting by date occurs.

To test, load the patron circulation history page (members/readingrec.pl)
for a patron with a circulation history. Sorting by date, checked out
on, date due, and Return date should work correctly with under
all three dateformat settings.

Signed-off-by: Melia Meggs me...@test.bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9061] DataTables date sort does not work with date in uk format (dd/mm/yyyy)

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||me...@bywatersolutions.com

--- Comment #3 from Melia Meggs me...@bywatersolutions.com ---
To test, I set dateformat to dd/mm/.

Before applying patch, the patron's circulation history showed in this date
order:
12/03/2012 (March 12, 2012)
13/09/2012 (September 13, 2012)
14/06/2012 (June 14, 2012)

After applying the patch, the patron's circulation history was correctly
ordered by date.  I also checked that checked out on, date due, and return
date all sort in correct date order as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13138|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13495
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13495action=edit
[SIGNED-OFF] Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 CC||elli...@bywatersolutions.co
   ||m

--- Comment #6 from Elliott Davis elli...@bywatersolutions.com ---
Waylon,

Just as a jump in comment I applied the patch and attempted to test and found
that the way this patch is trying to solve the problem seems overly complex. 
Perhaps if we could consolidate the 3 sysprefs into 1 and add a more detailed
testing plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12361|0   |1
is obsolete||

--- Comment #70 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13496
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13496action=edit
Bug 8215 - Course Reserves

Adds a course reserves system for academic libraries.

The course reserves system allows libraries to create courses
and put items on reserves for those courses.

Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.

Signed-off-by: wajasu matted-34...@mypacks.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12413|0   |1
is obsolete||

--- Comment #71 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13497
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13497action=edit
Bug 8215 - Add Course Reserves - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12414|0   |1
is obsolete||

--- Comment #72 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13498
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13498action=edit
Bug 8215 - Add Course Reserves - QA Followup - Hide itemtype modification for
bib-level itemtypes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12593|0   |1
is obsolete||

--- Comment #73 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13499
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13499action=edit
[SIGNED-OFF] Bug 8215 follow-up encoding for branches  itemtypes

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9088] Default values for fund and item type on neworderempty form

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #3 from Melia Meggs me...@bywatersolutions.com ---
I applied this patch.  

Before the patch, when doing a new order, I have to select the item type and
fund.

After the patch, I set the AcqNewOrderEmptyDefaults system preference to
fund=BOOKS.  When I did a new order, I found that the BOOKS fund was correctly
filled in by default and can still be changed if necessary using the dropdown
menu of funds.

However, I can't get it to work for an item type.  I set AcqCreateItem to
create an item when placing an order.  I tried placing itemtype=BOOK in the
AcqNewOrderEmptyDefaults system preference, but the y - Koha item type box is
still blank by default, which means I have to choose the item type from the
dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9087] In Search.pl if there is parenthesis in itemcallnumber the link is broken

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9087

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #2 from Melia Meggs me...@bywatersolutions.com ---
I wanted to test this, but I can't seem to reproduce that error message on
master.

I did a search for an item that has call number [AR EUch (Thu) 1974], but I
don't get any error message when I click on it in the staff client or the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status

2012-11-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

--- Comment #14 from Nicole C. Engard neng...@gmail.com ---
The images on the search results for open library are still pretty tiny - can
we update those to be somewhere between the size that's there now and the size
that's on the detail page?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/