[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- After reflexion, I think it is no good idea to have an automatic quote escape. For example, if you have a single quote in a double quote string (or opposite) : _(Aujourd'hui) will become _(Aujourd\'hui), the backslash will be displayed. Also, like Marcel example, there might be problems with HTML added in JS. For example : $(#id).html(span title=\ + _(Dangerous) + \ /) will generate span title=Dangerous / In this case, the translation must not contain a double quotes, even escaped: $(#id).html(span title=\ + _(\Danger\) + \ /) will generate span title=Danger /, bad HTML. I've looked at http://wiki.koha-community.org/wiki/Coding_Guidelines. In JavaScript section, double quotes are always used : _(xxx). Looking at code, double quotes are used 2629 time and single quotes only 143 times. So if we always use double quotes, single quotes are not a problem anymore and it was the main problem (it is often used in French). I've looked at French PO, double quotes are actually never used in JavaScript translation ; it can be managed one by one. I've looked at old version of calendar, it used double quotes, that's why there was no problem with Today = Aujourd'hui. I will propose a patch for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942
--- Comment #17 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13756
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13756action=edit
Proposed patch (main)
Main patch : replace _('xxx') by _(xxx).
Except when written into HTML : onclick=... _('') ..., see follow-up patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #117 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #116) Owen, do you think you could push your branch to gitorious (or somewhere)? I still can't seem to apply this, so I'll just cherry-pick directly off your branch. Hi Jared, It's my fault, I proposed a dirty followup to avoid to resubmit an already signed-off patch. So the last patch just moves the new database entry to the end of the file. I pushed the branch with a new last patch in our git repository: http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/ft/Bug7067 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #13756|Proposed patch (main) |Always use double quotes : description||main patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942
--- Comment #18 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 13757
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13757action=edit
Always use double quotes : follow-up 1
Follow-up 1 :
In some places, a JavaScript string concatenation exists into translated string
:
_('Are you sure you want to delete the ' + count + ' attached items? ')
This does not work (see coding gidelines).
This patch corrects by using 2 translations :
_(Are you sure you want to delete the) + + count + + _(attached
items?)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #19 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 13758 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13758action=edit Always use double quotes : follow-up 2 Follow-up 2 : Move occurrences of JavaScript translated string from HTML to JavaScript block. The better way is to store translated JavaScript strings into a var : var MSG_NO_ITEM_SELECTED = _(Nothing is selected.); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 --- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 13759 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13759action=edit [3.6.x] Proposed patch Patch for 3.6.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8390] Place hold button is missing from the MARC view page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8390 Bug 8390 depends on bug 8481, which changed state. Bug 8481 Summary: Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 --- Comment #9 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 13760 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13760action=edit [3.6.x] Proposed patch Patch for 3.6.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Priority|P5 - low|P1 - high Change sponsored?|--- |Sponsored Assignee|gmcha...@gmail.com |vfernan...@keep.pt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi all, this is a critical bug in 3.10 - it would be awesome if someone could test and sign-off on this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7339] Help System in IE8 Does Not Load With 500 Error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|Help System in IE7-8 Does |Help System in IE8 Does Not |Not Load With 500 Error |Load With 500 Error --- Comment #15 from Owen Leonard oleon...@myacpl.org --- I managed to finally test this in IE7, and it doesn't look like this bug affects it anymore. On the other hand, help in IE7 doesn't load the right help page either (always the Okay I can log in) page. But it's probably time to give up on IE7 anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 --- Comment #2 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 13761 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13761action=edit BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Added a new system preference to set the UNIMARC field 100 default language. The default value for that system preference is 'fre'. Changed Biblio.pm to use the system preference: - if the language is bad filled in the preferences it uses 'fre' as default value - only replaces the language when the field 100 is empty - if the language is filled with the plugin only replaces the positions 25-28 to 'y50' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13762 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13762action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #13762|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13763 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13763action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #13601|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13764 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13764action=edit Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com The following queries show us the issues: select count(*) from items; select * from aqorders_items where ordernumber=XX; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13744|0 |1 is obsolete|| Attachment #13745|0 |1 is obsolete|| Attachment #13746|0 |1 is obsolete|| Attachment #13747|0 |1 is obsolete|| Attachment #13748|0 |1 is obsolete|| --- Comment #118 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13765 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13765action=edit Bug 7067 - OPAC Borrower Self Registration This development will add the ability for a new patron to register himself or herself. The self-registration will attempt to match this newly inputted data to any existing patrons and if any possible matches are found, ask if the patron is sure he or she doesn't already have an account at the library. A system preference may be set to prevent patron self-registration if the system detects the possibility that the person may already have an account. Once the patron has registered, passing a captcha (or similar bot-stopper), the patron will then be optionally verified a second time via email. At this point, the patron will be able to print a temporary library card (optional by system preference), and will be provided any details necessary to access electronic resources (this body of text would be a template in the slips and notices system). At the library's choice, this new patron would either be set to a temporary patron status (patron type set via system preference), or a fully-fledged patron (allow patron type to be determined by age and/or other attributes). Assuming the library uses temporary patron types for OPAC registrations, this patron will next enter a queue and would need to physically enter the library to verify himself and become a fully-fledged patron (most likely by bringing in physical proof of address, etc.). The librarian would look up the patron record and modify the patron type. If a temporary patron has not been verified within a certain time frame (defined by a system preference), the patron record will be deleted from the system via a cron job. For registered patrons, the system will allow each person to also update his or her personal data via the OPAC. When a patron updates his or her information, the changes will be entered into a queue to be verified by a librarian (preventing a patron from inputting obviously bogus data). The staff client home page will display the number of patron records with changes awaiting approval. A librarian would then be able to click through a list of modification requests, and approve or deny each (with approval and denial alerts being sent to the patron via the standard messaging system). NEW SYSTEM PREFERENCES * PatronSelfRegistration * PatronSelfRegistrationDetectDuplicates * PatronSelfRegistrationVerifyByEmail * PatronSelfRegistrationPrintTemporaryCard * PatronSelfRegistrationUseTemporaryStatus * PatronSelfRegistrationExpireTemporaryAccountsDelay NEW NOTICE * Verify by email notice NEW SLIP * Temporary card slip NEW CRON JOB * delete_expired_opac_registrations.pl - Deletes patrons that have not been upgraded from the temporary status within the specified delay * delete_unverified_opac_registrations.pl - Deletes the unverified patrons based on the length of time specified in the PatronSelfRegistrationExpireTemporaryAccountsDelay The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are. Test Plan: 1) Enable PatronSelfRegistration 2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number of days 3) Create a self-registered borrower category 4) Set PatronSelfRegistrationUseTemporaryStatus 5) Set PatronSelfRegistrationVerifyByEmail to Don't require 6) Go to OPAC, log out if logged in. 7) You should see the Register here link below the login box 8) Attempt to register yourself 9) Verify you can log in with your temporary password. 10) Set PatronSelfRegistrationVerifyByEmail to Require 11) Attempt another self-registration 12) Check the messages table, you should see a new message with a verification link. 13) Copy and paste the link into a web browser to verify the registration 14) Log in with the given credentials to verify the account was created. Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to my personal details tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #119 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13766 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13766action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts * Add required fields check for editing exiting patrons * Don't force require email address for existing patrons when PatronSelfRegistrationVerifyByEmail is enabled. Signed-off-by: Owen Leonard oleon...@myacpl.org Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #120 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13767 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13767action=edit Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #121 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13768 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13768action=edit Bug 7067: Followup FIX QA fails Signed-off-by: Owen Leonard oleon...@myacpl.org Fixed minor conflict in C4/Installer/PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #122 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13769 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13769action=edit Bug 7067 [5] Followup FIX merge updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8032] Sort lists by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Small patch --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comment: This patch adds a new sort for lists. Add/edit a list and set the sort value to callnumber. The results (opac and intranet) are sorted by callnumber. The patch works as expected. The patch uses an existed esoteric way to pass the sort parameter to the templates (sort_$sort = 1 or author_sort = 1 if $sort eq 'author'), it would be great to standardize this stuff. It is not the goal of this patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8032] Sort lists by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] New: OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Bug ID: 9166 Summary: OPAC needs configuration file for datepicker Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-reserve.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org Blocks: 7261 In the staff client we have a configuration file for the datepicker which not only lets us load defaults for all instances but also includes the translated text for localization. The OPAC needs this too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7261] System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Depends on||9166 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- This bug blocks Bug 7261 because it is through the configuration file that the CalendarFirstDayOfWeek preference is applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 13770 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13770action=edit Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8856] Details section of cart always displays 59
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8856 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Please re-open if you can show that this error can be reproduced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] New: The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 Bug ID: 9167 Summary: The sort field copyrightdate is not standardized Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com CC: m.de.r...@rijksmuseum.nl At the OPAC, the sort field is year and at the intranet is copyrightdate. To reproduce: Create a list at the OPAC and select the sort field 'year'. Go to the list management page at the intranet: the sort field copyrightdate is not selected by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8032] Sort lists by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||9167 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||8032 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #123 from Jared Camins-Esakov jcam...@cpbibliography.com ---
There are no unit tests for Koha::Borrower::Modifications, nor for the
AddMember_Opac routine (any other routines added should also have unit tests,
of course). Starting with the 3.12 release cycle, unit tests are required for
code added to the Koha:: and C4:: namespaces.
Also, please use hashrefs rather than hashes as arguments in the Koha::
namespace. I could have sworn you did a follow-up changing all the hash
arguments to hashrefs but I don't see it anywhere, even among the obsolete
patches.
Other notes:
* Do not access the database in BEGIN {} blocks, especially not in the Koha::
namespace.
* Use of C4::SQLHelper from the Koha:: namespace. Calling into the C4::
namespace from Koha:: is not supposed to be done. If that was the only
objection, I would probably push it anyway, at least this time, but arguably I
probably shouldn't.
* Package-level my variables are verboten, since they break persistence, and
replacing my with our should be done only under extreme duress, and never
in new code (note: you can use our when it's called for by the code, just not
as a workaround for my not working under Plack).
Thank you for including a test plan on the bug. I copied it (and the original
RFC) into the commit message for the first patch. I did not review it for
accuracy yet, since I discovered the lack of unit tests before I got that far,
so you may want to do that.
Also, I noticed a few other issues that would not prevent me pushing this but
you might want to keep in mind for the future:
* The standard for help in command-line scripts is to use pod2usage.
* Object-oriented classes do not export routines and therefore should not use
Exporter. Even procedural classes that do not export any routines should not
use Exporter.
* When creating -new() subroutines, the following idiom may be useful:
return bless( { 'verification_token' = $args{'verification_token'}, ... },
$class );
Or even:
return bless( $args, $class );
I find those two idioms make code easier to read, and certainly save typing,
but they are by no means required.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #13556|0 |1 is obsolete|| Attachment #13556|Rebase for master |Rebase for master -- DO NOT description||USE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #13184|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5496] Ergonomic improvement in smart rule management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5496 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|paul.poul...@biblibre.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5581] BibLibre authorities improvements for 3.4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5581 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- This patch was an omnibus, many things made their way into Koha, some have failed QA, but I think it's not needed to keep this one open -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5584] BibLibre OPAC improvements for 3.4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5584 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- This patch was an omnibus, many things made their way into Koha, some have failed QA, but I think it's not needed to keep this one open -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13771 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13771action=edit Bug 9167: Standardize the sort field copyrightdate for lists How to reproduce the issue: Create a list at the OPAC and select the sort field 'year'. Go to the list management page at the intranet: the sort field copyrightdate is not selected by default. How to test this patch: Check the issue is not still present with this patch. Create several lists at the OPAC with different sort field. Check results are consistent on both interfaces. Check the selected sort field is selected on the edit page. Check there is no regression. What this patch does: - change the way to send the selected sort field to the templates - remove the select tests on the new list page (useless) - the copyrightdate sortfield is named copyrightdate everywhere - update your database : set virtualshelves.sortfield = 'copyrightdate' if virtualshelves.sortfield = 'year' http://bugs.koha-community.org/show_bug.cgi?id=9167 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9168] New: Software error when filtering in receipt summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Bug ID: 9168 Summary: Software error when filtering in receipt summary Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com In acquisition, on receipt summary page : acqui/parcel.pl?inreceipt summaryvoiceid=X When using left filters (ISBN, basket, ...), you get a software error : Can't use an undefined value as an ARRAY reference at /home/koha/src/acqui/parcel.pl line 160. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED Patch complexity|--- |Small patch Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9167] The sort field copyrightdate is not standardized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9167 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- To apply AFTER Bug 8032 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3922] Managing suggestions: filter form missing information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3922 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #3 from Paul Poulain paul.poul...@biblibre.com --- can't reproduce the problem (but not sure I understand it fully), marking RESO FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5947] Adding a date filter to the suggestions search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5947 Bug 5947 depends on bug 3922, which changed state. Bug 3922 Summary: Managing suggestions: filter form missing information http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3922 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5574] 3.4 cataloguing improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5574 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Paul Poulain paul.poul...@biblibre.com --- This patch was an omnibus, many things made their way into Koha, some have failed QA, but I think it's not needed to keep this one open -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8661] break out additional authors in opac like in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8661] break out additional authors in opac like in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #13054|0 |1 is obsolete|| --- Comment #9 from Owen Leonard oleon...@myacpl.org --- Created attachment 13772 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13772action=edit Bug 8661 [Revised] break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Revision moves the position of the authority detail icon so that it falls inside delimiting punctuation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9168] Software error when filtering in receipt summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 13773 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13773action=edit Proposed patch Hidden inputs of form where wrong. booksellerid and invoicedatereceived are not necessary, parcel.pl will find them using invoiceid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9168] Software error when filtering in receipt summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 13774 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13774action=edit Proposed patch (follow-up 1) Small follow-up: in parcel.pl booksellerid is set to template twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6999] New icon sets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6999 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1464] MARC editor: auth_val, plugin and thesaurus are mutually exclusive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1464 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 917] plugins for coded fields in unimarc authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=917 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- fixed a long time ago... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4225] Cloning of rules in smart-rules.pl only clones top table of rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4225 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |koha-b...@lists.koha-commun ||ity.org Severity|enhancement |minor --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- problem still existing in 3.10 if I tested correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4264] categories for authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4264 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |koha-b...@lists.koha-commun ||ity.org --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- large enhancement to write, because it will require a new table for authorized values headers. Could be useful though, but not a high priority -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |koha-b...@lists.koha-commun ||ity.org Severity|minor |enhancement --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- still relevant, and I think it's more an enhancement than a bugfix. Should be easier with T::T plugins ! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] New: Wrap authorities relator code in span to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Bug ID: 9169 Summary: Wrap authorities relator code in span to allow for CSS customization Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org Some libraries would like to be able to hide relator codes when displaying authorities in the OPAC and staff client. Adding a span with class relatorcode would allow this text to be hidden via CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3928] Expected Date v. Received Date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3928 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |koha-b...@lists.koha-commun ||ity.org --- Comment #2 from Paul Poulain paul.poul...@biblibre.com --- is it still an issue nicole ? (otherwise said: is a critical bug open since 3 years really critical ;-) ) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5845] Incorrect values saving on content enrichment.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5845 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in span to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|Wrap authorities relator|Wrap relator code in span |code in span to allow for |to allow for CSS |CSS customization |customization --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Sorry, bibliographic records, not authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5773] Allow the librarians to specify the search indexes for advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5773 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5575] 3.4 BibLibre circ members omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5575 Bug 5575 depends on bug 5773, which changed state. Bug 5773 Summary: Allow the librarians to specify the search indexes for advanced search http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5773 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8032] Sort lists by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13775 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13775action=edit Bug 9167: Standardize the sort field copyrightdate for lists How to reproduce the issue: Create a list at the OPAC and select the sort field 'year'. Go to the list management page at the intranet: the sort field copyrightdate is not selected by default. How to test this patch: Check the issue is not still present with this patch. Create several lists at the OPAC with different sort field. Check results are consistent on both interfaces. Check the selected sort field is selected on the edit page. Check there is no regression. What this patch does: - change the way to send the selected sort field to the templates - remove the select tests on the new list page (useless) - the copyrightdate sortfield is named copyrightdate everywhere - update your database : set virtualshelves.sortfield = 'copyrightdate' if virtualshelves.sortfield = 'year' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8032] Sort lists by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 --- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #11) You are in the wrong report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5753] Allow adults to be added to an organisation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5753 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Paul Poulain paul.poul...@biblibre.com --- Professionals are made to be attached to organizations. I don't see why we should also attach Adults. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5575] 3.4 BibLibre circ members omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5575 Bug 5575 depends on bug 5753, which changed state. Bug 5753 Summary: Allow adults to be added to an organisation http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5753 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #23 from Paul Poulain paul.poul...@biblibre.com --- As the QA is OK, there is a signoff on the patch, I think it must be my test database that is wrong, so setting passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8981] Remove Nonpublic General Note from OPAC authorities display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #13239|0 |1 is obsolete|| --- Comment #3 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13776 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13776action=edit Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Does what it says, with no side effects Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8981] Remove Nonpublic General Note from OPAC authorities display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13777 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13777action=edit Bug 8981 follow-up: case While QAing your patch, I saw you were writting MarcFlavour, it should have been marcflavour Will work with the UC, but let's be consistent. This patch fixes another MarcFlavour just a few lines before I spotted by chance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8981] Remove Nonpublic General Note from OPAC authorities display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Patch complexity|--- |Trivial patch QA Contact||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * passes koha-qa.pl * won't say anything about the feature itself because i'm not a MARC21 specialist, but do what it announce * you wrote MarcFlavour instead of marcflavour for the system preference, it works, but it's better to use the syspref form, so I've uploaded a follow-up that just fixes the wording. passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8955] Self checkout should degrade gracefully with JavaScript turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||paul.poul...@biblibre.com Patch complexity|--- |Trivial patch --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * passes koha-qa.pl * I can't see a difference between before and after when I'm js=ON (as expected) * I see that the follow-up has not been signed-off, so back to need signoff. Kyle can you test this follow-up please ? I'll pass QA once you've done. PS: My feeling is that it's a (minor) enhancement, not a normal bugfix. Your opinion ? PS2: on my setup, I don't see the koha logo in Powered by (there's nothing) Is it because I'm using the -recent- ccsr theme ? what does the sco-main page look like for you ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in span to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in span to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169
--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13778
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13778action=edit
Bug 9169 - Wrap relator code in span to allow for CSS customization
This patch adds span class=relatorcode around the display of
relator codes in the OPAC and the staff client, and adds a space
before the bracket ( [relatorcode]) for readability.
To test, add custom CSS to OPACUserCSS and IntranetUserCSS and
view a record which includes relator code data. Suggested:
.relatorcode {
background-color: rgb(230, 240, 242);
border-radius: 3px 3px 3px 3px;
color: rgb(51, 51, 51);
display: inline-block;
font-size: 75%;
font-weight: normal;
margin-left: 0.4em;
padding: 0.1em 0.4em;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7687] Remove problematic CSS gradient declarations targeting Internet Explorer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Patch complexity|--- |Trivial patch --- Comment #3 from Paul Poulain paul.poul...@biblibre.com --- QA comment * css only small patch * don't break anything on FF afaics passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7687] Remove problematic CSS gradient declarations targeting Internet Explorer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13779 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13779action=edit Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the new list link which showed the wrong icon. Signed-off-by: Chris Cormack chr...@catalyst.net.nz I tested this in Firefox, and Chromium and it didn't break anything, I trust it works for IE too. Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7687] Remove problematic CSS gradient declarations targeting Internet Explorer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #13336|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #12695|0 |1 is obsolete|| --- Comment #33 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 12695 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12695 Bug 6945 counter patch adding link in the cat-toolbar counter-patch does not please owen nicole, removing it by obsoleting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #13256|0 |1 is obsolete|| Attachment #13257|0 |1 is obsolete|| --- Comment #34 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13780 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13780action=edit Add a link to show a MARC preview in the normal view of the detail http://bugs.koha-community.org/show_bug.cgi?id=6945 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 --- Comment #35 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13781 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13781action=edit Bug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the normal view Adding the same MARC preview link to the section of the template which is displayed when XSLT is on. This revision also adds a unique id to the surrounding element in the normal and XSLT versions. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch --- Comment #36 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * despite I don't like the place where the link is placed, I QA this patch because I agree with Nicole Owen it's an interesting link for librarians * tiny patch passes QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Component|SIP2|Architecture, internals, ||and plumbing Patch complexity|--- |Trivial patch Assignee|colin.campbell@ptfs-europe. |gmcha...@gmail.com |com | QA Contact|m...@kohaaloha.com | Severity|enhancement |minor --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- QA comment: patch passed QA already (see comment 3), also had a signoff from chris (from before the rebase) setting passed QA in the name of Mason PS: is it really an ENH ? I think it's more a minor bugfix, so changing severity accordingly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Patch complexity|--- |Trivial patch --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * despite it's size, this patch is really small * template only * passes koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #13415|0 |1 is obsolete|| --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13782 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13782action=edit Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label Feschrift Ind. to Literary genre - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added QA Contact||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8893] show more information on printout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com Patch complexity|--- |Trivial patch QA Contact||paul.poul...@biblibre.com --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * remove a lot of code, ++ * passes koha-qa.pl * I don't see any possible side-effect * feature works passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8893] show more information on printout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #13057|0 |1 is obsolete|| --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 13783 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13783action=edit Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8955] Self checkout should degrade gracefully with JavaScript turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8955 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- PS2: on my setup, I don't see the koha logo in Powered by (there's nothing) Is it because I'm using the -recent- ccsr theme ? Yes, the CCSR theme includes lots of errors like this in features which I assume were not deemed necessary by the original sponsors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8614] Icon for scores on OPAC detail page broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8614] Icon for scores on OPAC detail page broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #13453|0 |1 is obsolete|| --- Comment #5 from Owen Leonard oleon...@myacpl.org --- Created attachment 13784 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13784action=edit Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken At some point some famfamfam icons were moved out of the theme director into the lib directory in opac-tmpl. When this was done the path to the directory was changed accordingly in most cases. However, not all famfamfam icons were moved, and some image paths were not corrected. This patch completes the move of the famfamfam icon set to opac-tmpl/lib and corrects the path to the icons on the OPAC XSL detail page and the OPAC holds page. To test, view those pages and confirm that the images work. View records with a variety of material types. Edit: Rebased on origin/3.8.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9170] New: deleting a patron with holds leaves orphaned holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9170 Bug ID: 9170 Summary: deleting a patron with holds leaves orphaned holds Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This is not based in any code evidence ... it's just a guess of mine. I'm finding a lot of lines in the reserves table where there is no reservedate and no borrowernumber, but the found is still NULL. I'm thinking that when the patron is deleted their holds aren't moved to the old_reserves table or deleted, just their borrowernumber is being NULLed out. If this is the case, I think that the holds should be removed from the reserves table which should be the place for all current holds are stored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9149] Patch 8823 introduces reference to non-existent function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 jane.ch...@cwts.edu changed: What|Removed |Added CC||jane.ch...@cwts.edu --- Comment #1 from jane.ch...@cwts.edu --- I think I have a similar problem. Cannot edit/replace/create records. The following error appeared when trying to save: Undefined subroutine C4::AuthoritiesMarc::GetAuthorizedHeading called at /usr/share/koha/lib/C4/Biblio.pm line 667. Please help resolve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9171] New: Vendor sent us a file with holdings in 952 which has repeated subfields and no home or holding branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9171 Bug ID: 9171 Summary: Vendor sent us a file with holdings in 952 which has repeated subfields and no home or holding branch Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcha...@gmail.com Reporter: mdha...@tech.washk12.org Created attachment 13785 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13785action=edit usmarc file to demonstrate the bug Staging a file for import where the item information is in the 952 tag, but lacks home/holding branch information and may have repeated subfields, results in items with no branchcode set and near empty items for the repeated subfields To test: stage and import the attached usmarc file and note that some items, like in the first record, are missing the homebranch and holdingbranch information, and because of the repeated 'z' subfield another item record is created just for the repeated field. Apply patch and stage and import the file again to see that these items are imported correctly. I had to deal with a file from a vendor which had the holdings information in the 952 tag. This was for new books, so there was obviously no itemnumber. There was also no home or holding branch set, so the items got a little lost. To further complicate matter the 'z' subfield was repeated in a couple fields, and MARC::Record seemed to think those repeated subfields should be in a field by themselves. So I have a patch which adds code to watch for this missing home/holding branch subfields, and catches repeated subfields that end up in seperate fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
