[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 --- Comment #2 from Liz Rea (CatalystIT) --- Actually I need to know exactly what I am replicating so I can verify if the fix works - can you give me some concrete steps to follow so I can 1. see the problem and 2. make sure the fix works as we expect? Thanks! Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 Liz Rea (CatalystIT) changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8451 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Liz Rea (CatalystIT) changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9322 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Liz Rea (CatalystIT) changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@catalyst.net.nz Assignee|kyle.m.h...@gmail.com |l...@catalyst.net.nz --- Comment #1 from Liz Rea (CatalystIT) --- kyle has a bit of code for this, I'll try to find it and whack it in on the fines page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 --- Comment #2 from Liz Rea (CatalystIT) --- Another very bad no good scenario - say you have some transits placed independently of reserves: ++-++-+--+---+ | itemnumber | datesent| frombranch | datearrived | tobranch | comments | ++-++-+--+---+ |989 | 2012-12-27 15:25:38 | CPL| NULL| RPL | NULL | |989 | 2012-12-27 15:25:45 | RPL| NULL| SPL | NULL | |989 | 2012-12-27 15:25:51 | SPL| NULL| UPL | NULL | Then you get one that goes with a reserve: ++-++-+--+---+ | itemnumber | datesent| frombranch | datearrived | tobranch | comments | ++-++-+--+---+ |989 | 2012-12-27 15:25:38 | CPL| NULL| RPL | NULL | |989 | 2012-12-27 15:25:45 | RPL| NULL| SPL | NULL | |989 | 2012-12-27 15:25:51 | SPL| NULL| UPL | NULL | |989 | 2012-12-27 15:32:32 | SPL| NULL| CPL | NULL | ++-++-+--+---+ Your staff member, seeing dual prompts (because you will see dual prompts here), receives the item - all of the transits are marked arrived (and thus lost), and no matter how many times you check this item in, nothing will happen - the reserve is hung up, the transits are gone, it's in a properly bad way. This will require human intervention and detective work to get out of: ++-++-+--+---+ | itemnumber | datesent| frombranch | datearrived | tobranch | comments | ++-++-+--+---+ |989 | 2012-12-27 15:25:38 | CPL| 2012-12-27 15:33:00 | RPL | NULL | |989 | 2012-12-27 15:25:45 | RPL| 2012-12-27 15:33:00 | SPL | NULL | |989 | 2012-12-27 15:25:51 | SPL| 2012-12-27 15:33:00 | UPL | NULL | |989 | 2012-12-27 15:32:32 | SPL| 2012-12-27 15:33:00 | CPL | NULL | ++-++-+--+---+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9322] If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 --- Comment #1 from Liz Rea (CatalystIT) --- This will only happen if you return the item at the first one in the series - any other combination will trigger a "return this item to the branch that is expecting it" - for example item supposed to go cpl -> ffl, item returned at mpl Message: please return to FFL - this is fine and good. Do note, however, that no wrongtransfer is generated in this scenario. It probably should be, as we might want a record that it had gone to mpl instead of ffl. Currently there is none for branch transfers. (I think wrongtransfer only happens on transits initiated by reserves - but I could be wrong about that). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9322] New: If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9322 Bug ID: 9322 Summary: If multiple transfers exist (from circ/branchtransfers.pl), completing one completes them all Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: l...@catalyst.net.nz CC: gmcha...@gmail.com To replicate: * get an item's barcode * go to circulation -> transfers * select a branch to transfer to * put in your barcode * submit the transfer * select a different branch to transfer to * (I don't know why you would do this, but) put your same barcode in again * submit the transfer * select a third branch to transfer to * (again, I don't know why you would do this, but) put your same barcode in again * submit the transfer A query against the database will show 3 transfers: select * from branchtransfers; ++-++-+--+---+ | itemnumber | datesent| frombranch | datearrived | tobranch | comments | ++-++-+--+---+ |989 | 2012-12-27 14:31:14 | CPL| | FFL | NULL | |989 | 2012-12-27 14:31:20 | FFL| | FRL | NULL | |989 | 2012-12-27 14:34:22 | FRL| | CPL | NULL | You can see it's done something kind of smart, by putting the 2nd transfer to go from the destination of the first transfer. Makes good sense. What doesn't make such good sense is that when you complete the first transfer, the following happens: select * from branchtransfers; ++-++-+--+---+ | itemnumber | datesent| frombranch | datearrived | tobranch | comments | ++-++-+--+---+ |989 | 2012-12-27 14:31:14 | CPL| 2012-12-27 14:34:36 | FFL | NULL | |989 | 2012-12-27 14:31:20 | FFL| 2012-12-27 14:34:36 | FRL | NULL | |989 | 2012-12-27 14:34:22 | FRL| 2012-12-27 14:34:36 | CPL | NULL | ++-++-+--+---+ All three transfers are received when the first one is. The other two don't trigger. It's like they never existed. I think this also happens when you have a reserve triggered transit in addition to a circ/branchtransfers.pl transit. This is the cause of the occasional "Item on hold for , item is already waiting" messages when you would normally be expecting a "Confirm hold for " message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #3 from Chris Cormack --- Created attachment 14281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14281&action=edit Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack changed: What|Removed |Added Attachment #13636|0 |1 is obsolete|| --- Comment #39 from Chris Cormack --- Created attachment 14280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14280&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable Signed-off-by: Mirko Tietgen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack changed: What|Removed |Added Attachment #13635|0 |1 is obsolete|| --- Comment #38 from Chris Cormack --- Created attachment 14279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14279&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 and element. Additionally it gives basic support for the element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master 22.11.2012 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9321] New: holds queue printable version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321 Bug ID: 9321 Summary: holds queue printable version Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com It would be nice if there were a printable stylesheet for the holds queue. Right now it's a print screen basically and that means that the table doesn't always fit on the page - in fact it never has for me. I think it should be a list or a thinner table or something a bit more printer friendly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Chris Cormack changed: What|Removed |Added Attachment #14274|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 14278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14278&action=edit BZ 9320 : Pending reserves report (circ/pendingreserves.pl) should not show items on hold waiting to be picked up Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #8 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9158] Correcting whitespace around display of series 440 marc fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9158 --- Comment #8 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9278] Remove unused OPAC CSS file sanop.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9278 --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9140] Untranslatable strings in item circulation history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #14 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9158] Correcting whitespace around display of series 440 marc fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9158 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9278] Remove unused OPAC CSS file sanop.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9278 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9112] Update of SQL file for italian setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9112 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9140] Untranslatable strings in item circulation history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.10.x, will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9136] C4::Tags not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9136 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Nicole C. Engard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Nicole C. Engard changed: What|Removed |Added Attachment #14195|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard --- Created attachment 14277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14277&action=edit Bug 9306: Update descriptions for the 4 SeparateHoldings prefs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9315] Bad version of String::Random reported by koha_perl_deps.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Owen Leonard changed: What|Removed |Added Attachment #14253|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 14276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14276&action=edit Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 Signed-off-by: Owen Leonard Patch works correctly according to the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9315] Bad version of String::Random reported by koha_perl_deps.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Owen Leonard changed: What|Removed |Added Attachment #13534|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 14275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14275&action=edit [SIGNED-OFF] Bug 8451 - Confusing and problematic double prompt for processing transfers This patch will cause changing the priority of a reserve from 'in transit' to a priority number to delete the transfer associated with it, if there is one. Signed-off-by: Owen Leonard Tested with this plan: 1. Place a hold on an item for delivery to another branch. 2. Check in the item and confirm the transfer. 3. Edit the hold, changing the status from in-transit to a priority number. 4. Check in the item again. Before the patch I would see two prompts at step 4. After the patch I see one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 --- Comment #5 from Owen Leonard --- This seems to be working, assuming the test plan is: 1. Place a hold on an item for delivery to another branch. 2. Check in the item and confirm the transfer. 3. Edit the hold, changing the status from in-transit to a priority number. 4. Check in the item again. Before the patch I would see two prompts at step 4. After the patch I see one. I think, however, that this needs a follow-up for cases when instead of modifying the status in step 3 the hold is deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Sophie MEYNIEUX changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 14274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14274&action=edit BZ 9320 : Pending reserves report (circ/pendingreserves.pl) should not show items on hold waiting to be picked up Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9226] Wrong branch filter after suggestion creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 Owen Leonard changed: What|Removed |Added Attachment #13905|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 14273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14273&action=edit [SIGNED-OFF] Bug 9226: Wrong branch filter after suggestion creation Signed-off-by: Owen Leonard Before the patch, upon submitting a new suggestion in the staff client I was redirected to a view which was not filtered by branch. After the patch I was redirected to a view which was filtered by my logged-in branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9226] Wrong branch filter after suggestion creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9212] Parentheses in subject headings break search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #2 from Owen Leonard --- You don't say what the context for this error is--OPAC or staff client, XSLT or non-XSLT--but I can't reproduce the error. I tested with this record: http://lccn.loc.gov/2011019323 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] New: Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Bug ID: 9320 Summary: Pending reserves is showing reserves already waiting Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com CC: gmcha...@gmail.com A document with only one item that has multiple reserves is shown in circ/pendingreserves.pl even if the item is waiting for the first patron. With the patch, only items that are really available are shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #3 from Owen Leonard --- Following the test plan I get the same results (which appear to be valid) before and after the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Owen Leonard changed: What|Removed |Added Attachment #14192|0 |1 is obsolete|| --- Comment #74 from Owen Leonard --- Created attachment 14272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14272&action=edit [SIGNED-OFF] Bug 7143 adding Kiriaki Roditi as translator Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This should be updated to use "library" in place of "branch." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9309] "OPACurlOpenInNewWindow" isn't respected for 856$u links shown in OPAC when not using XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9309 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- This doesn't work for me unless I replace "OPACurlOpenInNewWindow" with "OPACURLOpenInNewWindow" (matching the case of the system preference). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9201] OAI-PMH mapping value cannot be 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9201 Jonathan Druart changed: What|Removed |Added Attachment #14108|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 14271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14271&action=edit Bug 9201 OAI-PMH mapping value cannot be 0 Allow the value of a OAI set mapping to be 0 / empty. Delete the mapping if field or subfield are empty. Signed-off-by: Jonathan Druart Now it is possible to add a value == 0 or an empty string. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9201] OAI-PMH mapping value cannot be 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9201 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart --- (In reply to comment #1) > Problem comes from the call at C4::Biblio::GetMarcAuthors. Hi Fridolyn, Could you explain more precisely the reason why please? Your patch duplicates some information (mintag and maxtag are already defined in GetMarcAuthors). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9294] Move JavaScript out of circulation template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 --- Comment #6 from Jonathan Druart --- I prefer to wait before passing qa on this patch. It depends on another one not already pushed and it interferes with Bug 9289. On rebasing, we won't forget to uncomment this line! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9294] Move JavaScript out of circulation template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #5 from Jonathan Druart --- Oops sorry, this bug depends on Bug 9283 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9294] Move JavaScript out of circulation template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart changed: What|Removed |Added Attachment #13983|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 14270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14270&action=edit Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Katrin Fischer Small change, fixes reported problem. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #9 from Jonathan Druart --- QA Comments: I did not test this patch, but it does not break anything and is in agreement with the result of the discussion of Bug 6574. Marked as Passed QA. Jared, this patch will be in conflict with Bug 6261. So I advice you to apply the patch of Bug 6261 before this one. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9183] C4::Search should only have one ZOOM event loop
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183 Jonathan Druart changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9183] C4::Search should only have one ZOOM event loop
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183 Jonathan Druart changed: What|Removed |Added Attachment #13924|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 14269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14269&action=edit Bug 9183: Refactor ZOOM event loop Prior to this patch, there were three identical ZOOM event loops in C4::Search. This is wasteful, and goes against all good programming practice. This patch refactors the ZOOM event loops into a separate subroutine which is called by SimpleSearch, searchResults, and GetDistinctValues call. The new routine, _ZOOM_event_loop process the ZOOM event loop and, once it has been fully processed, passes control to a closure provided by the calling routine for processing the results, and destroys the result sets. To test (after applying patch): 1) Do a regular bibliographic search that should return results. 2) Do a search in the Cataloging module that should return results. 3) If you get results from both searches, the patch works. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9183] C4::Search should only have one ZOOM event loop
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart --- QA Comments: I don't know very well this part of code but it seems good to me. I searched in the 2 places and I got results. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 --- Comment #8 from Jonathan Druart --- Created attachment 14268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14268&action=edit Bug 9206: Followup QA FIX - Fix indentation - It is useless to loop on all items. If at least 1 item is already issued, we want to return 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 Jonathan Druart changed: What|Removed |Added Attachment #14127|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 14267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14267&action=edit Bug 9206 - Only allow place holds in records that the patron don't have in his possession - QA Followup Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 Jonathan Druart changed: What|Removed |Added Attachment #14126|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 14266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14266&action=edit Bug 9206 - Only allow place holds in records that the patron don't have in his possession Added a system preference to turn on/off this feature. By default the system allow the patron to place holds even if it is in his possession. Script to place holds check if the system preference is off and if patron has at least one item to block holds. Messages to say that are already in patron possession added to templates. Method to check if patron has one issue from one record added to C4::Circulation Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart --- QA Comments: Looks good to me. I tested the feature (on/off) at the opac and the intranet, I didn't find any issue. I will submit a followup (fix indentation and the return of the new routine CheckIfIssuedToPatron). Jared, could you switch back the status to Needs signoff if you require one for it? Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8565] forgive fines doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8565 Nicole C. Engard changed: What|Removed |Added Version|master |3.8 Severity|major |critical --- Comment #1 from Nicole C. Engard --- An update on this - in 3.8. It looks like if the code is F it does forgive, but if it's FU it does not. It should forgive fines no matter what the code is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9193] socialnetworks aren't working in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9193 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #2 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #3 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8883] opacsmallimage doesn't work in ccsr theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8883 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #3 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9194] browse search aligned funny in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9194 --- Comment #2 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9197] opacnav shows below tabs on opac-user.pl in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9197 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #2 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8979] "News" does not work with CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #2 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9195] nav overlaps lists in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com --- Comment #2 from Nicole C. Engard --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9194] browse search aligned funny in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9194 Nicole C. Engard changed: What|Removed |Added Assignee|fcapovi...@live.ca |pelletiermax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9319] Display all patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9319 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This is not a bug report, this is a support requests. Support requests should be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: http://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9162] Add a system preference to set which notes fields appears on title notes/description separator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Jonathan Druart changed: What|Removed |Added Attachment #14264|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 14265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14265&action=edit BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart FIX some indentation in C4/Biblio.pm +FIX 1 end of parentheses in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9162] Add a system preference to set which notes fields appears on title notes/description separator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Jonathan Druart changed: What|Removed |Added Attachment #14121|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 14264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14264&action=edit BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart FIX some indentation in C4/Biblio.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9162] Add a system preference to set which notes fields appears on title notes/description separator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart --- QA Comments: The proposed patch works well. However if all existing fields are blacklisted, the biblio.notes field is displayed. So if you blacklist the 300$a and if it is mapped with this db field, it will be displayed. Possible improvement : Perhaps some libraries would like to blacklist some fields for the opac and fewer fields for the intranet (required 1 syspref by interface). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart changed: What|Removed |Added Attachment #14115|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart --- Created attachment 14263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14263&action=edit 7368 GetXmlBiblio Only changing some documentation about GetXmlBiblio Signed-off-by: Mirko Tietgen Added the word 'contain' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #69 from Jonathan Druart --- QA Comments: Last patch changes some lines of documentation. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@biblibre.co
||m
--- Comment #4 from Jonathan Druart ---
QA Comments:
I am not sure at all but the check on the notforloan value should not be made
in the CanItemBeReserved routine ? Is not it more relevant ?
If not, your patch has to be resubmitted for a little modification.
The test in IsAvailableForItemLevelRequest is:
return ($available_per_item and ($item->{onloan} or
GetReserveStatus($itemnumber) eq "W" or $item->{notforloan} < 0));
it will be optimized if you change the order, as:
return ($available_per_item and ($item->{onloan} or $item->{notforloan} < 0
or GetReserveStatus($itemnumber) eq "W" ));
Marked as Failed QA.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8906] Improve OAI management interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #11 from Jonathan Druart --- Created attachment 14262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14262&action=edit Bug 8906: Followup replace 'Clear' with 'Delete' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8906] Improve OAI management interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #10 from Jonathan Druart --- Owen, What do you think about Mirko's proposition? I think he is right, but I let you give you opinion. I will submit a patch with this modification, please signoff or mark it as obsolete if you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9289] Adjacent checkbox behavior broken on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Jonathan Druart changed: What|Removed |Added Attachment #14250|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 14261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14261&action=edit Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9289] Adjacent checkbox behavior broken on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart --- QA Comments: Trivial patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9284] JavaScript should conform to coding guidelines recommended by JSHint
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9284 Jonathan Druart changed: What|Removed |Added Attachment #14249|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 14260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14260&action=edit Bug 9284 - JavaScript should follow rules recommended by JSHint Coding style corrections to members.js: - Mixed tab/space indentation converted to spaces. - Converted "!=" and "==" to "!==" and "===" for comparisons with ''. - Adding missing semicolons. To test, create or edit a patron and confirm that validation hasn't been broken by the changes to members.js: Invalid date, empty required fields, guarantor popup, restricted-until field display, etc. http://bugs.koha-community.org/show_bug.cgi?id=9281 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9284] JavaScript should conform to coding guidelines recommended by JSHint
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9284 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart --- QA Comments: This patch only changes 7 lines substituting the js comparison operators (!= with !== and == with ===) in the members.js file. No behaviour changed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8299] overdue_notice.pl shows warning messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299 Jonathan Druart changed: What|Removed |Added Attachment #14243|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 14259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14259&action=edit Bug 8299 - overdue_notice.pl shows error messages fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8299] overdue_notice.pl shows warning messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |nikhil...@gmail.com |ity.org | QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8299] overdue_notice.pl shows warning messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299 Jonathan Druart changed: What|Removed |Added Version|3.8 |master --- Comment #6 from Jonathan Druart --- It is a patch for master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8299] overdue_notice.pl shows warning messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart --- QA Comments: On a technical point of view this patch is good because it tests if the variable is defined before passing it to a regexp. But the content of a letter should be defined. I think the real error is the last line of the log: No letter_code at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 686. So there is no letter defined for this overdue. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart changed: What|Removed |Added Attachment #14235|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 14258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14258&action=edit Bug 6261 [Revised] Consolidate patron toolbar include files The staff client has two almost identical include files which can be consolidated: circ-toolbar.inc and members-toolbar.inc. This patch marges the slight differences between them and eliminates circ-toolbar.inc, that being the one which was used on fewer pages. In order to accommodate the different "destination" variable for operations which redirect back either to circ or patrons, circulation.pl defines "destination" in the template. Revision corrects a redirect error in setstatus.pl which predates this patch but which never showed up until now. To test, perform various operations from the toolbar on at least two pages: circulation.pl and moremember.pl. Operations: Edit, add child, duplicate, change password, print (all options), search to hold, renew, set permissions, delete, update child to adult, and export checked-in barcodes. In most cases simply confirming that the link takes you to the right place is enough. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart --- QA Comments: Looks good to me, no regression found. The patch merges 2 include template files into 1 (members-toolbar.inc), changes the permission for printing (from 'borrowers => 1' to 'circulate => circulate_remaining_permissions') and fixes a typo in the setstatus.pl script (bornum with borrowernumber). A future improvement could be done by managing the different files which use this include file specifying the destination variable (in order to be redirected to the page where the user was). Marked to Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Francois Charbonnier changed: What|Removed |Added CC||francois.charbonnier@biblib ||re.com --- Comment #9 from Francois Charbonnier --- I guess someone used/is using the LOC or CCODE as itemtypes (maybe to display the information?) or thought it might suit everybody to get everything within one field... Anyway, if Koha 3.6 can returns itemtypes / LOC and CCODE values, the patch for this bug should make it works the same way here. Then, we should open up a "feature request" to change the behaviour. I agree we should separate the advanced search and the suggestion droplist setups to avoid confusion for the patron. If a library want to catalogue the location and the ccode at the suggestion level, there should be two new fields that would be display depending on a new syspref similar to AdvancedSearchTypes syspref. And maybe, we could be wilder and add not just one syspref but two sysprefs to distinguish opac and staff suggestion droplist set ups! :^) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
