[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #3 from Liz Rea (CatalystIT)  ---
Steps to reproduce the bug (copied from 8378):
1. make 2 checkouts with 2 different borrowers of the same categorycode
2. make these checkouts become overdue "update issues set date_due='-XX-XX
XX:XX' where borrowernumber IN(X,Y)"
3. run misc/cronjobs/overdue_notices.pl -n
You should obtain the same letter twice.
4. Now apply the patch and re-run misc/cronjobs/overdue_notices.pl -n
You should obtain 2 different letters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] syntax not working on overdues anymore

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #32 from Jared Camins-Esakov  ---
I have reverted this patch from master, as it was the cause of the much larger
problem described in bug 9325. A new patch to restore the  syntax would
be welcomed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
Commit 40f9914e60e002ae4cbf10d09cff8bbf32abd8fe for bug 8378 created this bad
behaviour.

I would be in favour of reverting that, and fixing the fines bug by just doing

@@ -671,7 +679,7 @@ sub parse_letter {
 my $currency_format;
 if ($params->{'letter'}->{'content'} =~ m/(.*)<\/fine>/o) { #
process any fine tags...
 $currency_format = $1;
-$params->{'letter'}->{'content'} =~
s/.*<\/fine>/<>/o;
+$params->{'letter'}->{'content'} =~
s/.*<\/fine>/<>/o;
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #7 from Liz Rea (CatalystIT)  ---
Notes for when I come back to this Monday:

ExpireReservesMaxPickUpDelay = allow
ReservesMaxPickUpDelay = 1 (day)
Holiday on the calendar 
Cron set to run daily (package crons) 

should expire sunday night (friday and saturday are holidays, hold is over
after 1 day).



-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

  Attachment #14305|0   |1
is obsolete||

--- Comment #13 from Liz Rea (CatalystIT)  ---
Created attachment 14306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14306&action=edit
Bug 9209: Skip tests for older DBD::Mock

Because the calendar tests require a more recent version of DBD::Mock
than has been packaged by Debian, it makes sense to skip all the tests
requiring the database when only an older version is present.

Signed-off-by: Liz Rea 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

--- Comment #12 from Jared Camins-Esakov  ---
The test plan for the follow-up is the same as for the original: run `prove
t/Calendar.t`. If you have a version of DBD::Mock older than 1.45, all the
tests will be skipped once the follow-up is applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

--- Comment #11 from Jared Camins-Esakov  ---
Created attachment 14305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14305&action=edit
Bug 9209: Skip tests for older DBD::Mock

Because the calendar tests require a more recent version of DBD::Mock
than has been packaged by Debian, it makes sense to skip all the tests
requiring the database when only an older version is present.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9272] Plack goes into paroxysms of horror when faced with deleting an authorized value

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9272

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||3309

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3309] Deleting authorized values when data exists

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Depends on||9272

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

--- Comment #13 from Liz Rea (CatalystIT)  ---
This last patch is based on the work of 6261, which was just pushed. It'll need
a new signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

  Attachment #14270|0   |1
is obsolete||

--- Comment #12 from Liz Rea (CatalystIT)  ---
Created attachment 14304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14304&action=edit
Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting

To replicate:

* install en-NZ translation (or en-GB)
* activate the new language, and select it for use
* pretend you are going to issue a book to a member (search for a member from
"check out" in header)
* without the patch, the toolbar will be incorrect. The toolbar will also be
incorrect on moremember.pl.

To test:
* apply the patch
* re-generate the en-NZ or en-GB translation
* activate the new language, or select it for use
* pretend you are going to issue a book to a member (search for a member from
"check out" in header)
* with the patch, the toolbar will appear to be correct. It will also be
correct on moremember.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9145] Authorities: standard language for UNIMARC

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9145

Katrin Fischer  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9269

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9269] Remove DefaultLanguageField008 syspref

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9269

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9145

--- Comment #1 from Katrin Fischer  ---
There was a discussion on bug 9145, why a default value is not enough in some
cases. I am linking both bugs together for now, not sure it's the same
situation here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9284] JavaScript should conform to coding guidelines recommended by JSHint

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9284

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574

--- Comment #11 from Jared Camins-Esakov  ---
I believe this patch is unnecessary now that bug 6261 has been pushed. Could
you please confirm that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8299] overdue_notice.pl shows warning messages

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #6 from Jared Camins-Esakov  ---
Marking as "Failed QA" until I have an answer about the test plan.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #14300|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #30 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6261] Consolidate patron toolbar include files

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9289] Adjacent checkbox behavior broken on circulation.pl

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9266] Managing tags / reject: Error "Unbekannte Operation (ablehnen)" in translated staff client

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266

Katrin Fischer  changed:

   What|Removed |Added

 CC||frede...@tamil.fr,
   ||katrin.fisc...@bsz-bw.de
  Component|Staff Client|I18N/L10N
Version|unspecified |master
   Severity|minor   |normal

--- Comment #1 from Katrin Fischer  ---

Tested in 3.10.1.

I can reproduce the problem using the checkboxes and the buttons below the list
of tags.

Also I noted some other translation related problems:

1) On the OPAC detail page there is a little icon in front of 'Add' that is
missing in the German templates before 'Hinzufügen'.

2) When you use the 'reject' and 'accept' links in the list of terms, after
rejecting or accepting one of the buttons appears in English. Looking like:

Bestätigt (= Accepted) | Reject
Approve | Abgelehnt (= Rejected)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9301] Search to Hold no longer passing through patron name

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9301

--- Comment #1 from Liz Rea (CatalystIT)  ---
Do note this doesn't seem to happen in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #3 from Liz Rea (CatalystIT)  ---
I stepped through your test plan - 

>From start to finish, with the patch on, I don't see the missing issue in the
history, but I don't see it in the arrived list either - am I supposed to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

--- Comment #10 from Katrin Fischer  ---
Not sure how to fix this - maybe we could comment out the tests that are broken
now and reactivate them later when a new version is available?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Same for me - 1.43 and 11 tests failing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8054] can hit submit twice when paying fines

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054

--- Comment #3 from Liz Rea (CatalystIT)  ---
Created attachment 14303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14303&action=edit
Bug 8054 - double clicking can cause duplicate payments/fines

Uses preventDoubleForSubmit() to prevent double form submissions in the fines
module.

To test:

Create a manual invoice/fine
Create some manual fines, click save like mad - you should get only one fine
(without, you will get several if you click madly enough)

Click Pay fines
Pay some fines, clicking save like mad on each. You should only get one
payment. (without, you will get several payments)

Create a manual credit
Create a credit, click save like mad. You should only get one credit. (without
you will get several if you click madly enough)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Derryn  changed:

   What|Removed |Added

 CC||derr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

  Attachment #14301|0   |1
is obsolete||

--- Comment #79 from Liz Rea (CatalystIT)  ---
Created attachment 14302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14302&action=edit
Bug 7143 updating history and about page

Signed-off-by: Liz Rea 
Changes look to be correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Stable|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #78 from Chris Cormack  ---
Created attachment 14301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14301&action=edit
Bug 7143 updating history and about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #29 from Katrin Fischer  ---
First patch passed QA, please switch back to 'Needs Signoff' later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #12891|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 14300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14300&action=edit
[SIGNED-OFF] Bug 8712 - We should use WAI-ARIA guidelines to help with
accessibility

Added title to the search box

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451

Liz Rea (CatalystIT)  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea (CatalystIT)  ---
I have reservations about this patch which I cannot fully articulate, but it
has to do with the behaviour of transfers and 9322 - I think it may be
dangerous to fix this, in this way, while 9322 is still an issue.

The only real solution I see to this particular problem, is finding a way to
link a reserve specifically to it's associated transfer, and make it delete
only transfers associated with the reserve that has been
re-ordered/deleted/whatever and leave the explicit transfers (done through
branchtransfers.pl) alone. 

The reason for this is that you could have a legitimate situation where an item
is supposed to be going two places at the same time, or at least Koha is being
told to send something to two places at the same time. Koha can probably not
ever be smart enough to know which to prefer, an explicit transfer or a reserve
generated transfer, which is why there are two prompts.

The messages are certainly confusing - this bug has been a problem for years
(I'm thinking specifically of issues reported by NEKLS, because that is where I
have my experience with dual prompts). Certainly this is one way to fix the
issue at hand in this bug, but I also think we need to think carefully about
the design of explicit transfers and reserve generated transfers. Currently
Koha doesn't differentiate between them, and bug 9322 is certainly muddying the
water as to "when transfers are completed in *any* situation."

Sorry to be so long winded, but I honestly think we really need to think about
how to fix this in a way that makes sense for all transfers and not just
reserve transfers. And more importantly, we need to think about how we can
present the information that there are two kinds of transfers for an item, if
that is the case, in a way that is not confusing to library staff.

LR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Chris Cormack  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable

--- Comment #71 from Chris Cormack  ---
Pushed to master and 3.10.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #77 from Chris Cormack  ---
Pushed to 3.10.x will be in 3.10.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9183] C4::Search should only have one ZOOM event loop

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Pushed to 3.10.x will be in 3.10.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328

Galen Charlton  changed:

   What|Removed |Added

 Blocks||7167

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Galen Charlton  changed:

   What|Removed |Added

 Depends on||9328

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9328] New: File::Find::Rule should not be a mandatory dependency for installation

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328

Bug ID: 9328
   Summary: File::Find::Rule should not be a mandatory dependency
for installation
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com

File::Find::Rule is introduced as a dependency in the work for bug 7167. 
However, since it's indirectly invoked via C4::Installer, that module must be
present for Makefile.PL to compile during installation.

I suggest making a new convention that it be possible to run Makefile.PL
without requiring non-core Perl modules. 

F::F::Rule doesn't introduce functionality that is not available to File::Find,
just some (admittedly useful) syntactical sugar, so one possibility would be
cutting out that dependency entirely.  If that's not preferred, it at least
should not be required for Makefile.PL to run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #227 from Galen Charlton  ---
(In reply to comment #226)
> Reopening because this breaks Koha, you can't currently install
> 
> perl Makefile.PL fails with this change, I don't think that is separate bug,
> just this one needs to be reverted of fixed.

Specifically, one way that failure manifests is:

$ perl Makefile.PL 
unable to locate Koha configuration file koha-conf.xml at
/home/esi/koha/C4/Context.pm line 372.
unable to locate Koha configuration file koha-conf.xml at
/home/esi/koha/C4/Context.pm line 372.
Can't call method "config" on unblessed reference at
/home/esi/koha/C4/Context.pm line 790.
Compilation failed in require at /home/esi/koha/C4/Installer.pm line 26.
BEGIN failed--compilation aborted at /home/esi/koha/C4/Installer.pm line 26.
Compilation failed in require at Makefile.PL line 31.
BEGIN failed--compilation aborted at Makefile.PL line 31.

The following commit fixes the immediate problem and allows the perl
Makefile.PL; make; make test sequence to work, although the patch is otherwise
untested.

http://git.koha-community.org/gitweb/?p=wip/koha-equinox.git;a=commitdiff;h=aa0052119467f84a7afe33d64714e52ed90acbe4

As the TODO in the patch notes, the double "unable to locate Koha configuration
file" bit when running Makefile.PL is noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6328] Fine in days does not work

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328

Bug 6328 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190

Bug 6190 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327

Bug 9327 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Chris Cormack  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #226 from Chris Cormack  ---
Reopening because this breaks Koha, you can't currently install

perl Makefile.PL fails with this change, I don't think that is separate bug,
just this one needs to be reverted of fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326

Bug 9326 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #48 from Katrin Fischer  ---
I can't get debug to show up. My LogLevel is set to the highest level 7. I
verified this is also the value in the systempreferences table.

I added following code to the mainpage.pl file:
use Koha::Utils::Logger qw/$log/;
$log = Koha::Utils::Logger->new;

$log->unusable("This is an unusable thing");
$log->critical("This is critical!");
$log->error("This is an error !");
$log->warning("This is only a warning.");
$log->normal("This nothing to worry about.");
$log->info("This is an information");
$log->debug("This is a debug message");

With LogToHtmlComments set to Embed I can see following in the HTML source code
of the main page:



My log files shows:
[27/12/2012 17:54:44] UNUS  : This is an unusable thing
[27/12/2012 17:54:44] CRIT  : This is critical!
[27/12/2012 17:54:44] ERROR : This is an error !
[27/12/2012 17:54:44] WARN  : This is only a warning.
[27/12/2012 17:54:44] NORMAL: This nothing to worry about.
[27/12/2012 17:54:44] INFO  : This is an information

My test plan so far was:

1) Apply patches and try to access Koha.
  Verify useful error message is shown.
2) Install new dependency: Log::LogLite
  sudo apt-get install liblog-loglite-perl
3) Run database update
  Verify database update works correctly
4) Run t/Logger.t
  Verify all tests pass
5) Do some searches in OPAC.
  Verify Koha does not explode and all is acting normal.
  Verify debug message is not showing up in HTML source.
  Look for 

[Koha-bugs] [Bug 9257] Add "groups" to normal search pulldown

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
It looks like this functionality depends on the user having JavaScript enabled.
Generally speaking functionality which requires JavaScript should degrade
gracefully: If it doesn't work without JS it should not be present for
JS-disabled users.

I would love to see a solution which used  instead of a disabled
 to organize the options.

Could we perhaps prepend the group name with a specific string which could be
parsed by the search script in order to be understood as a group instead of a
single library?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6328] Fine in days does not work

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328

Bug 6328 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6190] Custom field removal from patron entry screens

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190

Bug 6190 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327

Bug 9327 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326

Bug 9326 depends on bug 7167, which changed state.

Bug 7167 Summary: updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #225 from Jared Camins-Esakov  ---
I am closing this bug so that no one is tempted to use it for any follow-up
comments on this feature. Any issues encountered with the new non-linear
database updates need to be addressed on separate bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #224 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||9327

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9327] New: Database update system should provide utility function for adding sysprefs

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327

Bug ID: 9327
   Summary: Database update system should provide utility function
for adding sysprefs
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jcam...@cpbibliography.com
CC: gmcha...@gmail.com
Depends on: 7167

Right now in order to add sysprefs we use the dbh directly. Instead the
database update system should provide functions like
C4::Update::Database::AddSyspref and C4::Update::Database::RemoveSyspref for
adding and removing sysprefs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9326] New: New database update system suggests running duplicate updates

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326

Bug ID: 9326
   Summary: New database update system suggests running duplicate
updates
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jcam...@cpbibliography.com
CC: gmcha...@gmail.com
Depends on: 7167

When an update has been renamed, the new database update system suggests
running the duplicate update, even though when you tell it to go ahead and do
that, it informs you that it is a duplicate update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jared Camins-Esakov  changed:

   What|Removed |Added

 Blocks||9326

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9292] Remove dead code related to 'publictype'

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
   Patch complexity|--- |Trivial patch
   Severity|enhancement |minor

--- Comment #2 from Owen Leonard  ---
This patch should have a commit message which includes a description of the
problem, a description of the solution, and a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard  ---
Please provide a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9323] Untranslatable string in serials search

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #47 from Jonathan Druart  ---
(In reply to comment #46)
> (In reply to comment #44)
> > A quick start:
> > http://wiki.koha-community.org/wiki/Logger
> 
> It seems to me that ->debug calls *should* be included in code committed to
> Master. Isn't the entire point of the logger that it's possible to change
> your log level so that you can get all the debug information/all the
> warnings/info and errors/just errors/just critical errors?

Yes maybe. But developpers must be aware that too many debug message are not
relevant because logs would become too big and then unreadable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
There are still instances of "branch" instead of "library":

   choices:
 homebranch: 'home branch'
 holdingbranch: 'holding branch'

These instances should be changed to:

   choices:
 homebranch: 'home library'
 holdingbranch: 'holding library'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our session cookie

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9102

--- Comment #10 from Jonathan Druart  ---
(In reply to comment #9)
> (In reply to comment #8)
> > Bug 9102 : Followup Set HttpOnly on the CGISESSID cookie
> 
> Is there a way to test the follow-up like their was for Chris's patch?

I don't know...
I think if you don't have any error on some pages the patch works.
But if we have a doubt about this patch, we don't have to integrate it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9274] Software error in bibtex export

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
Please also resubmit your patch with a commit message which describes the
problem, describes the solution, and provides a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
This patch should have a commit message which includes a description of the
problem, a description of the solution, and a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9102] [SECURITY] We should set httponly on our session cookie

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9102

--- Comment #9 from Owen Leonard  ---
(In reply to comment #8)
> Bug 9102 : Followup Set HttpOnly on the CGISESSID cookie

Is there a way to test the follow-up like their was for Chris's patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8906] Improve OAI management interface

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14262|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 14299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14299&action=edit
[SIGNED-OFF] Bug 8906: Followup replace 'Clear' with 'Delete'

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8378

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] syntax not working on overdues anymore

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9325

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] syntax not working on overdues anymore

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #14069|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  ---
Comment on attachment 14069
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14069
Bug 8378: Fix overdue letter generation

New Bug created for this patch (Bug 9325)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

--- Comment #1 from Jonathan Druart  ---
Created attachment 14297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14297&action=edit
Bug 9325: Fix overdue letter generation

In overdue_notices.pl, letter template must not be passed to
parse_letter because this sub modifies it, so the first overdue letter
is ok but following letters have exactly the same content.
This patch make a copy of the template before passing it to parse_letter

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9325] New: overdue notices sent same messages for all users.

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325

Bug ID: 9325
   Summary: overdue notices sent same messages for all users.
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com

In overdue_notices.pl, letter template must not be passed to
parse_letter because this sub modifies it, so the first overdue letter
is ok but following letters have exactly the same content.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #46 from Jared Camins-Esakov  ---
(In reply to comment #44)
> A quick start:
> http://wiki.koha-community.org/wiki/Logger

It seems to me that ->debug calls *should* be included in code committed to
Master. Isn't the entire point of the logger that it's possible to change your
log level so that you can get all the debug information/all the warnings/info
and errors/just errors/just critical errors?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #45 from Katrin Fischer  ---
Hi Jonathan, thx for your work - still testing. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #44 from Jonathan Druart  ---
A quick start:
http://wiki.koha-community.org/wiki/Logger

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9315] Bad version of String::Random reported by koha_perl_deps.pl

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9315

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #76 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #14272|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9183] C4::Search should only have one ZOOM event loop

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9009] Add separate user js and css for SCO module

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9009

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9162] Add a system preference to set which notes fields appears on title notes/description separator

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #43 from Jonathan Druart  ---
(In reply to comment #41)
> I was also wondering about the 7 levels - do we have some more documentation
> how the different levels are supposed to be used? Maybe this is a standard
> Perl/Logging thing I am not aware of, but I think some more pointers in the
> POD or on a wiki page would be really helpful before we start using this all
> over Koha.

It is not easy to deal correctly with each level.
debug, warning and error are easy. But how to differentiate an error from a
critical message?
The choice is made from personal point of view and can vary for each kind of
bug. It is not easy to do an exhaustive wiki page for such stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #42 from Jonathan Druart  ---
Created attachment 14296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14296&action=edit
Bug 8190: FIX Unit test

Set the KOHA_LOG environment variable in the test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9324] New: Reserves cannot be deleted with DEBUG on under Plack

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9324

Bug ID: 9324
   Summary: Reserves cannot be deleted with DEBUG on under Plack
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jcam...@cpbibliography.com
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When I try to delete a reserve I get the following error:
DBD::mysql::st execute failed: Duplicate entry '10' for key 'PRIMARY' at
/home/jcamins/kohaclone/C4/Reserves.pm line 1081.DBD::mysql::st execute failed:
Duplicate entry '10' for key 'PRIMARY' at
/home/jcamins/kohaclone/C4/Reserves.pm line 1081. at
/home/jcamins/kohaclone/reserve/modrequest.pl line 91

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320

Owen Leonard  changed:

   What|Removed |Added

  Attachment #14278|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 14295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14295&action=edit
[SIGNED-OFF] Bug 9320 Pending reserves report should not show waiting items

Test plan : * chose an item reserved by multiple patrons.
* return the item and confirm reservation =>
  item is waiting to be picked up
* run circ/pendingreserves.pl
=> without patch, this item is shown in the list
=> with the patch, only really available items are show.

Signed-off-by: Owen Leonard 

Works according to test plan. The title with one waiting item appeared
in pending holds report before the patch, doesn't appear after the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #43 from Jared Camins-Esakov  ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #41 from Katrin Fischer  ---
Hi Jonathan,

thx for looking into this.

I have continued testing and found another problem. When you don't have the new
environment variable set, the test suite fails. The tests need to pass without
additional 'developer configuration'.

Can you please change the test? Maybe you can set the environment variable in
the test and use a writeable temporary file.

I am going set 'Failed QA' for this reason - please switch back to Signed Off
when the tests pass. 

There is also a little typo (Logguer) when you run the test with prove
t/Logger.t:
| You must call this test with a KOHA_LOG env var like: |
| KOHA_LOG="/tmp/t1.log" prove t/Logguer.t  |

I was also wondering about the 7 levels - do we have some more documentation
how the different levels are supposed to be used? Maybe this is a standard
Perl/Logging thing I am not aware of, but I think some more pointers in the POD
or on a wiki page would be really helpful before we start using this all over
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >